H" X-Original-To: Stable@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 833F430BB88 for ; Thu, 23 Oct 2025 10:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761215165; cv=none; b=oe9n2eZ+2exQrlNocKxWnGCeiBD9ofBn4Z4oNHLsnrmGiM2UP01fIngojsklhUv5BZKY0Y0ikyg5i+p0CHn+pYgJASEKeCLHfKvmy9Ps/f8CXaRaUKclOlqvBc5VIDcXGCvHKznCDm1J4QsUaz5rLbIj+H0OPNsTO7WeGAUj9DQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761215165; c=relaxed/simple; bh=n/QDHw1ITWRby7vrBcC4hapXZgt2KFZCOKf4tNRyaaA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F4q1T0bh775QZg1VdZpLhGe264vsgyQrrvSoGtfYYdzfBhlQMOAGOsrQdKQxONUJe7716jL+XYhxQzkRf2A7P/7AKcEciF+0OeeYtd3WRjxlo0kk3dWzY/wZ9MTDQyrEv6xpPeCxdAMHw8GEwiR21BxngCM4DgCU1ALo9EE6tdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ofp7nl/H; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59N76T0X029864 for ; Thu, 23 Oct 2025 10:26:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=jdyJtjan7SM H7wF51lvA8fxlxpPM+Q5el4ttALOfDg8=; b=ofp7nl/HBaXVLLvPU82S4U87eL6 Gy9EvPxlr17buAKxBAYQcnWxylx1Kg++K7y8RtBRTKCk3MLstr16HdN1ARN6pVcd 6RVXfXm0xPTCQGj/nALSmHn8Vhp9cjATvCuE6O0M0LXy+3TANJXVZWyvk18fC5yu DhnYPYKaIAXV4/YnAwL8b6PB0V4AKOQ8yxiNIrZbx1H4i4d1x4bL6mJYAmwgQa1A AfRV9HT8L7HoB1n3vE8Xr9iyfd+zhOYMtpboYGP+zNQ5WbHanUx0Qz8MYHuqnRCS +PnTudC3dlP+T7wAtvywk02KPHYcSn0Nvbasoqgqc+MFqSidEGwvkV9z9jA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v2ge80jq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 23 Oct 2025 10:26:01 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4e8b15de40fso31049151cf.1 for ; Thu, 23 Oct 2025 03:26:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761215160; x=1761819960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jdyJtjan7SMH7wF51lvA8fxlxpPM+Q5el4ttALOfDg8=; b=DCeP0QTrH/9vHvyl/DlMt9HuUD8bAHpsKINAv0WXDZcT6XbC9MCV9e6zl1NySXcWLo /N9PnBPyeiEUkmWpop/LFbUBvqbScxo87SGiFge0ClgfZu4XEr+I3n7DPZ9wmbRxiOcQ vgpexsdRX6sPILFYEZyxNeDz4nLZ08jVxdqOCLOcv5HK2IVb76YNG83ocZx+T6oZqR7+ 5HKppIIKYrlUvID8KcBF/PDA59RQUWppMO1UO3LUnbC2tWDUKeZkB1cpQFAC53v5xwT4 pjhfdEOH2dJMOtUbfvBwKdU2IjlspaTwJ8rzB61ykvKYAp45OW0de6Bkv87mH5Vk9wIl vYng== X-Forwarded-Encrypted: i=1; AJvYcCUSCgerYGb1ua3+XdRQuwDfQh5c5x4rlIbyoiOhD+MsWgF/OjJGLYP+GnWRj/6Q74cOIjvzGME=@vger.kernel.org X-Gm-Message-State: AOJu0YwzS9e3142enyJi2sMdD06MO8eD89fZbAp1xn3zMO1x2PZZsgAu yFlzXI1iXYahxOqbdDrl1aTcd5e/H2qzJYUPpG96GEkGLZDha7xbikRCWhucLr2zHYlmqmYcsB7 FRQEzRqYY9b/+/yURJf9yPxf8rW3mUkTbKFv7xieANsTurLMxvTCBQ6UYvqk= X-Gm-Gg: ASbGncuLZwIfHSQjDqqHsoZa4vDpmDEK53AdHhGgyTku8gd1ZQ15idHKsTFgsAIsRZh V/4UHTI163UXTjbNfnuZSpgOPEZjNl6SJq8ekELnTxWVKKEYNmZSRk/CoHqUpw1nSJW+96LEBFy HZHO0jtj6WYAGiofM9NViCUYavFsW5+JCLKmNitQkRi6DFtZC1EPNhBxYYe7fPWdpzApifM8fru wsfj00+eClwfWsu9wAwqYg21tvxOdw9khkS5vDAacitRHhOP7RjXohnNVw5G1dxXSJbnS7HfLip QH0JJ8KooBuzmqS/QafbXhUcqfBqMPsZUhglTyYZlmDW8p8s7GDgW5CC7/XfGs7QYKcFbNjueMS 4r0vL+4qEkfoy X-Received: by 2002:a05:622a:1827:b0:4e8:b8f7:299d with SMTP id d75a77b69052e-4e8b8f72eaamr207458381cf.68.1761215160567; Thu, 23 Oct 2025 03:26:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFD7wLSA44400aNfpBlMqCLaACZqamHhHypYbkYfQM4rxcD3dsHflxyufF1YmFN6YdHQzG4bA== X-Received: by 2002:a05:622a:1827:b0:4e8:b8f7:299d with SMTP id d75a77b69052e-4e8b8f72eaamr207458091cf.68.1761215160076; Thu, 23 Oct 2025 03:26:00 -0700 (PDT) Received: from debian ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c427f77bsm92220685e9.3.2025.10.23.03.25.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Oct 2025 03:25:59 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: perex@perex.cz, tiwai@suse.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla , Stable@vger.kernel.org, Alexey Klimov Subject: [PATCH v2 04/20] ASoC: qcom: q6asm-dai: perform correct state check before closing Date: Thu, 23 Oct 2025 11:24:28 +0100 Message-ID: <20251023102444.88158-5-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251023102444.88158-1-srinivas.kandagatla@oss.qualcomm.com> References: <20251023102444.88158-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMCBTYWx0ZWRfXwnygIno/vsGZ 1DvdKKT+5PfXFBLjQHW6qZ8cUp1jLhKP7txwTtXxEOCWKG4QkMj+OcV2h00WnSWZYlqGZYSCHbQ yHhBYAppoe1ILtlI8juPqxeoNfiVO5dLfRtHkUDAhoLzte6OWP4BJP7mEWovVJQX6R17S92wyDh nhlxvx59BD+gFH9EBOI0j3nWHcblB/J254DKkBv6i/mEun2MyadHFHN41KWEh8P+EcejN+KYfU3 91kANcommqsJhfa3fLyPpYUQ51lOgzlc8Xd/LXzSG6N625smmlBWf5OTbeFf8ef63Z2DCfZK3qi OX2frW9hgJRr7xuESbj4ep+ZwL5cw+9WUrDuZYjFr+8Muwk/46h/VFrJ/Pz617I5h+zTZkAtrno f7kplwl83hjx2S3CjhsRlmbop7Orkw== X-Authority-Analysis: v=2.4 cv=KqFAGGWN c=1 sm=1 tr=0 ts=68fa02b9 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=MOmvoJmQv4oe-d1MVI8A:9 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: aUn5U7I29hwq9oow29kOd5sHEvmlQ124 X-Proofpoint-ORIG-GUID: aUn5U7I29hwq9oow29kOd5sHEvmlQ124 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_08,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180020 X-DKIM: signer='qualcomm.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 4.1 (++++) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (4.1 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: qualcomm.com] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [5.133.47.210 listed in zen.spamhaus.org] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [142.0.200.124 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 41 Do not stop a q6asm stream if its not started, this can result in unnecessary dsp command which will timeout anyway something like below: q6asm-dai ab00000.remoteproc:glink-edge:apr:service@7:dais: CMD 10bcd timeout Fix this by correctly checking the state. Fixes: 2a9e92d371db ("ASoC: qdsp6: q6asm: Add q6asm dai driver") Cc: Signed-off-by: Srinivas Kandagatla Tested-by: Alexey Klimov # RB5, RB3 --- sound/soc/qcom/qdsp6/q6asm-dai.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c index e8129510a734..0eae8c6e42b8 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -233,13 +233,14 @@ static int q6asm_dai_prepare(struct snd_soc_component *component, prtd->pcm_count = snd_pcm_lib_period_bytes(substream); prtd->pcm_irq_pos = 0; /* rate and channels are sent to audio driver */ - if (prtd->state) { + if (prtd->state == Q6ASM_STREAM_RUNNING) { /* clear the previous setup if any */ q6asm_cmd(prtd->audio_client, prtd->stream_id, CMD_CLOSE); q6asm_unmap_memory_regions(substream->stream, prtd->audio_client); q6routing_stream_close(soc_prtd->dai_link->id, substream->stream); + prtd->state = Q6ASM_STREAM_STOPPED; } ret = q6asm_map_memory_regions(substream->stream, prtd->audio_client, -- 2.51.0 From - Thu Oct 23 10:27:36 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id oL1wJxUD+mjenRUAYBR5ng (envelope-from ) for ; Thu, 23 Oct 2025 10:27:33 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Thu, 23 Oct 2025 10:27:33 +0000 Received: from dfw.mirrors.kernel.org ([142.0.200.124]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vBsXd-00000006H11-1k1p for hi@josie.lol; Thu, 23 Oct 2025 10:27:33 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.mirrors.kernel.org (Postfix) with ESMTPS id EC65C4F85F1 for ; Thu, 23 Oct 2025 10:27:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C93AD30C62F; Thu, 23 Oct 2025 10:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bHD3C6ag" X-Original-To: Stable@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9F0230C364 for ; Thu, 23 Oct 2025 10:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761215167; cv=none; b=TChiVwdr1BHgF82XFyNJZ2jMLQVWq9jwdXgWokhJWz9H3m3bSdpFUzKRQUURV5lsAd5vrM/gAtVwQr2OitStAJVJBJX4yh1sWjXuA7TwnXhWbkKIAKAAB4Jnkk0IKb+FGjguYc3CHd4S2ZvlIRabj5o1vwnhPOwka8lAk9ZW1m8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761215167; c=relaxed/simple; bh=+pEzU2CaP92P+tjHZGLYMYsO+p/lLdluRH2vfoyibvo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d7kFHhbEcMv4j5OUI7Qr24GG7HJnqVPW4eaiCBdaHQv5T6Z//rQQ23wsKi7+CWkBhHHfpSsPBL8r4uY24dgFRxRbcPtrngvjix+pP06QlRVxD9H78xvH2qpYnA/J1Y7ZaMzDBpTPNPN+KlCmNXBqKJLlOH+JflT+0EkagLxd5A0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bHD3C6ag; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59N6ZRVh007464 for ; Thu, 23 Oct 2025 10:26:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=hugy+iqvLUJ 2cjxOk55z+UZwKkAMqHXBccnGqDcDbTE=; b=bHD3C6agXJdHa6WOJPjq+k2cj2e Efmk65n6JaL9JQox4iXtAsYb3tUz5HRd2dNh03JvSMyQtls+BNIfRxZvW4HZAJRN R/FJ1hCidjA/3meuFLicg/UNMQ7U9Hl3/IAndNM5JK3dzuRD1j72gruOQv35jdmu OuhMW7b3Qrc1CjZIIj4YzBEyseY7jF12jWxMzgjlqUafKIFybYBXHImFYPxZGQIV y8IuxH5luwGauiSOSHgMs7FaHx1Qa/aoLVJo/igQJXK8wrT775Rh+9qYj8uK0nEK 0rbJlfPmxx/QSNrZAMeuf/9hUSQqtBJpVarEDIJtLDgCr2LFJpCfLwAJI+g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v344839h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 23 Oct 2025 10:26:05 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4e8a13eedecso18075291cf.0 for ; Thu, 23 Oct 2025 03:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761215164; x=1761819964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hugy+iqvLUJ2cjxOk55z+UZwKkAMqHXBccnGqDcDbTE=; b=WL04SfRJxOaFb7YJq4QIO4rCLUOvCcrMgo+kswzUzsfSAjJym4qp31Df2ShUqki6GM CtbkyDJi4DjCHTgCsI316MNBc9MIiNkMUa1ltp0o/ypLONgd88Pp0VJy+YZsPgZTPCOQ 8vpx2QZQAr5WtwHWTU1UP4BYIVbqrycJkZ1qD5QGBef9OqvwapgiGSI73BhFFGPtdBcn x1/XjERKRDcMW179lGCZYs9kNPWd+dUaI0QbsTM5SEkSg3usYMRIn3hoAkUT0ZU05ZXm n3a5VfpPu5U7z2e8N2AR4XWwNt6yFG71gJ8iuz2vY+w5MWTQWFetNoA41S/vGelgZbD0 0Omg== X-Forwarded-Encrypted: i=1; AJvYcCUngg0rFhAtaAzpzJvxlzUN+PR0lJCISRAEI32+57WtKO5B6opN1ZOqjb7j1K0uD8Jci3DjYIk=@vger.kernel.org X-Gm-Message-State: AOJu0YyfhaYkHIfSH7wXNWD/JADgJHqd/5pR/gYUp7rYtxlbeW25ZTWF aTPnPK8UvuiWoO2yAukEQZhm/HnAXYUwqmciYQVSOs4bT2RLyz3viVCamryMKOybN57uP/LIfda o3x2oPBBgiQZxrFFAlsyhrIValPjklRyQ8Dbi8HL3tM/OtqMnGCcVWz4qtDs= X-Gm-Gg: ASbGncst1ZASIKGlOeonn/vhGngD/4k/W4GkxcBj/lGNjqFHqdsBW0Ckw7Ka4fvRNe9 uTXibrTJSCmep6KyKeHgtJ/AboS2uYa7fpiXOq84KKWTH7EwztAiWhjX/ANOOgUtYWJNA8uQVa6 RV3G9SI7GGbEMwduoeuushrPelXyINoEjkgM1qjIjINGtcn+kzRUuvQvHfxlztliVYlMx6cX/PC auDUk11plcEDqtjqckYsA7xOrWajbyVVJZhdP4eCK037YSRrHZCl5gaT9xpyWBlSy0Nw0g0zqP3 cIC29epPxA06aE90kQ8fJEQyx3XCpkg+tnijF5iCO55mrgkCpjhyuEFsQZrMmPE4HmaYmsbJLaE QcvFH0yXEJXg0 X-Received: by 2002:a05:622a:d:b0:4e8:b669:990 with SMTP id d75a77b69052e-4e8b6690c9emr204363201cf.22.1761215163713; Thu, 23 Oct 2025 03:26:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbFZ/aAh022rvOoagwONZHMEh0MEWdYvgy0BQ8CSY0tqtrarJPhK0oSiMEE6Ys8biKzppMkQ== X-Received: by 2002:a05:622a:d:b0:4e8:b669:990 with SMTP id d75a77b69052e-4e8b6690c9emr204361541cf.22.1761215158490; Thu, 23 Oct 2025 03:25:58 -0700 (PDT) Received: from debian ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c427f77bsm92220685e9.3.2025.10.23.03.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Oct 2025 03:25:58 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: perex@perex.cz, tiwai@suse.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla , Stable@vger.kernel.org, Alexey Klimov Subject: [PATCH v2 03/20] ASoC: qcom: qdsp6: q6asm-dai: set 10 ms period and buffer alignment. Date: Thu, 23 Oct 2025 11:24:27 +0100 Message-ID: <20251023102444.88158-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251023102444.88158-1-srinivas.kandagatla@oss.qualcomm.com> References: <20251023102444.88158-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: p6GDDxYufU6VntlgOnWWQ-w7fUSzZf-r X-Proofpoint-ORIG-GUID: p6GDDxYufU6VntlgOnWWQ-w7fUSzZf-r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMyBTYWx0ZWRfXyuq8a8vVu6zc XFPuPBvKHQ/EzWmKjh3uEq9SOAjTkQ9eExDczpw2/AHRzJTcaG/WczmypAqTzQsoAFzYNF+1gi6 js4IhJtu6LB6YlBjuF587WPXcPw2Ht8wo+feS+P5jx/Ltey1pQ58EgpE/Pj+kFHXudPHytnzLFp 6gW8lsM+po85O/bgzxN3UhYWCZjfa/TfEuM+pqC04SHHKpKyOX4yw29H7TjxSqAUzbJs5fAwc8M dzAi6KCDLJH48LcRkMOgRng3haYmCetn39eM5ppHc93jrfPgkd0XLZYRL632bfxImBGwNQkfkd0 AtuzzopxiB+0yKQJxVdGZ9D8HlLMV6tWWnBmxelAs+fi5PY7PazLVAZerlxAZ5qWBsuvVrj0jVh w8fdf271lG09EkcfT31D0NFyx2v4vQ== X-Authority-Analysis: v=2.4 cv=E/vAZKdl c=1 sm=1 tr=0 ts=68fa02bd cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Ubk33e6zxpvlPXQfVdEA:9 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_08,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180023 X-DKIM: signer='qualcomm.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: qualcomm.com] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 DSP expects the periods to be aligned to fragment sizes, currently setting up to hw constriants on periods bytes is not going to work correctly as we can endup with periods sizes aligned to 32 bytes however not aligned to fragment size. Update the constriants to use fragment size, and also set at step of 10ms for period size to accommodate DSP requirements of 10ms latency. Fixes: 2a9e92d371db ("ASoC: qdsp6: q6asm: Add q6asm dai driver") Cc: Signed-off-by: Srinivas Kandagatla Tested-by: Alexey Klimov # RB5, RB3 --- sound/soc/qcom/qdsp6/q6asm-dai.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c index b616ce316d2f..e8129510a734 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -403,13 +403,13 @@ static int q6asm_dai_open(struct snd_soc_component *component, } ret = snd_pcm_hw_constraint_step(runtime, 0, - SNDRV_PCM_HW_PARAM_PERIOD_BYTES, 32); + SNDRV_PCM_HW_PARAM_PERIOD_SIZE, 480); if (ret < 0) { dev_err(dev, "constraint for period bytes step ret = %d\n", ret); } ret = snd_pcm_hw_constraint_step(runtime, 0, - SNDRV_PCM_HW_PARAM_BUFFER_BYTES, 32); + SNDRV_PCM_HW_PARAM_BUFFER_SIZE, 480); if (ret < 0) { dev_err(dev, "constraint for buffer bytes step ret = %d\n", ret); -- 2.51.0 From - Thu Oct 23 10:32:54 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id aN50ElME+mj6CxYAYBR5ng (envelope-from ) for ; Thu, 23 Oct 2025 10:32:51 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Thu, 23 Oct 2025 10:32:51 +0000 Received: from dfw.mirrors.kernel.org ([142.0.200.124]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vBsck-00000006SRV-44XD for hi@josie.lol; Thu, 23 Oct 2025 10:32:51 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.mirrors.kernel.org (Postfix) with ESMTPS id A95054E578B for ; Thu, 23 Oct 2025 10:31:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 087C730C629; Thu, 23 Oct 2025 10:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DYrAgg0M" X-Original-To: stable@vger.kernel.org Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.c