DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [139.178.88.99 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 On Mon, Oct 06, 2025 at 04:13:26PM -0700, Manivannan Sadhasivam wrote: > On Mon, Oct 06, 2025 at 02:33:33PM -0500, Bjorn Helgaas wrote: > > On Mon, Oct 06, 2025 at 11:32:38AM -0700, Brian Norris wrote: > > > Some PCI drivers call pci_set_power_state(..., PCI_D3hot) on their own > > > when preparing for runtime or system suspend, so by the time they hit > > > pci_finish_runtime_suspend(), they're in D3hot. Then, pci_target_state() > > > may still pick a lower state (D3cold). > > > > We might need this change, but maybe this is also an opportunity to > > remove some of those pci_set_power_state(..., PCI_D3hot) calls from > > drivers. > > > > Agree. The PCI client drivers should have no business in opting for D3Hot in the > suspend path. I dunno. There are various reasons a device might want to go to D3Hot some time before fully suspending the system, and possibly even before runtime suspend (or they may not support runtime PM at all). For example, on the first step on my alphabetical trawl through git grep -l '\' drivers/ I found a driver that supports some power-toggling via debugfs, in drivers/accel/habanalabs/common/debugfs.c. It would take nontrivial effort to evaluate every case like that for removal. BTW, we even have documentation for this: https://docs.kernel.org/power/pci.html#suspend "However, in some rare case it is convenient to carry out these operations in a PCI driver. Then, pci_save_state(), pci_prepare_to_sleep(), and pci_set_power_state() should be used to save the device's standard configuration registers, to prepare it for system wakeup (if necessary), and to put it into a low-power state, respectively." So sure, it should be rare (like the docs say), and it's probably redundant in many cases, but I'm not that interested in shaving various drivers' yaks right now. I'm just fixing a (small) performance regression in documented behavior. > It should be the other way around, they should opt-out if they > want by calling pci_save_state(), but that is also subject to discussion. FWIW, that's also documented in the above link. Brian From - Mon Oct 13 22:21:54 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 8J4AOYB77WgNPy8AYBR5ng (envelope-from ) for ; Mon, 13 Oct 2025 22:21:52 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Mon, 13 Oct 2025 22:21:52 +0000 Received: from am.mirrors.kernel.org ([147.75.80.249]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1v8QvQ-0000000D0mQ-266B for hi@josie.lol; Mon, 13 Oct 2025 22:21:52 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384