gative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // While here, replace strlen()+kmemdup() to kstrdup(). Signed-off-by: Peter Senna Tschudin Reviewed-by: walter harms Signed-off-by: Mauro Carvalho Chehab £-ثن