ners can time out or not complete subflow setup before data transfer finishes. Slowing writes increases the window for address signaling and subflow establishment, improving determinism. This aligns with existing practice elsewhere in the script where many subtests already run with `speed=slow` for similar reasons (e.g., numerous `speed=slow` calls throughout the file). - Scope and risk: - Test-only: Changes are confined to `tools/testing/selftests/net/mptcp/mptcp_join.sh` and do not touch kernel code paths or ABIs. - Minimal and contained: Two call sites adjusted; no logic or expectations changed, only pacing. - Low regression risk: Only increases runtime slightly for two subtests; expected counts remain the same (e.g., still `chk_join_nr 3 3 3` and `chk_add_nr 3 3` in tools/testing/selftests/net/mptcp/mptcp_join.sh:2273-2274; and unchanged checks after the invalid addresses case at 2286-2288). - Stable-policy fit: - Fixes test flakiness affecting CI/users running stable selftests (practical impact for validation). - No new features or architectural changes; very small diff; conforms to stable rules for low-risk test fixes. - No “Cc: stable” tag, but the change is a clear reliability fix for selftests, which stable trees commonly accept to keep test suites meaningful. Given it’s a tiny, isolated selftest reliability improvement with no kernel-side risk and tangible benefit for CI stability, it is suitable for backporting. tools/testing/selftests/net/mptcp/mptcp_join.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh index 8e92dfead43bf..fed14a281a6d9 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -2151,7 +2151,8 @@ signal_address_tests() pm_nl_add_endpoint $ns1 10.0.3.1 flags signal pm_nl_add_endpoint $ns1 10.0.4.1 flags signal pm_nl_set_limits $ns2 3 3 - run_tests $ns1 $ns2 10.0.1.1 + speed=slow \ + run_tests $ns1 $ns2 10.0.1.1 chk_join_nr 3 3 3 chk_add_nr 3 3 fi @@ -2163,7 +2164,8 @@ signal_address_tests() pm_nl_add_endpoint $ns1 10.0.3.1 flags signal pm_nl_add_endpoint $ns1 10.0.14.1 flags signal pm_nl_set_limits $ns2 3 3 - run_tests $ns1 $ns2 10.0.1.1 + speed=slow \ + run_tests $ns1 $ns2 10.0.1.1 join_syn_tx=3 \ chk_join_nr 1 1 1 chk_add_nr 3 3 -- 2.51.0[PATCH AUTOSEL 6.17-6.12] selftests: mptcp: join: allow more time to send ADD_ADDRSasha Levin undefinedpatches@lists.linux.dev, stable@vger.kernel.org undefined undefined undefined undefined undefined undefined undefined undefined/y