1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=kAxInnwr; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b727f452fffso306392966b.1 for ; Thu, 27 Nov 2025 03:17:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1764242224; x=1764847024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GJVJA3oiVaBETKowUaWc1AtovR4cPiTo2+ur0NTpWtI=; b=kAxInnwrzrbnyQi6iANFodU1cLRlU5o8Hq3LYIw2UD02KUadQxIHmHbfu9SHvYJ5fn pvMIciZFq9JAAf4z44q/8yZydFiTurBGfzZ/2N3Fi7BCGCyvGtoJdCm702lCQ1YHAdrT BqOpHtCPLnVj7E/FsE/XcelPL/Pv4mAQKTI98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764242224; x=1764847024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GJVJA3oiVaBETKowUaWc1AtovR4cPiTo2+ur0NTpWtI=; b=N8ihvLhx+AlRLnuPD2O5rcdUDTHmh7MjqyMEHDlYUaCDIXPKR1PVBrET2Ifa5ygX6E OVZ7tA4spTi52X1os1EyxCjc4MGZywgtkJ+7hAZ3kiOh1fuOyIzWrLpz2Xa+ml9+0tVs rNPhi5LGOAFk7RSc7zii6Y+6Js1KKcuMOyuZQEepkRJWea/0HkPxJ26Ygl816JxScgq0 ifpXwn9g4YylIEGk7BChIi31v6arJGc5cdDgjMWedELN8nXLobtjfNInKHllAfAtzSbf fJsh9saYvEdBfaynmiNKgm3ZJeKHwq9njO6i0yzXLeOEPcFkWdAUyZ2Y3hPuz2u0a3TM Onbw== X-Forwarded-Encrypted: i=1; AJvYcCUIfxT7L5whYHlzPlt/83erdTdTkub/ffeTsuD1vL6sDpuRBVXlPpizUAw8pAD7F/E3lN4zjGg=@vger.kernel.org X-Gm-Message-State: AOJu0YxrB5osef5d2qBdUr8Ji2TWQeMfUIoelPpdyJt/yaWLWCc9cQhZ 5aeTc4Y1A5Naqr/Dlpd7ZJJ39myKxbJR7azsKsNrLKNmuTGWpPWMrGKYezIskuZY X-Gm-Gg: ASbGncuvESRDGBx2qcXlmNbpHH9xdujN4+gNq5qgBDiXIxHuXViK2hDUkOHg6jRoMtv d3fkEFEAcRBl4uaWBinSXlbcPgM4EdsdBrpEirdcuavrce1HiIyqdEQzE6Yz3Jiun+az269xMQE G2cMbiLt3b7VbSlD0/GJLH5sgH1kyyj0uKIFwHJaWm7LafkdFsuDTT4v55YFc4PmSLHZPRCZ0fN ZgR3LY36hzMat0WH9s+VdF2kDN56RVKWUJMQ1UUYLPhFoFIgh4lFqSAQFU/WIXINr6+62DhRZUK YWAN6sAeQFJ7TnI9SmHhnc7fwUWEV3e+yqhXVnHM+WjisNh4n4t07NbpRc8YMw2uzzCdXAF5rSM SbfSls4JUIrvPM5mbKgjlF/9TQTWTWSpJUSsSDAd2qg7pwBXVCTRj+tpFtbzelaBux48F+ntRoi zwCNNcpVmQJ9D3m51hSVQla+xm5W3w7tPjKNQSl7C6pRkn9z2Y+m08ats2eTsb62A= X-Google-Smtp-Source: AGHT+IE+huPMKVkx99Dz9smUQr+C4LOMabu9B98nf9uQG/iI4ndCFTmSTFC7MWlwCN2ZTQviKYWA0w== X-Received: by 2002:a17:907:7246:b0:b3a:8070:e269 with SMTP id a640c23a62f3a-b766ef1d667mr2775997566b.14.1764242224446; Thu, 27 Nov 2025 03:17:04 -0800 (PST) Received: from januszek.c.googlers.com.com (5.214.32.34.bc.googleusercontent.com. [34.32.214.5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a48c7bsm131702266b.64.2025.11.27.03.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 03:17:04 -0800 (PST) From: "=?UTF-8?q?=C5=81ukasz=20Bartosik?=" X-Google-Original-From: =?UTF-8?q?=C5=81ukasz=20Bartosik?= To: Mathias Nyman , Greg Kroah-Hartman , Jiri Slaby Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] xhci: dbgtty: fix device unregister: fixup Date: Thu, 27 Nov 2025 11:16:44 +0000 Message-ID: <20251127111644.3161386-1-ukaszb@google.com> X-Mailer: git-send-email 2.52.0.487.g5c8c507ade-goog Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-DKIM: signer='chromium.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-2.1 points) --- pts rule name description ---- ---------------------- ----------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [139.178.88.99 listed in list.dnswl.org] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: chromium.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -20 From: Łukasz Bartosik This fixup replaces tty_vhangup() call with call to tty_port_tty_vhangup(). Both calls hangup tty device synchronously however tty_port_tty_vhangup() increases reference count during the hangup operation using scoped_guard(tty_port_tty). Cc: stable@vger.kernel.org Fixes: 1f73b8b56cf3 ("xhci: dbgtty: fix device unregister") Signed-off-by: Łukasz Bartosik Link: https://lore.kernel.org/stable/20251127101904.3097504-1-ukaszb%40google.com --- Changes in V2: - Added CC: stable@vger.kernel.org --- drivers/usb/host/xhci-dbgtty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c index 57cdda4e09c8..90282e51e23e 100644 --- a/drivers/usb/host/xhci-dbgtty.c +++ b/drivers/usb/host/xhci-dbgtty.c @@ -554,7 +554,7 @@ static void xhci_dbc_tty_unregister_device(struct xhci_dbc *dbc) * Hang up the TTY. This wakes up any blocked * writers and causes subsequent writes to fail. */ - tty_vhangup(port->port.tty); + tty_port_tty_vhangup(&port->port); tty_unregister_device(dbc_tty_driver, port->minor); xhci_dbc_tty_exit_port(port); -- 2.52.0.487.g5c8c507ade-goog From - Thu Nov 27 11:25:09 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id QGPzIhE1KGmufDUAYBR5ng (envelope-from ) for ; Thu, 27 Nov 2025 11:25:05 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Thu, 27 Nov 2025 11:25:05 +0000 Received: from dfw.mirrors.kernel.org ([142.0.200.124]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vOa7V-0000000FZ9X-01yo for hi@josie.lol; Thu, 27 Nov 2025 11:25:05 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.mirrors.kernel.org (Pososie.lol@vger.kernel.org>) id 1vOZcX-0000000EWM0-3DA6 for hi@josie.lol; Thu, 27 Nov 2025 10:53:06 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.mirrors.kernel.org (Postfix) with ESMTPS id 4314634AD20 for ; Thu, 27 Nov 2025 10:53:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 647F532AAB3; Thu, 27 Nov 2025 10:52:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ebh8MeRI"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="CCShTgGL"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ebh8MeRI"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="CCShTgGL" X-Original-To: linux-s390@vger.kernel.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 453CC315D3E for ; Thu, 27 Nov 2025 10:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764240778; cv=none; b=pGx3xhSHLRuD15+AfZLFykMZK12WqxkhSXKPe6M+v+z5L5x4LF1A2wY+PlMWzomdau7/8zBjvyxM0En7sKvDnN7Vo8JVmyCKe6JpHQy07HCSYjIBHKzYKdTBZbpPdraT9oP5di5dj0qHQz36VeGpYNBsj+Ip341Qvhs3ZOfXacw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764240778; c=relaxed/simple; bh=lmIpG/6wpMPGrn8UHtJLjo9/YEqgWiovYbOwMFrcwDI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t5iHb4tIgbSxXD2qwdXcl38Rz1MEbCsN08Yhcj8ekFHA+SJO4tsgMPFaHp9L1eG4EhvJVZqIwjW5AKeJpu5yIdL2OMA3CnJlKuVIja/vQT3XlyvGqnoTw+CwU2EDfBD99Hj+jFkrnMEI3jiW0XKHK50mDYi7S+CbonktF/Yw/5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ebh8MeRI; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=CCShTgGL; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ebh8MeRI; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=CCShTgGL; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8060E5BCCE; Thu, 27 Nov 2025 10:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764240774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dSkfS1PH0V2GqQ7JwCU589oUysx1YAYg5wc2qE7DJO8=; b=ebh8MeRIbzXXS4nlvQHeE6b19GwtbYkg18vQvDryICee/hUE4994i2zgnpMFUBIthYG3nU UBJRzc8F+GLXPmMIeEIu6lcKDO+GuS5r4t3R24vLkBwrUcZBDFHcekbZBzLjpj2fMJFncP AMexocPLs/1FOCJ4ElPh9GDrDvtUkmg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764240774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dSkfS1PH0V2GqQ7JwCU589oUysx1YAYg5wc2qE7DJO8=; b=CCShTgGLpH2iP4/uFPeSXXOQ7YG9AKQXx7Q/6PY7ZXom3Et/ho3asQQ/5oScgUFip56eSH p9FRhoNDdKZxDyBw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764240774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dSkfS1PH0V2GqQ7JwCU589oUysx1YAYg5wc2qE7DJO8=; b=ebh8MeRIbzXXS4nlvQHeE6b19GwtbYkg18vQvDryICee/hUE4994i2zgnpMFUBIthYG3nU UBJRzc8F+GLXPmMIeEIu6lcKDO+GuS5r4t3R24vLkBwrUcZBDFHcekbZBzLjpj2fMJFncP AMexocPLs/1FOCJ4ElPh9GDrDvtUkmg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764240774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dSkfS1PH0V2GqQ7JwCU589oUysx1YAYg5wc2qE7DJO8=; b=CCShTgGLpH2iP4/uFPeSXXOQ7YG9AKQXx7Q/6PY7ZXom3Et/ho3asQQ/5oScgUFip56eSH p9FRhoNDdKZxDyBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B0C7F3EA63; Thu, 27 Nov 2025 10:52:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xrDGJ4ItKGlFNgAAD6G6ig (envelope-from ); Thu, 27 Nov 2025 10:52:50 +0000 Date: Thu, 27 Nov 2025 10:52:49 +0000 From: Pedro Falcato To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Oven Liyang , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Matthew Wilcox , Jarkko Sakkinen , Oscar Salvador , Kuninori Morimoto , Mark Rutland , Ada Couprie Diaz , Robin Murphy , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Kevin Brodsky , Yeoreum Yun , Wentao Guan , Thorsten Blum , Steven Rostedt , Yunhui Cui , Nam Cao , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song Subject: Re: [RFC PATCH 1/2] mm/filemap: Retry fault by VMA lock if the lock was released for I/O Message-ID: <5by7tko4v3kqvvpu4fdsgpw42yl5ed5qisbaz3la4an52hq4j2@v75fagey6gva> References: <20251127011438.6918-1-21cnbao@gmail.com> <20251127011438.6918-2-21cnbao@gmail.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251127011438.6918-2-21cnbao@gmail.com> X-Spam-Flag: NO X-Spam-Score: -7.80 X-Spam-Level: X-Spamd-Result: default: False [-7.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[gmail.com]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[linux-foundation.org,kvack.org,oppo.com,armlinux.org.uk,arm.com,kernel.org,xen0n.name,linux.ibm.com,ellerman.id.au,gmail.com,csgroup.eu,dabbelt.com,eecs.berkeley.edu,ghiti.fr,linux.intel.com,infradead.org,linutronix.de,redhat.com,alien8.de,zytor.com,oracle.com,suse.cz,google.com,suse.com,suse.de,renesas.com,uniontech.com,linux.dev,goodmis.org,bytedance.com,lists.infradead.org,vger.kernel.org,lists.linux.dev,lists.ozlabs.org,tencent.com,huaweicloud.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_GT_50(0.00)[66]; MISSING_XM_UA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[oppo.com:email,imap1.dmz-prg2.suse.org:helo] X-DKIM: signer='suse.de' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: suse.de] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [213.196.21.55 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On Thu, Nov 27, 2025 at 09:14:37AM +0800, Barry Song wrote: > From: Oven Liyang > > If the current page fault is using the per-VMA lock, and we only released > the lock to wait for I/O completion (e.g., using folio_lock()), then when > the fault is retried after the I/O completes, it should still qualify for > the per-VMA-lock path. > > Signed-off-by: Oven Liyang > Signed-off-by: Barry Song > --- > arch/arm/mm/fault.c | 5 +++++ > arch/arm64/mm/fault.c | 5 +++++ > arch/loongarch/mm/fault.c | 4 ++++ > arch/powerpc/mm/fault.c | 5 ++++- > arch/riscv/mm/fault.c | 4 ++++ > arch/s390/mm/fault.c | 4 ++++ > arch/x86/mm/fault.c | 4 ++++ If only we could unify all these paths :( > include/linux/mm_types.h | 9 +++++---- > mm/filemap.c | 5 ++++- > 9 files changed, 39 insertions(+), 6 deletions(-) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index b71625378ce3..12b2d65ef1b9 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -1670,10 +1670,11 @@ enum vm_fault_reason { > VM_FAULT_NOPAGE = (__force vm_fault_t)0x000100, > VM_FAULT_LOCKED = (__force vm_fault_t)0x000200, > VM_FAULT_RETRY = (__force vm_fault_t)0x000400, > - VM_FAULT_FALLBACK = (__force vm_fault_t)0x000800, > - VM_FAULT_DONE_COW = (__force vm_fault_t)0x001000, > - VM_FAULT_NEEDDSYNC = (__force vm_fault_t)0x002000, > - VM_FAULT_COMPLETED = (__force vm_fault_t)0x004000, > + VM_FAULT_RETRY_VMA = (__force vm_fault_t)0x000800, So, what I am wondering here is why we need one more fault flag versus just blindly doing this on a plain-old RETRY. Is there any particular reason why? I can't think of one. I would also like to see performance numbers. The rest of the patch looks OK to me. -- Pedro From - Thu Nov 27 11:00:38 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id OEUIJVIvKGnppjUAYBR5ng (envelope-from ) for ; Thu, 27 Nov 2025 11:00:34 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Thu, 27 Nov 2025 11:00:34 +0000 Received: from sv.mirrors.kernel.org ([139.178.88.99]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vOZjk-0000000El1J-1kPq for hi@josie.lol; Thu, 27 Nov 2025 11:00:34 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3D8F93B035F for ; Thu, 27 Nov 2025 11:00:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A120132C33D; Thu, 27 Nov 2025 11:00:17 +0000 (UTC) X-Original-To: stable@vger.kernel.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86C05329C6E; Thu, 27 Nov 2025 11:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764241217; cv=none; b=FRpk6mw0J8II0opEegltrGrpFcvZhFZPD+EyHRcH+OE6hn6D8af61osQpgdDERw+cPJ8DNdm2PL3oD+Y8UCTX2H9thPmJvKIWQr13uige8NxOtALe1sTVGZyPYL4RIvinEZZQEwyroJ0x3LtmbMULGxnxNjq3PFGqlA5WqSSoAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764241217; c=relaxed/simple; bh=DrtuUmq2hDhyefwbu7US/QbXPT7foSEpjDXflbiHEIE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sggclovIRUVg7ThElvk8iKrxypxuKZ4dzVpxUU/sFZjrzY8YaxWNkxnWEHo/cTC98FrIZQu8A50UAJ/r1O6nSVV3XsL3aEu3Mh6k/DEYzJd2ZIMf2046/TVS9bVfxz2DiG334z6jw4iyRabB0XoxdD9kEtMoBI93VR3/I2YOhf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailf