.lore.kernel.org (Postfix) with ESMTP id 105BA300D94B for ; Fri, 27 Feb 2026 09:16:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 32E593290DA; Fri, 27 Feb 2026 09:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Cd5eNvP2" X-Original-To: stable@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC4231618B; Fri, 27 Feb 2026 09:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772183794; cv=fail; b=V/2aX3Qs76UAn0rmIiLukLBcuBFovJ44yRZdgDS49gQFAD3ffKScA6MWMPCBJ+tiURdh3C1rwjiXzdgHOLLRUHj9E9GUZ6/KrNjB72zEKxbuF1+GrJyIeDX36zzyPjVQ9ovTLJKtXwigmx4k1MgfoyvCe0hlNE1paDUYGgEmDHA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772183794; c=relaxed/simple; bh=JxP3R9JAyDqc+Tp0PbNAnGIxQ/x3lsnnkBFbH3B3PKU=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=uIg6Cq9nXNzXYuipFNidxA9bc5XASNlFu517SyaIsGzG5+AuhbwKdfRaynStoML092lKx6Zexf3zKllPWprXGUN+ctR5EWO2WT7x7l6zdUjm44WphH6PAP3U8q9SwKfl6jelC9z+oGmDztpteqAwteuTGpKsTs6ygu1h6GqBu1E= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Cd5eNvP2; arc=fail smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772183791; x=1803719791; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=JxP3R9JAyDqc+Tp0PbNAnGIxQ/x3lsnnkBFbH3B3PKU=; b=Cd5eNvP2dezphdvTvLjJIITbdT5ZGbbkCgCVrSBTj4s3tM1r5Q9do9Zj c5IIZBazvPQkqJzpYg1jsDTvoxK/0vwiA2Hid5Brd3IiPQcla6KjxqjYH bauOXRoIi+XtHJ8Iev2h7XC76Ikes4xDDThOImzxBUEFm0zHG8QSUpU2C BtccOy/LZcLMBNbRzgzMAffAGJhg90vcieT+b4YR1QWuNMWQ+c1jqa4pg RHHcFECQdZpfoQK83l/nzUlXResaAsswJKsXzqTPnDO328ZjF71REqzA0 ldTPGBM0WE2nlQzsExxBvDP6RW8KK+esXZoWeFApo56tjNDHxaE5diqQB g==; X-CSE-ConnectionGUID: ZPR34+wVQHSQr9Qsnx+qTg== X-CSE-MsgGUID: ql/w8xq2S/+8nS+ufBe2cg== X-IronPort-AV: E=McAfee;i="6800,10657,11713"; a="73231621" X-IronPort-AV: E=Sophos;i="6.21,313,1763452800"; d="scan'208";a="73231621" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2026 01:16:31 -0800 X-CSE-ConnectionGUID: Pg19nqMlRfeThL/LZ3IlKQ== X-CSE-MsgGUID: B97QlnUVTxiQmLOJmdawFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,313,1763452800"; d="scan'208";a="244257690" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2026 01:16:31 -0800 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Feb 2026 01:16:30 -0800 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 27 Feb 2026 01:16:30 -0800 Received: from CY3PR05CU001.outbound.protection.outlook.com (40.93.201.8) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Feb 2026 01:16:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c3QXmD9GICp8ZVaWhtxJznoCDl/1PJ+RUVnGnyDQ3AVq2RzuTLH5l6d+Jk2P2ESwusX9U1p9KeL8UNTMGX6u/pe7PLLNICJrRb+gK3FpSP2JLgiRvQXBdlS5kDD+RQG4eMauBEvnZmFOiifXj2m4q/1gWsbk368hZkgIzz1MSmlhke++ogvNwLWfJXdyaeMf3mMb9Ds5OiF+oxm23vOeeJlgj7DxzCzNQEPxZSfYbooaxLSl0kfsguGC4hQYX3nzBUQlj4faoDo4XBG+ceAItDLnkpbKjgzfZ9vrTbSPAGY+T5fOzwjwb1Z2z9cHh4OB6mZNztqTFBkioRR5/jHZOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZU1chBaqvi2aj9n8tWoOUqRVvs9x/ffUMULCUlJ0MxM=; b=gZPsoSdrYyMXeJb2q/STD+CD9NeHL5UpX3hBTjOJ+m8g5WiJqxSuIQdKmmOQ4nQWlyLAhHYEy4cngL+85eY4SXl0zqmfG3VnC4/ICqvLRsi9gWjI2cg/Ck2T5/tAWZcZH7Rcx2wi9kda601dpgmIf2eFuMQN8qpBKUlpC8ZxUuQmFI5dA1OGhfxIidl5zceTiRCTQ5Tv3px1uTKHRCP9xe7XtALmTCy0cR8SeqkwtS8NysvuCl9yvxxqOq7cDZUD9AJ1/MNT3uBUUN3GOgS64o0vUFjqWSpAEiEToJFV8ZP/0ODS22NIqn0ghslHEO/5XtEdPUrHhtVB1IFNz6nnXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) by CO1PR11MB5137.namprd11.prod.outlook.com (2603:10b6:303:92::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Fri, 27 Feb 2026 09:16:27 +0000 Received: from IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456]) by IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456%6]) with mapi id 15.20.9654.015; Fri, 27 Feb 2026 09:16:27 +0000 Message-ID: <1e71a22b-48d5-4a5f-87d5-860a6cb9a04d@intel.com> Date: Fri, 27 Feb 2026 11:16:23 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mmc: sdhci-pci-gli: fix GL9750 DMA write corruption To: Matthew Schwartz , Ulf Hansson , Ben Chuang CC: , , References: <20260227075909.3860183-1-matthew.schwartz@linux.dev> Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20260227075909.3860183-1-matthew.schwartz@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0282.eurprd04.prod.outlook.com (2603:10a6:10:28c::17) To IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB7198:EE_|CO1PR11MB5137:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ce561ed-ef54-48d1-c402-08de75e0e2fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: ZncpymVSCWE8OF78u2skpmCYYsLhb92EkPVY9s4MpUBsoy8aic73L/QiMNW8F/We+Rtnm8XwKoAG7EdTqDV/4BnHbEJkJYT3wTd32DwiuOPzD4gopkQFq9C6yZkvwAxw3L57Du/8g4GyCGssafTbs9sBw0KI5cQxZZuwvBm99k1DFKjKUmtZdAHDk5vf5go0CEonIh9bAHx5O0C72P/3CPudOCbjo/MJDIGsCU/uOcGiZ452gQJNLB1HskZX36fd3giu+yrI2VqCbswZUzX8+FCAoxdpHjFGLk+4pLRH/60JGI0NwUVbJl+J4zvgZqsys3Bj8l2tmR/iXbTiO+fCLXMsIt9+L85kqNivQ3Y57DDzKDnzapEAOWTKKGQ1gAu1gkHqDwfUoUnlc4hHmk4WnDzBYfq0Q6gpFxmI0i/oY32FWDwfna9SHjD2DOtvHsbkxKyQ9FfKZcPmzy4T9Mpe7I6Oz/pEI1K2K7X1N/Fwss677qccQuqINRimdd27kmR3x4DMMYqp++71C54H2iJStDAPypgC5/itlSvG+f2CKjRpsa+Q+gLs/cqYeIbJyNf/BvDny58G0QcludaWIMzJUGZZAQuuj1yz/fTHOdokgW9XhuMnOZ8ZdvC+Rs2jsfOBBHbFwJG2oBbKjR5iIx8fLVvH7tuXKRkebXki3FWfTBQJDCIZeJKaR0CLQliHcRx5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB7198.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2dZU2NhclVTYzRjVlhtNjBhMTNBWnZyei9XWDlLYURiQllqL3Q1QW9lL2VS?= =?utf-8?B?SDV5QUpNN2xTc2xtYnNRTU0vMFBWeW0wTUZQekNhckVheXRpdkJPWE82Q3hF?= =?utf-8?B?MlNJR29Sa1FRNmlKMXhtUkk3aG16WVo2dlV5TllXbEc4N2xKTCtjMmR4bElo?= =?utf-8?B?OFZqVEd6ZWtab0hkaEx1SVJDZW11d0s3aERXdlRrSFIzTFkvVXhoWTNPNUM1?= =?utf-8?B?Z290QzJoblc1b2hYOEtadFRIMjNaSnhTTFVBTUhxTTdBQlREZXlRR01DNHNP?= =?utf-8?B?N3NXRGRoUmhlSHo4bjBjSmZNOUlmbTMwM0JOL3cvNjhNTlF4eGFCNXBYdnl6?= =?utf-8?B?QU9USlpPK3ZzOGthT1pCNDNoVHpid1RGeDVBb2pMMmo3ZThiSG9QdENUbWp5?= =?utf-8?B?aWcxNkRXVkh4djhJNUpzZjgrUjlCL0hoSllGTlp6bERVRlZaWnlEYmRsSlYy?= =?utf-8?B?bWhLT2lMTmlseWlmUFFyRXBpaDQ1UzRNMjlvMU1CbGR4TjhiU3U0MzZSVEMr?= =?utf-8?B?TEh2TzZNcVJxRTdNMXdlUTJSZDZqY0lIK2VwVWU4Y2hXOEpNSDJST1hOMkow?= =?utf-8?B?N09HSHRLallobHdCR3JLRXphVUdWdTNQNlY2UEJ6SlNKZk9xenJZYllPYzZC?= =?utf-8?B?MmwxY3RDaHl0K3djNkZpK0xNNlZTQXRqdWtNdFE1cXJiSjJTcjlhYWdQUUhp?= =?utf-8?B?Njk4QmdhTVUxOEd1cFJVMXZKUmp2ZCtna01seXdGb1ZqN0MzdEJwNWI4NFUw?= =?utf-8?B?QlFqUGFicVVnSXFwa0R6akQvcTJkVW9UTFZ0N09rL25hWGJSUzY5ZGhkaTBa?= =?utf-8?B?UzQyUldkWHRWWkRIdTFLVmhhR3pucFBMbXYwNUpnRzlQU29qY0J2bm0xUkJE?= =?utf-8?B?dXNiNFIxL1RtRUgyRmdLcG16UzJMVzZyY0JJbFh0eWZjcmtKc2h0dnhMbitJ?= =?utf-8?B?K3RGRzBHZjBaK2t5OW4waWFZK25ndGVBVHJaOTdlTWtyU0JrODAxcGRSMjRO?= =?utf-8?B?alUwR3pTUEMvWmZicHd3ZmZkY2RobVNNYTBhL1pubUsvYW1jOGNuVFhRc2NP?= =?utf-8?B?enYzcndvSmVpTTZPQkpTVzV2Y1R6N0JKK2wzWVhTdWJMUzJteDF5YUpyUG8w?= =?utf-8?B?UEcyRkN6QXFZSzhKOVlYY3daeDJiK3ZiRjFVNDkxNmJlWkFZczNCaVdNemZW?= =?utf-8?B?MkNiUzhjSkZtRkJLakJEQ2Q1UmlacUNFb3F6Vjlkb3hUVGtrMkRlMmNXVExq?= =?utf-8?B?OU1lVEMyUE4wVDRwb25QUHlIOGFMbmFYYmZFbm5iV0hYODQ5MmlGU2R0T1FO?= =?utf-8?B?dDhxTERXN0h4ZWx6WjhJc3p4dTNndWtzMzAxZEZwVDIvaWhYVzl5M3J3cndz?= =?utf-8?B?NXJRSFpiWVhlWVk0ekwwMjJCNnFqODJlNWhqTlZNc1BsdHUwdDRISzF6N2or?= =?utf-8?B?aHhEQWVMNE50YU5xWThhVnZONFI1Uk5nODhmYlFIZU9NOXhLUTRwWDUvem55?= =?utf-8?B?TlNvYVF3OGFBcEtGdUc2QzZ5UkNIeDRUYTNmcVNFZUZRZGVsMEE5VWtldkFH?= =?utf-8?B?TS94NGFvbGxzblE2MFRaRDhnT04xeEJDb0NxYWJET1MwVVh2M0FoL21yR2ZO?= =?utf-8?B?NU1zaklFUTZocmRuQU1lTmhDQjFUckJLT0JkSkhaWHBKLzNRK0RhQ3RIakty?= =?utf-8?B?L0pJQ1VPQzd1MkppRjJKZmhMOUdwb3YyckJGLzZzYWFnSkV1WXE4c25QcWVL?= =?utf-8?B?OWJ2NXh1ZTNmWkxNVTgzOVNGOWNpTlRTOHFQbmNCVG9yNkxLa0JGQWw4OU9o?= =?utf-8?B?bkxFZDJVNzZiQWhSanBGaWpsRng1T1dkZzVwNjduNW5Zbm4wZlNCckI4YnFY?= =?utf-8?B?M0JHckIwRE8wL2JSV3JDWE9mLzZRajhVN1FDZ091R0c1WXJ4NXNhTlZtQWda?= =?utf-8?B?MlU5OEt3N1FXeDBad20vMW1FMytCNStzdFpEdFQ3WFNPejA5dE1NYTlERjBN?= =?utf-8?B?VDJqbitoYlZPSlVjalIwSkNuU0krazNJL0FtY1JTS05PTkFoZ2diOW1KMWFO?= =?utf-8?B?NWIzTXRIRWZML1M4aXN5c056OUpPaFJ5UTJWZHVpcDRGVUxzWlhjVkQyVmJh?= =?utf-8?B?MVFMcnJXMEF4amh4bms4bm83bk4xZS9WYzh6VlBmMFJWS0VySUtGOWUzd0Rt?= =?utf-8?B?d243b0krVFRsNzg4Z3ZSTTVPSnhFUXhjQWlveEZOclllQUhKbWc3VUpieUZT?= =?utf-8?B?OWNUcU1UOERCU1hzQitlQzNKcmVqQnRQYlh1V2pmaXc1eGZPQkYwYkQvcXEz?= =?utf-8?B?STVKdGkyVWRxQTVFYnJhMFBMWk5GTEwwMkZRYkkrMitNTy9GRysvNllYWmVw?= =?utf-8?Q?SAx+T0cl81TsfnO0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2ce561ed-ef54-48d1-c402-08de75e0e2fc X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7198.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 09:16:27.6459 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9w+AgZ3DSlytDZPviaeVEDPnqQOeNGGUc2tW6hFekR2ZJi3nFMuelrvgYJ7EohF4dRZIb73McsePkvjs3on9Gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5137 X-OriginatorOrg: intel.com X-DKIM: signer='intel.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-DKIM: signer='@intel.com' status='pass' reason='' X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://docs.mxroute.com/docs/expert-spam-filtering.html --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: intel.com] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 URIBL_DBL_BLOCKED_OPENDNS ADMINISTRATOR NOTICE: The query to dbl.spamhaus.org was blocked due to usage of an open resolver. See https://www.spamhaus.org/returnc/pub/ [URIs: intel.com] 0.0 RCVD_IN_ZEN_BLOCKED_OPENDNS RBL: ADMINISTRATOR NOTICE: The query to zen.spamhaus.org was blocked due to usage of an open resolver. See https://www.spamhaus.org/returnc/pub/ [172.234.253.10 listed in zen.spamhaus.org] 0.0 URIBL_ZEN_BLOCKED_OPENDNS ADMINISTRATOR NOTICE: The query to zen.spamhaus.org was blocked due to usage of an open resolver. See https://www.spamhaus.org/returnc/pub/ [URIs: intel.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 On 27/02/2026 09:59, Matthew Schwartz wrote: > The GL9750 SD host controller has intermittent data corruption during > DMA write operations. The GM_BURST register's R_OSRC_Lmt field > (bits 17:16), which limits outstanding DMA read requests from system > memory, is not being cleared during initialization. The Windows driver > sets R_OSRC_Lmt to zero, limiting requests to the smallest unit. > > Clear R_OSRC_Lmt to match the Windows driver behavior. This eliminates > write corruption verified with f3write/f3read tests while maintaining > DMA performance. > > Cc: stable@vger.kernel.org > Fixes: e51df6ce668a ("mmc: host: sdhci-pci: Add Genesys Logic GL975x support") > Closes: https://lore.kernel.org/linux-mmc/33d12807-5c72-41ce-8679-57aa11831fad@linux.dev/ > Signed-off-by: Matthew Schwartz Ben wrote "So I think your patch setting R_OSRC_Lmt to zero is reasonable." Can be have a Reviewed-by tag also? Nevertheless: Acked-by: Adrian Hunter > --- > Link to RFC: https://lore.kernel.org/all/20260117234800.931664-1-matthew.schwartz@linux.dev/ > Changes from RFC -> v1: use the proper name for the register field > --- > drivers/mmc/host/sdhci-pci-gli.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c > index b0f91cc9e40e4..7a7be3f7bee6b 100644 > --- a/drivers/mmc/host/sdhci-pci-gli.c > +++ b/drivers/mmc/host/sdhci-pci-gli.c > @@ -26,6 +26,9 @@ > #define GLI_9750_WT_EN_ON 0x1 > #define GLI_9750_WT_EN_OFF 0x0 > > +#define SDHCI_GLI_9750_GM_BURST_SIZE 0x510 > +#define SDHCI_GLI_9750_GM_BURST_SIZE_R_OSRC_LMT GENMASK(17, 16) > + > #define SDHCI_GLI_9750_CFG2 0x848 > #define SDHCI_GLI_9750_CFG2_L1DLY GENMASK(28, 24) > #define GLI_9750_CFG2_L1DLY_VALUE 0x1F > @@ -629,6 +632,11 @@ static void gl9750_hw_setting(struct sdhci_host *host) > > gl9750_wt_on(host); > > + /* clear R_OSRC_Lmt to avoid DMA write corruption */ > + value = sdhci_readl(host, SDHCI_GLI_9750_GM_BURST_SIZE); > + value &= ~SDHCI_GLI_9750_GM_BURST_SIZE_R_OSRC_LMT; > + sdhci_writel(host, value, SDHCI_GLI_9750_GM_BURST_SIZE); > + > value = sdhci_readl(host, SDHCI_GLI_9750_CFG2); > value &= ~SDHCI_GLI_9750_CFG2_L1DLY; > /* set ASPM L1 entry delay to 7.9us */ From - Fri Feb 27 09:22:09 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id OEb+NyBioWmd/ToAYBR5ng (envelope-from ) for ; Fri, 27 Feb 2026 09:21:36 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 27 Feb 2026 09:21:37 +0000 Received: from sin.lore.kernel.org ([104.64.211.4]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vvu2R-00000000GUK-3MIe for hi@josie.lol; Fri, 27 Feb 2026 09:21:36 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sin.lore.kernel.org (Postfix) with ESMTP id 96CCE301BA49 for ; Fri, 27 Feb 2026 09:21:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9127738B7D1; Fri, 27 Feb 2026 09:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Lk/eL6yU" X-Original-To: linux-s390@vger.kernel.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 730DA3624A3; Fri, 27 Feb 2026 09:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772184078; cv=none; b=lB7nVhJr9N4rDDfJUMAdY51J8KUI9DwVmhOyzW/pk42PzytwH0aV44IO5W+CO9KwxfNHlCY71w4nWNDUgIInPMNdbxsQU929LOTqyp05QQW1lK276Rk8vNmWGTyfh/9S/DM6uyKKyIC4iVmCc3adwJbTlvacBhMkkga01OjrW9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772184078; c=relaxed/simple; bh=J5BlJPpNzKGEPTM3aR/d2a49DEl+mSKAY46kUhvBVbg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=knAUe2TGlmeBCuUPMMtQLdxvGSNaZBppYoL8KarZft7SJyfqMsjcHq8t05q2AqL7+4qiFNr38Y11WpfFzJ5I3GuCqD3qKYM92cPGXGR+D/dsehlGqHazbT7YwnHX3J++iJsECt+u0Aoxw/+bAzRtmqvlYc5dvpXKqxPqrbUztCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Lk/eL6yU; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R0QJ6K2347127; Fri, 27 Feb 2026 09:21:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=DB39mHhxUx3sbcn61cGF7UuyCYc7v7LfXe8EZ3aVs t0=; b=Lk/eL6yU7wfGH9mpAfGBKvaCqI3eraIPWVTqf2jadInoLyKCc/K6oj6zC GawwgFZv2k2OZKaM5RRDoPlrJWSFJKD8TcxvXfdCP4homQMk4Wdg/BgAJeJUToAF K1qYJ5lKFNVF+g0st01Vf7APOGwc2S0nhrWAWfAmQjgqilpoAdM3eVm6K609JgHh HA5CC5ihyqX6iITH9kuMVaqCo4S/nxTbcvNE2CfnmmYT0M3kwYaaWaepIRn4Izdp 5mvCWJxuVTguqZTKtL8mUAPGGvTE/HXhw1MD3kykcKgEpoQbyn0Fi68aq9RGL+jF Qi0HTMUjRIupZsv1rSpuMXXu334kA== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ch8591aq6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:21:12 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 61R84HN7030259; Fri, 27 Feb 2026 09:21:11 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4cfrhks7w6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:21:11 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 61R9L74U16450002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Feb 2026 09:21:07 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC37020049; Fri, 27 Feb 2026 09:21:07 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 850AB20040; Fri, 27 Feb 2026 09:21:07 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 27 Feb 2026 09:21:07 +0000 (GMT) From: Heiko Carstens To: Alexander Gordeev , Sven Schnelle , Vasily Gorbik , Christian Borntraeger , Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: [PATCH] s390/xor: Fix xor_xc_2() inline assembly constraints Date: Fri, 27 Feb 2026 10:21:07 +0100 Message-ID: <20260227092107.1120216-1-hca@linux.ibm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDA3OCBTYWx0ZWRfXxKF2gyYLjPmn aRl4P1za8+n3adnufUtgLktWSBtGtslAtsp/4bDI5caN8S5TG7xpUicxlzgsQBRACaSnagqhj++ vBBOfopebBc+8k9SUw4kvgo697Khc/z1ppjPcJankbN9LQDnXnYSJu1agDIaVZM1NasCBlLhJA4 PCXfrxm2oh1cqMxnZBmV06hyR6w9l6Qkaea6WODfG8wh3XT+HDkeGOAqSBX6Kx6DyPaxpUrgn1s hhs4OlqvsYjKmOmksMirjIrETpR1nIV/Uj8qsgpXpY15M2a6m5+1UuTLr2hLsnuAlExi/7hXkWd h/5kZXkfqkkwjiuhPLauPElgi1d3q3MCHbWZNoLolOIci8jMaCQAjjEnUOVsoZGm4vFjVX7fZJz SSuImIMoucdeas2vJqQi1jcx32c0I/75igXV/tgnEuNRZ+D/NvGJu9aghx50IzXKqBIvLb7DjNh CUIT+BP011oyXFFbPQA== X-Proofpoint-GUID: -nZHDk_hsYX90DYT3GfxpYMJNTY0Y5ld X-Authority-Analysis: v=2.4 cv=S4HUAYsP c=1 sm=1 tr=0 ts=69a16209 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=w_A7ZVS8W7fTsnOWK-QA:9 X-Proofpoint-ORIG-GUID: -nZHDk_hsYX90DYT3GfxpYMJNTY0Y5ld X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_01,2026-02-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602270078 X-DKIM: signer='ibm.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://docs.mxroute.com/docs/expert-spam-filtering.html --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 The inline assembly constraints for xor_xc_2() are incorrect. "bytes", "p1", and "p2" are input operands, while all three of them are modified within the inline assembly. Given that the function consists only of this inline assembly it seems unlikely that this may cause any problems, however fix this in any case. Cc: stable@vger.kernel.org Signed-off-by: Heiko Carstens --- arch/s390/lib/xor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/lib/xor.c b/arch/s390/lib/xor.c index 1721b73b7803..d703c44d5fd6 100644 --- a/arch/s390/lib/xor.c +++ b/arch/s390/lib/xor.c @@ -28,8 +28,8 @@ static void xor_xc_2(unsigned long bytes, unsigned long * __restrict p1, " j 3f\n" "2: xc 0(1,%1),0(%2)\n" "3:" - : : "d" (bytes), "a" (p1), "a" (p2) - : "0", "cc", "memory"); + : "+d" (bytes), "+a" (p1), "+a" (p2) + : : "0", "cc", "memory"); } static void xor_xc_3(unsigned long bytes, unsigned long * __restrict p1, -- 2.51.0 From - Fri Feb 27 09:24:31 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id UOzXHcpioWnjgD0AYBR5ng (envelope-from ) for ; Fri, 27 Feb 2026 09:24:26 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 27 Feb 2026 09:24:26 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vvu5B-00000000MAi-2Rmt for hi@josie.lol; Fri, 27 Feb 2026 09:24:26 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 6E99D3101E02 for ; Fri, 27 Feb 2026 09:20:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 03ECE389E08; Fri, 27 Feb 2026 09:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b="a19n42Vv"; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b="E4B7JXH6" X-Original-To: stable@vger.kernel.org Received: from sphereful.davidgow.net (sphereful.davidgow.net [203.29.242.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DAD538A721; Fri, 27 Feb 2026 09:20:0