 fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073
Content-Transfer-Encoding: 8bit
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: msgid.link]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

From: Eric Dumazet <edumazet@google.com>

commit e2a9eeb69f7d4ca4cf4c70463af77664fdb6ab1d upstream.

syzbot and Eulgyu Kim reported crashes in mptcp_pm_nl_get_local_id()
and/or mptcp_pm_nl_is_backup()

Root cause is list_splice_init() in mptcp_pm_nl_flush_addrs_doit()
which is not RCU ready.

list_splice_init_rcu() can not be called here while holding pernet->lock
spinlock.

Many thanks to Eulgyu Kim for providing a repro and testing our patches.

Fixes: 141694df6573 ("mptcp: remove address when netlink flushes addrs")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot+5498a510ff9de39d37da@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/6970a46d.a00a0220.3ad28e.5cf0.GAE@google.com/T/
Reported-by: Eulgyu Kim <eulgyukim@snu.ac.kr>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/611
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20260124-net-mptcp-race_nl_flush_addrs-v3-1-b2dc1b613e9d@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[ Conflicts because the code has been moved from pm_netlink.c to
  pm_kernel.c later on in commit 8617e85e04bd ("mptcp: pm: split
  in-kernel PM specific code"). The same modifications can be applied
  in pm_netlink.c with one exception, because 'pernet->local_addr_list'
  has been renamed to 'pernet->endp_list' in commit 35e71e43a56d
  ("mptcp: pm: in-kernel: rename 'local_addr_list' to 'endp_list'"). The
  previous name is then still being used in this version.
  Also, another conflict is caused by commit 7bcf4d8022f9 ("mptcp: pm:
  rename helpers linked to 'flush'") which is not in this version:
  mptcp_nl_remove_addrs_list() has been renamed to
  mptcp_nl_flush_addrs_list(). The previous name has then been kept. ]
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 net/mptcp/pm_netlink.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 9f25cfd96f98..4b805d7f5769 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -1859,16 +1859,26 @@ static void __reset_counters(struct pm_nl_pernet *pernet)
 static int mptcp_nl_cmd_flush_addrs(struct sk_buff *skb, struct genl_info *info)
 {
 	struct pm_nl_pernet *pernet = genl_info_pm_nl(info);
-	LIST_HEAD(free_list);
+	struct list_head free_list;
 
 	spin_lock_bh(&pernet->lock);
-	list_splice_init(&pernet->local_addr_list, &free_list);
+	free_list = pernet->local_addr_list;
+	INIT_LIST_HEAD_RCU(&pernet->local_addr_list);
 	__reset_counters(pernet);
 	pernet->next_id = 1;
 	bitmap_zero(pernet->id_bitmap, MPTCP_PM_MAX_ADDR_ID + 1);
 	spin_unlock_bh(&pernet->lock);
-	mptcp_nl_remove_addrs_list(sock_net(skb->sk), &free_list);
+
+	if (free_list.next == &pernet->local_addr_list)
+		return 0;
+
 	synchronize_rcu();
+
+	/* Adjust the pointers to free_list instead of pernet->local_addr_list */
+	free_list.prev->next = &free_list;
+	free_list.next->prev = &free_list;
+
+	mptcp_nl_remove_addrs_list(sock_net(skb->sk), &free_list);
 	__flush_addrs(&free_list);
 	return 0;
 }
-- 
2.51.0



From - Thu Feb 12 17:52:48 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215983-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id mItrILQQjmk4BjgAYBR5ng
	(envelope-from <stable+bounces-215983-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 17:41:08 +0000
Return-path: <stable+bounces-215983-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 17:41:08 +0000
Received: from sto.lore.kernel.org ([172.232.135.74])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215983-hi=josie.lol@vger.kernel.org>)
	id 1vqage-0000000FhYB-0Z5e
	for hi@josie.lol;
	Thu, 12 Feb 2026 17:41:08 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sto.lore.kernel.org (Postfix) with ESMTP id 52FCF301253D
	for <hi@josie.lol>; Thu, 12 Feb 2026 17:41:06 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id D164F211A28;
	Thu, 12 Feb 2026 17:41:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pmKBOhdt"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD9711E9B3F;
	Thu, 12 Feb 2026 17:41:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770918062; cv=none; b=ESDXc8mnH0k6ZRoPxO1M30v7+6LLATBLm+T6pQa//kcWs5TtT1bQqL+5D9dsMngFimI6HkiqAfPDn64/3JsUdkZgBca/5O09Je1MPGdEPbC2caqpHyA5JOqyjeiCj2PNWrJBIZnLn1W8vEltCTW4wj814gn/mc9Z14Xh2j430EQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770918062; c=relaxed/simple;
	bh=JuoZWuJHqqx1DXrYnnJxtG+Mlw2QkrQua4Z4MNJSUGU=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fK0XkOvpkJA/EoqZPNJYjZ90yLZ5LR13dj+kJmx0iIc9ltmDW6Nn4H6bHkP/uLbgTrje4sRqFehw38VLDQkAqY2mqzfpMWu7MeU8yEvWQpqM8uA9bPOLLs9MOZ0WyRfHnSIkvM1cTkBzwSGZXD3NAzhAEO7Oo5LUObGUiABR7sw=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pmKBOhdt; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 968EDC4CEF7;
	Thu, 12 Feb 2026 17:41:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770918062;
	bh=JuoZWuJHqqx1DXrYnnJxtG+Mlw2QkrQua4Z4MNJSUGU=;
	h=From:To:Cc:Subject:Date:From;
	b=pmKBOhdt691RM+hQQb++sI49fryqSv+dkGWH1D1ft7ah+cDgP3m0y4Mf2sJ5gvpha
	 Qvp1H+5ukxFt8CsqONt2xefA5OEDW3tQlImNqhOc+IhjGdt+eZTFLQGl5itSsHOvZe
	 3vTwrIRHNjhQK0v9oAJBLWBdIw+vTYDxie5/JHWR5V8TyxMx6W/bfZpn39bB8cAlWn
	 vpq4mkteOmbfxN4/VEsZFYl8xnCaU/+HU2cQsGxl5RzbsBOvjQU2OLme01boRvGm0T
	 lURMp727GQwhwpwYH+VT663UE3yclloG25u9dr9rwoBUvELrbPlHKsLWneLoHn5QSN
	 KTHlK7MD07KpQ==
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: stable@vger.kernel.org,
	gregkh@linuxfoundation.org
Cc: MPTCP Upstream <mptcp@lists.linux.dev>,
	Eric Dumazet <edumazet@google.com>,
	syzbot+5498a510ff9de39d37da@syzkaller.appspotmail.com,
	Eulgyu Kim <eulgyukim@snu.ac.kr>,
	Mat Martineau <martineau@kernel.org>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH 6.1.y] mptcp: fix race in mptcp_pm_nl_flush_addrs_doit()
Date: Thu, 12 Feb 2026 18:40:52 +0100
Message-ID: <20260212174051.1839592-2-matttbe@kernel.org>
X-Mailer: git-send-email 2.51.0
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=3192; i=matttbe@kernel.org; h=from:subject; bh=W5rjCbGOcVM2iHsdt8PD8IQL8WF3OCFnV/IhyOBrL5Y=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDL7BJZsDPJZm3ddNE2n6sT2vD21E8+aRrLq32pYnLpfx 65j68XajlIWBjEuBlkxRRbptsj8mc+reEu8/Cxg5rAygQxh4OIUgIkwn2FkOHzMfoXy0bw5Xyed U/sb9trT4RzTwUfr72lbFd66uMRvrQnDf59Tgmza7REHWI5srXVJu161WeKNr9ckszfaE4Wz/Y+ /ZQEA
X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073
Content-Transfer-Encoding: 8bit
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: msgid.link]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

From: Eric Dumazet <edumazet@google.com>

commit e2a9eeb69f7d4ca4cf4c70463af77664fdb6ab1d upstream.

syzbot and Eulgyu Kim reported crashes in mptcp_pm_nl_get_local_id()
and/or mptcp_pm_nl_is_backup()

Root cause is list_splice_init() in mptcp_pm_nl_flush_addrs_doit()
which is not RCU ready.

list_splice_init_rcu() can not be called here while holding pernet->lock
spinlock.

Many thanks to Eulgyu Kim for providing a repro and testing our patches.

Fixes: 141694df6573 ("mptcp: remove address when netlink flushes addrs")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot+5498a510ff9de39d37da@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/6970a46d.a00a0220.3ad28e.5cf0.GAE@google.com/T/
Reported-by: Eulgyu Kim <eulgyukim@snu.ac.kr>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/611
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20260124-net-mptcp-race_nl_flush_addrs-v3-1-b2dc1b613e9d@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[ Conflicts because the code has been moved from pm_netlink.c to
  pm_kernel.c later on in commit 8617e85e04bd ("mptcp: pm: split
  in-kernel PM specific code"). The same modifications can be applied
  in pm_netlink.c with one exception, because 'pernet->local_addr_list'
  has been renamed to 'pernet->endp_list' in commit 35e71e43a56d
  ("mptcp: pm: in-kernel: rename 'local_addr_list' to 'endp_list'"). The
  previous name is then still being used in this version.
  Also, another conflict is caused by commit 7bcf4d8022f9 ("mptcp: pm:
  rename helpers linked to 'flush'") which is not in this version:
  mptcp_nl_remove_addrs_list() has been renamed to
  mptcp_nl_flush_addrs_list(). The previous name has then been kept. ]
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 net/mptcp/pm_netlink.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index cc58536bbf26..293ec3448f52 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -1855,16 +1855,26 @@ static void __reset_counters(struct pm_nl_pernet *pernet)
 static int mptcp_nl_cmd_flush_addrs(struct sk_buff *skb, struct genl_info *info)
 {
 	struct pm_nl_pernet *pernet = genl_info_pm_nl(info);
-	LIST_HEAD(free_list);
+	struct list_head free_list;
 
 	spin_lock_bh(&pernet->lock);
-	list_splice_init(&pernet->local_addr_list, &free_list);
+	free_list = pernet->local_addr_list;
+	INIT_LIST_HEAD_RCU(&pernet->local_addr_list);
 	__reset_counters(pernet);
 	pernet->next_id = 1;
 	bitmap_zero(pernet->id_bitmap, MPTCP_PM_MAX_ADDR_ID + 1);
 	spin_unlock_bh(&pernet->lock);
-	mptcp_nl_remove_addrs_list(sock_net(skb->sk), &free_list);
+
+	if (free_list.next == &pernet->local_addr_list)
+		return 0;
+
 	synchronize_rcu();
+
+	/* Adjust the pointers to free_list instead of pernet->local_addr_list */
+	free_list.prev->next = &free_list;
+	free_list.next->prev = &free_list;
+
+	mptcp_nl_remove_addrs_list(sock_net(skb->sk), &free_list);
 	__flush_addrs(&free_list);
 	return 0;
 }
-- 
2.51.0



From - Thu Feb 12 17:52:48 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215984-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id CISLH/QQjmmnSjgAYBR5ng
	(envelope-from <stable+bounces-215984-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 17:42:12 +0000
Return-path: <stable+bounces-215984-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 17:42:12 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215984-hi=josie.lol@vger.kernel.org>)
	id 1vqahg-0000000FjoB-0p7B
	for hi@josie.lol;
	Thu, 12 Feb 2026 17:42:12 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 68B3A3047516
	for <hi@josie.lol>; Thu, 12 Feb 2026 17:42:01 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 8661F23ED75;
	Thu, 12 Feb 2026 17:42:00 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rNnjDk/j"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62ED41E9B3F;
	Thu, 12 Feb 2026 17:42:00 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770918120; cv=none; b=rs6AAy/1L7zP/lj0YkqvJZegZRwNhWamk99N/BOkBbjqtKi0ODjnrYr/Q7MqeHZGic41p8jb9yL5NG9zd7wio7LNDjrIpbKG0Sb/5N+QaL6dVielKYQ+7HJPXnkK2LMZb+EgbUW9iFFye0M8VAJNLEr9qn2+tYL25QICsEZ1wEk=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770918120; c=relaxed/simple;
	bh=ZkFiNws2RQdpDs8XLBZhVq8Fo3BvVximS2v1wPpiquU=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qKmR2SV7RRNQ3Psbe5/9Jh+5FqLmBXJzRGjC0Q9nGejaZgribTkOmPgBy8rP/CHE88xETg1XhFPYRNSkJXZQMipThCZw/BQwADDu0a9Hwq/2DPt4h6hejYJmlRk+8os9XYLdf3QZA2lP6JFoe/eGo1BJlXO3+rQa5gwx+Qm4XiE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rNnjDk/j; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AC40C16AAE;
	Thu, 12 Feb 2026 17:41:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770918120;
	bh=ZkFiNws2RQdpDs8XLBZhVq8Fo3BvVximS2v1wPpiquU=;
	h=From:To:Cc:Subject:Date:From;
	b=rNnjDk/jujuJcfxoLXVxMvdhV6l5i3yDIn2JNRHwTeZch4JT8TiNxe9RfO0H/2dPp
	 Na49stBTtXmuVOF98l3LtqopsWLwuUgawshUOFsOjRbOx+tUu1/NNQ/mqq0DejBuA5
	 0r9BtA9sNhtIO8rnJ01qeumqm/dqBMJmfo8CaaR9lbFCEvJkeBtTsSAsQGJls50Fau
	 VhO9pIYcb5MRIn+CoAe1x1l9UNWoJ5zCV+9iNsGBvLPCYS67eCkqlICHu15l051/0p
	 dK+lUomCc+za6n2E4+gyv6OvPJ2qJ0PiesAPrlFsfTtkCDhCoxHfFJd7eAWF0+/TyA
	 lZ0O0UH9ObT5Q==
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: stable@vger.kernel.org,
	gregkh@linuxfoundation.org
Cc: MPTCP Upstream <mptcp@lists.linux.dev>,
	Eric Dumazet <edumazet@google.com>,
	syzbot+5498a510ff9de39d37da@syzkaller.appspotmail.com,
	Eulgyu Kim <eulgyukim@snu.ac.kr>,
	Mat Martineau <martineau@kernel.org>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH 5.15.y] mptcp: fix race in mptcp_pm_nl_flush_addrs_doit()
Date: Thu, 12 Feb 2026 18:41:47 +0100
Message-ID: <20260212174146.1841030-2-matttbe@kernel.org>
X-Mailer: git-send-email 2.51.0
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=3183; i=matttbe@kernel.org; h=from:subject; bh=On2kSmDCbLIbTazrBwMQSs2xFdKmS1BqxP5FB85aHsk=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDL7BG4lf36ay5C0knnNulXlZ768PaMnNnH2HR3bhNd7P Q54Bxbd6ihlYRDjYpAVU2SRbovMn/m8irfEy88CZg4rE8gQBi5OAZhIVAojw0S3HJtlLVPXb72s deb/wh5zA2mZr/Lz8g1PSZXde8GSs4Lhv5/dyoUdCi7SUglWTS4cbw5cWrqndf8TvhknPz+1/st tww8A
X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073
Content-Transfer-Encoding: 8bit
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: msgid.link]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

From: Eric Dumazet <edumazet@google.com>

commit e2a9eeb69f7d4ca4cf4c70463af77664fdb6ab1d upstream.

syzbot and Eulgyu Kim reported crashes in mptcp_pm_nl_get_local_id()
and/or mptcp_pm_nl_is_backup()

Root cause is list_splice_init() in mptcp_pm_nl_flush_addrs_doit()
which is not RCU ready.

list_splice_init_rcu() can not be called here while holding pernet->lock
spinlock.

Many thanks to Eulgyu Kim for providing a repro and testing our patches.

Fixes: 141694df6573 ("mptcp: remove address when netlink flushes addrs")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot+5498a510ff9de39d37da@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/6970a46d.a00a0220.3ad28e.5cf0.GAE@google.com/T/
Reported-by: Eulgyu Kim <eulgyukim@snu.ac.kr>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/611
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20260124-net-mptcp-race_nl_flush_addrs-v3-1-b2dc1b613e9d@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[ Conflicts because the code has been moved from pm_netlink.c to
  pm_kernel.c later on in commit 8617e85e04bd ("mptcp: pm: split
  in-kernel PM specific code"). The same modifications can be applied
  in pm_netlink.c with one exception, because 'pernet->local_addr_list'
  has been renamed to 'pernet->endp_list' in commit 35e71e43a56d
  ("mptcp: pm: in-kernel: rename 'local_addr_list' to 'endp_list'"). The
  previous name is then still being used in this version.
  Also, another conflict is caused by commit 7bcf4d8022f9 ("mptcp: pm:
  rename helpers linked to 'flush'") which is not in this version:
  mptcp_nl_remove_addrs_list() has been renamed to
  mptcp_nl_flush_addrs_list(). The previous name has then been kept. ]
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 net/mptcp/pm_netlink.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index e396adefea02..1c8aabce33a6 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -1656,16 +1656,26 @@ static void __reset_counters(struct pm_nl_pernet *pernet)
 static int mptcp_nl_cmd_flush_addrs(struct sk_buff *skb, struct genl_info *info)
 {
 	struct pm_nl_pernet *pernet = genl_info_pm_nl(info);
-	LIST_HEAD(free_list);
+	struct list_head free_list;
 
 	spin_lock_bh(&pernet->lock);
-	list_splice_init(&pernet->local_addr_list, &free_list);
+	free_list = pernet->local_addr_list;
+	INIT_LIST_HEAD_RCU(&pernet->local_addr_list);
 	__reset_counters(pernet);
 	pernet->next_id = 1;
 	bitmap_zero(pernet->id_bitmap, MAX_ADDR_ID + 1);
 	spin_unlock_bh(&pernet->lock);
-	mptcp_nl_remove_addrs_list(sock_net(skb->sk), &free_list);
+
+	if (free_list.next == &pernet->local_addr_list)
+		return 0;
+
 	synchronize_rcu();
+
+	/* Adjust the pointers to free_list instead of pernet->local_addr_list */
+	free_list.prev->next = &free_list;
+	free_list.next->prev = &free_list;
+
+	mptcp_nl_remove_addrs_list(sock_net(skb->sk), &free_list);
 	__flush_addrs(&free_list);
 	return 0;
 }
-- 
2.51.0



From - Thu Feb 12 17:52:49 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215985-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id aA+SMk0SjmkBtTgAYBR5ng
	(envelope-from <stable+bounces-215985-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 17:47:57 +0000
Return-path: <stable+bounces-215985-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 17:47:58 +0000
Received: from sto.lore.kernel.org ([172.232.135.74])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215985-hi=josie.lol@vger.kernel.org>)
	id 1vqanF-0000000FvTQ-28ak
	for hi@josie.lol;
	Thu, 12 Feb 2026 17:47:57 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sto.lore.kernel.org (Postfix) with ESMTP id B2295301286D
	for <hi@josie.lol>; Thu, 12 Feb 2026 17:47:55 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C04B61668;
	Thu, 12 Feb 2026 17:47:54 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GKe3Ln0U"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36C361F5EA;
	Thu, 12 Feb 2026 17:47:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770918474; cv=none; b=QZVtmm+GzQ58weCFjwdVwsR6mOjVMuTdiqrx28epkNnlqi/vUYWDsukRr0LJ0Kc9krVIl3Xu2VdEB9rcf3uXyymYM8dE9VNJi7+T9st7VTj5kKfJJ3DUwikOF47nAo5y3cvpoSkg9xoj6IpnV69naNnL+qzqCmqnV7Lla72Djmw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770918474; c=relaxed/simple;
	bh=63eALC78UAbwjHtNgvnNd25XAYb18N5UP5293tvCClU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=RfVIgGrL3AY2eumaq2PIztR6lST28Jb/AMLNN/gaee0RMeO1Vu+KHSWX/ANc+p9Q/QmG/0XxraXdcLZnowH19zoONfEGoFh0n8560EarHkL+5YZxYFnUY9dUpwfwd2cni/Ld71f0P+JhlveEB+nifO8RWf+Cp+krVbR7gO4rbTk=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GKe3Ln0U; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4019AC4CEF7;
	Thu, 12 Feb 2026 17:47:53 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770918473;
	bh=63eALC78UAbwjHtNgvnNd25XAYb18N5UP5293tvCClU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=GKe3Ln0UIr4Hxfec1A3/xVtsDdcLvg80s4LuHq1oza0sSlEywXxtMmg9UkccIajiV
	 GxfS4/9ajVZrpziQlUerIPURVBOKjk03L2nh09x9SHmKBol0EYiYQNqX1/+Tp9Prrq
	 wrqtV8SXeFL/ZdrVYA9SY5b+PItDZ2oVz1z8bEXEuGSl9eRAR+GiOuJmUoyssTF0Kc
	 5UAGTesxrS/qMcqfvsgAr9a1YNRgZQl/cbcN76KRfRZGnq3y9kyT1V1KcxJLBOqYN0
	 oosjmhRXrsuwBl42QzUqfp8vQ2rmixIlsW18hhWrUnFXIqWDByOxslfjEm/swawxKk
	 Trn4Ey5jLcMoQ==
Date: Thu, 12 Feb 2026 09:47:09 -0800
From: Eric Biggers <ebiggers@kernel.org>
To: Andreas Schwab <schwab@suse.de>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ard Biesheuvel <ardb@kernel.org>,
	"Jason A . Donenfeld" <Jason@zx2c4.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Vivian Wang <wangruikang@iscas.ac.cn>,
	Jerry Shih <jerry.shih@sifive.com>,
	"David S . Miller" <davem@davemloft.net>,
	Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <pjw@kernel.org>,
	Alexandre Ghiti <alex@ghiti.fr>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Han Gao <gaohan@iscas.ac.cn>, linux-riscv@lists.infradead.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: riscv: Depend on
 RISCV_EFFICIENT_VECTOR_UNALIGNED_ACCESS
Message-ID: <20260212174709.GB2269@sol>
References: <20251206213750.81474-1-ebiggers@kernel.org>
 <mvm1piq9ron.fsf@suse.de>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <mvm1piq9ron.fsf@suse.de>
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

On Thu, Feb 12, 2026 at 11:34:00AM +0100, Andreas Schwab wrote:
> On Dez 06 2025, Eric Biggers wrote:
> 
> > Replace the RISCV_ISA_V dependency of the RISC-V crypto code with
> > RISCV_EFFICIENT_VECTOR_UNALIGNED_ACCESS, which implies RISCV_ISA_V as
> > well as vector unaligned accesses being efficient.
> 
> That should be a runtime dependency.
> 

Currently there's no easy way to make it a runtime dependency,
especially given RISC-V's support for systems where the
"vector unaligned accesses are supported and efficient" property can
vary across CPUs on the same system and thus also vary at runtime as
CPUs go online and offline.  See
https://lore.kernel.org/linux-riscv/20251206195655.GA4665@quark/ where I
described these challenges in more detail.

I'd certainly *like* to make it a runtime dependency.  But the RISC-V
folks will need to provide a way to do that.  Part of that will likely
involve dropping support for systems where some CPUs don't have the same
feature set as the boot CPU, aligning with the other architectures.

For now, this patch was the only real option.

- Eric


From - Thu Feb 12 17:52:57 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215931-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id OEwFDQyfjWn9DAAAYBR5ng
	(envelope-from <stable+bounces-215931-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 09:36:12 +0000
Return-path: <stable+bounces-215931-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 09:36:12 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215931-hi=josie.lol@vger.kernel.org>)
	id 1vqT7L-00000000i8o-3vKY
	for hi@josie.lol;
	Thu, 12 Feb 2026 09:36:12 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id A19BA306BF24
	for <hi@josie.lol>; Thu, 12 Feb 2026 09:36:10 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 1C9BD286416;
	Thu, 12 Feb 2026 09:36:10 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SciaKszj"
X-Original-To: stable@vger.kernel.org
Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABA6A17B418
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 09:36:08 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.160.172
ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770888970; cv=pass; b=nDr7dN2kIGoIhCUdczczhe1vOZVyRiMGbCsOjIA6K65nzXbgDEXtosL9BdMmXZbQks4NZ36DtTVo0FI8nhsrAevQit6JvxpdRNxtcOZB76BAvvwBdwqQSE/s1CYz5r496ubK5BrrgNpKtuxpZqkRtVaFxFpFPPiMDuz/Cei8yrQ=
ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770888970; c=relaxed/simple;
	bh=92uxc6KlHViWMwKYKjNTsEWd7ucmY6Tt+XUlURwlqPM=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type; b=CNagmIFhOVOjmLRhkalE8B2e9PzRNqNVyE2K0cBW9T4vhn+y9BszRDQv0WJoLcl4j2VnW/rf5TuFFOZPnhFGdDba5/nPQSDx6cZbz2PzPG2gd4W79wbOqpv6qK9eslAqjT/1S2LvvSLr0sDu5RTeGsR2i2HZujvHMB4fANV80LI=
ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SciaKszj; arc=pass smtp.client-ip=209.85.160.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com
Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-502f101d1cfso26563931cf.1
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 01:36:08 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1770888967; cv=none;
        d=google.com; s=arc-20240605;
        b=NUs+vZxQuYUP1zlDbWBd96BUPKiDLCR7fYuKNCLKFgRaQ0EpKQaVY8JLvtRdtB3Yu7
         p/VKMyodJePJXbRAOb1OaSmbbe1S9UgpF7p7b9hwhtc+e18g44A0xFw/4Lm+QPvl0JRl
         rSTLe1irofT/jQt0noCHDYqh2h4PBVgcyNsixUNG0a2jMvje4dMaKbcx2Kyd36sNm/6O
         RLTH6bAmy23B+smb7sNeoo4SqfHa1OXoq/FNiujbmBNyWkWv4BH5UiAtWwK8KB0W0Xm6
         7CY2GDsyhVqwVdCGFc8cdWJDfyeEXTpJXBve4MqtqBUMtURzwPizSzdbupeivpaaBv16
         upMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=aaNajqUCbVH6NKKZgFxe2XVZqsv9heTJ6/BgQI66ZCU=;
        fh=NBqO8Sw0bfFoS+w+J1Jw5sdwenJ7f2CdmXJ4Gm5hcSw=;
        b=b/qnvD+m9/XheeUlvuRzx1bkERw9D5CB/8AYd4/4Ql5alsvdIvVUmsn3Rq9P9j8AE1
         dW7OHfUvt3C1wY3X+xbmA/8oU05TlYadJsQcnahSYzchd9gTk9wIuwpf+8rb2xQ9pvMU
         60Cg5kRfD2Ng6E/PecImWvQyIyooH/f+OWJyqSnVHSO96Y91l5d/vP03ufR9dYCuDVQR
         OX4uNh+viYLl19KGekkYhpOFmdlkstdPStNT+E/wIA2cpdPuHDhLnnT/5+nmLH5OKZNB
         iJcq4kCzzICy+AESQcnu8uzosjMSHaIYq5e0jBHvK7GItlaaga0XwSvrRgkIOTxAaS7q
         A/0A==;
        darn=vger.kernel.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20230601; t=1770888967; x=1771493767; darn=vger.kernel.org;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=aaNajqUCbVH6NKKZgFxe2XVZqsv9heTJ6/BgQI66ZCU=;
        b=SciaKszj20wA4bn8EMdaB5FTwKAGnBbdnIhbUW87q592TnmbPxcPhSl04MUasVPlrw
         0KNWpYIEeHu4Q/MAlIsq+WwW2R76/Oaul2YsyoBXYrpvqKoS1+ZSBJHtC3TthraeSpzg
         d+o4yOcK2g9AO6yEKPrR8745D4QCcZBVpdkLOf6QCIcIPCFJjEHRQrMpVOxq4kNvtigj
         ivc+xILxRGdqTy3F5Tvf2iFmarQgIYs/kO24+wHPoQXy4Nn7AzTXwf/1leio0UIz2CnX
         FcS5y/W09jdrkFC14bXhHWpoPvtLiqPqJlJGgbh8M5haSreXJtOqv+7XATuhv9ooeO85
         gJMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770888967; x=1771493767;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from
         :to:cc:subject:date:message-id:reply-to;
        bh=aaNajqUCbVH6NKKZgFxe2XVZqsv9heTJ6/BgQI66ZCU=;
        b=onYvdPAV7RGeR5V2D5i2tZE5rtrHS6Ns1xsarFi/9RS1JpUfL7qJI1pqa3G3QddPkv
         I+QkGWFkf3H8CIIdBbiFlqWZZSngNeJ9vQkNZGiXpPIimFNx0zWSnnRfJB3ohv6uDqsW
         5TaafYhTxL4Zmj3sW+BkZuUW2Rs43UZ796+mX64mR0d6b5DXVrVVLtWoI6gZEquaeNAb
         IMpkQbWhAHzpcO05WUiLGZd1AKHIF1qWaHt28G6ozIl+xV80lLv05CbO4jq6pWLdCiUo
         v5NyS6xS2tMlyQ03SgFnGgep2ubKA0NOfTmUug1Bi7EwI7YgAZF/Dx/b8iherBXEzU/A
         UQaw==
X-Forwarded-Encrypted: i=1; AJvYcCUS1O38kuFN5aHWlJbgdxHACVSvW21PY/TR6K0Sh9AAmG0e1FNLplJSltSO8TQM2IBR24eQORc=@vger.kernel.org
X-Gm-Message-State: AOJu0Yx/F5QyycnXnyExPWnUSD8VFdjt8Qzbc78/ZVs+GdXcqecpKlvG
	MnoNQWymYPbOCPeeHO6UH5UNjLmCHdbmtsf8i61LW19W1TtM6JmDSL26mlTODiI0rOEt4PIIpPX
	qrblr/QbdZzICzDV0m/9OLS8ClkFmcBwDxLQfBvp4lCxFvHJ5E9deHy69+wQ=
X-Gm-Gg: AZuq6aIkWpTvAK6QMbwqtgJvtiWIM+HzdJiaYZQWWjdsPqegO8QMkOZ0Zf4EZrzrgb/
	mAEap4jFvue3V5zq9ZrxU2iUY1v7GNtx5gyklM8UyEN6GwPb40O2k345zAZaWkBEJGl2i97uHKz
	QXlPIjAlOBoHc2gmcFeltFf99Lic8K2usQxxbr9nTyNAkIfC5nTVrkvkO9cy0nrUx4Ap34qFlW3
	cRSLwihtPxWqzezna2ooKopCmfwOg9fnWMGfqPP7bJBysU8a3bLDCPxm2i3cYy6pCtV5YONP3ll
	ManvzBWu
X-Received: by 2002:a05:622a:1110:b0:502:9ffa:1ae6 with SMTP id
 d75a77b69052e-50694f0a623mr15968021cf.82.1770888967284; Thu, 12 Feb 2026
 01:36:07 -0800 (PST)
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
References: <20260212075909.2952-1-xnguchen@sina.cn>
In-Reply-To: <20260212075909.2952-1-xnguchen@sina.cn>
From: Eric Dumazet <edumazet@google.com>
Date: Thu, 12 Feb 2026 10:35:56 +0100
X-Gm-Features: AZwV_QjXnpdhtByLqaQj244aO5GysHO27XP9rX_DzW677rvDS0863mqAwuPafJE
Message-ID: <CANn89iK+hLmcGL88m+DjubJiRegTg-En3bk9Ndg9_G6SAO7a5A@mail.gmail.com>
Subject: Re: [PATCH 6.6] tcp: use dst_dev_rcu() in tcp_fastopen_active_disable_ofo_check()
To: Chen Yu <xnguchen@sina.cn>
Cc: dsahern@kernel.org, kuba@kernel.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-DKIM: signer='google.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -7.1 (-------)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-7.1 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: msgid.link]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -7.5 USER_IN_DEF_DKIM_WL    From: address is in the default DKIM
                             welcome-list
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_MED          DKIMwl.org - Medium trust sender
SpamTally: Final spam score: -70

On Thu, Feb 12, 2026 at 8:59=E2=80=AFAM Chen Yu <xnguchen@sina.cn> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> [ Upstream commit b62a59c18b692f892dcb8109c1c2e653b2abc95c ]
>
> Use RCU to avoid a pair of atomic operations and a potential
> UAF on dst_dev()->flags.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: David Ahern <dsahern@kernel.org>
> Link: https://patch.msgid.link/20250828195823.3958522-8-edumazet@google.c=
om
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> [ Minor changed due to 6.6 doesn't have
> commit:a74fc62eec15 ("ipv4: adopt dst_dev, skb_dst_dev and skb_dst_dev_ne=
t[_rcu]") ]
> Signed-off-by: Chen Yu <xnguchen@sina.cn>
> ---
>  net/ipv4/tcp_fastopen.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/tcp_fastopen.c b/net/ipv4/tcp_fastopen.c
> index 408985eb74ee..27339cc7342c 100644
> --- a/net/ipv4/tcp_fastopen.c
> +++ b/net/ipv4/tcp_fastopen.c
> @@ -574,10 +574,11 @@ void tcp_fastopen_active_disable_ofo_check(struct s=
ock *sk)
>                 }
>         } else if (tp->syn_fastopen_ch &&
>                    atomic_read(&sock_net(sk)->ipv4.tfo_active_disable_tim=
es)) {
> -               dst =3D sk_dst_get(sk);
> +               rcu_read_lock();
> +               dst =3D __sk_dst_get(sk);
>                 if (!(dst && dst->dev && (dst->dev->flags & IFF_LOOPBACK)=
))

This is a wrong backport.

Really, a74fc62eec155c ("ipv4: adopt dst_dev, skb_dst_dev and
skb_dst_dev_net[_rcu]")
can not be avoided.


From - Thu Feb 12 17:52:57 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215932-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id KBHjLoqgjWn9DAAAYBR5ng
	(envelope-from <stable+bounces-215932-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 09:42:34 +0000
Return-path: <stable+bounces-215932-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 09:42:35 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215932-hi=josie.lol@vger.kernel.org>)
	id 1vqTDW-00000000tbI-1oa4
	for hi@josie.lol;
	Thu, 12 Feb 2026 09:42:34 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 60E36301B92A
	for <hi@josie.lol>; Thu, 12 Feb 2026 09:42:02 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id AF8CF2E0400;
	Thu, 12 Feb 2026 09:42:01 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Q1qqUXK4"
X-Original-To: stable@vger.kernel.org
Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 511452DE6F9
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 09:42:00 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.160.179
ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770889321; cv=pass; b=DCTYHl+LXIL2imZvFwpmGYxrRyhD2vscCq+8SQoG4nFSvL27O0XwI5X0tFDMSADppNs55+eKPkIqDu4+Iw6Uc9JcxFm1BTkJZTYtsqUULx9JNe8q71EkWnWBV81Yorsr3XIJ4W6g6DhAI95xaBRNjbKAKdgFONCgtzKUIIIZlWQ=
ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770889321; c=relaxed/simple;
	bh=zmTrhOt5I67WnfOpJVUIewScgn5nhORqAKcL5d/sLMk=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type; b=Bxmu9GydEz9eCkNmKtVSmREaGzNo3HTWgrDAy1b3tVUkU6pP9uuCLhUg3pmvjRcnji7+o+b5Y1zFPE+ixuNzF2sBKJ2Yl6Dc4kfHOYdMxBCo1FCEV7PZXZQ/PE41Oa0ijdYXtfjRZRuVM7tz/mbCW7nR9cZb3MPQR+WfWeMOVTI=
ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Q1qqUXK4; arc=pass smtp.client-ip=209.85.160.179
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com
Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-505d3baf1a7so315161cf.1
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 01:42:00 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1770889319; cv=none;
        d=google.com; s=arc-20240605;
        b=E+EdiS6Sy/+2f+19Irj6Pg7HEukfBR900jy596YVCWo8RR7HQlE5cfilacWhz4GNB0
         FQA8H9kzhkoYW6ZCGs499AWpujPZA6OYOOWxbQ4M3kVfVxWatOadpeHzdCdixFyICO/q
         zTFtuEmHnugzwuENWN9dJUHplQ++2qiMAOrr+uaV+ufgRDIHvi83wudPMlHkhgymhUvJ
         uvjOeqYElpfB4C4TrXrJR5RG/nqahQo1M38+NGUFm2uV8H5dMqO+SYo8u23hwHqsF9dH
         fD8ojooCusOvbG1eoI+CNOJck5MUCTVrOETjTV2WMGCmP7IyyGoVRMZpvRwFwIUr/0Df
         Q1ug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:dkim-signature;
        bh=VcH9GZLlhn0MK8AoO+gKd8YN91XeUHOY861U71nMAN8=;
        fh=BjRq9pe6fW6KSNFuNqrpLADClV1cT6u1nUHnXUrvG94=;
        b=Asdf86+Np/EI+qhbc3mQ+IWdaDjUXThWjXqA2OYUmDTpAzIpoGApK0u9BK6rcCW9bW
         +Do7J5d+PrwumGw9NygYWC6wlhGPSDE4WpQYNhvwdaydMTsjd5N1DysgPsuWgS7XFNkg
         RvjlAqvF7XROWSGTj1bracLK9PNdKNBOMnaQt97P6c38t62jJpHqIClS+7NAVwnfXvJR
         oPwdLCT6tSojppc3mrneVcSKGMuYS4ZhtehXlTVTNa+36T2GA7P1mV2KqNe/Pd0DIh/X
         BO6YYpQnxoIhNR9cbjx3Mno//hFNqvj4nG8urlNSJyz1llG0cjN0jHtpBCwaRoZNBauD
         xD1A==;
        darn=vger.kernel.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20230601; t=1770889319; x=1771494119; darn=vger.kernel.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=VcH9GZLlhn0MK8AoO+gKd8YN91XeUHOY861U71nMAN8=;
        b=Q1qqUXK4GwTcaceRdFfqh9QZbR37YdU9ouTMJt5eBKeRjCGpi63sXYBFYRZlwZDZRE
         HY1t5bFgnYX/mxL+SKccaOxT8xW46mXj8ncPRQ5mPj841cxzCrCO99N+58VYc/1OY55k
         WCbyo84fa2YrEn9OKswvMUUhzBGtkakhRxbWUltkJr4NcGm+5Sx7MUkMVSpdW9CBP44X
         x3nmfigvcA3Zor6jBc+P4tsWbNuXOz2izgNaaNIr6Pr1q9LJHDg4Oz3SHVKewjc7bk7w
         sAZ2bfI+ASQXit0qcQPOP/UnC4a0tO9f0J8/MK5ELmzG1Q9djSHh+GYuXZ8cr5zRnrX0
         oYpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770889319; x=1771494119;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=VcH9GZLlhn0MK8AoO+gKd8YN91XeUHOY861U71nMAN8=;
        b=gNkJy0ohg6g61MbbCzK6tKfouTtE7qpQHJrun7Q0kfWaAwIDhg8sUbkIXSnUuPx0E+
         /1KGksh0l6WECzXrycn2D3Lm40XvgTB4kPVDEaTFLGLhOAMH/xcsL/14K8VA2Ax4anRl
         Gu9T7EtcCicOXbdVWiEeBQL8UfIaI74P9wcWVq9M6bYpFVJbbe9kJ6lXTd1grZktDN8P
         iaGrQXA1enJXTAkmp9nSTB4wJWzRAxzyfLl3NV2+wWEywKCyXdsf0hbYdDlEC0VuT8+3
         qAj67t0zCp7bZkn0zj8Fz/C5fOkIrY6RL+5Y/JN/sRkmoVsSfxf8bAImgmBqVxhnVLBW
         8d9g==
X-Forwarded-Encrypted: i=1; AJvYcCWR/Fc4Bcc1TQ9uxoUEne6wYw1FLSwJsipbxMC1Er42rlS1mi+o3OWomV+t/toOCpV/dL87/mw=@vger.kernel.org
X-Gm-Message-State: AOJu0Yy5tm+c4HRFoCXwn9Yn3rdf949R6VIWZl5fzGEYrgy5uTj99dwH
	xMhIySYpG/GCk5VbavcEvPt4LaCmjTjW9o83MdwCdgJgGj/1faPWA1FS6uvdAHRI6zJpmDfs1Pi
	2bptw3i4w4G3pyDwawaYGU1aSgeTtvdunye+jS4a2
X-Gm-Gg: AZuq6aJVLzppqjIMItL3KamZ+qbZtaUJ85vr3cnBFRcsxQdYXJIS/+m1ZXtMMp0gww9
	c9hTh5rspXj1iS4W+QwzsSczRn49wX2y+iTIaZTYEadbMx47y68IK5/cJNqM51MFs3tDHToifjy
	ASB+LMO2+ENX9//hhH+KWzh65ddkZDaeTXBWmThuUWJhogurFj3AnPGh5U14nlzHFoayL7GDwD7
	6LNjp6Xwck7KLbMY3YOeTbtQHqw3qUHUx5xB9G64U3xyFRQTgfPHfxx/bcDdxYEo9yCKM7tqMyo
	3SVmY0Av
X-Received: by 2002:a05:622a:4f8e:b0:506:9852:75ec with SMTP id
 d75a77b69052e-506985282abmr2869311cf.9.1770889318777; Thu, 12 Feb 2026
 01:41:58 -0800 (PST)
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
References: <20260212090252.158689-1-tabba@google.com> <20260212090252.158689-2-tabba@google.com>
 <86jywib98e.wl-maz@kernel.org>
In-Reply-To: <86jywib98e.wl-maz@kernel.org>
From: Fuad Tabba <tabba@google.com>
Date: Thu, 12 Feb 2026 09:41:22 +0000
X-Gm-Features: AZwV_QiSeFqGPiRC70jpUcnw67INjoq4qSM1niKSMpmtbfB7i8EWB8CCB6Ry2n4
Message-ID: <CA+EHjTz-JU2gDfziCY2SguK9=6gGSCL5TN_U_C7FiZ5i0JTZqQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/3] KVM: arm64: Hide S1POE from guests when not
 supported by the host
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, 
	linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, 
	joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, 
	catalin.marinas@arm.com, will@kernel.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
X-DKIM: signer='google.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -7.1 (-------)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-7.1 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -7.5 USER_IN_DEF_DKIM_WL    From: address is in the default DKIM
                             welcome-list
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_MED          DKIMwl.org - Medium trust sender
SpamTally: Final spam score: -70

Hi Marc,

On Thu, 12 Feb 2026 at 09:29, Marc Zyngier <maz@kernel.org> wrote:
>
> Hi Fuad,
>
> On Thu, 12 Feb 2026 09:02:50 +0000,
> Fuad Tabba <tabba@google.com> wrote:
> >
> > When CONFIG_ARM64_POE is disabled, KVM does not save/restore POR_EL1.
> > However, ID_AA64MMFR3_EL1 sanitisation currently exposes the feature to
> > guests whenever the hardware supports it, ignoring the host kernel
> > configuration.
>
> This is the umpteenth time we get caught by this. PAN was the latest
> instance until this one. Maybe an approach would be to have a default
> override when a config option is not enabled, so that KVM is
> consistent with the rest of the kernel?

I spoke to Will about this, and one thing he'll look into is whether
this value in `struct arm64_ftr_reg` can be made consistent with the
cpu configuration itself (in cpufeature.c itself) . This would avoid
the problem altogether if possible. The question is whether the kernel
needs to somehow know that a certain feature exists even if it's
disabled in the config...

If he thinks it's not doable at that level, I'll look into
alternatives to make it correct by construction.

> >
> > If a guest detects this feature and attempts to use it, the host will
> > fail to context-switch POR_EL1, potentially leading to state corruption.
> >
> > Fix this by masking ID_AA64MMFR3_EL1.S1POE and preventing KVM from
> > advertising the feature when the host does not support it, i.e.,
> > system_supports_poe() is false.
> >
> > Fixes: 70ed7238297f ("KVM: arm64: Sanitise ID_AA64MMFR3_EL1")
> > Signed-off-by: Fuad Tabba <tabba@google.com>
> > ---
> >  arch/arm64/include/asm/kvm_host.h | 3 ++-
> >  arch/arm64/kvm/sys_regs.c         | 3 +++
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> > index ac7f970c7883..7af72ca749a6 100644
> > --- a/arch/arm64/include/asm/kvm_host.h
> > +++ b/arch/arm64/include/asm/kvm_host.h
> > @@ -1592,7 +1592,8 @@ void kvm_set_vm_id_reg(struct kvm *kvm, u32 reg, u64 val);
> >       (kvm_has_feat((k), ID_AA64MMFR3_EL1, S1PIE, IMP))
> >
> >  #define kvm_has_s1poe(k)                             \
> > -     (kvm_has_feat((k), ID_AA64MMFR3_EL1, S1POE, IMP))
> > +     (system_supports_poe() &&                       \
> > +      kvm_has_feat((k), ID_AA64MMFR3_EL1, S1POE, IMP))
>
> Why do we need to further key this on system_supports_poe()? I can see
> this is a potential optimisation, but I don't think this is part of
> the minimal fix.

I did this to be consistent with similar checks, e.g., kvm_has_fpmr().
I can remove it or put it in a separate patch, whichever you prefer.

>
> >
> >  #define kvm_has_ras(k)                                       \
> >       (kvm_has_feat((k), ID_AA64PFR0_EL1, RAS, IMP))
> > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> > index 88a57ca36d96..237e8bd1cf29 100644
> > --- a/arch/arm64/kvm/sys_regs.c
> > +++ b/arch/arm64/kvm/sys_regs.c
> > @@ -1816,6 +1816,9 @@ static u64 __kvm_read_sanitised_id_reg(const struct kvm_vcpu *vcpu,
> >                      ID_AA64MMFR3_EL1_SCTLRX |
> >                      ID_AA64MMFR3_EL1_S1POE |
> >                      ID_AA64MMFR3_EL1_S1PIE;
> > +
> > +             if (!system_supports_poe())
> > +                     val &= ~ID_AA64MMFR3_EL1_S1POE;
>
> How about S1PIE? It seems to have a similar problem, in the sense that
> it has extra state. But I guess because we don't put it behind a
> config option, we context-switch it anyway and all is good?

Like you said, S1PIE doesn't have a config option. I thought if I were
to add one to S1PIE, then why not add one to the other features that
don't have config options... It is conceivable that a config option
might be added in the future, but like you noted above, I think we
need a deeper fix that nips this problem in the bud.

Let's see if Will thinks that we can fix this at the `arm64`
cpufeature layer, rather than somewhere in KVM.

Cheers,
/fuad

> Thanks,
>
>         M.
>
> --
> Without deviation from the norm, progress is not possible.


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215933-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 2CV/D1mijWmRBAQAYBR5ng
	(envelope-from <stable+bounces-215933-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 09:50:17 +0000
Return-path: <stable+bounces-215933-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 09:50:17 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215933-hi=josie.lol@vger.kernel.org>)
	id 1vqTKy-000000019j8-2DyE
	for hi@josie.lol;
	Thu, 12 Feb 2026 09:50:16 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 61D1B3094FAD
	for <hi@josie.lol>; Thu, 12 Feb 2026 09:50:05 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id B53342C234C;
	Thu, 12 Feb 2026 09:50:04 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CRCnp2Uw";
	dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UM1tzJ7u"
X-Original-To: stable@vger.kernel.org
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DB4E6F2F2
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 09:50:03 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770889804; cv=none; b=tVv6a2brF0ZXNSrH4V/NexujylbxgkcwwKMV1ZnKDSYoidWazUKI5JZhecaaJcIS7ypvVw3iTAo+oXPA4/ZrlVzuTbcAnGeWJ0nhq3n/pQCjSirQ4DWKRF8pDUSsml/aTSWN89OY5lqfAJjNpdpLGGeLedo9h7HbFMs1clBxNd4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770889804; c=relaxed/simple;
	bh=ssiBpGwudSOhWWpXd6ltuV0trtgpSjINF3dITy6pg0s=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=goRogSRc37fNW6WK3xNFqlFqGGhrb/P2WrCw+h58OjY4ttZavo3EQ7LwWOpSu0ztMYzIF383KnJPx1CwGGGvpDrK89g/yR03Llci/8iurI5K4o5uDwTiV2Pmde49O6KG16CPl8rxnPG9jXaToQpwh3JqOn/YzL9l901ex0RrR2c=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CRCnp2Uw; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UM1tzJ7u; arc=none smtp.client-ip=170.10.129.124
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1770889802;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7izo/A5Ul08EXM2WpJ9NM5vTC0yA5lFDEQbyiP4NFcY=;
	b=CRCnp2UwTvVzBCMIWlVfd4+IXB3P8x9g5GNV+WL6SeueerGzvkGLz/9sslIX0u5YeaN803
	sKQMHYZ0xP+8mYmMi9QzZiuuK+kdHxuJvRtzNCB17Mxuxbx368ETnNcsQoSemHHjQIxvzV
	V6yiKGl1XJ3E22Wg4gC8dP66IKjTO8M=
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
 us-mta-117-TqKA0r1rNvisEOucRxLB6g-1; Thu, 12 Feb 2026 04:50:00 -0500
X-MC-Unique: TqKA0r1rNvisEOucRxLB6g-1
X-Mimecast-MFC-AGG-ID: TqKA0r1rNvisEOucRxLB6g_1770889800
Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48336b182ebso35252575e9.3
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 01:50:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=redhat.com; s=google; t=1770889799; x=1771494599; darn=vger.kernel.org;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=7izo/A5Ul08EXM2WpJ9NM5vTC0yA5lFDEQbyiP4NFcY=;
        b=UM1tzJ7u887hU+Bo0jjFMc6ZolvP1/wL5b1+c4dpfRfi5cvyD2swHCSKQCQPbQSR0J
         li8uh3p/z5tLWsEz+tIr3j6xPlt+rFU8uvnAvq5gJjNddkGXLLaHt7BFBDc3z3UDWalC
         G9bcoJ5t+/pZroQHSPznmWPkdRLaH3GXjq1o17LiHeBto7wwy0Y5D4wlomqF8uv7OLpf
         sE0jnRptuDbtMmXtHR+h0/2Jd2z8ZtDicQrQHTwwS3WpYMnrWCBurmjB6Lhvs+iePzFL
         PkCiwqn0603bq+S68IsNBCthG30Y0al64X0cdp17vPlM8u6KJGniye3o1BtC3vwksFgI
         pGIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770889799; x=1771494599;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=7izo/A5Ul08EXM2WpJ9NM5vTC0yA5lFDEQbyiP4NFcY=;
        b=LBCZaHXyeYCrBW0J4Mmzpvy+9oQgL48eynIfpkdHRSxrL+/6/aP8UUNPweNUxCFWng
         6sXvYrwr480DvFZXH+P8s+3wdHfBE4ienkaUV/m6PnmdSMaJ3FuyLqnm5JV4FQWLFWJK
         vkfD8aouKgYCxAuFuev73TluLmgV8FVvE6Upe9ECKUWixruLY/0+pEf0iYCHaecQ0fkC
         EjwIx+2G0uZ37PxhBWuOms2vYEj4UsnFgq/y5eAV04INS8BRLiPzH4Vzk/+hhgyZpAIf
         6poj/Luj0MbN7BmR08/hSaVl4yI7h5duToV3+/V0cYccxUTA21USN9fp+IQoADg0yyvF
         tuGg==
X-Forwarded-Encrypted: i=1; AJvYcCUMtSHGP3BagTX57d8sgRx2u6Rf35SY9M6Fxla9chVzntZsH8LYhw5+GQ6xOcLXdp3Qu+zVtuQ=@vger.kernel.org
X-Gm-Message-State: AOJu0YwTzLnsmPR+KTFM+lwe+AM5ddUgDadoJmEBGphLms23taz/wsd6
	10+Q18Gh//gVLXidSTCYgCe4eGz87kRLfIOHC7m0NMKYlfzZT9Jxx4rq6wf+gGAr9pkm0MWP0oa
	FocAdX4kD2rkROsACETm4wrjggVkI6b26gCvPL1TsvevCNIou2xSFV748vQ==
X-Gm-Gg: AZuq6aIDoYmur6gVEjJ1u1G6Q+lenkHAGnEYNmgX/TJB7gn0GhSnfPtcK5FUgQjWumU
	66nmq9BRt2qP/P0kcB81m2gIGaLveqnsTpTdcybH2t35sppOlPiubUrxyZlMs32ZlkKlW3a2FW2
	eyfCi+8c9POmi3YkYzvwfTobxrni4I6IwwDf8kxJatiG2Ze4Rm2uF4dMfjLGH7DwTT+XQUcnGb3
	2nr8I5RBjpvG4FMKxsc8LLCzor7KFGIAtzLIh9O17Vo3FsxhnCa9UDDktPrEXuxjgnUdPWw3dZa
	4tMC01IDxfUjSow4c7Qloz3XZswX5P8lEYXR3DevCC9BSI4Lj0mNbYxOVl1Wg422lwVSlfIdYA6
	Sobzui0oUbNiZCBOtvVoPKSxXdfu7G44RF14J/1hJq3Go/ZeAvdqPHSsKQhbnCw==
X-Received: by 2002:a05:600c:c08f:b0:483:6e32:50d4 with SMTP id 5b1f17b1804b1-4836e3250ddmr2220565e9.18.1770889799516;
        Thu, 12 Feb 2026 01:49:59 -0800 (PST)
X-Received: by 2002:a05:600c:c08f:b0:483:6e32:50d4 with SMTP id 5b1f17b1804b1-4836e3250ddmr2220055e9.18.1770889799021;
        Thu, 12 Feb 2026 01:49:59 -0800 (PST)
Received: from ?IPV6:2a01:e0a:c:37e0:8998:e0cf:68cc:1b62? ([2a01:e0a:c:37e0:8998:e0cf:68cc:1b62])
        by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4836aa0847asm29634535e9.3.2026.02.12.01.49.57
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Thu, 12 Feb 2026 01:49:58 -0800 (PST)
Message-ID: <e9d35c78-1c4b-4a9c-8cf0-9531e972279f@redhat.com>
Date: Thu, 12 Feb 2026 10:49:54 +0100
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] drm/hyperv: During panic do VMBus unload after frame
 buffer is flushed
To: mhklkml@zohomail.com, mhklinux@outlook.com, drawat.floss@gmail.com,
 maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de,
 airlied@gmail.com, simona@ffwll.ch, kys@microsoft.com,
 haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
 longli@microsoft.com, ryasuoka@redhat.com
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
 linux-hyperv@vger.kernel.org, stable@vger.kernel.org
References: <20260209070201.1492-1-mhklinux@outlook.com>
 <20260209070201.1492-2-mhklinux@outlook.com>
 <a5372b72-8dc0-4f2d-ad5c-086f3e75ee81@redhat.com>
 <002601dc9baa$517d8b40$f478a1c0$@zohomail.com>
Content-Language: en-US, fr
From: Jocelyn Falempe <jfalempe@redhat.com>
In-Reply-To: <002601dc9baa$517d8b40$f478a1c0$@zohomail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-DKIM: signer='redhat.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

On 12/02/2026 00:01, mhklkml@zohomail.com wrote:
> From: Jocelyn Falempe <jfalempe@redhat.com> Sent: Wednesday, February 11, 2026 1:54 PM
>>
>> On 09/02/2026 08:02, mhkelley58@gmail.com wrote:
>>> From: Michael Kelley <mhklinux@outlook.com>
>>>
>>> In a VM, Linux panic information (reason for the panic, stack trace,
>>> etc.) may be written to a serial console and/or a virtual frame buffer
>>> for a graphics console. The latter may need to be flushed back to the
>>> host hypervisor for display.
>>>
>>> The current Hyper-V DRM driver for the frame buffer does the flushing
>>> *after* the VMBus connection has been unloaded, such that panic messages
>>> are not displayed on the graphics console. A user with a Hyper-V graphics
>>> console is left with just a hung empty screen after a panic. The enhanced
>>> control that DRM provides over the panic display in the graphics console
>>> is similarly non-functional.
>>>
>>> Commit 3671f3777758 ("drm/hyperv: Add support for drm_panic") added
>>> the Hyper-V DRM driver support to flush the virtual frame buffer. It
>>> provided necessary functionality but did not handle the sequencing
>>> problem with VMBus unload.
>>>
>>> Fix the full problem by using VMBus functions to suppress the VMBus
>>> unload that is normally done by the VMBus driver in the panic path. Then
>>> after the frame buffer has been flushed, do the VMBus unload so that a
>>> kdump kernel can start cleanly. As expected, CONFIG_DRM_PANIC must be
>>> selected for these changes to have effect. As a side benefit, the
>>> enhanced features of the DRM panic path are also functional.
>>
>> Thanks for properly fixing this issue with DRM Panic on hyperv.
>>
>> I've a small comment below.
>>
>> With that fixed:
>> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
>>
>> The first patch looks good too, I can review it if no other step up, as
>> I'm not familiar with hyperv.
>>
>>>
>>> Fixes: 3671f3777758 ("drm/hyperv: Add support for drm_panic")
>>> Signed-off-by: Michael Kelley <mhklinux@outlook.com>
>>> ---
>>>    drivers/gpu/drm/hyperv/hyperv_drm_drv.c     |  4 ++++
>>>    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 15 ++++++++-------
>>>    2 files changed, 12 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>>> index 06b5d96e6eaf..79e51643be67 100644
>>> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>>> @@ -150,6 +150,9 @@ static int hyperv_vmbus_probe(struct hv_device *hdev,
>>>    		goto err_free_mmio;
>>>    	}
>>>
>>> +	/* If DRM panic path is stubbed out VMBus code must do the unload */
>>> +	if (IS_ENABLED(CONFIG_DRM_PANIC) && IS_ENABLED(CONFIG_PRINTK))
>>
>> I think drm_panic should still work without printk.
>> The "user" panic screen would be unaffected, but the "kmsg" screen might
>> be blank, and the "qr_code" would generate an empty qr code.
>> (Actually I never tried to build a kernel without printk).
> 
> Yeah, I had never built such a kernel either until recently when the kernel
> test robot flagged an error in Hyper-V code when CONFIG_PRINTK is not set. :-)
> 
> But for this patch, the issue is that drm_panic() never gets called if CONFIG_PRINTK
> isn't set. In that case, kmsg_dump_register() is a stub that returns an error.  So
> drm_panic_register() never registers the callback to drm_panic(). And if
> drm_panic() isn't going to run, responsibility for doing the VMBus unload
> must remain with the VMBus code. It's hard to actually test this case because
> of depending on printk() for debugging output, so double-check my
> thinking.

Ok you're right. I changed from 
atomic_notifier_chain_register(&panic_notifier_list, ...) to 
kmsg_dump_register() in the v10 of drm_panic.

So I should either make DRM_PANIC depends on PRINTK, or call 
atomic_notifier_chain_register() if PRINTK is not defined.

As I think kernel without PRINTK are uncommon, I'll probably do the 
first solution.

-- 

Jocelyn
> 
> Michael
> 
>>
>>> +		vmbus_set_skip_unload(true);
>>>    	drm_client_setup(dev, NULL);
>>>
>>>    	return 0;
> 



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <linux-s390+bounces-16300-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id CBszO8GijWmNEQIAYBR5ng
	(envelope-from <linux-s390+bounces-16300-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 09:52:01 +0000
Return-path: <linux-s390+bounces-16300-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 09:52:02 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <linux-s390+bounces-16300-hi=josie.lol@vger.kernel.org>)
	id 1vqTMf-00000001DT2-1MQc
	for hi@josie.lol;
	Thu, 12 Feb 2026 09:52:01 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 3424E30014BC
	for <hi@josie.lol>; Thu, 12 Feb 2026 09:51:30 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id CAB272D47F1;
	Thu, 12 Feb 2026 09:51:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="KzsB5jse"
X-Original-To: linux-s390@vger.kernel.org
Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07C7B2B9A4;
	Thu, 12 Feb 2026 09:51:25 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.97
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770889889; cv=none; b=eMn4hjfbExVOhVTzPaeRHRJ7BV+rQ2wOkRs4KppF2xQKlywJ0Dcjt7p08FkXLEwuyKEe4ZrwO1wGQb2j+M/418FRLZo/W8LpYoESrQZyKnrtRZsrt7PYmFB4JwDWdgXT1FezGxXGP7fGFwVH45fa+Cc1/CEdt4I/VqvB33wzpy0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770889889; c=relaxed/simple;
	bh=B7sBeI2OHeGzGmEM1MDciZvw3RM4fLtNiVKVRT4HeoU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=MDO+M2o+xl/1JcF6QcpxSsY8UZznVnC0rN91KfHGKmBnTEfHu51sHEZr9WUhYn9HqQCsaRKsdwn5dQhmcxqKcfc8eqiqwroKU89+W5H1ocug98pKjKTWvLjVis4NcdhP0kffXrRv65Xh1KIQmeBwngJ1MTIXIse/mMSj6kFk1O0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=KzsB5jse; arc=none smtp.client-ip=115.124.30.97
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com
DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=linux.alibaba.com; s=default;
	t=1770889883; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type;
	bh=qpruaUwKwh867x0HVlxV3T2XoeP5v0Ct5QMf35UW6c8=;
	b=KzsB5jseH9KBJrEiaBxupfDEKfEu0bEOqa6aO3ELO30XhuxMCNY1Uhq+erULMCmoIhnoVVWXBsR2FHDxY8+B28Ig9EwiiGFm3utBQdmjYFNnwy4CWyVyTiYLH8DW08qlnqf+nAAas4TGSLfzqLHEMpKoXAo3x9n8YmEyzVZZaUQ=
Received: from localhost(mailfrom:alibuda@linux.alibaba.com fp:SMTPD_---0Wz4YnRr_1770888937 cluster:ay36)
          by smtp.aliyun-inc.com;
          Thu, 12 Feb 2026 17:35:37 +0800
Date: Thu, 12 Feb 2026 17:35:37 +0800
From: "D. Wythe" <alibuda@linux.alibaba.com    >
To: Dust Li <dust.li@linux.alibaba.com>
Cc: "D. Wythe" <alibuda@linux.alibaba.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Sidraya Jayagond <sidraya@linux.ibm.com>,
	Wenjia Zhang <wenjia@linux.ibm.com>,
	Mahanta Jambigi <mjambigi@linux.ibm.com>,
	Simon Horman <horms@kernel.org>, Tony Lu <tonylu@linux.alibaba.com>,
	Wen Gu <guwen@linux.alibaba.com>, linux-kernel@vger.kernel.org,
	linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org,
	netdev@vger.kernel.org, oliver.yang@linux.alibaba.com,
	pasic@linux.ibm.com
Subject: Re: [PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
Message-ID: <20260212093537.GA27899@j66a10360.sqa.eu95>
References: <20260202094800.30373-1-alibuda@linux.alibaba.com>
 <aYx7Uh9MmJsPWUu4@linux.alibaba.com>
Precedence: bulk
X-Mailing-List: linux-s390@vger.kernel.org
List-Id: <linux-s390.vger.kernel.org>
List-Subscribe: <mailto:linux-s390+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-s390+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aYx7Uh9MmJsPWUu4@linux.alibaba.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-DKIM: signer='linux.alibaba.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 3.4 (+++)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (3.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
  3.0 FROM_ADDR_WS           Malformed From address
SpamTally: Final spam score: 34

On Wed, Feb 11, 2026 at 08:51:30PM +0800, Dust Li wrote:
> On 2026-02-02 17:48:00, D. Wythe wrote:
> >The current SMC-R implementation relies on global per-device CQs
> >and manual polling within tasklets, which introduces severe
> >scalability bottlenecks due to global lock contention and tasklet
> >scheduling overhead, resulting in poor performance as concurrency
> >increases.
> >
> >Refactor the completion handling to utilize the ib_cqe API and
> >standard RDMA core CQ pooling. This transition provides several key
> >advantages:
> >
> >1. Multi-CQ: Shift from a single shared per-device CQ to multiple
> >link-specific CQs via the CQ pool. This allows completion processing
> >to be parallelized across multiple CPU cores, effectively eliminating
> >the global CQ bottleneck.
> >
> >2. Leverage DIM: Utilizing the standard CQ pool with IB_POLL_SOFTIRQ
> >enables Dynamic Interrupt Moderation from the RDMA core, optimizing
> >interrupt frequency and reducing CPU load under high pressure.
> >
> >3. O(1) Context Retrieval: Replaces the expensive wr_id based lookup
> >logic (e.g., smc_wr_tx_find_pending_index) with direct context retrieval
> >using container_of() on the embedded ib_cqe.
> >
> >4. Code Simplification: This refactoring results in a reduction of
> >~150 lines of code. It removes redundant sequence tracking, complex lookup
> >helpers, and manual CQ management, significantly improving maintainability.
> 
> Excellent !
> 
> Some comments below.
> 
> >
> >Performance Test: redis-benchmark with max 32 connections per QP
> >Data format: Requests Per Second (RPS), Percentage in brackets
> >represents the gain/loss compared to TCP.
> >
> >| Clients | TCP      | SMC (original)      | SMC (cq_pool)       |
> >|---------|----------|---------------------|---------------------|
> >| c = 1   | 24449    | 31172  (+27%)       | 34039  (+39%)       |
> >| c = 2   | 46420    | 53216  (+14%)       | 64391  (+38%)       |
> >| c = 16  | 159673   | 83668  (-48%)  <--  | 216947 (+36%)       |
> >| c = 32  | 164956   | 97631  (-41%)  <--  | 249376 (+51%)       |
> >| c = 64  | 166322   | 118192 (-29%)  <--  | 249488 (+50%)       |
> >| c = 128 | 167700   | 121497 (-27%)  <--  | 249480 (+48%)       |
> >| c = 256 | 175021   | 146109 (-16%)  <--  | 240384 (+37%)       |
> >| c = 512 | 168987   | 101479 (-40%)  <--  | 226634 (+34%)       |
> >
> >The results demonstrate that this optimization effectively resolves the
> >scalability bottleneck, with RPS increasing by over 110% at c=64
> >compared to the original implementation.
> >
> >Signed-off-by: D. Wythe <alibuda@linux.alibaba.com>
> >---
> > net/smc/smc_core.c |   8 +-
> > net/smc/smc_core.h |  16 ++-
> > net/smc/smc_ib.c   | 114 ++++++-------------
> > net/smc/smc_ib.h   |   5 -
> > net/smc/smc_tx.c   |   1 -
> > net/smc/smc_wr.c   | 267 ++++++++++++++++-----------------------------
> > net/smc/smc_wr.h   |  38 ++-----
> > 7 files changed, 150 insertions(+), 299 deletions(-)
> >
> >diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c
> >index 8aca5dc54be7..9590c8aed3dd 100644
> >--- a/net/smc/smc_core.c
> >+++ b/net/smc/smc_core.c
> >@@ -815,17 +815,11 @@ int smcr_link_init(struct smc_link_group *lgr, struct smc_link *lnk,
> > 	lnk->lgr = lgr;
> > 	smc_lgr_hold(lgr); /* lgr_put in smcr_link_clear() */
> > 	lnk->link_idx = link_idx;
> >-	lnk->wr_rx_id_compl = 0;
> > 	smc_ibdev_cnt_inc(lnk);
> > 	smcr_copy_dev_info_to_link(lnk);
> > 	atomic_set(&lnk->conn_cnt, 0);
> 
> I think this isn't unlikey, we haven't signal the RDMA WRITE wr, so it
> shouldn't have CQEs when wc->status == 0.
> If we are here, wc->status should always != 0.
> 

Nice catch, I mixed this up with the rwwi version.

> 
> >+}
> >+
> >+static void smc_wr_reg_process_cqe(struct ib_cq *cq, struct ib_wc *wc)
> >-		       sizeof(*link->wr_tx_v2_pend));
> Why remove this memset ?
> 
> >-		memset(link->lgr->wr_tx_buf_v2, 0,
> >-		       sizeof(*link->lgr->wr_tx_buf_v2));
> >+		memset(link->lgr->wr_tx_buf_v2, 0, sizeof(*link->lgr->wr_tx_buf_v2));
> > 	} else {
> >-		link->wr_tx_pends[pnd_snd_idx].wc_status = wc->status;
> >-		if (link->wr_tx_pends[pnd_snd_idx].compl_requested)
> >+		if (tx_pend->compl_requested)
> > 			complete(&link->wr_tx_compl[pnd_snd_idx]);
> >-		memcpy(&pnd_snd, &link->wr_tx_pends[pnd_snd_idx],
> >-		       sizeof(pnd_snd));
> >-		/* clear the full struct smc_wr_tx_pend including .priv */
> >-		memset(&link->wr_tx_pends[pnd_snd_idx], 0,
> >-		       sizeof(link->wr_tx_pends[pnd_snd_idx]));
> 
> ditto
> 

Looks like I accidentally deleted this code, I will restore it in the
next version.

> >-		memset(&link->wr_tx_bufs[pnd_snd_idx], 0,
> >-		       sizeof(link->wr_tx_bufs[pnd_snd_idx]));
> >+		memset(&link->wr_tx_bufs[tx_pend->idx], 0, sizeof(link->wr_tx_bufs[tx_pend->idx]));
> > 		if (!test_and_clear_bit(pnd_snd_idx, link->wr_tx_mask))
> > 			return;
> > 	}
> > 
> >-	if (wc->status) {
> >+	if (unlikely(wc->status)) {
> > 		if (link->lgr->smc_version == SMC_V2) {
> > 			memset(link->wr_tx_v2_pend, 0,
> > 			       sizeof(*link->wr_tx_v2_pend));
> >@@ -128,44 +117,12 @@ static inline void smc_wr_tx_process_cqe(struct ib_wc *wc)
> > 		/* terminate link */
> > 		smcr_link_down_cond_sched(link);
> > 	}
> >+		smc_wr_rx_init_cqe(&link->wr_rx_ibs[i].cqe);
> >+		link->wr_rx_ibs[i].wr.wr_cqe = &link->wr_rx_ibs[i].cqe;
> >+		link->wr_rx_ibs[i].index = i;
> >+	}
> 
> Can we group all those xxx_init_cqe into a function and move them out of
> smc_wr_alloc_link_mem() ? All what smc_wr_alloc_link_mem() is all about
> allocating memory.
> 
> Maybe we can define a smc_wr_init_cqes() and call it in
> smc_wr_create_link() ?
> 
> 

Sounds reasonable, I'll implement this in the next version.
Additionally, other items like removing redundant fields and renaming
the index will also be addressed in the same update.

Thanks,
D. Wythe

> Best regards,
> Dust


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <io-uring+bounces-12176-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id mL59Jn2mjWmHSQQAYBR5ng
	(envelope-from <io-uring+bounces-12176-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:07:57 +0000
Return-path: <io-uring+bounces-12176-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:07:57 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <io-uring+bounces-12176-hi=josie.lol@vger.kernel.org>)
	id 1vqTc4-00000001gMT-1Hzk
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:07:57 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id F0439301CCEB
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:07:54 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id B74AD2D6E58;
	Thu, 12 Feb 2026 10:07:54 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YWH/5Izb"
X-Original-To: io-uring@vger.kernel.org
Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id F339E246BA7;
	Thu, 12 Feb 2026 10:07:49 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770890874; cv=none; b=leDY7TAtojcmdOoNrOnI2lT8aFcLEcNSJzle3QsynJDduWuK/2hVoNC0iH3KLs1JF8IRfMwEA7zI91xJJ2y7EjJw39Kb17HpnDb50zOCiHSRTFd3iNpx0oUtHWZHURebbuTnAU0H3J3GAgzU0G6JUp4ThTbb/pbkzQGwFv9eMjU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770890874; c=relaxed/simple;
	bh=uTyItwhkWyUdGHdWTNVgB/OwNLaAluY2qSDBafx/3dU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=sx++4e1/RCB+Hxn3e7z0kH5NhFtB3D8En37dPrZC2StUTAyOSwXeshDdN+Oho1WYZ+40UhfMdRwGLAMJC0d44bEBSEyI0lD90r1ZMl9ws9DqNxU7B4NMFgrGOW9V3qgGvGkbu/3OQ/pE1/C4vT453OzxnqhsHLu4JX7HraWJB/Y=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=YWH/5Izb; arc=none smtp.client-ip=198.137.202.133
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org
Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=jSlX9h8f/KU7AnNLwZBHlCdwR/NrX+FSMXQajoFNUxM=; b=YWH/5IzbWtN6t6m9InMkRDgPEa
	dc6Fov4F7pnYfAY6Foqeaqu3e/ph7K4ikhMfu2iwY75Hxui4x6QOdCzsosdpdukZD81HIwk74H4UE
	gVLWa4AMOovmCpmM6+DbcJp3xgPnYY2KeA/FAHFKS1OE77FFUJLii+sdJFkDeFWfEvHBbJ2nvSlAr
	Ga0wyfoqOjrDWzyU6FNDLaYIXp34DoRWhUh386XdxLzwiuv2e5cRHe3mvDPR0iUfNfG64et1Ugzc6
	KXOtHkASTjm7qtPDsL5TV1rHBltpX8mOBydYleC9WHZSH8heK3BhAzpEf/sxbWO6JhZVP0uEXim47
	KUXG4oIQ==;
Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux))
	id 1vqTbw-00000001tyA-08vU;
	Thu, 12 Feb 2026 10:07:48 +0000
Date: Thu, 12 Feb 2026 02:07:48 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: Pavel Begunkov <asml.silence@gmail.com>, axboe@kernel.dk,
	io-uring@vger.kernel.org, csander@purestorage.com, krisman@suse.de,
	bernd@bsbernd.com, hch@infradead.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v1 03/11] io_uring/kbuf: add support for kernel-managed
 buffer rings
Message-ID: <aY2mdLkqPM0KfPMC@infradead.org>
References: <20260210002852.1394504-1-joannelkoong@gmail.com>
 <20260210002852.1394504-4-joannelkoong@gmail.com>
 <89c75fc1-2def-4681-a790-78b12b45478a@gmail.com>
 <CAJnrk1ZZyYmwtzcHAnv2x8rt=ZVsz7CXCVV6jtgMMDZytyxp3A@mail.gmail.com>
 <1c657f67-0862-4e13-9c71-7217aeecef61@gmail.com>
 <CAJnrk1YXmxqUnT561-J7seaicxFRJTyJ=F3_MX1rmtAROC6Ybg@mail.gmail.com>
Precedence: bulk
X-Mailing-List: io-uring@vger.kernel.org
List-Id: <io-uring.vger.kernel.org>
List-Subscribe: <mailto:io-uring+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:io-uring+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJnrk1YXmxqUnT561-J7seaicxFRJTyJ=F3_MX1rmtAROC6Ybg@mail.gmail.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
X-DKIM: signer='infradead.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: infradead.org]
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On Wed, Feb 11, 2026 at 02:06:18PM -0800, Joanne Koong wrote:
> > I don't think I follow. I'm saying that it might be interesting
> > to separate rings from how and with what they're populated on the
> > kernel API level, but the fuse kernel module can do the population
> 
> Oh okay, from your first message I (and I think christoph too) thought
> what you were saying is that the user should be responsible for
> allocating the buffers with complete ownership over them, and then
> just pass those allocated to the kernel to use. But what you're saying
> is that just use a different way for getting the kernel to allocate
> the buffers (eg through the IORING_REGISTER_MEM_REGION interface). Am
> I reading this correctly?

I'm arguing exactly against this.  For my use case I need a setup
where the kernel controls the allocation fully and guarantees user
processes can only read the memory but never write to it.  I'd love
to be able to piggy back than onto your work.



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215934-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id kPwBDcqnjWnUagUAYBR5ng
	(envelope-from <stable+bounces-215934-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:13:30 +0000
Return-path: <stable+bounces-215934-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:13:30 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215934-hi=josie.lol@vger.kernel.org>)
	id 1vqThR-00000001pxF-3R07
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:13:30 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 77972303A86A
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:10:12 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 9E06D2DFA32;
	Thu, 12 Feb 2026 10:10:11 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fCuZ5hRP";
	dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="G8oDHDL+"
X-Original-To: stable@vger.kernel.org
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6575D2DC333
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 10:10:10 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770891011; cv=none; b=G/On7Km62Hhb3RS5AReuZfgXY92hM0V4ee7NFC3Q0oYReK5PrQMhDR6QugugIA+nAjmriiSuhL1835HytDUCO6kRGTXHc34tIwzpczx30sTFOZESjEhy4Cj9W/10CHntRnDCvm1AJwOSAnMnTnnCJABmiLWYQVM1IPnhZCx89f0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770891011; c=relaxed/simple;
	bh=SGaCcfVfOD01Cl86Knz26tLX4aJ70u9hQYfrkP4z5FM=;
	h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:
	 In-Reply-To:Content-Type; b=nt0fizC5VOxONmKlDvy99P18++Y4NGB6T/a7MfWbkUCK8PA4lPDbMwsEdMSDGA5Q3ZwK2mzfQAXzjCspZtCA/Zb8IBAWBkHUvsDo4f0yHFfSeGLD4WjaLVceNbGghgFsad+DcfeDJ1XXxLHhfMmAV4wqo9488cxg33zk3bV99nY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fCuZ5hRP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=G8oDHDL+; arc=none smtp.client-ip=170.10.133.124
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1770891009;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MGtZzlI0afIe1oXYIL6I39556RNwafluFe5WLDNAu60=;
	b=fCuZ5hRPPsi9frrPBgZr4n+Fj40n+pXi7ahjL3h4ICbhv9aR46ELDXQD5hg6DCg2G/6MQf
	nnSpBW4YMFcH3rGG9uOlOaw/z1SzeKqy54fEoTO40rbyf97srihrqNoykLvWBLtGhac4FI
	Pc7SNicQWOKb+sj5zC4ToIfWc9z35Sg=
Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com
 [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
 us-mta-450-V5YWIOKfM96q0fpE6RYJOQ-1; Thu, 12 Feb 2026 05:10:07 -0500
X-MC-Unique: V5YWIOKfM96q0fpE6RYJOQ-1
X-Mimecast-MFC-AGG-ID: V5YWIOKfM96q0fpE6RYJOQ_1770891006
Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4368060a5e5so4415884f8f.3
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 02:10:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=redhat.com; s=google; t=1770891006; x=1771495806; darn=vger.kernel.org;
        h=content-transfer-encoding:in-reply-to:content-language:references
         :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to
         :cc:subject:date:message-id:reply-to;
        bh=MGtZzlI0afIe1oXYIL6I39556RNwafluFe5WLDNAu60=;
        b=G8oDHDL+lGk9V1J+uwIuvYtRI0vcK8NFlpD8Yv/Hg+9H52Sqq7jpe+2v2hnNXwhPdJ
         lY7EkkAKvnl3FreULZEFDFxLt8k6mpOOoexij1IRqMpiZsep5XoMo2sXWWnEPkuv0IN+
         FNwtuOp6zIo1DFx0UFgw6oJR6qL68uK3QSkXPn6XgTTezMlNWHyQPo6nWQjlpy6+8wH4
         kLGp2qYs53qzDvV5UVcYwK5G2l3HRhpDSDpvWEbIkXs/P16O2FUkqJT53vHHjyM2st7I
         S+PnajoWNKbKXuix3l07m2p/JiroM3puD2eUEm0cBd6CyK51zQxaqtGUx8kmItg38+YM
         oK6w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770891006; x=1771495806;
        h=content-transfer-encoding:in-reply-to:content-language:references
         :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=MGtZzlI0afIe1oXYIL6I39556RNwafluFe5WLDNAu60=;
        b=RRx+yFlilav/sbXYm9UY3URr/d+Zi4aCDpcenuyTlfJcjH7CN7lMKye2IH4qQeVgay
         X8PlGoHOdJmAvdY+VbunA25Kk3iiQzmXogkNMcuFmXqKhQp2T+MvqoO4VQu89jKLCY1c
         /9kk/2l14GIwWdW3MilkN03V+TRDH14Qzb/3Db+qJ2iphcGn2F8iFOP8ENLNwV5g7doH
         kCe1qOjFTNszzkOlO7ONJXULLJbYtx5yVAKN9N9hYXVeWxncvv1K5aA+2Td09cINWE7T
         pO2fVbt8s9X6iONhlN1bwU3crcLlgnk80XvezMreksH043HVQRolf2wDJlc7duiGfcxw
         RsmA==
X-Forwarded-Encrypted: i=1; AJvYcCWG0uer3/L0Zcmw9uWOD5gkAvxvUZkv2sAj/+6JNpSYSFl++irqY11CkzxfWJXPKb094b0bRB4=@vger.kernel.org
X-Gm-Message-State: AOJu0YzhBg9RUHWO49j34yjIpu7+ZDOShvGhut7rN3O/fzhx+S5Ab47H
	tFm17gWFwwBAlfdMZw7DWPjoicXPIRY3xl/T7N+L89Tz8Pkfyd+djpG+VeCgkqPSAYxwUfiV6wn
	O9/+KbGUH8T4Z6uk/6uJxz+200tOCLgWQ1/HOakOmbABl7xJym2M8Uorg2A==
X-Gm-Gg: AZuq6aKKlADdx8sUjm/7lOFOWYXjZjTN5QxeIayUpXDKNeWHVJQxTgSfH+SbtRgVoUS
	7h4MK+eu89BOpD71H8gJjP+WMvsp/eyoHLIdr3BeRUEVY8Fh9kGNV0iULdyGo60JcHW+elqDhYe
	OD3Pf1AzR7zDG3NZYIqPp2dXHAxGKXOvOx/nvEu95rgbStxQ1JDCybayRMSEeWSfMG8/NsSJbQ5
	cukxO+WIk9utpvPc9QL8Pav3Bwchr0VO7/blppF8Dn2cnkyBkObYmj/nJleCWX7WokQJwPP5sE7
	2az67NysYKJHxRcGXYFdUXrvD86TBXKOGxKL6TVPTrczD2QZsWKovN6V5yn7XWReA/LVZBc7RB9
	np4we/9Ql3LTIf8ozkBxtS18wIo8o75Wqsa0NuUfeH2+Lohhony0Q3A68a376zQ==
X-Received: by 2002:a05:6000:4024:b0:436:1b1:6cbb with SMTP id ffacd0b85a97d-4378aa01106mr3209829f8f.7.1770891005908;
        Thu, 12 Feb 2026 02:10:05 -0800 (PST)
X-Received: by 2002:a05:6000:4024:b0:436:1b1:6cbb with SMTP id ffacd0b85a97d-4378aa01106mr3209788f8f.7.1770891005389;
        Thu, 12 Feb 2026 02:10:05 -0800 (PST)
Received: from ?IPV6:2a01:e0a:c:37e0:8998:e0cf:68cc:1b62? ([2a01:e0a:c:37e0:8998:e0cf:68cc:1b62])
        by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783d325f7sm11303724f8f.8.2026.02.12.02.10.03
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Thu, 12 Feb 2026 02:10:04 -0800 (PST)
Message-ID: <7c6933fc-663d-4bf6-8594-c14c4be83c98@redhat.com>
Date: Thu, 12 Feb 2026 11:10:02 +0100
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] drm/hyperv: During panic do VMBus unload after frame
 buffer is flushed
From: Jocelyn Falempe <jfalempe@redhat.com>
To: mhklkml@zohomail.com, mhklinux@outlook.com, drawat.floss@gmail.com,
 maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de,
 airlied@gmail.com, simona@ffwll.ch, kys@microsoft.com,
 haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
 longli@microsoft.com, ryasuoka@redhat.com
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
 linux-hyperv@vger.kernel.org, stable@vger.kernel.org
References: <20260209070201.1492-1-mhklinux@outlook.com>
 <20260209070201.1492-2-mhklinux@outlook.com>
 <a5372b72-8dc0-4f2d-ad5c-086f3e75ee81@redhat.com>
 <002601dc9baa$517d8b40$f478a1c0$@zohomail.com>
 <e9d35c78-1c4b-4a9c-8cf0-9531e972279f@redhat.com>
Content-Language: en-US, fr
In-Reply-To: <e9d35c78-1c4b-4a9c-8cf0-9531e972279f@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-DKIM: signer='redhat.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: freedesktop.org]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

On 12/02/2026 10:49, Jocelyn Falempe wrote:
> On 12/02/2026 00:01, mhklkml@zohomail.com wrote:
>> From: Jocelyn Falempe <jfalempe@redhat.com> Sent: Wednesday, February 
>> 11, 2026 1:54 PM
>>
>> But for this patch, the issue is that drm_panic() never gets called if 
>> CONFIG_PRINTK
>> isn't set. In that case, kmsg_dump_register() is a stub that returns 
>> an error.  So
>> drm_panic_register() never registers the callback to drm_panic(). And if
>> drm_panic() isn't going to run, responsibility for doing the VMBus unload
>> must remain with the VMBus code. It's hard to actually test this case 
>> because
>> of depending on printk() for debugging output, so double-check my
>> thinking.
> 
> Ok you're right. I changed from 
> atomic_notifier_chain_register(&panic_notifier_list, ...) to 
> kmsg_dump_register() in the v10 of drm_panic.
> 
> So I should either make DRM_PANIC depends on PRINTK, or call 
> atomic_notifier_chain_register() if PRINTK is not defined.
> 
> As I think kernel without PRINTK are uncommon, I'll probably do the 
> first solution.
> 

FYI, I just sent the corresponding change:

https://patchwork.freedesktop.org/series/161544/

Best regards,

--

Jocelyn



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215936-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 4PZzCpCpjWmVpQQAYBR5ng
	(envelope-from <stable+bounces-215936-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:21:04 +0000
Return-path: <stable+bounces-215936-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:21:04 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215936-hi=josie.lol@vger.kernel.org>)
	id 1vqToj-0000000236r-3KBx
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:21:03 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id 622B7302C788
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:16:43 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 18DE62E03E4;
	Thu, 12 Feb 2026 10:16:37 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="f7tr/E4L"
X-Original-To: stable@vger.kernel.org
Received: from mail-m1973194.qiye.163.com (mail-m1973194.qiye.163.com [220.197.31.94])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA3C22EC569;
	Thu, 12 Feb 2026 10:16:32 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.94
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770891397; cv=none; b=DAdkFJkA1UstPyNA7+4GOGuowDbetP0bqepnpW5R7XiKVpVAmmOOyDbUECj2bjf0awicmt4KoueZ2HFwtINvZ7BMbNUhzKM5bNzssSnD+HZaUUZimib4GXmw08nQB5sp3Xz3jPCVPRNBcdc03MPmoTzKh4oSPpkWoDMdPWjtVHc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770891397; c=relaxed/simple;
	bh=S0aN7p4YQN4RmlyDDCPare7qU/HGNXtlRHX0+vqggF0=;
	h=From:To:Cc:Subject:Date:Message-Id; b=ImYNGbfnpQb3FZo99ukb/iUEB/hvBH68IG6cujHgxtuBDU90+UUXmdSqpHezWHM0U6cqDyju+3dDAuQKe9jcJyHJwErYrewMN964DyozTHh6fdG+cnOga2U7dZxduCcu29DD+7ok+rFnrwt9rMBd9nn3ST19aWWehAZ2CRbAsRQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=f7tr/E4L; arc=none smtp.client-ip=220.197.31.94
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com
Received: from localhost.localdomain (unknown [58.22.7.114])
	by smtp.qiye.163.com (Hmail) with ESMTP id 33fa08078;
	Thu, 12 Feb 2026 18:16:21 +0800 (GMT+08:00)
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Finley Xiao <finley.xiao@rock-chips.com>,
	Frank Zhang <rmxpzlb@gmail.com>,
	linux-pm@vger.kernel.org,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org,
	Shawn Lin <shawn.lin@rock-chips.com>,
	stable@vger.kernel.org
Subject: [PATCH] pmdomain: rockchip: Fix rkvdec0/1 and venc0/1 for RK3588
Date: Thu, 12 Feb 2026 18:16:04 +0800
Message-Id: <1770891364-52147-1-git-send-email-shawn.lin@rock-chips.com>
X-Mailer: git-send-email 2.7.4
X-HM-Tid: 0a9c515a082f09cckunm305a02041ef9af
X-HM-MType: 1
X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly
	tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGh9JSlYeTh1MSktPTE5PTRpWFRQJFh
	oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0
	hVSktLVUpCS0tZBg++
DKIM-Signature: a=rsa-sha256;
	b=f7tr/E4LX48FgGZFCGkczgOcuFAT9VbPhusium2zsAa0QDxmpmNN4PypuvtTVlIxkv843sPIAXHGkBF6cjXvQIRWyWdChEU7u8MMHroicK43UuzL5bbmIXcXYhoo25lhqqii1mMBpJkNSrj+4iR8i3pfIcyGHv6JJdTJOPONs/E=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1;
	bh=GFR9wRVn0Qke2uoGUoqI/yXbVDXXXiIpaex2yOx3ucY=;
	h=date:mime-version:subject:message-id:from;
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
X-DKIM: signer='rock-chips.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: rock-chips.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [104.64.211.4 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

>From the RK3588 TRM Table 1-1 RK3588 Voltage Domain and Power Domain Summary,
PD_RKVDEC0/1 and PD_VENC0/1 rely on VD_VCODEC which require extra voltages to
be applied, otherwise it breaks RK3588-evb1-v10 board after vdec support landed[1].
The panic looks like below:

  rockchip-pm-domain fd8d8000.power-management:power-controller: failed to set domain 'rkvdec0' on, val=0
  rockchip-pm-domain fd8d8000.power-management:power-controller: failed to set domain 'rkvdec1' on, val=0
  ...
  Hardware name: Rockchip RK3588S EVB1 V10 Board (DT)
  Workqueue: pm genpd_power_off_work_fn
  Call trace:
  show_stack+0x18/0x24 (C)
  dump_stack_lvl+0x40/0x84
  dump_stack+0x18/0x24
  vpanic+0x1ec/0x4fc
  vpanic+0x0/0x4fc
  check_panic_on_warn+0x0/0x94
  arm64_serror_panic+0x6c/0x78
  do_serror+0xc4/0xcc
  el1h_64_error_handler+0x3c/0x5c
  el1h_64_error+0x6c/0x70
  regmap_mmio_read32le+0x18/0x24 (P)
  _regmap_bus_reg_read+0xfc/0x130
  _regmap_read+0x188/0x1ac
  regmap_read+0x54/0x78
  rockchip_pd_power+0xcc/0x5f0
  rockchip_pd_power_off+0x1c/0x4c
  _genpd_power_off+0x84/0x120
  genpd_power_off+0x1b4/0x260
  genpd_power_off_work_fn+0x38/0x58
  process_scheduled_works+0x194/0x2c4
  worker_thread+0x2ac/0x3d8
  kthread+0x104/0x124
  ret_from_fork+0x10/0x20
  SMP: stopping secondary CPUs
  Kernel Offset: disabled
  CPU features: 0x3000000,000e0005,40230521,0400720b
  Memory Limit: none
  ---[ end Kernel panic - not syncing: Asynchronous SError Interrupt ]---

[1] https://lore.kernel.org/linux-rockchip/20251020212009.8852-2-detlev.casanova@collabora.com/
Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Cc: stable@vger.kernel.org
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

---

 drivers/pmdomain/rockchip/pm-domains.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
index 997e93c..040aa5f 100644
--- a/drivers/pmdomain/rockchip/pm-domains.c
+++ b/drivers/pmdomain/rockchip/pm-domains.c
@@ -1315,10 +1315,10 @@ static const struct rockchip_domain_info rk3588_pm_domains[] = {
 	[RK3588_PD_NPUTOP]	= DOMAIN_RK3588("nputop",  0x0, BIT(3),  0,       0x0, BIT(11), BIT(2),  0x0, BIT(1),  BIT(1),  false, false),
 	[RK3588_PD_NPU1]	= DOMAIN_RK3588("npu1",    0x0, BIT(4),  0,       0x0, BIT(12), BIT(3),  0x0, BIT(2),  BIT(2),  false, false),
 	[RK3588_PD_NPU2]	= DOMAIN_RK3588("npu2",    0x0, BIT(5),  0,       0x0, BIT(13), BIT(4),  0x0, BIT(3),  BIT(3),  false, false),
-	[RK3588_PD_VENC0]	= DOMAIN_RK3588("venc0",   0x0, BIT(6),  0,       0x0, BIT(14), BIT(5),  0x0, BIT(4),  BIT(4),  false, false),
-	[RK3588_PD_VENC1]	= DOMAIN_RK3588("venc1",   0x0, BIT(7),  0,       0x0, BIT(15), BIT(6),  0x0, BIT(5),  BIT(5),  false, false),
-	[RK3588_PD_RKVDEC0]	= DOMAIN_RK3588("rkvdec0", 0x0, BIT(8),  0,       0x0, BIT(16), BIT(7),  0x0, BIT(6),  BIT(6),  false, false),
-	[RK3588_PD_RKVDEC1]	= DOMAIN_RK3588("rkvdec1", 0x0, BIT(9),  0,       0x0, BIT(17), BIT(8),  0x0, BIT(7),  BIT(7),  false, false),
+	[RK3588_PD_VENC0]	= DOMAIN_RK3588("venc0",   0x0, BIT(6),  0,       0x0, BIT(14), BIT(5),  0x0, BIT(4),  BIT(4),  false, true),
+	[RK3588_PD_VENC1]	= DOMAIN_RK3588("venc1",   0x0, BIT(7),  0,       0x0, BIT(15), BIT(6),  0x0, BIT(5),  BIT(5),  false, true),
+	[RK3588_PD_RKVDEC0]	= DOMAIN_RK3588("rkvdec0", 0x0, BIT(8),  0,       0x0, BIT(16), BIT(7),  0x0, BIT(6),  BIT(6),  false, true),
+	[RK3588_PD_RKVDEC1]	= DOMAIN_RK3588("rkvdec1", 0x0, BIT(9),  0,       0x0, BIT(17), BIT(8),  0x0, BIT(7),  BIT(7),  false, true),
 	[RK3588_PD_VDPU]	= DOMAIN_RK3588("vdpu",    0x0, BIT(10), 0,       0x0, BIT(18), BIT(9),  0x0, BIT(8),  BIT(8),  false, false),
 	[RK3588_PD_RGA30]	= DOMAIN_RK3588("rga30",   0x0, BIT(11), 0,       0x0, BIT(19), BIT(10), 0x0, 0,       0,       false, false),
 	[RK3588_PD_AV1]		= DOMAIN_RK3588("av1",     0x0, BIT(12), 0,       0x0, BIT(20), BIT(11), 0x0, BIT(9),  BIT(9),  false, false),
-- 
2.7.4



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215935-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id aLpEG6OpjWmgewcAYBR5ng
	(envelope-from <stable+bounces-215935-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:21:23 +0000
Return-path: <stable+bounces-215935-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:21:23 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215935-hi=josie.lol@vger.kernel.org>)
	id 1vqTp4-000000023oA-3X7R
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:21:23 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id F00393063D45
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:15:59 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 2CC522E8DEF;
	Thu, 12 Feb 2026 10:15:58 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ji8DxQAY"
X-Original-To: stable@vger.kernel.org
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 544A32D77E3;
	Thu, 12 Feb 2026 10:15:56 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770891358; cv=none; b=k+agMuZqg5kwb8hntwsEXqB66u/iuKoOdOVfACFmDzjs+iQ8ZowwBCXmdSGVjLXHCaZYAOZH+14QfC0BFdigMWGpGk7RIPbpPDoMlTd/8l3/Uz3ghzOOOW0VVnwN8aK0e59E9B81RENGYU7iFtELm9zfGF8sHRvHClO/UM1ylK0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770891358; c=relaxed/simple;
	bh=Wk89nFUepuSXaXCGvF8acoSpbg0D5i8pnzVyOgeRsro=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=D9yiCNlZS/AAdSS0TEw02OSArMUzmI5LosN2raNfSH85cBV43POy7P/SBb87/Et8ym596tSzLyFc5AzKt8Ehbx7JxAre5Gpv9E3vd9zfBYn/IC9CftgpXESn7DE2Te/lHw8OVPXsWmtG40n4whm15/jlcZl2pgG0GL2YubyEgFc=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ji8DxQAY; arc=none smtp.client-ip=198.175.65.18
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1770891357; x=1802427357;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Wk89nFUepuSXaXCGvF8acoSpbg0D5i8pnzVyOgeRsro=;
  b=Ji8DxQAYrjPq42bYJ9vxcYYGBk2FMGdtNDeavH+cPZGxKQFh11GptjCK
   sSKspGek5aFccmtRF7oIsv4vPmUHYR8GXissRTGuD1CbxS2k6QQVnNH2G
   pA/vCTWzjA0WBo5bCoOkA2ZVmSdRZtG2jhCnahlvG3MGJ2UWoIWwL/MYN
   6orx60zXz09kGojXVISETVSMuaKJ3aGlEOCgbHHTWDHoL+wfWE6rEAuGx
   y67HOzQY85UGt2kJX8b8S7q/ytTiNVKplnpzgc4DwijXMZO2gWzjukFJ4
   yTOXTNczzRzwIhwwXjxaY/b+Vq77AzxuAhGFYDhbESxbDGO220X7fhhTo
   A==;
X-CSE-ConnectionGUID: DQgkvj4IRV69nGR5CAsLfA==
X-CSE-MsgGUID: FUJKXL0FQwq6MESJgW9nUQ==
X-IronPort-AV: E=McAfee;i="6800,10657,11698"; a="72104976"
X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; 
   d="scan'208";a="72104976"
Received: from orviesa008.jf.intel.com ([10.64.159.148])
  by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 02:15:56 -0800
X-CSE-ConnectionGUID: M1pIBHV8Ttm5cMtvCOqfJg==
X-CSE-MsgGUID: cEy5DnNZS4SO6lSjS0EdHg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; 
   d="scan'208";a="212582397"
Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.145])
  by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 02:15:53 -0800
Date: Thu, 12 Feb 2026 12:15:50 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Alban Bedel <alban.bedel@lht.dlh.de>, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, Nam Cao <namcao@linutronix.de>,
	Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Lennert Buytenhek <buytenh@arista.com>,
	Peng Zhang <zhangpeng.00@bytedance.com>, stable@vger.kernel.org,
	Muchun Song <songmuchun@bytedance.com>,
	Maximilian Lueer <maximilian.lueer@lht.dlh.de>
Subject: Re: [PATCH v3] serial: 8250: always disable IRQ during THRE test
Message-ID: <aY2oVjCL21wL-8aE@smile.fi.intel.com>
References: <20260209113207.2118445-1-alban.bedel@lht.dlh.de>
 <5964c41f-ddd3-406d-91b1-62fa33364163@kernel.org>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5964c41f-ddd3-406d-91b1-62fa33364163@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6
 krs, Bertel Jungin Aukio 5, 02600 Espoo
X-DKIM: signer='intel.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-DKIM: signer='@intel.com' status='pass' reason=''
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: intel.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 5

On Thu, Feb 12, 2026 at 09:41:08AM +0100, Jiri Slaby wrote:
> On 09. 02. 26, 12:32, Alban Bedel wrote:

> > commit 039d4926379b ("serial: 8250: Toggle IER bits on only after irq
> > has been set up") moved IRQ setup before the THRE test, so the interrupt
> > handler can run during the test and race with its IIR reads. This can
> > produce wrong THRE test results and cause spurious registration of the
> > serial8250_backup_timeout timer. Unconditionally disable the IRQ for the
> > short duration of the test and re-enable it afterwards to avoid the race.

...

> > v2: Replaced disable_irq_nosync() with disable_irq() to prevent interrupts
> >      that are currently being handled
> 
> This made me to check, why/how this is possible. It appears to be, but only
> thanks to:
>   205d300aea75 serial: 8250: change lock order in serial8250_do_startup()
> 
> And the change should be documented in the commit log. Especially to avoid
> stable backports to trees without 205d300aea75.

There is a de facto tag Depends-on: which might be used here.

-- 
With Best Regards,
Andy Shevchenko




From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215937-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id gOTRHoCqjWmVpQQAYBR5ng
	(envelope-from <stable+bounces-215937-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:25:04 +0000
Return-path: <stable+bounces-215937-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:25:04 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215937-hi=josie.lol@vger.kernel.org>)
	id 1vqTse-00000002AFv-0Vjf
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:25:04 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 13A3E303CC39
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:24:58 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 36A0F29E115;
	Thu, 12 Feb 2026 10:24:57 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TP3HfEze"
X-Original-To: stable@vger.kernel.org
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id B95B01C4A24;
	Thu, 12 Feb 2026 10:24:54 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770891897; cv=none; b=LclHtdnwd3/QR8+XVu2OcyM5mgv40hm+ry7721HbN5WpyKDSaag+qw85e77AjKjJYh4/4LcS1tISooA0rYxjjVW8yMqk43dkI5vTf1kn1d7m9MnLOhOGdlqGFPpAHflNlf8b6ijc4O59Q6V0Qji9WGf0+k9P+LnxhVoxDHna3o4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770891897; c=relaxed/simple;
	bh=Q1mgWVleEE0wyf7KXIaG1atYZg87rJLD9jD9rv73Zxc=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=oQ8zUZMTIKmWuLJ5+Dchm8Hovt0cLTbnmpkH5PPDkAU7Mm3A8hkRBOQ0JYPMlnhKn/YwFLlnFA6ABX1ZlvuUhuB+DBLhmR9UJ8E4+sIZuIOFeNCcbROoCL3dL9qsa0UY7DrVXQYuDplw6NS5SQ93sYWuY0Cc7fONT+gG8KHD3Ww=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TP3HfEze; arc=none smtp.client-ip=198.175.65.15
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1770891895; x=1802427895;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Q1mgWVleEE0wyf7KXIaG1atYZg87rJLD9jD9rv73Zxc=;
  b=TP3HfEzepY88WwL4j6dxlKJfs6JgebjmQDdrfR7K08BOQkUQr9x53P59
   dxk0PZbKyk6iS6KkxJ90mJmoVXkVQWEqzAQuTRpY/AhN/hYeDE+wXSQiM
   cfa/3TpHbxshA1mxfEAsaDYCebFqC89XKcUYXdpyEibxUdOV40gMmlDnv
   EN5W05vVPEnz2a3qQlf4R2zfsgE1jW0LzRismPs/V9FQAhR0Y4NIvWW5u
   qwqlS9YbIlNgmTLEiBMp2SUf2DS/5KTIGd20jJgALbjegufHUkd6TZgdK
   2TNiyqVkzkyqpEli7eT386ficB+U3Bgv+YaJQOBiohwYIf1dWGP3VNC6D
   A==;
X-CSE-ConnectionGUID: bWryUqVuTAWcoXyHUxcrHg==
X-CSE-MsgGUID: yDdx/szhQs+h32pDEtaXlw==
X-IronPort-AV: E=McAfee;i="6800,10657,11698"; a="75684952"
X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; 
   d="scan'208";a="75684952"
Received: from orviesa007.jf.intel.com ([10.64.159.147])
  by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 02:24:54 -0800
X-CSE-ConnectionGUID: w92L+W/iTzySPvh6OtFRUw==
X-CSE-MsgGUID: f9HdQho0SvCpTUUQIBLK6A==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; 
   d="scan'208";a="212664748"
Received: from b580.bj.intel.com ([10.238.152.74])
  by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 02:24:51 -0800
From: Junjie Cao <junjie.cao@intel.com>
To: miriam.rachel.korenblit@intel.com,
	johannes.berg@intel.com,
	linux-wireless@vger.kernel.org,
	richardcochran@gmail.com
Cc: horms@kernel.org,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	yedidya.ben.shimol@intel.com,
	avraham.stern@intel.com,
	daniel.gabay@intel.com,
	krishnanand.prabhu@intel.com,
	luciano.coelho@intel.com,
	gregory.greenman@intel.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: ptp: Fix potential race condition in PTP removal
Date: Thu, 12 Feb 2026 18:24:02 +0800
Message-ID: <20260212102402.1283533-1-junjie.cao@intel.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <DM3PPF63A6024A9E1EF4081E342AF4BED81A365A@DM3PPF63A6024A9.namprd11.prod.outlook.com>
References: <DM3PPF63A6024A9E1EF4081E342AF4BED81A365A@DM3PPF63A6024A9.namprd11.prod.outlook.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='intel.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-DKIM: signer='@intel.com' status='pass' reason=''
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

Hi Miri,

You're right -- cancel_delayed_work_sync() handles re-arming by design,
and the work is scheduled with a 1-hour delay (IWL_PTP_WRAP_TIME =
3600 * HZ), so it cannot realistically fire again during the
microsecond-scale teardown window.

The real issue is simply that the delayed work can execute between
ptp_clock_unregister() and cancel_delayed_work_sync(), observing
partially cleared PTP state.

I'll send a v2 with a corrected commit message, and also split the
patch into two (one per sub-driver) as Simon suggested.

Thanks for the review!

Junjie


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215938-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id GIzKBOqsjWk0KQgAYBR5ng
	(envelope-from <stable+bounces-215938-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:35:22 +0000
Return-path: <stable+bounces-215938-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:35:22 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215938-hi=josie.lol@vger.kernel.org>)
	id 1vqU2b-00000002SKp-1ozM
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:35:22 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id 8E9B730200DC
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:34:04 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id D74922264CA;
	Thu, 12 Feb 2026 10:34:03 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nsLKylHB";
	dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ctraEmnn";
	dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="d8llgl8Y";
	dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UKHSTwsz"
X-Original-To: stable@vger.kernel.org
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7242BE647
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 10:34:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770892443; cv=none; b=srlhm8fTBcu0QYEzuScJ+bqC22dMCjpdRma5bFfBK7Yn/Xr/XXsAPy2FeMIJSKjO2S7HsQGC9te39WPX5A6uPy7d3sqmxBRp7qjE1+Z9BNguXf9Nl2+wrnwFEwHpHyPsDesGg5ux5ltgNzN2pJ1DhCuehwaQT7A3ylFrFJejQWM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770892443; c=relaxed/simple;
	bh=kLZwO6LnZFSRcZNUwXxBDrrg2rSZk13WMmdXPZp5bHY=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=b6o3UwinuYoTESab1LrHqtyYDThRKzVxjEzj9rO/ZgwmvZQuOhIG3nGpz/I7EBYcWEVGIuv+dv3V5sUjhdh+jdWIOfTwn3QerS3B6hgadbP8yvd9WW4guAXqqV9kApAL+WeAp6JD2so+Njj89waRgBIsUyGb8ieRs3hidU3hViI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=nsLKylHB; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ctraEmnn; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=d8llgl8Y; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=UKHSTwsz; arc=none smtp.client-ip=195.135.223.131
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de
Received: from hawking.nue2.suse.org (unknown [IPv6:2a07:de40:a101:3:92b1:1cff:fe69:ddc])
	by smtp-out2.suse.de (Postfix) with ESMTP id C33FC5BDAD;
	Thu, 12 Feb 2026 10:34:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1770892441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BeqIufAnYFkDobcmSJZWZ2CF3hg0EmflNlkkrGIm70U=;
	b=nsLKylHB2RCOPy8131sxnnODIOADcYH6mFmK5mdtcESmMXnNjDYV9fJUN6QJ0+8dNVULwL
	OeiKltQzlUQahubViNh8d4ygNwYOc4um3TApa4/R0ZRycLJdWM6Hx3iUZvCmRECW6xtIF4
	PKFbO6etyfBYAw8rR7+S2mMhtY2rjqg=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1770892441;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BeqIufAnYFkDobcmSJZWZ2CF3hg0EmflNlkkrGIm70U=;
	b=ctraEmnnzOPGB2pjH+6bObn5UnOpNRFk6wffYbCuXaSwDTXjXcrDSLpgAAUyDMX/a11Wjr
	4spUj71SJeEfgqBA==
Authentication-Results: smtp-out2.suse.de;
	dkim=pass header.d=suse.de header.s=susede2_rsa header.b=d8llgl8Y;
	dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UKHSTwsz
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1770892440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BeqIufAnYFkDobcmSJZWZ2CF3hg0EmflNlkkrGIm70U=;
	b=d8llgl8YGpXU3bLR71G4BOLv8H8nzNx0xCNaqYEQBknIKOLnjDf4H5XulvGAl35mQYAyQU
	ZyoB4rYuJ/JgMYuDvVxsafSNZEgwbCmJdaOupDN8LRrLSzgJfLNLTAUBMZ+Ba9hOJFx5+t
	9LuoN6rmuJB16LahLniFFfNRmdCF19I=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1770892440;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BeqIufAnYFkDobcmSJZWZ2CF3hg0EmflNlkkrGIm70U=;
	b=UKHSTwsz4ggPCOXEVZLqlnng5t29saErflvm5qpBVM1LvWZpGvIj4K8uAuyKCXJzH53e20
	QzPVzB+HlRXI3DCQ==
Received: by hawking.nue2.suse.org (Postfix, from userid 17005)
	id A8E114A0A2B; Thu, 12 Feb 2026 11:34:00 +0100 (CET)
From: Andreas Schwab <schwab@suse.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org,  linux-kernel@vger.kernel.org,  Ard
 Biesheuvel <ardb@kernel.org>,  "Jason A . Donenfeld" <Jason@zx2c4.com>,
  Herbert Xu <herbert@gondor.apana.org.au>,  Vivian Wang
 <wangruikang@iscas.ac.cn>,  Jerry Shih <jerry.shih@sifive.com>,  "David S
 . Miller" <davem@davemloft.net>,  Palmer Dabbelt <palmer@dabbelt.com>,
  Paul Walmsley <pjw@kernel.org>,  Alexandre Ghiti <alex@ghiti.fr>,
  "Martin K . Petersen" <martin.petersen@oracle.com>,  Han Gao
 <gaohan@iscas.ac.cn>,  linux-riscv@lists.infradead.org,
  stable@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: riscv: Depend on
 RISCV_EFFICIENT_VECTOR_UNALIGNED_ACCESS
In-Reply-To: <20251206213750.81474-1-ebiggers@kernel.org> (Eric Biggers's
	message of "Sat, 6 Dec 2025 13:37:50 -0800")
References: <20251206213750.81474-1-ebiggers@kernel.org>
Date: Thu, 12 Feb 2026 11:34:00 +0100
Message-ID: <mvm1piq9ron.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Spamd-Result: default: False [15.29 / 50.00];
	SPAM_FLAG(5.00)[];
	NEURAL_SPAM_LONG(3.50)[0.999];
	BAYES_HAM(-3.00)[99.99%];
	NEURAL_SPAM_SHORT(3.00)[1.000];
	HFILTER_HOSTNAME_UNKNOWN(2.50)[];
	RDNS_NONE(2.00)[];
	ONCE_RECEIVED(1.20)[];
	HFILTER_HELO_IP_A(1.00)[hawking.nue2.suse.org];
	HFILTER_HELO_NORES_A_OR_MX(0.30)[hawking.nue2.suse.org];
	R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];
	MIME_GOOD(-0.10)[text/plain];
	RCVD_NO_TLS_LAST(0.10)[];
	MX_GOOD(-0.01)[];
	FROM_HAS_DN(0.00)[];
	MID_RHS_MATCH_FROM(0.00)[];
	FUZZY_RATELIMITED(0.00)[rspamd.com];
	DIRECT_TO_MX(0.00)[Gnus/5.13 (Gnus v5.13)];
	MIME_TRACE(0.00)[0:+];
	ARC_NA(0.00)[];
	DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];
	TO_MATCH_ENVRCPT_ALL(0.00)[];
	RCPT_COUNT_TWELVE(0.00)[16];
	RCVD_COUNT_ONE(0.00)[1];
	FROM_EQ_ENVFROM(0.00)[];
	R_RATELIMIT(0.00)[from(RLajr16mudzow8bnf6sy)];
	DNSWL_BLOCKED(0.00)[2a07:de40:a101:3:92b1:1cff:fe69:ddc:from];
	DKIM_TRACE(0.00)[suse.de:+];
	TO_DN_SOME(0.00)[]
X-Spam-Flag: YES
X-Spamd-Bar: +++++++++++++++
X-Rspamd-Queue-Id: C33FC5BDAD
X-Rspamd-Server: rspamd2.dmz-prg2.suse.org
X-Rspamd-Action: add header
X-Spam-Level: ***************
X-Spam-Score: 15.29
X-Spam: Yes
X-DKIM: signer='suse.de' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [104.64.211.4 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On Dez 06 2025, Eric Biggers wrote:

> Replace the RISCV_ISA_V dependency of the RISC-V crypto code with
> RISCV_EFFICIENT_VECTOR_UNALIGNED_ACCESS, which implies RISCV_ISA_V as
> well as vector unaligned accesses being efficient.

That should be a runtime dependency.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <io-uring+bounces-12177-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 6BTQCievjWlTRwkAYBR5ng
	(envelope-from <io-uring+bounces-12177-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:44:55 +0000
Return-path: <io-uring+bounces-12177-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:44:55 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <io-uring+bounces-12177-hi=josie.lol@vger.kernel.org>)
	id 1vqUBq-00000002izt-2GFj
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:44:55 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id CFDE0300E1A9
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:44:50 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 974312ED848;
	Thu, 12 Feb 2026 10:44:47 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XhYj/0IT"
X-Original-To: io-uring@vger.kernel.org
Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A3529BD87
	for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 10:44:45 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770893087; cv=none; b=TqTX/15XnLotwlfDlfU6McSYOVSa/tbxbbiv0rQY5dkGtjCj4F4FKXHoF9IXIu1ECNPlo8dzHoK1oi65mXNXYuxcYz38mZ6/mIu9Duicne+fHeZzLh0xpQVfPjPTbe5GMi3VT7diA620/Bt8kX5BIV/j1tS1Aq22aRgyrboLHZ8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770893087; c=relaxed/simple;
	bh=17MwG0yNTIWpU9UvgmGZnQhE/JU3V+aOKX7otvBm+KE=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=mxJaRa44CnN6GHybWtTjcTZtbIdf6iLdPr1xZ3B7UM5iRBZzU5AoH6giXxiR5bcI61iCseEKtczJ0b52leij3rqFM+p+MutU+EeECmYkbSkkL8sUkWABfL2n8HAhGp4FxBq45P0GR9r77dLTo+SSn/BhbrXbgOJFK9yHumjJlHc=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XhYj/0IT; arc=none smtp.client-ip=209.85.128.41
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47edd9024b1so80306175e9.3
        for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 02:44:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1770893084; x=1771497884; darn=vger.kernel.org;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=QHBRvvNw0TKsfp498JIu6yBHF4UlvOdwxk8GoEvvLQI=;
        b=XhYj/0ITf64ffJUY1leh9M/7e/izPPGUg3xcvOokJI5CxJTB4Q1aPtyAsti3SFJPMs
         N9vvD9BGrp0PyIS+/QfgGLgdn9CNzHXKcEXURGb747eoUwVQi9ddurT0W9/8QMMABs1W
         hkqO/bUZmpevnGmY376Rujp5iDtpycbfKszS6zCjOFXyM9/mxX5/tx57V5HQm83euq0P
         stJoXnFQu8Z2CnMCdGWKV5lNqnahfgdclWcjmZY2iDiwiz0jNFhPdqUo3xS32SBSLJEC
         n3qU/oETLG6aVKC74Bsu3C2yoNJ1corL25qvUPoDQKmJAz5P9kWrYOHtcOvw/abj9hRV
         YMig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770893084; x=1771497884;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=QHBRvvNw0TKsfp498JIu6yBHF4UlvOdwxk8GoEvvLQI=;
        b=r+FDFLk3u09hle3nDfu/NxfBmDqamUJsdO/EVA8Dh+byz0aqABMCRRR6IP71F1nOd+
         YyhKQR31Jid5d+DoLl1WYw5gmc+O698J8wpZwovKmLrK3PN3CBWhuHENTiXUG2ugdzhr
         vpllZ/ZPt2NKy5VvVwgv7EOJCFaz/q+tnIc/u4QVUajM3sAscO6fJiCXomAhJ13TVk7O
         FRe5wi/CypDCMjXoV7m072jeUAeo84+vPWaV7M03uMIAb2sAIdsGp+S0bAcLJUWZMM6Y
         HcRaHd0slJWcm5csuDlXdl3UvxqxXOOWZt9SPw2pBPXgsUyn9wKI89G5U2oWjtATj7Di
         nUDw==
X-Forwarded-Encrypted: i=1; AJvYcCXdT56PKe6vxIC0uOqpDWTUd9rfylVbeUzCXTwPTYBFFPwT8hdq8ypJlb1y6zX+lLLSy5ypl374Yw==@vger.kernel.org
X-Gm-Message-State: AOJu0Yz4VZFFsUgsfyqyg7H04x5ztBQfJXuDbGZYGOmByW9Nc/jOIW+w
	qYUWAGmjYMwhBivGlKZCaP1quYZqCiUXsyN+d2wpGD67JKe5TF5VdYcu
X-Gm-Gg: AZuq6aKulsiGmJuQ9C0/iCQuRISW7aCjnTy8Wfxh0sKidlbYkNJnpax27vS5n6OAhKN
	jBEz6skthwEqGUKEpUPz004zFTuWVUsl+2XhNRmyi/wapbxjSyIbALzWr1bE8renQjuaNei/VNI
	E6mP5UpqJUMe1dlYP2LYNI6/zmXKOSutx8JcRm8GKaouZLyYQegUxc67+peUinHxQL8n4WNEGRA
	6ne7Obr2OJ3Twzv6iJMBK2qndDBSCvOtYEznfEeJnfjxxFtWiPOyatKha5PE1QcsOz+knODwdHE
	lDKCtnPY9rlLqfuURxhs+7g/V9eveZzYCQdS+hDDmiGfDN/5+FG7H2LCUauAUhcey0SkgSASNxz
	7Mffe8EaR/QhRij8ZlzLdRrP/Vq9f9IqlNt+EMrraFoaMgudKd1uHoEOZa1lBJBvbbTgVu39+ck
	fIydeCJ3cV4OpGkGu+VI+GfoYlphtlIOq6t8eg24gXNsXDUlBguk6mk0AGA/RlTIgKZESU8mrXF
	+iVQbHlJoOS2sbQlseQ2ENkmeBDNOMrMjn3//IxQvrIhocBr1cYZGO4GGLEv0pv+7pilvydmSax
	wA==
X-Received: by 2002:a05:600c:4e14:b0:477:561f:6fc8 with SMTP id 5b1f17b1804b1-483656ae486mr29560285e9.5.1770893084331;
        Thu, 12 Feb 2026 02:44:44 -0800 (PST)
Received: from ?IPV6:2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c? ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c])
        by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835bc7bd3fsm40732625e9.18.2026.02.12.02.44.43
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Thu, 12 Feb 2026 02:44:43 -0800 (PST)
Message-ID: <bd488a4e-a856-4fa5-b2bb-427280e6a053@gmail.com>
Date: Thu, 12 Feb 2026 10:44:44 +0000
Precedence: bulk
X-Mailing-List: io-uring@vger.kernel.org
List-Id: <io-uring.vger.kernel.org>
List-Subscribe: <mailto:io-uring+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:io-uring+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 03/11] io_uring/kbuf: add support for kernel-managed
 buffer rings
To: Christoph Hellwig <hch@infradead.org>
Cc: Joanne Koong <joannelkoong@gmail.com>, axboe@kernel.dk,
 io-uring@vger.kernel.org, csander@purestorage.com, krisman@suse.de,
 bernd@bsbernd.com, linux-fsdevel@vger.kernel.org
References: <20260210002852.1394504-1-joannelkoong@gmail.com>
 <20260210002852.1394504-4-joannelkoong@gmail.com>
 <89c75fc1-2def-4681-a790-78b12b45478a@gmail.com>
 <aYykILfX_u9-feH-@infradead.org>
Content-Language: en-US
From: Pavel Begunkov <asml.silence@gmail.com>
In-Reply-To: <aYykILfX_u9-feH-@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-DKIM: signer='gmail.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider
                             [asml.silence[at]gmail.com]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [104.64.211.4 listed in list.dnswl.org]
  0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
                             EnvelopeFrom freemail headers are
                             different
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On 2/11/26 15:45, Christoph Hellwig wrote:
> On Tue, Feb 10, 2026 at 04:34:47PM +0000, Pavel Begunkov wrote:
>>> +	union {
>>> +		/* used for pbuf rings */
>>> +		__u64	ring_addr;
>>> +		/* used for kmbuf rings */
>>> +		__u32   buf_size;
>>
>> If you're creating a region, there should be no reason why it
>> can't work with user passed memory. You're fencing yourself off
>> optimisations that are already there like huge pages.
> 
> Any pages mapped to userspace can be allocated in the kernel as well.

pow2 round ups will waste memory. 1MB allocations will never
become 2MB huge pages. And there is a separate question of
1GB huge pages. The user can be smarter about all placement
decisions.

> And I really do like this design, because it means we can have a
> buffer ring that is only mapped read-only into userspace.  That way
> we can still do zero-copy raids if the device requires stable pages
> for checksumming or raid.  I was going to implement this as soon
> as this series lands upstream.

That's an interesting case. To be clear, user provided memory is
an optional feature for pbuf rings / regions / etc., and I think
the io_uring uapi should leave fields for the feature. However, I
have nothing against fuse refusing to bind to buffer rings it
doesn't like.

-- 
Pavel Begunkov



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215939-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 4ClJLySwjWlzQAoAYBR5ng
	(envelope-from <stable+bounces-215939-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:49:08 +0000
Return-path: <stable+bounces-215939-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:49:09 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215939-hi=josie.lol@vger.kernel.org>)
	id 1vqUFw-00000002qaK-1wVa
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:49:08 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id A8212315341B
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:46:00 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 2AA8E281358;
	Thu, 12 Feb 2026 10:46:00 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="g5BOpCOI"
X-Original-To: stable@vger.kernel.org
Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E72C1DDA24;
	Thu, 12 Feb 2026 10:45:57 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770893160; cv=none; b=QgRfAOqT8l6h88VFt64uP2pDWW5EwBIDdgpyVGecDAZiQwC3WMx9IM+GE+YzuJN6+Mq+4ifNQ9jNbrDzHYTvVIMwgQ4c3r3rlJShr9k4qFQj53SrohJkj8dxyBUPeGKN0jV44YCO8006Aj65kIh6oGrvkHxX1CLKEnMW2FtB9WI=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770893160; c=relaxed/simple;
	bh=Q9lBOtUg68sa9iMHgSNiQwBdqiC8tpa9sl++GN3qSZE=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=lhSbglCUu2uOqfxYfxOsE7CY6bxHdC/xQxHB8RiwEi9HaJso2vesMRFRiSPH2wsXindN5vwi6+YVSWjRfKTjC8rzUqeId0ktFvipxjzQ302VKbOT22n1kbkn+XHgEX1h2i5d3qbx8fjlgPSfvVMbkhodY4M416QIMII0723Di4s=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=g5BOpCOI; arc=none smtp.client-ip=220.197.31.2
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;
	s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=qe
	ccGjVLjUuQaSbBstJwiQOfIWq48EFo6VoO+Gt3HtY=; b=g5BOpCOIBd4ujm+v3L
	bACpaRc4XLiIdpWizPIMP45pgaMItayZldkEpD6iG3XzjnJ04WTtuiRftr7BWZMK
	yoRqefmKMad48OXCC6niAAiYBrr+24xej+NOxwcprMNKq34fl84Rkja9Jqx/JOrt
	EzXktG0bNSJgKBomI1Nnux+dE=
Received: from 163.com (unknown [])
	by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wA38f4Tr41pL2eqLA--.10527S6;
	Thu, 12 Feb 2026 18:44:43 +0800 (CST)
From: Zhiquan Li <zhiquan_li@163.com>
To: seanjc@google.com,
	pbonzini@redhat.com,
	shuah@kernel.org
Cc: kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	zhiquan_li@163.com,
	stable@vger.kernel.org
Subject: [PATCH v2 4/4] KVM: selftests: Fix reserved value WRMSR testcase for multi-feature MSRs
Date: Thu, 12 Feb 2026 18:38:41 +0800
Message-ID: <20260212103841.171459-5-zhiquan_li@163.com>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20260212103841.171459-1-zhiquan_li@163.com>
References: <20260212103841.171459-1-zhiquan_li@163.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-CM-TRANSID:_____wA38f4Tr41pL2eqLA--.10527S6
X-Coremail-Antispam: 1Uf129KBjvJXoW7Kw1ktFW8WF48KrWfXryrZwb_yoW8Ar1kpa
	n3Jr40kr93Ka4fAayxGF4xXF18ZFnrWr40gF1Fy3srZF15Ja4xZw1xKay5Aas3urWSq3y3
	Zas2gw1j9a1DJaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2
	9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pEqg4hUUUUU=
X-CM-SenderInfo: 52kl13xdqbzxi6rwjhhfrp/xtbCwhuvmGmNrxvmkQAA3J
X-DKIM: signer='163.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider
                             [zhiquan_li[at]163.com]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
                             EnvelopeFrom freemail headers are
                             different
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

From: Sean Christopherson <seanjc@google.com>

When determining whether or not a WRMSR with reserved bits will #GP or
succeed due to the WRMSR not existing per the guest virtual CPU model,
expect failure if and only if _all_ features associated with the MSR are
unsupported.  Checking only the primary feature results in false failures
when running on AMD and Hygon CPUs with only one of RDPID or RDTSCP, as
AMD/Hygon CPUs ignore MSR_TSC_AUX[63:32], i.e. don't treat the bits as
reserved, and so #GP only if the MSR is unsupported.

Fixes: 9c38ddb3df94 ("KVM: selftests: Add an MSR test to exercise guest/host and read/write")
Reported-by: Zhiquan Li <zhiquan_li@163.com>
Closes: https://lore.kernel.org/all/20260209041305.64906-6-zhiquan_li@163.com
Cc: stable@vger.kernel.org
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 tools/testing/selftests/kvm/x86/msrs_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kvm/x86/msrs_test.c b/tools/testing/selftests/kvm/x86/msrs_test.c
index 4c97444fdefe..f7e39bf887ad 100644
--- a/tools/testing/selftests/kvm/x86/msrs_test.c
+++ b/tools/testing/selftests/kvm/x86/msrs_test.c
@@ -175,7 +175,7 @@ void guest_test_reserved_val(const struct kvm_msr *msr)
 	 * If the CPU will truncate the written value (e.g. SYSENTER on AMD),
 	 * expect success and a truncated value, not #GP.
 	 */
-	if (!this_cpu_has(msr->feature) ||
+	if ((!this_cpu_has(msr->feature) && !this_cpu_has(msr->feature2)) ||
 	    msr->rsvd_val == fixup_rdmsr_val(msr->index, msr->rsvd_val)) {
 		u8 vec = wrmsr_safe(msr->index, msr->rsvd_val);
 
-- 
2.43.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215940-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id kGjGE7ywjWk0KQgAYBR5ng
	(envelope-from <stable+bounces-215940-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:51:40 +0000
Return-path: <stable+bounces-215940-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:51:40 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215940-hi=josie.lol@vger.kernel.org>)
	id 1vqUIM-00000002xcc-3H2z
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:51:40 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id 41A82300EBE4
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:51:35 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C1DA3128C0;
	Thu, 12 Feb 2026 10:51:34 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b="Kk/Os6rw"
X-Original-To: stable@vger.kernel.org
Received: from n169-112.mail.139.com (n169-112.mail.139.com [120.232.169.112])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14AD13128B6
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 10:51:26 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=120.232.169.112
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770893494; cv=none; b=b8hmQBTZqF/YnU1mIOaGgwakS3Yu73ARi+vqE1gOA6cym5v9Kqq4YZF9T/iYtoKXtrI9X5eII5o2WjHPZBFULRHxWX9aJI87hSwTuyTzfVm/4bw9XdIduyp/QYZGHajdfNcpBYGW2w7aSiheT+wdFKgHTTYCtVSxQF6tfKNENEQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770893494; c=relaxed/simple;
	bh=U1hOlTlXpRX5mmx96VIfHFC4wsgFl+dsfkcTTMlw+Uw=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WSjcVG8Jx0blVZNEf0tcID573gNKwMyCv8lm5YxWOHDxrCtmjMR3IXY3gVi9uHxj6gFrUZgB1vveiqPuOrzNIuEdeFkjB2OlJ/z992acTWGSRkKVZXsrAOKz3VhOlc4msv22eUkEszK3Cu7Agke+ebtxylfdMBQzqVdx6NlwEL0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com; spf=pass smtp.mailfrom=139.com; dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b=Kk/Os6rw; arc=none smtp.client-ip=120.232.169.112
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=139.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=139.com; s=dkim; l=0;
	h=from:subject:message-id:to:cc:mime-version;
	bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=;
	b=Kk/Os6rwdwb3tsKGy3WmvXeLj6FPkcoNrdUrlsMnHX2oRIAjWGhG1Ig0bjRIQpzGF2bO3Niy7guMt
	 cFrVeCoIRzFyihEw7rA3G/AH3yRqbOL2QMc3JqJof5+ufkGVQx0m8SJMXAQr61V86WrgBVqkAnpZTR
	 o5i7zb3yyowYyw7c=
X-RM-TagInfo: emlType=0                                       
X-RM-SPAM:                                                                                        
X-RM-SPAM-FLAG:00000000
Received:from ubuntu24.corp.ad.wrs.com (unknown[120.244.194.126])
	by rmsmtp-lg-appmail-22-12025 (RichMail) with SMTP id 2ef9698db0a86a5-97ebd;
	Thu, 12 Feb 2026 18:51:22 +0800 (CST)
X-RM-TRANSID:2ef9698db0a86a5-97ebd
From: Bin Lan <lanbincn@139.com>
To: stable@vger.kernel.org,
	gregkh@linuxfoundation.org
Cc: Alexander Aring <aahringo@redhat.com>,
	David Teigland <teigland@redhat.com>,
	Bin Lan <lanbincn@139.com>
Subject: [PATCH 5.10.y] fs: dlm: fix invalid derefence of sb_lvbptr
Date: Thu, 12 Feb 2026 10:51:12 +0000
Message-ID: <20260212105112.4137-1-lanbincn@139.com>
X-Mailer: git-send-email 2.43.0
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='139.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.7 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.7 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: 139.com]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider
                             [lanbincn[at]139.com]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
                             EnvelopeFrom freemail headers are
                             different
  0.1 DKIM_INVALID           DKIM or DK signature exists, but is not valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 7

From: Alexander Aring <aahringo@redhat.com>

[ Upstream commit 7175e131ebba47afef47e6ac4d5bab474d1e6e49 ]

I experience issues when putting a lkbsb on the stack and have sb_lvbptr
field to a dangled pointer while not using DLM_LKF_VALBLK. It will crash
with the following kernel message, the dangled pointer is here
0xdeadbeef as example:

[  102.749317] BUG: unable to handle page fault for address: 00000000deadbeef
[  102.749320] #PF: supervisor read access in kernel mode
[  102.749323] #PF: error_code(0x0000) - not-present page
[  102.749325] PGD 0 P4D 0
[  102.749332] Oops: 0000 [#1] PREEMPT SMP PTI
[  102.749336] CPU: 0 PID: 1567 Comm: lock_torture_wr Tainted: G        W         5.19.0-rc3+ #1565
[  102.749343] Hardware name: Red Hat KVM/RHEL-AV, BIOS 1.16.0-2.module+el8.7.0+15506+033991b0 04/01/2014
[  102.749344] RIP: 0010:memcpy_erms+0x6/0x10
[  102.749353] Code: cc cc cc cc eb 1e 0f 1f 00 48 89 f8 48 89 d1 48 c1 e9 03 83 e2 07 f3 48 a5 89 d1 f3 a4 c3 66 0f 1f 44 00 00 48 89 f8 48 89 d1 <f3> a4 c3 0f 1f 80 00 00 00 00 48 89 f8 48 83 fa 20 72 7e 40 38 fe
[  102.749355] RSP: 0018:ffff97a58145fd08 EFLAGS: 00010202
[  102.749358] RAX: ffff901778b77070 RBX: 0000000000000000 RCX: 0000000000000040
[  102.749360] RDX: 0000000000000040 RSI: 00000000deadbeef RDI: ffff901778b77070
[  102.749362] RBP: ffff97a58145fd10 R08: ffff901760b67a70 R09: 0000000000000001
[  102.749364] R10: ffff9017008e2cb8 R11: 0000000000000001 R12: ffff901760b67a70
[  102.749366] R13: ffff901760b78f00 R14: 0000000000000003 R15: 0000000000000001
[  102.749368] FS:  0000000000000000(0000) GS:ffff901876e00000(0000) knlGS:0000000000000000
[  102.749372] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  102.749374] CR2: 00000000deadbeef CR3: 000000017c49a004 CR4: 0000000000770ef0
[  102.749376] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[  102.749378] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[  102.749379] PKRU: 55555554
[  102.749381] Call Trace:
[  102.749382]  <TASK>
[  102.749383]  ? send_args+0xb2/0xd0
[  102.749389]  send_common+0xb7/0xd0
[  102.749395]  _unlock_lock+0x2c/0x90
[  102.749400]  unlock_lock.isra.56+0x62/0xa0
[  102.749405]  dlm_unlock+0x21e/0x330
[  102.749411]  ? lock_torture_stats+0x80/0x80 [dlm_locktorture]
[  102.749416]  torture_unlock+0x5a/0x90 [dlm_locktorture]
[  102.749419]  ? preempt_count_sub+0xba/0x100
[  102.749427]  lock_torture_writer+0xbd/0x150 [dlm_locktorture]
[  102.786186]  kthread+0x10a/0x130
[  102.786581]  ? kthread_complete_and_exit+0x20/0x20
[  102.787156]  ret_from_fork+0x22/0x30
[  102.787588]  </TASK>
[  102.787855] Modules linked in: dlm_locktorture torture rpcsec_gss_krb5 intel_rapl_msr intel_rapl_common kvm_intel iTCO_wdt iTCO_vendor_support kvm vmw_vsock_virtio_transport qxl irqbypass vmw_vsock_virtio_transport_common drm_ttm_helper crc32_pclmul joydev crc32c_intel ttm vsock virtio_scsi virtio_balloon snd_pcm drm_kms_helper virtio_console snd_timer snd drm soundcore syscopyarea i2c_i801 sysfillrect sysimgblt i2c_smbus pcspkr fb_sys_fops lpc_ich serio_raw
[  102.792536] CR2: 00000000deadbeef
[  102.792930] ---[ end trace 0000000000000000 ]---

This patch fixes the issue by checking also on DLM_LKF_VALBLK on exflags
is set when copying the lvbptr array instead of if it's just null which
fixes for me the issue.

I think this patch can fix other dlm users as well, depending how they
handle the init, freeing memory handling of sb_lvbptr and don't set
DLM_LKF_VALBLK for some dlm_lock() calls. It might a there could be a
hidden issue all the time. However with checking on DLM_LKF_VALBLK the
user always need to provide a sb_lvbptr non-null value. There might be
more intelligent handling between per ls lvblen, DLM_LKF_VALBLK and
non-null to report the user the way how DLM API is used is wrong but can
be added for later, this will only fix the current behaviour.

Cc: stable@vger.kernel.org
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
[ Adjust context ]
Signed-off-by: Bin Lan <lanbincn@139.com>
---
 fs/dlm/lock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 51ab06308bc7..fa81cd79a86e 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -3635,7 +3635,7 @@ static void send_args(struct dlm_rsb *r, struct dlm_lkb *lkb,
 	case DLM_MSG_REQUEST_REPLY:
 	case DLM_MSG_CONVERT_REPLY:
 	case DLM_MSG_GRANT:
-		if (!lkb->lkb_lvbptr)
+		if (!lkb->lkb_lvbptr || !(lkb->lkb_exflags & DLM_LKF_VALBLK))
 			break;
 		memcpy(ms->m_extra, lkb->lkb_lvbptr, r->res_ls->ls_lvblen);
 		break;
-- 
2.43.0




From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215941-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id aA0uIHCxjWk0KQgAYBR5ng
	(envelope-from <stable+bounces-215941-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:54:40 +0000
Return-path: <stable+bounces-215941-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:54:40 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215941-hi=josie.lol@vger.kernel.org>)
	id 1vqULH-000000034KB-19Wp
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:54:40 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id 5BD823050351
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:53:12 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id E4A513EBF24;
	Thu, 12 Feb 2026 10:52:55 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b="zei3L+23"
X-Original-To: stable@vger.kernel.org
Received: from n169-111.mail.139.com (n169-111.mail.139.com [120.232.169.111])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id C453731986C
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 10:52:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=120.232.169.111
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770893575; cv=none; b=F7Z7+pKCXXgxTTy7rx2cDajnsMZg64V/GCt36iZ3NCEZWqCj3vBH0+7auDz1IqZvf2e2sbcdmeK8RAYO5P/lzutAMyWZCPDhlsYBlsWzNjmB+hMPb1uHgW7X/QBD2XGkKXV/5+qgjyHgh+qQka9b6ZKbRM9Q7Lg+hlUpywGnoUE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770893575; c=relaxed/simple;
	bh=HR2ns6vv/H4ljkqrmZMnGqH+nGu2Wi5FG+PS29Zwgh8=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HwYMzgyzfyTcMNVyI6A/eei2p4hH2TBOhuQmOchjcOtI06iUdmpK3yXj383fIXnTwCaBx5QWfRmunzQQ0HK4gqzczf9kE0HRwnrb0g7LXcGdpeNkIXQofxA4lAzL2ZGRn1GZJN2jLSPxqz6f4W7yzJUiawROCjig+n0ABPhVo/E=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com; spf=pass smtp.mailfrom=139.com; dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b=zei3L+23; arc=none smtp.client-ip=120.232.169.111
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=139.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=139.com; s=dkim; l=0;
	h=from:subject:message-id:to:cc:mime-version;
	bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=;
	b=zei3L+23LUH7Pp4SqjFGUtcf7kzKY3xy38jc+ExRujyypAjNv1ZCRS54hMd6E8CfK1p3/YuTKgt6O
	 x2zg338QH7IrYlhZCPnZSosKNbzo+GVCBDKoWQgbQpF0MLdRxH0SzEbF8uzvup3tKYYYuZu4sxsngU
	 qM/6YuoEaWIUhAJo=
X-RM-TagInfo: emlType=0                                       
X-RM-SPAM:                                                                                        
X-RM-SPAM-FLAG:00000000
Received:from ubuntu24.corp.ad.wrs.com (unknown[120.244.194.126])
	by rmsmtp-lg-appmail-18-12021 (RichMail) with SMTP id 2ef5698db0fa874-98fd4;
	Thu, 12 Feb 2026 18:52:43 +0800 (CST)
X-RM-TRANSID:2ef5698db0fa874-98fd4
From: Bin Lan <lanbincn@139.com>
To: stable@vger.kernel.org,
	gregkh@linuxfoundation.org
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Bin Lan <lanbincn@139.com>
Subject: [PATCH 5.15.y] net: dsa: free routing table on probe failure
Date: Thu, 12 Feb 2026 10:52:36 +0000
Message-ID: <20260212105236.4180-1-lanbincn@139.com>
X-Mailer: git-send-email 2.43.0
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='139.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.7 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.7 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: 139.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [104.64.211.4 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider
                             [lanbincn[at]139.com]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
                             EnvelopeFrom freemail headers are
                             different
  0.1 DKIM_INVALID           DKIM or DK signature exists, but is not valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 7

From: Vladimir Oltean <vladimir.oltean@nxp.com>

[ Upstream commit 8bf108d7161ffc6880ad13a0cc109de3cf631727 ]

If complete = true in dsa_tree_setup(), it means that we are the last
switch of the tree which is successfully probing, and we should be
setting up all switches from our probe path.

After "complete" becomes true, dsa_tree_setup_cpu_ports() or any
subsequent function may fail. If that happens, the entire tree setup is
in limbo: the first N-1 switches have successfully finished probing
(doing nothing but having allocated persistent memory in the tree's
dst->ports, and maybe dst->rtable), and switch N failed to probe, ending
the tree setup process before anything is tangible from the user's PoV.

If switch N fails to probe, its memory (ports) will be freed and removed
from dst->ports. However, the dst->rtable elements pointing to its ports,
as created by dsa_link_touch(), will remain there, and will lead to
use-after-free if dereferenced.

If dsa_tree_setup_switches() returns -EPROBE_DEFER, which is entirely
possible because that is where ds->ops->setup() is, we get a kasan
report like this:

==================================================================
BUG: KASAN: slab-use-after-free in mv88e6xxx_setup_upstream_port+0x240/0x568
Read of size 8 at addr ffff000004f56020 by task kworker/u8:3/42

Call trace:
 __asan_report_load8_noabort+0x20/0x30
 mv88e6xxx_setup_upstream_port+0x240/0x568
 mv88e6xxx_setup+0xebc/0x1eb0
 dsa_register_switch+0x1af4/0x2ae0
 mv88e6xxx_register_switch+0x1b8/0x2a8
 mv88e6xxx_probe+0xc4c/0xf60
 mdio_probe+0x78/0xb8
 really_probe+0x2b8/0x5a8
 __driver_probe_device+0x164/0x298
 driver_probe_device+0x78/0x258
 __device_attach_driver+0x274/0x350

Allocated by task 42:
 __kasan_kmalloc+0x84/0xa0
 __kmalloc_cache_noprof+0x298/0x490
 dsa_switch_touch_ports+0x174/0x3d8
 dsa_register_switch+0x800/0x2ae0
 mv88e6xxx_register_switch+0x1b8/0x2a8
 mv88e6xxx_probe+0xc4c/0xf60
 mdio_probe+0x78/0xb8
 really_probe+0x2b8/0x5a8
 __driver_probe_device+0x164/0x298
 driver_probe_device+0x78/0x258
 __device_attach_driver+0x274/0x350

Freed by task 42:
 __kasan_slab_free+0x48/0x68
 kfree+0x138/0x418
 dsa_register_switch+0x2694/0x2ae0
 mv88e6xxx_register_switch+0x1b8/0x2a8
 mv88e6xxx_probe+0xc4c/0xf60
 mdio_probe+0x78/0xb8
 really_probe+0x2b8/0x5a8
 __driver_probe_device+0x164/0x298
 driver_probe_device+0x78/0x258
 __device_attach_driver+0x274/0x350

The simplest way to fix the bug is to delete the routing table in its
entirety. dsa_tree_setup_routing_table() has no problem in regenerating
it even if we deleted links between ports other than those of switch N,
because dsa_link_touch() first checks whether the port pair already
exists in dst->rtable, allocating if not.

The deletion of the routing table in its entirety already exists in
dsa_tree_teardown(), so refactor that into a function that can also be
called from the tree setup error path.

In my analysis of the commit to blame, it is the one which added
dsa_link elements to dst->rtable. Prior to that, each switch had its own
ds->rtable which is freed when the switch fails to probe. But the tree
is potentially persistent memory.

Fixes: c5f51765a1f6 ("net: dsa: list DSA links in the fabric")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20250414213001.2957964-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[ Backport the fix to net/dsa/dsa2.c in v5.15.y for dsa2.c was
renamed back into dsa.c by commit
47d2ce03dcfb ("net: dsa: rename dsa2.c back into dsa.c and create its header")
since v6.2. ]
Signed-off-by: Bin Lan <lanbincn@139.com>
---
 net/dsa/dsa2.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index bf384b30ec0a..a6b6bcffc69c 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -1079,6 +1079,16 @@ static void dsa_tree_teardown_lags(struct dsa_switch_tree *dst)
 	kfree(dst->lags);
 }
 
+static void dsa_tree_teardown_routing_table(struct dsa_switch_tree *dst)
+{
+	struct dsa_link *dl, *next;
+
+	list_for_each_entry_safe(dl, next, &dst->rtable, list) {
+		list_del(&dl->list);
+		kfree(dl);
+	}
+}
+
 static int dsa_tree_setup(struct dsa_switch_tree *dst)
 {
 	bool complete;
@@ -1096,7 +1106,7 @@ static int dsa_tree_setup(struct dsa_switch_tree *dst)
 
 	err = dsa_tree_setup_cpu_ports(dst);
 	if (err)
-		return err;
+		goto teardown_rtable;
 
 	err = dsa_tree_setup_switches(dst);
 	if (err)
@@ -1123,14 +1133,14 @@ static int dsa_tree_setup(struct dsa_switch_tree *dst)
 	dsa_tree_teardown_switches(dst);
 teardown_cpu_ports:
 	dsa_tree_teardown_cpu_ports(dst);
+teardown_rtable:
+	dsa_tree_teardown_routing_table(dst);
 
 	return err;
 }
 
 static void dsa_tree_teardown(struct dsa_switch_tree *dst)
 {
-	struct dsa_link *dl, *next;
-
 	if (!dst->setup)
 		return;
 
@@ -1144,10 +1154,7 @@ static void dsa_tree_teardown(struct dsa_switch_tree *dst)
 
 	dsa_tree_teardown_cpu_ports(dst);
 
-	list_for_each_entry_safe(dl, next, &dst->rtable, list) {
-		list_del(&dl->list);
-		kfree(dl);
-	}
+	dsa_tree_teardown_routing_table(dst);
 
 	pr_info("DSA: tree %d torn down\n", dst->index);
 
-- 
2.43.0




From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215942-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id aHH1A3KxjWk0KQgAYBR5ng
	(envelope-from <stable+bounces-215942-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:54:42 +0000
Return-path: <stable+bounces-215942-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:54:42 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215942-hi=josie.lol@vger.kernel.org>)
	id 1vqULI-000000034OO-40Ih
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:54:42 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id CF8FA30508D3
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:53:12 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 0F5571A9F94;
	Thu, 12 Feb 2026 10:53:11 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b="HNl6P126"
X-Original-To: stable@vger.kernel.org
Received: from n169-112.mail.139.com (n169-112.mail.139.com [120.232.169.112])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAF99314D03
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 10:53:08 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=120.232.169.112
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770893591; cv=none; b=RFDBox8sFVqlruWFonjVi4qnByMfq96KQbyUNTmcpn9TYDEdSMMQz1Yor0HZPbHcj+YXF8sApoN1Sxad4JIeO2kd0m+qm1jkbwNtXetZrGxVIjPlkqVU/sfR20rbrYFIOj+Yrji2+iuREsz6qVwGSspnm1jHxsyzNMMoh2wPzgA=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770893591; c=relaxed/simple;
	bh=QODKW3Mcvd5psbAB98MHCK7+ZWVDYdyCLvhF40H+wI4=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XE0AW/EXM4nY/rBm3rECLVW28XY8RCojNh9HEPnWIePJI+Rl5XRuaa/bOF3v06J10hl2ltohLUZBEcfZ6KDKmzue24lch2OPni5SA1wXQSGLjcCqof/EukjinQqhTVjHH9qdngOYfKU/g2ZCK6gdX1h65J1dYklSiyuz5peBU7c=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com; spf=pass smtp.mailfrom=139.com; dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b=HNl6P126; arc=none smtp.client-ip=120.232.169.112
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=139.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=139.com; s=dkim; l=0;
	h=from:subject:message-id:to:cc:mime-version;
	bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=;
	b=HNl6P126EBTkodbXBvlQAX2+fGhMo2a46FkYJtf/2mvB60LsTX7YA2fU0TK3VOGX1wQHsAA2HcmuO
	 0xwM82sd02sA3pxZwe7Id3SMMg1XBdbMknH3OZgRCjyUTtFBPtyqh1rWufWQ1XQvB5hmEMlRnfKyhM
	 cdGZordgXCYQ/a5o=
X-RM-TagInfo: emlType=0                                       
X-RM-SPAM:                                                                                        
X-RM-SPAM-FLAG:00000000
Received:from ubuntu24.corp.ad.wrs.com (unknown[120.244.194.126])
	by rmsmtp-lg-appmail-20-12023 (RichMail) with SMTP id 2ef7698db110fe2-976f4;
	Thu, 12 Feb 2026 18:53:06 +0800 (CST)
X-RM-TRANSID:2ef7698db110fe2-976f4
From: Bin Lan <lanbincn@139.com>
To: stable@vger.kernel.org,
	gregkh@linuxfoundation.org
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Bin Lan <lanbincn@139.com>
Subject: [PATCH 6.1.y] net: dsa: free routing table on probe failure
Date: Thu, 12 Feb 2026 10:53:04 +0000
Message-ID: <20260212105304.4210-1-lanbincn@139.com>
X-Mailer: git-send-email 2.43.0
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='139.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.7 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.7 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: 139.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [104.64.211.4 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider
                             [lanbincn[at]139.com]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
                             EnvelopeFrom freemail headers are
                             different
  0.1 DKIM_INVALID           DKIM or DK signature exists, but is not valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 7

From: Vladimir Oltean <vladimir.oltean@nxp.com>

[ Upstream commit 8bf108d7161ffc6880ad13a0cc109de3cf631727 ]

If complete = true in dsa_tree_setup(), it means that we are the last
switch of the tree which is successfully probing, and we should be
setting up all switches from our probe path.

After "complete" becomes true, dsa_tree_setup_cpu_ports() or any
subsequent function may fail. If that happens, the entire tree setup is
in limbo: the first N-1 switches have successfully finished probing
(doing nothing but having allocated persistent memory in the tree's
dst->ports, and maybe dst->rtable), and switch N failed to probe, ending
the tree setup process before anything is tangible from the user's PoV.

If switch N fails to probe, its memory (ports) will be freed and removed
from dst->ports. However, the dst->rtable elements pointing to its ports,
as created by dsa_link_touch(), will remain there, and will lead to
use-after-free if dereferenced.

If dsa_tree_setup_switches() returns -EPROBE_DEFER, which is entirely
possible because that is where ds->ops->setup() is, we get a kasan
report like this:

==================================================================
BUG: KASAN: slab-use-after-free in mv88e6xxx_setup_upstream_port+0x240/0x568
Read of size 8 at addr ffff000004f56020 by task kworker/u8:3/42

Call trace:
 __asan_report_load8_noabort+0x20/0x30
 mv88e6xxx_setup_upstream_port+0x240/0x568
 mv88e6xxx_setup+0xebc/0x1eb0
 dsa_register_switch+0x1af4/0x2ae0
 mv88e6xxx_register_switch+0x1b8/0x2a8
 mv88e6xxx_probe+0xc4c/0xf60
 mdio_probe+0x78/0xb8
 really_probe+0x2b8/0x5a8
 __driver_probe_device+0x164/0x298
 driver_probe_device+0x78/0x258
 __device_attach_driver+0x274/0x350

Allocated by task 42:
 __kasan_kmalloc+0x84/0xa0
 __kmalloc_cache_noprof+0x298/0x490
 dsa_switch_touch_ports+0x174/0x3d8
 dsa_register_switch+0x800/0x2ae0
 mv88e6xxx_register_switch+0x1b8/0x2a8
 mv88e6xxx_probe+0xc4c/0xf60
 mdio_probe+0x78/0xb8
 really_probe+0x2b8/0x5a8
 __driver_probe_device+0x164/0x298
 driver_probe_device+0x78/0x258
 __device_attach_driver+0x274/0x350

Freed by task 42:
 __kasan_slab_free+0x48/0x68
 kfree+0x138/0x418
 dsa_register_switch+0x2694/0x2ae0
 mv88e6xxx_register_switch+0x1b8/0x2a8
 mv88e6xxx_probe+0xc4c/0xf60
 mdio_probe+0x78/0xb8
 really_probe+0x2b8/0x5a8
 __driver_probe_device+0x164/0x298
 driver_probe_device+0x78/0x258
 __device_attach_driver+0x274/0x350

The simplest way to fix the bug is to delete the routing table in its
entirety. dsa_tree_setup_routing_table() has no problem in regenerating
it even if we deleted links between ports other than those of switch N,
because dsa_link_touch() first checks whether the port pair already
exists in dst->rtable, allocating if not.

The deletion of the routing table in its entirety already exists in
dsa_tree_teardown(), so refactor that into a function that can also be
called from the tree setup error path.

In my analysis of the commit to blame, it is the one which added
dsa_link elements to dst->rtable. Prior to that, each switch had its own
ds->rtable which is freed when the switch fails to probe. But the tree
is potentially persistent memory.

Fixes: c5f51765a1f6 ("net: dsa: list DSA links in the fabric")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20250414213001.2957964-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[ Backport the fix to net/dsa/dsa2.c in v6.1.y for dsa2.c was
renamed back into dsa.c by commit
47d2ce03dcfb ("net: dsa: rename dsa2.c back into dsa.c and create its header")
since v6.2. ]
Signed-off-by: Bin Lan <lanbincn@139.com>
---
 net/dsa/dsa2.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index 98f864879175..668699d7b0b7 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -1148,6 +1148,16 @@ static void dsa_tree_teardown_lags(struct dsa_switch_tree *dst)
 	kfree(dst->lags);
 }
 
+static void dsa_tree_teardown_routing_table(struct dsa_switch_tree *dst)
+{
+	struct dsa_link *dl, *next;
+
+	list_for_each_entry_safe(dl, next, &dst->rtable, list) {
+		list_del(&dl->list);
+		kfree(dl);
+	}
+}
+
 static int dsa_tree_setup(struct dsa_switch_tree *dst)
 {
 	bool complete;
@@ -1165,7 +1175,7 @@ static int dsa_tree_setup(struct dsa_switch_tree *dst)
 
 	err = dsa_tree_setup_cpu_ports(dst);
 	if (err)
-		return err;
+		goto teardown_rtable;
 
 	err = dsa_tree_setup_switches(dst);
 	if (err)
@@ -1197,14 +1207,14 @@ static int dsa_tree_setup(struct dsa_switch_tree *dst)
 	dsa_tree_teardown_switches(dst);
 teardown_cpu_ports:
 	dsa_tree_teardown_cpu_ports(dst);
+teardown_rtable:
+	dsa_tree_teardown_routing_table(dst);
 
 	return err;
 }
 
 static void dsa_tree_teardown(struct dsa_switch_tree *dst)
 {
-	struct dsa_link *dl, *next;
-
 	if (!dst->setup)
 		return;
 
@@ -1218,10 +1228,7 @@ static void dsa_tree_teardown(struct dsa_switch_tree *dst)
 
 	dsa_tree_teardown_cpu_ports(dst);
 
-	list_for_each_entry_safe(dl, next, &dst->rtable, list) {
-		list_del(&dl->list);
-		kfree(dl);
-	}
+	dsa_tree_teardown_routing_table(dst);
 
 	pr_info("DSA: tree %d torn down\n", dst->index);
 
-- 
2.43.0




From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <io-uring+bounces-12178-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id oHAyMHSxjWnzAAsAYBR5ng
	(envelope-from <io-uring+bounces-12178-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:54:44 +0000
Return-path: <io-uring+bounces-12178-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 10:54:44 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <io-uring+bounces-12178-hi=josie.lol@vger.kernel.org>)
	id 1vqULM-000000034Ui-2XzG
	for hi@josie.lol;
	Thu, 12 Feb 2026 10:54:44 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 9FA0F30E6031
	for <hi@josie.lol>; Thu, 12 Feb 2026 10:53:09 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id BD0D6318BAB;
	Thu, 12 Feb 2026 10:52:33 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fhfGAhM4"
X-Original-To: io-uring@vger.kernel.org
Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AC5D31E10B
	for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 10:52:30 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770893553; cv=none; b=Y6YkqnqNbK0/7vSVjh+xScp9QAIh0Jc+EL+nlZOZ22NvHlkUgo6SWsFqViKhqFSpsvtg68zT8KgYmqVypb6ODcA+RTb7FoH+3nZu7s+ylqdbiLgpU1OcWCBj59yNcvCbxQZ32caqyAsCAgcMnrpfuBbNe//TRyH9Ob4KCfYyk/o=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770893553; c=relaxed/simple;
	bh=vDmlrrh4BLYaRR2l3ElM2gSOc+TGgSPsvhONw2b2DjM=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=HObdl5EXDWafm7Y3B+Nwzp1gg0GomsCKceF0oKffEojyb2SMvoqsHQBX1t+4pBxWK2DslD1nL7YXTXCLOhsf+sUEuNxQswfKe44JRCNqwzCHitlMxFcynim6JNX1MCMuUU+lxRfP3Y6ANXv+UXBxUxt3Z56dKg5kAWAGTJKrf58=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fhfGAhM4; arc=none smtp.client-ip=209.85.128.46
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48334ee0aeaso28081665e9.1
        for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 02:52:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1770893549; x=1771498349; darn=vger.kernel.org;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=i7QK3EogTA2awwuFyYLWPGKb9u4Hhfpc0q+gDE6cl74=;
        b=fhfGAhM4OqwHWwaKNJtPn6hovTbFJlEicirI7hVY70vcZX6IAbyu9SOVTNKGxsW02g
         b9ZEO8fT6ljEDJ7+bb/vu1EGOGjIZWI3vJc0wTABTZ/wDp7tLtxVl1Ro9UU8MkLlNYfT
         r6FSzw032GNVVsS+J94iNH8iL5R9nvl2v8qVtRxvs3TlUyiwUapST6F6RYXIM5/7iFux
         MkNr8bhthdICvViw0fdunLrqu/FkVpAF+QVXRr8gGCynVqyrVJIJAkmnm3ifWYmKZ3jg
         dCerdnrM/7BOetdaRDh2Ur3Rmx7QsskMV0iwj1ZQsuKIQKKvBMaM8cpzZ3XKzp00U4Dx
         Q/9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770893549; x=1771498349;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=i7QK3EogTA2awwuFyYLWPGKb9u4Hhfpc0q+gDE6cl74=;
        b=VhB8LAgNJZA5HKTylL5TBfKaa1A5bbb4HomU14/SymE7+Ygt7R43GHolWJItMeF8Yp
         xCA182a1Ppu4XYxm+cYaHeMakMK3yg/uCyuugS5y4coE9r1/yjlRq5SVSHRMS72F9zq7
         AtcNwZxgJtC6d0uCQO/sj/EYPUXmFWjHzNL14Xjlvz8Ukuess6tM3mIzjQ8UJLwQHAXu
         e6jmRj84tA9UN95/OtcRt+qV5r0Z+47PtOFWOz2LZRAcBnjzoW3mYFD8Caa8psfDzQcI
         sk+67gPCgMO+9ZJCHrz3xc4Gyu/xCSiNMDv/UbxavI63RgnTlH6AXNCHoeZqhU9LF1Ds
         Dtpg==
X-Forwarded-Encrypted: i=1; AJvYcCVpMlfCwUyVfgrU7bCcqHBlR5SEla0XGb0ty4Y3BocOCKH+Y5S9l6ZARyf0ZSEczpMhYVpEipiyKw==@vger.kernel.org
X-Gm-Message-State: AOJu0YzbnfFBrLCvs+5VyX622clsVxNHXW/ZWdhA4VxQ90AwUxvdV0V2
	q8XcyYOwvhCGHw2UH7OHLB3NY+l5pnk3oRQQ/8ah+hRGR4A5dx9uCxYM
X-Gm-Gg: AZuq6aIIQ09SdvPSBXStuAVnIf0tCuaSS9Zt85cSKnwN9zqOHKHc07cA66BLuoPWJUz
	4AATiKjVPHT41FAnVL+/Jozy+pSvzA5kJurh4ytqFgpI0bZnXOxQRazDQbwG0n6IueqyEsgqXJg
	SLSbuolWONLnk8x1KF9yYuGs48BoVMOroHAMjt9MYDI+hD1hp2zVM35MoRzuuYzdLinQHgK5lb1
	MnJC0SsT9k/UWZks4+9bsSt15N+/eMKsac2mIDzhsJwY/B1oeNhkRL7+hMc2SR/M7aACg36y2lb
	l6hFtWQZ7Fd65zkq9xRRk2aHm5O56sSjaF7T7JsAweJkd2WU+hR7OBa7GzTQRgql3Ipu7QDMlHX
	GgYU5kj/pfyd9qE3vrfdhneGtztYCa6u+LpKWUEAisMVMDR4YBavrgRkT1hXiRnE80cRKYOzGVp
	rxe0kUiAL46hR8LeG5JPPhbU++kRTNOIfxDQABFfc+HpwOMG1933eGrQ2CmUk8bZAHfOekmLQnS
	ZvrXcLt/PQHH893ko52vtzKzB3/ZMJOH2c52rWsUQ2tUa3lwwPwfVlCA0I7VyduonCUoNfNDPYY
	kQ==
X-Received: by 2002:a05:600d:486:10b0:483:6a8d:b2f9 with SMTP id 5b1f17b1804b1-4836a8db4f0mr14923255e9.5.1770893549133;
        Thu, 12 Feb 2026 02:52:29 -0800 (PST)
Received: from ?IPV6:2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c? ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c])
        by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4836131d52bsm36821225e9.28.2026.02.12.02.52.28
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Thu, 12 Feb 2026 02:52:28 -0800 (PST)
Message-ID: <809cd04b-007b-46c6-9418-161e757e0e80@gmail.com>
Date: Thu, 12 Feb 2026 10:52:29 +0000
Precedence: bulk
X-Mailing-List: io-uring@vger.kernel.org
List-Id: <io-uring.vger.kernel.org>
List-Subscribe: <mailto:io-uring+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:io-uring+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 03/11] io_uring/kbuf: add support for kernel-managed
 buffer rings
To: Christoph Hellwig <hch@infradead.org>,
 Joanne Koong <joannelkoong@gmail.com>
Cc: axboe@kernel.dk, io-uring@vger.kernel.org, csander@purestorage.com,
 krisman@suse.de, bernd@bsbernd.com, linux-fsdevel@vger.kernel.org
References: <20260210002852.1394504-1-joannelkoong@gmail.com>
 <20260210002852.1394504-4-joannelkoong@gmail.com>
 <89c75fc1-2def-4681-a790-78b12b45478a@gmail.com>
 <CAJnrk1ZZyYmwtzcHAnv2x8rt=ZVsz7CXCVV6jtgMMDZytyxp3A@mail.gmail.com>
 <1c657f67-0862-4e13-9c71-7217aeecef61@gmail.com>
 <CAJnrk1YXmxqUnT561-J7seaicxFRJTyJ=F3_MX1rmtAROC6Ybg@mail.gmail.com>
 <aY2mdLkqPM0KfPMC@infradead.org>
Content-Language: en-US
From: Pavel Begunkov <asml.silence@gmail.com>
In-Reply-To: <aY2mdLkqPM0KfPMC@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-DKIM: signer='gmail.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider
                             [asml.silence[at]gmail.com]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
                             EnvelopeFrom freemail headers are
                             different
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On 2/12/26 10:07, Christoph Hellwig wrote:
> On Wed, Feb 11, 2026 at 02:06:18PM -0800, Joanne Koong wrote:
>>> I don't think I follow. I'm saying that it might be interesting
>>> to separate rings from how and with what they're populated on the
>>> kernel API level, but the fuse kernel module can do the population
>>
>> Oh okay, from your first message I (and I think christoph too) thought
>> what you were saying is that the user should be responsible for
>> allocating the buffers with complete ownership over them, and then
>> just pass those allocated to the kernel to use. But what you're saying
>> is that just use a different way for getting the kernel to allocate
>> the buffers (eg through the IORING_REGISTER_MEM_REGION interface). Am
>> I reading this correctly?
> 
> I'm arguing exactly against this.  For my use case I need a setup
> where the kernel controls the allocation fully and guarantees user
> processes can only read the memory but never write to it.  I'd love
> to be able to piggy back than onto your work.

IORING_REGISTER_MEM_REGION supports both types of allocations. It can
have a new registration flag for read-only, and then you either make
the bounce avoidance optional or reject binding fuse to unsupported
setups during init. Any arguments against that? I need to go over
Joanne's reply, but I don't see any contradiction in principal with
your use case.

-- 
Pavel Begunkov



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215943-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 8H8+Mze0jWmzbwsAYBR5ng
	(envelope-from <stable+bounces-215943-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:06:31 +0000
Return-path: <stable+bounces-215943-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 11:06:32 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215943-hi=josie.lol@vger.kernel.org>)
	id 1vqUWl-00000003Q53-1Gsg
	for hi@josie.lol;
	Thu, 12 Feb 2026 11:06:31 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 9D21130774F2
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:04:05 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id E24B23446DA;
	Thu, 12 Feb 2026 11:04:03 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oi0PRiJV"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF9CD1D5CD9;
	Thu, 12 Feb 2026 11:04:03 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770894243; cv=none; b=C7i64zfSwcA9rly+rg9GToK9V0bdwvXkmvyfIkbV6Vzgk/8+c90AXFzFamqMZDioWtHs5VtPWzGv7zqQ8eHggp669hADDn+eCCfi3QbYihvWEhFR4vkf8+ArLPEaiQxqXd6zKAbX6n2+GDIXGSPL43X7VJo1VzR0HQtS63998n4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770894243; c=relaxed/simple;
	bh=5vSbprRosksE04vwNa8oFaR5lXnaQ5PV1yZExADSpyI=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=K5IG9jdYOc1pPd4qtjqN7vmqxNIHostmpVMX6ytXboAiyTAeqB8nhr6Pa7GD+YF3xc+z4/1AO83ukXQFjzbFfb0TYYdoZR4djItW0E/CU/GBQKgnOFu1Ltovq8Ku+v9Y4Vu2E2SjQYifEZ+oMeMAqajUKTOPDDosLAHyORU5D6g=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oi0PRiJV; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42B93C19422;
	Thu, 12 Feb 2026 11:04:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770894243;
	bh=5vSbprRosksE04vwNa8oFaR5lXnaQ5PV1yZExADSpyI=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=oi0PRiJVSkn8ncOEdV4em5QI9hBsxAAytVUMx3YSv5JtHfih12nlBjIEKVP8whuO2
	 L7P8S74lMGl6SmM5B79M/ELgVSNB7yHUMm2Uwa8HYgmPZb+99ygDqGMZ9roPo7B4dh
	 eGzRkkzwZT4iY4N1M3f5uHcDnswb0QrBkQpcGnfjJw/I3VpKEq2U1JeTp0843KOO+5
	 +IOL58eHTlvQr7b+K3xLuvmJWHPYqTPNbw7U340QwESrwUh8wBdK3+Yvni2soxd6sl
	 jNcN83U3MKgvZglqHFHrPthTL/Bsug71JAhwuTFTJwCR3hgP2X4lTyCTzZjdBrppkv
	 6zQ8zVUkPSAaQ==
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: stable@vger.kernel.org,
	gregkh@linuxfoundation.org
Cc: MPTCP Upstream <mptcp@lists.linux.dev>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	Mat Martineau <martineau@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH 5.15.y] selftests: mptcp: pm: ensure unknown flags are ignored
Date: Thu, 12 Feb 2026 12:03:45 +0100
Message-ID: <20260212110344.781836-2-matttbe@kernel.org>
X-Mailer: git-send-email 2.51.0
In-Reply-To: <2025122947-enforced-elective-e753@gregkh>
References: <2025122947-enforced-elective-e753@gregkh>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=3827; i=matttbe@kernel.org; h=from:subject; bh=5vSbprRosksE04vwNa8oFaR5lXnaQ5PV1yZExADSpyI=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDJ7N090WWr9oKTn2UGz2pmi+eYXW8X6byUckdttZfl2q uuPO1ZGHaUsDGJcDLJiiizSbZH5M59X8ZZ4+VnAzGFlAhnCwMUpABOpCGdkaPK9UrNToibkyISU GJFb/lPVZ1lYH0+SE41afynjaNLnLkaGs7J2Bp2FcpxHC2ZxXj90LEH4n2nZbo4jJ/1m7HkfXra TCwA=
X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073
Content-Transfer-Encoding: 8bit
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

commit 29f4801e9c8dfd12bdcb33b61a6ac479c7162bd7 upstream.

This validates the previous commit: the userspace can set unknown flags
-- the 7th bit is currently unused -- without errors, but only the
supported ones are printed in the endpoints dumps.

The 'Fixes' tag here below is the same as the one from the previous
commit: this patch here is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.

Fixes: 01cacb00b35c ("mptcp: add netlink-based PM")
Cc: stable@vger.kernel.org
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20251205-net-mptcp-misc-fixes-6-19-rc1-v1-2-9e4781a6c1b8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[ Conflicts in pm_netlink.sh, because some refactoring have been done
  later on: commit 0d16ed0c2e74 ("selftests: mptcp: add
  {get,format}_endpoint(s) helpers") and commit c99d57d0007a
  ("selftests: mptcp: use pm_nl endpoint ops") are not in this version.
  The same operation can still be done at the same place, without using
  the new helpers.
  Also, commit 1dc88d241f92 ("selftests: mptcp: pm_nl_ctl: always look
  for errors") is not in this version, and create a conflict in the
  context which is not related to the modification here.
  Conflicts in pm_nl_ctl.c, because commit 69c6ce7b6eca ("selftests:
  mptcp: add implicit endpoint test case") is not in this version, and
  caused a conflict in the context which is not related to the
  modification here. ]
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 tools/testing/selftests/net/mptcp/pm_netlink.sh |  4 ++++
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c   | 11 +++++++++++
 2 files changed, 15 insertions(+)

diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
index 68e05bd3526e..e3ab2f5ef304 100755
--- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
+++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
@@ -124,6 +124,10 @@ id 8 flags signal 10.0.1.8" "id limit"
 ip netns exec $ns1 ./pm_nl_ctl flush
 check "ip netns exec $ns1 ./pm_nl_ctl dump" "" "flush addrs"
 
+ip netns exec $ns1 ./pm_nl_ctl add 10.0.1.1 flags unknown
+check "ip netns exec $ns1 ./pm_nl_ctl dump" "id 1 flags  10.0.1.1" "ignore unknown flags"
+ip netns exec $ns1 ./pm_nl_ctl flush
+
 ip netns exec $ns1 ./pm_nl_ctl limits 9 1
 check "ip netns exec $ns1 ./pm_nl_ctl limits" "$default_limits" "rcv addrs above hard limit"
 
diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
index 354784512748..e50075be0e4d 100644
--- a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
+++ b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
@@ -22,6 +22,8 @@
 #define MPTCP_PM_NAME		"mptcp_pm"
 #endif
 
+#define MPTCP_PM_ADDR_FLAG_UNKNOWN _BITUL(7)
+
 static void syntax(char *argv[])
 {
 	fprintf(stderr, "%s add|get|set|del|flush|dump|accept [<args>]\n", argv[0]);
@@ -238,6 +240,8 @@ int add_addr(int fd, int pm_family, int argc, char *argv[])
 					flags |= MPTCP_PM_ADDR_FLAG_BACKUP;
 				else if (!strcmp(tok, "fullmesh"))
 					flags |= MPTCP_PM_ADDR_FLAG_FULLMESH;
+				else if (!strcmp(tok, "unknown"))
+					flags |= MPTCP_PM_ADDR_FLAG_UNKNOWN;
 				else
 					error(1, errno,
 					      "unknown flag %s", argv[arg]);
@@ -436,6 +440,13 @@ static void print_addr(struct rtattr *attrs, int len)
 					printf(",");
 			}
 
+			if (flags & MPTCP_PM_ADDR_FLAG_UNKNOWN) {
+				printf("unknown");
+				flags &= ~MPTCP_PM_ADDR_FLAG_UNKNOWN;
+				if (flags)
+					printf(",");
+			}
+
 			/* bump unknown flags, if any */
 			if (flags)
 				printf("0x%x", flags);
-- 
2.51.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <io-uring+bounces-12179-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 2GwXDQm4jWn5rAwAYBR5ng
	(envelope-from <io-uring+bounces-12179-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:22:49 +0000
Return-path: <io-uring+bounces-12179-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 11:22:49 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <io-uring+bounces-12179-hi=josie.lol@vger.kernel.org>)
	id 1vqUmW-00000003svO-3bsB
	for hi@josie.lol;
	Thu, 12 Feb 2026 11:22:49 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 6399E30829AE
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:22:44 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id DEA653451BB;
	Thu, 12 Feb 2026 11:22:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="2687BFWJ"
X-Original-To: io-uring@vger.kernel.org
Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99406344DA9
	for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 11:22:41 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.45
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770895363; cv=none; b=hEiNlQWssXTAVkIPflE1+NmgJl57STSxSMsoVSbznOAvGcBcGqIWhZvQIDg30MQDzaxm6MvJAtGcEMmggnS9Hz6dDEJcAaSP4fpjdSoXgFdWwy5zis/m9DQzx1jXwPtecENtf3A8YJ5RBcSdoRIjk1BZ2r04q7u7FTdeoRJblmw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770895363; c=relaxed/simple;
	bh=r8S+g/XKpjP5qK5PLtLl0Dz5Fb5x8pUqgE8UX2PbB5M=;
	h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=WD4oHhBT1pKZl2zXGyDmcMYVsbnMd3wGRSQNSEMzijbygPslMFvGUFFuN0vsRP4k9O7o51UTKyarT3VpdEg6Gw36XL1kAcHCnVtsPokUY3IJFW1b9kIvFJnWARgjuv/mlMIyJ//1+Pr52Y5ae8FG+5IREJnTqryeexaArQwD25o=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=2687BFWJ; arc=none smtp.client-ip=209.85.161.45
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk
Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-676815e147dso54920eaf.3
        for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 03:22:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1770895360; x=1771500160; darn=vger.kernel.org;
        h=content-transfer-encoding:subject:from:cc:to:content-language
         :user-agent:mime-version:date:message-id:from:to:cc:subject:date
         :message-id:reply-to;
        bh=zYUKQPFrG9XZXM/vSsXcJfnCi4meMyT/KdhvALKcdpM=;
        b=2687BFWJMJoapQd3sK2D382YqcrV5C9PZLc4Axv6k9zBDq29RGBpvm4v38jSgdf/G9
         AEXPsO0WeIi3g6UmqW2TW47777AjPREBYWbvq16JEYmsAiCrgQ12RaUnrjSN/bdTjvxk
         heevcJIthdo9W1HBBA297okdh9XXppe0Xaum+ekHkU23aKrcsAp5vp1IcSUUiTE25ytx
         S8gVS7gsf+wnBZ/GPIQHd9BPmm//IMUK3/P/NhKc3qj4OWtvVyDYjrQ8varqt2vDSwD+
         htR27afL8eqliQRrVrqKMIzYr9Au08LOvRA9chNRimTCoe9WMIy9Uqr+3HGmy0hp5Hp1
         clPg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770895360; x=1771500160;
        h=content-transfer-encoding:subject:from:cc:to:content-language
         :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state
         :from:to:cc:subject:date:message-id:reply-to;
        bh=zYUKQPFrG9XZXM/vSsXcJfnCi4meMyT/KdhvALKcdpM=;
        b=SEvdxusDsdVmehe4D5/HANc3Oqa8ANVoptZatMUJwcQ68uP92RtbZWoyaepDoCOZPC
         RNAEStCupCrHyeWAMzjrU5CR38Ac4mB7ZsRTwlrChIv6fzxTKM7AZmT81bz2mlTA5fKL
         c4YlVBQq1Q6JdFcnEewg93ZNyMGjH6pX9nfxsDn0IrFlg/ARXAOXkEXcJfR4WWGulp5T
         nH8yxERSH1x2l+zaQbDqYEYXEcdzpH2YPMAMrJ82uDpUj5o87uiazwketOdTj4rFUNMi
         KCmSXyYSUKkUtGUw8BLc1z36hXjYcxHD7Bwo7JyONW0oI4F9222th7WwrMCtIQ3Eo2Wi
         r/Hg==
X-Gm-Message-State: AOJu0YwXSzHxYwS3mL9awfPK1aZKWX33Lbgc5oWBDl67PM2r59dy1WRM
	6ZxjEl3l2uH+aLPkH/8LVAxFNmJrIaooLywt8Imm5vNx8DDyIYCg94udJtJH3HrT/j10mDQW6V2
	76XtPWpk=
X-Gm-Gg: AZuq6aLjsZbtiSkQmCNNKzhysiGuMZ6bcvX6eEa2/1txYAktFlFIVTSrCSSVxX+0QhF
	xIMXQ03w8vKZcIdGe5TrLLty2cxxUxZulQ5OxzGwVVLaGW9sn7cw/ULYHwO8WEuWdehwr+SYQ73
	cQ0c8fCc/AAgftpizvT58rzUwAb97OwGN+h6xepOFWfhp3mLL/wvBI9sC9VqZNZpZAkdrgm26mD
	napvplZ1Tf0Q7wcMP/BTcsywXxoE5b+W3BEnZSUrUoHFs4dVxayLvLW0Wgr2WwYCwIKYJ1cqIYD
	/I+0rMySAbx2vwNRtwoqcNBFtegg9aJh4hxb1Vgef/4pZ98iJOmct0mXT926rNhFoueynsSXYZY
	RCNurRzZMtdX4ryLiMlKQC/iZWVFd+3POhnb8lmwJrUWZQlAYkBYjLMckjDZZEXivUmF38kTYAx
	CaE0EOdoKfhH4Ern/VNGkdwoU6Qi4e1twk6VCU2G1kQ1vJdGmWKITojhf2n9ogIANCP436ZmpUz
	dary6dxLA==
X-Received: by 2002:a05:6820:188b:b0:662:f0cb:84c5 with SMTP id 006d021491bc7-675dbafc487mr621523eaf.34.1770895360521;
        Thu, 12 Feb 2026 03:22:40 -0800 (PST)
Received: from [192.168.1.150] ([198.8.77.157])
        by smtp.gmail.com with ESMTPSA id 006d021491bc7-674736da861sm2461198eaf.7.2026.02.12.03.22.39
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Thu, 12 Feb 2026 03:22:39 -0800 (PST)
Message-ID: <7eff267c-a76a-43e1-87a5-d92148abdc7d@kernel.dk>
Date: Thu, 12 Feb 2026 04:22:38 -0700
Precedence: bulk
X-Mailing-List: io-uring@vger.kernel.org
List-Id: <io-uring.vger.kernel.org>
List-Subscribe: <mailto:io-uring+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:io-uring+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: io-uring <io-uring@vger.kernel.org>
From: Jens Axboe <axboe@kernel.dk>
Subject: [GIT PULL] Large buffer support for zcrx
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-DKIM: signer='kernel-dk.20230601.gappssmtp.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 5

Hi Linus,

Now that the net PR is upstream, here's support for large buffers for
zcrx. Using larger (bigger than 4K) rx buffers can increase the effiency
of zcrx. For example, it's been shown that using 32K buffers can
decrease CPU usage by ~30% compared to 4K buffers. Please pull!

The following changes since commit d1de61db1536727c1cad049c09decff22e8b6dd7:

  io_uring/zcrx: document area chunking parameter (2026-01-14 02:13:37 +0000)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git tags/for-7.0/io_uring-zcrx-large-buffers-20260206

for you to fetch changes up to 795663b4d160ba652959f1a46381c5e8b1342a53:

  io_uring/zcrx: implement large rx buffer support (2026-01-24 08:33:03 -0700)

----------------------------------------------------------------
for-7.0/io_uring-zcrx-large-buffers-20260206

----------------------------------------------------------------
Pavel Begunkov (1):
      io_uring/zcrx: implement large rx buffer support

 include/uapi/linux/io_uring.h |  2 +-
 io_uring/zcrx.c               | 38 +++++++++++++++++++++++++++++++++-----
 2 files changed, 34 insertions(+), 6 deletions(-)

-- 
Jens Axboe



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215944-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id cIVFKa++jWn2Jw8AYBR5ng
	(envelope-from <stable+bounces-215944-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:51:11 +0000
Return-path: <stable+bounces-215944-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 11:51:11 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215944-hi=josie.lol@vger.kernel.org>)
	id 1vqVDz-00000004hJB-1FRz
	for hi@josie.lol;
	Thu, 12 Feb 2026 11:51:11 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 3C462303E3A0
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:51:08 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 1A13530BF6A;
	Thu, 12 Feb 2026 11:51:06 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u57jX9Km"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB2482FE579;
	Thu, 12 Feb 2026 11:51:05 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770897066; cv=none; b=tnM7znYteFrXyaQ4S4nJy/2RMEB10xjg3OjkKktvmpAbKuBYzKy++seN698Rumn8OpoEwCrdDNVfIBzgrWaRDwvMaAXMSOllhonSn1xdBgee224kbeJyOzHvNVZjticw2ho7CoJsmM5NCkQkrl4GfpYcYBNiGHJ4TXlm241fMNc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770897066; c=relaxed/simple;
	bh=WmbzLKDB0Uaqeg3tAn1+tey25NxlODgd+5JE8M2pG88=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=LbFMEIEaHUc1f+G+6DbdLh67Uc5DDigpdyD/a4xtffEHhtmDwitlb9uTRDdGHQ0kcKFf1E4bHsei3g0iOFre9RBWkeo9gC3RUTO5NbOVfPYr9UFROxqzMBWa07KcSMepoVzanvmrg+B3ekTnVYZtAWVGprvw/4JpiLoAIqy7u7I=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u57jX9Km; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24A76C4CEF7;
	Thu, 12 Feb 2026 11:51:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770897065;
	bh=WmbzLKDB0Uaqeg3tAn1+tey25NxlODgd+5JE8M2pG88=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=u57jX9Km3ju/LH5+ytVyhvQI7LBpNCKNjSu0bNZicWxQGrCsqvWMJgTtNG8qHZQc8
	 F4gyV6SkzMrxOrwOaVq+MdXupEwq7hBD7RAdYBCvgMogXywJELcqDrMPXzcZNJCF3A
	 LSxd/ZXa0aW0W+acrNEvleYAHC8Aqv0jzFy3bFJvetotbMpHa5zZpGeCaI5gStW3Sv
	 /a/KD/9pC/mjS0YemjqzLlCmd+WzDaxVZ2CT6ZmULkqb92yrMIsS68mY8L/x+RhY/b
	 9qsb2n+PWf18h11G6CbU3xTQfajQ2v+wtDcur05YHqUhcJZRIovfN6vE7TxiQZNfD1
	 ob/6/tDBmAgdg==
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: stable@vger.kernel.org,
	gregkh@linuxfoundation.org
Cc: MPTCP Upstream <mptcp@lists.linux.dev>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	Mat Martineau <martineau@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH 5.10.y] selftests: mptcp: pm: ensure unknown flags are ignored
Date: Thu, 12 Feb 2026 12:50:57 +0100
Message-ID: <20260212115056.898313-2-matttbe@kernel.org>
X-Mailer: git-send-email 2.51.0
In-Reply-To: <2025122947-clapping-zookeeper-5d32@gregkh>
References: <2025122947-clapping-zookeeper-5d32@gregkh>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=3927; i=matttbe@kernel.org; h=from:subject; bh=WmbzLKDB0Uaqeg3tAn1+tey25NxlODgd+5JE8M2pG88=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDJ79y18opx92rg+kGnPjfLyFRdsnnU5/fF+cWlXRu/6o DOnv++a31HKwiDGxSArpsgi3RaZP/N5FW+Jl58FzBxWJpAhDFycAjCRcyGMDDceskVdfbDNO/zy aV/L21PtpxuezHkt/dJlo+RrllPRUy0YGX6ZeJ4NPaUR1VrKrq2wQb334qNg/6Tt59V/m2QuKdM 1ZQEA
X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073
Content-Transfer-Encoding: 8bit
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: msgid.link]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

commit 29f4801e9c8dfd12bdcb33b61a6ac479c7162bd7 upstream.

This validates the previous commit: the userspace can set unknown flags
-- the 7th bit is currently unused -- without errors, but only the
supported ones are printed in the endpoints dumps.

The 'Fixes' tag here below is the same as the one from the previous
commit: this patch here is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.

Fixes: 01cacb00b35c ("mptcp: add netlink-based PM")
Cc: stable@vger.kernel.org
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20251205-net-mptcp-misc-fixes-6-19-rc1-v1-2-9e4781a6c1b8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[ Conflicts in pm_netlink.sh, because some refactoring have been done
  later on: commit 0d16ed0c2e74 ("selftests: mptcp: add
  {get,format}_endpoint(s) helpers") and commit c99d57d0007a
  ("selftests: mptcp: use pm_nl endpoint ops") are not in this version.
  The same operation can still be done at the same place, without using
  the new helpers.
  Also, commit 1dc88d241f92 ("selftests: mptcp: pm_nl_ctl: always look
  for errors") is not in this version, and create a conflict in the
  context which is not related to the modification here.
  In v5.10, endpoints couldn't be re-used directly, so the flag is
  tested before.
  Conflicts in pm_nl_ctl.c, because commit 69c6ce7b6eca ("selftests:
  mptcp: add implicit endpoint test case") and commit 371b90377e60
  ("selftests: mptcp: set and print the fullmesh flag") are not in this
  version, and caused a conflict in the context which is not related to
  the modification here. ]
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 tools/testing/selftests/net/mptcp/pm_netlink.sh |  2 +-
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c   | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
index 7d194f5c2939..9d95d7e5b70a 100755
--- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
+++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
@@ -80,7 +80,7 @@ if mptcp_lib_expect_all_features; then
 subflows 0" "defaults limits"
 fi
 
-ip netns exec $ns1 ./pm_nl_ctl add 10.0.1.1
+ip netns exec $ns1 ./pm_nl_ctl add 10.0.1.1 flags unknown
 ip netns exec $ns1 ./pm_nl_ctl add 10.0.1.2 flags subflow dev lo
 ip netns exec $ns1 ./pm_nl_ctl add 10.0.1.3 flags signal,backup
 check "ip netns exec $ns1 ./pm_nl_ctl get 1" "id 1 flags  10.0.1.1" "simple add/get addr"
diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
index b24a2f17d415..c6d7e0f2a8b8 100644
--- a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
+++ b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
@@ -22,6 +22,8 @@
 #define MPTCP_PM_NAME		"mptcp_pm"
 #endif
 
+#define MPTCP_PM_ADDR_FLAG_UNKNOWN _BITUL(7)
+
 static void syntax(char *argv[])
 {
 	fprintf(stderr, "%s add|get|del|flush|dump|accept [<args>]\n", argv[0]);
@@ -236,6 +238,8 @@ int add_addr(int fd, int pm_family, int argc, char *argv[])
 					flags |= MPTCP_PM_ADDR_FLAG_SIGNAL;
 				else if (!strcmp(tok, "backup"))
 					flags |= MPTCP_PM_ADDR_FLAG_BACKUP;
+				else if (!strcmp(tok, "unknown"))
+					flags |= MPTCP_PM_ADDR_FLAG_UNKNOWN;
 				else
 					error(1, errno,
 					      "unknown flag %s", argv[arg]);
@@ -373,6 +377,13 @@ static void print_addr(struct rtattr *attrs, int len)
 					printf(",");
 			}
 
+			if (flags & MPTCP_PM_ADDR_FLAG_UNKNOWN) {
+				printf("unknown");
+				flags &= ~MPTCP_PM_ADDR_FLAG_UNKNOWN;
+				if (flags)
+					printf(",");
+			}
+
 			/* bump unknown flags, if any */
 			if (flags)
 				printf("0x%x", flags);
-- 
2.51.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <io-uring+bounces-12180-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id +INFNM6/jWnFTREAYBR5ng
	(envelope-from <io-uring+bounces-12180-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:55:58 +0000
Return-path: <io-uring+bounces-12180-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 11:55:59 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <io-uring+bounces-12180-hi=josie.lol@vger.kernel.org>)
	id 1vqVIc-00000004p1y-1W0u
	for hi@josie.lol;
	Thu, 12 Feb 2026 11:55:58 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 2881230530C6
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:55:57 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E89634DCE2;
	Thu, 12 Feb 2026 11:55:55 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AUCM/s7K"
X-Original-To: io-uring@vger.kernel.org
Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66BEF296BD2
	for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 11:55:54 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.68
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770897355; cv=none; b=bJQwJ+WNxUnnGGTCLdkHrjMjvsUYzcX9DPXKJwhVxzAc/4QgxF+zliJRCRBjm52rrhjzcg1s697hqJwEBgQvX36MvIZo14FaOBvf2FrvvEaSCPNc7YrgJ8gyVwfxJKHmzdIyuMNoJuXlch8eTdFRuAXtRiaRxvqMG2RmmbKr2lU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770897355; c=relaxed/simple;
	bh=YCtOu2KV9/mCl7mKppEFkkBunz1ia1iUmnfhM1UNwIw=;
	h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=A72no6wl0LBs4/9QeOeOhasAg6ewjj6W66/bszaEq0+PsUDxDuONklAix9KoCmM2idHhGz1fCR8/GVUR6GLSPWW8sTZ8mZagohN/5whuFzhqQgmbOapZPtFzpamAwcAoCz2exT/W6YOPab5vqclXAJB6JGVlOJt+pgBJouDObN4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AUCM/s7K; arc=none smtp.client-ip=209.85.216.68
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pj1-f68.google.com with SMTP id 98e67ed59e1d1-3538952a464so772778a91.2
        for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 03:55:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1770897354; x=1771502154; darn=vger.kernel.org;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=CyiHM3zBArshMUcVKv1ZlKJW//HEodrChAZzOzlZz4c=;
        b=AUCM/s7K+ZKpx8L+CzjtuVnMcIDF+7VrIZJtnHQaZ0idx71ghm4HL0FjAIKdRLyepf
         fY2LlBXZEe+oSM9rssnSX+kPsOp15GVmji4J7ApqJwG7sjRIAXf+A+RaV8dLUhz6isIG
         xf1GQDduVrMkSfh8gya0TEXSySzhxbZqVhcd7BOTQ1/nDvojJvIkucWUUj4koXvFf2QR
         XcUK724YnzOaEk19WiLMYzJUQnEMiJurb2gNE3QTBy6tez1LLdqJVO0CVfYLMpWxH4yn
         cnH/CLCDlUCp8gLYf0WajfQfIQKwUfbUIH7txfVD0k3o/NHYI5td2VDg/wACK5SDpxWa
         P9gQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770897354; x=1771502154;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=CyiHM3zBArshMUcVKv1ZlKJW//HEodrChAZzOzlZz4c=;
        b=IWyk/yijz6TA42OqgYh0W/g+tmFEdHAasE/fhV5vnwdnh6aR5o4upNSD/gEYgC9UdH
         F4KZpdkXyFWzbEUcTwfkmjhKMefFuTie05uM/AFrHVa/x30OFUkx1sY6pGPObGu7VF+3
         9eRmtga3xe0xQBoUjPKVtGes9kSgAn3pZhnmxbZhwVIPm8pBYTKCFE1gm4ZenUQSyrRD
         JsdTi0EFHYs2I0R03YMFf7VvVS23O/yIZLRqhmdBAOT7U8vWyg/NxfMaLLvjs755PqDK
         xPEvTUsw9qT4ag9vIUxERzCP8fSKpiKEetqQPRptY6Aq+TDZkcYtjK1bWwnzp7khrNBv
         NVPQ==
X-Gm-Message-State: AOJu0Yz81BsnnDr3WmFDdVzEH+4ZFW00vxsJ4WFhL2MIK2LeBggWvYfU
	QctmU+7BI0AH2UXogl7v2T4hgKn0mxCCbH8tF8KXS0WPb9aCUXtbf0k/
X-Gm-Gg: AZuq6aJ7m+Stn9riYvE6wHfiWX1bGbhgbf3wJ/6krgofRIlFzwCUiEwGB6qKCVbz3lh
	bsYCR0zkO3HUmxAZMO1lm8+9I9Ucz3t8FS4o5UM985pHITwQXBS+rx4TZcDhaIXvTwYhTWAXIZr
	Q/Dl505i+CWWKWRJpMmEPK8z56aSbpTarObSs3GGQsot/nX386uO1KWQenAYR8F9bse80v3+71j
	rJYMdEu9wrbtVxdKzU9r7lFIUo8DqrpIic3Mdtv4NzJz/35ZVkuTjRzezHd4r7ZE9kYn9q37DkP
	QW5gPt8g9SK2ELXSkjrB5Em057SIzSchhUimjET3HvuZgtSwvMkO8K+WWboGPpzqc8KgDOyu4bp
	SvydY8NJG2Hc6sMaf8NTjZNXyW2UM8LzFXhQZPdq04vdDhiMdyWr4hzSl6GN51f0YeRruLKuQtK
	B6/GHz661DF4B4LlpayX9x0HVvjWot4ciGlzV3VG3/yV5O0DKh3kXG+NinpjOcPXdQr8h57cvU7
	UduoCT4SlnoqRc=
X-Received: by 2002:a17:90b:4c12:b0:354:a57c:65ef with SMTP id 98e67ed59e1d1-3568f41081cmr1771779a91.6.1770897353698;
        Thu, 12 Feb 2026 03:55:53 -0800 (PST)
Received: from cute.. ([2405:201:31:d01f:1c4d:265b:8163:813b])
        by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6e1967c6fasm5631830a12.1.2026.02.12.03.55.50
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 12 Feb 2026 03:55:53 -0800 (PST)
From: Soham Kute <officialsohamkute@gmail.com>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	syzbot+ab12f0c08dd7ab8d057c@syzkaller.appspotmail.com,
	Soham Kute <officialsohamkute@gmail.com>
Subject: [PATCH] io_uring: fix list corruption race in io_pollfree_wake()
Date: Thu, 12 Feb 2026 17:24:58 +0530
Message-Id: <20260212115458.9149-1-officialsohamkute@gmail.com>
X-Mailer: git-send-email 2.34.1
Precedence: bulk
X-Mailing-List: io-uring@vger.kernel.org
List-Id: <io-uring.vger.kernel.org>
List-Subscribe: <mailto:io-uring+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:io-uring+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='gmail.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: syzkaller.appspot.com]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider
                             [officialsohamkute[at]gmail.com]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
                             EnvelopeFrom freemail headers are
                             different
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

io_pollfree_wake() removes the poll wait entry without holding
the waitqueue head lock. Other removal paths take the head lock,
so this can race and lead to list corruption detected by list_debug.

Acquire the waitqueue lock before calling io_poll_remove_waitq(),
matching the locking used in io_poll_remove_entry().

Reported-by: syzbot+ab12f0c08dd7ab8d057c@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=ab12f0c08dd7ab8d057c
Signed-off-by: Soham Kute <officialsohamkute@gmail.com>
---
 io_uring/poll.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/io_uring/poll.c b/io_uring/poll.c
index aac4b3b88..006154355 100644
--- a/io_uring/poll.c
+++ b/io_uring/poll.c
@@ -383,10 +383,17 @@ static void io_poll_cancel_req(struct io_kiocb *req)
 
 static __cold int io_pollfree_wake(struct io_kiocb *req, struct io_poll *poll)
 {
+	struct wait_queue_head *head;
 	io_poll_mark_cancelled(req);
 	/* we have to kick tw in case it's not already */
 	io_poll_execute(req, 0);
-	io_poll_remove_waitq(poll);
+	/* Pairs with smp_store_release() in io_poll_remove_waitq() */
+	head = smp_load_acquire(&poll->head);
+	if (head) {
+		spin_lock_irq(&head->lock);
+		io_poll_remove_waitq(poll);
+		spin_unlock_irq(&head->lock);
+	}
 	return 1;
 }
 
-- 
2.34.1



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215945-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id uIrnEZLAjWnkhBEAYBR5ng
	(envelope-from <stable+bounces-215945-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:59:14 +0000
Return-path: <stable+bounces-215945-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 11:59:14 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215945-hi=josie.lol@vger.kernel.org>)
	id 1vqVLl-00000004ure-3aNB
	for hi@josie.lol;
	Thu, 12 Feb 2026 11:59:14 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 79A2F3053AAF
	for <hi@josie.lol>; Thu, 12 Feb 2026 11:59:11 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 3073734DCE2;
	Thu, 12 Feb 2026 11:59:10 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lgFY8y4V"
X-Original-To: stable@vger.kernel.org
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17AF9296BD2;
	Thu, 12 Feb 2026 11:59:07 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770897550; cv=none; b=EMCj99xwgJb7QdBgoaAWabl85EWl6VU+42C0ZuT3BFa8CAe6khhplayqgR8NnXqh6WEXftrLnCGvkFdL1s0rg03m/2lsIlJP86g4EayzHOzcy73aFCSlMeIgvtazMKOhro7hbSL+yg97ACXKNRf48MJSKGg2EoAMN/vHbWao7Nc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770897550; c=relaxed/simple;
	bh=nA8+PJsKz/Qxikad9cmNxC/qX/Tn7x7XJkvi8067PzQ=;
	h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Gj3kJxXDHTBq6wntwCy7Z5bzdue765p7FTGt0rEjpr3DVS/VKU7wvh/s0WydGCrTFadbPDX8S4XmAOPvCyTHaebc7b3jwdn6z2/DCDEN8cIjbf2qdr2P4F+wa8H6YFPnGAcG3sOKUwbcbcikufQ6qr5LXQYjYyxxaJVtduNaSiM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=lgFY8y4V; arc=none smtp.client-ip=213.167.242.64
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com
Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c68:63f7:8b59:bf7b:a87:f18a])
	by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A1B2492;
	Thu, 12 Feb 2026 12:58:17 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;
	s=mail; t=1770897498;
	bh=nA8+PJsKz/Qxikad9cmNxC/qX/Tn7x7XJkvi8067PzQ=;
	h=From:Date:Subject:To:Cc:From;
	b=lgFY8y4V3mnLk4mAwWB3Usqy8TpKSkdVNVUqLLxvLr8diMbiNW9NDcyMnEtAN6x9R
	 U3h4Qt1n1Mt8ud86e8NFffqtj8RkJ4/w27a/293qwj4y3wK9mN2EdinHjuuGBLlSD0
	 EhXYrLMJISuucrGdwDPWgx9hgiICeW+7qnxJ9rFA=
From: Jai Luthra <jai.luthra@ideasonboard.com>
Date: Thu, 12 Feb 2026 17:28:48 +0530
Subject: [PATCH] media: i2c: imx283: Enter full standby when stopping
 streaming
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20260212-imx283-hang-fix-v1-1-57784739604c@ideasonboard.com>
X-B4-Tracking: v=1; b=H4sIAHfAjWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE
 vPSU3UzU4B8JSMDIzMDI0Mj3czcCiMLY12QnG5aZoWuRZJxmompgYV5apqZElBXQVEqUBhsYnR
 sbS0Awkusw2EAAAA=
X-Change-ID: 20260212-imx283-hang-fix-8b3f45087ef6
To: Sakari Ailus <sakari.ailus@linux.intel.com>, 
 Kieran Bingham <kieran.bingham@ideasonboard.com>, 
 Umang Jain <uajain@igalia.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, 
 Hans Verkuil <hverkuil@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, 
 stable@vger.kernel.org, Jai Luthra <jai.luthra@ideasonboard.com>
X-Mailer: b4 0.14.2
X-Developer-Signature: v=1; a=openpgp-sha256; l=1842;
 i=jai.luthra@ideasonboard.com; h=from:subject:message-id;
 bh=nA8+PJsKz/Qxikad9cmNxC/qX/Tn7x7XJkvi8067PzQ=;
 b=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBpjcCDSBZsM79/NBu8Jo9TAo2BitR1jg4kFUA/C
 akuQ9P9lpKJAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCaY3AgwAKCRBD3pH5JJpx
 RUC0D/sGPUwPLJkMflzdBOh+/4enx7JzKZbXe6xcZwALzaiPxFVoNT/eatrkFqSz3RgTs27QfUX
 i1otE7ZJaF6VmLx2L3QeoDWc0ak6qLN2nnI9UzOeiLIN+qk/tbGUUKQrJ+sYdlx3DGUd/WIKVOz
 FAGlm+zqyuZ4vM/GVKSYT4ZEWg2ysEyz6MzbfW4EByZocJPNX1wxVbsSTafk9O6HhM5Fg6AE7B7
 bnmcHwE8CmzF3yaChzaZ6p7D3s1lg7OSaZ3rCSOoSx1DBKSuxCo12ZRfFMGiT3tLkd9ksOU9j3D
 /7jxEadZzZDPVsrAiQ79VgpnaP5SGy+f6V4x2S1Vo7QiO6wIQ8sUlEvySzLobk3E+0OIk374hx5
 XUk6BDLiQYfB16tiiXBOeFifAy4ymXqO6q6YqwCMvmWRNCW8qbX1DyBcjkF10mc3SIV8X2wn7Ba
 S1ae0LRC2JdSeIeUpfh3hcU7iUNfWzN+w2GNohFFdfuq4vk6rKnv+HW1kfpEQL6TfEcTV7vh6T5
 zgYsl/NGBUjL5Gw3HD2lcGSEODEGxHxLGFDc6i8KOPuumnvRna6VykJdsiZANwXZdJwbEgER5Vy
 Jt4j4jx1Py92mcpgpFzRKCtfVHrB+yn0OoIg2tdAdWvaheS/jW4J8/DCkbzy3NYZfGXDtz9Fymm
 ZenSxzyLuVlmhzQ==
X-Developer-Key: i=jai.luthra@ideasonboard.com; a=openpgp;
 fpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145
X-DKIM: signer='ideasonboard.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: ideasonboard.com]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

Use IMX283_STANDBY (bit 0) instead of IMX283_STBLOGIC (bit 1) when
stopping streaming. STBLOGIC only puts the sensor logic into standby but
leaves the MIPI interface (along with other components) in an
indeterminate state.

This (presumably) causes the CSI receiver (e.g. Raspberry Pi's CFE) to
miss the LP-11 to HS transition when streaming restarts, resulting in a
hang of 10+ seconds. The issue is most visible when immediately
restarting a full-resolution stream after stopping a 3x3 binned one, so
that runtime suspend hasn't yet been triggered.

Writing IMX283_STANDBY puts the entire sensor into standby. The
imx283_standby_cancel() sequence already handles the full wakeup from
this suspended state.

Cc: stable@vger.kernel.org
Link: https://github.com/raspberrypi/linux/issues/7153
Link: https://github.com/will127534/OneInchEye/issues/12
Fixes: ccb4eb4496fa ("media: i2c: Add imx283 camera sensor driver")
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 drivers/media/i2c/imx283.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx283.c b/drivers/media/i2c/imx283.c
index 8ab63ad8f385f6e2a2d7432feff0af09a5356dc4..9b3094a57873c6e8ff8c41d058ea3b0012642cac 100644
--- a/drivers/media/i2c/imx283.c
+++ b/drivers/media/i2c/imx283.c
@@ -1158,7 +1158,7 @@ static int imx283_disable_streams(struct v4l2_subdev *sd,
 	if (pad != IMAGE_PAD)
 		return -EINVAL;
 
-	ret = cci_write(imx283->cci, IMX283_REG_STANDBY, IMX283_STBLOGIC, NULL);
+	ret = cci_write(imx283->cci, IMX283_REG_STANDBY, IMX283_STANDBY, NULL);
 	if (ret)
 		dev_err(imx283->dev, "Failed to stop stream\n");
 

---
base-commit: 37a93dd5c49b5fda807fd204edf2547c3493319c
change-id: 20260212-imx283-hang-fix-8b3f45087ef6

Best regards,
-- 
Jai Luthra <jai.luthra@ideasonboard.com>



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <io-uring+bounces-12181-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id uBIeIa3BjWnkhBEAYBR5ng
	(envelope-from <io-uring+bounces-12181-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:03:57 +0000
Return-path: <io-uring+bounces-12181-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:03:57 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <io-uring+bounces-12181-hi=josie.lol@vger.kernel.org>)
	id 1vqVQK-000000053ds-3wmx
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:03:57 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 24237305AAAF
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:03:04 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id BB12234AAF9;
	Thu, 12 Feb 2026 12:03:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="mCIj9T1M"
X-Original-To: io-uring@vger.kernel.org
Received: from mail-oa1-f68.google.com (mail-oa1-f68.google.com [209.85.160.68])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3609B31A04E
	for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 12:03:00 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.68
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770897782; cv=none; b=W8+ZU7xkskfaJy510CCkyYx0ys7cA5M7Aac+AUKKv5sH5otQG/4pvQcO2OQPGQP7RH5b4xlqWuJ4D1x/1sXGL8+mDcSNJNgbxppICFDvYr2IrvuHqCFKJhBH5JA6yjXxsvnmcmLRifOv+kX0DjnfXJGWZ+QghwploOcprE/hphE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770897782; c=relaxed/simple;
	bh=etPO5rAF/iZNTMhRsXxVZC5DQsNDTwpHKQZKVhoz2Wc=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=koyduMYGRCSpEDtIN9s7wlRYxK0TvNd178NiEzPtkjMpuUEr40e+S1zP6JsipxR52MMyi1cUVcCBpQlsiqpvj6Zwf2mReGj9aXKaOWnPUXmhwmvBVGNcCLW3KFoUbjyYDFLo+G5DpGJPgOopMm3MlKNjUKfXDVogBy0Atyn0W7o=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=mCIj9T1M; arc=none smtp.client-ip=209.85.160.68
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk
Received: by mail-oa1-f68.google.com with SMTP id 586e51a60fabf-409521ba360so1879757fac.2
        for <io-uring@vger.kernel.org>; Thu, 12 Feb 2026 04:02:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1770897779; x=1771502579; darn=vger.kernel.org;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=j9yZyoI1MedJ91neH42mRt3C3fl0JTlkoE+1s2Qiphs=;
        b=mCIj9T1MOQwCITwMODWOhTMeIAmufBplHFyzCwKBFuGzjC3qINMzRPEoXzPabvNpsI
         YCqcWZqQtazzIPJfGp6oWTDjbRMTxDfKCy9g9xtyB70zzYdqIqROsRRLr+4dMoH1Scpw
         bciNH24F9mE6tdvYK5vPJpz2rIMVyzEIdOFcwhaCjJGmoVtNdMAaIiCi/nREpSGbxUGI
         RBET0mtWZleDKbfo09hVwL8u3u42KHNFpFEcX4NBkQY2nx1ncaEIiwezIobLn14EDy70
         30ACF9LiYik9Ggm7hOoRmmilYhkjbBxEVdTI8RAP/95jJn/5x9jE13WXNCryDWgbhRjz
         silg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770897779; x=1771502579;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=j9yZyoI1MedJ91neH42mRt3C3fl0JTlkoE+1s2Qiphs=;
        b=dayuDuSgcNp0RV+BP9BtA6yLKp8iEQAbRO8VWTXaztbpbnRrJrSNmA4NHJ/1473A0B
         fWWA4FKxTmLZNjaJLgG+hXZ/yXQZdKuSqWNg/eKOnMlqCsHzdjRbcP8ThlmkfXkarNXd
         7lJWp695x3Q0ZAIw5FgUT7PoxHIv/LksFGH08NgM7SF0vL3b/OTA6e6AApo6gwYB6l1i
         uE+lkxXKpf+fNyBfpNToneei8YMrhJVdiSPy8FyJpyuQ4EgD26in94omj/p3yfs8e0sE
         a+0Bdbl32SwOOlwOfe5/tvUXxAyNnkwGZEfOW0FBZz22PgWl/8F57zeldVry9Yz+Y8I/
         SMqA==
X-Gm-Message-State: AOJu0YxZd/1oPdb0nLCUCxxoXB4/asi/H47tgbTvZauyAoAWnhtMd1t1
	pWpxYh4UbhXH130EDyJS0K6i/D1fxbdgnCqzMxNVmiL6hUIPo0QfFpVJcnHx2UVzx1s=
X-Gm-Gg: AZuq6aLlRE5hZ1VkwT7OZRU57S9W+rvtGUtbAGBadeXgJRwXuE0ag0OMCmbkTQQzMwo
	Puj9G11ysqrxmG+3aFPAQjhqQWRBSZBrc/VFUw5WN3jikXFS3Zw5kWNin3Twhsx6fqV5Z8AQ976
	ncwNZQgwvHuo5vq1Fo/whaEWLhiyB2VQZLoKwa5WHl9cphA8Pz6v2IF15KEl8fA8WhooivMQCQo
	kRFESHbqvA9HPllDrLfRAoPMM0qUnffOsbT/SBP+LDang1w0bKFsSrcWhOVjK6EoBNCDF3ZqmAh
	cyAEGuORMNcwYo3mo7xRS/d87kULPRBKzc0kcGO4scaS4jYfpzAAaDDVlmQT4r3vTG13s+J5llG
	HiwGZcdYQeBYuRQu2X/n1UZfDv4BIIy2UTjOWkFfqcqLD+39XIWcliRvSU4UnQcC/ixRDKid5U0
	b+6tvLiVlHXPnyC0MG9Tvj6EeNHfld9QueExXvwcr7GwFDdQHVqvsmvOt1IcXLlb6d5+xcx6Zui
	mA/pJRQhg==
X-Received: by 2002:a05:687c:409b:b0:3e8:44ec:3416 with SMTP id 586e51a60fabf-40eca29f54dmr1061066fac.46.1770897778961;
        Thu, 12 Feb 2026 04:02:58 -0800 (PST)
Received: from [192.168.1.150] ([198.8.77.157])
        by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40eaf103ac3sm3493170fac.11.2026.02.12.04.02.57
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Thu, 12 Feb 2026 04:02:58 -0800 (PST)
Message-ID: <ddb783d5-f69d-45da-ae76-96578ababe03@kernel.dk>
Date: Thu, 12 Feb 2026 05:02:56 -0700
Precedence: bulk
X-Mailing-List: io-uring@vger.kernel.org
List-Id: <io-uring.vger.kernel.org>
List-Subscribe: <mailto:io-uring+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:io-uring+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] io_uring: fix list corruption race in io_pollfree_wake()
To: Soham Kute <officialsohamkute@gmail.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
 syzbot+ab12f0c08dd7ab8d057c@syzkaller.appspotmail.com
References: <20260212115458.9149-1-officialsohamkute@gmail.com>
Content-Language: en-US
From: Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20260212115458.9149-1-officialsohamkute@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-DKIM: signer='kernel-dk.20230601.gappssmtp.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 5

On 2/12/26 4:54 AM, Soham Kute wrote:
> io_pollfree_wake() removes the poll wait entry without holding
> the waitqueue head lock. Other removal paths take the head lock,
> so this can race and lead to list corruption detected by list_debug.
> 
> Acquire the waitqueue lock before calling io_poll_remove_waitq(),
> matching the locking used in io_poll_remove_entry().
> 
> Reported-by: syzbot+ab12f0c08dd7ab8d057c@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=ab12f0c08dd7ab8d057c
> Signed-off-by: Soham Kute <officialsohamkute@gmail.com>
> ---
>  io_uring/poll.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/io_uring/poll.c b/io_uring/poll.c
> index aac4b3b88..006154355 100644
> --- a/io_uring/poll.c
> +++ b/io_uring/poll.c
> @@ -383,10 +383,17 @@ static void io_poll_cancel_req(struct io_kiocb *req)
>  
>  static __cold int io_pollfree_wake(struct io_kiocb *req, struct io_poll *poll)
>  {
> +	struct wait_queue_head *head;
>  	io_poll_mark_cancelled(req);
>  	/* we have to kick tw in case it's not already */
>  	io_poll_execute(req, 0);
> -	io_poll_remove_waitq(poll);
> +	/* Pairs with smp_store_release() in io_poll_remove_waitq() */
> +	head = smp_load_acquire(&poll->head);
> +	if (head) {
> +		spin_lock_irq(&head->lock);
> +		io_poll_remove_waitq(poll);
> +		spin_unlock_irq(&head->lock);
> +	}
>  	return 1;
>  }

The callpath is io_poll_wake() -> io_pollfree_wake(), where the former
where much holds &head->lock already. How did you come to this
conclusion? Your patch would instantly deadlock.

Additionally, if you follow the replies off your syzbot link:

Closes: https://syzkaller.appspot.com/bug?extid=ab12f0c08dd7ab8d057c

you'll see I already debugged this issue, it's a media bug, and there's
no POLLFREE involved at all. And it looks like I'm not even the first
one to debug it, I subsequently found that someone else sent in a
different patch for this last year, but solving the same root cause in
media.

-- 
Jens Axboe


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215946-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id wLz+Fc/BjWk5JxAAYBR5ng
	(envelope-from <stable+bounces-215946-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:04:31 +0000
Return-path: <stable+bounces-215946-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:04:31 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215946-hi=josie.lol@vger.kernel.org>)
	id 1vqVQs-000000054d2-3twa
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:04:31 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 77C283061E2E
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:03:10 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 11DD2346A1F;
	Thu, 12 Feb 2026 12:03:10 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nNArYCtC"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E28BC346779
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 12:03:09 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770897790; cv=none; b=hCoW7jaCodqHoFAyTJjAkaYdFegRMM246CUmkox9qvehwNGkxyAWffMCxi3DFIlwWmcgEmhEuQnehiGATnMhFo6OTaaeJI25w8Bh6nMMOTbrnWdr94n/7gAGMDI7RvgaH5VgAUtdW87mgZ10P0YPCqryvgkjf1fdDBaO8BsWHX0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770897790; c=relaxed/simple;
	bh=QTG7dgC+Wfczdc3D6nBZNoS5vg83J17qa2NZgBfUULo=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=fPmz/CAa1Pmn/MBwGjvkJac7CC6yHq0DnJk9BP4jzjT28/iPtgfofkc5i+N18aQGLSXnI7c1QPpXkxE/kagncXKivSVEqP5RFt1ixOcxKvVEqI/O85Py846rCEo8Q2rp+pkAFgpcRV9B2UjGb+oDSmQrBY/ASbXi+UHrbD9ltP8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nNArYCtC; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF3AEC4CEF7;
	Thu, 12 Feb 2026 12:03:08 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1770897789;
	bh=QTG7dgC+Wfczdc3D6nBZNoS5vg83J17qa2NZgBfUULo=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=nNArYCtCv3Ic1on8deQtB1QWuQq6/gaiUSw3/qE40Mv9zVvHRmK0bhhHlOhkGNi7m
	 6nL+OT4ZaRktRXUY/xjKjIF84TwQhoUrIKlvoquhbyqdk6rklQoyYvk/urmQ0Xkqfs
	 MAs7xykxLH4MrnKU4wer3aSFtd6uGKLRGijPsz9U=
Date: Thu, 12 Feb 2026 13:03:06 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: stable <stable@vger.kernel.org>
Subject: Re: 6.12-stable inclusion request
Message-ID: <2026021246-rumbling-accustom-025a@gregkh>
References: <51b76881-90fa-4de3-9c39-68d076b5706f@kernel.dk>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51b76881-90fa-4de3-9c39-68d076b5706f@kernel.dk>
X-DKIM: signer='linuxfoundation.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

On Tue, Feb 10, 2026 at 02:58:45PM -0700, Jens Axboe wrote:
> Hi,
> 
> See:
> 
> https://github.com/axboe/liburing/issues/1530
> 
> for the reasonings here, but please add this patch to the 6.12-stable
> queue. Thanks!

Now applied, thanks.

greg k-h


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215947-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id AJg4KknCjWmtkhIAYBR5ng
	(envelope-from <stable+bounces-215947-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:06:33 +0000
Return-path: <stable+bounces-215947-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:06:33 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215947-hi=josie.lol@vger.kernel.org>)
	id 1vqVSr-0000000590Z-1Tqi
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:06:33 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id D712730C3D2D
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:05:27 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 170DC356A29;
	Thu, 12 Feb 2026 12:05:27 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VpJqUq1x";
	dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P1rG4Dbv"
X-Original-To: stable@vger.kernel.org
Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C07356A07
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 12:05:25 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770897927; cv=none; b=b5sD3rCKZxxfGPTHqJPbrKkDs1FRrz2bUPDtcgZJkjjoDgSBeWeAkvkPqFMLwWn9pYLJ8cOUlXewlCD+vzh2f6V77nPFMxp/ziqA0wdZhbpxHrnO4xyJtlH5qiZ/mCTdL3tfNa0xfS9vo/DVv9qlD2rR9h+D+WKiMldn5toBzOs=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770897927; c=relaxed/simple;
	bh=o2GFVDqXiSLUKn8UeGbPsRZ1svvguHIXozzWU8zIjZY=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=KU4XyqNqnCvunmfZnMA8U6X+yNcvnL91/XMheVttDWDL3iIVi9Z4ZLjH8FqeVWoNEeCijulNV+XW+I2kwmwwBQQru9/A6/TdltoyjktTTXb+rPeIV8d6bLwhupYVs6OQcJLOa6tHg8TRvsmpj6epC+/KqXydQsWnBziGEygMR4Y=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VpJqUq1x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P1rG4Dbv; arc=none smtp.client-ip=205.220.168.131
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com
Received: from pps.filterd (m0279866.ppops.net [127.0.0.1])
	by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61C9oEwQ3562269
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 12:05:25 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=
	cc:content-transfer-encoding:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=
	qHpGzoa3aopZAtJxfvEehMpSqEZ816kpOkyer+YIROI=; b=VpJqUq1x4U4uaVZ0
	8uMfx/11i4i/O5tLZzXy9biQVtAsH1gyOQ2Mj1AfY4TeKOG/LBF20+CuJyem2Cth
	psNooWPvjpsD/Tf1BdqcXBY545Clbx176K/2RbxMRGF/16J05Row/CnpYKA+R5fV
	FStFEkGpClfx8tltg8a1yC3ZAAMpx0PvwInuYx0vzO+qIuQ7whWGT6t7Xarxv74e
	7h7Rt4NHZrk4mZpvZCmx9b+fqQm1IVWKRCAFzhW6t0/WOGzzIBkmzLPAk5MjVEJ+
	JfzpxWIWTnSW/AMnl3wzEOksBV9rJSUZlL7Ocb34lfRU0bntKCSHIqVahF+X70x/
	Y/GgIQ==
Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71])
	by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9ck2gdc2-1
	(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 12:05:24 +0000 (GMT)
Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-895375da74bso22614796d6.0
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 04:05:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=oss.qualcomm.com; s=google; t=1770897924; x=1771502724; darn=vger.kernel.org;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=qHpGzoa3aopZAtJxfvEehMpSqEZ816kpOkyer+YIROI=;
        b=P1rG4DbvXTwogHQiPHoJA46cssDjLbzEelbSKm44tAYDctVIm0jXhV81hu5vZ4k/oe
         W/mCZdUZQwFIGYU/Bjl1iY5aSzJcD/Kfk7qXZ0xQHcWntxmSn8outCZ5YFE2hI4MPtlO
         Ipa9A4UebWQ/qPnZkkQldapqb3adRk2npWpdR85KmkU1yg8RkyWkGjtlfVYVyJsWOPFi
         lGRO4wtoDavpcfffbA7PJDBQERUlkB+AbDfFUz9/KbWe9yujCxkJz5CVhPfpa6gJ4Yh8
         1CjN0Sb5ICL382FMalaEW+ukEgI8SoT8W/PJcA374bWA0we33sMw817BBezZKGp4zs9g
         5fTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770897924; x=1771502724;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=qHpGzoa3aopZAtJxfvEehMpSqEZ816kpOkyer+YIROI=;
        b=YojRYY7iZb1+ORQAWq7U51wQQ8n0YZOeZWavKRZHCf7C2ukyoYyowihB2wUUgJXm4q
         DEBI49c2595dLOsln1gvCf9A2dFJzY79d15zWMz7TA/FvVlXJ1ppZJNImMCgqN41K9of
         FAANFk+gNiIHFWyNFUMGQXzVoL8arKDwNUU8tAdRxAhKXVLvRJS5e9+m8xhMsldOklyG
         pw/tGkp5v+vKUXxp33VlmaiKO9MjvVcXjrW5+kPdzIzv8z3x6upP6Vd+h17iUzWAu0An
         U4fxP+YIVOYXp93iqtcgyNJRpzbMj+tbTx3t40G4EH4bdBXs1xnhRH7m20nZ/K4hGlL7
         /qsQ==
X-Forwarded-Encrypted: i=1; AJvYcCVcVFw5KLm99zlUziOI8ywh9IECeqWVR2FIJ5sxUF5auHcpNjqrZ1u728r3HYc7sFF3ypp7eAU=@vger.kernel.org
X-Gm-Message-State: AOJu0Yxl5FTWG3UWICgDRVQSg0h3CUrVHJ/F9hIp9p2LtGviCrxVGV+V
	ET1Ac6XVrTM7E8sPhRjDmFmfLNgB3ZaVfX9QHY0xtLY8MHj1H48xxNjyLkZSW4dA3RSDMUXwPpa
	sRJXfzF9ezhnHZ0bcz/GSm9AMZ2jeelAVmR24Z5gAh9xktr0O8mXj4UrtTM8=
X-Gm-Gg: AZuq6aKtVEwYUZsX+tjjmIM9LFzSS2RmthHlbKpW+yZBdR0P47DXUIuhdfWc+QeVCES
	Ch1miYDFZpSWaO4xiAU/g0ftOgT4kJwUy7DzyG7pq4W4hX8Llxj6l3VPqBAJnJPpJtKQwRSgxGO
	yq2AtXC8BoDTXmAyrJBCwqPfzuTuuDrBGfKFVpOM9QnX3nJwwnjareo2JiUltE1iuadSUr1qX14
	+/iK/KvlMVOpDC/07S5KMikXMI8Vd73SnFcFLGcv+yuio2hrsWXCher3sa9yLDZ0OHsIS4Zy1wl
	SjLdu7xWf3bGOdCwlSn7zYn8K+uTtQ3nbSWnRxn1sGX9IAQpZei0lUHFcjp7f+BuD4KUrexY4DF
	GLL5t62yt6c0fmaoYE0lGtKftJp6opxcSsFbKkHXxTqRCMPbntefP0mM4QWcvpKhdEKAizb+C63
	x2XpQ=
X-Received: by 2002:a05:6214:484a:b0:897:1d50:2336 with SMTP id 6a1803df08f44-89727972a48mr28203056d6.6.1770897923759;
        Thu, 12 Feb 2026 04:05:23 -0800 (PST)
X-Received: by 2002:a05:6214:484a:b0:897:1d50:2336 with SMTP id 6a1803df08f44-89727972a48mr28202586d6.6.1770897923258;
        Thu, 12 Feb 2026 04:05:23 -0800 (PST)
Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245])
        by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65b2da1aceasm1112696a12.19.2026.02.12.04.05.21
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Thu, 12 Feb 2026 04:05:22 -0800 (PST)
Message-ID: <fe57b3f0-cda1-4bde-a215-12e3aa9ea344@oss.qualcomm.com>
Date: Thu, 12 Feb 2026 13:05:20 +0100
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/4] soc: qcom: ice: Remove platform_driver support and
 expose as a pure library
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: manivannan.sadhasivam@oss.qualcomm.com,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konradybcio@kernel.org>,
        Abel Vesa <abel.vesa@linaro.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson
 <ulf.hansson@linaro.org>,
        "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org,
        Sumit Garg <sumit.garg@oss.qualcomm.com>, stable@vger.kernel.org,
        Abel Vesa <abel.vesa@oss.qualcomm.com>
References: <20260210-qcom-ice-fix-v2-0-9c1ab5d6502c@oss.qualcomm.com>
 <20260210-qcom-ice-fix-v2-1-9c1ab5d6502c@oss.qualcomm.com>
 <7d61d324-0d26-47ce-aac6-d17abdcf05cd@oss.qualcomm.com>
 <jkrkp74jgjg6d63ro4inl7ily4p6s35hmhpxeroyzue3o55tto@sgl2b4uv6ysv>
Content-Language: en-US
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
In-Reply-To: <jkrkp74jgjg6d63ro4inl7ily4p6s35hmhpxeroyzue3o55tto@sgl2b4uv6ysv>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Authority-Analysis: v=2.4 cv=cd7fb3DM c=1 sm=1 tr=0 ts=698dc204 cx=c_pps
 a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17
 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10
 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22
 a=EUspDBNiAAAA:8 a=FGFzfvMP8PCZN11w_dYA:9 a=QEXdDO2ut3YA:10
 a=1HOtulTD9v-eNWfpl4qZ:22
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDA5MCBTYWx0ZWRfXwOgEDBAJCtkm
 CnknoxmXWK8qE7NhTFakMOOK6c5DOqvKK2cfGcP0ScnNNzJDbi18MtVRabA8UuuraRj85u5etWO
 iYuLlwRCEkO/Lxjxv0wojd++tJsPNXtG4+42TsogTEyEmj+PGJN8wHX/v/p9YcVyjolXs+9FUB8
 499bXcG+2/y6gVTo1Q+b9mKuCJiIpMp+Wc6BqAKckxuwbDYHkVoNyT7BckT6DoSo477j29KUxs0
 XjQQj8TwDJ6gLEiklFBSzOxNf14ddRqUGZ+mHaEeQ4ztE+wbY7XE7qWiKuH7j6zLmA0lNvvoiGI
 133LC3DDye3c054f1Q8WUWX4D+guZWGItU8ruiwyYd93//xwcXa+Lq9LTSkumlz4o0JDaxkXS2L
 mmUy+EKmg5SETV6XOCzGULSAa6VeWEzZDETMwO3eXCf8c18C3gz9QicEAO6Vj2pI4mD5H9eTYtP
 xbaSjilu8WO9ZTlMp4A==
X-Proofpoint-GUID: jUiYPItHzrrDbIVlN33Qt5549JkBz6Bz
X-Proofpoint-ORIG-GUID: jUiYPItHzrrDbIVlN33Qt5549JkBz6Bz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49
 definitions=2026-02-12_03,2026-02-12_01,2025-10-01_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0
 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0
 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc=
 route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000
 definitions=main-2602120090
X-DKIM: signer='qualcomm.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-DKIM: signer='oss.qualcomm.com' status='pass' reason=''
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On 2/10/26 1:19 PM, Manivannan Sadhasivam wrote:
> On Tue, Feb 10, 2026 at 10:39:54AM +0100, Konrad Dybcio wrote:
>> On 2/10/26 7:56 AM, Manivannan Sadhasivam via B4 Relay wrote:
>>> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>>>
>>> The current platform driver design causes probe ordering races with
>>> consumers (UFS, eMMC) due to ICE's dependency on SCM firmware calls. If ICE
>>> probe fails (missing ICE SCM or DT registers), devm_of_qcom_ice_get() loops
>>> with -EPROBE_DEFER, leaving consumers non-functional even when ICE should
>>> be gracefully disabled. devm_of_qcom_ice_get() cannot know if the ICE
>>> driver probe has failed due to above reasons or it is waiting for the SCM
>>> driver.
>>
>> [...]
>>
>>> -static void qcom_ice_put(const struct qcom_ice *ice)
>>> +static void qcom_ice_put(struct kref *kref)
>>>  {
>>> -	struct platform_device *pdev = to_platform_device(ice->dev);
>>> -
>>> -	if (!platform_get_resource_byname(pdev, IORESOURCE_MEM, "ice"))
>>> -		platform_device_put(pdev);
>>> +	platform_device_put(to_platform_device(ice_handle->dev));
>>> +	ice_handle = NULL;
>>>  }
>>>  
>>>  static void devm_of_qcom_ice_put(struct device *dev, void *res)
>>>  {
>>> -	qcom_ice_put(*(struct qcom_ice **)res);
>>> +	const struct qcom_ice *ice = *(struct qcom_ice **)res;
>>> +	struct platform_device *pdev = to_platform_device(ice->dev);
>>> +
>>> +	if (!platform_get_resource_byname(pdev, IORESOURCE_MEM, "ice"))
>>> +		kref_put(&ice_handle->refcount, qcom_ice_put);
>>
>> IIUC this makes the refcount go down only in the legacy DT case - why?
>>
> 
> It is the other way around, no? Absence of 'ice' reg range in the consumer node
> means it is using *new* binding.

Yeah obviously you're right

I suppose in the legacy case we don't need any refcounting, since there's only
a single reference, from the storage controller device..

This assumption would break if someone had a funny idea to specify the same
"ice" range for sdcc and ufs though (via the legacy binding), but let's hope
no one does that..

Konrad


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215948-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id CEKLDG/DjWnNkhIAYBR5ng
	(envelope-from <stable+bounces-215948-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:11:27 +0000
Return-path: <stable+bounces-215948-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:11:27 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215948-hi=josie.lol@vger.kernel.org>)
	id 1vqVXa-00000005KvF-1AY5
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:11:26 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 3A6773014C34
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:11:17 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 19246356A1C;
	Thu, 12 Feb 2026 12:11:16 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="P5TzgXl4"
X-Original-To: stable@vger.kernel.org
Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012025.outbound.protection.outlook.com [52.101.43.25])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10DFA34AAF9;
	Thu, 12 Feb 2026 12:11:13 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.25
ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770898276; cv=fail; b=R5GQuGeKtt1JTZcqy0sXTWOEWDuHjyC2+ktTlgU8FzTWrZ3RcWF+ZCSpzCDX/5Px2Nmm1IOxcZ9LGMTMBWCre37Sc+ja5rQpuU4KW8/M/pRP+xy26qV8VnTTtNd4UHfAy3ZDFshfn/3uQxAqZV9JiVciQtSWEJxtGqeDSZWK2ys=
ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770898276; c=relaxed/simple;
	bh=uSe7pid2oTEXEWOJh5QJKg9wyQLUinjDq0PT8DY7wVw=;
	h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From:
	 In-Reply-To:Content-Type; b=taCMvdbkM0OQbxj1V35WNF8DUBSIe7dRXWQnScaM5degrMuydgbyC+u88RnzKEA/03Ogr9zbn4PukFQfP4CNInKBLolCTGoM+eLldec/GSTPtZM3C2fNEbEW+kKrPJ7wRCfKIFM3M81Fr34TDZR2rfyPcEkQgrcqOE9vz9CUO+0=
ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=P5TzgXl4; arc=fail smtp.client-ip=52.101.43.25
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=NlvR0/Xw41bFHXNghbG0oBkmhcbV65yJLRTigzzxR7F3Sr2rrzgAEJNke+O++QG9SPvmg4jvg+jwzxmhlcxdAIgfKlk2iCqFNKDBWK5+eTLXleHCImoPVfM1cX8pKnZiAE3Ufs1xOSsmIxbPS+4qOwZziEbUImOXvhLaf6kDH8h4kx56gYowj1Ldu5j3WzDkHwNGCtj6Klw/bpEuu0y0pOqXTUIrnph6PLC0OckobHjDCdpGfeAAh7RmglWs+10v6wKidCTpLSsX+m/A9cq90v6J4IAGR/A0SC1j170FGCdSLPZc/oELgz+2t9NWuq62pZhDT0ZJ9//1BFkXRxVPLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vlqlkO0keKNXxxE+ZaA1aw44MnHLT1iIi258zk5vpvQ=;
 b=bLULxWIDwvE8yS71lIIKLsg8Vv23LXicZtuwdJfpUWUAsm8MBTMrRzO3P06Bsvr56Tm3TBTh8s39rkczSDhKuPmO1siOsP89m1EF6Ndi9DO7Tle3sBDjH5jyuOVzpZh/D7/+B5iSaUVxi9EdpbJKO/4aBzY12dbSsQhiF/Vms3Tcr5tDMMNdudwXZB1ZnDmNg9mltHYx6WygGil9daxjbviBoBJE2Joyj/jtaJP/XKgcYYRvwADR1hYs13TAP87KHi82ULgJO+1lAgUzIETkI4MiEH03yJDnhkNP4mvC3VCB1DIayxmDMUVUjs+vFNJv01I5VHGcaJRKZMYxQh3tIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 198.47.21.195) smtp.rcpttodomain=kernel.org smtp.mailfrom=ti.com; dmarc=pass
 (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none
 (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vlqlkO0keKNXxxE+ZaA1aw44MnHLT1iIi258zk5vpvQ=;
 b=P5TzgXl4lVfomaK/M9UTrHUWbHRLHR3hcN2t0+Lm1iHQVbHt4EmRr7VPcawe3nv0/M4kEjOJaWeAXmJFEE8mXxC4vTGYDYM9rVJ35w1zPPb5DKpmGggsL7DpeUKkKgn7kZzlGD531W91khPoGeUFE3IoSQiIWoYRQfhLfC8SUcI=
Received: from BL0PR01CA0033.prod.exchangelabs.com (2603:10b6:208:71::46) by
 DM3PPFC7DCDCAD9.namprd10.prod.outlook.com (2603:10b6:f:fc00::c4b) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.12; Thu, 12 Feb
 2026 12:11:10 +0000
Received: from BN3PEPF0000B070.namprd21.prod.outlook.com
 (2603:10b6:208:71:cafe::6c) by BL0PR01CA0033.outlook.office365.com
 (2603:10b6:208:71::46) with Microsoft SMTP Server (version=TLS1_3,
 cipher=TLS_AES_256_GCM_SHA384) id 15.20.9611.11 via Frontend Transport; Thu,
 12 Feb 2026 12:11:11 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195)
 smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass
 action=none header.from=ti.com;
Received-SPF: Pass (protection.outlook.com: domain of ti.com designates
 198.47.21.195 as permitted sender) receiver=protection.outlook.com;
 client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C
Received: from flwvzet201.ext.ti.com (198.47.21.195) by
 BN3PEPF0000B070.mail.protection.outlook.com (10.167.243.75) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.9632.0 via Frontend Transport; Thu, 12 Feb 2026 12:11:09 +0000
Received: from DFLE208.ent.ti.com (10.64.6.66) by flwvzet201.ext.ti.com
 (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 12 Feb
 2026 06:11:04 -0600
Received: from DFLE210.ent.ti.com (10.64.6.68) by DFLE208.ent.ti.com
 (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 12 Feb
 2026 06:11:04 -0600
Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE210.ent.ti.com
 (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend
 Transport; Thu, 12 Feb 2026 06:11:04 -0600
Received: from [172.24.231.225] (a0507033-hp.dhcp.ti.com [172.24.231.225])
	by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 61CCAx5D3467474;
	Thu, 12 Feb 2026 06:11:00 -0600
Message-ID: <8d85409e-2f07-4e4b-831b-68c17a341a60@ti.com>
Date: Thu, 12 Feb 2026 17:40:59 +0530
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/3] PCI: tegra194: Reset BARs when running in PCIe
 endpoint mode
To: Niklas Cassel <cassel@kernel.org>, Manikanta Maddireddy
	<mmaddireddy@nvidia.com>, <kishon@kernel.org>
CC: Manivannan Sadhasivam <mani@kernel.org>, Vidya Sagar <vidyas@nvidia.com>,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>, <stable@vger.kernel.org>,
	Thierry Reding <treding@nvidia.com>, <linux-pci@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>, Thierry Reding
	<thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, "Rob
 Herring" <robh@kernel.org>, =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?=
	<kwilczynski@kernel.org>
References: <20250922140822.519796-5-cassel@kernel.org>
 <20250922140822.519796-7-cassel@kernel.org>
 <2fedf28e-83ea-4e51-b1a1-e45f0e928509@nvidia.com> <aYonDJyd_dbV0GBK@ryzen>
 <94458c39-587b-4bb4-a410-e921e5d99f10@nvidia.com> <aYsDDOZA18BBeOsd@ryzen>
 <aYsKzBjmGEi1z0am@ryzen>
Content-Language: en-US
From: Aksh Garg <a-garg7@ti.com>
In-Reply-To: <aYsKzBjmGEi1z0am@ryzen>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN3PEPF0000B070:EE_|DM3PPFC7DCDCAD9:EE_
X-MS-Office365-Filtering-Correlation-Id: 090e1ab9-7f2c-472e-6885-08de6a2fce60
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam:
	BCL:0;ARA:13230040|36860700013|82310400026|376014|7416014|1800799024;
X-Microsoft-Antispam-Message-Info:
	=?utf-8?B?T1lxaGVhQU5GdFFlTVdhVkZpeSs1NWZIaTBwQlZZRjVRcWlRVW1rUnhheG5k?=
 =?utf-8?B?bWJHRG9BeEx3MzdlbzdaTC9mWndmRThSUnowb0lSZlJWeStvZm1FK05XVCtp?=
 =?utf-8?B?UDk1QUdWQ0UzbmwvQlEwQ05jTDdxTEUxZjFVbWcyaytJeXpWUW16MlNURGV4?=
 =?utf-8?B?RFQxWmw5S2llMkV4VXlDNDByaFh2VGpMMmVZdjBvYW5vZUQySnkzenlmd1ln?=
 =?utf-8?B?aDdZQkpCN1VER3orU2hvZDRhQnRzaDNtdHRwWmppSms1V21kQnRoVEVTenVr?=
 =?utf-8?B?SS9rOStHR2lUMkNDR1ZCVldPWGRkZkJWMlBNaDk3aE1VL2ZRTVVNT2JWTU5s?=
 =?utf-8?B?Q1cxZm55Wkx0YXZjRUdOdTRsQ1N3NXgvbFVyRlpONGg3TVpBTnZxdFVtK1Zr?=
 =?utf-8?B?eFZqNW5IVHRtWTN6UHM3TG5EenZnZklQQWUreFQvQ3R5RE53bFNadzAxOGR6?=
 =?utf-8?B?VFhvazJQdVZ2YS85YjRHR3ZRZWorSWFURmdSdSt3ZngvK083VUk1cyt3OWFF?=
 =?utf-8?B?c25NeTlpMWtxYWFQS280dTdLY1l4NVlnVmhxKzNWclBMK01lRlBSbXBzQzk1?=
 =?utf-8?B?TjlLWmVDVWFGWDUxdE5sWndldW9NMjFDbGhiVVFDdEdWaE9DVFpLdXYvSlp3?=
 =?utf-8?B?WVJnT0tkcXhheUZ2Y01XYmJBaFZ5aTNLbTZXM202MTc3eUtvbVd3b1c3c1Fw?=
 =?utf-8?B?cU5RdnRvT29kVHF2ZTlmMVl5aWpmOWVOaXhOeDdlWXM5Kytic3BINXp3Nnpw?=
 =?utf-8?B?M1hpYUpzRm5OK3RkWnBWYW10MytQb2xSNUNCemppK29BMDBMZnJITkdaR0pH?=
 =?utf-8?B?VEx3czhiRitKOWl5MmI1OVNzL0tSTE1iYTYwUnFpaFJQMUNRa0tMRkI3M09V?=
 =?utf-8?B?TU5ORktXL0NmRWE5SVhqbGJVZXhKdkk1Y3pNQnFSd2xtanBFcTE5VUw2YlFJ?=
 =?utf-8?B?bFBBdDhPekg5UnRoUVpuTFZLU0ZxUjg1UnQxKzErZ1J2SXd6cmxYZC8yY052?=
 =?utf-8?B?L2RRYng2RzlpL2hraWFOYWJWazBIeXRzVFUxVVkxMm42NWV6ZjYzWk1Pa0Qy?=
 =?utf-8?B?R3BrY29IdmVuNHZNdWtjQmpHTTloY1AveDMybG5SN3VWK3R0aFNuSGV2c3Rl?=
 =?utf-8?B?MlJ3c0N1YkM3cFF1dllCU3pEeFJ6aWpwb29oMU9NWDNnMjY2dVVTaVkvNXZx?=
 =?utf-8?B?Qkx6cmYzSWRyYWRBaHUxYzZnS0M3RkFKdVZTNitRZnExVXFOdXFYMkdxRWR4?=
 =?utf-8?B?dWM3VFVmNGRSM3JvcDUyY3g3a0xidG5XRVRLNTlYQkhMMEhzaWFRV1dobTZC?=
 =?utf-8?B?T1Y1WHFFdHIydjRJTXQ0RkkzT1oyWWxmdDZJa3ArTDI2dy9waXdnVFdOR09S?=
 =?utf-8?B?TFNkZGQzV2E4S2tqLzFFcDJtc3dpcGNuT2IvcHBNV0ZBZndKdGVMQjhnVFpa?=
 =?utf-8?B?UHIvUDdZUlE4MmhnbGxrZW9xdHNrdDdmM20wTmN6d3Zic3VWR21wQlJCQzJo?=
 =?utf-8?B?RjgyR2RjMlczVEZTMEg1d1BtaFJHRzlVbDVpR3FlR2JoQU1ZdXdwL0N1aWJH?=
 =?utf-8?B?NXJJOURDVktqZmdSY0hWUFJwanl2d21MVngveDVSL0RER2V0cHB1dGdaWU11?=
 =?utf-8?B?dStGSXg5RXEzWkdVVmkyMTVBdHBLZlFBOWZMeUkwYUZWNFdQVEJRc2pMTHh5?=
 =?utf-8?B?ZU9NOXVuN3F6bjU3VXJ6SW8wL1RUNjV1YXJma1Z6V3lEN25nVlpPTmJ6SnVt?=
 =?utf-8?B?NlRTbUt0SVNSTHpsQy8vTGF6dEFFYXhyZGljM2FnajhHZVRjbUdmK0cxSWt5?=
 =?utf-8?B?Nm5wdGdkVjNTM0hYU2R3M0xPMjRPYWRSWGZvbUZRaDFOYmpSTEdkeTVLYjdY?=
 =?utf-8?B?alFZVVNUZ251SDRWM090N2I5WXlBUCtOMWpZSnU0c1FCSldaNXBTN2xnNkU3?=
 =?utf-8?B?dEkzeFRVb1pLTWowUE9oT2hlYmhJR3JZbWtGSmdZbGlWMWpIelh5NkJyYW5F?=
 =?utf-8?B?MWZFTEdLV25OSGhSY1ljTWFXdUk4Vm9MV3czb0gyOThGUmhYZ0lWYTJ1VkFv?=
 =?utf-8?B?T0ZSR1JkRThRRmF6MC9jVUhPUGZpTC9UUTM1c3NWQUFzbWpmblNKZ2o0OGM0?=
 =?utf-8?B?Q1FJVHV3K3piTUtYNXJHTlhmczhqa0twUkxlQlBYbThmOHZaN3BUNDZnUXRB?=
 =?utf-8?B?UWNkWWR1RWtnWEl5dFFHd1V2Wkpqc1dnN1kzNlV2UDF0eXozYytPWW5mRDJz?=
 =?utf-8?B?RmZWdlZ6MXd5WmpGdFE3cnVjN3JBPT0=?=
X-Forefront-Antispam-Report:
	CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	B6f2B784SvXo4khbbP4hQYWIR1C87SivlTbrsPkEk+KrQfRaeq3kHq9mNGhSnC+0GvJPFHYLWNt4P1jX+Do0C/tHUvtx9Sihx2d12ij+bxI+wpCuT2kyiyRfK/hXi5wKuGhLCtKj2N64MAFJlrVeTtXnl4LwyCBgybWREJDVrTjnFz6vxfbjEgUF9WavtTCTRTRb1SHUUSLSe+rzu6KjDgvq+GE6BWdOChyFt93pffc0IYaUYIu/ZQshl6yhWIZnvMEjY3xDEcDcrBGFoVGhXXfZA4DvoVc/se5uijVktI7L2FOKmzQ7vPtLf0ALLWSjhsJ0LHK5MWB0GcPcF5SrGiXZG95/DoJwm+1RM6kwMECytkKSAEX6wP5ejlAE7IU3xzL2w31XkQ8vTbgwwsR3FbDJmWe+HpMTlvel0wBsX+tXtMckZu3C8MA6F0gqgIdd
X-OriginatorOrg: ti.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 12:11:09.0409
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 090e1ab9-7f2c-472e-6885-08de6a2fce60
X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN3PEPF0000B070.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPFC7DCDCAD9
X-DKIM: signer='ti.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: ti.com]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

+ Kishon

On 10/02/26 16:09, Niklas Cassel wrote:
>> BAR_RESERVED already means disabled, it just assumes that an EPC driver
>> disables all BARs by default, which is the case for:
>> pci-dra7xx.c, pci-imx6.c, pci-layerscape-ep.c, pcie-artpec6.c,
>> pcie-designware-plat.c, pcie-dw-rockchip.c, pcie-qcom-ep.c, pcie-rcar-gen4.c,
>> pcie-stm32-ep.c, pcie-uniphier-ep.c.
>> (All drivers which disables all BARs by default in the init() callback using
>> dw_pcie_ep_reset_bar(). pci-epf-test will later enable all BARs that are not
>> marked as BAR_RESERVED.)
>> 
>> That leaves: pcie-keembay.c, pci-keystone.c, pcie-tegra194.c (before my patch).
>> 
>> For pcie-keembay.c, this is not a problem, because BAR0, BAR2, BAR4 are marked
>> as only_64bit, so pci-epf-test configure these BARs as 64-bit BARs, and thus
>> BAR1, BAR3, and BAR5 will get disabled implicitly.
>> 
>> For pci-keystone.c, this is the only driver that is a bit weird, it marks
>> BAR0 and BAR1 as reserved, but does not disable them in the init() callback.
>> It seems force set BAR0 as a 32-bit BAR in the init() callback.
>> 
>> Thus, for all drivers except for pci-keystone.c, BAR_RESERVED does mean
>> BAR_DISABLED. Feel free to send a patch that renames BAR_RESERVED to
>> BAR_DISABLED.
>> 
>> If you send such a patch, perhaps you also want to modify the PCI endpoint
>> core to call reset_bar() for all BARs marked as BAR_RESERVED/BAR_DISABLED,
>> instead of each EPC driver doing so in the init() callback. I think the main
>> reason why this is not done already is that thare is no reset_bar() op in
>> struct pci_epc_ops epc_ops, there is only clear_bar() which clears an BAR
>> enabled by an EPF driver. (So you would most likely also need to add a
>> .disable_bar() op in struct pci_epc_ops epc_ops.)
> 
> Aksh (on To:),
> 
> since you have a @ti.com email, perhaps you can explain how pci-keystone.c
> can pass all the pci-epf-test test cases, considering that this is the only
> driver that has BARs (BAR0 and BAR1) marked as BAR_RESERVED but do not also
> disable the BARs (using dw_pcie_ep_reset_bar()) in the init() callback.
> 
> Or, perhaps the simple answer is that pci-keystone.c does not pass all
> pci-epf-test test cases?
> 
> 
> Kind regards,
> Niklas

Hi Niklas,

I just joined the organization and have no context on why the
pci-keystone.c have BAR0 and BAR1 as reserved, without disabling the
bars using dw_pcie_ep_reset_bar() in the .init() callback. Because the
AM65 do not use any BARs for any purpose like Tegra194 does (ATU
registers or eDMA registers exposed in BAR4 for example), there would
be no issue if the BAR0 and BAR1 are overwritten.

This was introduced in the driver the time the EP support was added to
the driver by Kishon in commit 23284ad677a9 ("PCI: keystone: Add support
for PCIe EP in AM654x Platforms"), where no context is provided in the
comments or commit message why the BAR0/1 are marked as reserved in the
features. Perhaps Kishon can provide a better insight over this.

Regards,
Aksh Garg

> 



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215949-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id AOQmHZfDjWkoGhMAYBR5ng
	(envelope-from <stable+bounces-215949-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:12:07 +0000
Return-path: <stable+bounces-215949-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:12:07 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215949-hi=josie.lol@vger.kernel.org>)
	id 1vqVYF-00000005MGe-0urX
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:12:07 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 0D171305AC80
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:12:06 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 81236356A11;
	Thu, 12 Feb 2026 12:12:05 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z3+T4inr"
X-Original-To: stable@vger.kernel.org
Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EBF634AAF9
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 12:12:04 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.82.176
ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770898325; cv=pass; b=sg6Gd6CB9nL0yGhSoEsd8sF/pLC6bBCoReZ7RDT7nGEdLSMDfp2h0rq36I7bxx6f3M8akYVpncbKOFt2TN4b9QKjU2v1GZOjFt4MTYcUU+NXbqVImi34wWmQkF4KePmXqVRYiS+uFENzia2XKULKAH5mZWOCqbJ12blACPl3cug=
ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770898325; c=relaxed/simple;
	bh=hdNJuliFV+u1aeBSpWRoouGk7YA8j6s817VbVZUsNhU=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type; b=j6wC17P+Tqm/K20nfDxzuYOr+5CHk7jnbB6t54Pa2+W4VtQ9tqDlzrYIPu49WlHMFJSIbArRHjvNUShB1YNlmpJ+RYmkjxkPcgKCtiCE5fbtYSrt8i5Q8EBO7nsE1l8ooVLWHYd9aZpY64y1J+TZDe5d3goi7u+LSbEbJfDovH0=
ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z3+T4inr; arc=pass smtp.client-ip=74.125.82.176
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-2ba76e80509so318329eec.1
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 04:12:04 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1770898323; cv=none;
        d=google.com; s=arc-20240605;
        b=itfJLKv+/Q7NPN1Y1NvaMtgZCL/RAPE/TEADGRbJZyZNTD7n4CVBTHgoC9oNdX3L8C
         DqqtT01Q+MlkE/Vwi+V0S1aHPhcl82G5zfd5vHAwdNHG7HTrQ2HtpJYpvViBSNWjlRty
         obJpmjV+DbhvuFhFhn636K6qHJBUPwrCDEpEp9pH8aTaKng0fLwOvsuSf+R943nrQNqt
         FGIbDXNiHmcSYaFCcZTfWdcet+1ptVmu9yle24Fk6Sfy1fBBwBYu8DcpDTP3Xb6KJIOV
         FtXJB307KJsf2mP0MPkZ8oCUdPPSeJX0ITo574crpGiK1/rnsLDvCOZBFU2hnbtw6fMY
         p9eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=hdNJuliFV+u1aeBSpWRoouGk7YA8j6s817VbVZUsNhU=;
        fh=UcwNukraXF7UnYx4JtWuUubRk7gjiLTgVnsat+VAeEg=;
        b=SpdVYXS2/8+B/H2p9+YWg7Y5zpMSVTZF6QVjorRIBihbd0LVgp4KBsq+pwGHmCNlJf
         pY0qbLM7KfQXd74bugn2WQXSSzyh4O6EhZgCzAHuHf71Pz7LI/IsReNd8CzdJyu032Q1
         KO+vaLDMniQswhsafAqxraySSu2LtktrJtZs3lrBRXFLKswVNhGX+o06wTczrg99z5I5
         JcnAv1VDWzoAgqHp72kCWm7DMCtjcc2uErZflsGQPSp8KmcQ+eqz/a3WaA6LSUkceAZd
         NQnT/GRSd1gjBbF70qTmySTzjngdxi3c3wahzaWaZEWvnH0tGbd+K0NZXoqq/uY3z2XZ
         N1fw==;
        darn=vger.kernel.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1770898323; x=1771503123; darn=vger.kernel.org;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=hdNJuliFV+u1aeBSpWRoouGk7YA8j6s817VbVZUsNhU=;
        b=Z3+T4inr9efHMeVhgeHMznhpHHjfeni2n9ADLxyFL1PsK0gqZILhkKz0cgK3d59gnc
         bVeiHmEJRdOSuyH0O46irymHBchIx9gALw0OKXS/sg5CMsbWs42J8YoRVHMhPQ9am4mW
         cKiBFoj5MdA7wTRbIvvw4akr6ZJxswxeoPaqD/NLkqtk/PmYp/3Ki0eRv+x5Mpoe9GCo
         yW8mDzvFnjBo0SIIt6viaC/iOlbbNzUXCDsnkDisLOk56+thnZBlXxzBEB7PQakj6UYO
         66hRj7k2uU4kYMR9hjODwdCkpGiPNIGTtG4rcLS6i+JDVm5MuRm/PR4qET/BOMRgWkVT
         b6kQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770898323; x=1771503123;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from
         :to:cc:subject:date:message-id:reply-to;
        bh=hdNJuliFV+u1aeBSpWRoouGk7YA8j6s817VbVZUsNhU=;
        b=LPfzBvROKhB/QPADoCcqXjF45qy8cRLaoazkGwd/fgBI5po1tYd7nbKavYiXSoifaI
         C8dKdx1Vx0Uuz4Dj9lzclUR9UU5odmRVhW0Dp8yKIWsumHJ4dNhcbjwQaHgbx78kwg7+
         tx12KDyavNKsZCh8Kf4nO9cECyooqyBd6GtL8il76rsjhNp6nF2zE7C7dovbAjy3U++z
         MATzsqQMkZvwUl3nWf807IU1PjL7dpqa5kzerboajNOeEVop5WHaT3JWFgAR6/FnFPS/
         zkBwqS0r9WFfyDCzgU+4Pgwk8qTzc2ZOzXhFGUhAHt7MNcuXUIQd/PLQvxNzyUECKMdr
         OgvQ==
X-Forwarded-Encrypted: i=1; AJvYcCXLvo9zOABclnF7kX0TDVBBDPuRHQupme7GMc8XXS3IVoRxggauOD129h/J3HFIDjO36guCApI=@vger.kernel.org
X-Gm-Message-State: AOJu0YwbHht0ps0vcfq1cg5lKjKFfWfE3GQlN56gnZ2Lz0nE1bzdBJSV
	t+6K/8ZL6n/LBl5HyDxt18NOflw2y3l7FEQTbSToNYPPtchXf/yT6slxX4M8v/KfuMtOjGTL4Gt
	uva4VJjqqZWqlFNQBu+izWJGHzIlawNY=
X-Gm-Gg: AZuq6aIwkSlxT/vFHUy58KXLZGcHo3ft1BUmjtm9aG1xJqpl55LzllSQBM7T0YcHdyu
	uzWb+FlP1hiOd6mKToEbsfW/YzNeadLVvhBOSA8qCYKE5Uc9J5HykzHQhXH8gTbmfsxdCQkAxXT
	HogedAo9uOnraaYLIFzIwD7CerscpCDCe9fClPEMqBUKQP4aI7+EOAwwIMSIo9gh/AR26IKO/rI
	zus5jZes7J8ig7W/VcdTKbGqriCHdWj44nG+cQT9ZJRqvxIup6Hv1ivQaoPubkPrQNRKDIbtxWd
	kcjhdQ4C6Jglh64SH4D2iWXelbjV7RPKX1zPWY649MNUj5yGq4GBo4byA+/LRLDyanThzl2gnlX
	NosBgqc0BnV58P5wgA8t6HapI
X-Received: by 2002:a05:7300:cb0f:b0:2ba:6f02:2939 with SMTP id
 5a478bee46e88-2baa7f6a42bmr632842eec.1.1770898323327; Thu, 12 Feb 2026
 04:12:03 -0800 (PST)
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
References: <20260212010955.3480391-1-sashal@kernel.org> <20260212010955.3480391-23-sashal@kernel.org>
In-Reply-To: <20260212010955.3480391-23-sashal@kernel.org>
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date: Thu, 12 Feb 2026 13:11:50 +0100
X-Gm-Features: AZwV_Qjq6JjCaY13QKYBUvVQv4H6RyUaa8vYnCFiiN4Ovi19FySxcmcySYnCq5A
Message-ID: <CANiq72mi6_UrGoFs2=ch6AyKP0hhCon3epSkXCzwiGUGmfswOQ@mail.gmail.com>
Subject: Re: [PATCH AUTOSEL 6.19-6.18] rust: sync: Implement Unpin for ARef
To: Sasha Levin <sashal@kernel.org>
Cc: patches@lists.linux.dev, stable@vger.kernel.org, 
	Alice Ryhl <aliceryhl@google.com>, Daniel Almeida <daniel.almeida@collabora.com>, 
	Alexandre Courbot <acourbot@nvidia.com>, Benno Lossin <lossin@kernel.org>, 
	Boqun Feng <boqun.feng@gmail.com>, ojeda@kernel.org, shankari.ak0208@gmail.com, 
	rust-for-linux@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-DKIM: signer='gmail.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider
                             [miguel.ojeda.sandonis[at]gmail.com]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
                             EnvelopeFrom freemail headers are
                             different
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On Thu, Feb 12, 2026 at 2:10=E2=80=AFAM Sasha Levin <sashal@kernel.org> wro=
te:
>
> This is a **build fix / type system correctness fix**. While no in-tree
> code currently triggers the build failure in 6.19.y,

Hmm... If nothing is failing to build in a tree, then I don't think it
is supposed to be considered a "build fix". It may be still good to
have, e.g. for other backports and for downstream developers/vendors,
but it sounds more critical than it really is when worded like that
(same for "type system correctness fix" -- one could think it may be
referring to unsoundness).

> - The commit is still in linux-next, pending mainline merge

Wait, shouldn't all stable commits land in mainline first? (modulo exceptio=
ns)

...ah, it is actually in mainline, but the AI checked linux-next only
I guess (?).

Would it help to hint at it in the AI review instructions? Or, if you
already only ever make it review things that are picked from mainline
anyway, then telling the AI to avoid checking that?

Thanks!

Cheers,
Miguel


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215951-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id sBYzKZDFjWnNkhIAYBR5ng
	(envelope-from <stable+bounces-215951-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:20:32 +0000
Return-path: <stable+bounces-215951-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:20:32 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215951-hi=josie.lol@vger.kernel.org>)
	id 1vqVgO-00000005b42-1Qjp
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:20:32 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 677DA302C37B
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:20:31 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 966B43570B6;
	Thu, 12 Feb 2026 12:20:27 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JBcg4lQ9"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F601346779;
	Thu, 12 Feb 2026 12:20:27 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770898827; cv=none; b=sMkPRyuoKYRvq6dOXyjysrwSFEhhSjbwE19/+WLk+P4dgffkvTNwkAxJBDW0KXNMD5WeGmE2tly4cik1bBAlYR1X3AXvpygc5bVAG5Hze3YiteYkIdbSFWaHhazUTbWxHmIzcgZYKN1/HiHLbqGCVT0zK9GHUEoGY1MdeAVjWGg=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770898827; c=relaxed/simple;
	bh=yIbWErC8RoWVsumaMazbVPE1/7hFZ//8a27+WNh2ZJ4=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=CJAIzGkopFYmPjx/RFxxCV5kLpRu5zJF6sFiticpVawWdQUzFkxhsc9rRXvVO05YSlIdsBRM62oqUOil1sJjifmc5ucoY7PxyQGoKbM6u8Ky63F75fevAuinA9aoktHGIN5EE7IHaZ6sox03PQN1no0Ihd7n98Nk/LZQhwJZYWc=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JBcg4lQ9; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03E74C4CEF7;
	Thu, 12 Feb 2026 12:20:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770898827;
	bh=yIbWErC8RoWVsumaMazbVPE1/7hFZ//8a27+WNh2ZJ4=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=JBcg4lQ9GBoQaNq/TDFVUofSs0znEjq9PUwj/bwijzcNnoTtA8xCZNY3BgczOnMJT
	 cRkgFKae2iL57FpxXHKBVjK/5qoKFYD9gfKRWM9g7UhBq2BY+TytcFhGVNRK0wQKRj
	 fGaQT7ZixF3H1EcAPIRXQC40Gwz8e9GAmlQqcuZS2c7TbL8MrYuGxXxpRghoyRe7QF
	 QXCg9c8agzlInhrUZLWlWG+SQh5gGTNjFUdmpZywDp+CUvNwPhArwLTQkcKdzB/V++
	 BXq5/6gv/PXOwQgMMlGeVB1qxrCEP3ibazV97DdMEZS3FUzfmWFzYj7yIlqozPLx9K
	 SyKhFsFV9oBGQ==
Date: Thu, 12 Feb 2026 13:20:21 +0100
From: Niklas Cassel <cassel@kernel.org>
To: Aksh Garg <a-garg7@ti.com>
Cc: Manikanta Maddireddy <mmaddireddy@nvidia.com>, kishon@kernel.org,
	Manivannan Sadhasivam <mani@kernel.org>,
	Vidya Sagar <vidyas@nvidia.com>,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	stable@vger.kernel.org, Thierry Reding <treding@nvidia.com>,
	linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kwilczynski@kernel.org>
Subject: Re: [PATCH v2 2/3] PCI: tegra194: Reset BARs when running in PCIe
 endpoint mode
Message-ID: <aY3FhZUhb7RL80Fp@ryzen>
References: <20250922140822.519796-5-cassel@kernel.org>
 <20250922140822.519796-7-cassel@kernel.org>
 <2fedf28e-83ea-4e51-b1a1-e45f0e928509@nvidia.com>
 <aYonDJyd_dbV0GBK@ryzen>
 <94458c39-587b-4bb4-a410-e921e5d99f10@nvidia.com>
 <aYsDDOZA18BBeOsd@ryzen>
 <aYsKzBjmGEi1z0am@ryzen>
 <8d85409e-2f07-4e4b-831b-68c17a341a60@ti.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8d85409e-2f07-4e4b-831b-68c17a341a60@ti.com>
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: ti.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

On Thu, Feb 12, 2026 at 05:40:59PM +0530, Aksh Garg wrote:
> > since you have a @ti.com email, perhaps you can explain how pci-keystone.c
> > can pass all the pci-epf-test test cases, considering that this is the only
> > driver that has BARs (BAR0 and BAR1) marked as BAR_RESERVED but do not also
> > disable the BARs (using dw_pcie_ep_reset_bar()) in the init() callback.
> > 
> > Or, perhaps the simple answer is that pci-keystone.c does not pass all
> > pci-epf-test test cases?
> 
> Hi Niklas,
> 
> I just joined the organization and have no context on why the
> pci-keystone.c have BAR0 and BAR1 as reserved, without disabling the
> bars using dw_pcie_ep_reset_bar() in the .init() callback. Because the
> AM65 do not use any BARs for any purpose like Tegra194 does (ATU
> registers or eDMA registers exposed in BAR4 for example), there would
> be no issue if the BAR0 and BAR1 are overwritten.
> 
> This was introduced in the driver the time the EP support was added to
> the driver by Kishon in commit 23284ad677a9 ("PCI: keystone: Add support
> for PCIe EP in AM654x Platforms"), where no context is provided in the
> comments or commit message why the BAR0/1 are marked as reserved in the
> features. Perhaps Kishon can provide a better insight over this.

It is extra confusing, since the older driver from TI:
pci-dra7xx.c does have the dw_pcie_ep_reset_bar() calls in init()
(git blame shows added by Kishon), so it is a bit surprising that
the newer driver (pci-keystone.c) does not.

(And like I explained, currently all DWC drivers except keystone and
pcie-keembay.c do have the dw_pcie_ep_reset_bar() calls in init().)


Kind regards,
Niklas


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215952-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 6ImbGpbFjWnNkhIAYBR5ng
	(envelope-from <stable+bounces-215952-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:20:38 +0000
Return-path: <stable+bounces-215952-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:20:38 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215952-hi=josie.lol@vger.kernel.org>)
	id 1vqVgU-00000005bBj-14gC
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:20:38 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id B5CCB304E7E8
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:20:32 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id E313A346A1F;
	Thu, 12 Feb 2026 12:20:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ait6T45Q"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id C04752FF150;
	Thu, 12 Feb 2026 12:20:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770898829; cv=none; b=OHUTDCFA5XBiXzYj/er8LTcE7I7feopYcMbjC4wVrmCEBihhCcLaxCpNGnmgD4d8mOIkXtQjSjxu8IrTPucs4UNTYoMimzpf2BXYs/6I/3GKphIrjThhMihoTYc1k+3hDFbia5A4iGN13kgIflGvfL7Wf8cog4DNS9hjjaZVl4g=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770898829; c=relaxed/simple;
	bh=EsVPA6igSHogdWunbQbxpBLhZdkZH4NQp46IhTeVY5E=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bLOceT49qlQQazcdYcdDHD/5kYGLcblAgk2AVfr5mgSyxK1LjdbBgiWcMKJdHRsFpRRJVK5/yi2AoYGYbVIUB+Oph0T6HvlNAHFJeBdB/2vgDgdTc1f9KUefGumNms1dvmobzLBsZPJpd3nAWc/pgZIPZ6kZ11X7UcYpOJsZJCc=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ait6T45Q; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE1ABC4CEF7;
	Thu, 12 Feb 2026 12:20:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1770898829;
	bh=EsVPA6igSHogdWunbQbxpBLhZdkZH4NQp46IhTeVY5E=;
	h=From:To:Cc:Subject:Date:From;
	b=ait6T45QErAa+WKgfUF0JqhbgWNV13Ex9aLKhucWdr1kx8CaO9CyM5dkV0BS3ghAc
	 /wylcGZ7znSOW31adupJpeH21LrbETQ16oUlKM19VJVt0nBIDA4DBDCmHdCgDsjbvt
	 1F+x228TTQChgI6tvFYjTRkxzDpPQFQSJO0iT0GE=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org,
	torvalds@linux-foundation.org,
	stable@vger.kernel.org
Cc: lwn@lwn.net,
	jslaby@suse.cz,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Linux 6.12.71
Date: Thu, 12 Feb 2026 13:20:24 +0100
Message-ID: <2026021249-prepaid-scant-755b@gregkh>
X-Mailer: git-send-email 2.53.0
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='linuxfoundation.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: linuxfoundation.org]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

I'm announcing the release of the 6.12.71 kernel.

All users of the 6.12 kernel series that had issues with 6.12.69 or
6.12.70 should upgrade, as some regressions are fixed here.

The updated 6.12.y git tree can be found at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.12.y
and can be browsed at the normal kernel.org git web browser:
	https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h

------------

 Makefile                                  |    2 
 drivers/net/bareudp.c                     |    4 
 drivers/net/geneve.c                      |    4 
 drivers/net/vxlan/vxlan_core.c            |    2 
 include/net/ip_tunnels.h                  |   13 +-
 io_uring/rw.c                             |    2 
 tools/testing/vsock/control.c             |    9 -
 tools/testing/vsock/msg_zerocopy_common.c |   10 --
 tools/testing/vsock/msg_zerocopy_common.h |    1 
 tools/testing/vsock/util.c                |  142 ++++++++++++++++++++++++++++++
 tools/testing/vsock/util.h                |    7 +
 tools/testing/vsock/vsock_perf.c          |   10 ++
 tools/testing/vsock/vsock_test.c          |   51 +++-------
 tools/testing/vsock/vsock_test_zerocopy.c |    2 
 tools/testing/vsock/vsock_uring_test.c    |    2 
 15 files changed, 197 insertions(+), 64 deletions(-)

Greg Kroah-Hartman (1):
      Linux 6.12.71

Jens Axboe (1):
      io_uring/rw: recycle buffers manually for non-mshot reads

Konstantin Shkolnyy (1):
      vsock/test: verify socket options after setting them

Menglong Dong (1):
      net: tunnel: make skb_vlan_inet_prepare() return drop reasons



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215953-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id SHSdBavFjWljAxQAYBR5ng
	(envelope-from <stable+bounces-215953-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:20:59 +0000
Return-path: <stable+bounces-215953-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:20:59 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215953-hi=josie.lol@vger.kernel.org>)
	id 1vqVgo-00000005bgc-26dA
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:20:59 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 4C5233040FB0
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:20:38 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 15C5A3570C9;
	Thu, 12 Feb 2026 12:20:38 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Q9KQqNFu"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E76B9346A1F;
	Thu, 12 Feb 2026 12:20:37 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770898838; cv=none; b=Yuddlm3QhE+on2q9IDa9b6kFidWxC6iKqx5qpsVAmj1JPnaZKwZYSllyB4aI+l4hO0J6BOprhQiLRhAlPwX5/QURseRkhUOUMJkjZaNZKeT5qFv+oZT1PKqQOpcdlzEoypoKE/XLW+BZUknxK6KVfNV5xD258DoNVmhpXcILQb4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770898838; c=relaxed/simple;
	bh=m2KkbH62SiGwcjALVDFRgRDqfbnGM/aINi689so7cZ8=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=aKg2fVgE1zvwj0ynPYOQg4wltpPjjBo016FZUkyL6RbztHmXTXfXy2yHGjZS44D80COCtrvYYe++XetNgq1OC/WSBLR1QYBL070ciMl6LdBQTimAlCaEUunDqrMOmtMwOBp813kAbsJ4m8iJbC7xTieNLTSnSByGpAdaER7BE6c=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Q9KQqNFu; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E268C4CEF7;
	Thu, 12 Feb 2026 12:20:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1770898837;
	bh=m2KkbH62SiGwcjALVDFRgRDqfbnGM/aINi689so7cZ8=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=Q9KQqNFuYpgilFyEJJ/GS63gRRDEbCixifYts8m5C8daEw/xdWTodQjyZNQLWnaah
	 QNWy58XRaKM9ABBr27IhXqH9xFnrR0sB9wUi6e9CI0E3Xd+HbaQ2cq2mjUYOyinj3j
	 oChU/UtNQEnT3DEGQWcw4jIIhgXHlZ6TulHTtCPM=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org,
	torvalds@linux-foundation.org,
	stable@vger.kernel.org
Cc: lwn@lwn.net,
	jslaby@suse.cz,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: Linux 6.12.71
Date: Thu, 12 Feb 2026 13:20:25 +0100
Message-ID: <2026021249-afternoon-risk-b79d@gregkh>
X-Mailer: git-send-email 2.53.0
In-Reply-To: <2026021249-prepaid-scant-755b@gregkh>
References: <2026021249-prepaid-scant-755b@gregkh>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='linuxfoundation.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: linuxfoundation.org]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

diff --git a/Makefile b/Makefile
index 3f2328829d28..443fa095f66f 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 VERSION = 6
 PATCHLEVEL = 12
-SUBLEVEL = 70
+SUBLEVEL = 71
 EXTRAVERSION =
 NAME = Baby Opossum Posse
 
diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c
index e057526448d7..fa2dd76ba3d9 100644
--- a/drivers/net/bareudp.c
+++ b/drivers/net/bareudp.c
@@ -317,7 +317,7 @@ static int bareudp_xmit_skb(struct sk_buff *skb, struct net_device *dev,
 	__be32 saddr;
 	int err;
 
-	if (!skb_vlan_inet_prepare(skb, skb->protocol != htons(ETH_P_TEB)))
+	if (skb_vlan_inet_prepare(skb, skb->protocol != htons(ETH_P_TEB)))
 		return -EINVAL;
 
 	if (!sock)
@@ -387,7 +387,7 @@ static int bareudp6_xmit_skb(struct sk_buff *skb, struct net_device *dev,
 	__be16 sport;
 	int err;
 
-	if (!skb_vlan_inet_prepare(skb, skb->protocol != htons(ETH_P_TEB)))
+	if (skb_vlan_inet_prepare(skb, skb->protocol != htons(ETH_P_TEB)))
 		return -EINVAL;
 
 	if (!sock)
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 963fb9261f01..eea0875e4e55 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -827,7 +827,7 @@ static int geneve_xmit_skb(struct sk_buff *skb, struct net_device *dev,
 	__be16 sport;
 	int err;
 
-	if (!skb_vlan_inet_prepare(skb, inner_proto_inherit))
+	if (skb_vlan_inet_prepare(skb, inner_proto_inherit))
 		return -EINVAL;
 
 	if (!gs4)
@@ -937,7 +937,7 @@ static int geneve6_xmit_skb(struct sk_buff *skb, struct net_device *dev,
 	__be16 sport;
 	int err;
 
-	if (!skb_vlan_inet_prepare(skb, inner_proto_inherit))
+	if (skb_vlan_inet_prepare(skb, inner_proto_inherit))
 		return -EINVAL;
 
 	if (!gs6)
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index bbfa4eed1755..c78451ed06ec 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -2381,7 +2381,7 @@ void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev,
 	__be32 vni = 0;
 
 	no_eth_encap = flags & VXLAN_F_GPE && skb->protocol != htons(ETH_P_TEB);
-	if (!skb_vlan_inet_prepare(skb, no_eth_encap))
+	if (skb_vlan_inet_prepare(skb, no_eth_encap))
 		goto drop;
 
 	old_iph = ip_hdr(skb);
diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h
index 01fcf952b05d..1f92cc7fdbd2 100644
--- a/include/net/ip_tunnels.h
+++ b/include/net/ip_tunnels.h
@@ -467,11 +467,12 @@ static inline bool pskb_inet_may_pull(struct sk_buff *skb)
 
 /* Variant of pskb_inet_may_pull().
  */
-static inline bool skb_vlan_inet_prepare(struct sk_buff *skb,
-					 bool inner_proto_inherit)
+static inline enum skb_drop_reason
+skb_vlan_inet_prepare(struct sk_buff *skb, bool inner_proto_inherit)
 {
 	int nhlen = 0, maclen = inner_proto_inherit ? 0 : ETH_HLEN;
 	__be16 type = skb->protocol;
+	enum skb_drop_reason reason;
 
 	/* Essentially this is skb_protocol(skb, true)
 	 * And we get MAC len.
@@ -492,11 +493,13 @@ static inline bool skb_vlan_inet_prepare(struct sk_buff *skb,
 	/* For ETH_P_IPV6/ETH_P_IP we make sure to pull
 	 * a base network header in skb->head.
 	 */
-	if (!pskb_may_pull(skb, maclen + nhlen))
-		return false;
+	reason = pskb_may_pull_reason(skb, maclen + nhlen);
+	if (reason)
+		return reason;
 
 	skb_set_network_header(skb, maclen);
-	return true;
+
+	return SKB_NOT_DROPPED_YET;
 }
 
 static inline int ip_encap_hlen(struct ip_tunnel_encap *e)
diff --git a/io_uring/rw.c b/io_uring/rw.c
index 996cd4bec482..1a38b3578367 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -953,6 +953,8 @@ int io_read(struct io_kiocb *req, unsigned int issue_flags)
 	if (ret >= 0)
 		return kiocb_done(req, ret, issue_flags);
 
+	if (req->flags & REQ_F_BUFFERS_COMMIT)
+		io_kbuf_recycle(req, issue_flags);
 	return ret;
 }
 
diff --git a/tools/testing/vsock/control.c b/tools/testing/vsock/control.c
index d2deb4b15b94..0066e0324d35 100644
--- a/tools/testing/vsock/control.c
+++ b/tools/testing/vsock/control.c
@@ -27,6 +27,7 @@
 
 #include "timeout.h"
 #include "control.h"
+#include "util.h"
 
 static int control_fd = -1;
 
@@ -50,7 +51,6 @@ void control_init(const char *control_host,
 
 	for (ai = result; ai; ai = ai->ai_next) {
 		int fd;
-		int val = 1;
 
 		fd = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);
 		if (fd < 0)
@@ -65,11 +65,8 @@ void control_init(const char *control_host,
 			break;
 		}
 
-		if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR,
-			       &val, sizeof(val)) < 0) {
-			perror("setsockopt");
-			exit(EXIT_FAILURE);
-		}
+		setsockopt_int_check(fd, SOL_SOCKET, SO_REUSEADDR, 1,
+				     "setsockopt SO_REUSEADDR");
 
 		if (bind(fd, ai->ai_addr, ai->ai_addrlen) < 0)
 			goto next;
diff --git a/tools/testing/vsock/msg_zerocopy_common.c b/tools/testing/vsock/msg_zerocopy_common.c
index 5a4bdf7b5132..8622e5a0f8b7 100644
--- a/tools/testing/vsock/msg_zerocopy_common.c
+++ b/tools/testing/vsock/msg_zerocopy_common.c
@@ -14,16 +14,6 @@
 
 #include "msg_zerocopy_common.h"
 
-void enable_so_zerocopy(int fd)
-{
-	int val = 1;
-
-	if (setsockopt(fd, SOL_SOCKET, SO_ZEROCOPY, &val, sizeof(val))) {
-		perror("setsockopt");
-		exit(EXIT_FAILURE);
-	}
-}
-
 void vsock_recv_completion(int fd, const bool *zerocopied)
 {
 	struct sock_extended_err *serr;
diff --git a/tools/testing/vsock/msg_zerocopy_common.h b/tools/testing/vsock/msg_zerocopy_common.h
index 3763c5ccedb9..ad14139e93ca 100644
--- a/tools/testing/vsock/msg_zerocopy_common.h
+++ b/tools/testing/vsock/msg_zerocopy_common.h
@@ -12,7 +12,6 @@
 #define VSOCK_RECVERR	1
 #endif
 
-void enable_so_zerocopy(int fd);
 void vsock_recv_completion(int fd, const bool *zerocopied);
 
 #endif /* MSG_ZEROCOPY_COMMON_H */
diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
index 8a899a9fc9a9..894221a1ff31 100644
--- a/tools/testing/vsock/util.c
+++ b/tools/testing/vsock/util.c
@@ -663,3 +663,145 @@ void free_test_iovec(const struct iovec *test_iovec,
 
 	free(iovec);
 }
+
+/* Set "unsigned long long" socket option and check that it's indeed set */
+void setsockopt_ull_check(int fd, int level, int optname,
+			  unsigned long long val, char const *errmsg)
+{
+	unsigned long long chkval;
+	socklen_t chklen;
+	int err;
+
+	err = setsockopt(fd, level, optname, &val, sizeof(val));
+	if (err) {
+		fprintf(stderr, "setsockopt err: %s (%d)\n",
+			strerror(errno), errno);
+		goto fail;
+	}
+
+	chkval = ~val; /* just make storage != val */
+	chklen = sizeof(chkval);
+
+	err = getsockopt(fd, level, optname, &chkval, &chklen);
+	if (err) {
+		fprintf(stderr, "getsockopt err: %s (%d)\n",
+			strerror(errno), errno);
+		goto fail;
+	}
+
+	if (chklen != sizeof(chkval)) {
+		fprintf(stderr, "size mismatch: set %zu got %d\n", sizeof(val),
+			chklen);
+		goto fail;
+	}
+
+	if (chkval != val) {
+		fprintf(stderr, "value mismatch: set %llu got %llu\n", val,
+			chkval);
+		goto fail;
+	}
+	return;
+fail:
+	fprintf(stderr, "%s  val %llu\n", errmsg, val);
+	exit(EXIT_FAILURE);
+;
+}
+
+/* Set "int" socket option and check that it's indeed set */
+void setsockopt_int_check(int fd, int level, int optname, int val,
+			  char const *errmsg)
+{
+	int chkval;
+	socklen_t chklen;
+	int err;
+
+	err = setsockopt(fd, level, optname, &val, sizeof(val));
+	if (err) {
+		fprintf(stderr, "setsockopt err: %s (%d)\n",
+			strerror(errno), errno);
+		goto fail;
+	}
+
+	chkval = ~val; /* just make storage != val */
+	chklen = sizeof(chkval);
+
+	err = getsockopt(fd, level, optname, &chkval, &chklen);
+	if (err) {
+		fprintf(stderr, "getsockopt err: %s (%d)\n",
+			strerror(errno), errno);
+		goto fail;
+	}
+
+	if (chklen != sizeof(chkval)) {
+		fprintf(stderr, "size mismatch: set %zu got %d\n", sizeof(val),
+			chklen);
+		goto fail;
+	}
+
+	if (chkval != val) {
+		fprintf(stderr, "value mismatch: set %d got %d\n", val, chkval);
+		goto fail;
+	}
+	return;
+fail:
+	fprintf(stderr, "%s val %d\n", errmsg, val);
+	exit(EXIT_FAILURE);
+}
+
+static void mem_invert(unsigned char *mem, size_t size)
+{
+	size_t i;
+
+	for (i = 0; i < size; i++)
+		mem[i] = ~mem[i];
+}
+
+/* Set "timeval" socket option and check that it's indeed set */
+void setsockopt_timeval_check(int fd, int level, int optname,
+			      struct timeval val, char const *errmsg)
+{
+	struct timeval chkval;
+	socklen_t chklen;
+	int err;
+
+	err = setsockopt(fd, level, optname, &val, sizeof(val));
+	if (err) {
+		fprintf(stderr, "setsockopt err: %s (%d)\n",
+			strerror(errno), errno);
+		goto fail;
+	}
+
+	 /* just make storage != val */
+	chkval = val;
+	mem_invert((unsigned char *)&chkval, sizeof(chkval));
+	chklen = sizeof(chkval);
+
+	err = getsockopt(fd, level, optname, &chkval, &chklen);
+	if (err) {
+		fprintf(stderr, "getsockopt err: %s (%d)\n",
+			strerror(errno), errno);
+		goto fail;
+	}
+
+	if (chklen != sizeof(chkval)) {
+		fprintf(stderr, "size mismatch: set %zu got %d\n", sizeof(val),
+			chklen);
+		goto fail;
+	}
+
+	if (memcmp(&chkval, &val, sizeof(val)) != 0) {
+		fprintf(stderr, "value mismatch: set %ld:%ld got %ld:%ld\n",
+			val.tv_sec, val.tv_usec, chkval.tv_sec, chkval.tv_usec);
+		goto fail;
+	}
+	return;
+fail:
+	fprintf(stderr, "%s val %ld:%ld\n", errmsg, val.tv_sec, val.tv_usec);
+	exit(EXIT_FAILURE);
+}
+
+void enable_so_zerocopy_check(int fd)
+{
+	setsockopt_int_check(fd, SOL_SOCKET, SO_ZEROCOPY, 1,
+			     "setsockopt SO_ZEROCOPY");
+}
diff --git a/tools/testing/vsock/util.h b/tools/testing/vsock/util.h
index fff22d4a14c0..ba84d296d8b7 100644
--- a/tools/testing/vsock/util.h
+++ b/tools/testing/vsock/util.h
@@ -68,4 +68,11 @@ unsigned long iovec_hash_djb2(const struct iovec *iov, size_t iovnum);
 struct iovec *alloc_test_iovec(const struct iovec *test_iovec, int iovnum);
 void free_test_iovec(const struct iovec *test_iovec,
 		     struct iovec *iovec, int iovnum);
+void setsockopt_ull_check(int fd, int level, int optname,
+			  unsigned long long val, char const *errmsg);
+void setsockopt_int_check(int fd, int level, int optname, int val,
+			  char const *errmsg);
+void setsockopt_timeval_check(int fd, int level, int optname,
+			      struct timeval val, char const *errmsg);
+void enable_so_zerocopy_check(int fd);
 #endif /* UTIL_H */
diff --git a/tools/testing/vsock/vsock_perf.c b/tools/testing/vsock/vsock_perf.c
index 8e0a6c0770d3..75971ac708c9 100644
--- a/tools/testing/vsock/vsock_perf.c
+++ b/tools/testing/vsock/vsock_perf.c
@@ -251,6 +251,16 @@ static void run_receiver(int rcvlowat_bytes)
 	close(fd);
 }
 
+static void enable_so_zerocopy(int fd)
+{
+	int val = 1;
+
+	if (setsockopt(fd, SOL_SOCKET, SO_ZEROCOPY, &val, sizeof(val))) {
+		perror("setsockopt");
+		exit(EXIT_FAILURE);
+	}
+}
+
 static void run_sender(int peer_cid, unsigned long to_send_bytes)
 {
 	time_t tx_begin_ns;
diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c
index 79ef11c0ab14..8855094202d4 100644
--- a/tools/testing/vsock/vsock_test.c
+++ b/tools/testing/vsock/vsock_test.c
@@ -455,17 +455,13 @@ static void test_seqpacket_msg_bounds_server(const struct test_opts *opts)
 
 	sock_buf_size = SOCK_BUF_SIZE;
 
-	if (setsockopt(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_MAX_SIZE,
-		       &sock_buf_size, sizeof(sock_buf_size))) {
-		perror("setsockopt(SO_VM_SOCKETS_BUFFER_MAX_SIZE)");
-		exit(EXIT_FAILURE);
-	}
+	setsockopt_ull_check(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_MAX_SIZE,
+			     sock_buf_size,
+			     "setsockopt(SO_VM_SOCKETS_BUFFER_MAX_SIZE)");
 
-	if (setsockopt(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_SIZE,
-		       &sock_buf_size, sizeof(sock_buf_size))) {
-		perror("setsockopt(SO_VM_SOCKETS_BUFFER_SIZE)");
-		exit(EXIT_FAILURE);
-	}
+	setsockopt_ull_check(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_SIZE,
+			     sock_buf_size,
+			     "setsockopt(SO_VM_SOCKETS_BUFFER_SIZE)");
 
 	/* Ready to receive data. */
 	control_writeln("SRVREADY");
@@ -597,10 +593,8 @@ static void test_seqpacket_timeout_client(const struct test_opts *opts)
 	tv.tv_sec = RCVTIMEO_TIMEOUT_SEC;
 	tv.tv_usec = 0;
 
-	if (setsockopt(fd, SOL_SOCKET, SO_RCVTIMEO, (void *)&tv, sizeof(tv)) == -1) {
-		perror("setsockopt(SO_RCVTIMEO)");
-		exit(EXIT_FAILURE);
-	}
+	setsockopt_timeval_check(fd, SOL_SOCKET, SO_RCVTIMEO, tv,
+				 "setsockopt(SO_RCVTIMEO)");
 
 	read_enter_ns = current_nsec();
 
@@ -866,11 +860,8 @@ static void test_stream_poll_rcvlowat_client(const struct test_opts *opts)
 		exit(EXIT_FAILURE);
 	}
 
-	if (setsockopt(fd, SOL_SOCKET, SO_RCVLOWAT,
-		       &lowat_val, sizeof(lowat_val))) {
-		perror("setsockopt(SO_RCVLOWAT)");
-		exit(EXIT_FAILURE);
-	}
+	setsockopt_int_check(fd, SOL_SOCKET, SO_RCVLOWAT,
+			     lowat_val, "setsockopt(SO_RCVLOWAT)");
 
 	control_expectln("SRVSENT");
 
@@ -1398,11 +1389,9 @@ static void test_stream_credit_update_test(const struct test_opts *opts,
 	/* size_t can be < unsigned long long */
 	sock_buf_size = buf_size;
 
-	if (setsockopt(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_SIZE,
-		       &sock_buf_size, sizeof(sock_buf_size))) {
-		perror("setsockopt(SO_VM_SOCKETS_BUFFER_SIZE)");
-		exit(EXIT_FAILURE);
-	}
+	setsockopt_ull_check(fd, AF_VSOCK, SO_VM_SOCKETS_BUFFER_SIZE,
+			     sock_buf_size,
+			     "setsockopt(SO_VM_SOCKETS_BUFFER_SIZE)");
 
 	if (low_rx_bytes_test) {
 		/* Set new SO_RCVLOWAT here. This enables sending credit
@@ -1411,11 +1400,8 @@ static void test_stream_credit_update_test(const struct test_opts *opts,
 		 */
 		recv_buf_size = 1 + VIRTIO_VSOCK_MAX_PKT_BUF_SIZE;
 
-		if (setsockopt(fd, SOL_SOCKET, SO_RCVLOWAT,
-			       &recv_buf_size, sizeof(recv_buf_size))) {
-			perror("setsockopt(SO_RCVLOWAT)");
-			exit(EXIT_FAILURE);
-		}
+		setsockopt_int_check(fd, SOL_SOCKET, SO_RCVLOWAT,
+				     recv_buf_size, "setsockopt(SO_RCVLOWAT)");
 	}
 
 	/* Send one dummy byte here, because 'setsockopt()' above also
@@ -1457,11 +1443,8 @@ static void test_stream_credit_update_test(const struct test_opts *opts,
 		recv_buf_size++;
 
 		/* Updating SO_RCVLOWAT will send credit update. */
-		if (setsockopt(fd, SOL_SOCKET, SO_RCVLOWAT,
-			       &recv_buf_size, sizeof(recv_buf_size))) {
-			perror("setsockopt(SO_RCVLOWAT)");
-			exit(EXIT_FAILURE);
-		}
+		setsockopt_int_check(fd, SOL_SOCKET, SO_RCVLOWAT,
+				     recv_buf_size, "setsockopt(SO_RCVLOWAT)");
 	}
 
 	fds.fd = fd;
diff --git a/tools/testing/vsock/vsock_test_zerocopy.c b/tools/testing/vsock/vsock_test_zerocopy.c
index 04c376b6937f..9d9a6cb9614a 100644
--- a/tools/testing/vsock/vsock_test_zerocopy.c
+++ b/tools/testing/vsock/vsock_test_zerocopy.c
@@ -162,7 +162,7 @@ static void test_client(const struct test_opts *opts,
 	}
 
 	if (test_data->so_zerocopy)
-		enable_so_zerocopy(fd);
+		enable_so_zerocopy_check(fd);
 
 	iovec = alloc_test_iovec(test_data->vecs, test_data->vecs_cnt);
 
diff --git a/tools/testing/vsock/vsock_uring_test.c b/tools/testing/vsock/vsock_uring_test.c
index 6c3e6f70c457..5c3078969659 100644
--- a/tools/testing/vsock/vsock_uring_test.c
+++ b/tools/testing/vsock/vsock_uring_test.c
@@ -73,7 +73,7 @@ static void vsock_io_uring_client(const struct test_opts *opts,
 	}
 
 	if (msg_zerocopy)
-		enable_so_zerocopy(fd);
+		enable_so_zerocopy_check(fd);
 
 	iovec = alloc_test_iovec(test_data->vecs, test_data->vecs_cnt);
 


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215950-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id sODWJPHFjWmsSRQAYBR5ng
	(envelope-from <stable+bounces-215950-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:22:09 +0000
Return-path: <stable+bounces-215950-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:22:09 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215950-hi=josie.lol@vger.kernel.org>)
	id 1vqVhw-00000005djN-1NyY
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:22:09 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 8365531B73F8
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:18:18 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id CA4F3357727;
	Thu, 12 Feb 2026 12:18:16 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=1g4.org header.i=@1g4.org header.b="hKAu2ljP"
X-Original-To: stable@vger.kernel.org
Received: from mail-4397.protonmail.ch (mail-4397.protonmail.ch [185.70.43.97])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67C933570B6;
	Thu, 12 Feb 2026 12:18:13 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.97
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770898696; cv=none; b=obm2aYD6oxVc6KbRe5qZNtT4WKxLlByAKhPAUysa4ZV/3zN6zawX/Swzavs+JJ+3C7P5tP5GRf1tP6jr3mLG53uiNZtanKWfKQIpOP+qFD5aBQo6+ayEWXAnNyENUy77odryDuHAk25JNMh55EpMF4zMN9i9f0LvkoPGa/HZFyc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770898696; c=relaxed/simple;
	bh=Fgp+NowPbYwgCMhWMOsiWJrrq1R0CaAAYKvFqsMquo0=;
	h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=UvZFlScysJXAsSssZkyhY2KCufNAvqP6p4isi5dnb4JbRtoYCnViKMMzM3lGuTQPbh7LBZsjN3TQyaKwklQ9W7Ioml2yDEghg0mTZyd2X4VyXfMKB8OBhxG0FbAcLtg/LJonvZJyOxip4pzRblGcXWSBYkZWESeLVu7Osnyr1OA=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1g4.org; spf=pass smtp.mailfrom=1g4.org; dkim=pass (2048-bit key) header.d=1g4.org header.i=@1g4.org header.b=hKAu2ljP; arc=none smtp.client-ip=185.70.43.97
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1g4.org
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1g4.org
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1g4.org;
	s=protonmail2; t=1770898683; x=1771157883;
	bh=fZ8VB4W/hZRiQ0wYvpHYEcLhoXj9fzTdCw14ccJdOcA=;
	h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
	 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
	 Message-ID:BIMI-Selector;
	b=hKAu2ljPi03hV5sbJzr6xjS5CwhmKp2p8yeI5rCCL7p5jHKDbqni84uFyKrIvlmcL
	 ga/sJKMMhCsfkNqUh465UfImD3sqF7M9hfXi0UlBPTlbI8qI4GxQPVyKqLmIBXTSG7
	 dIFpBX5G89LBKVjoXc1B9uXO8/x3u/dfZWQExT5zcxo0ZFxocdlNcr5ibwINwPkMPs
	 8IGAQoAAceOJ0otb3paKQKsHHfZN86waoV0dV6oZENbNlgdSiMwUewEsoNLGYElxGO
	 Ff0jxrWS1b6INXSjl27aosdLJl6n2oz9OFjcAcKYc8A5M7BphrCVqam4e1/CJxLiTA
	 v6R3jTX09RANw==
Date: Thu, 12 Feb 2026 12:17:59 +0000
To: Victor Nogueira <victor@mojatatu.com>
From: Paul Moses <p@1g4.org>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>, Cong Wang <xiyou.wangcong@gmail.com>, Jiri Pirko <jiri@resnulli.us>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v5 1/1] net/sched: act_gate: snapshot parameters with RCU on replace
Message-ID: <nmLWEyw7BWgMgTdbfbxbYI1QqIF-IPdNFFsdf_T8qY8IBncn1bNnTPDe9Bz1AWfsGVt4pgj8wLzhB1DxZ1-RzuZiW2VZLamsaBS4WpjC8lw=@1g4.org>
In-Reply-To: <CA+NMeC_v8bQo2tFUYiD1faMJ0Gd9FFbqmPHCvBUD7HW_yoCx0A@mail.gmail.com>
References: <20260205150958.412278-1-p@1g4.org> <20260205150958.412278-2-p@1g4.org> <CA+NMeC_v8bQo2tFUYiD1faMJ0Gd9FFbqmPHCvBUD7HW_yoCx0A@mail.gmail.com>
Feedback-ID: 8253658:user:proton
X-Pm-Message-ID: 641b4b95da5523bcf2bb07a85c371348fcbfce84
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-DKIM: signer='1g4.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: 1g4.org]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

Proposed changes from v5...v6:
1. Agreed
   -Fixed in (net/sched: act_gate: keep gate_setup_timer helper name)

2. Agreed
   -Fixed in (net/sched: act_gate: drop redundant clockid pre-validation)

3. I was not able to reproduce it. I tended to keep it since NULL became
   representable in the conversion and it was not an expensive branch.
   -Fixed in (net/sched: act_gate: assume params exist on replace path)

4. use_old_entries is true only when REPLACE does not provide a usable new =
entry
   list (missing or empty) and we copy the previous entries into p to prese=
rve
   effective behavior. This block is skipped when new entries are provided,=
 so
   old cycletime is not reused in that case. It could be clearer but I didn=
't
   think it was worth the diff increase.

5. Yes
   -Fixed in (net/sched: act_gate: deduplicate init error cleanup labels)

6. Agreed
   -Fixed in (net/sched: act_gate: align cleanup dereference with act_vlan)

7. Agreed
   -Fixed in (net/sched: act_gate: dump params under rcu read-side lock)

Thanks,
Paul


On Friday, February 6th, 2026 at 4:36 AM, Victor Nogueira <victor@mojatatu.=
com> wrote:

> > The gate action can be replaced while the hrtimer callback or dump path=
 is
> > walking the schedule list.
> >
> > Convert the parameters to an RCU-protected snapshot and swap updates un=
der
> > tcf_lock, freeing the previous snapshot via call_rcu(). When REPLACE om=
its
> > the entry list, preserve the existing schedule so the effective state i=
s
> > unchanged.
> > [...]
> > diff --git a/net/sched/act_gate.c b/net/sched/act_gate.c
> > index c1f75f2727576..4a1a10bfe3e62 100644
> > [...]
> > -static void gate_setup_timer(struct tcf_gate *gact, u64 basetime,
> > -                            enum tk_offsets tko, s32 clockid,
> > -                            bool do_init)
> > [...]
> > +static void gate_timer_setup(struct tcf_gate *gact, s32 clockid,
> > +                            enum tk_offsets tko)
> > [...]
>=20
> I don't believe you need to change the function name here.
>=20
> > [...]
> > @@ -323,20 +370,11 @@ static int tcf_gate_init(struct net *net, struct =
nlattr *nla,
> >
> >         if (tb[TCA_GATE_CLOCKID]) {
> >                 clockid =3D nla_get_s32(tb[TCA_GATE_CLOCKID]);
> > -               switch (clockid) {
> > -               case CLOCK_REALTIME:
> > -                       tk_offset =3D TK_OFFS_REAL;
> > -                       break;
> > -               case CLOCK_MONOTONIC:
> > -                       tk_offset =3D TK_OFFS_MAX;
> > -                       break;
> > -               case CLOCK_BOOTTIME:
> > -                       tk_offset =3D TK_OFFS_BOOT;
> > -                       break;
> > -               case CLOCK_TAI:
> > -                       tk_offset =3D TK_OFFS_TAI;
> > -                       break;
> > -               default:
> > +               clockid_provided =3D true;
> > +               if (clockid !=3D CLOCK_REALTIME &&
> > +                   clockid !=3D CLOCK_MONOTONIC &&
> > +                   clockid !=3D CLOCK_BOOTTIME &&
> > +                   clockid !=3D CLOCK_TAI) {
> >                         NL_SET_ERR_MSG(extack, "Invalid 'clockid'");
> >                         return -EINVAL;
> >                 }
>=20
> This is better than what you had before, however it still
> is redundant given that you do the switch statement later
> and perform the same validation again. If there's no reason to
> keep this code, you probably can also get rid of "clockid_provided".
>=20
> > @@ -366,6 +404,37 @@ static int tcf_gate_init(struct net *net, struct n=
lattr *nla,
> > [...]
> > +
> > +       if (ret !=3D ACT_P_CREATED) {
> > +               rcu_read_lock();
> > +               old_p =3D rcu_dereference(gact->param);
> > +               if (old_p) {
>=20
> When do you believe old_p might be NULL here?
> From what I understand, you can't arrive here while
> a delete for the same action instance is happening in parallel.
> Were you able to create such scenario when testing gate?
>=20
> > [...]
> > +       if (use_old_entries) {
> > +               err =3D tcf_gate_copy_entries(p, old_p, extack);
> > +               if (err)
> > +                       goto unlock;
> > +
> > +               if (!tb[TCA_GATE_CYCLE_TIME])
> > +                       cycletime =3D old_p->tcfg_cycletime;
>=20
> Why did you keep this one as in v4?
> You don't want to reuse the old "cycletime" if the user
> specified new entries?
> Not saying you are necessarily wrong.
> Just trying to understand your logic.
>=20
> > [...]
> > -chain_put:
> > +unlock:
> >         spin_unlock_bh(&gact->tcf_lock);
> >
> >         if (goto_ch)
> >                 tcf_chain_put_by_act(goto_ch);
> > +       release_entry_list(&p->entries);
> > +       kfree(p);
>=20
> The 4 lines above look exactly like what you
> do in err_free. Can't you label them as err_free
> and remove the lines below?
>=20
> > [...]
> > +err_free:
> > +       if (goto_ch)
> > +               tcf_chain_put_by_act(goto_ch);
> > +       release_entry_list(&p->entries);
> > +       kfree(p);
> > +       goto release_idr;
> > +}
> > [...]
> >  static void tcf_gate_cleanup(struct tc_action *a)
> > @@ -458,9 +594,10 @@ static void tcf_gate_cleanup(struct tc_action *a)
> >         struct tcf_gate *gact =3D to_gate(a);
> >         struct tcf_gate_params *p;
> >
> > -       p =3D &gact->param;
> >         hrtimer_cancel(&gact->hitimer);
> > -       release_entry_list(&p->entries);
> > +       p =3D rcu_replace_pointer(gact->param, NULL, 1);
> > +       if (p)
> > +               call_rcu(&p->rcu, tcf_gate_params_free_rcu);
> >  }
>=20
> Sorry, I think I lacked precision in my last comment.
> I meant that you should've removed the rtnl requirement
> (which you did), but also use rcu_dereference_protected as
> act_vlan does. This relates to my previous comment on "old_p"
> being NULL. I don't believe you need to set this to NULL
> unless you were able to reproduce the scenario I described
> earlier.
>=20
> >  static int dumping_entry(struct sk_buff *skb,
> > @@ -512,7 +649,8 @@ static int tcf_gate_dump(struct sk_buff *skb, struc=
t tc_action *a,
> >         spin_lock_bh(&gact->tcf_lock);
> >         opt.action =3D gact->tcf_action;
> >
> > -       p =3D &gact->param;
> > +       p =3D rcu_dereference_protected(gact->param,
> > +                                     lockdep_is_held(&gact->tcf_lock))=
;
>=20
> You could've kept the rcu_read_lock approach here.
> One of the main advantages of making the params rcu
> is being able to dump without the tcf_lock.
>=20
> cheers,
> Victor
> 


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215956-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 0N1MHhHNjWl6rRMAYBR5ng
	(envelope-from <stable+bounces-215956-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:52:33 +0000
Return-path: <stable+bounces-215956-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:52:33 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215956-hi=josie.lol@vger.kernel.org>)
	id 1vqWBN-00000006YeG-1Fhh
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:52:33 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 31252306642D
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:52:32 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 70AC22F39DE;
	Thu, 12 Feb 2026 12:52:31 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mKqoZNU+"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4768B296BD2
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 12:52:30 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770900751; cv=none; b=cf9eywZQaMhQ5asa4zhOWIBJwf64jnho42VB8lgQ0IX5xIedYm2JWs+oBi+wtcCOjo51HLj7x7T4n3nmNycuNvf8xyjWBhrOuYLgNvznrn6Q+8oq0uI/pIhtoKYVy0YcJMY1a55LgSjCfF+Zdk7Rj/DWSJS0hWgSH0sYJhB+5tQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770900751; c=relaxed/simple;
	bh=kAK5Pe1R55mQWBTm0vefHxh9FAlrEg6zu6pOoLeFq8s=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=bQZkwfMbrFRql3NIkzt68sdBzjyvtkK/pb53NxIntBbGoak9I6dnr94wzuz7OMX+WgrMvmgll9PPxqjoz2vfjKb0RFq5GedP/4YiLPyms5a+t1aq0dNadbvHysDpncChhah7iakzNDoOomEbeO1afmUmvMSNt32debfIWCaMtR0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mKqoZNU+; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B878C4CEF7;
	Thu, 12 Feb 2026 12:52:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1770900750;
	bh=kAK5Pe1R55mQWBTm0vefHxh9FAlrEg6zu6pOoLeFq8s=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=mKqoZNU+P9CS4cCFguoLrCM8CB5ZsHdU+1Ms8YCg6Rx1Z2MpboIBemHF1gNuy4NZU
	 CP7pVKK01J2kAVYlksW+2fDKbnFsPiH0NN/W2+modqtUmzPlndigJ8alXDTnMSw0VG
	 JcX9G6IfXbomMOeZBMbAaRdDGA+ufTtjHvmZhziM=
Date: Thu, 12 Feb 2026 13:52:27 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: stable <stable@vger.kernel.org>
Subject: Re: 6.18-stable inclusion request
Message-ID: <2026021222-bunkhouse-surfacing-ae48@gregkh>
References: <7923dc60-dbf5-44aa-9aab-1c474cea0039@kernel.dk>
 <faa3e25a-ab8e-4589-aa4f-6f58bd93a636@kernel.dk>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <faa3e25a-ab8e-4589-aa4f-6f58bd93a636@kernel.dk>
X-DKIM: signer='linuxfoundation.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: linuxfoundation.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

On Wed, Feb 11, 2026 at 05:21:35AM -0700, Jens Axboe wrote:
> On 2/11/26 4:49 AM, Jens Axboe wrote:
> > Hi Greg/stable,
> > 
> > Can you add these two patches to the 6.18-stable queue? You can also
> > just cherry pick these in order:
> > 
> > 38aa434ab9335ce2d178b7538cdf01d60b2014c3
> > 91214661489467f8452d34edbf257488d85176e4
> > 
> > It's in the nice-to-have category just to be consistent with the
> > older/current stable release.
> 
> Oh and since 6.19 is out as well, 6.19-stable queue as well, please.

Now done, thanks!

greg k-h


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215954-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 4DoIKI7NjWnORhcAYBR5ng
	(envelope-from <stable+bounces-215954-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:54:38 +0000
Return-path: <stable+bounces-215954-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:54:38 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215954-hi=josie.lol@vger.kernel.org>)
	id 1vqWDN-00000006cNK-3s7K
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:54:38 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 44E6F30300E1
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:51:50 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 76FBF356A0D;
	Thu, 12 Feb 2026 12:51:47 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="izkPJ3y0"
X-Original-To: stable@vger.kernel.org
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F5FC191F84;
	Thu, 12 Feb 2026 12:51:45 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770900707; cv=none; b=n4Hgz5FFc36cwhc8vpxmhoXy6RBPaXYbWtArd08VX3VHIZHcsAgYOIyBzoXOWea3aODiSqGqOIeNXZ0CFEmDSWthu6f2B2qRfRLAWoWR1Qx8xyqOscCiITPKbq7PkZjHNOMG9Qe6/UdZ2cpxMBcXcOToBVFq1IryGKB0J8AfPvE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770900707; c=relaxed/simple;
	bh=PyVwbo3G2WaDgrVWH5+kW9Klx0qdUxGwxHjil+oq0k4=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=k+YDHfNRUpp68rvo6vcLCkB9+1l2DXXIc9h1YbTIcUZKGd5e+S75XIFeH6olyh6FUS9SdjXYJ1Mgm2XkFQoiMkl7eaC465HhturFJJ+JNvxEWD83sUijo0GOR9TUWaRy1A1hz35GU0/IphRiqaZNIY07N+5pHL93TudSvAtaclg=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=izkPJ3y0; arc=none smtp.client-ip=198.175.65.16
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1770900705; x=1802436705;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=PyVwbo3G2WaDgrVWH5+kW9Klx0qdUxGwxHjil+oq0k4=;
  b=izkPJ3y0Oqc3kqKDKbvedP+JzGenbpYKMUaaVIcFtrjhiA0uDuHKQjmK
   THsatzORHZ6wzOg6gBN8K0BJ+ogXASPu8Ah5NGxdNzUgc0VcPq7FIcVk/
   zHafuxlLSdOzTBVv5M2ZiyfzA7EZwBWLaRf6AYV/2vOfyl+pnXp4Kfgdn
   coWQUBrQMn3gy975daoVcqMCIZUkTqGxH0ADSQYyHZ0rvfaOi8agkiWSp
   +YjrUv/1O8pZuMQmLSP0j9XRB6juNZhNjVkesv5lPyZcYJmHPNNQCzacQ
   ysT1WF+pWradT3O3cOj1+Ky2EueL9TcI2rW3YKtpUmKseNzLS6DePS0VU
   g==;
X-CSE-ConnectionGUID: YBdTq6RdTs6aGBNb2tJBIw==
X-CSE-MsgGUID: kSe1PlgIQH+a5HWSc8JvPA==
X-IronPort-AV: E=McAfee;i="6800,10657,11699"; a="72254017"
X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; 
   d="scan'208";a="72254017"
Received: from orviesa005.jf.intel.com ([10.64.159.145])
  by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 04:51:45 -0800
X-CSE-ConnectionGUID: FA5gVCb9QZKpXm/ZR1xihA==
X-CSE-MsgGUID: bkpau9f3QgyODNgg6lR35A==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; 
   d="scan'208";a="217553313"
Received: from b580.bj.intel.com ([10.238.152.74])
  by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 04:51:41 -0800
From: Junjie Cao <junjie.cao@intel.com>
To: miriam.rachel.korenblit@intel.com,
	johannes.berg@intel.com,
	linux-wireless@vger.kernel.org,
	richardcochran@gmail.com
Cc: horms@kernel.org,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	yedidya.ben.shimol@intel.com,
	avraham.stern@intel.com,
	daniel.gabay@intel.com,
	krishnanand.prabhu@intel.com,
	luciano.coelho@intel.com,
	gregory.greenman@intel.com,
	stable@vger.kernel.org,
	Junjie Cao <junjie.cao@intel.com>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: [PATCH v2 1/2] wifi: iwlwifi: mvm: fix race condition in PTP removal
Date: Thu, 12 Feb 2026 20:50:34 +0800
Message-ID: <20260212125035.1345718-1-junjie.cao@intel.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <DM3PPF63A6024A9E1EF4081E342AF4BED81A365A@DM3PPF63A6024A9.namprd11.prod.outlook.com>
References: <DM3PPF63A6024A9E1EF4081E342AF4BED81A365A@DM3PPF63A6024A9.namprd11.prod.outlook.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='intel.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-DKIM: signer='@intel.com' status='pass' reason=''
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: intel.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

iwl_mvm_ptp_remove() calls cancel_delayed_work_sync() only after
ptp_clock_unregister() and clearing ptp_data state (ptp_clock,
ptp_clock_info, last_gp2).

This creates a race where the delayed work iwl_mvm_ptp_work() can
execute between ptp_clock_unregister() and cancel_delayed_work_sync(),
observing partially cleared PTP state.

Move cancel_delayed_work_sync() before ptp_clock_unregister() to
ensure the delayed work is fully stopped before any PTP cleanup
begins.

Fixes: 1595ecce1cf3 ("wifi: iwlwifi: mvm: add support for PTP HW clock (PHC)")
Cc: stable@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Signed-off-by: Junjie Cao <junjie.cao@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ptp.c b/drivers/net/wireless/intel/iwlwifi/mvm/ptp.c
index ad156b82eaa9..efb291ceb0e5 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/ptp.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/ptp.c
@@ -323,11 +323,11 @@ void iwl_mvm_ptp_remove(struct iwl_mvm *mvm)
 			       mvm->ptp_data.ptp_clock_info.name,
 			       ptp_clock_index(mvm->ptp_data.ptp_clock));
 
+		cancel_delayed_work_sync(&mvm->ptp_data.dwork);
 		ptp_clock_unregister(mvm->ptp_data.ptp_clock);
 		mvm->ptp_data.ptp_clock = NULL;
 		memset(&mvm->ptp_data.ptp_clock_info, 0,
 		       sizeof(mvm->ptp_data.ptp_clock_info));
 		mvm->ptp_data.last_gp2 = 0;
-		cancel_delayed_work_sync(&mvm->ptp_data.dwork);
 	}
 }
-- 
2.48.1



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215955-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id aMW1NbbNjWnvQBUAYBR5ng
	(envelope-from <stable+bounces-215955-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:55:18 +0000
Return-path: <stable+bounces-215955-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:55:19 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215955-hi=josie.lol@vger.kernel.org>)
	id 1vqWE2-00000006dc1-30ge
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:55:18 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 070A130BA476
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:52:00 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id E8637358D1A;
	Thu, 12 Feb 2026 12:51:58 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WRk/Lspw"
X-Original-To: stable@vger.kernel.org
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5F522F39DE;
	Thu, 12 Feb 2026 12:51:56 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770900718; cv=none; b=oMN4P2Ej0MDAJBmKfLBXgvM8a7DGY3TU3AITiPfVfI5ZQdZZt4WvJWnntm1R0kCnAGpsPEnAMzyuUPqmSzPgezpPgnzD4q2MI2X0rHKPnFwFQGcoEpbZZ7ln2/zQPkh4mtq0uZBokaKgDxmRHecbJwVRX8qwVL4k0mCh9ZfZW5g=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770900718; c=relaxed/simple;
	bh=5PADlxX/i4hi1VtzVuL+/fMGXH/GtoU6RGW/xNTvkbA=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=O3BcmMCpxB+0U87MEZCbefClSoQFgoF/mS1XjJJgE4XR/gRSsKI3sl0N/CFLc3Joll1LoHkQCKqAF8bbmwQEyp3x4bKslEfn2LuutNNg4vQDOazTXxJF7833Qe+BPTNK22JKnYlbJ0pDfYiGmtjAcku+XMu+HzBgayHzY9votSQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WRk/Lspw; arc=none smtp.client-ip=198.175.65.16
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1770900717; x=1802436717;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=5PADlxX/i4hi1VtzVuL+/fMGXH/GtoU6RGW/xNTvkbA=;
  b=WRk/Lspw69jjWmZeFYk3mPiJQnxRNtvbkXRVsIHml0Spp6waSpdGO6RY
   9818mhxeXGdUygfwUfAaLAF/0lQye0TxPZXRHzpizjl6RBXJAJx8X3Ro+
   vveeHR3jWE2M9+n4sD7jXjzmaJqE/6JzWDtx+8tX8UJo7xNQfik2F55Sm
   QxHgRsCrlhkWxhdMD37w0pvIbBKnNBSAaGypTj6pfGag+d8I0pDXl16lM
   bXTY4Jo1NYvGdhV9XlFgx1KYJ8XlT4yHEo87rF1oVaDbEsH0pKl0Phiyi
   IInDoVLYccZFu0oBCKXviLHEerFY/alCf8dvePZ9y/QF3vB/hVIdjDh4g
   Q==;
X-CSE-ConnectionGUID: jWV3RxjNSXq1wNGycJiFvQ==
X-CSE-MsgGUID: 0Hks4yIwQ/CIfpU5vAif8g==
X-IronPort-AV: E=McAfee;i="6800,10657,11699"; a="72254028"
X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; 
   d="scan'208";a="72254028"
Received: from orviesa005.jf.intel.com ([10.64.159.145])
  by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 04:51:51 -0800
X-CSE-ConnectionGUID: g7rFGx85TkSh4eFZ3STacg==
X-CSE-MsgGUID: TdTu/8/vS1CpLsgXK5HHPg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; 
   d="scan'208";a="217553359"
Received: from b580.bj.intel.com ([10.238.152.74])
  by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 04:51:48 -0800
From: Junjie Cao <junjie.cao@intel.com>
To: miriam.rachel.korenblit@intel.com,
	johannes.berg@intel.com,
	linux-wireless@vger.kernel.org,
	richardcochran@gmail.com
Cc: horms@kernel.org,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	yedidya.ben.shimol@intel.com,
	avraham.stern@intel.com,
	daniel.gabay@intel.com,
	krishnanand.prabhu@intel.com,
	luciano.coelho@intel.com,
	gregory.greenman@intel.com,
	stable@vger.kernel.org,
	Junjie Cao <junjie.cao@intel.com>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: [PATCH v2 2/2] wifi: iwlwifi: mld: fix race condition in PTP removal
Date: Thu, 12 Feb 2026 20:50:35 +0800
Message-ID: <20260212125035.1345718-2-junjie.cao@intel.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20260212125035.1345718-1-junjie.cao@intel.com>
References: <DM3PPF63A6024A9E1EF4081E342AF4BED81A365A@DM3PPF63A6024A9.namprd11.prod.outlook.com>
 <20260212125035.1345718-1-junjie.cao@intel.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='intel.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-DKIM: signer='@intel.com' status='pass' reason=''
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: intel.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

iwl_mld_ptp_remove() calls cancel_delayed_work_sync() only after
ptp_clock_unregister() and clearing ptp_data state (ptp_clock,
last_gp2, wrap_counter).

This creates a race where the delayed work iwl_mld_ptp_work() can
execute between ptp_clock_unregister() and cancel_delayed_work_sync(),
observing partially cleared PTP state.

Move cancel_delayed_work_sync() before ptp_clock_unregister() to
ensure the delayed work is fully stopped before any PTP cleanup
begins.

Fixes: d1e879ec600f ("wifi: iwlwifi: add iwlmld sub-driver")
Cc: stable@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Signed-off-by: Junjie Cao <junjie.cao@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mld/ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mld/ptp.c b/drivers/net/wireless/intel/iwlwifi/mld/ptp.c
index 231920425c06..b40182320801 100644
--- a/drivers/net/wireless/intel/iwlwifi/mld/ptp.c
+++ b/drivers/net/wireless/intel/iwlwifi/mld/ptp.c
@@ -319,10 +319,10 @@ void iwl_mld_ptp_remove(struct iwl_mld *mld)
 			       mld->ptp_data.ptp_clock_info.name,
 			       ptp_clock_index(mld->ptp_data.ptp_clock));
 
+		cancel_delayed_work_sync(&mld->ptp_data.dwork);
 		ptp_clock_unregister(mld->ptp_data.ptp_clock);
 		mld->ptp_data.ptp_clock = NULL;
 		mld->ptp_data.last_gp2 = 0;
 		mld->ptp_data.wrap_counter = 0;
-		cancel_delayed_work_sync(&mld->ptp_data.dwork);
 	}
 }
-- 
2.48.1



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <linux-s390+bounces-16301-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 8AFJGubNjWlTEhgAYBR5ng
	(envelope-from <linux-s390+bounces-16301-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:56:06 +0000
Return-path: <linux-s390+bounces-16301-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 12:56:06 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <linux-s390+bounces-16301-hi=josie.lol@vger.kernel.org>)
	id 1vqWEm-00000006euZ-2rsI
	for hi@josie.lol;
	Thu, 12 Feb 2026 12:56:06 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 8650B30498C9
	for <hi@josie.lol>; Thu, 12 Feb 2026 12:53:50 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id B111E35B13D;
	Thu, 12 Feb 2026 12:53:47 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="mk3xUFtY"
X-Original-To: linux-s390@vger.kernel.org
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F142F39DE;
	Thu, 12 Feb 2026 12:53:46 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770900827; cv=none; b=lSWZ4WCqz7X/AhUYaCvyvu4EiXWO6JB8ucFmkf146fX+kzPDK0nUNLkgL79lAxYE/iLnzJZPGZq6NKVJosTPS4BWzzZE2Qp5sEmJIExekMf6HJKkT1F3F772MPf7R6jV7g0mHsui1RmRgRlJVbaLFx4NgxDRggEkBw7pZ0OIwH8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770900827; c=relaxed/simple;
	bh=KcgzCkqEtNXky1CQfL+85yMQ2DEAeGtXazF+INdVsbQ=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fwC2/K1v53CZBSQ7DZcl0vA6Dc22HX+d5WBBaJ46Mujx3/sU97IHge0UvR8ptn5ejZp3gy3pdvqKa7Be+YWFe4pSidMMdzLKy84F7YyW38LhPXuI6ti0N39aMTAqWwnqpMEPm8ruHOAPFwNTc4LCI1SbZNL7WuuS/yAPKF5WOW0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=mk3xUFtY; arc=none smtp.client-ip=148.163.156.1
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com
Received: from pps.filterd (m0360083.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61C16A70235984;
	Thu, 12 Feb 2026 12:53:37 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc
	:content-transfer-encoding:date:from:message-id:mime-version
	:subject:to; s=pp1; bh=MegMCZ0LCQEfaM4xRTMfYdN9TxUm7QTj4F5eT5dAn
	Tg=; b=mk3xUFtY+OwQb46Y443azD/ZdepLg60MGhWtk5+3iaimrSVSt9WMOZZvz
	KmIZGzMVY+Y3og5a7JucOQlpWm0jrwCUkSgmbxibZpkFJf9Gcf3yWXPSLD3y+yR6
	mx3hDcBJUNIEZBhpaHbjwToS0YbENSafDEshwo3Jt+u8G5sBhxSdc3WrIL1xqvlY
	urwHoR4psVgVuXkAeUZDPviV/c6gAtEvxAd8zQE4+mTGKdREZ4U9jNNMOsn+iIwX
	DeczwT26f8K4I46BFeyE2vU9wigOg8mr7YAjAhK68dQZijwGSzv3xHBVK+vbY2xr
	EbHHXlxmZU404aJguz9Ogx4YKdRXQ==
Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])
	by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696up7bt-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 12:53:37 +0000 (GMT)
Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])
	by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 61C9E0TM012623;
	Thu, 12 Feb 2026 12:53:35 GMT
Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230])
	by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6h7kjb36-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 12:53:35 +0000
Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105])
	by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 61CCrVsv23200080
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
	Thu, 12 Feb 2026 12:53:31 GMT
Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id 92CB22004B;
	Thu, 12 Feb 2026 12:53:31 +0000 (GMT)
Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id 614FF20040;
	Thu, 12 Feb 2026 12:53:31 +0000 (GMT)
Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9])
	by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;
	Thu, 12 Feb 2026 12:53:31 +0000 (GMT)
From: Thomas Richter <tmricht@linux.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-perf-users@vger.kernel.org, acme@kernel.org, namhyung@kernel.org,
        james.clark@linaro.org, irogers@google.com
Cc: agordeev@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com,
        hca@linux.ibm.com, japo@linux.ibm.com,
        Thomas Richter <tmricht@linux.ibm.com>
Subject: [PATCH linux-next] perf parse-events: Fix big-endian 'overwrite' by writing correct union member
Date: Thu, 12 Feb 2026 13:53:15 +0100
Message-ID: <20260212125315.777356-1-tmricht@linux.ibm.com>
X-Mailer: git-send-email 2.51.0
Precedence: bulk
X-Mailing-List: linux-s390@vger.kernel.org
List-Id: <linux-s390.vger.kernel.org>
List-Subscribe: <mailto:linux-s390+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-s390+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-TM-AS-GCONF: 00
X-Proofpoint-Reinject: loops=2 maxloops=12
X-Authority-Analysis: v=2.4 cv=KZnfcAYD c=1 sm=1 tr=0 ts=698dcd51 cx=c_pps
 a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17
 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22
 a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=KKAkSRfTAAAA:8 a=1XWaLZrsAAAA:8
 a=UHkrvoB-SimJn0k8XG4A:9 a=cvBusfyB2V15izCimMoJ:22
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDA5NiBTYWx0ZWRfX7gCRaEN95BrE
 Oy04jluEwg/gdUBSI6BgLway4UNR4xNFWCr2Aae23waT60r4/+wEVpUklKABqqdJmaUON3WjIB+
 EHcbOxYtZcsnKruLczXaQ+TT0GIlrUoIGBHZRTV/xMFnE8atQ7GszeiHcJgrQ5RW7eL7/RCFWr0
 6fRVKr+GtMkHCbSJ5BeY0LRAOliItyjMjFqpHJi32e6aaQw00lZjLfZ/YWGDXHcZmDo6Ar6Uium
 A12AxHPMPdTi2N9SLx/T6g3WycUM08QO4qM/kDK9XeOv9sPb5j7QPSv7vPlEhbbbYsRA6baM9gj
 +gRGeIyUy2mSNAHffNo1jhuCzcCimyGVzDKalXnfPClXnH4QfZHDzHCMOTwYGG0jaTvmSAzVe0r
 HSpbzz6tthqAhdGJLdjmcFFQtehwya6oSq6W4xlxFBkylZd8C7g6zefVAOgKgbkvjeSu8zybtKf
 zQwdd9dHol2MO6rffww==
X-Proofpoint-ORIG-GUID: HEEoFUZaDDjFBv50EVXNyMNmC2dCrxYn
X-Proofpoint-GUID: Z79QE5XREdSB25nkZ2zdDh1mcnHOXbJz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49
 definitions=2026-02-12_03,2026-02-12_02,2025-10-01_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 spamscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0
 clxscore=1015 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0
 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0
 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120096
X-DKIM: signer='ibm.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 5

The "Read backward ring buffer" test crashes on big-endian (e.g. s390x)
due to a NULL dereference when the backward mmap path isn't enabled.

Reproducer:
  # ./perf test -F 'Read backward ring buffer'
  Segmentation fault (core dumped)
  # uname -m
  s390x
  #

Root cause:
get_config_terms() stores into evsel_config_term::val.val (u64) while later
code reads boolean fields such as evsel_config_term::val.overwrite.
On big-endian the 1-byte boolean is left-aligned, so writing
evsel_config_term::val.val = 1 is read back as
evsel_config_term::val.overwrite = 0,
leaving backward mmap disabled and a NULL map being used.

Store values in the union member that matches the term type, e.g.:
  /* for OVERWRITE */
  new_term->val.overwrite = 1;  /* not new_term->val.val = 1 */
to fix this.

Impact:
Enables backward mmap on big-endian and prevents the crash.
No change on little-endian.

Output after:
 # ./perf test -Fv 44
 --- start ---
 Using CPUID IBM,9175,705,ME1,3.8,002f
 mmap size 1052672B
 mmap size 8192B
 ---- end ----
 44: Read backward ring buffer                         : Ok
 #

Fixes: 159ca97cd97c ("perf parse-events: Refactor get_config_terms() to remove macros")
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Reviewed-by: Jan Polensky <japo@linux.ibm.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Ian Rogers <irogers@google.com>
---
 tools/perf/util/parse-events.c | 49 +++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index d4647ded340f..12fe5392c832 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -1250,7 +1250,54 @@ static int get_config_terms(const struct parse_events_terms *head_config,
 			}
 			new_term->free_str = true;
 		} else {
-			new_term->val.val = val;
+			switch (new_type) {
+			case EVSEL__CONFIG_TERM_PERIOD:
+				new_term->val.period = val;
+				break;
+			case EVSEL__CONFIG_TERM_FREQ:
+				new_term->val.freq = val;
+				break;
+			case EVSEL__CONFIG_TERM_TIME:
+				new_term->val.time = val;
+				break;
+			case EVSEL__CONFIG_TERM_STACK_USER:
+				new_term->val.stack_user = val;
+				break;
+			case EVSEL__CONFIG_TERM_INHERIT:
+				new_term->val.inherit = val;
+				break;
+			case EVSEL__CONFIG_TERM_OVERWRITE:
+				new_term->val.overwrite = val;
+				break;
+			case EVSEL__CONFIG_TERM_MAX_STACK:
+				new_term->val.max_stack = val;
+				break;
+			case EVSEL__CONFIG_TERM_MAX_EVENTS:
+				new_term->val.max_events = val;
+				break;
+			case EVSEL__CONFIG_TERM_PERCORE:
+				new_term->val.percore = val;
+				break;
+			case EVSEL__CONFIG_TERM_AUX_OUTPUT:
+				new_term->val.aux_output = val;
+				break;
+			case EVSEL__CONFIG_TERM_AUX_SAMPLE_SIZE:
+				new_term->val.aux_sample_size = val;
+				break;
+			case EVSEL__CONFIG_TERM_CALLGRAPH:
+			case EVSEL__CONFIG_TERM_DRV_CFG:
+			case EVSEL__CONFIG_TERM_BRANCH:
+			case EVSEL__CONFIG_TERM_AUX_ACTION:
+			case EVSEL__CONFIG_TERM_USR_CHG_CONFIG:
+			case EVSEL__CONFIG_TERM_USR_CHG_CONFIG1:
+			case EVSEL__CONFIG_TERM_USR_CHG_CONFIG2:
+			case EVSEL__CONFIG_TERM_USR_CHG_CONFIG3:
+			case EVSEL__CONFIG_TERM_USR_CHG_CONFIG4:
+			case EVSEL__CONFIG_TERM_RATIO_TO_PREV:
+			default:
+				new_term->val.val = val;
+				break;
+			}
 		}
 	}
 	return 0;
-- 
2.53.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215957-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id MPNOLsbPjWljdRgAYBR5ng
	(envelope-from <stable+bounces-215957-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:04:06 +0000
Return-path: <stable+bounces-215957-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 13:04:06 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215957-hi=josie.lol@vger.kernel.org>)
	id 1vqWMY-00000006tl6-1mzb
	for hi@josie.lol;
	Thu, 12 Feb 2026 13:04:06 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 1B264304F35F
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:04:04 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id A6A87359F9E;
	Thu, 12 Feb 2026 13:04:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="i3LvwHf6"
X-Original-To: stable@vger.kernel.org
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D2E9356A0D;
	Thu, 12 Feb 2026 13:04:01 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.148.174
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770901442; cv=none; b=YR6C0Kh9YoBf4t69U6YP7dwOziGYG1dBcpAp2BZktygDr7+yJ/6/s6JLFSl68wwX9F0xM0G79Ejw+YmA5cBZpdld2oC43nTwLJfbs6BjJ1YYijI7DcHSPII2vgiMtLdh1d3u3PZgmmRPETVz0yWIMqnW86NHV9XJjOFUQwztPec=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770901442; c=relaxed/simple;
	bh=EfLS4ZM7f5cRpk+TAS+xqWJ3cF3htCYIH5HHvc3mNg8=;
	h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=KlFqp4uyD48gg4QaMOL+jEiCq7N7auKltNWciM67BDSJqacaWspk54oo1dj00jC86Ep/kFGzhiEo/mPGuHQNsJqOdx6AYhYb9vtsrFcRQPZ1F3F9oNVFmGmL7sBd1YYHRf2WYgerjKRaS/nmEAROJzj7vT/LgGlR5tVL6db7c6g=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=i3LvwHf6; arc=none smtp.client-ip=67.231.148.174
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
	by mx0a-0016f401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61BLNov01274001;
	Thu, 12 Feb 2026 05:03:47 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=
	cc:content-transfer-encoding:content-type:date:from:message-id
	:mime-version:subject:to; s=pfpt0220; bh=3woJmYNsewlYdtCBXzd3+ry
	fIzxYexwDJcAg74rOJn8=; b=i3LvwHf6wYw6jl5b6Yde8kQAwhKEnnlgOcqAMIY
	DEoUr1AeQvGnC/EO+4PbGC6vEQOuQhcqYPrBg6fds8Nv11fXBKTwadJ49Eqox4Q5
	KVZ1qwV6X+05kk2lbDX6xZlzCfp5rwMQZSjOsNvs6st53hP7MH+ZORwKKc4Icc/a
	5Kra8TTjAWtbN4zCEbk9lL+gq+zaFEsC22JnTUz6N6enx152YH2fZPy5jZgAe7Hn
	wCAr/WVPhM2h3hXI+L0HNI2eUx6XqoaoaXQeAQQ7543qpHXmxDtELAgMkyPDpVel
	h4ER4f0adJD19qjQ7wxiI6EuzYbH4X7/PFMNDkaLCSsYBrg==
Received: from dc6wp-exch02.marvell.com ([4.21.29.225])
	by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 4c89g1nrk1-2
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 05:03:47 -0800 (PST)
Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by
 DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.2.1544.25; Thu, 12 Feb 2026 05:04:03 -0800
Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com
 (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.25 via Frontend
 Transport; Thu, 12 Feb 2026 05:04:03 -0800
Received: from localhost.localdomain (unknown [10.28.36.175])
	by maili.marvell.com (Postfix) with ESMTP id B563D3F703F;
	Thu, 12 Feb 2026 05:03:41 -0800 (PST)
From: Srujana Challa <schalla@marvell.com>
To: <netdev@vger.kernel.org>, <virtualization@lists.linux.dev>
CC: <pabeni@redhat.com>, <mst@redhat.com>, <jasowang@redhat.com>,
        <xuanzhuo@linux.alibaba.com>, <eperezma@redhat.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <ndabilpuram@marvell.com>, <kshankar@marvell.com>,
        <schalla@marvell.com>, <stable@vger.kernel.org>
Subject: [PATCH v3,net] virtio_net: Improve RSS key size validation
Date: Thu, 12 Feb 2026 18:33:40 +0530
Message-ID: <20260212130340.3540415-1-schalla@marvell.com>
X-Mailer: git-send-email 2.25.1
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Authority-Analysis: v=2.4 cv=ELgLElZC c=1 sm=1 tr=0 ts=698dcfb3 cx=c_pps
 a=gIfcoYsirJbf48DBMSPrZA==:117 a=gIfcoYsirJbf48DBMSPrZA==:17
 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22
 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=M5GUcnROAAAA:8
 a=l6LeGXZaLw7GYeYAWxUA:9 a=OBjm3rFKGHvpk9ecZwUJ:22
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDA5NyBTYWx0ZWRfX0WbwK2tyd1wJ
 /Xuk35zeYc1CIyV+/Eh4bE8ceuV7hKDGM7jQZVO1PK5zhEqewcsvMIIzjJEOQEYQt94O0l+Rutg
 j+U+v4bqH8XQwYaq1bstvRK/8LeTRZmtVtvfWYzM6pWBL+lK8iRySiGui9IWunEMwKPBsBvC9sb
 a26RZJIetcUznrDKAvxvioZJG+dALKX4nuD5aRIdFQYzmWiFwrd6tp4Sow3DTbEXKUlarAkFV9j
 gRO4nETAAnKuSdQu/t1uKXwy+yKwg0gXuaK/xMuirqlOmT1rL92nbkf7EsPqZ7wXqKgalMV9/0c
 tTeZLEfiAxzGMiMc8PCL0Xab+/i9uFBeljEp+1VPBlBrsrCgfB1ICNbq/usgpDgmY/c/uNNSRIS
 8f4mRRxKZAFM0AcAN8+swOwMuXafA8+rtJhw8Gy6JrzDy7uk+vhVUBt2qHG8NOpRJ2tovAmplmy
 DmwsXN0nFk+BIPqqvuA==
X-Proofpoint-GUID: 076p7Qdxk9CoPxQLKMlhn7xdMoetfR5V
X-Proofpoint-ORIG-GUID: 076p7Qdxk9CoPxQLKMlhn7xdMoetfR5V
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49
 definitions=2026-02-12_03,2026-02-12_02,2025-10-01_01
X-DKIM: signer='marvell.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

Replace hardcoded RSS max key size limit with a type based definition.
Add validation for RSS key size against spec minimum (40 bytes). When
validation fails, gracefully disable RSS features and continue
initialization rather than failing completely.

Cc: stable@vger.kernel.org
Fixes: 3f7d9c1964fc ("virtio_net: Add hash_key_length check")
Signed-off-by: Srujana Challa <schalla@marvell.com>

v3:
- Moved RSS key validation checks to virtnet_validate.
- Add fixes: tag and CC -stable
---
 drivers/net/virtio_net.c | 29 +++++++++++++++++++++--------
 1 file changed, 21 insertions(+), 8 deletions(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index db88dcaefb20..e61cea50dcab 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -381,7 +381,9 @@ struct receive_queue {
 	struct xdp_buff **xsk_buffs;
 };
 
-#define VIRTIO_NET_RSS_MAX_KEY_SIZE     40
+#define VIRTIO_NET_RSS_MAX_KEY_SIZE \
+	(type_max(((struct virtio_net_config *)0)->rss_max_key_size) + 1)
+#define VIRTIO_NET_RSS_MIN_KEY_SIZE 40
 
 /* Control VQ buffers: protected by the rtnl lock */
 struct control_buf {
@@ -6627,6 +6629,24 @@ static int virtnet_validate(struct virtio_device *vdev)
 		__virtio_clear_bit(vdev, VIRTIO_NET_F_STANDBY);
 	}
 
+	if (virtio_has_feature(vdev, VIRTIO_NET_F_RSS) ||
+	    virtio_has_feature(vdev, VIRTIO_NET_F_HASH_REPORT)) {
+		u8 key_sz = virtio_cread8(vdev,
+					  offsetof(struct virtio_net_config,
+						   rss_max_key_size));
+		/* Spec requires at least 40 bytes */
+		if (key_sz < VIRTIO_NET_RSS_MIN_KEY_SIZE) {
+			dev_warn(&vdev->dev,
+				 "rss_max_key_size=%u is less than spec minimum %u, disabling RSS\n",
+				 key_sz, VIRTIO_NET_RSS_MIN_KEY_SIZE);
+			if (virtio_has_feature(vdev, VIRTIO_NET_F_RSS))
+				__virtio_clear_bit(vdev, VIRTIO_NET_F_RSS);
+			if (virtio_has_feature(vdev, VIRTIO_NET_F_HASH_REPORT))
+				__virtio_clear_bit(vdev,
+						   VIRTIO_NET_F_HASH_REPORT);
+		}
+	}
+
 	return 0;
 }
 
@@ -6839,13 +6859,6 @@ static int virtnet_probe(struct virtio_device *vdev)
 	if (vi->has_rss || vi->has_rss_hash_report) {
 		vi->rss_key_size =
 			virtio_cread8(vdev, offsetof(struct virtio_net_config, rss_max_key_size));
-		if (vi->rss_key_size > VIRTIO_NET_RSS_MAX_KEY_SIZE) {
-			dev_err(&vdev->dev, "rss_max_key_size=%u exceeds the limit %u.\n",
-				vi->rss_key_size, VIRTIO_NET_RSS_MAX_KEY_SIZE);
-			err = -EINVAL;
-			goto free;
-		}
-
 		vi->rss_hash_types_supported =
 		    virtio_cread32(vdev, offsetof(struct virtio_net_config, supported_hash_types));
 		vi->rss_hash_types_supported &=
-- 
2.25.1



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215958-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id KHViHpTQjWmH7xYAYBR5ng
	(envelope-from <stable+bounces-215958-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:07:32 +0000
Return-path: <stable+bounces-215958-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 13:07:32 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215958-hi=josie.lol@vger.kernel.org>)
	id 1vqWPr-00000006zy1-3XQR
	for hi@josie.lol;
	Thu, 12 Feb 2026 13:07:32 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id 463EB3002D30
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:07:28 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 417C535B142;
	Thu, 12 Feb 2026 13:07:27 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KAU/a6zE"
X-Original-To: stable@vger.kernel.org
Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011037.outbound.protection.outlook.com [40.93.194.37])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 654BA11CAF;
	Thu, 12 Feb 2026 13:07:25 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.37
ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770901647; cv=fail; b=O2CVgKvXHdpejYLKX8U3rPhj0MuKPsGpOur5o7SLwz3HCo8xs1ht9wvzCUJLYvT6+kBfO7hKf6FyrQXNd62PJ0hHeUhx8Y9b0Zj/B8kvVOA5bJHna74wiJbvXWi189cJsrE5zdtS5aqUAB9DhrNEV/QE1DX/XxiFrgOimgVrry0=
ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770901647; c=relaxed/simple;
	bh=hHUogyhFWkGvPItZU80hwClMYohHxb9Y992MTcP9gnM=;
	h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=T+g5NHJjyQuG9VGThmw5H06Pr2Asj6/QVJrBNrxrjT2Lzr0Du49MXw8Iiwrpd48VZ9g/Lj+uAGQkzUj6Ol6Wly1/Do1F2ZvR4X5fmDMq0WCwVhwpL9y50f0PqfifKtxpc3WfgcG5PaObBfz44PVFB4bAlWDgx/F7MqnoanX+GAc=
ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=KAU/a6zE; arc=fail smtp.client-ip=40.93.194.37
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=fixqFJfWHONfgzUkdm7+UeEmlIJAPDyX19uEa+KZsXCmDpQHSspYLzSuw/gOpgLx+WlNP82B70Rl2dJ6BHB/Jseqkqsv1oYn9+eqR60ZQkg1cZHDyktbW0lfwXY3wrutgBHsjl3YrZe2Ip2cCX34wClk+/iU2HeJb2wfQQspRmzBlaNDgPHc/CYfeTOdJlNJwIE+bHAaFNA5+dvQRL/htieCoGaivSLhLvdAs3/TgNLQ2u10x5t1hWE699WGMLrTblCPYqDUIvUkxZgLADwLOJBbUH9fLJ38lTVyQpgOAsG0MyTXLPA0ZhKwqKjfvDApgDvAP+kb6rFZHntcRez3Ig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VXkF2WqplBMK/patOjYN9fQbVnhTWC1bXr/eBrDN1Qo=;
 b=EN/hb/aTBsDK3UOw3gkdPP3rVCRoKfb+SQ+PtjMcndxPs5UdexjWVJwXJMDlXw9Th3IzIGQwker8xVaLhn3IEmnWcuUxWYp8T9j5CpuAy81zOfyXnLDBUIOMotTILHpM+6mbrQSJImZEyfr69zGzLHB4uq9YzIWQ+0N5yznE48bJi4sVWTQZ3zRcdlF8SKMmlpxY1HQ3mUArEjD3TnU3ypQKux5uaQ6O6W2Feyba0MW7YAOAJhj4Uz1WU8EPPI/e7AG4NO6P9bDHPzb5GGIPo69g6DHZPGEu7HMfNxAoovKmqNQcX1tkhh/zQyVcltkDWuldd59H/DoJqeRmR9+10g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 198.47.23.195) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=ti.com;
 dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com;
 dkim=none (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VXkF2WqplBMK/patOjYN9fQbVnhTWC1bXr/eBrDN1Qo=;
 b=KAU/a6zER9vUIeYWs8S40b+d4NY4lch7/71nhuCvFl7mYuezK/DQIya8TVYDIUeKmgDRGdjrYo50jkZ4YjOR816fCtey37WT039/Voa+l6r/UTDAxBBaLxvbxqR1nkfe13Ly4u3b1ngGJKpYW1su2tflxBiBb/G7aBAneyz2IsI=
Received: from BYAPR02CA0024.namprd02.prod.outlook.com (2603:10b6:a02:ee::37)
 by CY8PR10MB6441.namprd10.prod.outlook.com (2603:10b6:930:63::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Thu, 12 Feb
 2026 13:07:22 +0000
Received: from SJ1PEPF000026C8.namprd04.prod.outlook.com
 (2603:10b6:a02:ee:cafe::42) by BYAPR02CA0024.outlook.office365.com
 (2603:10b6:a02:ee::37) with Microsoft SMTP Server (version=TLS1_3,
 cipher=TLS_AES_256_GCM_SHA384) id 15.20.9611.11 via Frontend Transport; Thu,
 12 Feb 2026 13:07:22 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195)
 smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass
 action=none header.from=ti.com;
Received-SPF: Pass (protection.outlook.com: domain of ti.com designates
 198.47.23.195 as permitted sender) receiver=protection.outlook.com;
 client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C
Received: from lewvzet201.ext.ti.com (198.47.23.195) by
 SJ1PEPF000026C8.mail.protection.outlook.com (10.167.244.105) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.9611.8 via Frontend Transport; Thu, 12 Feb 2026 13:07:21 +0000
Received: from DLEE210.ent.ti.com (157.170.170.112) by lewvzet201.ext.ti.com
 (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 12 Feb
 2026 07:07:21 -0600
Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE210.ent.ti.com
 (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 12 Feb
 2026 07:07:21 -0600
Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE209.ent.ti.com
 (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend
 Transport; Thu, 12 Feb 2026 07:07:21 -0600
Received: from toolbox.dhcp.ti.com (uda0492258.dhcp.ti.com [10.24.73.74])
	by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 61CD7HVE3538554;
	Thu, 12 Feb 2026 07:07:17 -0600
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <jm@ti.com>
CC: <stable@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<srk@ti.com>, <s-vadapalli@ti.com>
Subject: [PATCH] arm64: dts: ti: k3-am62a7-sk: Fix pinmux for pin M19 used by sdhci1
Date: Thu, 12 Feb 2026 18:36:41 +0530
Message-ID: <20260212130843.1054100-1-s-vadapalli@ti.com>
X-Mailer: git-send-email 2.51.1
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C8:EE_|CY8PR10MB6441:EE_
X-MS-Office365-Filtering-Correlation-Id: 4bb7b784-b2d1-4fde-876e-08de6a37a8bb
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam:
	BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013;
X-Microsoft-Antispam-Message-Info:
	=?us-ascii?Q?+U6T/0o11PN5dDarsgBMeCYBB9ki864w/9xyP5tv5iNoJUDEa09AeJcLzZtC?=
 =?us-ascii?Q?PHSfE4SblkT9DC91udGEEp382MPtg2kNsNppb7aJzM1f1flsms6lhnWEIL0k?=
 =?us-ascii?Q?jlQsn6dUnXm1KQ0c64bvOoXFmLObPSs+0MvRxZmV6xhBZQ9d3LHErJ+obPFW?=
 =?us-ascii?Q?1sFHFS4mOSJqJy29o3BeapQAmZIYaWv52ixRoD/XNgms11TchrZmiZKnGkJ1?=
 =?us-ascii?Q?J42bFZG1pCNWNuRF2oaQnH6fFjkGgxNGIsdP2CAuVJ35d2thRfbbz1l5CHU4?=
 =?us-ascii?Q?/kFvhsSK4FtCuwOxQ/K6zmUz1VQa2Q/QJSSkpnyKfAY8tUTrRmbZfYTd43bK?=
 =?us-ascii?Q?aLxgDIA6PFA64G6dg6US7+oDQXv7OQRtefSzF9rPV0CEbVqNkzFP+eS3yvJ1?=
 =?us-ascii?Q?mfIfdbWKYQmQEh9QVVFIuiQv2ZAV26loCWEEFD2YPONqNF/SrbGSDKiKG6PP?=
 =?us-ascii?Q?nGcNlqOWR4CGW9WjACVEXbekR+FJ74qFcedQx/rda+dhelod5iPGgfVqAUug?=
 =?us-ascii?Q?McxruEpIbw1BnrPWPVzV0AkVtoNMwS7MvGO8GR1zdM0SAWb/+pXq40/IuenO?=
 =?us-ascii?Q?OwrjqffwDtbNYeoHYWI3dMWDenusnPXS8AtpPdrGyZIKAVlK6W/abWef3ZbR?=
 =?us-ascii?Q?dThN11/4jWMYSWS/yOeV8rY+RMuvAVz68kyVnkMDPmU/zDrPfvUycWBNTYv3?=
 =?us-ascii?Q?5EPJWXvEfIptlYDCW0oNYcB0ODXur4nuND501kWB6eKDVKdcjbKiLo3hKbBI?=
 =?us-ascii?Q?Lmh7i2LMcU4ftkxOw6rgHxY+RHusyKekdOUOgp6BpenKpUMPsNMmwWbQ7+jb?=
 =?us-ascii?Q?ZmBbRivFmaN9XWn5b7l0oKnTofiYc2QHDv2sS2BahBiBBN+oztJmadzx+/hy?=
 =?us-ascii?Q?2V5xLgpGgGp7YaW/g1gVT9+9I5Mn1G7iduRcGlP2l4+hc2c3GH34XD8f05pU?=
 =?us-ascii?Q?vgkmKazzBqFVn1X4+ZdjX2M5RmXrVlCM3UayHc95YitXaOjQ9RsIbw5T5+wN?=
 =?us-ascii?Q?wO5xJ7zBuFWCYey9xsny6vZWdIjhs0B/hh7ViWIrD8TSbq3DA1eAVJo6I4B3?=
 =?us-ascii?Q?I3RXchP+6BxM0mWm0HavMgVHBY42xxSERRKeBPZ8GPqfeBox+nqbAG7Fvsw7?=
 =?us-ascii?Q?bxnB2t1inzBQ+8WbHs7P/QwQbxKxjdAb3HrFnaybUxn+eSQosEvAkzYBW7qZ?=
 =?us-ascii?Q?GtGbGMDcrIRKiIAkC0Lf/DxhtkZJ+aCN3ThN/Mmzl/cXycI4oQDmFUoBtlX3?=
 =?us-ascii?Q?JmBWVSA2eKIk4DkyjBnXxr8TV1DKEMtq8B5rbRpTeEMP5KARmioBwmTiMnTx?=
 =?us-ascii?Q?KsFtYn18oe2LHX5v1qiNVzRXYLeT1ExY/BTY7vQs6RrQBoYjl1h+mE1VLfd+?=
 =?us-ascii?Q?IE6e6I+NvpJ1zjr75RH31sZ6MaFDRjLlLtKys6Sml32jncOZ3Np+MY04t4gO?=
 =?us-ascii?Q?N1nH2qD97lNi/BIGir0Nsr5DC5fkyZLxWh6vSYYqOlRPFV8E63RXCI71Jkxm?=
 =?us-ascii?Q?W6C4x650+bq+RDpFTq5kcvU1UM2Vszt3YyOeElIiYSL3y7mHD6lXwotQ2qqC?=
 =?us-ascii?Q?hDn45U9wNAeaaFjydbaLzgQfU4u7+yYCWQfwZo8Lsd5GXhnHqxjuikUGsNSb?=
 =?us-ascii?Q?LPJ3u7AZcFFoNIAWZQ17J9UjpxddB99n+DecalaW8HVt678sHjG/LGTJ4JKn?=
 =?us-ascii?Q?d/8syw=3D=3D?=
X-Forefront-Antispam-Report:
	CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	3QYTttDYOXeZm2SxBwdXT4DaSB47II2Q3mn/oPw0UaR0Xdv9AtDUyUFtHb1o3aUpcpjX1r6XpI80vnJIKkMYq8xV/aLi04LiyzShvZfDBGCuKvt/RmEqShb7GKSvvoLVBFzk9j61sYczadRTHF9KLimN6VzbInGfoiIRAiJk3+JkyqMnX3qDCoZDdrUExzTiu/fjKAKEfMs4/LzOx78exP9Tkbp3Ynhf0kQoPAIAxE3FFbahFZLForl2GVpaWFjv8B0C45uXn3Vkwmw72Cew/l7kkpYs9tYMCEASfazgejNDcjQeejREaSjA6JgUHrSTAWAhwX1eSJzdDhnY3/oMpwjI5Srw8TW5S99eBx95VTXqgJosMotwPym2dvy6OoUT1koG/n64a9bEA4FfXwfEj0gpV6F8KorIm7MdlXvUsocPT/30IiVksUUrvJU+lFRJ
X-OriginatorOrg: ti.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 13:07:21.8507
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bb7b784-b2d1-4fde-876e-08de6a37a8bb
X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SJ1PEPF000026C8.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6441
X-DKIM: signer='ti.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: ti.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [104.64.211.4 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

According to the datasheet for the AM62Ax SoC [0], pin M19 has the address
0x000F40A8. Therefore, the offset to be passed to the AM62AX_IOPAD macro is
0xa8 and not 0x07c. With the existing incorrect offset, the following error
is seen when Linux boots:
	fa00000.mmc: deferred probe pending: platform: supplier regulator-5 not ready
with the SD Card being unusable and the boot process halting due to the root
filesystem in the SD Card being inaccessible.

Hence, fix it.

[0]: https://www.ti.com/lit/ds/symlink/am62a7.pdf

Fixes: 8f023012eb4a ("arm64: dts: ti: k3-am62a: Enable UHS mode support for SD cards")
Cc: <stable@vger.kernel.org>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---

Hello,

This patch is based on commit
37a93dd5c49b Merge tag 'net-next-7.0' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
of Mainline Linux.

Regards,
Siddharth.

 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
index e99bdbc2e0cb..9cfe7e7b317b 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
@@ -398,7 +398,7 @@ AM62AX_IOPAD(0x01d4, PIN_INPUT, 7) /* (C15) UART0_RTSn.GPIO1_23 */
 
 	vddshv_sdio_pins_default: vddshv-sdio-default-pins {
 		pinctrl-single,pins = <
-			AM62AX_IOPAD(0x07c, PIN_OUTPUT, 7) /* (M19) GPMC0_CLK.GPIO0_31 */
+			AM62AX_IOPAD(0x0a8, PIN_OUTPUT, 7) /* (M19) GPMC0_CLK.GPIO0_31 */
 		>;
 	};
 
-- 
2.51.1



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215959-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id GFs6DDPUjWmvoRkAYBR5ng
	(envelope-from <stable+bounces-215959-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:22:59 +0000
Return-path: <stable+bounces-215959-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 13:22:59 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215959-hi=josie.lol@vger.kernel.org>)
	id 1vqWeo-00000007VL7-3Djw
	for hi@josie.lol;
	Thu, 12 Feb 2026 13:22:59 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id DAFB73033E7D
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:22:57 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id CCB8A349B0F;
	Thu, 12 Feb 2026 13:22:54 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="C3T2hdlX"
X-Original-To: stable@vger.kernel.org
Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7863019E7F7;
	Thu, 12 Feb 2026 13:22:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770902574; cv=none; b=gqEypNRy3raCn8sXE0aeL04dFDxs4LJlF/ngpIZNG9+Ors/QKZ0p+0Ii+NjiWdOr80BH3Rtq4kiaMthgYmfI5T0cpovrQPYbNs7XCzerL+wLXADM9ued5mezzZk0MMj2UhlqCIjJjrwA33X7BBXF6ROdmLdH4ghRfiE1URvg7PM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770902574; c=relaxed/simple;
	bh=jVhqW5d5/4WvenW7FnYJhll+1n+XgrttPcOjEX9QFsg=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=I2GAXHqMDK+xkifjicKCnocRzQwoex8M8d5wCsXrn8ew/RCDZ/+3B7GzCxstR5EDHu0GGGxOIicLbUZ4vgpLx1b9vmSj7fYtof5JTjZMf4snXs1VUoxd68gM65EHt4jIvAaRALv4uFZyqg0deMnA/Az9d0YSXJUg7kZDPCoZtXk=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=C3T2hdlX; arc=none smtp.client-ip=185.11.138.130
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de;
	s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To;
	bh=6WYgrh1rDbYZNtpEGMZFwhuaDpq+FiSgx7pXrEAtZIw=; b=C3T2hdlXcrBJ4qpsbxcT7Y0ydx
	3XZ2S09zc+uLa1AYHpq+dFepR9WumOyxeqOUjR/uuQd/AheonJ10tXqLmuak6bs/eMFer19H5ZD/Y
	Y2kCzw4TSfLiUHoZNiAErkgTMgeZDW24grBr2VGRqdM0lW9mw7UKZOThLKQmwLcedtYCR00QVeXvi
	w+CTrw0mhI0LW7tXMGpFhC3/bOihCpypfC+sJm3npeo/G4H2vBxvvbfAVJWKtzueV5Ir/QuQ09TEF
	VxOhQxlwpG5HBJApbZwGq8ww6chNoLs71C1D95AJFwMOTI4Uw+pU6qLmsU3kd7xj7tmrQVKD6ugHu
	esMmfaMQ==;
Received: from i53875be4.versanet.de ([83.135.91.228] helo=diego.localnet)
	by gloria.sntech.de with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <heiko@sntech.de>)
	id 1vqWeU-008Dft-KJ; Thu, 12 Feb 2026 14:22:38 +0100
From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= <heiko@sntech.de>
To: Ulf Hansson <ulf.hansson@linaro.org>, Shawn Lin <shawn.lin@rock-chips.com>
Cc: Finley Xiao <finley.xiao@rock-chips.com>, Frank Zhang <rmxpzlb@gmail.com>,
 linux-pm@vger.kernel.org,
 Sebastian Reichel <sebastian.reichel@collabora.com>,
 Detlev Casanova <detlev.casanova@collabora.com>,
 linux-rockchip@lists.infradead.org, Shawn Lin <shawn.lin@rock-chips.com>,
 stable@vger.kernel.org
Subject: Re: [PATCH] pmdomain: rockchip: Fix rkvdec0/1 and venc0/1 for RK3588
Date: Thu, 12 Feb 2026 14:22:37 +0100
Message-ID: <16020302.lVVuGzaMjS@diego>
In-Reply-To: <1770891364-52147-1-git-send-email-shawn.lin@rock-chips.com>
References: <1770891364-52147-1-git-send-email-shawn.lin@rock-chips.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-DKIM: signer='sntech.de' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: sntech.de]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

Am Donnerstag, 12. Februar 2026, 11:16:04 Mitteleurop=C3=A4ische Normalzeit=
 schrieb Shawn Lin:
> From the RK3588 TRM Table 1-1 RK3588 Voltage Domain and Power Domain Summ=
ary,
> PD_RKVDEC0/1 and PD_VENC0/1 rely on VD_VCODEC which require extra voltage=
s to
> be applied, otherwise it breaks RK3588-evb1-v10 board after vdec support =
landed[1].
> The panic looks like below:
>=20
>   rockchip-pm-domain fd8d8000.power-management:power-controller: failed t=
o set domain 'rkvdec0' on, val=3D0
>   rockchip-pm-domain fd8d8000.power-management:power-controller: failed t=
o set domain 'rkvdec1' on, val=3D0
>   ...
>   Hardware name: Rockchip RK3588S EVB1 V10 Board (DT)
>   Workqueue: pm genpd_power_off_work_fn
>   Call trace:
>   show_stack+0x18/0x24 (C)
>   dump_stack_lvl+0x40/0x84
>   dump_stack+0x18/0x24
>   vpanic+0x1ec/0x4fc
>   vpanic+0x0/0x4fc
>   check_panic_on_warn+0x0/0x94
>   arm64_serror_panic+0x6c/0x78
>   do_serror+0xc4/0xcc
>   el1h_64_error_handler+0x3c/0x5c
>   el1h_64_error+0x6c/0x70
>   regmap_mmio_read32le+0x18/0x24 (P)
>   _regmap_bus_reg_read+0xfc/0x130
>   _regmap_read+0x188/0x1ac
>   regmap_read+0x54/0x78
>   rockchip_pd_power+0xcc/0x5f0
>   rockchip_pd_power_off+0x1c/0x4c
>   _genpd_power_off+0x84/0x120
>   genpd_power_off+0x1b4/0x260
>   genpd_power_off_work_fn+0x38/0x58
>   process_scheduled_works+0x194/0x2c4
>   worker_thread+0x2ac/0x3d8
>   kthread+0x104/0x124
>   ret_from_fork+0x10/0x20
>   SMP: stopping secondary CPUs
>   Kernel Offset: disabled
>   CPU features: 0x3000000,000e0005,40230521,0400720b
>   Memory Limit: none
>   ---[ end Kernel panic - not syncing: Asynchronous SError Interrupt ]---
>=20
> [1] https://lore.kernel.org/linux-rockchip/20251020212009.8852-2-detlev.c=
asanova@collabora.com/
> Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks for tracking this down. This will make sure the video
encoders/decoders will not probe, if the domain-supply is missing.


Reviewed-by: Heiko Stuebner <heiko@sntech.de>

>=20
> ---
>=20
>  drivers/pmdomain/rockchip/pm-domains.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/ro=
ckchip/pm-domains.c
> index 997e93c..040aa5f 100644
> --- a/drivers/pmdomain/rockchip/pm-domains.c
> +++ b/drivers/pmdomain/rockchip/pm-domains.c
> @@ -1315,10 +1315,10 @@ static const struct rockchip_domain_info rk3588_p=
m_domains[] =3D {
>  	[RK3588_PD_NPUTOP]	=3D DOMAIN_RK3588("nputop",  0x0, BIT(3),  0,       =
0x0, BIT(11), BIT(2),  0x0, BIT(1),  BIT(1),  false, false),
>  	[RK3588_PD_NPU1]	=3D DOMAIN_RK3588("npu1",    0x0, BIT(4),  0,       0x=
0, BIT(12), BIT(3),  0x0, BIT(2),  BIT(2),  false, false),
>  	[RK3588_PD_NPU2]	=3D DOMAIN_RK3588("npu2",    0x0, BIT(5),  0,       0x=
0, BIT(13), BIT(4),  0x0, BIT(3),  BIT(3),  false, false),
> -	[RK3588_PD_VENC0]	=3D DOMAIN_RK3588("venc0",   0x0, BIT(6),  0,       0=
x0, BIT(14), BIT(5),  0x0, BIT(4),  BIT(4),  false, false),
> -	[RK3588_PD_VENC1]	=3D DOMAIN_RK3588("venc1",   0x0, BIT(7),  0,       0=
x0, BIT(15), BIT(6),  0x0, BIT(5),  BIT(5),  false, false),
> -	[RK3588_PD_RKVDEC0]	=3D DOMAIN_RK3588("rkvdec0", 0x0, BIT(8),  0,      =
 0x0, BIT(16), BIT(7),  0x0, BIT(6),  BIT(6),  false, false),
> -	[RK3588_PD_RKVDEC1]	=3D DOMAIN_RK3588("rkvdec1", 0x0, BIT(9),  0,      =
 0x0, BIT(17), BIT(8),  0x0, BIT(7),  BIT(7),  false, false),
> +	[RK3588_PD_VENC0]	=3D DOMAIN_RK3588("venc0",   0x0, BIT(6),  0,       0=
x0, BIT(14), BIT(5),  0x0, BIT(4),  BIT(4),  false, true),
> +	[RK3588_PD_VENC1]	=3D DOMAIN_RK3588("venc1",   0x0, BIT(7),  0,       0=
x0, BIT(15), BIT(6),  0x0, BIT(5),  BIT(5),  false, true),
> +	[RK3588_PD_RKVDEC0]	=3D DOMAIN_RK3588("rkvdec0", 0x0, BIT(8),  0,      =
 0x0, BIT(16), BIT(7),  0x0, BIT(6),  BIT(6),  false, true),
> +	[RK3588_PD_RKVDEC1]	=3D DOMAIN_RK3588("rkvdec1", 0x0, BIT(9),  0,      =
 0x0, BIT(17), BIT(8),  0x0, BIT(7),  BIT(7),  false, true),
>  	[RK3588_PD_VDPU]	=3D DOMAIN_RK3588("vdpu",    0x0, BIT(10), 0,       0x=
0, BIT(18), BIT(9),  0x0, BIT(8),  BIT(8),  false, false),
>  	[RK3588_PD_RGA30]	=3D DOMAIN_RK3588("rga30",   0x0, BIT(11), 0,       0=
x0, BIT(19), BIT(10), 0x0, 0,       0,       false, false),
>  	[RK3588_PD_AV1]		=3D DOMAIN_RK3588("av1",     0x0, BIT(12), 0,       0x=
0, BIT(20), BIT(11), 0x0, BIT(9),  BIT(9),  false, false),
>=20






From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215960-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id WKNTHxjXjWlAVRwAYBR5ng
	(envelope-from <stable+bounces-215960-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:35:20 +0000
Return-path: <stable+bounces-215960-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 13:35:20 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215960-hi=josie.lol@vger.kernel.org>)
	id 1vqWqm-00000007rl8-0pH5
	for hi@josie.lol;
	Thu, 12 Feb 2026 13:35:20 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 460C03031B28
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:35:19 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 4AC0E2EBB8C;
	Thu, 12 Feb 2026 13:35:17 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EUPMhkJP";
	dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e4eE6hNx"
X-Original-To: stable@vger.kernel.org
Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B47B29B777
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 13:35:14 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770903317; cv=none; b=NdvgJ7+IDc2vZrluDkfwCQ40yOrPDLvKY5PHX+WD11aJowPJxPFAHJWDlv2Yzja6lBFOVExJcxK8G4Xc23lIU4ACyB+W528YSsY0Xay6XUPRYZZpabSYY0Zj2jMaPel0ofGD2PjZaeizB2vSRowqIg1pGQahvrfgVWyLtIUb024=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770903317; c=relaxed/simple;
	bh=sOHPdiJV+WLttVq0TcWdwDT9t1CZym6vgPjhtivZVu0=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CyLs6O29Lh81DZ6vgadJqgIiF+X3Ok3CJqCQEVXRo7040O3EZxDVh0dIskLOAuyHRADNig6vehcV2hmYayXp4CXOv0bbR7PfjkhS/lAYs9LpGaDdCH4lJfSuVjYsnODqTOfAKeJoE47gIpA6XBWKGdsj1PEA9Y08vzbmCVhKewM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EUPMhkJP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e4eE6hNx; arc=none smtp.client-ip=205.220.180.131
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com
Received: from pps.filterd (m0279871.ppops.net [127.0.0.1])
	by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61CDRguw3943708
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 13:35:14 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=
	cc:content-transfer-encoding:date:from:message-id:mime-version
	:subject:to; s=qcppdkim1; bh=Qc2iAQ+caoPq5hxORFy3jvGkJgIpRAmga3z
	vPX/0hw0=; b=EUPMhkJPds9LD5o0sDkNpcwGNoHtEplWSL7Be1W6vLaHwRXyGgR
	vwgpdvdSPPell5j100AYvXGnc8G2+cLQfye5WIDSlLjKGUAjatGnWM+ya7pJ+0Z1
	wLlbc3ovIkitatTqeMurCFWH6huFmIdZJDkk3IL9k2di0kIFnfbs9DkhGSLWYfcW
	krJY/og3PygaCPrxNUFR75vukhwRDUzr+P+BxaBAVj3oXssNc2oGfCDGn7ZG63H5
	lbrsCow/089epv/Eqw9JcF5hsVdGxk5rs00KoS6GrsADMVfUSP1em5yoOfQh4+X5
	wPNZG0T8g9nZQD/qPkg3sZh9t12qlT5vgAA==
Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200])
	by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c90d6ttdm-1
	(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 13:35:13 +0000 (GMT)
Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8ca3e7722f1so632164285a.1
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 05:35:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=oss.qualcomm.com; s=google; t=1770903313; x=1771508113; darn=vger.kernel.org;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=Qc2iAQ+caoPq5hxORFy3jvGkJgIpRAmga3zvPX/0hw0=;
        b=e4eE6hNxDhrdDyPwVEkkkkLBe+G8iw2IjPrKY8PEAOEgLjrLy/7LG1zNetHnH5voSw
         dcFd0gp7vNhyMkTfKsQXPu8d04KzWAdsvT2IxAfJoH0OWRm/GC7ZIMZhemRaeZfp/RAZ
         BY5+PtzfUbUHJbfXxrVRsApLgjjdaJSzGegBbhOCrLgXLLNcDCadh2l3/RFU9fj05+tu
         3WBZIejtUNrMEMHhdnHkXYDzeiqe1kU2ZfLd62TT8tA7ou+yl/rKzYZjMorjDNb16r6+
         MqNoLuykE73TAMz3SzBq5MoW/g1Qa1oGg31u73MYkw/dAwjwYoMM3Fq9nQpa6uSDI6RM
         O2/w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770903313; x=1771508113;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=Qc2iAQ+caoPq5hxORFy3jvGkJgIpRAmga3zvPX/0hw0=;
        b=oMLKZLl8X7AqeV44n+glKoxr9GC0nTy82NylZom6k4Yz/+DBPMoaSEbpnIg1FUlg4E
         rlZ9LK38Z25+NcQpDq5ljXFH3esOuSrGDBNYaVDSAWhUM/cY2X6dPY+vC3V3EHbyDzvU
         7flCZOiRNvGD5faLsgLjPZD8oVwoBRhkWEH9MFWZOmirHeadeGvhYaD6y9DY0hV417C0
         BTXIiBXevfX34SGONaqdQsBNyKkViLHEJOuxYqoj9F4nkMfs/R+a254RBM0YqReqrjlr
         16rcxftVZ6875JL84RRzcCERdAqRreSDMV9u7kIeMZDYpAfL8MpoNByUONWBvquCxjpm
         C41w==
X-Forwarded-Encrypted: i=1; AJvYcCXDXaXnnl51OkdQST/f/1M30thkig5B7UNeyQc2Quc8pV0e/3yXhGL8rFYHz9YvoE6N9UJEUbQ=@vger.kernel.org
X-Gm-Message-State: AOJu0YwrxYM9n0X20LKkNWN91sYKmONexwl0hiXDCzmUmQb2+QHI7X0M
	lCSEfEfpWGCkI+iExp50nGDSnrfUnK1qAivOUFRQCM/aY62hUjU1kEVS4yrxSOB9mhwQ5h7LTGg
	TSvEB/S0JSleuxg+Ph39cJ2kwtv1lE8OLDHN3V8+3s4BtdcLlWngj3vuth00=
X-Gm-Gg: AZuq6aIfkTctqCKScihiFTsZKonOKhAqO+lFFgewBNwIPwnpNWDyXxoPALLMm3XyQKi
	ZLamvkRrlTWTluQHveygiYVtLOl4BxtD2rc8dL3OkUB3PvxuvhnARqjEhlXciAA6fIki5iA5n7B
	LHzKjx+q1//DjqyqRkBxzfKssg1drBz61U4g/eOl+2Up5Aqwp32Hb2tUprBqidZShUpWoEKLveo
	G333dcc8NvPMUTMS8twQAOQnf40y8O6OyZD75VG8TnUesOgDQzdeYbzn2ShU2L3t3vOS+Ot3/Pf
	gSBbSE20zzZ3f1Of5LKihohRswkK0R/50PHrHnTM4ljQ7BrLb56VUVl3E2cuvQ0ywZZDi+5CptJ
	uoeZwyVCzS89DA/cdxYlDph3ub7sM/sS2NT4KyoY/V9mWVMCWxFo=
X-Received: by 2002:a05:620a:4588:b0:8a0:7561:93c7 with SMTP id af79cd13be357-8cb33b957e0mr305571785a.17.1770903313264;
        Thu, 12 Feb 2026 05:35:13 -0800 (PST)
X-Received: by 2002:a05:620a:4588:b0:8a0:7561:93c7 with SMTP id af79cd13be357-8cb33b957e0mr305567085a.17.1770903312749;
        Thu, 12 Feb 2026 05:35:12 -0800 (PST)
Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:ed37:7547:7b8b:6eb0])
        by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65a3ceb1d6esm1805043a12.2.2026.02.12.05.35.11
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 12 Feb 2026 05:35:12 -0800 (PST)
From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
To: Linus Walleij <linusw@kernel.org>, Bartosz Golaszewski <brgl@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
        stable@vger.kernel.org
Subject: [PATCH] gpio: sysfs: fix chip removal with GPIOs exported over sysfs
Date: Thu, 12 Feb 2026 14:35:05 +0100
Message-ID: <20260212133505.81516-1-bartosz.golaszewski@oss.qualcomm.com>
X-Mailer: git-send-email 2.47.3
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Proofpoint-ORIG-GUID: W-wSpObAaFNL1AehJcurCZDp64rE-RfD
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDEwMSBTYWx0ZWRfX4mj7hg19BKxd
 hr4sUyNq+/3zQNSnYsggKpo6qFympiyxuiK40AFzs0160ZriKJYfuzuecshwZWkGI0lEZ5j3tcW
 NEQGTGU423gri1anPvzBMKisZoVY961mAxqQjIz7DixTPiQccLuzelgeGhaoeIgkUU9DvYJRSkK
 G6E/RGepQ28UBgVh8ALHAyWbG/Yd7BN1C4V+5pKD+YvUYCf8ECmBzeyBdSjTAX9Wi53MrhjgM+P
 UXJgQ+2omDrdHTo0KhXzP6ThTJckNw5IQAJZe0Ghr42x5sGBKb7cwVrF3y+6VFgDe0Lx8wNzPfc
 WvuO/lcWI8rHXN0J5f4tuLI1+Gbz65SWug7Kum+QoC31eMy3ut4Aq2ARvFZ5BHbqEu+HQF7dQqQ
 HXP/d0DJ6oPq5qrL4netXsxfSyM3YqOdJqOdAQWgMMfg6Vw2P3r8LSTDHK4gJXpAMLPfy7JZm0M
 gbMSh6hiuskGqAkcpew==
X-Authority-Analysis: v=2.4 cv=ZaMQ98VA c=1 sm=1 tr=0 ts=698dd711 cx=c_pps
 a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10
 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22
 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8
 a=CjzyuubHxb_HZ2d6ovcA:9 a=PEH46H7Ffwr30OY-TuGO:22
X-Proofpoint-GUID: W-wSpObAaFNL1AehJcurCZDp64rE-RfD
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49
 definitions=2026-02-12_04,2026-02-12_02,2025-10-01_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0
 spamscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 adultscore=0
 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0
 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120101
X-DKIM: signer='qualcomm.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-DKIM: signer='oss.qualcomm.com' status='pass' reason=''
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: qualcomm.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

Currently if we export a GPIO over sysfs and unbind the parent GPIO
controller, the exported attribute will remain under /sys/class/gpio
because once we remove the parent device, we can no longer associate the
descriptor with it in gpiod_unexport() and never drop the final
reference.

Rework the teardown code: provide an unlocked variant of
gpiod_unexport() and remove all exported GPIOs with the sysfs_lock taken
before unregistering the parent device itself. This is done to prevent
any new exports happening before we unregister the device completely.

Cc: stable@vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/gpio/gpiolib-sysfs.c | 106 ++++++++++++++++++-----------------
 1 file changed, 55 insertions(+), 51 deletions(-)

diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index cd553acf3055e..d4a46a0a37d8f 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -919,63 +919,68 @@ int gpiod_export_link(struct device *dev, const char *name,
 }
 EXPORT_SYMBOL_GPL(gpiod_export_link);
 
-/**
- * gpiod_unexport - reverse effect of gpiod_export()
- * @desc: GPIO to make unavailable
- *
- * This is implicit on gpiod_free().
- */
-void gpiod_unexport(struct gpio_desc *desc)
+static void gpiod_unexport_unlocked(struct gpio_desc *desc)
 {
 	struct gpiod_data *tmp, *desc_data = NULL;
 	struct gpiodev_data *gdev_data;
 	struct gpio_device *gdev;
 
-	if (!desc) {
-		pr_warn("%s: invalid GPIO\n", __func__);
+	if (!test_bit(GPIOD_FLAG_EXPORT, &desc->flags))
 		return;
-	}
 
-	scoped_guard(mutex, &sysfs_lock) {
-		if (!test_bit(GPIOD_FLAG_EXPORT, &desc->flags))
-			return;
-
-		gdev = gpiod_to_gpio_device(desc);
-		gdev_data = gdev_get_data(gdev);
-		if (!gdev_data)
-			return;
+	gdev = gpiod_to_gpio_device(desc);
+	gdev_data = gdev_get_data(gdev);
+	if (!gdev_data)
+		return;
 
-		list_for_each_entry(tmp, &gdev_data->exported_lines, list) {
-			if (gpiod_is_equal(desc, tmp->desc)) {
-				desc_data = tmp;
-				break;
-			}
+	list_for_each_entry(tmp, &gdev_data->exported_lines, list) {
+		if (gpiod_is_equal(desc, tmp->desc)) {
+			desc_data = tmp;
+			break;
 		}
+	}
 
-		if (!desc_data)
-			return;
+	if (!desc_data)
+		return;
 
-		list_del(&desc_data->list);
-		clear_bit(GPIOD_FLAG_EXPORT, &desc->flags);
+	list_del(&desc_data->list);
+	clear_bit(GPIOD_FLAG_EXPORT, &desc->flags);
 #if IS_ENABLED(CONFIG_GPIO_SYSFS_LEGACY)
-		sysfs_put(desc_data->value_kn);
-		device_unregister(desc_data->dev);
-
-		/*
-		 * Release irq after deregistration to prevent race with
-		 * edge_store.
-		 */
-		if (desc_data->irq_flags)
-			gpio_sysfs_free_irq(desc_data);
+	sysfs_put(desc_data->value_kn);
+	device_unregister(desc_data->dev);
+
+	/*
+	 * Release irq after deregistration to prevent race with
+	 * edge_store.
+	 */
+	if (desc_data->irq_flags)
+		gpio_sysfs_free_irq(desc_data);
 #endif /* CONFIG_GPIO_SYSFS_LEGACY */
 
-		sysfs_remove_groups(desc_data->parent,
-				    desc_data->chip_attr_groups);
-	}
+	sysfs_remove_groups(desc_data->parent,
+			    desc_data->chip_attr_groups);
 
 	mutex_destroy(&desc_data->mutex);
 	kfree(desc_data);
 }
+
+/**
+ * gpiod_unexport - reverse effect of gpiod_export()
+ * @desc: GPIO to make unavailable
+ *
+ * This is implicit on gpiod_free().
+ */
+void gpiod_unexport(struct gpio_desc *desc)
+{
+	if (!desc) {
+		pr_warn("%s: invalid GPIO\n", __func__);
+		return;
+	}
+
+	guard(mutex)(&sysfs_lock);
+
+	gpiod_unexport_unlocked(desc);
+}
 EXPORT_SYMBOL_GPL(gpiod_unexport);
 
 int gpiochip_sysfs_register(struct gpio_device *gdev)
@@ -1054,29 +1059,28 @@ void gpiochip_sysfs_unregister(struct gpio_device *gdev)
 	struct gpio_desc *desc;
 	struct gpio_chip *chip;
 
-	scoped_guard(mutex, &sysfs_lock) {
-		data = gdev_get_data(gdev);
-		if (!data)
-			return;
+	guard(mutex)(&sysfs_lock);
 
-#if IS_ENABLED(CONFIG_GPIO_SYSFS_LEGACY)
-		device_unregister(data->cdev_base);
-#endif /* CONFIG_GPIO_SYSFS_LEGACY */
-		device_unregister(data->cdev_id);
-		kfree(data);
-	}
+	data = gdev_get_data(gdev);
+	if (!data)
+		return;
 
 	guard(srcu)(&gdev->srcu);
-
 	chip = srcu_dereference(gdev->chip, &gdev->srcu);
 	if (!chip)
 		return;
 
 	/* unregister gpiod class devices owned by sysfs */
 	for_each_gpio_desc_with_flag(chip, desc, GPIOD_FLAG_SYSFS) {
-		gpiod_unexport(desc);
+		gpiod_unexport_unlocked(desc);
 		gpiod_free(desc);
 	}
+
+#if IS_ENABLED(CONFIG_GPIO_SYSFS_LEGACY)
+	device_unregister(data->cdev_base);
+#endif /* CONFIG_GPIO_SYSFS_LEGACY */
+	device_unregister(data->cdev_id);
+	kfree(data);
 }
 
 /*
-- 
2.47.3



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215961-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id cHk7K1vXjWmVVhwAYBR5ng
	(envelope-from <stable+bounces-215961-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:36:27 +0000
Return-path: <stable+bounces-215961-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 13:36:27 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215961-hi=josie.lol@vger.kernel.org>)
	id 1vqWrr-00000007twh-0BeG
	for hi@josie.lol;
	Thu, 12 Feb 2026 13:36:27 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 736AF30A794D
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:36:11 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id E1F0735BDAA;
	Thu, 12 Feb 2026 13:36:10 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b="liNNDiTX"
X-Original-To: stable@vger.kernel.org
Received: from smtp-42ac.mail.infomaniak.ch (smtp-42ac.mail.infomaniak.ch [84.16.66.172])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96E6C314D03
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 13:36:06 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=84.16.66.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770903370; cv=none; b=WPsDL1xndyh2X4lz8zBCdJMmwQCsXiLTL2r31P86IRSx+BMwk2y748DpLn0d+SdOcPPfiZuamDOD4ZLSzCbmbmfhc85OzDfuJJNzSWg4r8kBzlUBxMlBQsb8RXQKCP1Msebw/osROnpDZbt9e9UBJXAB2B3J+cOFqlT0TV0a77M=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770903370; c=relaxed/simple;
	bh=8TPMJycoHl+oBPNXwCoiW6EddB5LmvNhJXZy2Logh0k=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Amd0nyS1IfEmLwidWjSqRSjZidBWFOJo5rRafyovtvn5TIWQ7Q2gwp73EtZcZVe/gAUGB/PMf5aSL03D6T/P4kWpl0+r8auSp4dXWCrksJCfQ4zZFpaJuol1+Xhk4akvJE1vp5TLLatEaB/j8Gmp0SjgUUhoW9NDtYpRQwXCqNk=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net; spf=pass smtp.mailfrom=digikod.net; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b=liNNDiTX; arc=none smtp.client-ip=84.16.66.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=digikod.net
Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108])
	by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4fBbsq40m6zhFr;
	Thu, 12 Feb 2026 14:35:59 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digikod.net;
	s=20191114; t=1770903359;
	bh=xEyAvA0ZbsWEuMtKRmEo1JvZwxg/DQJkx+6k06T3DME=;
	h=From:To:Cc:Subject:Date:From;
	b=liNNDiTXnPwx9FhtwNA/ajVywOyoHP4yNYosdARL/mSxCFzInCbThT03hDVDqZehK
	 +mfdBuvDJU0GcH87yvvMVa7MsG7BkMz+MqL1FNPqdZgxnaMv0eMMF+B1QkhOhZjz2A
	 OwL+aRTMeHHo7Br4F8rtgcK1VD5ycaxm8ObdSi9E=
Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4fBbsq01TpzTmJ;
	Thu, 12 Feb 2026 14:35:58 +0100 (CET)
From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= <mic@digikod.net>
To: linux-kbuild@vger.kernel.org
Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= <mic@digikod.net>,
	linux-kernel@vger.kernel.org,
	kernel-team@cloudflare.com,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nsc@kernel.org>,
	=?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>,
	stable@vger.kernel.org
Subject: [PATCH v1] kbuild: Fix CC_CAN_LINK detection
Date: Thu, 12 Feb 2026 14:35:43 +0100
Message-ID: <20260212133544.1331437-1-mic@digikod.net>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Infomaniak-Routing: alpha
X-DKIM: signer='digikod.net' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

Most samples cannot be build on some environments because they depend
on CC_CAN_LINK, which is set according to the result of
scripts/cc-can-link.sh called by cc_can_link_user.

Because cc-can-link.sh must now build without warning, it may fail
because it is calling printf() with an empty string:

  + cat
  + gcc -m32 -Werror -Wl,--fatal-warnings -x c - -o /dev/null
  <stdin>: In function ‘main’:
  <stdin>:4:9: error: zero-length gnu_printf format string [-Werror=format-zero-length]
  cc1: all warnings being treated as errors

Fix this warning and the samples build by actually printing something.

Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nicolas Schier <nsc@kernel.org>
Cc: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Cc: stable@vger.kernel.org
Fixes: d81d9d389b9b ("kbuild: don't enable CC_CAN_LINK if the dummy program generates warnings")
Signed-off-by: Mickaël Salaün <mic@digikod.net>
---
 scripts/cc-can-link.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/cc-can-link.sh b/scripts/cc-can-link.sh
index e67fd8d7b684..58dc7dd6d556 100755
--- a/scripts/cc-can-link.sh
+++ b/scripts/cc-can-link.sh
@@ -5,7 +5,7 @@ cat << "END" | $@ -Werror -Wl,--fatal-warnings -x c - -o /dev/null >/dev/null 2>
 #include <stdio.h>
 int main(void)
 {
-	printf("");
+	printf("\n");
 	return 0;
 }
 END
-- 
2.53.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215962-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id gHQ+CaXZjWkEkB0AYBR5ng
	(envelope-from <stable+bounces-215962-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:46:13 +0000
Return-path: <stable+bounces-215962-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 13:46:13 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215962-hi=josie.lol@vger.kernel.org>)
	id 1vqX1I-00000008Bb6-3PZ9
	for hi@josie.lol;
	Thu, 12 Feb 2026 13:46:13 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 7EA6D3083A43
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:46:11 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id E19F933EC;
	Thu, 12 Feb 2026 13:46:10 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=codecoup.pl header.i=@codecoup.pl header.b="ifj6X24i"
X-Original-To: stable@vger.kernel.org
Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27EAD2AD20
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 13:46:08 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770903970; cv=none; b=oTQSNF+AP/L5H73U5B+RYjIgiMbqfbdKYniKpVYJ1qLFf0RntY3lLVQYMcbD37phTHw7rq5m5Ew0Mjo/SWPbHXbbVQhX30769T80/sTewRnOgo5lbUmNJsvEkxQv2N3np6hN6+926HxUCL+qyPVfzejlEbpP+neDuHkWsbNFu6Q=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770903970; c=relaxed/simple;
	bh=dUv4Z4RKWbg1YOudiByIx6u5p/gQcLg3pFtWHqvTLv0=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RZiepMGmIHnAJOrQnB+FUc/UWHOrgCkEyWYjJ2hW7Ndr83xM3G45x6j5vD9YAIWpuFepLDSb3je1YiVb8VZund52/7BREDMURJ9HMSWWnG1p0aD25DkwUrMNUGy72CQrDjpYfyby8ORJ0T7dBwvINmTpnFkJmFHbTpmlM9TR+FQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=codecoup.pl; spf=pass smtp.mailfrom=codecoup.pl; dkim=pass (2048-bit key) header.d=codecoup.pl header.i=@codecoup.pl header.b=ifj6X24i; arc=none smtp.client-ip=209.85.221.53
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=codecoup.pl
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codecoup.pl
Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43626796202so2741452f8f.3
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 05:46:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=codecoup.pl; s=google; t=1770903967; x=1771508767; darn=vger.kernel.org;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=u5IJc+vMufOcZ7BrhUT8ALQP9dDE3pvyqu+vStpetco=;
        b=ifj6X24ig2SlPvsqvRu52Iyz6IWawTOht77brOe27JkqvQ2TIVyhPGswgh8hHPB3Ao
         19/FDzRQ0r8uw/no1PCBG82yPTObb2tVepb1d6RTcblpUOWiRkN1d+uc8iVHxh58MNJs
         TwS7wSXSKDHB3zCTkzKKSbKBYjQs8dCBzdRphHpY5Yed/XxXGFwTWZDvUWkaAKbUDbmm
         J0IlrHTQZPHOc58s9isYnoKdEtz1ibYSEnhI74y4Z+WC1nfchpZelewAaDAxdjH6lCnZ
         DvhoyX6gZYtTFMuL8H8a3sFeZ6tuNwUjIqTFGSgZMNi41LjGDqRwyxeCdYwrc4NnRZ/n
         sJ/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770903967; x=1771508767;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=u5IJc+vMufOcZ7BrhUT8ALQP9dDE3pvyqu+vStpetco=;
        b=Colpf7Ra4lGGSq+TcpUJqTmWB9zz6iPfa+eQ4flfLmz+FXJvy106cFK7p4szt901sY
         ztpCLxIopXN5GZ4Q4ASjqYtQvxuIv0sObGMMDGHkMvL2UWpBzQM52Zn+BbjwszhdILky
         mqqQvglggFBKe97oy1D3qni3RYellbf4KBbx0pzRPTQ15FokiC/V3DB14GfOc0o4UtsF
         S056ViEYoBx6fTxDwygLpqz1RuQRDk4Flev2ex6CGAkuz2c+itqDFw91Sf9FYS4uBSm1
         9Dm+xYm7hEW6CFvBtmFmrC7poABSHvvDRA+JEHEA/pVVJTHOuL9i9GkG+z+Qne5xmJ3h
         7PlA==
X-Gm-Message-State: AOJu0Ywk18xbyFav4kbq3E4qRRKd5tHNj/DS1s2pprniktjlimL+bDul
	7NjgXgQRVO3ThElDPfGyZOwjW6SvMhGwwPAbSbVM9wTX4RDU4ggJrV2DR2KfmOPySBoPjUwQusp
	eiPJu0no=
X-Gm-Gg: AZuq6aJyDfa8c5w6Z+59P7gQpgu1f+j0cG3uTQAJ1aE0OhrR2uLoOTOFAdBhreSBUm8
	WSW6bUSM0KkV0/MqK3iU51lBx3NjkF8rCbRCAA6wQ9nWZMnT5Cxz4tpvc4WXHgO4CiLmG68geK2
	ccm6hBG9duAIVmFEMhnpxYV+qL6FFuKJzwU42ShXE9lOFCxud83zTO/1BuRXbxEzO4XFuxvL2N8
	wIqfVt7Bb5ucu86ZNnk9kyx4cTxioCriXJNKEQCGbMFUdj7Vqj06tq+aFBuyCziDHLdBQDRhiWk
	KkkKCXcbz9Q3J9LfL0UWNka69E30smS+CPoLfhlZocoCXNxhyGqXJKr9oKi4AIAyMp64UlUCsUD
	02oRR7tgwhV7C6NdKQgT2qNgdtVdcgCimbB40Qs7nXODzGT2EOgpAVEFV5t3rGd4mkgoGn+97Ta
	77H8TNn82kxHdamfM/YUzxNkbIZsNg
X-Received: by 2002:a05:6000:188e:b0:435:9ea8:8b83 with SMTP id ffacd0b85a97d-4378f14870emr3625053f8f.19.1770903966891;
        Thu, 12 Feb 2026 05:46:06 -0800 (PST)
Received: from localhost ([95.143.243.62])
        by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783d36f86sm11357396f8f.7.2026.02.12.05.46.06
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 12 Feb 2026 05:46:06 -0800 (PST)
From: Mariusz Skamra <mariusz.skamra@codecoup.pl>
To: mariusz.skamra@codecoup.pl
Cc: stable@vger.kernel.org,
	Paul Menzel <pmenzel@molgen.mpg.de>
Subject: [PATCH v2] Bluetooth: Fix CIS host feature condition
Date: Thu, 12 Feb 2026 14:45:50 +0100
Message-ID: <20260212134550.430152-1-mariusz.skamra@codecoup.pl>
X-Mailer: git-send-email 2.53.0
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='codecoup.pl' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: codecoup.pl]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

This fixes the condition for sending the LE Set Host Feature command.
The command is sent to indicate host support for Connected Isochronous
Streams in this case. It has been observed that the system could not
initialize BIS-only capable controllers because the controllers do not
support the command.

As per Core v6.2 | Vol 4, Part E, Table 3.1 the command shall be
supported if CIS Central or CIS Peripheral is supported; otherwise,
the command is optional.

Fixes: 709788b154ca ("Bluetooth: hci_core: Fix using {cis,bis}_capable for current settings")
Cc: stable@vger.kernel.org
Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index f04a90bce4a9..0b0dc0965f5a 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4592,7 +4592,7 @@ static int hci_le_set_host_features_sync(struct hci_dev *hdev)
 {
 	int err;
 
-	if (iso_capable(hdev)) {
+	if (cis_capable(hdev)) {
 		/* Connected Isochronous Channels (Host Support) */
 		err = hci_le_set_host_feature_sync(hdev, 32,
 						   (iso_enabled(hdev) ? 0x01 :
-- 
2.53.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215963-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id ODXaOsDZjWlD5BoAYBR5ng
	(envelope-from <stable+bounces-215963-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:46:40 +0000
Return-path: <stable+bounces-215963-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 13:46:41 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215963-hi=josie.lol@vger.kernel.org>)
	id 1vqX1k-00000008CSX-2c4o
	for hi@josie.lol;
	Thu, 12 Feb 2026 13:46:40 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 6E7293095402
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:46:37 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id A281A2AD20;
	Thu, 12 Feb 2026 13:46:36 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ChW6nw4a"
X-Original-To: stable@vger.kernel.org
Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010034.outbound.protection.outlook.com [52.101.201.34])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8945EEEAB;
	Thu, 12 Feb 2026 13:46:33 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.34
ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770903996; cv=fail; b=OdVT04YRel94po45ki6wBJVItWAOno+vOiSo5ikC4e2QGfqBhKrun0FslUIMiPGbkdB69psGwZ7+w4GAPQNMkDu2l33l4ehmRZmxAMScikW/lqnQnkINGaUu44WUn9fBmPvNRGUVhMdOINUeos1od7uu66mVqwgwrZromN2nyqM=
ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770903996; c=relaxed/simple;
	bh=CxpzYclZwqLcqMX1xNfMr50Pz7T4LuXp5wFs2XmYLd8=;
	h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From:
	 In-Reply-To:Content-Type; b=RtPkrWghWR1HoWJ3uRb+lrgWRcMTLrfIXXKGkXhVb2XS7XsdBFcJNMSq5udt1M38qN3owWZWDk1yDpTNFBtrQPMUCL83qUR6wnC79o5tnzLwGkLqWD1dKvzpv4VwIgzc/jhaRRO4Rg64cRmtFGEhUgW5aa+wlVzHhi0hDg01lFQ=
ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ChW6nw4a; arc=fail smtp.client-ip=52.101.201.34
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=kZ2pmBnyaTfpYiWp49QfA33RyHKrteEM5ZJ8bpMONCxIuoK8tuFDVn0RdSIYF/c8CenfbSQTzOpK2PX1Pig31Dhn1tBRNGMOOYT4pYyGCaYl8ffvWZOhCAzfdpnzztdqYLwhVFq+00e8K9PpUwkWx7vamh/QlvNHTreYQj5v0gTbzNHo5TNOdJ2SLDvplHL1NqCwAGPl6KgU/KL8lPzlLiVNbC/iqPjo/V9teclPhFwZsTixk1gXz1LMC7FwgI+jfbbCpxxSQsFhoQhequog/xWttOYrG5yB5yL88w9f1AQou7J2SUdqUQOR3vuUT3TCFsIDydb6FgEuq5ha3Lb8kQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EM0Cm80Ir9qmvA/M0YYdzH8JuGYDz0KEi0GFUvUrx4w=;
 b=v/u8/jaf3m3eww93prhitxEMhKk17X4X4277SbK3qAI2+hchbxzY3G16oPjZH1lOZV5PPPeMqPBYBJWtlEglJPSGFbDwjeundqA8U0l1b2aj4oMmdyZbNqPuf+HNrquUcDl97S36pTe1L5cQ2d3i3NU0920pQm0KYP8SBu3/JNpU23y96vKvWL8+QIgSqqVqCy6M3bMNu4hvgHHPjoETFwc0YY0R8ro3X2a+ECiXFC3L414t219tM/+mrrhG7JTjY7vhuCVAHP5myrY0/NlpFcWEFQsGQA0mZnJCAHHstM4XrSICZINvCiKG3oYHCqYtpqFBhWLSSuAl2L3jpzePug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 198.47.21.194) smtp.rcpttodomain=kernel.org smtp.mailfrom=ti.com; dmarc=pass
 (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none
 (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EM0Cm80Ir9qmvA/M0YYdzH8JuGYDz0KEi0GFUvUrx4w=;
 b=ChW6nw4ayDOfjBo0QarGtsLEC59A/lX/ub0h95tqRNUhFufkfe2UjLI25tgiFp/p8q4KJYH4cYPKNwQ0ud8OEhYLCYEQmQwjwy16AszvY9BPsYnsBKli23pUFfUNYD09WCayMuWt6LSIuTNEdL1/e6WUYMnEQNRO4JXmgatNr30=
Received: from PH3PEPF00004099.namprd05.prod.outlook.com (2603:10b6:518:1::45)
 by IA1PR10MB6145.namprd10.prod.outlook.com (2603:10b6:208:3ab::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.15; Thu, 12 Feb
 2026 13:46:31 +0000
Received: from SN1PEPF0002BA51.namprd03.prod.outlook.com
 (2a01:111:f403:f90e::3) by PH3PEPF00004099.outlook.office365.com
 (2603:1036:903:49::3) with Microsoft SMTP Server (version=TLS1_3,
 cipher=TLS_AES_256_GCM_SHA384) id 15.20.9587.15 via Frontend Transport; Thu,
 12 Feb 2026 13:46:31 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194)
 smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass
 action=none header.from=ti.com;
Received-SPF: Pass (protection.outlook.com: domain of ti.com designates
 198.47.21.194 as permitted sender) receiver=protection.outlook.com;
 client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C
Received: from flwvzet200.ext.ti.com (198.47.21.194) by
 SN1PEPF0002BA51.mail.protection.outlook.com (10.167.242.74) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.9611.8 via Frontend Transport; Thu, 12 Feb 2026 13:46:30 +0000
Received: from DFLE204.ent.ti.com (10.64.6.62) by flwvzet200.ext.ti.com
 (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 12 Feb
 2026 07:46:29 -0600
Received: from DFLE215.ent.ti.com (10.64.6.73) by DFLE204.ent.ti.com
 (10.64.6.62) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 12 Feb
 2026 07:46:28 -0600
Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE215.ent.ti.com
 (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend
 Transport; Thu, 12 Feb 2026 07:46:28 -0600
Received: from [10.249.145.65] ([10.249.145.65])
	by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 61CDkNDC3154025;
	Thu, 12 Feb 2026 07:46:24 -0600
Message-ID: <e9820b38-768c-45fb-a719-7a1db7a7a795@ti.com>
Date: Thu, 12 Feb 2026 19:16:22 +0530
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/3] PCI: tegra194: Reset BARs when running in PCIe
 endpoint mode
To: Niklas Cassel <cassel@kernel.org>
CC: Manikanta Maddireddy <mmaddireddy@nvidia.com>, <kishon@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>, Vidya Sagar <vidyas@nvidia.com>,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>, <stable@vger.kernel.org>,
	Thierry Reding <treding@nvidia.com>, <linux-pci@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>, Thierry Reding
	<thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, "Rob
 Herring" <robh@kernel.org>, =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?=
	<kwilczynski@kernel.org>
References: <20250922140822.519796-5-cassel@kernel.org>
 <20250922140822.519796-7-cassel@kernel.org>
 <2fedf28e-83ea-4e51-b1a1-e45f0e928509@nvidia.com> <aYonDJyd_dbV0GBK@ryzen>
 <94458c39-587b-4bb4-a410-e921e5d99f10@nvidia.com> <aYsDDOZA18BBeOsd@ryzen>
 <aYsKzBjmGEi1z0am@ryzen> <8d85409e-2f07-4e4b-831b-68c17a341a60@ti.com>
 <aY3FhZUhb7RL80Fp@ryzen>
Content-Language: en-US
From: Aksh Garg <a-garg7@ti.com>
In-Reply-To: <aY3FhZUhb7RL80Fp@ryzen>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA51:EE_|IA1PR10MB6145:EE_
X-MS-Office365-Filtering-Correlation-Id: 7bb6094a-70cd-4884-4c72-08de6a3d206a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam:
	BCL:0;ARA:13230040|1800799024|82310400026|36860700013|376014|7416014;
X-Microsoft-Antispam-Message-Info:
	=?utf-8?B?U21hRUI2S0NtQ3hWYUZMYStOaWsxRHM4OWQxQnZiQURaQVZyM0xndG1uTHBH?=
 =?utf-8?B?dEFLOEZxSlNaWGMrRmdBNDlTWVJVWGZpSERkbnBRK25laDJxc1FydmVuNlRh?=
 =?utf-8?B?bmtTamppTy91QlF3aVFsTkttamg5em1meFRYb0FycEpyVm9UV0NmVFBvRGhS?=
 =?utf-8?B?ay9GQXB1VFh4OVVIWnR0QTNENFRFOTdNRFlWVkQ1MVExbCt4K0hxZ2FiZHhR?=
 =?utf-8?B?MjlPczRpeWdwREloK0M5K3JlZkk3elViUDRYZ3ErRlpuSTB0ZHVjOVJ4MWV5?=
 =?utf-8?B?SE1OUmZpQ0ZyY2d6RFQrR2JNZ0NsUGN2aktNOEY2WS94ZlZ0WWVrVjZzNUVB?=
 =?utf-8?B?akhFdTRiTUhDYzhsTFdMcTVnY0lxeTVybmNQUnNKRWRjZjRhSkZOUG95cGx2?=
 =?utf-8?B?cTRRYmtZMHdUaG9VeVk4QU95cGlUVTFLWFg4blRxSW1lenYwZHJGZml0aVVu?=
 =?utf-8?B?R3oxUEpWb25RL2tMZnFCZWpYbkdJUUJLM1R1WTlYb1dGL1RIRVIyc2ZlWXlB?=
 =?utf-8?B?QktaTTk0bGN2ams2dzlPenp4c05pWVRGandOZ3pEanFUZHVVTFlNRXNHV1JP?=
 =?utf-8?B?dUFPZFBPU1lueTdXWlFRMUROOWhSZDYxdHBGYkJTa2FDSk9kLzBmM05oMDJz?=
 =?utf-8?B?UGJRMGJGaWszOThSWFdZRGNnbDQzeDhBYVNTWkFkeVhxNkpncW1DRjBCNWZV?=
 =?utf-8?B?TEdkbko2L3A4UGFZTDdmbG1pOTZzT2Yzckx4dC96SWxoYnRJVkEzajFGYmxG?=
 =?utf-8?B?WHE5bFpweXQ0VTlvSERVZHZKWUtvNFVRMUZoaDJCTHYzNkNCa0s3ZCtHUTJI?=
 =?utf-8?B?UFhqWUZ3aGk3VTZTSWtsa0RyMHZCNWhQT0p5TUFHZGhYYUpVcUUvVVFoeEhq?=
 =?utf-8?B?dE9Wci81ZUQ1UTNDL040YUx0THJ3UjMxaGRhUDYrTm1aY3FrbGgxSE82SW9v?=
 =?utf-8?B?QktyU2Y0Ti9HNVlwZERSaWtUNnhlRmhNV2xVUzZPTExRMUM0QTZFZzF5blRv?=
 =?utf-8?B?MXBWTUVTQUp1YUZUWW5TQU9WS1V5eTc4eFJEdmNpQndYWHF1NUx6MGkyZXl1?=
 =?utf-8?B?UFNLckR5Q1RRVUdVNmFkS0t3YjdhSGJ5L1A1ZWpoQnpYOG9UTzJKQTJmUUE2?=
 =?utf-8?B?bjBCeU9jbnFLTHoyemJ1aUlEZlh1Q2UvcUE2SWNCdmJsdEFJemV4S2ZOTXlp?=
 =?utf-8?B?YnAwZG96M1ZUNE5VOWFlWE9uVU5DNC9NcE83Z1JpRy9OcS9QSXJ5bXpxTkp3?=
 =?utf-8?B?bE5Ib3htZG9xa2UvdEYySkd3NCt4T1FpcE9jWFJNVk5XaGJGRW50OVBWSEFJ?=
 =?utf-8?B?MkJPVXVyUzZ5d2xvZzlDVUlhNGVhZGVPTkR6OWNCeDBrT1FneWJucmk3Um9o?=
 =?utf-8?B?NUYxbmxBWFFtTzljWHdNZXc4QUowckJtMnZVb0xEcHg1OUtUMzFQNGE2dUt1?=
 =?utf-8?B?ZzJ6bkNxQ1c3Q0FHbFpFaTdYNklmY1hUcE5MMENsc0h1RnhlaEFaUTE3NXl5?=
 =?utf-8?B?NXFKdU5pK2sxOFdxZjZRZEYxRkxTclM3UVNEWXg0Sm93emF3UWJ4WUQzOTRa?=
 =?utf-8?B?Vkt3ZkpJTU5pS2FWRlJMZXZpTy9yeXBKK3hWaUlueGNBcEdHbTQwcXRCd1g3?=
 =?utf-8?B?eWUwQktyYnBjUmlJZkI3L050WlZxbGkyaFRQWDQ0RFEvQUxEMGMxSnRxSUhh?=
 =?utf-8?B?dG95SkpYK1c0bkFyVHMrZitZd1RVRStubFB1UUx2ZE1OTlJtNGo0VmdnOU9U?=
 =?utf-8?B?YThoUEJhMEVJTFFsclJtK0tja1h6ODF6UVFDaFB1UktWTGtCUldMQjB4TXVv?=
 =?utf-8?B?YUNCVnJaRUphd0pRUWpycS9pU1JhS0VlVUlvOGFOVHlwQ21rQ2tUQ0RTdEZQ?=
 =?utf-8?B?SEVkbnpnTC9Ob1NlWXp0UmtZQUFqdlJIVTd5cXNudGJ3MHUrbjVEVm12OEZX?=
 =?utf-8?B?ZElmaWVWQnpJZU56M2lBc3ZQblZFOE5TQlRFLytmdWZHcXk5VElrRUZvR0Nq?=
 =?utf-8?B?V2E3NXFhNmVzNFVHbE8vWjB5OHJ3cytvZzhWZ0VhNWtFSFA3U25ST1VIUG9w?=
 =?utf-8?B?WFdqdlprcGozTTRWTCtjNFltWElhMDBKdlBsT0xHcENYSHVocDRkOVFDQVhU?=
 =?utf-8?B?RVhYRkt1RHFjV1JsMzgyUm5abDZWdUdsNmI4OTJxSElZb20vYnNaUmtreFVT?=
 =?utf-8?B?QW8zZ3lqU3F4K29DU21JS2VqZW5wc1l1Y1V6WkVaSHJWWklQRTZjdXlNOTBo?=
 =?utf-8?B?MFloODdxdXRZOW1TZWZIRnIweE9nPT0=?=
X-Forefront-Antispam-Report:
	CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014)(7416014);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	1hS5GH05AQE+hzO8+q4tn7P1m0tPvzjVV3A79OHrJ8BKUZawbzFveB3DXDJcH3/CY0nvdIb4A9zlvrjGd/eTChKHGsbKf2Ukid6RIkCW8309pw+qPZpsCkdfDDMS1Jliun9Sww6xSYYoXVwgfHGZBMxM2dupk5tF8pp8cCz352S3ZrK3hnwrAjqNJpW8Hn9gnnL7AZ33siOmRELSqeNDMNNiKKgXq/bApgS2JXhbc6We6F1ZynbMHalxxI0qOyOFwaMmPkKRNvJyRxuo4RVwd270Gl+GXtgiE7Ceim2bv2W24xo7YXbBJ1BG3jyOD4ectUucmEyHnwbnv59lIuzMgxpGS/zTGK2iGZT7lzcJVEJBYvZB90/kkRQ4TRnEZKl6LHNErQyiA0wwbP/IqK4jpqukEQ1BdsnoaVMQqxehsiK39dGBzc1KeLJOci5JI1NJ
X-OriginatorOrg: ti.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 13:46:30.1795
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bb6094a-70cd-4884-4c72-08de6a3d206a
X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1PEPF0002BA51.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6145
X-DKIM: signer='ti.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4



On 2/12/2026 5:50 PM, Niklas Cassel wrote:
> On Thu, Feb 12, 2026 at 05:40:59PM +0530, Aksh Garg wrote:
>> > since you have a @ti.com email, perhaps you can explain how pci-keystone.c
>> > can pass all the pci-epf-test test cases, considering that this is the only
>> > driver that has BARs (BAR0 and BAR1) marked as BAR_RESERVED but do not also
>> > disable the BARs (using dw_pcie_ep_reset_bar()) in the init() callback.
>> > 
>> > Or, perhaps the simple answer is that pci-keystone.c does not pass all
>> > pci-epf-test test cases?
>> 
>> Hi Niklas,
>> 
>> I just joined the organization and have no context on why the
>> pci-keystone.c have BAR0 and BAR1 as reserved, without disabling the
>> bars using dw_pcie_ep_reset_bar() in the .init() callback. Because the
>> AM65 do not use any BARs for any purpose like Tegra194 does (ATU
>> registers or eDMA registers exposed in BAR4 for example), there would
>> be no issue if the BAR0 and BAR1 are overwritten.
>> 
>> This was introduced in the driver the time the EP support was added to
>> the driver by Kishon in commit 23284ad677a9 ("PCI: keystone: Add support
>> for PCIe EP in AM654x Platforms"), where no context is provided in the
>> comments or commit message why the BAR0/1 are marked as reserved in the
>> features. Perhaps Kishon can provide a better insight over this.
> 
> It is extra confusing, since the older driver from TI:
> pci-dra7xx.c does have the dw_pcie_ep_reset_bar() calls in init()
> (git blame shows added by Kishon), so it is a bit surprising that
> the newer driver (pci-keystone.c) does not.
> 
> (And like I explained, currently all DWC drivers except keystone and
> pcie-keembay.c do have the dw_pcie_ep_reset_bar() calls in init().)
> 

Yes, true. I tried to backtrace why this is so for pci-keystone.c, but
couldn't find anything on this.

> Kind regards,
> Niklas
> 



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215964-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id MA4MLuTZjWlHWx0AYBR5ng
	(envelope-from <stable+bounces-215964-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:47:16 +0000
Return-path: <stable+bounces-215964-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 13:47:16 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215964-hi=josie.lol@vger.kernel.org>)
	id 1vqX2K-00000008DXn-0AaC
	for hi@josie.lol;
	Thu, 12 Feb 2026 13:47:16 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id 9C4FA300A5B9
	for <hi@josie.lol>; Thu, 12 Feb 2026 13:47:12 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 88C95274B3A;
	Thu, 12 Feb 2026 13:47:09 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=codecoup.pl header.i=@codecoup.pl header.b="mGlNQfT6"
X-Original-To: stable@vger.kernel.org
Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8A0EEAB
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 13:47:07 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770904029; cv=none; b=d9scWm3+f3h4r1MTYqV91xK1rB4IDMTh7yIPHRO7SW28Q3gbVL++8NXJ7VmZlPCdvR25DmhPV0pJb5QOEyrJ63NUhNRAJ9GJPtIPcYGsE0Uc4xdEwKi942/Tx1399ujK9vaYjaF9YvMfq/SQk9IQfruRWNIALCCv9O01F4AtoAE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770904029; c=relaxed/simple;
	bh=dUv4Z4RKWbg1YOudiByIx6u5p/gQcLg3pFtWHqvTLv0=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a/ULr42683Tw+gh/D34uV4NIadlvJExo8uljIsZpLPT3BkLSVZr0ntWqwTIzZ3Q1+9caYovlUk8Ax1qVNuUUUu3UNQCH8gUbIw89r2QBiaz9n9voNcF2BmXZXZxGq5whQChPRIoBnMffFK/mmrz/bsGjtM7hq4s1bOAxa3K4Wdg=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=codecoup.pl; spf=pass smtp.mailfrom=codecoup.pl; dkim=pass (2048-bit key) header.d=codecoup.pl header.i=@codecoup.pl header.b=mGlNQfT6; arc=none smtp.client-ip=209.85.221.47
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=codecoup.pl
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codecoup.pl
Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-436e87589e8so4296399f8f.3
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 05:47:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=codecoup.pl; s=google; t=1770904026; x=1771508826; darn=vger.kernel.org;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=u5IJc+vMufOcZ7BrhUT8ALQP9dDE3pvyqu+vStpetco=;
        b=mGlNQfT6ZddHbRCzNGSebbliRtFm9QPlKkmdXmz+AAzZrLPJ4na09KvxawP3NjBetc
         JQciPk5NHei4O6Ce2Md1VgEVa/UabqLUDhhCDTehVbkyulKTQBKQve8h/+zhm//v5vQ6
         CdWrJUsIIpLNk6ibLi01IwxvJy2GNNvVOTRfvVZE9hqQbCLNSUIfjCxmXoKwY/1ep+ld
         jfRsBLFaZsrDRZUZY69HRauTCZ2yOkQjFImSLgxVP1rQh6wiLT4kcPbbdebjhbaP5YXE
         WWgw/du2e46ACdGLYTmOU9Fx94tG0aBCF5ragfz2TORG4kCb9RVYo8D1G1cwjLO1rsok
         BHGA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770904026; x=1771508826;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=u5IJc+vMufOcZ7BrhUT8ALQP9dDE3pvyqu+vStpetco=;
        b=jofB6t2cD5i5TuBSRaQ8JxlDA1dJgb0jMRfnpg6jxrQIggYKmV2hNiMuFmPKDcILwt
         lBmB9zk2lo34UButrceb2UrlWT9RysbWdIos+0NStQabxIKnl/A8b5pki+FF91tNFVBd
         kZJwZh/YRsPhNWBjJUD3otghahDdZMlVBzZ9ecrszxCgDi5cnqVtqljAs7Ow66wMEmJn
         IA4gw3fPRDT190HpLK2NYJZOAXEH4kKUydsn6A+6enBZ50Mr+co5nDC+0jHDXrkWXsyS
         yP/QvwqVF5k8Owzyq1kmaWObMtjWhvQ6cGzJLuEsEgq2RO54fO4zDp+Zqp4e+lLEkeD/
         5i2Q==
X-Forwarded-Encrypted: i=1; AJvYcCXd9xahlPOfVEszAS59+myjsK4QuVSZRPnjtpDCuS9F//JO7+3fgXGnzvIL2gCUs8CeQMTDEY0=@vger.kernel.org
X-Gm-Message-State: AOJu0YxsIuQNTahyDYBQgI1hqg9ZGkh2cbzEqpsFq6WQc7WePFIAoP9B
	5ft1GDVFzA5lYTnVoxqZTesn5YXfIee1lKy7DOgHCHjlGKzQcFpBSqtClre4EozQF9g=
X-Gm-Gg: AZuq6aI6WnfF0hFvuxbFCAe5so5Os5VS/phHfH/4RHhCgtKmCqoX+Q7/fqTlJay7FhX
	WbBNLlYD+Mf3n2SrfjXs76tTA6bUt594qaaN/1vHHMoE9RtH1BzD4Xd16X1LSKjMupm1F4VdWGx
	yvPctuZSM3/i2OY2Lsk8R+7+hx7ug9FvMrRE9qEjmQ4cCQS23HEYeygxJy83WOCB7cTBA4eb7jK
	mI35m4ARBqXnaOjpHMT/IJ1ZEjfIvqIplT+N3RZZ7LVCkBal57oHImlH9fZHuRAXbHWl8/zDXVD
	dcX65B/uMSrd0+KQmNeldOn9UQQxNypPILX7iVaOfOq/NlsHmzPt4wEh5SbI586hGdzqT/Gh2EN
	bVk0p9LhjirMBh0dmInR85n+tjdNczMPYTHN6Y4sGDd5xMzDhFxKN72W65ucYFBjGkJ9kaaofqo
	zjzy6uEIQShOLExc4GQgRg98rgLfIh
X-Received: by 2002:a05:600c:3e83:b0:480:6999:27ec with SMTP id 5b1f17b1804b1-483656c0a9cmr39466285e9.13.1770904026135;
        Thu, 12 Feb 2026 05:47:06 -0800 (PST)
Received: from localhost ([95.143.243.62])
        by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783e3cacesm12598158f8f.31.2026.02.12.05.47.05
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 12 Feb 2026 05:47:05 -0800 (PST)
From: Mariusz Skamra <mariusz.skamra@codecoup.pl>
To: linux-bluetooth@vger.kernel.org
Cc: Mariusz Skamra <mariusz.skamra@codecoup.pl>,
	stable@vger.kernel.org,
	Paul Menzel <pmenzel@molgen.mpg.de>
Subject: [PATCH v2] Bluetooth: Fix CIS host feature condition
Date: Thu, 12 Feb 2026 14:46:46 +0100
Message-ID: <20260212134646.430396-1-mariusz.skamra@codecoup.pl>
X-Mailer: git-send-email 2.53.0
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-DKIM: signer='codecoup.pl' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

This fixes the condition for sending the LE Set Host Feature command.
The command is sent to indicate host support for Connected Isochronous
Streams in this case. It has been observed that the system could not
initialize BIS-only capable controllers because the controllers do not
support the command.

As per Core v6.2 | Vol 4, Part E, Table 3.1 the command shall be
supported if CIS Central or CIS Peripheral is supported; otherwise,
the command is optional.

Fixes: 709788b154ca ("Bluetooth: hci_core: Fix using {cis,bis}_capable for current settings")
Cc: stable@vger.kernel.org
Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index f04a90bce4a9..0b0dc0965f5a 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4592,7 +4592,7 @@ static int hci_le_set_host_features_sync(struct hci_dev *hdev)
 {
 	int err;
 
-	if (iso_capable(hdev)) {
+	if (cis_capable(hdev)) {
 		/* Connected Isochronous Channels (Host Support) */
 		err = hci_le_set_host_feature_sync(hdev, 32,
 						   (iso_enabled(hdev) ? 0x01 :
-- 
2.53.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <linux-s390+bounces-16303-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id kD98HYrdjWmyah4AYBR5ng
	(envelope-from <linux-s390+bounces-16303-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:02:50 +0000
Return-path: <linux-s390+bounces-16303-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:02:50 +0000
Received: from sto.lore.kernel.org ([172.232.135.74])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <linux-s390+bounces-16303-hi=josie.lol@vger.kernel.org>)
	id 1vqXHO-00000008gZo-0T6N
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:02:50 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sto.lore.kernel.org (Postfix) with ESMTP id CF7DB301347C
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:02:46 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id A21253451CE;
	Thu, 12 Feb 2026 14:02:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="CCUQ5n2l"
X-Original-To: linux-s390@vger.kernel.org
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D0BA3EBF1F;
	Thu, 12 Feb 2026 14:02:42 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770904963; cv=none; b=JIwojIOcu71OikXjbH7w2UEb5s6NWHICTmtp2olCGgnX8VEH1Vv80O+/DhRLixbTgkqA/uTzBKV/nErqSk1m0VQCCUY5nOvrvInQWybOjuvmu8qXIzMYsXa7Ca36tVNCTXM0Wg4cCgabjNpP8D6xlhv0Qg/0cnPWeb0IjM0TYHA=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770904963; c=relaxed/simple;
	bh=WnXhNfLpqjSOq+iWjqkyu0u0NnRxDWcyWCEJv5L6yV4=;
	h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=h6lKqhSQPjc5w+TNrDmfaEyXM4clXBzcAD4ybbLIOnxgrCZ3eEvRY7KaH4SZNGHB2GSHN7WWfovf5ZaKHWYGJkp8vlaCsta83cAndofI+hiYYx/SZwwKA9Z+qNWNwSddEfhxtvif9GYYnpRmIfbepLbsOZta0bWF8tM405YXvA4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=CCUQ5n2l; arc=none smtp.client-ip=148.163.156.1
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com
Received: from pps.filterd (m0360083.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61C99BEw528536;
	Thu, 12 Feb 2026 14:02:36 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc
	:content-transfer-encoding:content-type:date:from:message-id
	:mime-version:subject:to; s=pp1; bh=z9KnT6kiiqTL9pUGcsbZCQDdcvpr
	tBVFKD35eynel1Y=; b=CCUQ5n2lSuPid4QHdwiNNQX7Nx5SblJhqPJxnqjUefTN
	lewfuQEhY1pxpGnvqzUBXhFGZfehZ4xWzV+xjt1Boq6BMSM9QU76tQkdU9/dANQ7
	hSqe/FHTcNcOYt9hy5onwUYGgHKrPuPPdNaFBMzJTQNvXKkRlZUSFaHs6xySaRCl
	QXx6bMdKFmsBtJCibtU7r7SmvM2Ns4BlhZrdPe5+Rdjn2t93dy43JkaxzBt6vWNb
	1rqe2Evaq5TeOlmH7XULF40ID5uPkKDzQNDTaCw1yZzJKJtJc3S9QpD/r9iIKnkd
	0tJeLeyLddCFHfUS/zB+MjaPKrRThI5VvP1vzpXXVQ==
Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])
	by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696upg2d-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 14:02:36 +0000 (GMT)
Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])
	by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 61C9XZPt012616;
	Thu, 12 Feb 2026 14:02:35 GMT
Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226])
	by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6h7kjjcu-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 14:02:35 +0000
Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103])
	by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 61CE2UKi52035890
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
	Thu, 12 Feb 2026 14:02:30 GMT
Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id AFCC72004B;
	Thu, 12 Feb 2026 14:02:30 +0000 (GMT)
Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id 69E5F20065;
	Thu, 12 Feb 2026 14:02:30 +0000 (GMT)
Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9])
	by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP;
	Thu, 12 Feb 2026 14:02:30 +0000 (GMT)
From: Julian Ruess <julianr@linux.ibm.com>
Subject: [PATCH 0/3] vfio/pci: Introduce vfio_pci driver for ISM devices
Date: Thu, 12 Feb 2026 15:02:14 +0100
Message-Id: <20260212-vfio_pci_ism-v1-0-333262ade074@linux.ibm.com>
Precedence: bulk
X-Mailing-List: linux-s390@vger.kernel.org
List-Id: <linux-s390.vger.kernel.org>
List-Subscribe: <mailto:linux-s390+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-s390+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-B4-Tracking: v=1; b=H4sIAGbdjWkC/33QTWrDMBAF4KsEreugGUkjKaveo5Sg30ZQ28FuT
 Urw3StnU9c1Xb4H8/GYOxvTUNLIToc7G9JUxtJ3NcDTgYWL695SU2LNDDkqjqibKZf+fA3lXMa
 24SEETFIjSs3qyXVIudwe3MtrzZcyfvTD10OfcGkXiDiA+g1N2PAmkBOZFKkI4vm9dJ+3Y/HtM
 fQtW7BJrAG7AUQFIESA6BLXPO4BcgWg2AByWeBNFtqhRW/2ALUGtgtUBXQmq52QXjrYA+gHQE4
 bgCoQo9VCcktJ2z1A/wfoCkjyRsbsyELaA8wKANgApgJKSe6C9Wj+PnGe529gKQI7MgIAAA==
X-Change-ID: 20250227-vfio_pci_ism-0ccc2e472247
To: schnelle@linux.ibm.com, wintera@linux.ibm.com, ts@linux.ibm.com,
        oberpar@linux.ibm.com, gbayer@linux.ibm.com,
        Alex Williamson <alex@shazbot.org>, Jason Gunthorpe <jgg@ziepe.ca>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <skolothumtho@nvidia.com>,
        Kevin Tian <kevin.tian@intel.com>
Cc: mjrosato@linux.ibm.com, alifm@linux.ibm.com, raspl@linux.ibm.com,
        hca@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
        julianr@linux.ibm.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-pci@vger.kernel.org
X-Mailer: b4 0.14.2
X-TM-AS-GCONF: 00
X-Authority-Analysis: v=2.4 cv=KZnfcAYD c=1 sm=1 tr=0 ts=698ddd7c cx=c_pps
 a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17
 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22
 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8
 a=buv0j8F9Xdj7ltUxVnMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDEwNCBTYWx0ZWRfXzPCKsCWULGJ3
 EKlB9jnIEOFwXVSQFRRSR0ycYcB8HBsXIxba515f6hzOsJ3H27dZpVyCp3FT36NcdKe3Wy1NNH/
 hL96aqAVEKtSfoAxFg+Lt+YeWJqYNIY7PBNMI1KP7TGT943oPtPlYXljgwTpCPimVnXTxUcydN5
 FbAeGwDU44+RzQmxt4/TwD0uLfXLVQDn9D67o6cAGJoZFJCxUFpi1qIaUxqpKIiewKdvvVoZWfG
 uv+5FTt8ewY3Qq7ONQ1bNYR62Ov1/3WHFnLRmub5Vcam7EuDDLnUjcOwD+eXcUZKCEGGskOpKyt
 LAlbgBUleN2cOsxiFR//ibcjQxd8DUymXpGP7I/VkhaeJBbC3r+K1JSnGHpxkPLuHHigZbCeEfC
 N22fxoLRthluRsoADETKXODSG015Rp89q10ZWDDVUDymsR8RaveakpgmRTwdv7ua1kw6+0qpAuN
 xjzSDeJE0+KVHB8w4gA==
X-Proofpoint-ORIG-GUID: E6uP3_QtvQIhaO-aBG1j4w1DthdtX17k
X-Proofpoint-GUID: E6uP3_QtvQIhaO-aBG1j4w1DthdtX17k
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49
 definitions=2026-02-12_04,2026-02-12_02,2025-10-01_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 spamscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0
 clxscore=1015 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0
 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0
 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120104
X-DKIM: signer='ibm.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 5

Hi all,

This series adds a vfio_pci variant driver for the s390-specific
Internal Shared Memory (ISM) devices used for inter-VM communication
including SMC-D.

This is a prerequisite for an in-development open-source user space
driver stack that will allow to use ISM devices to provide remote
console and block device functionality. This stack will be part of
s390-tools.

This driver would also allow QEMU to mediate access to an ISM device,
enabling a form of PCI pass‑through even for guests whose hardware
cannot directly execute PCI accesses, such as nested guests.

On s390, kernel primitives such as ioread() and iowrite() are switched
over from function handle based PCI load/stores instructions to PCI
memory-I/O (MIO) loads/stores when these are available and not
explicitly disabled. Since these instructions cannot be used with ISM
devices, ensure that classic function handle-based PCI instructions are
used instead.

The driver is still required even when MIO instructions are disabled, as
the ISM device relies on the PCI store‑block (PCISTB) instruction to
perform write operations.

Thank you,
Julian

Signed-off-by: Julian Ruess <julianr@linux.ibm.com>
---
Julian Ruess (3):
      vfio/pci: Set VFIO_PCI_OFFSET_SHIFT to 48
      vfio/ism: Implement vfio_pci driver for ISM devices
      MAINTAINERS: add VFIO ISM PCI DRIVER section

 MAINTAINERS                        |   6 +
 drivers/vfio/pci/Kconfig           |   2 +
 drivers/vfio/pci/Makefile          |   2 +
 drivers/vfio/pci/ism/Kconfig       |  11 ++
 drivers/vfio/pci/ism/Makefile      |   3 +
 drivers/vfio/pci/ism/main.c        | 227 +++++++++++++++++++++++++++++++++++++
 drivers/vfio/pci/vfio_pci_config.c |   1 +
 drivers/vfio/pci/vfio_pci_core.c   |   4 +-
 include/linux/vfio_pci_core.h      |   2 +-
 9 files changed, 255 insertions(+), 3 deletions(-)
---
base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b
change-id: 20250227-vfio_pci_ism-0ccc2e472247

Best regards,
-- 
Julian Ruess <julianr@linux.ibm.com>



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <linux-s390+bounces-16302-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id cHpFEZDdjWkh+h4AYBR5ng
	(envelope-from <linux-s390+bounces-16302-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:02:56 +0000
Return-path: <linux-s390+bounces-16302-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:02:56 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <linux-s390+bounces-16302-hi=josie.lol@vger.kernel.org>)
	id 1vqXHT-00000008gi2-2lKa
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:02:56 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id 111843011F7B
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:02:45 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id D11A72F0C68;
	Thu, 12 Feb 2026 14:02:42 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="JDm407du"
X-Original-To: linux-s390@vger.kernel.org
Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7972A2C234A;
	Thu, 12 Feb 2026 14:02:41 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770904962; cv=none; b=d7wf6DbhBCdK9f6HO+lqei/tjE4b1t6GuLGD/7CqfvZ0R10HjOWAjywCcMpUvxLsPAG84APf8h7HSch69v0rfLxqmV82OOEEPX+WMCvwvgHj9jRr/tzGE6CNZYVUO67NzGZ9UNLXb3/53dNoIRnwKnw1b7FVtpEA1OgMbKI6YDw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770904962; c=relaxed/simple;
	bh=iS+s19X3jjjts8Df2O63rWj3hlfZLHXYx/c7cTEzgEI=;
	h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
	 In-Reply-To:To:Cc; b=nQ0BmD+9UMxdBG8JSudd0lpPIS4qq51ZJnEJS12BEIobfLz5BLWggS0YP2TfQYZSCWt3dwgDTkIlQ5nKMZWndTfnNsXy8iMyzJqma+2tHHTmEJx6bXe+dfTuaS//SwDFFFewcIyXJeSkBoTsnZIJG3bkCDvC6u/+yCadPcZ6MCs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=JDm407du; arc=none smtp.client-ip=148.163.158.5
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com
Received: from pps.filterd (m0360072.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61C741v5473751;
	Thu, 12 Feb 2026 14:02:36 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc
	:content-transfer-encoding:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to; s=pp1; bh=tmqPTD
	XRn4fBwC657wa097v50m21rpJjL5kQW52yC6U=; b=JDm407du5dtyjZgys88DD2
	N3eS18wKZhc86+U9mVpJOTq0LpxnVHnAWRjq5Rj7oqzSbXRikpbsloLl9uYi3/y1
	and3Q9SVl4J/bYaA85gukYlV1Xs+HJkQTqknY5NDYBTmvyQCOpK4nrj7zOZmEb4I
	IzMKErdCXc4tvAg3/JdUEfmtP/FhZFLsnjB0aEbeVUwgpITVLzLoHW1CUx6GIPb9
	30DK0bQKc0KTMFOfp8/Huw5AnX2jfx1+V8NjOY3bt1pbFIViPNTjweNDEiNQJh3N
	4LmMuL/RghdTT/0P/1K1nf9ZYG0/nNBMzhUS1FZtWwiABd+RojzXvms4B5OZjjZw
	==
Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])
	by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696x3qvx-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 14:02:36 +0000 (GMT)
Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])
	by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 61CCGKve008404;
	Thu, 12 Feb 2026 14:02:35 GMT
Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])
	by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6g3yjrt3-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 14:02:35 +0000
Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103])
	by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 61CE2VWp61669810
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
	Thu, 12 Feb 2026 14:02:31 GMT
Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id C533E20040;
	Thu, 12 Feb 2026 14:02:31 +0000 (GMT)
Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id 79D4F2004B;
	Thu, 12 Feb 2026 14:02:31 +0000 (GMT)
Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9])
	by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP;
	Thu, 12 Feb 2026 14:02:31 +0000 (GMT)
From: Julian Ruess <julianr@linux.ibm.com>
Date: Thu, 12 Feb 2026 15:02:17 +0100
Subject: [PATCH 3/3] MAINTAINERS: add VFIO ISM PCI DRIVER section
Precedence: bulk
X-Mailing-List: linux-s390@vger.kernel.org
List-Id: <linux-s390.vger.kernel.org>
List-Subscribe: <mailto:linux-s390+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-s390+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20260212-vfio_pci_ism-v1-3-333262ade074@linux.ibm.com>
References: <20260212-vfio_pci_ism-v1-0-333262ade074@linux.ibm.com>
In-Reply-To: <20260212-vfio_pci_ism-v1-0-333262ade074@linux.ibm.com>
To: schnelle@linux.ibm.com, wintera@linux.ibm.com, ts@linux.ibm.com,
        oberpar@linux.ibm.com, gbayer@linux.ibm.com,
        Alex Williamson <alex@shazbot.org>, Jason Gunthorpe <jgg@ziepe.ca>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <skolothumtho@nvidia.com>,
        Kevin Tian <kevin.tian@intel.com>
Cc: mjrosato@linux.ibm.com, alifm@linux.ibm.com, raspl@linux.ibm.com,
        hca@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
        julianr@linux.ibm.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-pci@vger.kernel.org
X-Mailer: b4 0.14.2
X-TM-AS-GCONF: 00
X-Authority-Analysis: v=2.4 cv=WZYBqkhX c=1 sm=1 tr=0 ts=698ddd7c cx=c_pps
 a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17
 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22
 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8
 a=VwQbUJbxAAAA:8 a=Ikd4Dj_1AAAA:8 a=N04f8XHk16Uzgq2NRSwA:9 a=QEXdDO2ut3YA:10
X-Proofpoint-GUID: vm_oryJQ4MZObU8Y1D8-iHXUu2E0M2me
X-Proofpoint-ORIG-GUID: vm_oryJQ4MZObU8Y1D8-iHXUu2E0M2me
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDEwNCBTYWx0ZWRfX5hZKwaP5Pj6d
 2Qr9xdvlifsUyoju/hVBjA0okCcJizyINBMyQoZ8mbvtLuPDp8C1mAtKPzwzfO1SMsMaIS4BOFE
 V/FOWUOyOQuXRa6fmSp1V5FfasFgfYghf8a7rAywMvKN4BtX9GatEAcaK5NZkyqLwu7aIoP3htT
 kFHEgLSxZ8+cQ+If3+CCk5zVD9gyKZMOf+83oDhMQKYX0Hp0zz9XEyIcIm+o2L5OZqH+iRkSHX0
 /tKd7FvZGdwe3ozg97envwZMbuFBOZtBsC0godOaeWULRWtE2CiyrEP+KulPyQOGDCjs+SBSpmW
 NXSf7IhwRZhae6WR8qPn9Z7+4dGxJ23Y0nw8eH6KxsIX5EGJidKeDCow5YEwVWwAvQFTudHS04O
 3cGfhBS+E+JVE3iKVLQbP1vfN1uvcgknXOmtegQLZ7QynQqCPCmNmn2nGabsmr9WuT4ETzZrt4q
 y5Vk6dt5joLuutWqBkg==
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49
 definitions=2026-02-12_04,2026-02-12_02,2025-10-01_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0
 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0
 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc=
 route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000
 definitions=main-2602120104
X-DKIM: signer='ibm.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [104.64.211.4 listed in list.dnswl.org]
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 5

ism_vfio_pci is a new kernel component that allows
to use the ISM device from userspace. Add myself
as a maintainer.

Acked-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Julian Ruess <julianr@linux.ibm.com>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e087673237636268346979ddc270f8cf0905c722..e9d025ea396e71102463a50b2934827175356da2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -27393,6 +27393,12 @@ L:	kvm@vger.kernel.org
 S:	Maintained
 F:	drivers/vfio/pci/hisilicon/
 
+VFIO ISM PCI DRIVER
+M:	Julian Ruess <julianr@linux.ibm.com>
+L:	kvm@vger.kernel.org
+S:	Maintained
+F:	drivers/vfio/pci/ism/
+
 VFIO MEDIATED DEVICE DRIVERS
 M:	Kirti Wankhede <kwankhede@nvidia.com>
 L:	kvm@vger.kernel.org

-- 
2.51.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <linux-s390+bounces-16304-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id ymkjNhbejWnlzx8AYBR5ng
	(envelope-from <linux-s390+bounces-16304-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:05:10 +0000
Return-path: <linux-s390+bounces-16304-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:05:11 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <linux-s390+bounces-16304-hi=josie.lol@vger.kernel.org>)
	id 1vqXJe-00000008l4t-0yz7
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:05:10 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 01B9D314465F
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:02:48 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id F02A035CB78;
	Thu, 12 Feb 2026 14:02:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="L3AM24ab"
X-Original-To: linux-s390@vger.kernel.org
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D13D2253FF;
	Thu, 12 Feb 2026 14:02:42 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770904963; cv=none; b=TeKSKUhArUioBnpMQGDgdhzad7N39A/2+pChQ5jaMbVu23XTSiKSXs5l0wd6Kn+HnwrwSSQcE0MzQVIiDKDyi+EItF9IesXS10lOs+uBVhOEnQu7SpoM0vrZEOpfoD5BQxL8cG+Xk/UjCeNzLkSBPrIaAlKZ3GtwsRjcwxqBXqk=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770904963; c=relaxed/simple;
	bh=5AZMm4V6MtU6MB8nUvcHN5TD1MVWJkjfvrL/N7CjmDw=;
	h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
	 In-Reply-To:To:Cc; b=WgkX+s6n0PnV9cNWIW61OuDzdw/xPB/fiiIEiCv+WYRCBRT44DdRrP2o1sDcZ5xv3PWdqsDawypKFu2tnSWApOM+BO4oA+T7Bz4GJ2bVQGML8lUxEx3WD3DX+bdHJc81GUuQYF8qw4VXr/TPORRO9jxw7n3banGKGYftdekNmz0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=L3AM24ab; arc=none smtp.client-ip=148.163.156.1
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com
Received: from pps.filterd (m0356517.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61C5IqVt4037824;
	Thu, 12 Feb 2026 14:02:37 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc
	:content-transfer-encoding:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to; s=pp1; bh=qrHuk3
	GbFygxKt4he95bkyIYcNIcfCPYj1UQM6zkk6s=; b=L3AM24ab4hArYKgkIdokMb
	Tt2hSNS2bVZpyZJH48STxoAzR/2/JA6jxBwITxwDaN2cRuzWBEYt+RdrBtkQ6ddz
	zvEF9VCicdla5yD7hdFuMgZcFSJKCJmUE8Fbr0uH+0hwoaKRxIW+32/YjPdeuaYx
	HHunxKFppuTCzpEGRySUeIvS30Juf8C8N6qil3DUy+ffbZNRJ2zjdhY+EPbuhuOH
	KihyLC0B89roJyzLO+S9VUAzkpxxbEE24Ac9wBhMny3akkVDVYXI/3FSjLdMV5BA
	OIIsBT+Zyx7D5FDj5h+I/dL5TOIyDjSytVYlQQ7zOk8moplMojvS7fVCLhBXGYVQ
	==
Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])
	by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696upcmq-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 14:02:36 +0000 (GMT)
Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])
	by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 61CDSXvF001427;
	Thu, 12 Feb 2026 14:02:35 GMT
Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])
	by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6gqnapm3-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 14:02:35 +0000
Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103])
	by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 61CE2Vnc61735332
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
	Thu, 12 Feb 2026 14:02:31 GMT
Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id 7474420043;
	Thu, 12 Feb 2026 14:02:31 +0000 (GMT)
Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id 1BA3C2004E;
	Thu, 12 Feb 2026 14:02:31 +0000 (GMT)
Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9])
	by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP;
	Thu, 12 Feb 2026 14:02:31 +0000 (GMT)
From: Julian Ruess <julianr@linux.ibm.com>
Date: Thu, 12 Feb 2026 15:02:16 +0100
Subject: [PATCH 2/3] vfio/ism: Implement vfio_pci driver for ISM devices
Precedence: bulk
X-Mailing-List: linux-s390@vger.kernel.org
List-Id: <linux-s390.vger.kernel.org>
List-Subscribe: <mailto:linux-s390+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-s390+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20260212-vfio_pci_ism-v1-2-333262ade074@linux.ibm.com>
References: <20260212-vfio_pci_ism-v1-0-333262ade074@linux.ibm.com>
In-Reply-To: <20260212-vfio_pci_ism-v1-0-333262ade074@linux.ibm.com>
To: schnelle@linux.ibm.com, wintera@linux.ibm.com, ts@linux.ibm.com,
        oberpar@linux.ibm.com, gbayer@linux.ibm.com,
        Alex Williamson <alex@shazbot.org>, Jason Gunthorpe <jgg@ziepe.ca>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <skolothumtho@nvidia.com>,
        Kevin Tian <kevin.tian@intel.com>
Cc: mjrosato@linux.ibm.com, alifm@linux.ibm.com, raspl@linux.ibm.com,
        hca@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
        julianr@linux.ibm.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-pci@vger.kernel.org
X-Mailer: b4 0.14.2
X-TM-AS-GCONF: 00
X-Authority-Analysis: v=2.4 cv=YZiwJgRf c=1 sm=1 tr=0 ts=698ddd7c cx=c_pps
 a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17
 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22
 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8
 a=BIpM-4bQ8UbgmxpNPDoA:9 a=QEXdDO2ut3YA:10
X-Proofpoint-ORIG-GUID: ERovvUeSskgStJB7PvHRZFCqwA69ZSIP
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDEwNCBTYWx0ZWRfX/L09TJyZBo0q
 Cd2jH2HAjI0Hlpw8gj/8NTDXrHPlyLWjiTBBjmxSDQFFfFubwbky9Tv4U4NFBsVHVvJUGmSJeaO
 SuEgGoktfmDVfW1SGzUrbvv1lpkBZLqvJ5GmQO6f6WILUrEKRqv5VYlSt6l5rVk/L0DlqsHtf73
 Cd0tZ2q+XwTZixt4p8W/f144VL4ybYgkSJKp2J7Q4bFwJ4z2iLPS2H01fEDUKKr6O/5NtxMwlMy
 uBi2f98rX3Si5sVVc7rNBzold2vTWs/xIRyjgYHPTSF00FuyexofqKBs2tW3B6JrXKg1nlCH5hU
 Sqg8FPKpM3ywwLDf/TjYiqLABDmL5AqBCHhDw2WRNaumztZrL1s3oAnLNHCkq1Nn8yEth/CJcLg
 9CURfoPNQ5vlqlc5IqzhbEg6Uf3oZqfaglAx9DKhHBwm27qQjver0524W3VPw5pFIZZDmJUbJCU
 1Iqgu5q2R7fId3J1k/Q==
X-Proofpoint-GUID: ERovvUeSskgStJB7PvHRZFCqwA69ZSIP
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49
 definitions=2026-02-12_04,2026-02-12_02,2025-10-01_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 malwarescore=0
 phishscore=0 bulkscore=0 adultscore=0 clxscore=1011 lowpriorityscore=0
 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0
 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120104
X-DKIM: signer='ibm.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 5

Add a vfio_pci variant driver for the s390-specific Internal Shared
Memory (ISM) devices used for inter-VM communication.

This enables the development of vfio-pci-based user space drivers for
ISM devices.

On s390, kernel primitives such as ioread() and iowrite() are switched
over from function handle based PCI load/stores instructions to PCI
memory-I/O (MIO) loads/stores when these are available and not
explicitly disabled. Since these instructions cannot be used with ISM
devices, ensure that classic function handle-based PCI instructions are
used instead.

The driver is still required even when MIO instructions are disabled, as
the ISM device relies on the PCI store block (PCISTB) instruction to
perform write operations.

Stores are not fragmented, therefore one ioctl corresponds to exactly
one PCISTB instruction. User space must ensure to not write more than
4096 bytes at once to an ISM BAR which is the maximum payload of the
PCISTB instruction

Export vfio_pci_config_rw() for config space accesses that do not rely
on s390 MIO instructions.

Acked-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Julian Ruess <julianr@linux.ibm.com>
---
 drivers/vfio/pci/Kconfig           |   2 +
 drivers/vfio/pci/Makefile          |   2 +
 drivers/vfio/pci/ism/Kconfig       |  11 ++
 drivers/vfio/pci/ism/Makefile      |   3 +
 drivers/vfio/pci/ism/main.c        | 227 +++++++++++++++++++++++++++++++++++++
 drivers/vfio/pci/vfio_pci_config.c |   1 +
 6 files changed, 246 insertions(+)

diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig
index 1e82b44bda1a0a544e1add7f4b06edecf35aaf81..296bf01e185ecacc388ebc69e92706c99e47c814 100644
--- a/drivers/vfio/pci/Kconfig
+++ b/drivers/vfio/pci/Kconfig
@@ -60,6 +60,8 @@ config VFIO_PCI_DMABUF
 
 source "drivers/vfio/pci/mlx5/Kconfig"
 
+source "drivers/vfio/pci/ism/Kconfig"
+
 source "drivers/vfio/pci/hisilicon/Kconfig"
 
 source "drivers/vfio/pci/pds/Kconfig"
diff --git a/drivers/vfio/pci/Makefile b/drivers/vfio/pci/Makefile
index e0a0757dd1d2b0bc69b7e4d79441d5cacf4e1cd8..6138f1bf241df04e7419f196b404abdf9b194050 100644
--- a/drivers/vfio/pci/Makefile
+++ b/drivers/vfio/pci/Makefile
@@ -11,6 +11,8 @@ obj-$(CONFIG_VFIO_PCI) += vfio-pci.o
 
 obj-$(CONFIG_MLX5_VFIO_PCI)           += mlx5/
 
+obj-$(CONFIG_ISM_VFIO_PCI)           += ism/
+
 obj-$(CONFIG_HISI_ACC_VFIO_PCI) += hisilicon/
 
 obj-$(CONFIG_PDS_VFIO_PCI) += pds/
diff --git a/drivers/vfio/pci/ism/Kconfig b/drivers/vfio/pci/ism/Kconfig
new file mode 100644
index 0000000000000000000000000000000000000000..2db6c9327980827bf617afb9a82b1d1928868d42
--- /dev/null
+++ b/drivers/vfio/pci/ism/Kconfig
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: GPL-2.0
+config ISM_VFIO_PCI
+	tristate "VFIO support for ISM devices"
+	depends on ISM
+	select VFIO_PCI_CORE
+	help
+	  This provides user space support for
+	  IBM Internal Shared Memory (ISM) Adapter devices
+	  using the VFIO framework.
+
+	  If you don't know what to do here, say N.
diff --git a/drivers/vfio/pci/ism/Makefile b/drivers/vfio/pci/ism/Makefile
new file mode 100644
index 0000000000000000000000000000000000000000..32cc3c66dd11395da85a2b6f05b3d97036ed8a35
--- /dev/null
+++ b/drivers/vfio/pci/ism/Makefile
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_ISM_VFIO_PCI) += ism-vfio-pci.o
+ism-vfio-pci-y := main.o
diff --git a/drivers/vfio/pci/ism/main.c b/drivers/vfio/pci/ism/main.c
new file mode 100644
index 0000000000000000000000000000000000000000..99f27682ec16ec855ae12ff87059dbb1bc18c586
--- /dev/null
+++ b/drivers/vfio/pci/ism/main.c
@@ -0,0 +1,227 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * vfio-ISM driver for s390
+ *
+ * Copyright IBM Corp. 2026
+ */
+
+#include "../vfio_pci_priv.h"
+
+struct ism_vfio_pci_core_device {
+	struct vfio_pci_core_device core_device;
+};
+
+static int ism_pci_open_device(struct vfio_device *core_vdev)
+{
+	struct ism_vfio_pci_core_device *mvdev = container_of(
+		core_vdev, struct ism_vfio_pci_core_device, core_device.vdev);
+	struct vfio_pci_core_device *vdev = &mvdev->core_device;
+	int ret;
+
+	ret = vfio_pci_core_enable(vdev);
+	if (ret)
+		return ret;
+
+	vfio_pci_core_finish_enable(vdev);
+	return 0;
+}
+
+static ssize_t ism_vfio_pci_do_io_r(struct vfio_pci_core_device *vdev,
+				    char __user *buf, loff_t off, size_t count,
+				    int bar)
+{
+	struct zpci_dev *zdev = to_zpci(vdev->pdev);
+	ssize_t ret, done = 0;
+	u64 req, length, tmp;
+
+	while (count) {
+		if (count >= 8 && IS_ALIGNED(off, 8))
+			length = 8;
+		else if (count >= 4 && IS_ALIGNED(off, 4))
+			length = 4;
+		else if (count >= 2 && IS_ALIGNED(off, 2))
+			length = 2;
+		else
+			length = 1;
+		req = ZPCI_CREATE_REQ(READ_ONCE(zdev->fh), bar, length);
+		/* use pcilg to prevent using MIO instructions */
+		ret = __zpci_load(&tmp, req, off);
+		if (ret)
+			return ret;
+		if (copy_to_user(buf, &tmp, length))
+			return -EFAULT;
+		count -= length;
+		done += length;
+		off += length;
+		buf += length;
+	}
+	return done;
+}
+
+static ssize_t ism_vfio_pci_do_io_w(struct vfio_pci_core_device *vdev,
+				    char __user *buf, loff_t off, size_t count,
+				    int bar)
+{
+	struct zpci_dev *zdev = to_zpci(vdev->pdev);
+	void *data __free(kfree) = NULL;
+	ssize_t ret;
+	u64 req;
+
+	if (count > ZPCI_BOUNDARY_SIZE)
+		return -EINVAL;
+	data = kzalloc(ZPCI_BOUNDARY_SIZE, GFP_KERNEL);
+	if (!data)
+		return -ENOMEM;
+	if (copy_from_user(data, buf, count))
+		return -EFAULT;
+	req = ZPCI_CREATE_REQ(READ_ONCE(zdev->fh), bar, count);
+	ret = __zpci_store_block(data, req, off);
+	if (ret)
+		return ret;
+	return count;
+}
+
+static ssize_t ism_vfio_pci_bar_rw(struct vfio_pci_core_device *vdev,
+				   char __user *buf, size_t count, loff_t *ppos,
+				   bool iswrite)
+{
+	int bar = VFIO_PCI_OFFSET_TO_INDEX(*ppos);
+	loff_t pos = *ppos & VFIO_PCI_OFFSET_MASK;
+	resource_size_t end;
+	ssize_t done = 0;
+
+	if (pci_resource_start(vdev->pdev, bar))
+		end = pci_resource_len(vdev->pdev, bar);
+	else
+		return -EINVAL;
+
+	if (pos >= end)
+		return -EINVAL;
+
+	count = min(count, (size_t)(end - pos));
+
+	if (iswrite)
+		done = ism_vfio_pci_do_io_w(vdev, buf, pos, count, bar);
+	else
+		done = ism_vfio_pci_do_io_r(vdev, buf, pos, count, bar);
+
+	if (done >= 0)
+		*ppos += done;
+
+	return done;
+}
+
+static ssize_t ism_vfio_pci_rw(struct vfio_device *core_vdev, char __user *buf,
+			       size_t count, loff_t *ppos, bool iswrite)
+{
+	unsigned int index = VFIO_PCI_OFFSET_TO_INDEX(*ppos);
+	struct vfio_pci_core_device *vdev;
+	int ret;
+
+	vdev = container_of(core_vdev, struct vfio_pci_core_device, vdev);
+
+	if (!count)
+		return 0;
+
+	switch (index) {
+	case VFIO_PCI_CONFIG_REGION_INDEX:
+		ret = vfio_pci_config_rw(vdev, buf, count, ppos, iswrite);
+		break;
+
+	case VFIO_PCI_BAR0_REGION_INDEX ... VFIO_PCI_BAR5_REGION_INDEX:
+		ret = ism_vfio_pci_bar_rw(vdev, buf, count, ppos, iswrite);
+		break;
+
+	default:
+		return -EINVAL;
+	}
+
+	return ret;
+}
+
+static ssize_t ism_vfio_pci_read(struct vfio_device *core_vdev,
+				 char __user *buf, size_t count, loff_t *ppos)
+{
+	return ism_vfio_pci_rw(core_vdev, buf, count, ppos, false);
+}
+
+static ssize_t ism_vfio_pci_write(struct vfio_device *core_vdev,
+				  const char __user *buf, size_t count,
+				  loff_t *ppos)
+{
+	return ism_vfio_pci_rw(core_vdev, (char __user *)buf, count, ppos,
+			       true);
+}
+
+static const struct vfio_device_ops ism_pci_ops = {
+	.name = "ism-vfio-pci",
+	.init = vfio_pci_core_init_dev,
+	.release = vfio_pci_core_release_dev,
+	.open_device = ism_pci_open_device,
+	.close_device = vfio_pci_core_close_device,
+	.ioctl = vfio_pci_core_ioctl,
+	.get_region_info_caps = vfio_pci_ioctl_get_region_info,
+	.device_feature = vfio_pci_core_ioctl_feature,
+	.read = ism_vfio_pci_read,
+	.write = ism_vfio_pci_write,
+	.request = vfio_pci_core_request,
+	.match = vfio_pci_core_match,
+	.match_token_uuid = vfio_pci_core_match_token_uuid,
+	.bind_iommufd = vfio_iommufd_physical_bind,
+	.unbind_iommufd = vfio_iommufd_physical_unbind,
+	.attach_ioas = vfio_iommufd_physical_attach_ioas,
+	.detach_ioas = vfio_iommufd_physical_detach_ioas,
+
+};
+
+static int ism_vfio_pci_probe(struct pci_dev *pdev,
+			      const struct pci_device_id *id)
+{
+	struct ism_vfio_pci_core_device *ivpcd;
+	int ret;
+
+	ivpcd = vfio_alloc_device(ism_vfio_pci_core_device, core_device.vdev,
+				  &pdev->dev, &ism_pci_ops);
+	if (IS_ERR(ivpcd))
+		return PTR_ERR(ivpcd);
+
+	dev_set_drvdata(&pdev->dev, &ivpcd->core_device);
+	ret = vfio_pci_core_register_device(&ivpcd->core_device);
+	if (ret)
+		vfio_put_device(&ivpcd->core_device.vdev);
+	return ret;
+}
+
+static void ism_vfio_pci_remove(struct pci_dev *pdev)
+{
+	struct vfio_pci_core_device *core_device;
+	struct ism_vfio_pci_core_device *ivpcd;
+
+	core_device = dev_get_drvdata(&pdev->dev);
+	ivpcd = container_of(core_device, struct ism_vfio_pci_core_device,
+			     core_device);
+
+	vfio_pci_core_unregister_device(&ivpcd->core_device);
+	vfio_put_device(&ivpcd->core_device.vdev);
+}
+
+static const struct pci_device_id ism_device_table[] = {
+	{ PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_IBM,
+					  PCI_DEVICE_ID_IBM_ISM) },
+	{}
+};
+MODULE_DEVICE_TABLE(pci, ism_device_table);
+
+static struct pci_driver ism_vfio_pci_driver = {
+	.name = KBUILD_MODNAME,
+	.id_table = ism_device_table,
+	.probe = ism_vfio_pci_probe,
+	.remove = ism_vfio_pci_remove,
+	.driver_managed_dma = true,
+};
+
+module_pci_driver(ism_vfio_pci_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("vfio-pci variant driver for the IBM Internal Shared Memory (ISM) device");
+MODULE_AUTHOR("IBM Corporation");
diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
index dc4e510e6e1bf4753e1d9005e0054399a639ea12..c7341a2d072b058965135a3d225894d74379e12e 100644
--- a/drivers/vfio/pci/vfio_pci_config.c
+++ b/drivers/vfio/pci/vfio_pci_config.c
@@ -1995,6 +1995,7 @@ ssize_t vfio_pci_config_rw(struct vfio_pci_core_device *vdev, char __user *buf,
 
 	return done;
 }
+EXPORT_SYMBOL(vfio_pci_config_rw);
 
 /**
  * vfio_pci_core_range_intersect_range() - Determine overlap between a buffer

-- 
2.51.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <linux-s390+bounces-16305-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id aOADCXTejWmJAyAAYBR5ng
	(envelope-from <linux-s390+bounces-16305-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:06:44 +0000
Return-path: <linux-s390+bounces-16305-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:06:44 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <linux-s390+bounces-16305-hi=josie.lol@vger.kernel.org>)
	id 1vqXL9-00000008ntL-3DnT
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:06:44 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 850923191173
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:02:55 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C1C635CB61;
	Thu, 12 Feb 2026 14:02:48 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="cEACVcTX"
X-Original-To: linux-s390@vger.kernel.org
Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CB10346E5A;
	Thu, 12 Feb 2026 14:02:46 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770904968; cv=none; b=JcSF1jCovJhAyUriQzuec00bo3AHnXkklUuT80x+NzoHFFhZsDg7Oduh09LlflYL9oypKiWjdTbyVdMOJ3XaGtUV1pTKAss2hmFNxQtJBj3fxolFvaRRPQG5ujTXubkQD/AaKF+y4E57IIajInEhxOks4if2JaFbEbtwn0CL2EA=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770904968; c=relaxed/simple;
	bh=R9x5Z5Kah0FOwz+XsjqJAfOjK2AVQJPUaRi3J+mut2Q=;
	h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
	 In-Reply-To:To:Cc; b=UhtGp7e1vEMWp6RwpA+Tn0/iqW9p3T63v8sJ88RWYptkABjf8rgqGqRqafn8P7h9ReHRgLG26GaSHj31JZHQDhQCaEFpfCfEqhj4HtCIwEyXrTq5CA1KsFlmUt/NQcQT4Lw1oFyn8vlh9oUEnMpOdH82hFcgEVS0Nssjz3Axkt0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=cEACVcTX; arc=none smtp.client-ip=148.163.158.5
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com
Received: from pps.filterd (m0353725.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61CDOJAL3414107;
	Thu, 12 Feb 2026 14:02:35 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc
	:content-transfer-encoding:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to; s=pp1; bh=mhB6RF
	oPQK8dVzbsRqsEX6IfqiK9Fcw9WsnO2/SS6IQ=; b=cEACVcTXq43FhjX/ng0t5b
	pdozQtOsmKEx06Qq7i3e1Hfgu4dUxWBNVckEBry9nbHhFW28uDgBRJH8trgJXrde
	7y4Y+EZrAp0UVy7MyVrODW1uDkmYKCjLBJQveBzrdHImRQffBHkJOFpwjhHGuJB6
	SiD62Sah/l7Db3TnixotSjlZZN03A0UZh66pp8Ydrk7AGUbSLWLfTEDv9CEje7Gn
	1k9SRfaNEX+Bk+WfNzhRAsyFlb8QZUU/ujhUU4f1kyoNyHG1mVQXTDjzjQUXqmcA
	9ymprvZKNPZ2Odup4sbRYIqJtxlmda+PQMd38BYIBc+541gH2z9zDd6rzYQiIASQ
	==
Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])
	by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696vbmvc-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 14:02:35 +0000 (GMT)
Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])
	by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 61C9goXG001837;
	Thu, 12 Feb 2026 14:02:34 GMT
Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])
	by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4c6je2ad0b-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Feb 2026 14:02:34 +0000
Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103])
	by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 61CE2VSD61669798
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
	Thu, 12 Feb 2026 14:02:31 GMT
Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id 0C62A20043;
	Thu, 12 Feb 2026 14:02:31 +0000 (GMT)
Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id BF5F22005A;
	Thu, 12 Feb 2026 14:02:30 +0000 (GMT)
Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9])
	by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP;
	Thu, 12 Feb 2026 14:02:30 +0000 (GMT)
From: Julian Ruess <julianr@linux.ibm.com>
Date: Thu, 12 Feb 2026 15:02:15 +0100
Subject: [PATCH 1/3] vfio/pci: Set VFIO_PCI_OFFSET_SHIFT to 48
Precedence: bulk
X-Mailing-List: linux-s390@vger.kernel.org
List-Id: <linux-s390.vger.kernel.org>
List-Subscribe: <mailto:linux-s390+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-s390+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20260212-vfio_pci_ism-v1-1-333262ade074@linux.ibm.com>
References: <20260212-vfio_pci_ism-v1-0-333262ade074@linux.ibm.com>
In-Reply-To: <20260212-vfio_pci_ism-v1-0-333262ade074@linux.ibm.com>
To: schnelle@linux.ibm.com, wintera@linux.ibm.com, ts@linux.ibm.com,
        oberpar@linux.ibm.com, gbayer@linux.ibm.com,
        Alex Williamson <alex@shazbot.org>, Jason Gunthorpe <jgg@ziepe.ca>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <skolothumtho@nvidia.com>,
        Kevin Tian <kevin.tian@intel.com>
Cc: mjrosato@linux.ibm.com, alifm@linux.ibm.com, raspl@linux.ibm.com,
        hca@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
        julianr@linux.ibm.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-pci@vger.kernel.org
X-Mailer: b4 0.14.2
X-TM-AS-GCONF: 00
X-Proofpoint-GUID: fv3arNPVHzcKc8BmdOyKW6B-d1ksJ0l7
X-Proofpoint-ORIG-GUID: fv3arNPVHzcKc8BmdOyKW6B-d1ksJ0l7
X-Authority-Analysis: v=2.4 cv=JdWxbEKV c=1 sm=1 tr=0 ts=698ddd7b cx=c_pps
 a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17
 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22
 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8
 a=modniqXMBZv9BQ1X5YgA:9 a=QEXdDO2ut3YA:10
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDEwNCBTYWx0ZWRfXwLduAeLBOgD0
 s7s1iJarvhbtDEp0HnZR88d8BWjr8OcFYH14Drr2PlzcDTfIQVw8qCjY8K6VaacbxG84SVjxBTD
 M40uX2I35PMDxk1nHEN8ELesZsYrOGnh9C6acIFvUZgk0h+psJ5oNH7WOzReqNmu/qfz5KExg3X
 paJv6mtOkUkLin6zGiPXyNmGa9UneXA7YWF+Jznknv0F8H8u9gF+ZBY65fjOPKu7uZgq/dAYV6o
 TdQrSeobKEbgmcSndVe+0wDaey5LE2QajnfS73DyjmX+BCZHS47l5gaESjH8nHwXlrHQVpDi3lN
 0vB3a3HYn8Yg2fqj2LHu2X+a4yU9hbc9TNwG76i/ZnbS8K6VqV9xwImeWay1+rOkaAgnX9Us5qB
 vVVnxAK7HnU4Lg1gH4KfiOzaENgQYJmdAsSlb3LUFOdA+mHnnDsv5g4KuiT+1zle0gem50pu/zN
 uP3yPyXLq6WWyPjYV5A==
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49
 definitions=2026-02-12_04,2026-02-12_02,2025-10-01_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 priorityscore=1501 clxscore=1011 impostorscore=0 bulkscore=0
 lowpriorityscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0
 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc=
 route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000
 definitions=main-2602120104
X-DKIM: signer='ibm.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 5

Extend VFIO_PCI_OFFSET_SHIFT to 48 to use the vfio-pci
VFIO_PCI_OFFSET_TO_INDEX() mechanism with the 256 TiB pseudo-BAR 0 of
the ISM device on s390. This bar is never mapped.

Acked-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Julian Ruess <julianr@linux.ibm.com>
---
 drivers/vfio/pci/vfio_pci_core.c | 4 ++--
 include/linux/vfio_pci_core.h    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
index 3a11e6f450f70105f17a3a621520c195d99e0671..3d70bf6668c7a69c4b46674195954d1ada662006 100644
--- a/drivers/vfio/pci/vfio_pci_core.c
+++ b/drivers/vfio/pci/vfio_pci_core.c
@@ -1647,7 +1647,7 @@ static unsigned long vma_to_pfn(struct vm_area_struct *vma)
 	u64 pgoff;
 
 	pgoff = vma->vm_pgoff &
-		((1U << (VFIO_PCI_OFFSET_SHIFT - PAGE_SHIFT)) - 1);
+		((1UL << (VFIO_PCI_OFFSET_SHIFT - PAGE_SHIFT)) - 1);
 
 	return (pci_resource_start(vdev->pdev, index) >> PAGE_SHIFT) + pgoff;
 }
@@ -1751,7 +1751,7 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma
 	phys_len = PAGE_ALIGN(pci_resource_len(pdev, index));
 	req_len = vma->vm_end - vma->vm_start;
 	pgoff = vma->vm_pgoff &
-		((1U << (VFIO_PCI_OFFSET_SHIFT - PAGE_SHIFT)) - 1);
+		((1UL << (VFIO_PCI_OFFSET_SHIFT - PAGE_SHIFT)) - 1);
 	req_start = pgoff << PAGE_SHIFT;
 
 	if (req_start + req_len > phys_len)
diff --git a/include/linux/vfio_pci_core.h b/include/linux/vfio_pci_core.h
index 1ac86896875cf5c9b5cc8ef25fae8bbd4394de05..12781707f086a330161990dc3579ec0d75887da8 100644
--- a/include/linux/vfio_pci_core.h
+++ b/include/linux/vfio_pci_core.h
@@ -20,7 +20,7 @@
 #ifndef VFIO_PCI_CORE_H
 #define VFIO_PCI_CORE_H
 
-#define VFIO_PCI_OFFSET_SHIFT   40
+#define VFIO_PCI_OFFSET_SHIFT   48
 #define VFIO_PCI_OFFSET_TO_INDEX(off)	(off >> VFIO_PCI_OFFSET_SHIFT)
 #define VFIO_PCI_INDEX_TO_OFFSET(index)	((u64)(index) << VFIO_PCI_OFFSET_SHIFT)
 #define VFIO_PCI_OFFSET_MASK	(((u64)(1) << VFIO_PCI_OFFSET_SHIFT) - 1)

-- 
2.51.0



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215965-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id METBOF3gjWmJAyAAYBR5ng
	(envelope-from <stable+bounces-215965-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:14:53 +0000
Return-path: <stable+bounces-215965-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:14:54 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215965-hi=josie.lol@vger.kernel.org>)
	id 1vqXT3-000000093oL-2fOx
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:14:53 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 59C353038AE6
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:14:52 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id C1F5D35CB6C;
	Thu, 12 Feb 2026 14:14:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qD++ga1E"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90EA835B65E;
	Thu, 12 Feb 2026 14:14:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770905691; cv=none; b=WflAsCslXjEe6GQz8rQ+tTm23sGvPCUg4ym3XL8xJoBDPzum2lYvukPHjyZkeEbXPu9deyrX41zhT4uJvKyYk+FzF5z2NlhoqbllcFKloOEn1S3dz0lKyGyhYW7iTFr1Lm5dNqkGZeTf8tT33MEHMU2V7VEkd4k8205HjA7JYss=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770905691; c=relaxed/simple;
	bh=5iN4Au8UeMri4/4aTlWwZL5atQwbRH8ebxaQUHqwz2s=;
	h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version:
	 Content-Type; b=K6QkPCH71eFlJvi57SjkTX6NmAq168amWQixxPJ18dt/5xoy3w2B4LH6E1jUwrr+sEAN75J0mxBholO1J+gIjt0eaig+iZ3Yzm12D4ZRObXvDbgceKmdcUijoMforUWgJ4+zss+ocT5Hb4eT9gYLjhWNNuBc5gmK6GoQ2voxMSw=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qD++ga1E; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F1A3C19425;
	Thu, 12 Feb 2026 14:14:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770905691;
	bh=5iN4Au8UeMri4/4aTlWwZL5atQwbRH8ebxaQUHqwz2s=;
	h=Date:From:To:Cc:Subject:References:From;
	b=qD++ga1EipNku49K9KDr4FwpMMGbM/xHHR98ZELglWNTXuOT/WecTQeGk6/H5BI5U
	 Y0ZKPNWk8X1oH/sYfomyZNBbdId643Ce86MAkJYdQn9fXNQHMo7GKhUQYM4PZN7yqV
	 qpRqCOuvr01xHgWXZ35EK0njz4r58qDEH74S3BiNwuhJvxKQSF+4uoNiu3Y2Kacyv6
	 97q46v+9M/h/vad5SGTcTv1XT7y2VhdvAsBn/OUbCWNAunpX5k043hJE/ubeUQLg7B
	 DxpS+e7T74rLHcNCTone/XlxYwZXOr/6aBmfqxNwaFF+B4t+9MTuI6Jk7nMQp5Ch0C
	 704QwXX0xNKOA==
Received: from rostedt by gandalf with local (Exim 4.99.1)
	(envelope-from <rostedt@kernel.org>)
	id 1vqXT0-000000002mM-2XMg;
	Thu, 12 Feb 2026 09:14:50 -0500
Message-ID: <20260212141450.462148762@kernel.org>
User-Agent: quilt/0.69
Date: Thu, 12 Feb 2026 09:14:35 -0500
From: Steven Rostedt <rostedt@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 stable@vger.kernel.org
Subject: [for-next][PATCH 2/3] tracing: Reset last_boot_info if ring buffer is reset
References: <20260212141433.849771751@kernel.org>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: msgid.link]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>

Commit 32dc0042528d ("tracing: Reset last-boot buffers when reading
out all cpu buffers") resets the last_boot_info when user read out
all data via trace_pipe* files. But it is not reset when user
resets the buffer from other files. (e.g. write `trace` file)

Reset it when the corresponding ring buffer is reset too.

Cc: stable@vger.kernel.org
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/177071302364.2293046.17895165659153977720.stgit@mhiramat.tok.corp.google.com
Fixes: 32dc0042528d ("tracing: Reset last-boot buffers when reading out all cpu buffers")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 kernel/trace/trace.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index fd470675809b..e884d32b7895 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -4127,6 +4127,8 @@ static int tracing_single_release_tr(struct inode *inode, struct file *file)
 	return single_release(inode, file);
 }
 
+static bool update_last_data_if_empty(struct trace_array *tr);
+
 static int tracing_open(struct inode *inode, struct file *file)
 {
 	struct trace_array *tr = inode->i_private;
@@ -4151,6 +4153,8 @@ static int tracing_open(struct inode *inode, struct file *file)
 			tracing_reset_online_cpus(trace_buf);
 		else
 			tracing_reset_cpu(trace_buf, cpu);
+
+		update_last_data_if_empty(tr);
 	}
 
 	if (file->f_mode & FMODE_READ) {
@@ -5215,6 +5219,7 @@ tracing_set_trace_read(struct file *filp, char __user *ubuf,
 int tracer_init(struct tracer *t, struct trace_array *tr)
 {
 	tracing_reset_online_cpus(&tr->array_buffer);
+	update_last_data_if_empty(tr);
 	return t->init(tr);
 }
 
@@ -7028,6 +7033,7 @@ int tracing_set_clock(struct trace_array *tr, const char *clockstr)
 		ring_buffer_set_clock(tr->snapshot_buffer.buffer, trace_clocks[i].func);
 	tracing_reset_online_cpus(&tr->snapshot_buffer);
 #endif
+	update_last_data_if_empty(tr);
 
 	if (tr->scratch && !(tr->flags & TRACE_ARRAY_FL_LAST_BOOT)) {
 		struct trace_scratch *tscratch = tr->scratch;
-- 
2.51.0




From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215966-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id GAQuBl7gjWk64CAAYBR5ng
	(envelope-from <stable+bounces-215966-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:14:54 +0000
Return-path: <stable+bounces-215966-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:14:54 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215966-hi=josie.lol@vger.kernel.org>)
	id 1vqXT3-000000093oN-3FAu
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:14:54 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 991863043D02
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:14:52 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id C98DF35CB70;
	Thu, 12 Feb 2026 14:14:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U6+72HzA"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90F7E35CB69;
	Thu, 12 Feb 2026 14:14:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770905691; cv=none; b=sS8d/Tj+cKNhAKGVOW75M8dA0lsDu3wQkJyGQaFaNG/xsBzSh0bVXZVj4oDmFXKjTVP1pas5i4BQX5ohyrYda01fb+IYFxQsnV46KIZwHm7zZInGQVwYVo7tfmLOygeV9IPnZK+uMPiYQbdD5zuLWIrPQDAifrkh1EZTGlj0WkE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770905691; c=relaxed/simple;
	bh=RdzQsLETYKvlriLm/NMGW7KYXfnHS0fq0aSeOOeoJXM=;
	h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version:
	 Content-Type; b=Hha+tGHRoOjxV197JIAe5QNS+J7FNkP8d6LYeCyQNTOptIf6rDiKONaSjKMDshVltqGaql8ctv5xy0rLUwi/ZuieSTgIVj1QNqlTttdIinEWjCjZmRti5333jJtqXxzWG/ArCytY5XTWI/OZa3voHPSBUGHPHyttlmb4efGYDVI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U6+72HzA; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42A82C16AAE;
	Thu, 12 Feb 2026 14:14:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770905691;
	bh=RdzQsLETYKvlriLm/NMGW7KYXfnHS0fq0aSeOOeoJXM=;
	h=Date:From:To:Cc:Subject:References:From;
	b=U6+72HzAW8FxFV6oUXlwSZk2p48eMlFl3nXeoy38Tj5xmoYh2SkIijLNBHo9lKnFC
	 /nQhQSLw0DC9KoLy8ndz6ZAT8ms2208rxf4RnObv37l3QNmrEUpYQYfTLEvH4RxvmS
	 myEitn3p35eyio47PqLzx5M9TMX7n+FdLRkhRjGpLYfjXW1NN8arvxmR8bKdtFcT9/
	 cdv51Kyoio1vOzu5v3V7sUH3C9DenPz+Gs8VQd5KG/hUg5XfnGzOM7ldH6Nc81Osuk
	 IL+QkGMQZFRhwfdfDSGVO3/ANwUrO6ljO3n8ufFj/XRdb0+x40zcjq1BmAGqg1QnSV
	 Z6ak7yDdnWhCQ==
Received: from rostedt by gandalf with local (Exim 4.99.1)
	(envelope-from <rostedt@kernel.org>)
	id 1vqXT0-000000002lq-1q1L;
	Thu, 12 Feb 2026 09:14:50 -0500
Message-ID: <20260212141450.296763331@kernel.org>
User-Agent: quilt/0.69
Date: Thu, 12 Feb 2026 09:14:34 -0500
From: Steven Rostedt <rostedt@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 stable@vger.kernel.org
Subject: [for-next][PATCH 1/3] tracing: Fix to set write permission to per-cpu buffer_size_kb
References: <20260212141433.849771751@kernel.org>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: msgid.link]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>

Since the per-cpu buffer_size_kb file is writable for changing
per-cpu ring buffer size, the file should have the write access
permission.

Cc: stable@vger.kernel.org
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/177071301597.2293046.11683339475076917920.stgit@mhiramat.tok.corp.google.com
Fixes: 21ccc9cd7211 ("tracing: Disable "other" permission bits in the tracefs files")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 kernel/trace/trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 845b8a165daf..fd470675809b 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -8613,7 +8613,7 @@ tracing_init_tracefs_percpu(struct trace_array *tr, long cpu)
 	trace_create_cpu_file("stats", TRACE_MODE_READ, d_cpu,
 				tr, cpu, &tracing_stats_fops);
 
-	trace_create_cpu_file("buffer_size_kb", TRACE_MODE_READ, d_cpu,
+	trace_create_cpu_file("buffer_size_kb", TRACE_MODE_WRITE, d_cpu,
 				tr, cpu, &tracing_entries_fops);
 
 	if (tr->range_addr_start)
-- 
2.51.0




From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215967-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id oL/aOJ7gjWk64CAAYBR5ng
	(envelope-from <stable+bounces-215967-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:15:58 +0000
Return-path: <stable+bounces-215967-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:15:59 +0000
Received: from sin.lore.kernel.org ([104.64.211.4])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215967-hi=josie.lol@vger.kernel.org>)
	id 1vqXU6-000000096T5-17tJ
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:15:58 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sin.lore.kernel.org (Postfix) with ESMTP id A272E301112D
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:15:54 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 0C38C3446C7;
	Thu, 12 Feb 2026 14:15:52 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kV2FfyLF";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="SNTfS508"
X-Original-To: stable@vger.kernel.org
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2E9135C195;
	Thu, 12 Feb 2026 14:15:50 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770905751; cv=none; b=had/W5Yz0W2FCPxefUuZGtpIrkrFVaDvUELTCa2jyxw32h9R23b55KMxAwLsW+WxRHmdTOQzxhKDGleqgmwTbpcBSm4pTJ5SR4NrKNJmLTrdiepThdbQmmoAnuAv7CIKjszVtQ4vDPhyNh+K+fhguRCTfFxutKb3aqR3vEdNPDg=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770905751; c=relaxed/simple;
	bh=gnLi+fuwVc80Hws1ypjaoVAMN8fcMyt+Z9AHpTiifaA=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=NOeyNvYXg1L99JQTsf+zJJECwaB0E+KCOocG0pAz10gj5iyJL4iot49zW2YxRWO90WWWPlGYem3LQEz4ZSm/vq3GFGejlWsm5NCzcqadeKzGhMH362axOIZlZzP1Az/qBdOK2HuKeFwHxij3rXFHkLuPQaJ7ZIFZ7x5Lqh1rQGI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=kV2FfyLF; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=SNTfS508; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Date: Thu, 12 Feb 2026 15:15:47 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1770905748;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FGnSLeUOBXf3YTe9/pZ2XFDqnrXb22gN1IA8GUBKIF0=;
	b=kV2FfyLFvxzUiLxZIDc1rXhMa/q1NAgQ2IV2kRi4pyT5fik+nON9jQdF1uktTYjK8Ms5KV
	PTJiOobL1ocNJtgBHbvcnksAMgbs0rWAUIFIfoFzTqgWflDTtsiPEQKIuN9Syw8QeTOAo5
	gXkbt6VPh5n2Gwio4bavb2UyxIYvJJUokdf3ByllYPNBjUdaAhIjHqD+s3lVkTS9P6RTjU
	9IaSNdWuZ7FUBov43Ov4uALRLkgZLxXNm6AT5dcewZ+X9Jkdv8m7ToRrn6NZHNd0hTuKI9
	fshvIprrTjO4WOZNQMEsMS1+yVzfdr6pINkBi7ZTk0JiM9oSOlA/IPm+wD4lgA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1770905748;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FGnSLeUOBXf3YTe9/pZ2XFDqnrXb22gN1IA8GUBKIF0=;
	b=SNTfS508eo039k6DAqLb+es3qExnFdWG1e+59if/uJ3H/cw+an400Lay/oIaGQxEiYHZEC
	3Q/txxZLR1t5gRAw==
From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>
To: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= <mic@digikod.net>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, 
	kernel-team@cloudflare.com, Nathan Chancellor <nathan@kernel.org>, 
	Nicolas Schier <nsc@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH v1] kbuild: Fix CC_CAN_LINK detection
Message-ID: <20260212151347-6f19b408-f22b-4ecb-9ce5-bd4e01e06743@linutronix.de>
References: <20260212133544.1331437-1-mic@digikod.net>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20260212133544.1331437-1-mic@digikod.net>
X-DKIM: signer='linutronix.de' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [104.64.211.4 listed in list.dnswl.org]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On Thu, Feb 12, 2026 at 02:35:43PM +0100, Mickaël Salaün wrote:
> Most samples cannot be build on some environments because they depend
> on CC_CAN_LINK, which is set according to the result of
> scripts/cc-can-link.sh called by cc_can_link_user.
> 
> Because cc-can-link.sh must now build without warning, it may fail
> because it is calling printf() with an empty string:
> 
>   + cat
>   + gcc -m32 -Werror -Wl,--fatal-warnings -x c - -o /dev/null
>   <stdin>: In function ‘main’:
>   <stdin>:4:9: error: zero-length gnu_printf format string [-Werror=format-zero-length]
>   cc1: all warnings being treated as errors
> 
> Fix this warning and the samples build by actually printing something.
> 
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nicolas Schier <nsc@kernel.org>
> Cc: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> Cc: stable@vger.kernel.org
> Fixes: d81d9d389b9b ("kbuild: don't enable CC_CAN_LINK if the dummy program generates warnings")

Thanks!

Reviewed-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

In my GCC 15.2 this warning is not enabled by default.

> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> ---
>  scripts/cc-can-link.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/cc-can-link.sh b/scripts/cc-can-link.sh
> index e67fd8d7b684..58dc7dd6d556 100755
> --- a/scripts/cc-can-link.sh
> +++ b/scripts/cc-can-link.sh
> @@ -5,7 +5,7 @@ cat << "END" | $@ -Werror -Wl,--fatal-warnings -x c - -o /dev/null >/dev/null 2>
>  #include <stdio.h>
>  int main(void)
>  {
> -	printf("");
> +	printf("\n");
>  	return 0;
>  }
>  END
> -- 
> 2.53.0
> 


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <linux-s390+bounces-16306-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id uI8eIQrhjWnBSR8AYBR5ng
	(envelope-from <linux-s390+bounces-16306-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:17:46 +0000
Return-path: <linux-s390+bounces-16306-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:17:46 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <linux-s390+bounces-16306-hi=josie.lol@vger.kernel.org>)
	id 1vqXVp-00000009Ag2-3W9L
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:17:46 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 0C6A93024A28
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:17:45 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 1AEAD35B642;
	Thu, 12 Feb 2026 14:17:42 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Q3uRx0oV"
X-Original-To: linux-s390@vger.kernel.org
Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04E2261573
	for <linux-s390@vger.kernel.org>; Thu, 12 Feb 2026 14:17:40 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770905862; cv=none; b=UE/Zdq7SagsQwUvlyVJ2HNkECdw3TjRl/0yj8+lqiGYUIBNpXQfhd9+6e+UIaNmDBL5Aj5AvXtkf+qHn9WdrM1dPSkReEWh9bfyNbqLr/ykY16XuL2hiAZcTmk5SOLmc/LwJ5h8jVCTTdktwXOMJD34j1V5TkVovqxy0w7ohPAM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770905862; c=relaxed/simple;
	bh=3b3igbvjtC6TzOflHJmS47zTEL8ymbacN0YsKIuJxWU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=KMVkWiTj8N2h6bKGBRzQ/ShHWRkw/w/d5G+QLs6SkvqbaSaWlY6xllJhVe1WEASOfRMQ6ZJR68Unf/GDSU7JNIW2wasavJT0Ss/KggR8LYOF3RXB1EkU+P3izXM8hCXDVkxmmOLVI8uL2MvaHBJh3tlesgL65oBEMjliLv7iAmg=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Q3uRx0oV; arc=none smtp.client-ip=209.85.222.177
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca
Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8c5384ee23fso696291985a.1
        for <linux-s390@vger.kernel.org>; Thu, 12 Feb 2026 06:17:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=ziepe.ca; s=google; t=1770905860; x=1771510660; darn=vger.kernel.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=3b3igbvjtC6TzOflHJmS47zTEL8ymbacN0YsKIuJxWU=;
        b=Q3uRx0oVkpBtjZMZbSndCvl0/QfZMt7MAbI3D53Txnr5ruSGu9lv2TFV5MAf2viUVP
         DBTTpZdyOU0CG9x13bvE8QdJ1Ws1qPBvvtbXzd3CGRZ/jPPL8wabZgieEAYpzhRGMF/O
         YPNOJTeSNw+dkZ/VtglpsW0d50nHTNJyHM+tyGNLHF+MRSikENW+5UT0wSzONaWcbioI
         0ySfyGpJ+0eaQEwRJrsNaAljb6ddCr+R4BrrICxJgWeaY8Ja6zeTgfwm7v9Cn/dmSKsy
         uuMMALbstQPH3dip8zt8iFv9o1DHdy4Mq3g+Srd2i9qde8R7TpaO/L1Q3TtoJxdNPstJ
         IS9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770905860; x=1771510660;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=3b3igbvjtC6TzOflHJmS47zTEL8ymbacN0YsKIuJxWU=;
        b=aKFVoGLV4wQdYNYq7GLmOsrhtGqLK6vCrcxr7aZxrfwGhjQ52W3CdG/gbycrwbGyYl
         utzqRL02rWH4Q1McuQj0sZ2VXB841t8A7K2jXLbYXSkT+vFE+LgNNJZzUO6Q6F/Ma8Vs
         jnGbEm6GyH3Ddmx248lICd56V1JX8UF2vqXM5jeMNgWZZdH2Fq1vq9hQpUChv6F5msiE
         c6O8ksmpyY8dQ5QmSnD580HRA/U7BiuGVKYVV7geIHw33JK4CeH/H69Nbt0y4g7CEJLL
         C/OeDb1wtQzAUpMzkqi+VAqOyJNZ7vRyBBXfmLIRkT3V6k7IdbOngjP29Q2FNiEE9RJB
         rGyw==
X-Forwarded-Encrypted: i=1; AJvYcCVGA0PrbiIqZpPtlFT4Yw8zX5voJaT8A4Xjg36C2fY/gAIKbxV/D2NAWKqZHjEbCGcI51j0ga4H09KZ@vger.kernel.org
X-Gm-Message-State: AOJu0YzSv/dd0Rt0uDIhdmMKPzrm2rKi8BY0v08vkvhMdKWugxv9r8/2
	MK8GvsTtf1Ig+nbsHNt877x3B6ZOD4tF06PCbUBWanndIFgnAL9XRJJIZm7pCvsT91A=
X-Gm-Gg: AZuq6aLsjTUUEWanLUHuHbYGKXJVOltiCfUDoVHzMEAgE0fj91i5enNDPd05D45lvpn
	gVXjMBlt80hx+5Gm4pI8LjjwVoAq2eZeUq9h5erGZB0wNTY2WdCHF+XWfpdUyw7B5xW2YPGdoFQ
	0mz8L+jhFOoYzXKgQdwGHPmdImeXdnFVn7CpghkCcNI9AMC6jMpJzUl0UpUF/FGeDK8y8DmzyhG
	qTs5pi/dwd2iTPxFM+xrmwuYoc4xGwx/InEiooxAOz4dWfXETs6qtbQ4cvV8fbtxbQS6oJ+aTg0
	hIFSbfhyA6PwslAZY0k8u9q4rIzZRNchyg89Fx6ub1CW6+P7woqAkQ3E4aHRtERfmON12LCZcu2
	OcbLSHRZRNHrID/ryLKB1mUrwlDd4qry5cc53RQmXDtA4hb1pPA/erBJsT+h4USbjKKqS8I4B4n
	qVUumZ4f/K+6EaWiJxk5A07w5svNz46jLhloYBay/zY6cxUNpHvPcuPhOWKUZ0Kd2YbZfUheBEG
	RPjpIc=
X-Received: by 2002:a05:6214:b6d:b0:888:4939:c29 with SMTP id 6a1803df08f44-89727b28033mr38655036d6.71.1770905859509;
        Thu, 12 Feb 2026 06:17:39 -0800 (PST)
Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119])
        by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8971cddb9efsm45048286d6.51.2026.02.12.06.17.38
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 12 Feb 2026 06:17:38 -0800 (PST)
Received: from jgg by wakko with local (Exim 4.97)
	(envelope-from <jgg@ziepe.ca>)
	id 1vqXVi-000000013HU-0xrD;
	Thu, 12 Feb 2026 10:17:38 -0400
Date: Thu, 12 Feb 2026 10:17:38 -0400
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Julian Ruess <julianr@linux.ibm.com>
Cc: schnelle@linux.ibm.com, wintera@linux.ibm.com, ts@linux.ibm.com,
	oberpar@linux.ibm.com, gbayer@linux.ibm.com,
	Alex Williamson <alex@shazbot.org>,
	Yishai Hadas <yishaih@nvidia.com>,
	Shameer Kolothum <skolothumtho@nvidia.com>,
	Kevin Tian <kevin.tian@intel.com>, mjrosato@linux.ibm.com,
	alifm@linux.ibm.com, raspl@linux.ibm.com, hca@linux.ibm.com,
	agordeev@linux.ibm.com, gor@linux.ibm.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/3] vfio/pci: Set VFIO_PCI_OFFSET_SHIFT to 48
Message-ID: <20260212141738.GM750753@ziepe.ca>
References: <20260212-vfio_pci_ism-v1-0-333262ade074@linux.ibm.com>
 <20260212-vfio_pci_ism-v1-1-333262ade074@linux.ibm.com>
Precedence: bulk
X-Mailing-List: linux-s390@vger.kernel.org
List-Id: <linux-s390.vger.kernel.org>
List-Subscribe: <mailto:linux-s390+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-s390+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260212-vfio_pci_ism-v1-1-333262ade074@linux.ibm.com>
X-DKIM: signer='ziepe.ca' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: ziepe.ca]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On Thu, Feb 12, 2026 at 03:02:15PM +0100, Julian Ruess wrote:
> Extend VFIO_PCI_OFFSET_SHIFT to 48 to use the vfio-pci
> VFIO_PCI_OFFSET_TO_INDEX() mechanism with the 256 TiB pseudo-BAR 0 of
> the ISM device on s390. This bar is never mapped.

Woah, this is dangerous, the size was selected to fit within a pgoff
of a 32bit system.. Does this entirely break vfio on 32 bit?

Jason


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215968-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id eLbcMCHojWlDgiAAYBR5ng
	(envelope-from <stable+bounces-215968-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:48:01 +0000
Return-path: <stable+bounces-215968-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:48:02 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215968-hi=josie.lol@vger.kernel.org>)
	id 1vqXz7-0000000AC0p-213a
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:48:01 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id E091F30659F5
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:41:00 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 46C21296BBA;
	Thu, 12 Feb 2026 14:40:59 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MLoAGlKb";
	dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rTEPpnE+"
X-Original-To: stable@vger.kernel.org
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id F23042EB847
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 14:40:57 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770907259; cv=none; b=gjp6imJeKvm6AM5U5gXZxi4aBjxGDcjslEQn3GpF6U6UXVA6Veb+PjX1RdcLhtV/JSyVUQvP0iQFRbswl2xOMX5Ku++31PQg4+sBmDOD3s7aru/xkzJjQuvhJuRBXHwmzGrGrDdMAmOESRGJkt1cwvhhIPCAOCX1lpZ/1ctTIr4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770907259; c=relaxed/simple;
	bh=MV+loLSfbym18ym6CF0ldD6FyGE5WQufzZjWV/GujiQ=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=pKyMoMfUONWvBDjGaYfmuqg637HMmgnJG/JONHC9KOsq45pbhsxt7j10dCBuiT6z/5ubVDUI9fLt1CSVkKOW1FTNtVaafnuVLfSG4sksE26ezFFSlp5hZhGn3gMVV7UaJZEFKWpHalB6b5de2dDLSQtPPbV2ncxZTR/ibQlAN2Y=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MLoAGlKb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rTEPpnE+; arc=none smtp.client-ip=170.10.129.124
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1770907257;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uDKQzbGUuJRbgtDN0hG7BvdewQ/ExGQehaybklKCcDA=;
	b=MLoAGlKbfo/xXSs89VRXpTQrzs9zwgpmtjzZj8YyXBzTfnsCfeCvUBGTMrRhHkQblDr8Bp
	lt5blVSGwZIT2Qo9qLiLTwTesE/pdh+cJ0kDZMoRVssBFxXhmHqm/oRfsQ5oaB+qDa0v6G
	z4rCAPdHmVGsUgYfbuWPr3dB8xnvsmI=
Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com
 [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
 us-mta-549-kfmQWGEDNVq0Ir_PJXQyYA-1; Thu, 12 Feb 2026 09:40:55 -0500
X-MC-Unique: kfmQWGEDNVq0Ir_PJXQyYA-1
X-Mimecast-MFC-AGG-ID: kfmQWGEDNVq0Ir_PJXQyYA_1770907255
Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4836cf00787so4429525e9.1
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 06:40:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=redhat.com; s=google; t=1770907254; x=1771512054; darn=vger.kernel.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=uDKQzbGUuJRbgtDN0hG7BvdewQ/ExGQehaybklKCcDA=;
        b=rTEPpnE+eEoCgviilZ+8SMHp5jquRmqyuD/CvRqequ+2GOrNuBnpy9Dtf7geh7GWRR
         PA2zzOuYfpURp3uwNfZnmwkPy9gdbMSQHsGcZrenYlRhVEIA23UM8C7hasnAfseYQhVW
         xszuZZRdXyDvH0rw173ZE2rkBS27CWQwiT4wrfts+uQNi61jV5r845x5lUIBE18izqpb
         rCVQHgqQBOxCD3stIq7t/jLou8qVyG5Kv1kvEiPe3JBp0u9/kYQLyVjx9GL37ZNSI7C6
         eMvku0Fku5AJnh6wDIsSeUG1Qg5e141/YHbLb18Gr8vRMUGS64Y0eFfHraWD27n0n82f
         VBSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770907254; x=1771512054;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=uDKQzbGUuJRbgtDN0hG7BvdewQ/ExGQehaybklKCcDA=;
        b=RaH0to6SGOeEFnoEhLt8kxpSW+ftES5V6YAxAxWIwt3aPdLQIN5Ai1xv2AmS7CijJl
         0OADo3XUF1qN/izmiA4t+SKDBhc/ziTG9JGYRj+m0lOAsW+NCkKpkazy5StNiKNig+lK
         /8G1FOl2kmg/pCbdsuj3eImPUXtjW31cOqKSvE5oKOZsrO9dp5qsWhxScRbN4dzviROi
         /msZSvWnF9xikBndQBueSjBQvD3U469mvfSSEI81fxh3S5stNKnju8l3iHsA6VdTXjC3
         az5gHBiAa1uVL69CtwjiIJIyg1ycYCq7/kFUrTtFw1s34wPunqAvn7PSxn1yoT5X61mJ
         SKFg==
X-Forwarded-Encrypted: i=1; AJvYcCWarr7WA7IcTV0gZd9qQVcC9N2JUeaXibzkFgRlFOhFlLCBSAYOiYRETR478NKV+SpKOY2m40w=@vger.kernel.org
X-Gm-Message-State: AOJu0YwtX4G8PYc9qxd7I43krHVUItugpSDt28AFuFTf+Udcw2xdkgfk
	IiM0nyaE511BYCYDbm2MdOijNyR7U5KZuCU3xtSYFuuDPW9EIEaGrecc81CuB3pbxREXaKBuGv+
	xoaJgu9T1Cl9eMSsFm1+sWARpBa2NZOJZjW1X2NPnwejA3DmzmcJd1YSXTw==
X-Gm-Gg: AZuq6aLnZqLYpzK9oRW26YBSHlMR7WSxhxL66u6Yt1JTC2IArm/QtFiX5/EEqqG3Yvs
	GC1u+a/c60xcWXs18drmA9IHQlrLh+HwtwQt8wwNVCw/bRWGONwSAb9y30yvXdnIVgpYlDVAq6O
	eK9q5JyOmBw9l5xiJTSEj893cirx7+g3dbp412/T0nDddB0Lw3TUzCA7ZW+l8uPqwtOr9g1WrJ+
	dDdKn4p1fHkspK6C8Z4gj/ge/HXAL0CzrvispJSepmuAe3jGj+9siL1fnlloID/kktQysnIvnVg
	sAFy3UwctaKtnOMAUXDxpp6Yhfeh8rGOpzYUMTyF1wSn0dglfUvFVHziFSp04skwf7yOgyI1UYF
	wmG0Y6JQNQdh6ZOtzkzxfRo5pvr4f/6jGQKSS4aKfumd0uQ==
X-Received: by 2002:a05:600c:4d06:b0:47e:e7de:7c41 with SMTP id 5b1f17b1804b1-483660306b6mr26987375e9.16.1770907254303;
        Thu, 12 Feb 2026 06:40:54 -0800 (PST)
X-Received: by 2002:a05:600c:4d06:b0:47e:e7de:7c41 with SMTP id 5b1f17b1804b1-483660306b6mr26986955e9.16.1770907253657;
        Thu, 12 Feb 2026 06:40:53 -0800 (PST)
Received: from redhat.com (IGLD-80-230-34-155.inter.net.il. [80.230.34.155])
        by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835ba1670fsm77265075e9.4.2026.02.12.06.40.51
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 12 Feb 2026 06:40:53 -0800 (PST)
Date: Thu, 12 Feb 2026 09:40:49 -0500
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Srujana Challa <schalla@marvell.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev,
	pabeni@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
	eperezma@redhat.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, ndabilpuram@marvell.com, kshankar@marvell.com,
	stable@vger.kernel.org
Subject: Re: [PATCH v3,net] virtio_net: Improve RSS key size validation
Message-ID: <20260212093707-mutt-send-email-mst@kernel.org>
References: <20260212130340.3540415-1-schalla@marvell.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260212130340.3540415-1-schalla@marvell.com>
X-DKIM: signer='redhat.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

On Thu, Feb 12, 2026 at 06:33:40PM +0530, Srujana Challa wrote:
> Replace hardcoded RSS max key size limit with a type based definition.
> Add validation for RSS key size against spec minimum (40 bytes). When
> validation fails, gracefully disable RSS features and continue
> initialization rather than failing completely.
> 
> Cc: stable@vger.kernel.org
> Fixes: 3f7d9c1964fc ("virtio_net: Add hash_key_length check")
> Signed-off-by: Srujana Challa <schalla@marvell.com>
> 
> v3:
> - Moved RSS key validation checks to virtnet_validate.
> - Add fixes: tag and CC -stable
> ---
>  drivers/net/virtio_net.c | 29 +++++++++++++++++++++--------
>  1 file changed, 21 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index db88dcaefb20..e61cea50dcab 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -381,7 +381,9 @@ struct receive_queue {
>  	struct xdp_buff **xsk_buffs;
>  };
>  
> -#define VIRTIO_NET_RSS_MAX_KEY_SIZE     40
> +#define VIRTIO_NET_RSS_MAX_KEY_SIZE \
> +	(type_max(((struct virtio_net_config *)0)->rss_max_key_size) + 1)

+1 here really unintuitive.
It does not look like it's still used, though?


> +#define VIRTIO_NET_RSS_MIN_KEY_SIZE 40
>  
>  /* Control VQ buffers: protected by the rtnl lock */
>  struct control_buf {
> @@ -6627,6 +6629,24 @@ static int virtnet_validate(struct virtio_device *vdev)
>  		__virtio_clear_bit(vdev, VIRTIO_NET_F_STANDBY);
>  	}
>  
> +	if (virtio_has_feature(vdev, VIRTIO_NET_F_RSS) ||
> +	    virtio_has_feature(vdev, VIRTIO_NET_F_HASH_REPORT)) {
> +		u8 key_sz = virtio_cread8(vdev,
> +					  offsetof(struct virtio_net_config,
> +						   rss_max_key_size));
> +		/* Spec requires at least 40 bytes */

move the define here then?

> +		if (key_sz < VIRTIO_NET_RSS_MIN_KEY_SIZE) {
> +			dev_warn(&vdev->dev,
> +				 "rss_max_key_size=%u is less than spec minimum %u, disabling RSS\n",
> +				 key_sz, VIRTIO_NET_RSS_MIN_KEY_SIZE);
> +			if (virtio_has_feature(vdev, VIRTIO_NET_F_RSS))
> +				__virtio_clear_bit(vdev, VIRTIO_NET_F_RSS);
> +			if (virtio_has_feature(vdev, VIRTIO_NET_F_HASH_REPORT))
> +				__virtio_clear_bit(vdev,
> +						   VIRTIO_NET_F_HASH_REPORT);


why not clear them unconditionally?

> +		}
> +	}
> +
>  	return 0;
>  }
>  
> @@ -6839,13 +6859,6 @@ static int virtnet_probe(struct virtio_device *vdev)
>  	if (vi->has_rss || vi->has_rss_hash_report) {
>  		vi->rss_key_size =
>  			virtio_cread8(vdev, offsetof(struct virtio_net_config, rss_max_key_size));
> -		if (vi->rss_key_size > VIRTIO_NET_RSS_MAX_KEY_SIZE) {
> -			dev_err(&vdev->dev, "rss_max_key_size=%u exceeds the limit %u.\n",
> -				vi->rss_key_size, VIRTIO_NET_RSS_MAX_KEY_SIZE);
> -			err = -EINVAL;
> -			goto free;
> -		}
> -
>  		vi->rss_hash_types_supported =
>  		    virtio_cread32(vdev, offsetof(struct virtio_net_config, supported_hash_types));
>  		vi->rss_hash_types_supported &=
> -- 
> 2.25.1



From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215969-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id eKE8LBLpjWlDgiAAYBR5ng
	(envelope-from <stable+bounces-215969-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:52:02 +0000
Return-path: <stable+bounces-215969-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:52:02 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215969-hi=josie.lol@vger.kernel.org>)
	id 1vqY30-0000000AJlg-291k
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:52:02 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id D64E83045A2E
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:48:49 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 0116535C1B7;
	Thu, 12 Feb 2026 14:48:48 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="nu6uB5eE";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="CZEeMQVK"
X-Original-To: stable@vger.kernel.org
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id B131F35BDAA;
	Thu, 12 Feb 2026 14:48:46 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770907727; cv=none; b=vCx7CgUM2FBWn+qYKTmib6f9NyyVNegrg2acq/4DGDkkd+uveEBe5uycXtSrrGyh5GAZcHav+3kjKvS9PsGejqMPRA59Y/ytaCm94vRDFQ4P5FoRjNHSWL/WgXdbo84jY1r4TnEuRtFTZHfqIbQVVI3HU2SFbbi4eMeUVvcldLM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770907727; c=relaxed/simple;
	bh=dFavjR5pdXwlc9K6evsuvIUExi633TuD2Y58C+AQzB4=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=m+CCfcUaH1cOBzE2tGYPEUr56JvbH6AG4D5i9x9rA3RLuSlzCt1S7qX69Nfp3ZiLkDUShpQoA+ryYLyRDaOaPBqoG6tUlm2f6s/5gxp3Z1gspUzrB3wGOz7nrnfb3I6PvqPGz+hDH6VSLXNLMWvXve+DQT5gPVOzpkwnp2VlXxA=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=nu6uB5eE; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=CZEeMQVK; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Date: Thu, 12 Feb 2026 15:48:41 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1770907723;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iyKLveYLx2s5utbcVS0AmPY44PgTdWydUyC5yig1Ys8=;
	b=nu6uB5eE+Ig0CPqWNXdLCsQ4n2Pr7jnNrODwcr/C3EfMXtifqh20fWjeNDYigRZ9LJfWI4
	J9oNH6bKq+IrcFwMPRlwbojTOhyJdhhLBD9Kcwv4Jt4k5hzXTrfjprKANFmiqpcZTFHVmP
	gF54kA51mbEQ7oYyq3eKSihBpi0j06cwRqVcbvGyWx525MS2jxffgPf9XHE+XSIKQaIbEn
	D76MyToOQ5UXTXBXSln7simIfKp7kIzImdQew+KfC6sI7oTbCg0Q5lR1R392szl56PWjbL
	hEYmMXCgnoMnKXrKPvkIHvxWxUSunDHJIG5l8Bvc81XhKKZBaGq3eI1u5NStEA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1770907723;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iyKLveYLx2s5utbcVS0AmPY44PgTdWydUyC5yig1Ys8=;
	b=CZEeMQVKcntcOvBwuUCfscuZPYwPbNP3RVFpqIsyORAkGv5NVdGuxmRYHtb4ATm1ykgc7I
	D5IzSCTjC0H/m3Aw==
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Ionut Nechita (Wind River)" <ionut.nechita@windriver.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
	ming.lei@redhat.com, muchun.song@linux.dev,
	mkhalfella@purestorage.com, chris.friesen@windriver.com,
	stable@vger.kernel.org, sunlightlinux@gmail.com,
	ionut_n2001@yahoo.com
Subject: Re: [PATCH v3 1/1] block/blk-mq: use atomic_t for quiesce_depth to
 avoid lock contention on RT
Message-ID: <20260212144841.95-yCgJm@linutronix.de>
References: <20260211203928.324307-2-ionut.nechita@windriver.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20260211203928.324307-2-ionut.nechita@windriver.com>
X-DKIM: signer='linutronix.de' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: linutronix.de]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On 2026-02-11 22:39:29 [+0200], Ionut Nechita (Wind River) wrote:
> From: Ionut Nechita <ionut.nechita@windriver.com>
>=20
> In RT kernel (PREEMPT_RT), commit 679b1874eba7 ("block: fix ordering
> between checking QUEUE_FLAG_QUIESCED request adding") causes severe
=E2=80=A6

> Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Fixes: 679b1874eba7 ("block: fix ordering between checking QUEUE_FLAG_QUI=
ESCED request adding")
This is
         6bda857bcbb86 ("block: fix ordering between checking QUEUE_FLAG_QU=
IESCED request adding")

in my tree. I don't have your hash anywhere. The hash at the top in the
email is also affected.

> Cc: stable@vger.kernel.org
> Signed-off-by: Ionut Nechita <ionut.nechita@windriver.com>

Otherwise
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -314,21 +314,18 @@ EXPORT_SYMBOL_GPL(blk_mq_quiesce_queue);
>   */
>  void blk_mq_unquiesce_queue(struct request_queue *q)
>  {
> -	unsigned long flags;
> -	bool run_queue =3D false;
> +	int depth;
> =20
> -	spin_lock_irqsave(&q->queue_lock, flags);
> -	if (WARN_ON_ONCE(q->quiesce_depth <=3D 0)) {
> -		;
> -	} else if (!--q->quiesce_depth) {
> -		blk_queue_flag_clear(QUEUE_FLAG_QUIESCED, q);
> -		run_queue =3D true;
> -	}
> -	spin_unlock_irqrestore(&q->queue_lock, flags);
> +	depth =3D atomic_dec_if_positive(&q->quiesce_depth);
> +	if (WARN_ON_ONCE(depth < 0))
> +		return;

Ah. That is cute.

> -	/* dispatch requests which are inserted during quiescing */
> -	if (run_queue)
> +	if (depth =3D=3D 0) {
> +		/* Ensure the decrement is visible before running queues */
> +		smp_mb__after_atomic();
> +		/* dispatch requests which are inserted during quiescing */
>  		blk_mq_run_hw_queues(q, true);
> +	}
>  }
>  EXPORT_SYMBOL_GPL(blk_mq_unquiesce_queue);
> =20

Sebastian


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215970-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id yNmkIr/pjWkuRiUAYBR5ng
	(envelope-from <stable+bounces-215970-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:54:55 +0000
Return-path: <stable+bounces-215970-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:54:55 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215970-hi=josie.lol@vger.kernel.org>)
	id 1vqY5n-0000000APGx-0bZk
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:54:55 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 300CF300F538
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:51:20 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 2B0E735B62D;
	Thu, 12 Feb 2026 14:51:17 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b="VfpmNuzq"
X-Original-To: stable@vger.kernel.org
Received: from smtp-8faa.mail.infomaniak.ch (smtp-8faa.mail.infomaniak.ch [83.166.143.170])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC4B135CB7E
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 14:51:10 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.166.143.170
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770907876; cv=none; b=X69/PL5cvZEgIapAsJwBRuzlnXWgM6SdD1hAmaIeC/7L/AUUj/a8eXpOteH8j3t+/3sCIZPYrkb4yn2YDbdg2vzx9sbtg1fk36K3FpCPqdqYbbLF4HtkSrjmOMF9l1zk1r6PhvhVfMw0QbkzkOrJRM+y2QGb0tPse8T3pw0EyOo=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770907876; c=relaxed/simple;
	bh=yV+qGryzCv5LdVIdZObnyl+TqBvoZRBq/s7BwmvEucY=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=aC9TplW4pdyZI9HxgFHfTapBaXSFA5VC0jtznykjxIHw5v60dmIV6DeqX3nEF4iLYrM6QoAHYqasJujDW7Cwhem3/fUJghonwjUKwBDF57fpi/yToBHb0kfrj3p6c9DsHjbuEsFyzsSiz/PNju1tdlEzl22yGhFJ896xsLgzP/c=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net; spf=pass smtp.mailfrom=digikod.net; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b=VfpmNuzq; arc=none smtp.client-ip=83.166.143.170
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=digikod.net
Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108])
	by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4fBdXR4dDGzgQh;
	Thu, 12 Feb 2026 15:51:03 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digikod.net;
	s=20191114; t=1770907863;
	bh=CO1ZykXZY4zJvGlWonzeMkNhR0m/da9fetsI6SBQSIo=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=VfpmNuzqAWs6ximhaxzWPLghgTTt/0jeQoJ5VFh4I6Wqum0fpHt7KXCz9agYPU1bP
	 SKHhpuNDMKkzd36eJwjcudqnYF9xhOC+TviDKsq3NM+vHPLU8FE5TKnjNezHKtz4QS
	 +fNkjznu5n3wuLwkBU9FjHnZwonM27gCyHvN3TKE=
Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4fBdXR0RTCzy0n;
	Thu, 12 Feb 2026 15:51:02 +0100 (CET)
Date: Thu, 12 Feb 2026 15:50:58 +0100
From: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= <mic@digikod.net>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, 
	kernel-team@cloudflare.com, Nathan Chancellor <nathan@kernel.org>, 
	Nicolas Schier <nsc@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH v1] kbuild: Fix CC_CAN_LINK detection
Message-ID: <20260212.Eich4Liesaiv@digikod.net>
References: <20260212133544.1331437-1-mic@digikod.net>
 <20260212151347-6f19b408-f22b-4ecb-9ce5-bd4e01e06743@linutronix.de>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20260212151347-6f19b408-f22b-4ecb-9ce5-bd4e01e06743@linutronix.de>
X-Infomaniak-Routing: alpha
X-DKIM: signer='digikod.net' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: cc-can-link.sh]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On Thu, Feb 12, 2026 at 03:15:47PM +0100, Thomas Weißschuh wrote:
> On Thu, Feb 12, 2026 at 02:35:43PM +0100, Mickaël Salaün wrote:
> > Most samples cannot be build on some environments because they depend
> > on CC_CAN_LINK, which is set according to the result of
> > scripts/cc-can-link.sh called by cc_can_link_user.
> > 
> > Because cc-can-link.sh must now build without warning, it may fail
> > because it is calling printf() with an empty string:
> > 
> >   + cat
> >   + gcc -m32 -Werror -Wl,--fatal-warnings -x c - -o /dev/null
> >   <stdin>: In function ‘main’:
> >   <stdin>:4:9: error: zero-length gnu_printf format string [-Werror=format-zero-length]
> >   cc1: all warnings being treated as errors
> > 
> > Fix this warning and the samples build by actually printing something.
> > 
> > Cc: Nathan Chancellor <nathan@kernel.org>
> > Cc: Nicolas Schier <nsc@kernel.org>
> > Cc: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> > Cc: stable@vger.kernel.org
> > Fixes: d81d9d389b9b ("kbuild: don't enable CC_CAN_LINK if the dummy program generates warnings")
> 
> Thanks!
> 
> Reviewed-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> 
> In my GCC 15.2 this warning is not enabled by default.

Some for me, but it is the case with GCC 13.3.0 on Ubuntu 24 LTS.

> 
> > Signed-off-by: Mickaël Salaün <mic@digikod.net>
> > ---
> >  scripts/cc-can-link.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/cc-can-link.sh b/scripts/cc-can-link.sh
> > index e67fd8d7b684..58dc7dd6d556 100755
> > --- a/scripts/cc-can-link.sh
> > +++ b/scripts/cc-can-link.sh
> > @@ -5,7 +5,7 @@ cat << "END" | $@ -Werror -Wl,--fatal-warnings -x c - -o /dev/null >/dev/null 2>
> >  #include <stdio.h>
> >  int main(void)
> >  {
> > -	printf("");
> > +	printf("\n");
> >  	return 0;
> >  }
> >  END
> > -- 
> > 2.53.0
> > 


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215971-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id sFVLBJLqjWkuRiUAYBR5ng
	(envelope-from <stable+bounces-215971-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:58:26 +0000
Return-path: <stable+bounces-215971-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:58:26 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215971-hi=josie.lol@vger.kernel.org>)
	id 1vqY9B-0000000AVuU-3J7u
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:58:26 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 015A330094F9
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:58:25 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id E1BF6342CB1;
	Thu, 12 Feb 2026 14:58:23 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b="Gvu6J4Wa"
X-Original-To: stable@vger.kernel.org
Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94B3443ABC;
	Thu, 12 Feb 2026 14:58:22 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112
ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770908303; cv=pass; b=gNcgksE0YVcHWTYnJbFSGvnFQU3JBImzmkGNol6BS4NlUhwmUdvvettrr2xfKg1r6g9CcAJXjcdCPLngQWM6hByKyV2u+GCrCgfoUD3Hh202TasnPlgrpzjRyn2UmiRANtcVbB6AmK0hDbIAstGNvyy71+0KxQnes8zVVQ0gA6Y=
ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770908303; c=relaxed/simple;
	bh=Uqg+1i9fzmYpJWilVjNVALXs0GMRJU++P8SXvGfrlbg=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=k1yFbWIiwYBWCobJ5WdetQeCFq8G0K3Sq8BjEPTP26j2NAIMVAPGrW41gS0E951Au4v6aG+W74sTAWg3Q8auTNVijG/Nnssed2NEDX+lNrMP383inCpaxpc/HI+ED8xhx1gyzvPtzZM7NbXIvYgdsnU1+NJdJG355JQEZ92pZmg=
ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b=Gvu6J4Wa; arc=pass smtp.client-ip=136.143.188.112
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com
ARC-Seal: i=1; a=rsa-sha256; t=1770908288; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=bdBJfciw+SLKHwce3M1xZeBNSh9/dUONzlxiisNvSAhA9Y/azTwPYL7lBuRhhDNN0vpXmD0e0M9w9bnORC8xpArw1JQv4Vc6Ew8HeHpRufv67M7pKk1CLOzy20GP/uxD1oFbaZghR0miSsD3zzsizXeFPmJXUMuZFMAklECth/c=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1770908288; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; 
	bh=ewJ17yZssUQQjHgmzfTqhJeBawC3u74ghBag/166lsk=; 
	b=EhP6TrIUfa4578JrGFn6RoN+JGO6Umocs7CWeEJjnfmRombZJWxvbZ5EobxFCaHuf7ivV7raxO3nIl+jnGSvBnvf6l9iU5G31FG+TBzMUzizyG72kmS5FtuaQ++llZzCQzVrs/O8DWMi/Sr05FaiXf9el+1W1eAlwizdHnzx1JI=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=collabora.com;
	spf=pass  smtp.mailfrom=sebastian.reichel@collabora.com;
	dmarc=pass header.from=<sebastian.reichel@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1770908288;
	s=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com;
	h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To;
	bh=ewJ17yZssUQQjHgmzfTqhJeBawC3u74ghBag/166lsk=;
	b=Gvu6J4Waf/OsLu1RLrAJg6LtJ0jCuzkBxwpJI6yXyprFKG6RAAaD0yvRfbvX10Wi
	/xV2ZO95dE5GMdDvIxAfdQbOzpYKDyFm0aH0JG3xNczQHAgaJ+mzqANxqKpCOd7+C5m
	Zf+7drziXG6/xtlkLgF4rrFvuv+JTHQ4av3DBjgU=
Received: by mx.zohomail.com with SMTPS id 1770908287347603.7883798586333;
	Thu, 12 Feb 2026 06:58:07 -0800 (PST)
Received: by venus (Postfix, from userid 1000)
	id 1869F18248B; Thu, 12 Feb 2026 15:58:03 +0100 (CET)
Date: Thu, 12 Feb 2026 15:58:03 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, 
	Finley Xiao <finley.xiao@rock-chips.com>, Frank Zhang <rmxpzlb@gmail.com>, linux-pm@vger.kernel.org, 
	Detlev Casanova <detlev.casanova@collabora.com>, Heiko Stuebner <heiko@sntech.de>, 
	linux-rockchip@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] pmdomain: rockchip: Fix rkvdec0/1 and venc0/1 for RK3588
Message-ID: <aY3oqqaoAM5QtHWl@venus>
References: <1770891364-52147-1-git-send-email-shawn.lin@rock-chips.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kclqcghfrdw46u3s"
Content-Disposition: inline
In-Reply-To: <1770891364-52147-1-git-send-email-shawn.lin@rock-chips.com>
X-Zoho-Virus-Status: 1
X-Zoho-AV-Stamp: zmail-av-0.1.0.1.4.3/270.907.16
X-ZohoMailClient: External
X-DKIM: signer='collabora.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-DKIM: signer='sebastian.reichel@collabora.com' status='pass' reason=''
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: collabora.com]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4


--kclqcghfrdw46u3s
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] pmdomain: rockchip: Fix rkvdec0/1 and venc0/1 for RK3588
MIME-Version: 1.0

Hi,

On Thu, Feb 12, 2026 at 06:16:04PM +0800, Shawn Lin wrote:
> From the RK3588 TRM Table 1-1 RK3588 Voltage Domain and Power Domain Summ=
ary,

That's Table 7-1 :)

> PD_RKVDEC0/1 and PD_VENC0/1 rely on VD_VCODEC which require extra voltage=
s to
> be applied, otherwise it breaks RK3588-evb1-v10 board after vdec support =
landed[1].
> The panic looks like below:
>=20
>   rockchip-pm-domain fd8d8000.power-management:power-controller: failed t=
o set domain 'rkvdec0' on, val=3D0
>   rockchip-pm-domain fd8d8000.power-management:power-controller: failed t=
o set domain 'rkvdec1' on, val=3D0
>   ...
>   Hardware name: Rockchip RK3588S EVB1 V10 Board (DT)
>   Workqueue: pm genpd_power_off_work_fn
>   Call trace:
>   show_stack+0x18/0x24 (C)
>   dump_stack_lvl+0x40/0x84
>   dump_stack+0x18/0x24
>   vpanic+0x1ec/0x4fc
>   vpanic+0x0/0x4fc
>   check_panic_on_warn+0x0/0x94
>   arm64_serror_panic+0x6c/0x78
>   do_serror+0xc4/0xcc
>   el1h_64_error_handler+0x3c/0x5c
>   el1h_64_error+0x6c/0x70
>   regmap_mmio_read32le+0x18/0x24 (P)
>   _regmap_bus_reg_read+0xfc/0x130
>   _regmap_read+0x188/0x1ac
>   regmap_read+0x54/0x78
>   rockchip_pd_power+0xcc/0x5f0
>   rockchip_pd_power_off+0x1c/0x4c
>   _genpd_power_off+0x84/0x120
>   genpd_power_off+0x1b4/0x260
>   genpd_power_off_work_fn+0x38/0x58
>   process_scheduled_works+0x194/0x2c4
>   worker_thread+0x2ac/0x3d8
>   kthread+0x104/0x124
>   ret_from_fork+0x10/0x20
>   SMP: stopping secondary CPUs
>   Kernel Offset: disabled
>   CPU features: 0x3000000,000e0005,40230521,0400720b
>   Memory Limit: none
>   ---[ end Kernel panic - not syncing: Asynchronous SError Interrupt ]---
>=20
> [1] https://lore.kernel.org/linux-rockchip/20251020212009.8852-2-detlev.c=
asanova@collabora.com/
> Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Greetings,

-- Sebastian

> ---
>=20
>  drivers/pmdomain/rockchip/pm-domains.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/ro=
ckchip/pm-domains.c
> index 997e93c..040aa5f 100644
> --- a/drivers/pmdomain/rockchip/pm-domains.c
> +++ b/drivers/pmdomain/rockchip/pm-domains.c
> @@ -1315,10 +1315,10 @@ static const struct rockchip_domain_info rk3588_p=
m_domains[] =3D {
>  	[RK3588_PD_NPUTOP]	=3D DOMAIN_RK3588("nputop",  0x0, BIT(3),  0,       =
0x0, BIT(11), BIT(2),  0x0, BIT(1),  BIT(1),  false, false),
>  	[RK3588_PD_NPU1]	=3D DOMAIN_RK3588("npu1",    0x0, BIT(4),  0,       0x=
0, BIT(12), BIT(3),  0x0, BIT(2),  BIT(2),  false, false),
>  	[RK3588_PD_NPU2]	=3D DOMAIN_RK3588("npu2",    0x0, BIT(5),  0,       0x=
0, BIT(13), BIT(4),  0x0, BIT(3),  BIT(3),  false, false),
> -	[RK3588_PD_VENC0]	=3D DOMAIN_RK3588("venc0",   0x0, BIT(6),  0,       0=
x0, BIT(14), BIT(5),  0x0, BIT(4),  BIT(4),  false, false),
> -	[RK3588_PD_VENC1]	=3D DOMAIN_RK3588("venc1",   0x0, BIT(7),  0,       0=
x0, BIT(15), BIT(6),  0x0, BIT(5),  BIT(5),  false, false),
> -	[RK3588_PD_RKVDEC0]	=3D DOMAIN_RK3588("rkvdec0", 0x0, BIT(8),  0,      =
 0x0, BIT(16), BIT(7),  0x0, BIT(6),  BIT(6),  false, false),
> -	[RK3588_PD_RKVDEC1]	=3D DOMAIN_RK3588("rkvdec1", 0x0, BIT(9),  0,      =
 0x0, BIT(17), BIT(8),  0x0, BIT(7),  BIT(7),  false, false),
> +	[RK3588_PD_VENC0]	=3D DOMAIN_RK3588("venc0",   0x0, BIT(6),  0,       0=
x0, BIT(14), BIT(5),  0x0, BIT(4),  BIT(4),  false, true),
> +	[RK3588_PD_VENC1]	=3D DOMAIN_RK3588("venc1",   0x0, BIT(7),  0,       0=
x0, BIT(15), BIT(6),  0x0, BIT(5),  BIT(5),  false, true),
> +	[RK3588_PD_RKVDEC0]	=3D DOMAIN_RK3588("rkvdec0", 0x0, BIT(8),  0,      =
 0x0, BIT(16), BIT(7),  0x0, BIT(6),  BIT(6),  false, true),
> +	[RK3588_PD_RKVDEC1]	=3D DOMAIN_RK3588("rkvdec1", 0x0, BIT(9),  0,      =
 0x0, BIT(17), BIT(8),  0x0, BIT(7),  BIT(7),  false, true),
>  	[RK3588_PD_VDPU]	=3D DOMAIN_RK3588("vdpu",    0x0, BIT(10), 0,       0x=
0, BIT(18), BIT(9),  0x0, BIT(8),  BIT(8),  false, false),
>  	[RK3588_PD_RGA30]	=3D DOMAIN_RK3588("rga30",   0x0, BIT(11), 0,       0=
x0, BIT(19), BIT(10), 0x0, 0,       0,       false, false),
>  	[RK3588_PD_AV1]		=3D DOMAIN_RK3588("av1",     0x0, BIT(12), 0,       0x=
0, BIT(20), BIT(11), 0x0, BIT(9),  BIT(9),  false, false),
> --=20
> 2.7.4
>=20

--kclqcghfrdw46u3s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmmN6ncACgkQ2O7X88g7
+ppwDQ/+MgfaLtM2QMPFgYQWMUHMFC/mO4X+3ZKAKoQSPbnUptASff0G8voyFYfZ
Ld74ACLB5gLXtv5sIbBHw/4N6WWUZOD+XwAYyHd9ceAU2jKoWycZHP2YcuFOQROS
HND+GtGq5Yl4QFruqt2wpo7IW3bRMF0tufXeOz01o5ezyPuYFDPqWeEUQSuBXwVj
YzPrz+hUgrTjun8EzWRz73NGtO1NsQkVGarg1o8gvczEK7qyyETZNonKSksZSpBc
wHMDmuBowxqQcGPvd58gB/mGRH6WnDnZJV5Pi828STqG0kpGSkvT+XcdUcOZhWjR
OdjQJ6YkA6V+a+e+wHCw6B7AsUagiBzojzgsGPq6/pCJ+AJ4oDQuizufPJ6nSLdn
bX6/5aLfYH2Ys9sPKpKlOoNnc8xxdmmMZqSA7w7Js+XUNuZRCBN51TAkjy+0g7qx
dUneQsnJsD0SVswpbXvdCn2+xrHJ6midhpBclOxWxSVzkVILO7M6OA6Uin9G6OLw
faVkLh0SNqZ/lpI3tQ5UN5jTH7kfhp6s3LxpDVQ6CPGjKmmuGCwaZff32nx5JVh4
AsgIfwCZYbNtwm/BQx/Zb4AWN2Z5sssHxz8n0S5ZmV7UwhTNLYnrt+YyNFuKMF3l
Y8DuMDmno5RWMlldvN3R8qp0AbUi9BDyNkD3y3LbUPVRzK3p754=
=KpAz
-----END PGP SIGNATURE-----

--kclqcghfrdw46u3s--


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215972-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id 0MLLFNTqjWmVSyMAYBR5ng
	(envelope-from <stable+bounces-215972-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:59:32 +0000
Return-path: <stable+bounces-215972-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 14:59:32 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215972-hi=josie.lol@vger.kernel.org>)
	id 1vqYAF-0000000AY3A-3ePF
	for hi@josie.lol;
	Thu, 12 Feb 2026 14:59:32 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id E73D23006B3D
	for <hi@josie.lol>; Thu, 12 Feb 2026 14:59:30 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id D4C1E35C182;
	Thu, 12 Feb 2026 14:59:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b="Yvwdi7HJ"
X-Original-To: stable@vger.kernel.org
Received: from mail-yx1-f53.google.com (mail-yx1-f53.google.com [74.125.224.53])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F66F346A1F
	for <stable@vger.kernel.org>; Thu, 12 Feb 2026 14:59:28 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.224.53
ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770908369; cv=pass; b=EpiChnhK3Jy1rWaTUZuUculzV6DDzPj7gyy2dXiyYLPnXHT2M/jBKObQlykrVvmkckIX5ZB9GZnyCdSaJoqXWmU1KVLPsf8NV22gF2pA7rrTx9D6S62RfaDki9VY1pB5s3r35wVLIPa0siCLeiTMrTx/MbmwWiU8ECjUpZYn58A=
ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770908369; c=relaxed/simple;
	bh=yGn21hxAcgcmG+63AgS3v0qYovGfQ2LjythatUWGR20=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type; b=BAQuHfqNpLDuh3EAe42L5o9Cni1VXhMEfPSCtOhvIbxxD+9uPytC1mvDXy18aWNrUQVDLVqJwDk2qVub+m0h0suTASVRfzXHN/gYT6vADFvROKMr4sjpPHDjqH0f4mSyroaoUJPQ+kDA6TM5QoruMQUrJUE5uXF/dNhHSNOre9I=
ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com; spf=none smtp.mailfrom=mojatatu.com; dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b=Yvwdi7HJ; arc=pass smtp.client-ip=74.125.224.53
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com
Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=mojatatu.com
Received: by mail-yx1-f53.google.com with SMTP id 956f58d0204a3-64acd19e1dfso5813324d50.0
        for <stable@vger.kernel.org>; Thu, 12 Feb 2026 06:59:28 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1770908367; cv=none;
        d=google.com; s=arc-20240605;
        b=hKHpXzsmtdQ7+FGHZ93dNYFGqxaLKwhd+0t1uGY1dBrY3hL3a6VibutC7lew0pXEIL
         trHwH5nz7i30eS64APT1/a7kAt8zj+U3mcWe3mz3YoNoNW/be5qMscbZnMGgBgkK1QkE
         GlbwA0T+hR4mPAZGLbb0iiZmrnnVnYex+wlRkSCGffxrAPrjASzNwhvHeYgb1snHFxx9
         5DNhWBw5S9vQ2y9PVWHyJPl1Bjzs63PGBhxi5K4RjeUoKyLG2jbnbDVzpK/NJAOfzigE
         z8fm4BqnEPtRqhQqkA/tCXO2onTR9T3+wUmEIdEHt5lms7FW06XdjpZXAzwZys9F6QpG
         hKsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=yGn21hxAcgcmG+63AgS3v0qYovGfQ2LjythatUWGR20=;
        fh=UynA+3jLEGYxcrmXpvT/CdJKV3yeZGugu/vn3QIGjRk=;
        b=kDX5+SVIkLjoASwXbkRh4zuL0rhPm/kcUMCnO8BX8fkaxBlCIu+VutoqEqZbFO444f
         cV8rU9HBieR/jKqCHFuMIKL5kyy382AZoqAlSXBTFiOcUo9aVRCV8vtYLb3QLB93LEij
         CObrv/DDKgIxZJEHLAFS7UYjNZA1raVaZmkt3ZWi3/sKZYxFWXPQkaHkSaUMhDlWBYUF
         Cxnzdy6S6XwcQiKaqjtknOI+hxeJF/xFjocJEQkkmdGV0sUWhDwqBW65fxp8ekYi4UeM
         WvivdCq3mra0dXCZ1jigowu+e5AB+joBULdk4mzqlXG97/0pLsrZ5q0Sla2IDmhGq/1s
         jz8w==;
        darn=vger.kernel.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=mojatatu-com.20230601.gappssmtp.com; s=20230601; t=1770908367; x=1771513167; darn=vger.kernel.org;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=yGn21hxAcgcmG+63AgS3v0qYovGfQ2LjythatUWGR20=;
        b=Yvwdi7HJ/E6jYa4h50wEB/QaCtgajK2q4JzXlvGgT1cfgxnb51/j72cgaSW1PrzuV5
         REn7gVIVfLVuR/r514dbSbi1FdIy1eeDZXOuky1pSH7UTeE1or3V+DYnY9dLPF+0Wd/j
         UtJ+QD19NdJL4TZBrOStakGPbL29U+jxnV5FCOpmoeWpxM2/7jR8BBOyuQ4wlSYMoGph
         /Y/gTCS9n7F3Cr9ztxAoa62H+brzrwbkBbgBNxU2TKgO9B+sihQDR+jPZllYyBRpvhgR
         3OIJsXo64TBxe2Kiz+WpuXWq3oqvcZybpTBdNkSWgud1KJ9zSfrCNmAi/5eSL9FbZ7mv
         4k4w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1770908367; x=1771513167;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from
         :to:cc:subject:date:message-id:reply-to;
        bh=yGn21hxAcgcmG+63AgS3v0qYovGfQ2LjythatUWGR20=;
        b=tLOD7LXtsBJo2hxz1aeRPXMYWjicUQF6nf6BcOa7eJECIvdoA+84LLBjKtiaEZrMXM
         4oFbokhtY0ZfggzCe71cMCRidjyzdg3/XZnlhkXnsCzjX0tQZST1kF71vScZMPfelOAm
         xrClX3uSCpWZfKDM/LTrPqHkRXv0RiUTQ4mwTbsUWNYS33kGd4M/qKO9Xw32ceoNxRgg
         kqSPyyFJy06/1cfOppHfX0iYnUpcCG+fiSMcdA5ybOVNHIxSJAW7eZluoV7XtRw7y86J
         MK4zIPD+NymZqXn9UnRwEsebDCn6bjOxzP+gNC1GQhDueW3qz52MNxC1D1s2X46/8/Fn
         yT3A==
X-Forwarded-Encrypted: i=1; AJvYcCXefG8qz4u+ZEc6lZsH+yMt98QcG68BjwZmFE2znPFGoQ86/IVuf5Nl8R/fbElGceJwAur/Vwk=@vger.kernel.org
X-Gm-Message-State: AOJu0YwW4wvJPTgI9DrCOmCDN/0SJgipVlJ6fodb/EB7BwRLFBTR1H9u
	gX5aObwZQ7fbN2wOqJi4nle9WxeVqJ1HTqKg44//dK4ANrOULKawf18it8L7HjsNfTwTUuO/6a8
	bQD72DVvwfFpI2gfrveFdyNl+NapdtFBngI9Rc+wi
X-Gm-Gg: AZuq6aKTXOsYbuHsU5LGx4KJCUvaDyzfsgfasRc9/NkxHJt5zzVNTvFWFCtf6i2QNtN
	gANQlyZdr4PocOXDSunuxlZyBq21D95Saoe6rw/tRgQaalB/oIOxpvOQvVdnNx5Z1wZGbpg3Z+H
	0tztOHelhasFwGGEPZxrfzcfIFTFV8MuZ7++YVSSv72seC9nYF8q2I2759ReiwIku0IxoIuxnGb
	Bmhsd6M2bw1zUu3NJibzkB3fJdwvtP586Fwrg7Xc7aXXyBKpYPSEa1sRr3W9gnbPrZ8/ZmQbiC/
	Jucxap2eFuqhWA2r+p2sCA==
X-Received: by 2002:a53:b1a2:0:b0:63f:af33:e413 with SMTP id
 956f58d0204a3-64bbaa3b703mr2031466d50.24.1770908367555; Thu, 12 Feb 2026
 06:59:27 -0800 (PST)
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
References: <20260205150958.412278-1-p@1g4.org> <20260205150958.412278-2-p@1g4.org>
 <CA+NMeC_v8bQo2tFUYiD1faMJ0Gd9FFbqmPHCvBUD7HW_yoCx0A@mail.gmail.com> <nmLWEyw7BWgMgTdbfbxbYI1QqIF-IPdNFFsdf_T8qY8IBncn1bNnTPDe9Bz1AWfsGVt4pgj8wLzhB1DxZ1-RzuZiW2VZLamsaBS4WpjC8lw=@1g4.org>
In-Reply-To: <nmLWEyw7BWgMgTdbfbxbYI1QqIF-IPdNFFsdf_T8qY8IBncn1bNnTPDe9Bz1AWfsGVt4pgj8wLzhB1DxZ1-RzuZiW2VZLamsaBS4WpjC8lw=@1g4.org>
From: Victor Nogueira <victor@mojatatu.com>
Date: Thu, 12 Feb 2026 11:59:16 -0300
X-Gm-Features: AZwV_QgRSL8UTzEEJf1PL2FE1zP9TG_DIZ0npWBwNFXgTFImvInzr5hzqmp5_ls
Message-ID: <CA+NMeC9XPutYDqbpYDuhyOp5tVUp-knoujWOHNf1reg=eY3Kcw@mail.gmail.com>
Subject: Re: [PATCH net v5 1/1] net/sched: act_gate: snapshot parameters with
 RCU on replace
To: Paul Moses <p@1g4.org>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>, Cong Wang <xiyou.wangcong@gmail.com>, 
	Jiri Pirko <jiri@resnulli.us>, "David S. Miller" <davem@davemloft.net>, 
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Simon Horman <horms@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 
	stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-DKIM: signer='mojatatu-com.20230601.gappssmtp.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.105.105.114 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 5

On Thu, Feb 12, 2026 at 9:18=E2=80=AFAM Paul Moses <p@1g4.org> wrote:
>
> Proposed changes from v5...v6:
> [...]

I think I understand what you are saying, but I believe I'll be able to
give you better comments once I see the code.

cheers,
Victor


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215973-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id QLC7A9rrjWkLziMAYBR5ng
	(envelope-from <stable+bounces-215973-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 15:03:54 +0000
Return-path: <stable+bounces-215973-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 15:03:54 +0000
Received: from sea.lore.kernel.org ([172.234.253.10])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215973-hi=josie.lol@vger.kernel.org>)
	id 1vqYET-0000000AhEx-1wVX
	for hi@josie.lol;
	Thu, 12 Feb 2026 15:03:53 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by sea.lore.kernel.org (Postfix) with ESMTP id 80DF53038AE2
	for <hi@josie.lol>; Thu, 12 Feb 2026 15:02:35 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id BC11B225775;
	Thu, 12 Feb 2026 15:02:34 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a8c/L0BI"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96BED21CC64;
	Thu, 12 Feb 2026 15:02:34 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770908554; cv=none; b=IsAnwHCS+c/O7b6XHXnwgY1N4TEIyhuBKg/IogHfaSONt10X86ZmeOWxhoVZMqeLzGuUEBmPEAB3bbfwD/uEzZlpaQQhaR66Ve0/Yi8deou18gRcusxfgtZQLuV4soNVCYhYM/22iaMgWC54WtoT7vHuz5qItPs/KqOLtzPuVLk=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770908554; c=relaxed/simple;
	bh=EMoDt1IiNsxkfqiKjCS0UPDXsAwhArjBJsUXQW8L6vU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=JUuiFWyEeE7FLzldYCFAconaOwS6R0L193rPwt/I5oKKbl/dilG4jXT+xBzMB7R9NTyIsrhq1adhoHS0wpYi/qHePT/F7NojbaSYhVSxZxzmd2xaDO03lPtBUOhelzVvZDAzZC2WNsj//bsigKLz6WIAsLXsb85xyCy3gHbY4aA=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a8c/L0BI; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40583C16AAE;
	Thu, 12 Feb 2026 15:02:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770908554;
	bh=EMoDt1IiNsxkfqiKjCS0UPDXsAwhArjBJsUXQW8L6vU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=a8c/L0BIsS1ke73oi1t0EZDfo8QIdqzaWM1nV6ZIXWZo4QozN3QbT5uEy1EJD7u7A
	 QBTKui+slf0xBu+H+MX4RoqXlZszimHjTb5mMVMOYtiPyVGJTFaESsJRsw6l9tAT/A
	 o/OgjaamyEel2Y/CzJe/jzF+dVuxk2tERpFjnN79tqJh0XnnUdhqs1T/UlcOlr1Gi5
	 e6EmvI4kB6DjBn2PBNGn/nQl6ckZMiZW/uInyowUIrokv8hyve8Uwd8uSiUVtSWFpg
	 DiSFsEL1fUaTCEI1UDHaCp6Fc6Gh9jibLwhz+Nx4Qf2AagRMaudOMmd04Y4Fu/vnAO
	 vNSBHUAQZIqAA==
Date: Thu, 12 Feb 2026 15:02:30 +0000
From: Simon Horman <horms@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: netdev@vger.kernel.org, stable@vger.kernel.org,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Zheyu Ma <zheyuma97@gmail.com>
Subject: Re: [PATCH net-next] net: arcnet: com20020-pci: fix support for
 2.5Mbit cards
Message-ID: <aY3rhuzCG-SdRrC2@horms.kernel.org>
References: <20260205065113.33547-1-enelsonmoore@gmail.com>
 <aYoAMrEVDNydXQdq@horms.kernel.org>
 <CADkSEUjdGka7vpZEKrF0a0R1S=S+bzjCpDRidF5d93_H7b2qtw@mail.gmail.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CADkSEUjdGka7vpZEKrF0a0R1S=S+bzjCpDRidF5d93_H7b2qtw@mail.gmail.com>
X-DKIM: signer='kernel.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-1.2 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [172.234.253.10 listed in list.dnswl.org]
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: -11

On Mon, Feb 09, 2026 at 01:58:38PM -0800, Ethan Nelson-Moore wrote:
> Hi, Simon,
> 
> On Mon, Feb 9, 2026 at 7:41 AM Simon Horman <horms@kernel.org> wrote:
> > I do wonder if this should be targeted at net rather than net-next.
> Should I send a new version redone against net, or will this be taken
> care of by a maintainer?

I'm unsure.
But at this point - a few days have past - I'd lean towards reposting for net.


From - Thu Feb 12 17:52:58 2026
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-215974-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id WF6SDGnsjWmVSyMAYBR5ng
	(envelope-from <stable+bounces-215974-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Thu, 12 Feb 2026 15:06:17 +0000
Return-path: <stable+bounces-215974-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Thu, 12 Feb 2026 15:06:17 +0000
Received: from tor.lore.kernel.org ([172.105.105.114])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-215974-hi=josie.lol@vger.kernel.org>)
	id 1vqYGm-0000000Am2t-3ua9
	for hi@josie.lol;
	Thu, 12 Feb 2026 15:06:17 +0000
Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1])
	by tor.lore.kernel.org (Postfix) with ESMTP id 01F53300B986
	for <hi@josie.lol>; Thu, 12 Feb 2026 15:06:16 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id A05A42E7BD3;
	Thu, 12 Feb 2026 15:06:13 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d5BsC5DV"
X-Original-To: stable@vger.kernel.org
