igned-off-by: Chuck Lever > > Would it make sense to also backport: > > commit 442d27ff09a218b61020ab56387dbc508ad6bfa6 > Author: Stephen Smalley > Date: Fri May 3 09:09:06 2024 -0400 > > nfsd: set security label during create operations > > ? It seems like that's fixing a similar kind of bug, and would also > make the upstream version of this apply cleanly. I'll have another look. I think 442d27ff09a218b61020ab56387dbc508ad6bfa6 had some significant pre-requisites. >> Signed-off-by: Greg Kroah-Hartman >> --- >> fs/nfsd/vfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- a/fs/nfsd/vfs.c >> +++ b/fs/nfsd/vfs.c >> @@ -1335,7 +1335,7 @@ nfsd_create_setattr(struct svc_rqst *rqs >> * Callers expect new file metadata to be committed even >> * if the attributes have not changed. >> */ >> - if (iap->ia_valid) >> + if (iap->ia_valid || attrs->na_pacl || attrs->na_dpacl) >> status = nfsd_setattr(rqstp, resfhp, attrs, 0, (time64_t)0); >> else >> status = nfserrno(commit_metadata(resfhp)); >> >> > -- Chuck Lever From - Sun Jan 18 19:08:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id qBckAy8tbWmwtxwAYBR5ng (envelope-from ) for ; Sun, 18 Jan 2026 18:57:51 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sun, 18 Jan 2026 18:57:51 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vhXyA-000000088UC-3RoB for hi@josie.lol; Sun, 18 Jan 2026 18:57:51 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id E96E73009741 for ; Sun, 18 Jan 2026 18:57:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59EF9257435; Sun, 18 Jan 2026 18:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kKAXgJ2d" X-Original-To: stable@vger.kernel.org Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03C4A1A316E for ; Sun, 18 Jan 2026 18:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768762663; cv=none; b=ZLVuklAiQjwcRyrevD4qkpPQRt5ypWDg05UlVpXU75KfiKxLLBTrLfMmjg5oV7DY+Y+ZO6DHeT6pKjpveBxMG+dq6swqsxr3Fx9ekDGk8J/ftsKd4dTDYU/4yJmaAT5mChbgRKzJoCYzcBEgfgPrbAgkj4+16l1XMchfq460CKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768762663; c=relaxed/simple; bh=uEH6tkrhwnjKM1uvdiIJIJXExMuu7hcx+AmXyWxFOOA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nI2/WoWgZmsZ9/8aC+xPUCLoIuZgdYCEyYXjNiV5te6WQ9BUnxkAUMelI0+F1zFyS4wYjx60e0tp0SMYCLrcVxr5fVRPW7H4gvPYLir45MURbUb8W0Tt0rYEKne3yU4Kk+3JenJPiyn4ldiQDd2lO8PvseDzSPCOF9nT1cEF+u4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kKAXgJ2d; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com A