linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://docs.mxroute.com/docs/expert-spam-filtering.html --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 0.0 RCVD_IN_ZEN_BLOCKED_OPENDNS RBL: ADMINISTRATOR NOTICE: The query to zen.spamhaus.org was blocked due to usage of an open resolver. See https://www.spamhaus.org/returnc/pub/ [172.234.253.10 listed in zen.spamhaus.org] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 > > > > > Oh, good point. In that case, I think it makes sense to add the flag asap, so > > > > > that _if_ it turns out that KVM needs to consume a field that isn't currently > > > > > saved/restored, we'll at least have a better story for KVM's that save/restore > > > > > everything. > > > > > > > > Not sure I follow. Do you mean start serializing everything and setting > > > > the flag ASAP (which IIUC would be after the rework we discussed), > > > > > > Yep. > > > > I don't think it matters that much when we start doing this. In all > > cases: > > > > 1. KVM will need to be backward-compatible. > > > > 2. Any new features that depend on save+restore of those fields will be > > a in a new KVM that does the 'full' save+restore (assuming we don't let > > people add per-field flags). > > > > The only scenario that I can think of is if a feature can be enabled at > > runtime, and we want to be able to enable it for a running VM after > > migrating from an old KVM to a new KVM. Not sure how likely this is. > > The scenario I'm thinking of is where we belatedly realize we should have been > saving+restoring a field for a feature that is already supported, e.g. gpat. If > KVM saves+restores everything, then we don't have to come up with a hacky solution > for older KVM, because it already provides the desired behavior for the "save", > only the "restore" for the older KVM is broken. > > Does that make sense? It makes sense in my head, but I'm not sure I communicated > the idea very well... Kinda? What I am getting at is that we'll always have an old KVM that doesn't save everything that we'll need to handle. I think the scenario you have in mind is where we introduce a feature *after* we start saving everything, and at a later point realize we didn't add proper "restore" support, but the "save" support must have always been there. gPAT is not a good example because it's in the "save" area :P But yeah, I see your point. It's not very straightforward now because what we save comes from the cache, and we only cache what we need for the current set of features. So this will need to be done on top of the rework we've been discussing, where vmcb02 starts being the source of truth instead of the cache, then we just (mostly) save vmcb02's control area as-is. From - Mon Feb 23 17:30:38 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id YEmHKbmOnGl4iDkAYBR5ng (envelope-from ) for ; Mon, 23 Feb 2026 17:30:33 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Mon, 23 Feb 2026 17:30:33 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vuZlR-0000000Gsvw-0xfk for hi@josie.lol; Mon, 23 Feb 2026 17:30:33 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 504283141288 for ; Mon, 23 Feb 2026 17:23:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C618333121C; Mon, 23 Feb 2026 17:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudlinux.com header.i=@cloudlinux.com header.b="WhYq0RsR" X-Original-To: stable@vger.kernel.org Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C969330B10 for ; Mon, 23 Feb 2026 17:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771867428; cv=none; b=sy/GGyFM48n47dSMvhWoylNmxXQYh3y02uQFGGjPSMxBfjQUulbxBNhVJ46Y0BFjnwne3jIbohri5B/E5LF6PJ+UX5DNS5k5ovwmeedWdzjx5/ySkeMOJX+C1tt0blXaP8zOLfp6f4TVfde/NCJLO1vL5uiH7V240+64jm5Yuww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771867428; c=relaxed/simple; bh=HdKcWIRXvLVamXfF7ZeFDsbncN9MIo9MT+ODsJsfhJQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=T0cVwIcPuBsUDjIYnryUJ2+XoS0DuPOL4sxbNb+iHM7SRik3OpCbHDc361132dE2y8awD0a0nbZi+1ZRF3SO8trzJBpWhzrlW1NgkrR/5z7yB19CBYi2hgwX/9RUrffzW75Fzdna/PCxuxAn3PdMt5Nt5Qrk6umJ/ONbj/57dL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cloudlinux.com; spf=pass smtp.mailfrom=cloudlinux.com; dkim=pass (2048-bit key) header.d=cloudlinux.com header.i=@cloudlinux.com header.b=WhYq0RsR; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cloudlinux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudlinux.com Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8230c33f477so1965146b3a.2 for ; Mon, 23 Feb 2026 09:23:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudlinux.com; s=google; t=1771867426; x=1772472226; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zYRTIPm2XKejelZxbfd12xi/Cr57PQ2HDO5pVWa4Q2s=; b=WhYq0RsRCnlbtAKr2ltNZSDCkeP14tGRpIL/sJXdbaFn0Dm7SYWC+2sJ1WG3FAvk3r ILHa97xtaZllAllCUpCzlCWhsDIzQTuN+s5j7oLGdi9YPfyI2VqnLBl1/WinK8Rs5PyD GEHQqpj0IUB7hksddWdEGldz3NetNbtvt+gHSiVQO7NsF99OW7cYNa3rzYFfKGsB6lX1 v6b8ou4OubnWs6oc9HWMsw3FxdmX9OpzG7/rCIL467mVdUhRqh3IJysj