g> To: Vinod Koul , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Miaoqian Lin Cc: stable@vger.kernel.org In-Reply-To: <20251027060601.33228-1-linmq006@gmail.com> References: <20251027060601.33228-1-linmq006@gmail.com> Subject: Re: [PATCH] slimbus: ngd: Fix reference count leak in qcom_slim_ngd_notify_slaves Message-Id: <176275952201.16494.2036590483704839905.b4-ty@kernel.org> Date: Mon, 10 Nov 2025 07:25:22 +0000 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [147.75.80.249 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 On Mon, 27 Oct 2025 14:06:01 +0800, Miaoqian Lin wrote: > The function qcom_slim_ngd_notify_slaves() calls of_slim_get_device() which > internally uses device_find_child() to obtain a device reference. > According to the device_find_child() documentation, > the caller must drop the reference with put_device() after use. > > Found via static analysis and this is similar to commit 4e65bda8273c > ("ASoC: wcd934x: fix error handling in wcd934x_codec_parse_data()") > > [...] Applied, thanks! [1/1] slimbus: ngd: Fix reference count leak in qcom_slim_ngd_notify_slaves commit: 79d84af332094852614b15638f7ffe18f5f7966e Best regards, -- Srinivas Kandagatla From - Mon Nov 10 07:32:34 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id EDVhJw+VEWl/QScAYBR5ng (envelope-from ) for ; Mon, 10 Nov 2025 07:32:31 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Mon, 10 Nov 2025 07:32:31 +0000 Received: from dfw.mirrors.kernel.org ([142.0.200.124]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vIMO7-0000000Bj2f-0nbA for hi@josie.lol; Mon, 10 Nov 2025 07:32:31 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with ciph