feiffer , Review requested Message-ID: Subject: [kubernetes-sigs/karpenter-provider-ibm-cloud] fix(ci): vendor/gen order (PR #477) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6953b851309bb_fa10d01051240"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: containermom X-GitHub-Recipient: pfeifferj X-GitHub-Reason: review_requested List-ID: kubernetes-sigs/karpenter-provider-ibm-cloud List-Archive: https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud List-Post: List-Unsubscribe: , List-Unsubscribe-Post: List-Unsubscribe=One-Click X-GitHub-Notify-Platform: newsies X-GitHub-Labels: cncf-cla: yes; size/S X-GitHub-Assignees: X-GitHub-PullRequestStatus: open X-Auto-Response-Suppress: All destinations: github@josie.lol X-GitHub-Recipient-Address: github@josie.lol X-DKIM: signer='github.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -2.0 (--) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-2.0 points) --- pts rule name description ---- ---------------------- ----------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [192.30.252.203 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [192.30.252.203 listed in wl.mailspike.net] 1.5 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -19 ----==_mimepart_6953b851309bb_fa10d01051240 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ## Description <!-- Describe your changes in detail --> ## Type of change <!-- Please delete options that are not relevant --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Helm chart change - [ ] Other (please describe) ## Testing <!-- Please describe the tests you ran to verify your changes --> - [ ] Unit tests added/updated - [ ] Helm chart tests pass (`helm lint` and template validation) - [ ] Tested changes manually - [ ] Added examples for new features ## Checklist <!-- Please check all that apply --> - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have updated the relevant CRDs if needed - [ ] I have updated the Helm chart version if needed - [ ] I have added tests that prove my fix is effective or that my feature works ## Additional context <!-- Add any other context about the pull request here --> You can view, comment on, or merge this pull request online at: https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud/pull/477 -- Commit Summary -- * fix(ci): vendor/gen order -- File Changes -- M .github/workflows/go-test.yaml (12) M charts/crds/karpenter-ibm.sh_ibmnodeclasses.yaml (9) M pkg/apis/v1alpha1/zz_generated.deepcopy.go (5) -- Patch Links -- https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud/pull/477.patch https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud/pull/477.diff -- Reply to this email directly or view it on GitHub: https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud/pull/477 You are receiving this because your review was requested. Message ID: <kubernetes-sigs/karpenter-provider-ibm-cloud/pull/477@github.com> ----==_mimepart_6953b851309bb_fa10d01051240 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Helm chart change
  • Other (please describe)

Testing

  • Unit tests added/updated
  • Helm chart tests pass (helm lint and template validation)
  • Tested changes manually
  • Added examples for new features

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated the relevant CRDs if needed
  • I have updated the Helm chart version if needed
  • I have added tests that prove my fix is effective or that my feature works

Additional context

You can view, comment on, or merge this pull request online at:

  https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud/pull/477

Commit Summary

  • 07f6ecc fix(ci): vendor/gen order

File Changes

(3 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: <kubernetes-sigs/karpenter-provider-ibm-cloud/pull/477@github.com>

----==_mimepart_6953b851309bb_fa10d01051240-- From - Tue Dec 30 11:32:43 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id OK1jDFi4U2kmUyEAYBR5ng (envelope-from ) for ; Tue, 30 Dec 2025 11:32:40 +0000 Return-path: Envelope-to: github@josie.lol Delivery-date: Tue, 30 Dec 2025 11:32:40 +0000 Received: from out-25.smtp.github.com ([192.30.252.208]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vaXxw-00000009Fix-0EDg for github@josie.lol; Tue, 30 Dec 2025 11:32:40 +0000 Received: from github.com (hubbernetes-node-2b4eaac.ash1-iad.github.net [10.56.128.74]) by smtp.github.com (Postfix) with ESMTPA id 975F61410B8 for ; Tue, 30 Dec 2025 03:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2023; t=1767094359; bh=LxZoFahOXg+wo2hzkxoNmZP5xvZI9Hk4PSYHBOHaMNM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:List-Unsubscribe-Post: From; b=CQ/BIVFBTIWDIFBTN2n6q/F3zzbWZMupJJGljDg4hVF+3jNiOh1ZOPFRSX5yqD2AS eMXzJd3twzoMiU5KS7Zp8PUSW0U1DvOrhk6A9V2Zls+ikVnJl2tCAZelYdG093VsVf QyAlmg3dDwp9rhOkBQsmVnvLrZlUY9RXMuuIgIIk= Date: Tue, 30 Dec 2025 03:32:39 -0800 From: Kubernetes Prow Robot Reply-To: kubernetes-sigs/karpenter-provider-ibm-cloud To: kubernetes-sigs/karpenter-provider-ibm-cloud Cc: Josephine Pfeiffer , Review requested Message-ID: In-Reply-To: References: Subject: Re: [kubernetes-sigs/karpenter-provider-ibm-cloud] fix(ci): vendor/gen order (PR #477) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6953b857942d6_10210d0104181b"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: k8s-ci-robot X-GitHub-Recipient: pfeifferj X-GitHub-Reason: review_requested List-ID: kubernetes-sigs/karpenter-provider-ibm-cloud List-Archive: https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud List-Post: List-Unsubscribe: , List-Unsubscribe-Post: List-Unsubscribe=One-Click X-GitHub-Notify-Platform: newsies X-GitHub-Labels: cncf-cla: yes; size/S X-GitHub-Assignees: X-GitHub-PullRequestStatus: open X-Auto-Response-Suppress: All destinations: github@josie.lol X-GitHub-Recipient-Address: github@josie.lol X-DKIM: signer='github.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -0.7 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-0.7 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HTML_MESSAGE BODY: HTML included in message 1.3 HTML_IMAGE_ONLY_24 BODY: HTML: images with 2000-2400 bytes of words -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [192.30.252.208 listed in wl.mailspike.net] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [192.30.252.208 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -6 ----==_mimepart_6953b857942d6_10210d0104181b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @k8s-ci-robot requested your review on: kubernetes-sigs/karpenter-provider-ibm-cloud#477 fix(ci): vendor/gen order. -- Reply to this email directly or view it on GitHub: https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud/pull/477#event-21792313951 You are receiving this because your review was requested. Message ID: ----==_mimepart_6953b857942d6_10210d0104181b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

@k8s-ci-robot requested your r= eview on: #477 fix(ci): vendor/gen order.

&m= dash;
Reply to this email directly, vi= ew it on GitHub, or unsub= scribe.
You are receiving this because your review was requested= .3D""Message ID: <kub= ernetes-sigs/karpenter-provider-ibm-cloud/pull/477/issue_event/2179231395= 1@github.com>

= ----==_mimepart_6953b857942d6_10210d0104181b-- From - Tue Dec 30 11:32:44 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id eKvuFVi4U2mE8RkAYBR5ng (envelope-from ) for ; Tue, 30 Dec 2025 11:32:40 +0000 Return-path: Envelope-to: github@josie.lol Delivery-date: Tue, 30 Dec 2025 11:32:40 +0000 Received: from out-20.smtp.github.com ([192.30.252.203]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vaXxw-00000009Fj7-0YlF for github@josie.lol; Tue, 30 Dec 2025 11:32:40 +0000 Received: from github.com (hubbernetes-node-83f90db.va3-iad.github.net [10.48.165.23]) by smtp.github.com (Postfix) with ESMTPA id D22363C0DE7 for ; Tue, 30 Dec 2025 03:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2023; t=1767094359; bh=Ki9lnrx2J1Vc1t4ML+AL3tJMetdaCSAmf0iUNofUZ5Y=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:List-Unsubscribe-Post: From; b=IlRJ8t86G8nhrW5lQyAR8INiVKpFK1F+Ryffb+XSz3oCDc3Q3fbKlEw/4RL8Rbt2v cpzb1n/w27yUlqHM1OxZGYsDC8Nz8waVs5OINRQB/4MtPoyrHOgBySbmt+h5UTczj5 7DwQYUQuk85VONZYniL6LZ6/tsum+lNjaydY4HRI= Date: Tue, 30 Dec 2025 03:32:39 -0800 From: Kubernetes Prow Robot Reply-To: kubernetes-sigs/karpenter-provider-ibm-cloud To: kubernetes-sigs/karpenter-provider-ibm-cloud Cc: Josephine Pfeiffer , Review requested Message-ID: In-Reply-To: References: Subject: Re: [kubernetes-sigs/karpenter-provider-ibm-cloud] fix(ci): vendor/gen order (PR #477) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6953b857bc327_10310d010082f8"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: k8s-ci-robot X-GitHub-Recipient: pfeifferj X-GitHub-Reason: review_requested List-ID: kubernetes-sigs/karpenter-provider-ibm-cloud List-Archive: https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud List-Post: List-Unsubscribe: , List-Unsubscribe-Post: List-Unsubscribe=One-Click X-GitHub-Notify-Platform: newsies X-GitHub-Labels: cncf-cla: yes; size/S X-GitHub-Assignees: X-GitHub-PullRequestStatus: open X-Auto-Response-Suppress: All destinations: github@josie.lol X-GitHub-Recipient-Address: github@josie.lol X-DKIM: signer='github.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -2.0 (--) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-2.0 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: githubusercontent.com] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [192.30.252.203 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [192.30.252.203 listed in wl.mailspike.net] 1.5 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -19 ----==_mimepart_6953b857bc327_10310d010082f8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit k8s-ci-robot left a comment (kubernetes-sigs/karpenter-provider-ibm-cloud#477) [APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *containermom* **Once this PR has been reviewed and has the lgtm label**, please assign [pfeifferj](https://github.com/pfeifferj) for approval. For more information see [the Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process). The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fkarpenter-provider-ibm-cloud).
Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
-- Reply to this email directly or view it on GitHub: https://github.com/kubernetes-sigs/karpenter-provider-ibm-cloud/pull/477#issuecomment-3699086216 You are receiving this because your review was requested. Message ID: ----==_mimepart_6953b857bc327_10310d010082f8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: containermom
Once this PR has been reviewed and has the lgtm label, p= lease assign pfeifferj for a= pproval. For more information see t= he Code Review Process.

The full list of commands accepted by this bot can be fou= nd here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /app= rove cancel in a comment

&m= dash;
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.3D""Message ID: <kubernetes-sigs/karpenter-provider-ibm-c= loud/pull/477/c3699086216@github.<= /span>com>

----==_mimepart_6953b857bc327_10310d010082f8-- From - Tue Dec 30 11:42:13 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id aIEUL5G6U2nELCIAYBR5ng (envelope-from ) for ; Tue, 30 Dec 2025 11:42:09 +0000 Return-path: Envelope-to: github@josie.lol Delivery-date: Tue, 30 Dec 2025 11:42:09 +0000 Received: from out-22.smtp.github.com ([192.30.252.205]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vaY77-00000009dUv-2gTH for github@josie.lol; Tue, 30 Dec 2025 11:42:09 +0000 Received: from github.com (hubbernetes-node-60932be.ac4-iad.github.net [10.52.153.56]) by smtp.github.com (Postfix) with ESMTPA id 59A3B2114B for ; Tue, 30 Dec 2025 03:42:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2023; t=1767094929; bh=k5xQoEid3yNt9cvGpZ95JAED8eRjKVfINOGd+P6w6vc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Po--- 0.0.1 |checksum:f81eefdbb81a94c09d9946df56b0f3625f9561f11d51e1fa3d0b0475600a8951 0.0.2 |checksum:d1d7cb04d53a1c37eb25c048a327d9826298e0976e24ec9f1e4c5acf5947a0e5 0.1.0 |checksum:09e2b2185b65f057d3484b303c179d83099b0421c126320696227cfeeeab660a 0.1.1 |checksum:c8cca54dac326ce61b13434e77e23cd6b0cc9a4ecad8117d45385aeef726b151 0.1.2 |checksum:c041a7ea8002b0d331882cff13b2d030f80c806362f4f9697a75002f0201d13d 0.5.0 |checksum:b6ff937302cea238fad941f500c2fd04c63d14768fe7fd6c75e96c6ff5ebe1ba 0.5.1 |checksum:37c87e23a9946f2d36a3199edf6da82414187af009f2c258ee94451065ee26ee 1.0.0 |checksum:a3179cf9385a5b90e80e66339d165fd64ad1bea1b9c9e6a6318b6f8803bf06cc 1.0.1 |checksum:77301bba81b7e631dc4bd3dad4de68c7fc6e8d3bb2d76f3b0fb6cf67b2120375 1.1.0 |checksum:4b7fc488743be064e88e3d6e3322bccb780916baaa097f2c33d4c54458467f33