Qpq+euqRl99kqmgTJFrcjUnXQTSU9 I2BtKqHN8sMMxk5FW7/41y3nTiLTt9wlSMOgJKvbYP0PNhJhFUOdKYzH49cLv0xXiW lj3r4OmNqQlxvW4/AfxxtgPTpgOpaRevzbkIQZ8+RSk1mCXq4Ld0yX9x9pEaSsXhd+ tSRZnzJeZOZNbczRtKmE8XDucUY2vIY02W3EzKxDQbZ2ehGrR5Yv2NMCeAEgwBZcmM SLKdchcqT9Klw== Date: Tue, 21 Oct 2025 14:10:04 -0500 From: Bjorn Helgaas To: "Bandi, Ravi Kumar" Cc: "mani@kernel.org" , "thippeswamy.havalige@amd.com" , "lpieralisi@kernel.org" , "bhelgaas@google.com" , "linux-pci@vger.kernel.org" , "kwilczynski@kernel.org" , "robh@kernel.org" , "michal.simek@amd.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Stefan Roese , Sean Anderson Subject: Re: [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts Message-ID: <20251021191004.GA1205652@bhelgaas> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [147.75.80.249 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 On Tue, Oct 21, 2025 at 05:46:17PM +0000, Bandi, Ravi Kumar wrote: > > On Oct 21, 2025, at 10:23 AM, Bjorn Helgaas wrote: > > On Sat, Sep 20, 2025 at 10:52:32PM +0000, Ravi Kumar Bandi wrote: > >> The pcie-xilinx-dma-pl driver does not enable INTx interrupts > >> after initializing the port, preventing INTx interrupts from > >> PCIe endpoints from flowing through the Xilinx XDMA root port > >> bridge. This issue affects kernel 6.6.0 and later versions. > >> > >> This patch allows INTx interrupts generated by PCIe endpoints > >> to flow through the root port. Tested the fix on a board with > >> two endpoints generating INTx interrupts. Interrupts are > >> properly detected and serviced. The /proc/interrupts output > >> shows: > >> > >> [...] > >> 32: 320 0 pl_dma:RC-Event 16 Level 400000000.axi-pcie, azdrv > >> 52: 470 0 pl_dma:RC-Event 16 Level 500000000.axi-pcie, azdrv > >> [...] > >> > >> Changes since v1:: > >> - Fixed commit message per reviewer's comments > >> > >> Fixes: 8d786149d78c ("PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver") > >> Cc: stable@vger.kernel.org > >> Signed-off-by: Ravi Kumar Bandi > > > > Hi Ravi, obviously you tested this, but I don't know how to reconcile > > this with Stefan's INTx fix at > > https://lore.kernel.org/r/20251021154322.973640-1-stefan.roese@mailbox.org > > > > Does Stefan's fix need to be squashed into this patch? > > Sure, we can squash Stefan’s fix into this. I know we *can* squash them. I want to know why things worked for you and Stefan when they *weren't* squashed: - Why did INTx work for you even without Stefan's patch. Did you get INTx interrupts but not the right ones, e.g., did the device signal INTA but it was received as INTB? - Why did Stefan's patch work for him even without your patch. How could Stefan's INTx work without the CSR writes to enable interrupts? - Why you mentioned "kernel 6.6.0 and later versions." 8d786149d78c appeared in v6.7, so why would v6.6.0 would be affected? > >> +++ b/drivers/pci/controller/pcie-xilinx-dma-pl.c > >> @@ -659,6 +659,12 @@ static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port) > >> return err; > >> } > >> > >> + /* Enable interrupts */ > >> + pcie_write(port, XILINX_PCIE_DMA_IMR_ALL_MASK, > >> + XILINX_PCIE_DMA_REG_IMR); > >> + pcie_write(port, XILINX_PCIE_DMA_IDRN_MASK, > >> + XILINX_PCIE_DMA_REG_IDRN_MASK); > >> + > >> return 0; > >> } From - Tue Oct 21 19:22:37 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id kNBCNHnd92irvAoAYBR5ng (envelope-from ) for ; Tue, 21 Oct 2025 19:22:33 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Tue, 21 Oct 2025 19:22:33 +0000 Received: from am.mirrors.kernel.org ([147.75.80.249]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vBHwH-00000003FEa-1vbG for hi@josie.lol; Tue, 21 Oct 2025 19:22:33 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8DE8B18A623F for ; Tue, 21 Oct 2025 19:22:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A720A34A3A6; Tue, 21 Oct 2025 19:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OHG6pFSo" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C9A338903 for ; Tue, 21 Oct 2025 19:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761074548; cv=none; b=Rc3yJgUqdD/WrMH/1hWixnpxh/5c7orY00b/4C/i4/eqG7vsh6WFZeKSNL5om9CovK8li5jupFl3hHzT1V9O4Enl6lIXSog1jaVQESePyiIGbmc+qlZi2W/eUa13O2ujkaWZva2l8InLaDbIP+xDclht5/1PASLsl9w/RHLLdS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761074548; c=relaxed/simple; bh=lYiLOSIv41E66nSgKgtX032B2kkuG+mtkwEQCSxWM3c=; h=From:To:Cc:Subject:Date:Message-ID:In-Rep