eceived: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id OJm5GiD89WhA1BIAYBR5ng
	(envelope-from <stable+bounces-188003-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Mon, 20 Oct 2025 09:08:48 +0000
Return-path: <stable+bounces-188003-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Mon, 20 Oct 2025 09:08:48 +0000
Received: from sv.mirrors.kernel.org ([139.178.88.99])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-188003-hi=josie.lol@vger.kernel.org>)
	id 1vAlsm-00000005R3G-0z9R
	for hi@josie.lol;
	Mon, 20 Oct 2025 09:08:48 +0000
Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by sv.mirrors.kernel.org (Postfix) with ESMTPS id 364A53E55D1
	for <hi@josie.lol>; Mon, 20 Oct 2025 09:08:45 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id CD56A2E972D;
	Mon, 20 Oct 2025 09:08:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="abag3KVA"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7BAB2E9ECE
	for <stable@vger.kernel.org>; Mon, 20 Oct 2025 09:08:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1760951323; cv=none; b=H6hqcIQxRNChzrIRFmvJw/HugipoEBYsnp5C//WGp7U+ySLObnMmMuMumtAZeEF0jAwroq13rmgdtNpfxemiukheKCDc+1p1FeB4rYozOjzvur+11swFeAcgpLvNtxQLXbL8smRDAajXeynZXnSLrFSq/q87bowtuOUPXcX4pXw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1760951323; c=relaxed/simple;
	bh=nOCn/6Ihk+X2zaF5Y7/xvQO86uWR2f9akZzxRl3+rDY=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=H4CuTbcfDqTSSgnVUl3JLiyXoVofTOQh3pMCoIS7ScgRIUg10nnqQoviNYodBvmEiMYJjZt/t4e9Nnv4jxJk1WkMHJ9uKYMXiaS3TEUJHNElJM0pkEVhy66o2qEBVDsDNZ8i85FrvNazcBRZf804rjyCaVfLqMX7W0kEbT5CsA4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=abag3KVA; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCF22C4CEFE;
	Mon, 20 Oct 2025 09:08:42 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1760951323;
	bh=nOCn/6Ihk+X2zaF5Y7/xvQO86uWR2f9akZzxRl3+rDY=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=abag3KVAB9Z0/ef9AAnfjajpsWasgVv8x2Blg3r06oImQy+899pHBc1/iB2XddKud
	 +MxxFltx1vL08lYZyaGMuCPz8kjJHlbaQBX+SUqqJakfOCGI0C5pdGhuS4DZQHTHEz
	 abHfHUgVzPHM5kMG9LtvGW10bUPnR+0NC8ge+fn0=
Date: Mon, 20 Oct 2025 11:08:40 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Timothy Pearson <tpearson@raptorengineering.com>
Cc: stable <stable@vger.kernel.org>
Subject: Re: [PATCH 6.12.y] drm/amd/display: fix dmub access race condition
Message-ID: <2025102005-praying-overlord-eb5d@gregkh>
References: <389171823.1798956.1760724071998.JavaMail.zimbra@raptorengineeringinc.com>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <389171823.1798956.1760724071998.JavaMail.zimbra@raptorengineeringinc.com>
X-DKIM: signer='linuxfoundation.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
                             blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: linuxfoundation.org]
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [139.178.88.99 listed in list.dnswl.org]
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

On Fri, Oct 17, 2025 at 01:01:12PM -0500, Timothy Pearson wrote:
> +/**
> + * struct dm_vupdate_work - Work data for periodic action in idle
> + * @work: Kernel work data for the work event
> + * @adev: amdgpu_device back pointer
> + * @stream: DC stream associated with the crtc
> + * @adjust: DC CRTC timing adjust to be applied to the crtc
> + */
> +struct vupdate_offload_work {
> +       struct work_struct work;
> +       struct amdgpu_device *adev;
> +       struct dc_stream_state *stream;
> +       struct dc_crtc_timing_adjust *adjust;
> +};

What happened to the proper formatting of this structure?  You lost all
tabs :(

Please fix up and resend.

thanks,

greg k-h


From - Mon Oct 20 09:17:45 2025
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <hca@linux.ibm.com>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id GMEzNDb+9WjMNxIAYBR5ng
	(envelope-from <hca@linux.ibm.com>)
	for <hi@josie.lol>; Mon, 20 Oct 2025 09:17:42 +0000
Return-path: <hca@linux.ibm.com>
Envelope-to: hi@josie.lol
Delivery-date: Mon, 20 Oct 2025 09:17:42 +0000
Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5])
	by witcher.mxrouting.net with esmtps  (TLS1.2) tls TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <hca@linux.ibm.com>)
	id 1vAm1O-00000005iR6-2syv
	for hi@josie.lol;
	Mon, 20 Oct 2025 09:17:42 +0000
Received: from pps.filterd (m0360072.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59K1nWil009802;
	Mon, 20 Oct 2025 09:17:41 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc
	:content-type:date:from:in-reply-to:message-id:mime-version
	:references:subject:to; s=pp1; bh=M+py6AMn6297S/l7VDb2nflKXjz0fa
	MooP7b1M94RtE=; b=sMJt27OGuY2hWtLarqchUfmAhq/Jv61yactrinVfn9PEfN
	Za3T8Kt8LoQv6dHah9WxMI4NNGWoqRLvbbsMWjrEJ2SX5gISaiHoGOM6c9LlXXOm
	57mPIcpNWzOpbOOiloDPE8dlHlabWS9KgDEjwpwIjHxScgRgCLl90ajJizu4fCxR
	VIJ3vr5G0bQYKNig7F2LubAMvywPgXRl6oqfqN7qAZfcFg/dS6vnIv1zYXZyzpb4
	wU6VY1BLNWIAq23TY1dDFy772y8fdWnRqUOcJkoYsAYTf3U5hyv6GW3I+dC+xyD7
	TVdE0IEiDP2jyUX2FgFI4FMKyD36qJdc/qmxFjZg==
Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])
	by mx0a-001b2d01.pphosted.com (PPS) with ESMrnel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id uLRMAJz/9WiyVRMAYBR5ng
	(envelope-from <stable+bounces-188004-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Mon, 20 Oct 2025 09:23:40 +0000
Return-path: <stable+bounces-188004-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Mon, 20 Oct 2025 09:23:40 +0000
Received: from ams.mirrors.kernel.org ([213.196.21.55])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-188004-hi=josie.lol@vger.kernel.org>)
	id 1vAm79-00000005sxU-2kZZ
	for hi@josie.lol;
	Mon, 20 Oct 2025 09:23:39 +0000
Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ams.mirrors.kernel.org (Postfix) with ESMTPS id 5FB7C34908A
	for <hi@josie.lol>; Mon, 20 Oct 2025 09:23:38 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 73D37221FC4;
	Mon, 20 Oct 2025 09:23:35 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="go/uKGAV"
X-Original-To: stable@vger.kernel.org
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F92A189B80
	for <stable@vger.kernel.org>; Mon, 20 Oct 2025 09:23:34 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1760952215; cv=none; b=T1BHwVuoQ7F7vlxEOiNrv/DiKheBBxI0C4dfN8xdUrciI9P2iHs2iIJevIoL34BWupvT7Bz/magD2ZX+h067Ciz8+NK+PQeEQtdEf41Lp4ygyOmBt/ZfnJApClIgUNa7hjCqvgk1GFA2Is51dpWuYAKlDIYCbAI8DrrQ1s8IkqI=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1760952215; c=relaxed/simple;
	bh=nZ2duEGBug1ry5EV1Pgtv6Z12+XiUE08TBphyrRKAkc=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=rThzGpefZ4JlOVQTlWj6KbVb7B8oMwjzaErWByagSwJSz5kpXKMTbl//OEbsMNEqpUuprNJdDuZ94yRhDJHjtYSLe+sxww2fwjMzikXGKPaKNa592ke0UuvQurxErQxZgX3/+HtHo4w5K494TzDCLz0i9k6snjNwPallpxleI5M=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=go/uKGAV; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4874BC116C6;
	Mon, 20 Oct 2025 09:23:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1760952214;
	bh=nZ2duEGBug1ry5EV1Pgtv6Z12+XiUE08TBphyrRKAkc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=go/uKGAV01+gllfTX4IhEYyuqR4KCCwrV4WxUUKh/gfIpi5dSF/YCPLbtDS4uinPr
	 fyOaH20LZS9jw3nxmVFJafuyaJ8C8tCV8O9UySSapXUqdjUxlMWC7D5uNmUSZFRncL
	 xCSt3CCWpy5rJD3uZ8qIxVEzsMvzCdtz2s13shms=
Date: Mon, 20 Oct 2025 11:23:32 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Aakarsh Jain <aakarsh.jain@samsung.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH 6.6.y 3/5] media: s5p-mfc: constify s5p_mfc_hw_cmds
 structures
Message-ID: <2025102030-tribunal-level-9d7a@gregkh>
References: <2025101646-unfunded-bootlace-0264@gregkh>
 <20251017143208.3997488-1-sashal@kernel.org>
 <20251017143208.3997488-3-sashal@kernel.org>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20251017143208.3997488-3-sashal@kernel.org>
X-DKIM: signer='linuxfoundation.org' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [213.196.21.55 listed in list.dnswl.org]
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
 -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender
SpamTally: Final spam score: 4

On Fri, Oct 17, 2025 at 10:32:06AM -0400, Sasha Levin wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> [ Upstream commit c76c43d77869adc1709693ba532fe7fb4f30aa45 ]
> 
> Static "s5p_mfc_hw_cmds" structures are not modified by the driver, so
> they can be made const for code safety.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Stable-dep-of: 7fa37ba25a1d ("media: s5p-mfc: remove an unused/uninitialized variable")
> Signed-off-by: Sasha Levin <sashal@kernel.org>

This patch breaks the build, so I've dropped this whole series.  Can you
redo it and resend?

thanks,

greg k-h


From - Mon Oct 20 09:25:30 2025
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <linux-s390+bounces-14021-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id OGw5OwYA9min8REAYBR5ng
	(envelope-from <linux-s390+bounces-14021-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Mon, 20 Oct 2025 09:25:26 +0000
Return-path: <linux-s390+bounces-14021-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Mon, 20 Oct 2025 09:25:27 +0000
Received: from dfw.mirrors.kernel.org ([142.0.200.124])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <linux-s390+bounces-14021-hi=josie.lol@vger.kernel.org>)
	id 1vAm8s-00000005xT9-3Et0
	for hi@josie.lol;
	Mon, 20 Oct 2025 09:25:26 +0000
Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.mirrors.kernel.org (Postfix) with ESMTPS id 97F7C4E7E99
	for <hi@josie.lol>; Mon, 20 Oct 2025 09:25:25 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id DC8C72F5483;
	Mon, 20 Oct 2025 09:25:22 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="hjsK+JyU"
X-Original-To: linux-s390@vger.kernel.org
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No clieTPS id 49v31bymk7-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Mon, 20 Oct 2025 09:17:41 +0000 (GMT)
Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])
	by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59K7GO9k002381;
	Mon, 20 Oct 2025 09:17:41 GMT
Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])
	by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 49vqej4ruj-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Mon, 20 Oct 2025 09:17:40 +0000
Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100])
	by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59K9Hb9C58196394
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
	Mon, 20 Oct 2025 09:17:37 GMT
Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id 360AE20043;
	Mon, 20 Oct 2025 09:17:37 +0000 (GMT)
Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id E66C020040;
	Mon, 20 Oct 2025 09:17:36 +0000 (GMT)
Received: from osiris (unknown [9.111.49.232])
	by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS;
	Mon, 20 Oct 2025 09:17:36 +0000 (GMT)
Date: Mon, 20 Oct 2025 11:17:35 +0200
From: Heiko Carstens <hca@linux.ibm.com>
To: Josephine Pfeiffer <hi@josie.lol>
Cc: agordeev@linux.ibm.com, gerald.schaefer@linux.ibm.com, gor@linux.ibm.com,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] s390: ptdump: use seq_puts() in pt_dump_seq_puts()
 macro
Message-ID: <20251020091735.24715A05-hca@linux.ibm.com>
References: <20251018170521.3355738-1-hi@josie.lol>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20251018170521.3355738-1-hi@josie.lol>
X-TM-AS-GCONF: 00
X-Proofpoint-ORIG-GUID: bZ9wgrrJA0GouusrPaIBnzRzQTdwpKrB
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfXwdp7Fcg3u9/r
 Tx/QvK+o+1uCEqtSbTPpGMrSOFtmueamxFaOJVxXcbHvNzqVUisFl1kX18hpyuIMtIiAgLQA8Jc
 tJN1g6oe1hlvmhGbraFL1/4med4sjDZFGtiMJBxSNR91ureUQtIHgkbi8tAKZrV1rqULSzp16Yr
 iThxa687hV/70iz6fsyUjzV400h7R98A+KsfnJ3/BmuK0H9qoDh7wJ3kJ4PCxYjgIALV+1djwQj
 E8w6Uwpb71lR3BiC4APdiZ11u5qkf293I+3V2HCvuTnHGxtIbdZKJTwvQmPVOP6qt3xGnW9II/J
 oVLek3sZSkECKC2qUx4L+o4VlssdmnQ1OmjWDXvbFwpIbGJKE+UeH1/gN2qojDBK0+ahcc1HLKN
 qODzxVGnxJ0gNcTRE2wUx53gr+Iujg==
X-Proofpoint-GUID: bZ9wgrrJA0GouusrPaIBnzRzQTdwpKrB
X-Authority-Analysis: v=2.4 cv=SKNPlevH c=1 sm=1 tr=0 ts=68f5fe35 cx=c_pps
 a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17
 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22
 a=6jiyLf937yJjbL3lZ8UA:9 a=CjuIK1q_8ugA:10
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40
 definitions=2025-10-20_02,2025-10-13_01,2025-03-28_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 priorityscore=1501
 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0
 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0
 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022
X-DKIM: signer='ibm.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: -0.1 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (-0.1 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
                             envelope-from domain
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [148.163.158.5 listed in list.dnswl.org]
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [148.163.158.5 listed in wl.mailspike.net]
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
SpamTally: Final spam score: 0

On Sat, Oct 18, 2025 at 07:05:21PM +0200, Josephine Pfeiffer wrote:
> The pt_dump_seq_puts() macro incorrectly uses seq_printf() instead of
> seq_puts(). This is both a performance issue and conceptually wrong,
> as the macro name suggests plain string output (puts) but the
> implementation uses formatted output (printf).
> 
> The macro is used in dump_pagetables.c:67-68 and 131 to output
> constant strings. Using seq_printf() adds unnecessary overhead for
> format string parsing.
> 
> This bug was introduced in commit 6bf9a639e76e1 ("s390/mm,ptdump: make
> page table dumping seq_file optional") in 2020, which explicitly stated
> it was the "s390 version of commit ae5d1cf358a5 ("arm64: dump: Make the
> page table dumping seq_file optional")", copying the buggy arm64
> implementation.
> 
> Fixes: 6bf9a639e76e1 ("s390/mm,ptdump: make page table dumping seq_file optional")
> Signed-off-by: Josephine Pfeiffer <hi@josie.lol>
...
> -		seq_printf(__m, fmt);		\
> +		seq_puts(__m, fmt);		\

So yes, it should have been seq_puts() instead of seq_printf(), but
there really is no _bug_ here, except of wasted CPU cycles for a seq
file which isn't enabled in any production kernel.

I'll apply this and change the commit message accordingly.

Thanks!

From - Mon Oct 20 09:17:51 2025
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <linux-s390+bounces-14020-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id yF9OETz+9WgflRAAYBR5ng
	(envelope-from <linux-s390+bounces-14020-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Mon, 20 Oct 2025 09:17:48 +0000
Return-path: <linux-s390+bounces-14020-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Mon, 20 Oct 2025 09:17:48 +0000
Received: from ams.mirrors.kernel.org ([213.196.21.55])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <linux-s390+bounces-14020-hi=josie.lol@vger.kernel.org>)
	id 1vAm1T-00000005iYn-3zRL
	for hi@josie.lol;
	Mon, 20 Oct 2025 09:17:48 +0000
Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ams.mirrors.kernel.org (Postfix) with ESMTPS id D395B347D8D
	for <hi@josie.lol>; Mon, 20 Oct 2025 09:17:46 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 835E033987;
	Mon, 20 Oct 2025 09:17:45 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="sMJt27OG"
X-Original-To: linux-s390@vger.kernel.org
Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEDDF2E9EB8;
	Mon, 20 Oct 2025 09:17:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1760951865; cv=none; b=LdoUHIh76HFVV4ROslR7gTgj/xpBjw+/kkt44IdjniOh8v8naFMNGIw0mEF8GnUZVlPtRorVON8QbqF8/iogWtc3xNXyyW7nN0AmIl4LN7y9hKOwsUETcsqr90j+R5omtLM8OrCWXrZe4q805PkuOwJJfJvOXOeRkTXlEV0SBks=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1760951865; c=relaxed/simple;
	bh=3l3wdWQKrGObOqU4MwS5hghEQARNxgr0FIg33Av1Tl0=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=sWJM8LNUUkg4W2YFc84g20o3VYO9h3ASLC7eaP82IaOBgrWfwjEZqiQGQvrdJWEzLnuuV98im+sZ/dycTIOlFo7QU5apXop2NIrA9FxubAAlIb1FnVmDIBpzXJBLZpRC5js5xql+jsY9uhketeqfrJg+YZEHseLEoG85K/WGVwk=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=sMJt27OG; arc=none smtp.client-ip=148.163.158.5
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com
Received: from pps.filterd (m0360072.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59K1nWil009802;
	Mon, 20 Oct 2025 09:17:41 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc
	:content-type:date:from:in-reply-to:message-id:mime-version
	:references:subject:to; s=pp1; bh=M+py6AMn6297S/l7VDb2nflKXjz0fa
	MooP7b1M94RtE=; b=sMJt27OGuY2hWtLarqchUfmAhq/Jv61yactrinVfn9PEfN
	Za3T8Kt8LoQv6dHah9WxMI4NNGWoqRLvbbsMWjrEJ2SX5gISaiHoGOM6c9LlXXOm
	57mPIcpNWzOpbOOiloDPE8dlHlabWS9KgDEjwpwIjHxScgRgCLl90ajJizu4fCxR
	VIJ3vr5G0bQYKNig7F2LubAMvywPgXRl6oqfqN7qAZfcFg/dS6vnIv1zYXZyzpb4
	wU6VY1BLNWIAq23TY1dDFy772y8fdWnRqUOcJkoYsAYTf3U5hyv6GW3I+dC+xyD7
	TVdE0IEiDP2jyUX2FgFI4FMKyD36qJdc/qmxFjZg==
Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])
	by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31bymk7-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Mon, 20 Oct 2025 09:17:41 +0000 (GMT)
Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])
	by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59K7GO9k002381;
	Mon, 20 Oct 2025 09:17:41 GMT
Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])
	by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 49vqej4ruj-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Mon, 20 Oct 2025 09:17:40 +0000
Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100])
	by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59K9Hb9C58196394
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
	Mon, 20 Oct 2025 09:17:37 GMT
Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id 360AE20043;
	Mon, 20 Oct 2025 09:17:37 +0000 (GMT)
Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id E66C020040;
	Mon, 20 Oct 2025 09:17:36 +0000 (GMT)
Received: from osiris (unknown [9.111.49.232])
	by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS;
	Mon, 20 Oct 2025 09:17:36 +0000 (GMT)
Date: Mon, 20 Oct 2025 11:17:35 +0200
From: Heiko Carstens <hca@linux.ibm.com>
To: Josephine Pfeiffer <hi@josie.lol>
Cc: agordeev@linux.ibm.com, gerald.schaefer@linux.ibm.com, gor@linux.ibm.com,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] s390: ptdump: use seq_puts() in pt_dump_seq_puts()
 macro
Message-ID: <20251020091735.24715A05-hca@linux.ibm.com>
References: <20251018170521.3355738-1-hi@josie.lol>
Precedence: bulk
X-Mailing-List: linux-s390@vger.kernel.org
List-Id: <linux-s390.vger.kernel.org>
List-Subscribe: <mailto:linux-s390+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-s390+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20251018170521.3355738-1-hi@josie.lol>
X-TM-AS-GCONF: 00
X-Proofpoint-ORIG-GUID: bZ9wgrrJA0GouusrPaIBnzRzQTdwpKrB
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfXwdp7Fcg3u9/r
 Tx/QvK+o+1uCEqtSbTPpGMrSOFtmueamxFaOJVxXcbHvNzqVUisFl1kX18hpyuIMtIiAgLQA8Jc
 tJN1g6oe1hlvmhGbraFL1/4med4sjDZFGtiMJBxSNR91ureUQtIHgkbi8tAKZrV1rqULSzp16Yr
 iThxa687hV/70iz6fsyUjzV400h7R98A+KsfnJ3/BmuK0H9qoDh7wJ3kJ4PCxYjgIALV+1djwQj
 E8w6Uwpb71lR3BiC4APdiZ11u5qkf293I+3V2HCvuTnHGxtIbdZKJTwvQmPVOP6qt3xGnW9II/J
 oVLek3sZSkECKC2qUx4L+o4VlssdmnQ1OmjWDXvbFwpIbGJKE+UeH1/gN2qojDBK0+ahcc1HLKN
 qODzxVGnxJ0gNcTRE2wUx53gr+Iujg==
X-Proofpoint-GUID: bZ9wgrrJA0GouusrPaIBnzRzQTdwpKrB
X-Authority-Analysis: v=2.4 cv=SKNPlevH c=1 sm=1 tr=0 ts=68f5fe35 cx=c_pps
 a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17
 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22
 a=6jiyLf937yJjbL3lZ8UA:9 a=CjuIK1q_8ugA:10
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40
 definitions=2025-10-20_02,2025-10-13_01,2025-03-28_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 priorityscore=1501
 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0
 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0
 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022
X-DKIM: signer='ibm.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-Spam-Score: 0.5 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.5 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
  0.0 RCVD_IN_DNSWL_BLOCKED  RBL: ADMINISTRATOR NOTICE: The query to
                             DNSWL was blocked.  See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block
                              for more information.
                             [213.196.21.55 listed in list.dnswl.org]
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 5

On Sat, Oct 18, 2025 at 07:05:21PM +0200, Josephine Pfeiffer wrote:
> The pt_dump_seq_puts() macro incorrectly uses seq_printf() instead of
> seq_puts(). This is both a performance issue and conceptually wrong,
> as the macro name suggests plain string output (puts) but the
> implementation uses formatted output (printf).
> 
> The macro is used in dump_pagetables.c:67-68 and 131 to output
> constant strings. Using seq_printf() adds unnecessary overhead for
> format string parsing.
> 
> This bug was introduced in commit 6bf9a639e76e1 ("s390/mm,ptdump: make
> page table dumping seq_file optional") in 2020, which explicitly stated
> it was the "s390 version of commit ae5d1cf358a5 ("arm64: dump: Make the
> page table dumping seq_file optional")", copying the buggy arm64
> implementation.
> 
> Fixes: 6bf9a639e76e1 ("s390/mm,ptdump: make page table dumping seq_file optional")
> Signed-off-by: Josephine Pfeiffer <hi@josie.lol>
...
> -		seq_printf(__m, fmt);		\
> +		seq_puts(__m, fmt);		\

So yes, it should have been seq_puts() instead of seq_printf(), but
there really is no _bug_ here, except of wasted CPU cycles for a seq
file which isn't enabled in any production kernel.

I'll apply this and change the commit message accordingly.

Thanks!


From - Mon Oct 20 09:23:43 2025
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-188004-hi=josie.lol@vger.ke