xed; d=oss.qualcomm.com; s=google; t=1771929827; x=1772534627; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=GVPafuMTkBBvdHOwmIqwEby5N6HPu4j2/4G4NoYv4Ds=; b=Dwy+DFrOehG8atDEOSN4T2JeyU61aVQ79ex9Z06Gu07PogWqUAvfDyIl5pnsq8rBwU dPRqql2+Yc2DNJuZFODF6aBtrfFePCaaNLG4qUQ+UCetuTVJNY14fPddu77bUsZSXVpk ODBCq9VQIasCJgj7dzFZ7el7eTM2T3JpjCdNsrGjEzY3f2PzlVqQDL6/QfJC1ghIvSk0 2rb4SHjsyB5AOHL9mdHgopZf9lO3KlBDqa0JXT7s0rrSLqtIT0306drpl/S/FQKDd0/I 5COwGAeTG4+vMTJA0PuSgRnfi0T4Ksm6QiofYeVDeXR28FOBoZDwjaSQ3J00931rJ3fN 4r7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771929827; x=1772534627; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GVPafuMTkBBvdHOwmIqwEby5N6HPu4j2/4G4NoYv4Ds=; b=G+pFzCrt1YTcc3wuXK8vSTpzrFf5yckHdMBrr8pNCqmZ1Q2V/Tg+LxXOojvUqRNT4R h8v58Di7q+DRcCMJdaKZUu86FpNr0X977MwZ86g44u9NGNscNM1QuxQL0Xcp5vnh8+1W DN1B6nHr8E8rigZ+1JtjzRpUa6e72Bd6bRlqa+nGZEnYFls497AXDVYElIQ5TKHHnSqV tKKXhsuafGemdYztDAEHWpsTsc21acu6SXnEAgQtXFYu+IQw+0yVUTOkYkydRfiNUznf U19rzfr06Krhxr+RgJtNdS4dYNG8DFoFXIv4qCoOfETmyE4o69cCft6esnW8wsoZBKct Glmg== X-Forwarded-Encrypted: i=1; AJvYcCVSO1diVXhnikdeuHnoA+4PQREXtG9fSJViUa8wjNPC6ruzXTujrfOWm7puYimApENBp9y3WCM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo4HLHsQr5At6KW28Ne8PR47kC1xt0NxmZa8xsgYuzoDi2Nlni BL4/U4NqcHMVgwgrBmdCGP5lP+3dhLgDU0g2wNVjWI3cbE2VvcloiL304X13twLTMJe0wbhFPpT PMVOi0a7diiBZBds1YTbdeLPS2J/fvq8pE3G+00t+NlFPCh7kOYGyfkrbnoU= X-Gm-Gg: AZuq6aKpcgJjlxpjyahvQGFc7Mq3gMnbfN9wosdEy1Jt1T2UiUDtE3rP4DApY4O86qh JYWsweMKyEQbgnaQvLOYmR8PPjmoMPsaEH7OA7tHdkBN6JJUU8iZ4tOUEHWV+LISOGbtF3JeRS1 7Fjaf57KJG4Okz+tfzXiJPOqmUZimJzuIA+t4sEnWHC2RTF68kOe2T71hAwPwUKmO6En8qhY88w ugs0qaw9LxJGtI5HRIectSGwmbZHaA+PfaNRPixT+rEb234XltoT5uB42B3F++EwhHvjjZQBUdg zW2ImQr8ALwGiqbAwgh+zJE12fONwgiN13q0/FZnlHdRJPtqK83XZeH3T2G1neguR0YQSVjP1jv WpADk3Vz5w007uJC7244LaTKUETwKHZg23j8vurgGhCBSBw== X-Received: by 2002:a05:620a:4627:b0:8c6:ffe3:49e4 with SMTP id af79cd13be357-8cb8ca6e217mr1443429385a.52.1771929826685; Tue, 24 Feb 2026 02:43:46 -0800 (PST) X-Received: by 2002:a05:620a:4627:b0:8c6:ffe3:49e4 with SMTP id af79cd13be357-8cb8ca6e217mr1443426885a.52.1771929826083; Tue, 24 Feb 2026 02:43:46 -0800 (PST) Received: from [127.0.1.1] ([178.197.223.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d40004sm25685906f8f.21.2026.02.24.02.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 02:43:45 -0800 (PST) From: Krzysztof Kozlowski Subject: [PATCH 0/4] firmware: arm_scmi: Drop fake 'const' on scmi_handle Date: Tue, 24 Feb 2026 11:43:38 +0100 Message-Id: <20260224-handle-not-const-v1-0-90bf93b53e27@oss.qualcomm.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIANqAnWkC/x2MQQqAIBAAvxJ7bsE2FOwr0cFyq4XQ0Igg/HvSc QZmXsichDMMzQuJb8kSQ4WubWDZXdgYxVcGUmQUUY9V+oMxxAuXGPKF1hmetSarrYKanYlXef7 lOJXyAf+h7WViAAAA X-Change-ID: 20260223-handle-not-const-9a6eb5529590 To: Sudeep Holla , Cristian Marussi , Michael Turquette , Stephen Boyd , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2696; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=6sPDie8uUqGDS1bsA07NmZp55tMOfOGlzrz/b5hPRYY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpnYDcRw8HWd8txJCgD3Arumeb3Kt0gJSl22Bwu 5P16m8ME0mJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaZ2A3AAKCRDBN2bmhouD 13RsD/0U2Kzo2qesvlrOb07YD9SW5ZCP1FxlSzAGO4KbDOGkmm5by6HPnMA2oR+qWkAfHJLNNP4 fOvAtijr6UM7Ckd6ysYb0jQLJ9GcJzeFPY44yghOURRRRQK2i5wa7p64qcCyCp1P32kHsbj7J23 JzXFCovKdNGyFm41w2LPX4DmdaxDO4z6tRr1QfhCaKxruQefjBuORlAMA0BOVVcA2HSxfvcvJUG LUsf/aiM1p7Vb7tniN3bQmUZlhF7lSDwIMfMeR5EMGhHf21vgEOYjJtQRG7ZCtm6uNMdfzR0NXO 8nJXjDY3rhLTThDp8eig8CybDwLP0kFCNNZi3m4Ro1znCVVbOi97ZsCYhyL2t3/SYXzMioXWyHW X9ZdZiO73mFpyEbQveSIcUJSozDn1t2p93rirFPmZkU2rmpk24qotVBI+uTprSRal74HajfsYzr fm44jNBruZ3VeX0xToabjB0aOc2S1udXdwlvuP2cCA6mOYdj/25TUWPIqCPWiNCt0U4ONm+eOhs cZ4Ysui0ZnEhX8AupCpEl3ji3sTsVGbGVBnImrxiA3jzY6pP+XT31QKcnRrM+YDG4z0Hv1SKMzy SmZc5CDHJozCT12HnwAIGab+HOJg8NASzJ/UIaV8Pg7YJ9G6w5imQg22Boz+n3CrFtliY8vg70j u6MGUlqTSqnFg0w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=DfIaa/tW c=1 sm=1 tr=0 ts=699d80e3 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=6nO30s3o7FuWeffXwhKHTA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=QjCKVQx7SMNC4EIcHegA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: R-CYEJ0Fztm04OxJYpsaatC4wTW9VW1P X-Proofpoint-ORIG-GUID: R-CYEJ0Fztm04OxJYpsaatC4wTW9VW1P X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDA4NyBTYWx0ZWRfX5PoHy8Fag/Qu NCpZTfPH+ecwINIRdxRLjxHuq32KYZ0aKlBVmi42vwY8QCPxK+DZEH8DGlTt4UQvF6ElotCNBdA lHjbRkn3jSmAEOKyLjtONs5uqmPCi2aAO/DCYUnwm7ZehTPUnb2qL6p3qHdSI0WDrHWkKjoLbYk +KaR9Bf3eNrvGK3t1+wiYzU24IqTSdJkOnhhr3WhbXmhp0mXIXkpUjblfeRR9E0o1rciXIGFKxs 6Dm2hIBBEzLnLPUFOUiN0zYSB57/orlukVQjefoOUteyn8GmDdQKdu2IUIxqqQ4SqTXcPsW1Xyz 8wSqiviGyapvhW0LeUemGKVoHv9g2GyxiZNsfkBsUiQwzUmkuvHbcFNP3eAFGO6gioSurhy6HAE S2CFLJUTI7VSiK4TIXLvMI3y1CtcefJ2CUhOMP3GuQ6gm+tbsxJfyYWpFDYevbxu+pdDRSSufiP zsllTmOs+TMiHjrng0A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_01,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 bulkscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240087 X-DKIM: signer='qualcomm.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-DKIM: signer='oss.qualcomm.com' status='pass' reason='' X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://docs.mxroute.com/docs/expert-spam-filtering.html --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_DBL_BLOCKED_OPENDNS ADMINISTRATOR NOTICE: The query to dbl.spamhaus.org was blocked due to usage of an open resolver. See https://www.spamhaus.org/returnc/pub/ [URIs: qualcomm.com] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: handle.dev] 0.0 RCVD_IN_ZEN_BLOCKED_OPENDNS RBL: ADMINISTRATOR NOTICE: The query to zen.spamhaus.org was blocked due to usage of an open resolver. See https://www.spamhaus.org/returnc/pub/ [172.105.105.114 listed in zen.spamhaus.org] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 URIBL_ZEN_BLOCKED_OPENDNS ADMINISTRATOR NOTICE: The query to zen.spamhaus.org was blocked due to usage of an open resolver. See https://www.spamhaus.org/returnc/pub/ [URIs: qualcomm.com] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 Severale functions operating on the 'handle' pointer, like scmi_handle_put() or scmi_xfer_raw_get(), are claiming it is a pointer to const thus they should not modify the handle. In fact that's a false statement, because first thing these functions do is drop the cast to const with container_of: struct scmi_info *info = handle_to_scmi_info(handle); And with such cast the handle is easily writable with simple: info->handle.dev = NULL; If the function really was not modifying the pointed handle, it would use the container_of_const() call. The code is not correct logically, either, because functions like scmi_notification_instance_data_set() are meant to modify the data behind the handle (in containing struct). Best regards, Krzysztof --- Krzysztof Kozlowski (4): firmware: arm_scmi: Drop fake 'const' on scmi_handle firmware: arm_scmi: Drop fake 'const' on scmi_protocol_handle firmware: arm_scmi: Use container_of_const() on scmi_handle firmware: arm_scmi: Use container_of_const() on scmi_protocol_instance drivers/clk/clk-scmi.c | 2 +- drivers/firmware/arm_scmi/base.c | 2 +- drivers/firmware/arm_scmi/clock.c | 2 +- drivers/firmware/arm_scmi/common.h | 15 +++--- drivers/firmware/arm_scmi/driver.c | 58 +++++++++++----------- drivers/firmware/arm_scmi/notify.c | 2 +- drivers/firmware/arm_scmi/perf.c | 2 +- drivers/firmware/arm_scmi/pinctrl.c | 4 +- drivers/firmware/arm_scmi/power.c | 2 +- drivers/firmware/arm_scmi/powercap.c | 2 +- drivers/firmware/arm_scmi/protocols.h | 4 +- drivers/firmware/arm_scmi/raw_mode.c | 4 +- drivers/firmware/arm_scmi/raw_mode.h | 2 +- drivers/firmware/arm_scmi/reset.c | 2 +- drivers/firmware/arm_scmi/sensors.c | 2 +- drivers/firmware/arm_scmi/system.c | 2 +- drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c | 2 +- drivers/firmware/arm_scmi/vendors/imx/imx-sm-cpu.c | 2 +- drivers/firmware/arm_scmi/vendors/imx/imx-sm-lmm.c | 2 +- .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 2 +- drivers/firmware/arm_scmi/voltage.c | 2 +- include/linux/scmi_protocol.h | 2 +- 22 files changed, 60 insertions(+), 59 deletions(-) --- base-commit: 5848db9e2caaa560a21ce692c4c32badef3c813f change-id: 20260223-handle-not-const-9a6eb5529590 Best regards, -- Krzysztof Kozlowski From - Tue Feb 24 11:44:36 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id qOFTOx+PnWlToAEAYBR5ng (envelope-from ) for ; Tue, 24 Feb 2026 11:44:31 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Tue, 24 Feb 2026 11:44:32 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vuqq7-00000000h9g-0lnA for hi@josie.lol; Tue, 24 Feb 2026 11:44:31 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id E342030BF870 for ; Tue, 24 Feb 2026 11:42:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CCEF637FF5D; Tue, 24 Feb 2026 11:42:15 +0000 (UTC) X-Original-To: stable@vger.kernel.org Received: from lgeamrelo07.lge.com (lgeamrelo07.lge.com [156.147.51.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C19233803D1 for ; Tue, 24 Feb 2026 11:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.147.51.103 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933335; cv=none; b=Xfn4c5hayMHnnmAbV+Wk74f1BaflxZVpX1Fw9eyEnrKRWMmxGI7OGlcq9sb9bFwzuMMOUGFftBfOS+W4TSbAAtRzcEyIAAierAi4WlzDXxZ1YCTpisf4+b5zQTYaNEMR9UpbHpqzXtNCOoEO552Hzt4fOkf1Oor2n24kHsJEbnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933335; c=relaxed/simple; bh=mV7jxebzJNVb+5lsUW2VQ5ClZ8zp8PK1uGUOtrrIR3I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qr+J3F6WpS7aisnRuvBeUWw22s4P17gyZyr+t6xRWGqRxO7gBMmhMKL/hPkt8YZnxnqWzZxH9DwhAzwqiXw/6VNWIwCLzWfzTLMwJ00wiuJpsI74SZN/C2EJY99duzQucwz1pyVbVqdV4Po8SFZTG30ZLcHgQyVDKnk2WkXm3A4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com; spf=pass smtp.mailfrom=lge.com; arc=none smtp.client-ip=156.147.51.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lge.com Received: from unknown (HELO yjaykim-PowerEdge-T330) (10.177.112.156) by 156.147.51.103 with ESMTP; 24 Feb 2026 20:42:06 +0900 X-Original-SENDERIP: 10.177.112.156 X-Original-MAILFROM: youngjun.park@lge.com Date: Tue, 24 Feb 2026 20:42:06 +0900 From: YoungJun Park To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Carsten Grohmann , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, "open list:SUSPEND TO RAM" , taejoon.song@lge.com, "hyungjun.cho@lge.com Carsten Grohmann" , stable@vger.kernel.org Subject: Re: [PATCH v4 1/3] mm, swap: speed up hibernation allocation and writeout Message-ID: