rmation: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 On Fri, Jan 30, 2026 at 01:08:35PM -0800, Andrew Morton wrote: > On Fri, 30 Jan 2026 13:01:24 -0800 Matthew Brost wrote: > > > > > Unfortunately hmm_range_fault() is typically called from a gpu > > > > pagefault handler and it's crucial to get the gpu up and running again > > > > as fast as possible. > > > > > > Would a millisecond matter? Regular old preemption will often cause > > > longer delays. > > > > > > > I think millisecond is too high. We are aiming to GPU page faults > > serviced in 10-15us of CPU time (GPU copy time varies based on size of > > fault / copy bus speed but still at most 200us). > > But it's a rare case? > Not that rare. I believe this code path — where hmm_range_fault returns -EBUSY — can be triggered any time HMM_PFN_REQ_FAULT is set and a page needs to be faulted in. We don't set HMM_PFN_REQ_FAULT in our GPU fault handler unless migrations are racing, which should indeed be rare with well behaved user space. But there are other cases, such as userptr binds, that do set HMM_PFN_REQ_FAULT, where it's somewhat expected to fault in a bunch of CPU pages. Doing an msleep probably isn’t a great idea in core code that a bunch of drivers call, unless this is truly the last resort. > Am I incorrect in believing that getting preempted will cause latencies > much larger than this? > I'm not really sure — I'm not a scheduling expert — but from my research I think preemption is still less than 1ms, and in cases where you don't preempt, cond_resched() is basically free. > > Matt > > > > > > Is there a way we could test for the cases where cond_resched() doesn't > > > > work and in that case instead call sched_yield(), at least on -EBUSY > > > > errors? > > > > > > kernel-internal sched_yield() was taken away years ago and I don't > > > think there's a replacement, particularly one which will cause a > > > realtime-policy task to yield to a non-rt-policy one. > > > > > > It's common for kernel code to forget that it could have realtime > > > policy - we probably have potential lockups in various places. > > > > > > I suggest you rerun your testcase with this patch using `chrt -r', see > > > if my speculation is correct. > > Please? Thomas is in Europe, so he’s already done for the day. But I tested this fix and verified that it resolves the hang we were seeing. I also did at least 10 runs with chrt -r 1, chrt -r 50, and chrt -r 99. I couldn’t get it to hang — previously I could reproduce the hang in at most 2 runs. In this test case all threads are on work queues, which I believe can bypass real-time scheduling policies, so that likely explains the chrt result. I think we’d have to craft a test case that triggers an hmm_range_fault from a user space call (userptr binds would do this) and race it with a migration to catch any RT bugs. Matt From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id WH03AuFYfWl6mjMAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 01:20:33 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 01:20:33 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlzf6-0000000EHER-2j1y for hi@josie.lol; Sat, 31 Jan 2026 01:20:32 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 602B3302B3A2 for ; Sat, 31 Jan 2026 01:20:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4A4143254B4; Sat, 31 Jan 2026 01:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="C3XaXnr/" X-Original-To: io-uring@vger.kernel.org Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5BAF2F616E for ; Sat, 31 Jan 2026 01:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769822416; cv=none; b=Qi5Sg+2Y/hnoJw2pIpjLFfTHXgK+MVDreSWsts20bQdg5dVC+wFcafkiMX+hlv4VSM1boBtLg7oe93gfdn3YJpDKc6xJCYX8zPA0p/8p/8XKuA0JbmYC2oJGtEA4TKjr3qI55XrsNVppz1JDPX7g+pfivvEXZfUNlUq+u6lWbc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769822416; c=relaxed/simple; bh=LqjG26iPcgUJUjdKHHQUCfcuvzKdnJ4bXKdhZ7B7/mk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qqSJXfBEHmWRI+5t9Czg8WsBMGxJzHYQOdOtb7UMHtxKykeBFvqJxGLfR6uXEqdY26CVCsCPFYvsnioB0mdYh2n5k/qmxp+tXzG5lKxCZ85thg4vS4l2n1y7If6IRh1CCytt23ayPTxk0q4t0ffaPs0yLNmDA1tdo7bTUkcZFL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=C3XaXnr/; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b8863db032dso444219366b.0 for ; Fri, 30 Jan 2026 17:20:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1769822413; x=1770427213; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=X+Zsir5E/r34txHH39Th9Cb+s5GtaeVJrYm06jsRDB0=; b=C3XaXnr/FF6cIAzaxerJOqcXEXJ/Fa6W2MhMyzCzozQs3rRMXUq5fYZqLTp4bPNcmK We9PIwTdP8jJcxo6tdZH0nrPfK8Lyw4qDIhiJUSzb2Dhd+X1DfddffqbeH3kHrnGMurw Di5zx1SXZpi8IKYMnH1jXy7Asc/GxFcQBgMBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769822413; x=1770427213; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X+Zsir5E/r34txHH39Th9Cb+s5GtaeVJrYm06jsRDB0=; b=LqXDExCebqrQBWTmYNDCWSPY5KpmsgarqDhLe7L76EKL6iYAXZS+3AtiikxtkT1yHt Ezmk+SUdI5aaZF6YjkY+24zOAfHTxl9q7STKVhmNu/kU9AsBVSmz0cttIbcR/BMc5fJ5 CO2X84dLzRpRHCqCQ2NCz5V6igFjAWPss42Ys0QRDBFUxUJM/lG3etgBA9FI2ykSsL71 ++YP5QFTmgNnyillPIi2hMel+vUmNMTMzK2IxI+LUtmfic3peV3U/HLYuy3rmhDnulrr h0es45rednCh5uYl18/NAwD9lJHGUqOUklvpvrVVRosu7H30r9uM6ACwsFRG3nxKP2nf aFUw== X-Forwarded-Encrypted: i=1; AJvYcCUt+hdQ4TiKI1pvgjF/F1M2PJHAmyACowB81KpN0zynvUNEtATbudYuh7JMvSKFG4bap21EYG1cHw==@vger.kernel.org X-Gm-Message-State: AOJu0YwqTMS+C3JxzY+MV/F5XpHiTSKXPq+Bft0n+7KbvgwNQR5+ZUIZ SYZ3ntdLTc1StmXWiLvAHo+dEk2UeUnD1LrXj+9Gux0q+hED2vs5rO2mk6hjLzddfmLfmtDjt42 w2dhAhr1PaA== X-Gm-Gg: AZuq6aIqYkNuIa+6gEZ/jcHacyDzoIO/BUm/+XsvkcxdyZbAmcrOLLyU66Mf/FcPgLD 6AJAulyjrSIefHJyISTRhWLtfiVi/o1Ye7mKS+3YsZORja/IH+xaxhBj62FjnXKzt+YXgFbDBPW CMmQbaoOgsO7PFgH8SWKf+56q7//mxMSV0Ec9ad7ewuHJ+abGig+ItXgsRdAfYJEk8vTpaj2g3o 3UVB63x+MlnYlL42rmsBuiEJnpeV3FV9sd7eeMizfzlcBMqRGWM2GQv1aLPPkkoNyKlYbm+R1f8 OBgdUoFexbKwW4TOZk7rm7yBLhbAYQbXwwzouscJQGT+01ZCWajwA09ilfr4TDAVBmeZpUI6Ua5 LtU5vTfoOAX3ur5s6ZoyT5IAAvfV1fKSa6Za0816HvhFiH7KDQGUhWrEZQX7PfmWmjj+6fbV3G3 nL1U/+8eFbdK5fminRvdNJi8aMXTDK3M9FemPAAfls3CdtPOO71SgSAhC8+sMa X-Received: by 2002:a17:907:9608:b0:b8d:f6f1:e27a with SMTP id a640c23a62f3a-b8dff882467mr246378666b.65.1769822412898; Fri, 30 Jan 2026 17:20:12 -0800 (PST) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1c0213sm506198266b.48.2026.01.30.17.20.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 17:20:12 -0800 (PST) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b8871718b00so470215766b.3 for ; Fri, 30 Jan 2026 17:20:11 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXJnrxb14pasrqq5y/M8MwpnyWnr8kmDmRp/K0FyCvf80xpwnfEBUWJJ29ny/xjnOT3MRM+MxwoCg==@vger.kernel.org X-Received: by 2002:a17:906:6a1f:b0:b87:701d:341a with SMTP id a640c23a62f3a-b8dff607a33mr279550266b.25.1769822411525; Fri, 30 Jan 2026 17:20:11 -0800 (PST) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> <20260130205227.6fb1d9ad@pumpkin> In-Reply-To: <20260130205227.6fb1d9ad@pumpkin> From: Linus Torvalds Date: Fri, 30 Jan 2026 17:19:55 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_QicYb2Y4IsMdcHkp6aaLn_xxvWlOuA7e1nJwap4TdBtycKshhvQFgQOM3M Message-ID: Subject: Re: [PATCH net-next RFC 0/3] net: move .getsockopt away from __user buffers To: David Laight Cc: Breno Leitao , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , metze@samba.org, axboe@kernel.dk, Stanislav Fomichev , io-uring@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" X-DKIM: signer='linux-foundation.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: linux-foundation.org] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On Fri, 30 Jan 2026 at 14:40, David Laight wrote: > > There is not much point making the 'optval' parameter more than > a structure of a user and kernel address - one of which will be NULL. That's exactly what we do *NOT* want. Because people will get it wrong, and then we're back to the bad old days where trivial bugs result in security issues. Can you point to an actual case where setsockopt / getsockopt would be performance-critical? Typically you do it once or twice. Linus From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id IJsGKuXefGm9eTgAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 16:40:05 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 16:40:05 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlrXQ-0000000GNYD-2l3H for hi@josie.lol; Fri, 30 Jan 2026 16:40:05 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 5F68E301494F for ; Fri, 30 Jan 2026 16:40:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 58685352C36; Fri, 30 Jan 2026 16:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ucbSE9Kd" X-Original-To: io-uring@vger.kernel.org Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010051.outbound.protection.outlook.com [52.101.61.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 356AB350A29; Fri, 30 Jan 2026 16:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.51 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769791201; cv=fail; b=b76x2Hai2tlrdwnSz62rVHxiy0aIJbI+7QytNP8KI/vgs2HTc8J79SY8bwZt4a++vXghgVbZ1jClNpEx3ADjP9QZfhlJWuuqLtsiqFpG3vJK6CY9Zzxnb5EcSM3IpCBkFUswArKJgCfE98GuB92UNk+WaY+ztZyofwtSvqQCYKk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769791201; c=relaxed/simple; bh=Wga6BbIWtqKhHD3vVlMEGzA6I4whQVAvkpl45olHqps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=jr1Ew+HXMya1OUAp5ZVZUjLSX0w1FTjjaEI/8+xDqLRJZs3MQBFq2/VO3Bj1ixn7RtqcxUs90xymJm/QtZaVNQvY3sY96S/eGyOLaPaMNobS7phAImvKpOUgGxKv+3ot7KdahQA9zjF9oDxWf2lCLMli8W9ajgdkDVXfYzNmW9A= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ucbSE9Kd; arc=fail smtp.client-ip=52.101.61.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Oqpf03Qljrtp1oelbqD6NU8XgmAVenbLZDO5QQ9G5v3x6jwCwfe5wg5wEk6zXBtfhpnIcBFT5998fv7/FxNAjUmg1sWNciYrZoxShDNQ4hEPrHEAaMrGggP0Vz9uo/1USxmJcoG/hN1rJWXJtbDIAfrlFkEpEeybe/i0QwjQJHCj7Lgj344fGBcAy0ClalURHKSlp6IqDmC2co/8Wz60ewDmZMpLSOHEmvhJ5Zg4DfFrArgjahpRHx3SZU9uutn6IRwe/jGi0qXw6H1KV/u+x1Bz4ugdPKj/MgyDy4Mv88sAUEYJ9FSRmQaXcNno1P4lLXHuakrWBUji1DoRNoIYVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HUGGo+36f7qwsFsPL5VjqY0jYr2eh/0L5rr/8TMI5s8=; b=bdDrRxnPqZtbfce9QJNAHWrufM/1X95aTYf1zykjCJ4kMz3sXgILmbTrzkp3jmiVKIOoqurHPx2cjCggxmuS+Dx9eCi+Cr+05ikPLXpVRQRK6vPVCr6fqowJAzsjCpAO3R7+68EPYvaecdRtAltu3t9pOVASMTTmDCpKetYtgYjGIddY4rVrK+ALTy1Qzwl3Nbh4+FKI06bMhEry/rSdCp1fzsZDXIaYBodgRMuf1WtWaDXfo3GoNCpyUIFEot3MiI0o2jwmcPsuaQwFVhahVWem6BP+SV4eIDWbHWgUH9FekFc1lmymLAs+/pAYDzqrv3i4OU6ioOFILnbookaUYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HUGGo+36f7qwsFsPL5VjqY0jYr2eh/0L5rr/8TMI5s8=; b=ucbSE9Kd6ejhtWRV4Nb9+cHFwTl2SbDWPJgDzAkty5iT+Wr2j0b6yoL2MhF4Bg/f3k+5HD9kCm/z/L+260dROmMFWjhcRY87WZ570RQWM79SnSXOlqOYD9RC1Y7WlSFswjw1p0+O79XyxwFXOeBU/nwYnJbyUdEB5bqhA8Dfsopb/fym0yp9FWfAXXC11TVQ8kMfe5S2qzqpMfUyuhmFe3o1mEDln+LpyvExgi3+jAOFx5/+CgS20Q8+UJUNLLekz3EEF7L/waQtSeimlLaKhhkN5Gm5oFzD7qvtxGuL2v66qO9clE1F+uG5Z/oQ/F83Cw/yuiapXb7XCVSPUXG4og== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV3PR12MB9402.namprd12.prod.outlook.com (2603:10b6:408:213::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.11; Fri, 30 Jan 2026 16:39:49 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9564.010; Fri, 30 Jan 2026 16:39:48 +0000 From: Zi Yan To: syzbot ci Cc: akpm@linux-foundation.org, apopple@nvidia.com, axboe@kernel.dk, balbirs@nvidia.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, david@kernel.org, dev.jain@arm.com, hannes@cmpxchg.org, io-uring@vger.kernel.org, jackmanb@google.com, jgg@nvidia.com, lance.yang@linux.dev, liam.howlett@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, mhocko@suse.com, muchun.song@linux.dev, npache@redhat.com, osalvador@suse.de, rppt@kernel.org, ryan.roberts@arm.com, surenb@google.com, vbabka@suse.cz, willy@infradead.org, syzbot@lists.linux.dev, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot ci] Separate compound page from folio Date: Fri, 30 Jan 2026 11:39:40 -0500 X-Mailer: MailMate (2.0r6290) Message-ID: <2A678D66-2516-4130-A34B-6A0B3549EEA7@nvidia.com> In-Reply-To: <697c68b3.a70a0220.9914.0032.GAE@google.com> References: <697c68b3.a70a0220.9914.0032.GAE@google.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0114.namprd03.prod.outlook.com (2603:10b6:a03:333::29) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV3PR12MB9402:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ed83828-0bbe-4aef-dead-08de601e2e91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PoRsv9AVYuCIcpmoG+bn0g+WnTs/gghYD+SjbYQ/12AjhKJW4Loh8nnSo2LM?= =?us-ascii?Q?bIJ6dWxCURdTNFYToR3JxkEwD+J9eVC+Ezjio9j7DXfJAicV6nNd77LrZCuN?= =?us-ascii?Q?Ptu7lEtDL3ENQ0unkMhAPc3XOpqvn8vJYxiHNjx7jX1zywxLhTYEJGgflX3Z?= =?us-ascii?Q?XhLgFAej/6zSgclAbIvbgElzgRIrj6TdNMrQMQKyLerizwWdrsHL5cr/n4Tg?= =?us-ascii?Q?iZyUL4fjZuYuIx9Yul0LqW7HkbUtsy0m8izXMY5FNxg10rh1lxcNGupsgR9X?= =?us-ascii?Q?NbzDaqm9/5guujDaNYAmYpsiE1muXIyQUSK26IECHT8EhivZn7OYDHax4IoN?= =?us-ascii?Q?MfZdX+2YIlSTjLEMjNv2otNzDij5NXNsdglMSyex3d2S8sdp0VxtLTVGorBb?= =?us-ascii?Q?Dj3yULnQQGlyWO1hgk+fHCBHQ98MWpXvbwFG76oithX96ai7NvbcN50q3tpm?= =?us-ascii?Q?DJICmeGbZytV+bBLm/Kte/Yhvt1rQuVLPWh7CKmfvd1vJykmBAXCSDqHI/sv?= =?us-ascii?Q?tibypD6fxDR0V0v85hr7mYtH9AassDwEAkvG9bEutxUUWPgqnyfnjVhY5gmK?= =?us-ascii?Q?1YDvoQera/tjrUtvCgrWDhtCsbJma8wqIqMYNgSxN99xaKqHU9yCuSfy6YXK?= =?us-ascii?Q?Vqtvr80u6W8J1zWVeAal4ZK5Nne3jZQyQ8LfpHzgziDdYXS7Lu9STJ7HjE77?= =?us-ascii?Q?dHaunJMhkboof3R1thgo8DF7QqYSdb7wKmN/wwwETY4IBZhjr/pAdaGu+nA7?= =?us-ascii?Q?ZLr34Ad7DNuocUnbC1Kz5MV7leypejq1/warWMVaJUzNUr4Tbn5iBFABTQ9l?= =?us-ascii?Q?AnKaDMDsrw3APMER3Vg3aNcqqHFQL6hyA0ASzDCgY9Qai/uaQw9Egd/CoPlJ?= =?us-ascii?Q?SDHP+RQyz88ILg1aqc5lkKwO2Ii1S/zJH6SBRH+NpyiaDw8NT6jODPG1Gtvz?= =?us-ascii?Q?Q79p/ohqB8eOELOidHc3YcXVGTWG7CPfCk9meO7iYRA28k//4x4lZhcFDO9n?= =?us-ascii?Q?n6BWRG0TptcPuyzRZltzTH9OiHjyhai9NuQMhDuNtLyuQpJ14IEKEDTMHhVr?= =?us-ascii?Q?GIgav8dawZw9S+umTpVd6Pqq/U+z0vLvy9qnipog/ZB7sYAZCvpNu7EUL287?= =?us-ascii?Q?glZOmOclga8XLFnYg7DgDMn0buFU9Tbd7kGSWfF0hXrt4qIAq0pdtUiijWbz?= =?us-ascii?Q?Q/xCPU05aR4syl/TmXf/bd1H7y3y7MKvTTauJZFnkY8dnPhfN/J412Qr/QP4?= =?us-ascii?Q?HZhVk1f2m0YSNXrIfYYGLTFFgD8dZGRWRNRQ0CPAExpOhVe+/0ODNmfxyGKE?= =?us-ascii?Q?MxVcTIRHeHuZyKyCOhmEnmLjOynS7n0jvDule4MKgr8yc69xKVv2sEV/87rT?= =?us-ascii?Q?JAMY4GyVKujfaKuw3BSkbFewHmhgUeFQKEGi9B5asTP5A3wweHvbSYRUli1e?= =?us-ascii?Q?E0gtE8EXIU+zK5LFrFX0Kngfpiiivjut9cGGkVdt0K9fDKjubBo813PPTE66?= =?us-ascii?Q?mP4Wa7cK4qpZ9W+NRtI8ltslhMJQR5xyZsFjVdSEH9DJ+P2Zo3FmFEKubfvb?= =?us-ascii?Q?BHhOzBiiIizo+Lu9hs8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vDBSl3mDDge9rtpYBmF9KPPN4R2ilyRmVtstRm1qelO7BoqRrbdAtPTcKwdH?= =?us-ascii?Q?PT+3H2INePTSndPuuUY0MoXw8HF2nUVYeewtIGDU/zRbb3Ncw5HRqi7pdtwm?= =?us-ascii?Q?UzTSqVqD2UCMYY5S86D13J3RwJVGkPTXqTd2IXywTYIqqXmmsMmEGaEt7V/T?= =?us-ascii?Q?eTB5BiyCcw86uFd9KfCHdrB/2DbCyWGmu8WdGFx7cdn5JbBe8CopfFlSrkFq?= =?us-ascii?Q?XMJGaSWnjqR8/z31hvu0ZJidZZS8svXkmt6uuCMOTM+/P/TLBUsGdzPejmUC?= =?us-ascii?Q?DV+aHyv8Pgm5BnnKt4Nfy/zxukxnKTOnMbhrt+G3l+/ljUToNXpbKbxlNjIf?= =?us-ascii?Q?/vbUNdPy3TLMndr/rrAFm7LU+8aEin804wGyWvmnbL3iT8PifCv++7W2yuLA?= =?us-ascii?Q?FPo0WvuOXKkMQMMGq+Aryi5VDMjlqgh1Qb3a44t0hsGEtN0P8OhZVNXJw7aW?= =?us-ascii?Q?DP1Ii6garj/1O/HiTyW5L3SetlD2Aanc4GQ22WTWDryUUqlXEGek2Cs5MKmQ?= =?us-ascii?Q?q/NVshT2+cY2JIWoV6hUyyGXSyCY8BX6IBeY/8mA00J/vVNeix0ZpYN2k2rt?= =?us-ascii?Q?XE4lhbHo8vwdDsCfkpARvWSQzXjHdcOa8uWGBlttMEvQ13LzbqafgUr7YjcD?= =?us-ascii?Q?aMEu6D2NIlve1/+Mx3diQ2Va2CTQTGqEgxM5HlG29xb3xMCWf7Gg/86XMrgK?= =?us-ascii?Q?yXbL6gZjjkIn1Xos0pBEtz+Us45KMYwWzPhV5uA2YUvjF5plGWqRuuE80rb8?= =?us-ascii?Q?MPo3JF1CsxfO5N/pR3NTnqrd2EjHa+L6e84HNRYLwzy1Eb20UDuJBsrKem+h?= =?us-ascii?Q?SEwxUGVm8c/qCtNFdXdUAHTnrb037kpQAjGeFmYxTv+COGwOTzJo1Yltw1+V?= =?us-ascii?Q?PTJL4UdaTd/hmyGY+7yXlWPechCMsrl3D1ht14+cvLK4FOSUSbZ+dL+VbsCk?= =?us-ascii?Q?Tfry47k7WJ4igemAg1s8l4QOz3bA86kQuINsNEl5CChTwz63SdPndRriF3pv?= =?us-ascii?Q?ifQwzbekTQiP6+M42zuCEiHSBDISgB177C/L/GqlAYuv5F+TtkTvGMmXKXbN?= =?us-ascii?Q?6cTQ0woCkQBIxES2487yF2Ox5NSWM0qmVACBQy+OTS9fhaKHIM1qh5Iaaoyv?= =?us-ascii?Q?aGRQqLxGg3qVJhotHDTbJGaGv9fLzB/cwq6eT3gYbhak/ga9uqcTLRJPYF4g?= =?us-ascii?Q?xH1lgwvoi8kwKqvUbcUhiBHuiRfh01j4CSrEM2QTycstBP3jozUnWaNZqm6i?= =?us-ascii?Q?JV3PfBqaUvOdwjPSvFQ5C5Eg9Kwahb7Pyb/8oHkdo1YJ3xyrd2liYd9Fn/NR?= =?us-ascii?Q?sbruD7NiNmyRoD/2GFnbJRF/RfjryRtaFj9UgRqMdks3LTc9P8Iu85C5rpmD?= =?us-ascii?Q?lxBhuaQaDNWOs1n2XbFfNlSNkfggRKBpjx8bo3KSUqgK9waHL4sbxHcXOzSL?= =?us-ascii?Q?jUfXUlUFoYuVBbfIC3/BPwwyEDwwPCRmIy0hCq28VvUnwe6XOJxHnURoONhl?= =?us-ascii?Q?nleWKtWXWYSiadzuuBQNAPUmh9XmHY5rVtPxpent3OHlKW+Q93gwdqBFe2yq?= =?us-ascii?Q?JNt5Nn54OaGJD0xN5iB2ESeQH5tDoJPXzvW9UkpRIkwp+xrukCQs0avMpx8V?= =?us-ascii?Q?udsbyPh8WZjnxuO97bGFubuQ4M+865RyDrcWYlXGC+Gz8fKupyAU8GtkNxSh?= =?us-ascii?Q?w/LCoiUjdux/M/UgHhJ58YTjmh6/u9+3YiBxiC+8DCaiWC4ru6RFmOaouJHr?= =?us-ascii?Q?nkpglx8l4g=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ed83828-0bbe-4aef-dead-08de601e2e91 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2026 16:39:48.1480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yggb7pthLG5XMZIrayrui370kiccGaUcu6AFOdNb6B1T1p1NThZYY6MCTptNTfyz X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9402 X-DKIM: signer='Nvidia.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: syzbot.org] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 On 30 Jan 2026, at 3:15, syzbot ci wrote: > syzbot ci has tested the following series > > [v1] Separate compound page from folio > https://lore.kernel.org/all/20260130034818.472804-1-ziy@nvidia.com > * [RFC PATCH 1/5] io_uring: allocate folio in io_mem_alloc_compound() a= nd function rename > * [RFC PATCH 2/5] mm/huge_memory: use page_rmappable_folio() to convert= after-split folios > * [RFC PATCH 3/5] mm/hugetlb: set large_rmappable on hugetlb and avoid = deferred_list handling > * [RFC PATCH 4/5] mm: only use struct page in compound_nr() and compoun= d_order() > * [RFC PATCH 5/5] mm: code separation for compound page and folio > > and found the following issue: > WARNING in __folio_large_mapcount_sanity_checks > > Full report is available here: > https://ci.syzbot.org/series/f64f0297-d388-4cfa-b3be-f05819d0ce34 > > *** > > WARNING in __folio_large_mapcount_sanity_checks > > tree: mm-new > URL: https://kernel.googlesource.com/pub/scm/linux/kernel/git/akp= m/mm.git > base: 0241748f8b68fc2bf637f4901b9d7ca660d177ca > arch: amd64 > compiler: Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1= ~exp1~20251221153213.50), Debian LLD 21.1.8 > config: https://ci.syzbot.org/builds/76dc5ea6-0ff5-410b-8b1f-72e5607= a704e/config > C repro: https://ci.syzbot.org/findings/a308f1d6-69e2-4ebc-80a9-b51d9= dc02851/c_repro > syz repro: https://ci.syzbot.org/findings/a308f1d6-69e2-4ebc-80a9-b51d9= dc02851/syz_repro > > ------------[ cut here ]------------ > diff > folio_large_nr_pages(folio) > WARNING: ./include/linux/rmap.h:148 at __folio_large_mapcount_sanity_ch= ecks+0x499/0x6b0 include/linux/rmap.h:148, CPU#1: syz.0.17/5988 > Modules linked in: > CPU: 1 UID: 0 PID: 5988 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT= (full) > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-= 1.16.2-1 04/01/2014 > RIP: 0010:__folio_large_mapcount_sanity_checks+0x499/0x6b0 include/linu= x/rmap.h:148 > Code: 5f 5d e9 4a 4e 64 09 cc e8 84 d8 aa ff 90 0f 0b 90 e9 82 fc ff ff= e8 76 d8 aa ff 90 0f 0b 90 e9 8f fc ff ff e8 68 d8 aa ff 90 <0f> 0b 90 e= 9 b8 fc ff ff e8 5a d8 aa ff 90 0f 0b 90 e9 f2 fc ff ff > RSP: 0018:ffffc900040e72f8 EFLAGS: 00010293 > RAX: ffffffff8217c0f8 RBX: ffffea0006ef5c00 RCX: ffff888105fdba80 > RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000 > RBP: 0000000000000001 R08: ffffea0006ef5c07 R09: 1ffffd4000ddeb80 > R10: dffffc0000000000 R11: fffff94000ddeb81 R12: 0000000000000001 > R13: 0000000000000000 R14: 1ffffd4000ddeb8f R15: ffffea0006ef5c78 > FS: 00005555867b3500(0000) GS:ffff8882a9923000(0000) knlGS:00000000000= 00000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00002000000000c0 CR3: 0000000103ab0000 CR4: 00000000000006f0 > Call Trace: > > folio_add_return_large_mapcount include/linux/rmap.h:184 [inline] > __folio_add_rmap mm/rmap.c:1377 [inline] > __folio_add_file_rmap mm/rmap.c:1696 [inline] > folio_add_file_rmap_ptes+0x4c2/0xe60 mm/rmap.c:1722 > insert_page_into_pte_locked+0x5ab/0x910 mm/memory.c:2378 > insert_page+0x186/0x2d0 mm/memory.c:2398 > packet_mmap+0x360/0x530 net/packet/af_packet.c:4622 > vfs_mmap include/linux/fs.h:2053 [inline] > mmap_file mm/internal.h:167 [inline] > __mmap_new_file_vma mm/vma.c:2468 [inline] > __mmap_new_vma mm/vma.c:2532 [inline] > __mmap_region mm/vma.c:2759 [inline] > mmap_region+0x18fe/0x2240 mm/vma.c:2837 > do_mmap+0xc39/0x10c0 mm/mmap.c:559 > vm_mmap_pgoff+0x2c9/0x4f0 mm/util.c:581 > ksys_mmap_pgoff+0x51e/0x760 mm/mmap.c:605 > do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] > do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7f5d7399acb9 > Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89= f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f= 0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007ffe9f3eea78 EFLAGS: 00000246 ORIG_RAX: 0000000000000009 > RAX: ffffffffffffffda RBX: 00007f5d73c15fa0 RCX: 00007f5d7399acb9 > RDX: 0000000000000002 RSI: 0000000000030000 RDI: 0000200000000000 > RBP: 00007f5d73a08bf7 R08: 0000000000000003 R09: 0000000000000000 > R10: 0000000000000011 R11: 0000000000000246 R12: 0000000000000000 > R13: 00007f5d73c15fac R14: 00007f5d73c15fa0 R15: 00007f5d73c15fa0 > > > > *** > > If these findings have caused you to resend the series or submit a > separate fix, please add the following tag to your commit message: > Tested-by: syzbot@syzkaller.appspotmail.com > > --- > This report is generated by a bot. It may contain errors. > syzbot ci engineers can be reached at syzkaller@googlegroups.com. The issue comes from alloc_one_pg_vec_page() in net/packet/af_packet.c. It allocates a compound page with __GFP_COMP, but latter does vm_insert_p= age() in packet_mmap(), using it as a folio. The fix below is a hack. We will need a get_free_folios() instead. I will check all __GFP_COMP callers to find out which ones are using it as a folio and which ones are using it as a compound page. I suspect most are using it as a folio. #syz test diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 2194a6b3a062..90858d20dfbe 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5311,6 +5311,8 @@ unsigned long get_free_pages_noprof(gfp_t gfp_mask,= unsigned int order) page =3D alloc_pages_noprof(gfp_mask & ~__GFP_HIGHMEM, order); if (!page) return 0; + if (gfp_mask & __GFP_COMP) + return (unsigned long)folio_address(page_rmappable_folio(= page)); return (unsigned long) page_address(page); } EXPORT_SYMBOL(get_free_pages_noprof); Best Regards, Yan, Zi From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id IF06KlnffGnKMDkAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 16:42:01 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 16:42:01 +0000 Received: from sin.lore.kernel.org ([104.64.211.4]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlrZJ-0000000GRzP-0Dvo for hi@josie.lol; Fri, 30 Jan 2026 16:42:01 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sin.lore.kernel.org (Postfix) with ESMTP id 785223002B57 for ; Fri, 30 Jan 2026 16:41:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3169C34D934; Fri, 30 Jan 2026 16:41:55 +0000 (UTC) X-Original-To: io-uring@vger.kernel.org Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF1BF3191A7 for ; Fri, 30 Jan 2026 16:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769791315; cv=none; b=b2WQrff/PjHY9YIvK+akg7R5ZHV8Vpo7i93wAxMIqZ00sHH59GXtfTCP1NDu0CKyyFKXyEpNujSrMi4ZoP1jBbBEHiqrvnzFWJ5MY/JeDx5AruMEr+QxRE/e/ZhUk3abJh3wsvbewZTJNH4SbBTT69pUTMqh32rpx9yZZHQdpEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769791315; c=relaxed/simple; bh=DjcBVY8mJqbGJnCRObWENCx0c6xRt7QNzm9li1dg71c=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To:Cc: Content-Type; b=eyNhQWyd262sjhpp2OT2LOhQ81mcPNvYL6Jv5GQr+S3zWu92CbJKxQY8j+cyVnAagDvCJxHvVFAMgXzIZd7NFXea+dCRBsVmf0CuPVYeZlAGsMesI7jt+2tT3I/36OSbnXeggXT/cH8/ilOGqqM42lRKh2eNKCeGXVkXO3zV3yM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.160.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-409682c165fso7551987fac.3 for ; Fri, 30 Jan 2026 08:41:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769791313; x=1770396113; h=cc:to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DjcBVY8mJqbGJnCRObWENCx0c6xRt7QNzm9li1dg71c=; b=WdV3t/k+5kDac81GvcpS3/1E/v3Nj592gEr5D3nNW2KHCe1M3gNv8VxlZcP17/PLet S7G5O/zmQ2zkV4A6LZLQllzOhbfVTCvHXagf1hUYpk7fjti95AZjenomdPLr1VcuBVs6 DWDOTVyPTqd4hEGh8RYBAX3km9+HS6SGV0HCq4USEefiwQa+gSiWHaU+IY1bKD0US/Ru ECgknrkSVy/UeRc31lpkCLLnIAyC3USHyfijdAQhk00wNTX7+3xnQlE1nk5s4LWVm2m8 cWniagnNjddUquWQW6V+H8nnKWPPGkrTUsPKif+XbdRRybT8gi0Unv68hv5ULhLCzDDH VlSw== X-Forwarded-Encrypted: i=1; AJvYcCWk71JZ2GJj48tOnc+HBt9LjekZDd4W+yZGNQXIeAN6O81AVDcTXcFX3No/Q5RIwL5BVy6XqUFlXw==@vger.kernel.org X-Gm-Message-State: AOJu0YzUc4yn0pAdpklJt2T3SjAVsflcfa6Y5imhbFlZKbBV4W9GNE+I vl/jOwkRO0g45aUvyx8GpR/7NoCaDY/+z0o/M8Qd8O/u+O/CDC/KKIY6jTTxM6vPat8vzFquJUd UKyayo1OvBWsTj/ppgTXLEYZFmeHe2g4DkYGBzSct565s+9pGpHNUmYsg1jw= Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:4613:b0:663:cb2:d67d with SMTP id 006d021491bc7-6630f04c2bamr1438160eaf.37.1769791312692; Fri, 30 Jan 2026 08:41:52 -0800 (PST) Date: Fri, 30 Jan 2026 08:41:52 -0800 In-Reply-To: <2A678D66-2516-4130-A34B-6A0B3549EEA7@nvidia.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <697cdf50.050a0220.371857.00e6.GAE@google.com> Subject: Re: Re: [syzbot ci] Separate compound page from folio From: syzbot ci To: ziy@nvidia.com Cc: akpm@linux-foundation.org, apopple@nvidia.com, axboe@kernel.dk, balbirs@nvidia.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, david@kernel.org, dev.jain@arm.com, hannes@cmpxchg.org, io-uring@vger.kernel.org, jackmanb@google.com, jgg@nvidia.com, lance.yang@linux.dev, liam.howlett@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, mhocko@suse.com, muchun.song@linux.dev, npache@redhat.com, osalvador@suse.de, rppt@kernel.org, ryan.roberts@arm.com, surenb@google.com, syzbot@lists.linux.dev, syzkaller-bugs@googlegroups.com, vbabka@suse.cz, willy@infradead.org, ziy@nvidia.com Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [104.64.211.4 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 Unknown command From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id uFQgCrLkfGleVT4AYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 17:04:50 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 17:04:50 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlrvN-0000000HEzd-3JcQ for hi@josie.lol; Fri, 30 Jan 2026 17:04:50 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 957EB304E0C0 for ; Fri, 30 Jan 2026 17:00:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 719F42253A0; Fri, 30 Jan 2026 17:00:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com header.b="m27aXN2m" X-Original-To: stable@vger.kernel.org Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27E83570A6 for ; Fri, 30 Jan 2026 17:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.153.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792422; cv=none; b=Jj7bL19W2wBgjtvFkVt+/H7QwNRSF+B8c/t2M5VDX4pGrFwmCkFZcDNqjeek5jOFtG6UZUsI4Eq2oeGinFeu6s43jbLjxSTlVEF+4X3ZS88FzQHxAopADtduIthdH8dOUYfo/FyKkIh6MrKH3XJUuxG+ily+tPBt22FNmfrdgs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792422; c=relaxed/simple; bh=JyBRMQSQuxvl3z8pwOXAeqgUK9hw9MiYTK2ahHd4AHs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CApPXydGf3ZBLZjlmjdUHYcSalTiUSiB3Is2Wne8q4zQHGezoIpFneL1hQc9RaE1dfKCf9P05ys8ueggsg9Cc8uCml6JJ+fmNjPFYuqSPc568B/HfxjGx43EACUhcdVyhi/0rMkZnK4DmKnDCfD1UgxaQo5ko4CSoAnOmDVY9qM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meta.com; spf=pass smtp.mailfrom=meta.com; dkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com header.b=m27aXN2m; arc=none smtp.client-ip=67.231.153.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meta.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=meta.com Received: from pps.filterd (m0089730.ppops.net [127.0.0.1]) by m0089730.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 60UD9DlY3839412 for ; Fri, 30 Jan 2026 09:00:19 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=s2048-2025-q2; bh=Mm+xOkZ24YFd5RjWStEPyEiVdlh2cY8+P++RYXeeNlA=; b=m27aXN2mAG+e ez4zm7jZzRaxhytqzIvPVQpZw8dSPXOVVwYRJUoVs0x/Ts7AiNo7i+Kh+nS/e61l 8GKDxve7wHyt8jNCp82wGUbAAQtYCclS4a5cnBbFOmbfcX5foxShfeqytUpw2p48 RnoiB+kw+m835G+uXtPlYWcX8NaCeJfmEKFPr4aYKB6M86bFeWfAZJELtzSbts1D ompmX06B9I4d6pnh/wEAWPPY3U2nOhhGeIi7IwnZrxQOUBpr8ucpa6kvpFOhGtD6 mNtu0GXHLmPM8V18a/spDpXkmZM8kRFquJeFxnTEVodqPWryyVcFczJKT0K7LmXN kwuO+nfnyQ== Received: from mail.thefacebook.com ([163.114.134.16]) by m0089730.ppops.net (PPS) with ESMTPS id 4c0w9ctd2d-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 09:00:19 -0800 (PST) Received: from twshared108583.15.frc2.facebook.com (2620:10d:c085:208::f) by mail.thefacebook.com (2620:10d:c08b:78::2ac9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.35; Fri, 30 Jan 2026 17:00:15 +0000 Received: by devbig197.nha3.facebook.com (Postfix, from userid 544533) id 84E026EAF1B1; Fri, 30 Jan 2026 09:00:04 -0800 (PST) From: Keith Busch To: , CC: , , , , , , Keith Busch Subject: [PATCHv2 1/4] PCI: Fix incorrect unlocking in pci_slot_trylock() Date: Fri, 30 Jan 2026 08:59:50 -0800 Message-ID: <20260130165953.751063-2-kbusch@meta.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260130165953.751063-1-kbusch@meta.com> References: <20260130165953.751063-1-kbusch@meta.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: 3AafLVpN0_WiOFTuc2CacYlgS_uHNMAw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDEzOSBTYWx0ZWRfX3s57mQA43bkx zy0M6vmSpzv0zRJhqNMGdHgtSfmI8MdzJU3sXo+q2I+cTELX6Lw4djcfwqXG+8abt4AYtwzdn9G OpV6XxKOiNw4AxF/VRZpD1nMRL9nKldt1fhrqvS1C6mLIqQeWojiF0c/0Y+LLHQWqxfZcVW6tHd KniY+GnKTcw1EA6euTn2k5y02/t/Dx4FOrq/REHBivMbT5aFF1CKIqANg6i8S2W08uxolcIQ/eH bz+rjMWKlMQxETWHUeBsbXpKGuxY9KeC9uKx4pNh3e/Y5EfHznQLmK6mhIPNDmwpDL3/mXAfObD HnFKxX9PgkOhLjN6m4Rm4pOR8oNCHVt9nbkFg5f/YD/usMArVViwSaMxRBljL8kBJoDcjdmWetu rzzMRWg1v0T9k6jgj1/uO1FKjLamD9TpFD1yFUw2BWixeulT+2im3qldv0At+yky4Z5AmNLaDoX p1dgayBVGcwKKIZtMwA== X-Authority-Analysis: v=2.4 cv=Scr6t/Ru c=1 sm=1 tr=0 ts=697ce3a3 cx=c_pps a=CB4LiSf2rd0gKozIdrpkBw==:117 a=CB4LiSf2rd0gKozIdrpkBw==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=968KyxNXAAAA:8 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=KowqXwEJNvZSKAjHX7EA:9 X-Proofpoint-GUID: 3AafLVpN0_WiOFTuc2CacYlgS_uHNMAw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_02,2026-01-30_03,2025-10-01_01 X-DKIM: signer='meta.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 From: Jinhui Guo Commit a4e772898f8b ("PCI: Add missing bridge lock to pci_bus_lock()") delegates the bridge device's pci_dev_trylock() to pci_bus_trylock() in pci_slot_trylock(), but it forgets to remove the corresponding pci_dev_unlock() when pci_bus_trylock() fails. Before the commit, the code did: if (!pci_dev_trylock(dev)) /* <- lock bridge device */ goto unlock; if (dev->subordinate) { if (!pci_bus_trylock(dev->subordinate)) { pci_dev_unlock(dev); /* <- unlock bridge device */ goto unlock; } } After the commit the bridge-device lock is no longer taken, but the pci_dev_unlock(dev) on the failure path was left in place, leading to the bug. This yields one of two errors: 1. A warning that the lock is being unlocked when no one holds it. 2. An incorrect unlock of a lock that belongs to another thread. Fix it by removing the now-redundant pci_dev_unlock(dev) on the failure path. Fixes: a4e772898f8b ("PCI: Add missing bridge lock to pci_bus_lock()") Cc: stable@vger.kernel.org Reviewed-by: Dan Williams Signed-off-by: Jinhui Guo Signed-off-by: Keith Busch --- drivers/pci/pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 13dbb405dc31f..59319e08fca61 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -5346,10 +5346,8 @@ static int pci_slot_trylock(struct pci_slot *slot) if (!dev->slot || dev->slot !=3D slot) continue; if (dev->subordinate) { - if (!pci_bus_trylock(dev->subordinate)) { - pci_dev_unlock(dev); + if (!pci_bus_trylock(dev->subordinate)) goto unlock; - } } else if (!pci_dev_trylock(dev)) goto unlock; } --=20 2.47.3 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id mO8NHxrpfGkt1D8AYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 17:23:38 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 17:23:38 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlsDZ-00000000HsW-2ws3 for hi@josie.lol; Fri, 30 Jan 2026 17:23:38 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 437E33009F83 for ; Fri, 30 Jan 2026 17:22:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 595EB35A939; Fri, 30 Jan 2026 17:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=1g4.org header.i=@1g4.org header.b="RWamMXeY" X-Original-To: stable@vger.kernel.org Received: from mail-10627.protonmail.ch (mail-10627.protonmail.ch [79.135.106.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F189359710; Fri, 30 Jan 2026 17:22:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.27 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793768; cv=none; b=IdDVIxxd59LcT8I9KwKCQVpLKsTaXmNytkBhEjzvNak/X4A71E3kTOBe9zra0st5laF0tHUCPNcrthv5lIWfS5hGBZh5/JELQveQtnkENos/zCedclXENWO0EQ0LpbivxQh7y5Qpm1sJt66w5xRLB3Y7i4jpHDsSXnQX+s7OZrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793768; c=relaxed/simple; bh=6IsexkEpjd/dpxFx6yAbjOBMYeOwHCgMSGgGXfn9CQM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BT0xcnVlHaS0jKLbdKy37/rOIcf8xdOnoOUixgYRqmKEIhxw2Yck7fXT/Xr2R15180DuNDBPIqPe607vqDqWT0PeFhV7zhDA7RWzK0Mtei6tUfVlaQZonhbq+YATT+mJ/6jrWkWFZuPg10nlbtRqGzxPQeruTN7XOkwoMzyAu7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1g4.org; spf=pass smtp.mailfrom=1g4.org; dkim=pass (2048-bit key) header.d=1g4.org header.i=@1g4.org header.b=RWamMXeY; arc=none smtp.client-ip=79.135.106.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1g4.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1g4.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1g4.org; s=protonmail2; t=1769793757; x=1770052957; bh=6IsexkEpjd/dpxFx6yAbjOBMYeOwHCgMSGgGXfn9CQM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=RWamMXeYqBHKsrbXiwOuVpNWjJIxfHiElPhlRlrW1tr5VTMVcDd4WcLMq2NK6hxBF bdRBSkiJ+2DS7JBRMLjpuhwDhLh3CvLrc9q/HyHabyuOyCbZCHA6VzQOMn2xw5CfYW 5RB5sgxzGdrIobprkKhb4mfv9+x4Ar2opPx7ld57CuiboRHgaJZcAn52MN3kUbYh6Y FVE3GVpgpTKDFWsLozYyPg49WNlMNxE8tFVrdZe8YJoJTjyO7jpS+PoSvlEMh1LP9g 1LnUDTgQV/csEWTZo/4rfnNUuFYGizAYzOwJ0XfuKjrzNHrQPWqMJONFGqSLyEwXJP 7LoqOcEwg1xEg== Date: Fri, 30 Jan 2026 17:22:33 +0000 To: Jamal Hadi Salim From: Paul Moses Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] net: sched: act_api: size RTM_GETACTION reply by fill size Message-ID: In-Reply-To: References: <20260130134220.305757-1-p@1g4.org> Feedback-ID: 8253658:user:proton X-Pm-Message-ID: 7b528e6ff830b50d937c1b4134436380198bfc88 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-DKIM: signer='1g4.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: githubusercontent.com] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 Yes, In net/sched/act_api.c the GETACTION notify path always does alloc_skb= (NLMSG_GOODSIZE), if tca_get_fill()=20 runs out of tailroom it returns -1 and tcf_get_notify() maps that to -EINVA= L. So failures are size-dependent=20 and can look intermittent across different action dumps. act_gate might be = the outlier? The size is already computed in tca_action_gd() (sum tcf_action_fill_size()= then tcf_action_full_attrs_size())=20 and add/del already allocate max(attr_size, NLMSG_GOODSIZE). This patch jus= t makes GETACTION consistent with=20 that. On the reproducer: the gatebench test with 100 entries is reasonable. https://raw.githubusercontent.com/jopamo/gatebench/refs/heads/main/src/self= tests/test_large_dump.c I plan to follow this up with another patch for act_gate and believe they b= oth are integral to fully stabilize=20 act_gate. Thanks Paul On Friday, January 30th, 2026 at 10:05 AM, Jamal Hadi Salim wrote: >=20 >=20 > On Fri, Jan 30, 2026 at 8:43=E2=80=AFAM Paul Moses p@1g4.org wrote: >=20 > > tcf_action_fill_size() already computes the required dump size, but > > RTM_GETACTION replies always allocate NLMSG_GOODSIZE. Large action > > state can overrun that skb and make dumps fail. > >=20 > > Use the computed reply size for RTM_GETACTION replies so large actions > > can be dumped, while still keeping NLMSG_GOODSIZE as a floor. > >=20 > > Fixes: 4e76e75d6aba ("net sched actions: calculate add/delete event mes= sage size") > > Cc: stable@vger.kernel.org > > Signed-off-by: Paul Moses p@1g4.org > > --- > > net/sched/act_api.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > >=20 > > diff --git a/net/sched/act_api.c b/net/sched/act_api.c > > index e1ab0faeb8113..8ab016d352850 100644 > > --- a/net/sched/act_api.c > > +++ b/net/sched/act_api.c > > @@ -1685,12 +1685,12 @@ static int tca_get_fill(struct sk_buff *skb, st= ruct tc_action *actions[], > >=20 > > static int > > tcf_get_notify(struct net *net, u32 portid, struct nlmsghdr *n, > > - struct tc_action *actions[], int event, > > + struct tc_action *actions[], int event, size_t attr_size, > > struct netlink_ext_ack *extack) > > { > > struct sk_buff *skb; > >=20 > > - skb =3D alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL); > > + skb =3D alloc_skb(max_t(size_t, attr_size, NLMSG_GOODSIZE), GFP_KERNE= L); > > if (!skb) > > return -ENOBUFS; > > if (tca_get_fill(skb, actions, portid, n->nlmsg_seq, 0, event, > > @@ -2041,7 +2041,8 @@ tca_action_gd(struct net *net, struct nlattr *nla= , struct nlmsghdr *n, > > attr_size =3D tcf_action_full_attrs_size(attr_size); > >=20 > > if (event =3D=3D RTM_GETACTION) > > - ret =3D tcf_get_notify(net, portid, n, actions, event, extack); > > + ret =3D tcf_get_notify(net, portid, n, actions, event, > > + attr_size, extack); > > else { /* delete */ > > ret =3D tcf_del_notify(net, n, actions, portid, attr_size, extack); > > if (ret) >=20 >=20 > dunno. Is this based on some issue you found? This is a common pattern > in a lot of places in the stack and has not caused any issues (afaik). >=20 > cheers, > jamal From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 4PTSFlbwfGkGTQQAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 17:54:30 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 17:54:30 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlshR-00000001HYN-3tCw for hi@josie.lol; Fri, 30 Jan 2026 17:54:30 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 83E2430398B1 for ; Fri, 30 Jan 2026 17:53:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD7B3366546; Fri, 30 Jan 2026 17:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b="lvqXB7nL" X-Original-To: stable@vger.kernel.org Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 292E834E767 for ; Fri, 30 Jan 2026 17:53:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.210.175 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769795633; cv=pass; b=R5KBkXT+boccuxKyu1ggniC5HC5EsO3CV5JB4yxfLfdTGbFb3GFFytyyGaDrn2l6y7ok3jIjcHqYpcFNQiSQ1LFehOHpp42FlZ2tuEwa1ckUynWAzc6tYc2QNkTztabvX4+kbMMqKppy1j0mZb3CNmWjV8UYcwXdHo4DctYcaSo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769795633; c=relaxed/simple; bh=326he210/tRZUiUmp5+sWT8etWqVRtLzZLG9pPxkOqg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=FavnL6jPohtO1w1uRbjcZ45H1ZfgnzMfnydMGATfjsPACLFIe/PQdHvM8N/Ob/bBQ7sEQn3KvXr66VQIkduVV12ywvpmhI7XBx9zoBFgc61cGdZoOQI8zaWbSsiE94Lq5gkqY+x/Wv8FkgfGzDtYFXLraKZPSmwsCTA4o/qedEc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com; spf=none smtp.mailfrom=mojatatu.com; dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b=lvqXB7nL; arc=pass smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=mojatatu.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8230c33f477so1087855b3a.2 for ; Fri, 30 Jan 2026 09:53:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769795631; cv=none; d=google.com; s=arc-20240605; b=gnaM6XIGrA8KNasPLsQjJoQ+3KlznelwySQI5K1i7kD2gyHsfdeA2CvQmjd5V0LTtf r0v43qMEOp9Kih/qeSeB3oWCaZj/ES2rTSqBr9A3LJ8Mh62umgczB/sOBwukUPAt5fmq pWCl5Hp1Rosv0/CdlyEHT2DpzoyqkZ7J6aIOFdpdxXNbkGkiunxvemUfsbTCNFBl8sbu ZbgWhZIkSHKpf5BQe9OtmFfdR6AluNpFXcHMljYhVjEim14HKeuD2G0H5vOXY5aslS8v aZfa/eRslsig93al8kHTgJyNfXe7dswWhr3CSh0ejsZAkkRDbEK6k97fClXQHUS1F950 dffw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=2vQAO1Uv8zYyW2LQO1EawZkOK3KNj111fQmdKtqn2pc=; fh=duuI4EYlazk9snXQFv1EeNm7GyEp056/pZL41fcp7fc=; b=WHJh7ZToEjTXwC0V1y+vkkpqYELu/TMHtZvQDps+9JJmaZhwpdvS+k4cPpqKKBjpOf CZUb8IsnGfEOYdyxtw7K52a5AGd0IM72a66vYbcfT/e1lhTS5HLiMeQFUiFA80nj1lzw 44Wn55Rim5ZcAYp+kTlzli9+4+QlMtYJ+Xvc8YvjWXXuv2+OpFfcNIH0ZWkzKA5ukcKw A9CIrVN8xvFAvKqFFnp47k7+3vQvJaDPHQbp1ZLWchLIfLgc9+rbZsn5CWTTMpBJUOq+ 18W/2Ylr4Bv1CT4sNgi+Cdyuw/jo+HFnNoMvRQsWLi8XjzUDZocDTwNq8oTSmH3lQGrl wCyg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20230601.gappssmtp.com; s=20230601; t=1769795631; x=1770400431; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2vQAO1Uv8zYyW2LQO1EawZkOK3KNj111fQmdKtqn2pc=; b=lvqXB7nLsiR+cO4h+FLw1npQHKOEDqLC85zIfdXSWxy6Ae9x8QnfmhSBuEyAkhphHW JW7eE/AMSZZ1Ub80WcnCPonHfvlsNi2wg5/vuOD893X/twFxOroJvFxARweAcTfGUQtk HqE/PupgfPkxIOvLl0KWHyApCP6SaKrla9qhnxzTBDzSjHbnkwYBKnYXNGnZHGmaYpfI J2Yds9tsH+4ZrLOKzapjjJfTdEPAJoA6rKuJ9vqu6l4XWY2rWGQERDs9SP6StOzowJRD 7FjQYz4wgFNnlH3pkHKYdAPp2tX1ioW/lqrVg6oTCdX/vn/keQBnWLixi9qaPawJn7Xu LJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769795631; x=1770400431; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2vQAO1Uv8zYyW2LQO1EawZkOK3KNj111fQmdKtqn2pc=; b=TdIRdUx8QccYTnOD8ENtGSPumB8yzDw/+Wl8sEbWieDjmZxe9+pzaqtahf4RQCc2KA RGpGIdlySrERoYDdgCdcmv+U71XYazMSQ8t9p1DZLjuPndK23zR4isU88Q2gHZkKB7W3 spzUEX28h+UgzXSSoKVS4I16T5xgx8EM4MdRbOlJCf0AFPQNeFtaD3I4Wzvnl9BoiXf4 s6LqVPxDPv3Y6P13sF019/bSTHnsVX6h8Mg6kKo6RVrqy5iNLGCJxVE3uu1DC/eMgm5R 6AwVAeS+PdPAJxFRrLeEteicETsG0pNLo4bwNME2noXhzWkmIZXkh8nPak3nlsQ3XXKB lPJw== X-Forwarded-Encrypted: i=1; AJvYcCX22IB8hWldUPQpXjjwfPMsxOHhfX6GXUTIhFljfvGynPSB5lETH79niW9QM6TFnOW1uf8g47E=@vger.kernel.org X-Gm-Message-State: AOJu0YxdEoZyU1iPh1HRdv7umu0k60WMyU51QRgLoO8WMLvVflszKGTd wxP0oLaTMVqCIk7veVJlSk9aYrNBltzDULhQn8TnvbrUhpZd9mRSf2sdDFGP7BFX5yZF/5pmdug rM0KCu2Blay7lCdWF7IGjlSz0qZkZWA3v/+ntceXp X-Gm-Gg: AZuq6aIBJmUWk2fFUNGkwTn2UerMa69qHTMaIt2Ie+J5j73p+XBoKCZr0sqet8P4nl6 nfvP8l7/ARAuDbqSIUE5XQbPOtdvbwYmeEoxZ3HeTGi2bG0DazFR9CnUnLgLvnpWjEv15ExBwih +rj/JDtHNDoqAOLnwgbsSXZBNyY/vYs3SF/0PnxFB/E+4933pc2XT1lUgF3sa+aIdXQfyfFkuCn 2rCBiJreF1Gkt2Dgd6yj+V1dqGe7vRcEHdZKIseMOMkoo5AZ+3OtGicUGohigll2w82+9yH1dMt sz52S1qO8gG9vg== X-Received: by 2002:a05:6300:6141:b0:38e:91a7:6352 with SMTP id adf61e73a8af0-392e0163b8dmr3106804637.66.1769795631321; Fri, 30 Jan 2026 09:53:51 -0800 (PST) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260130134220.305757-1-p@1g4.org> In-Reply-To: From: Jamal Hadi Salim Date: Fri, 30 Jan 2026 12:53:40 -0500 X-Gm-Features: AZwV_QiQhjrnk_kiCNTQ9hpPibGH8uv5bn2JIzi1spPEoRMYIYMFhv-zfwvpGj0 Message-ID: Subject: Re: [PATCH net] net: sched: act_api: size RTM_GETACTION reply by fill size To: Paul Moses Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-DKIM: signer='mojatatu-com.20230601.gappssmtp.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: githubusercontent.com] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 On Fri, Jan 30, 2026 at 12:22=E2=80=AFPM Paul Moses wrote: > > Yes, In net/sched/act_api.c the GETACTION notify path always does alloc_s= kb(NLMSG_GOODSIZE), if tca_get_fill() > runs out of tailroom it returns -1 and tcf_get_notify() maps that to -EIN= VAL. So failures are size-dependent > and can look intermittent across different action dumps. act_gate might b= e the outlier? > Very bizarre that dump would fail because it is transactional. It shouldnt matter that you are only allocing NLMSG_GOODSIZE. Is there a possibility that a single act_gate entry can be larger than NLMSG_GOODSIZE? > The size is already computed in tca_action_gd() (sum tcf_action_fill_size= () then tcf_action_full_attrs_size()) > and add/del already allocate max(attr_size, NLMSG_GOODSIZE). This patch j= ust makes GETACTION consistent with > that. > I looked at act_gate dump and it is sane. Which leads to perhaps your test program being bugy. Install the 100 actions then use tc to count. Something like: tc actions ls action gate | grep index | wc -l cheers, jamal > On the reproducer: the gatebench test with 100 entries is reasonable. > https://raw.githubusercontent.com/jopamo/gatebench/refs/heads/main/src/se= lftests/test_large_dump.c > > I plan to follow this up with another patch for act_gate and believe they= both are integral to fully stabilize > act_gate. > > Thanks > Paul From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id KPS1HrTxfGm0SQEAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:00:20 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:00:20 +0000 Received: from sin.lore.kernel.org ([104.64.211.4]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlsn5-00000001TBp-2TYi for hi@josie.lol; Fri, 30 Jan 2026 18:00:20 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sin.lore.kernel.org (Postfix) with ESMTP id 910593001CFA for ; Fri, 30 Jan 2026 18:00:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6329369975; Fri, 30 Jan 2026 18:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="gB6I7Wum" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C407A1CAA79 for ; Fri, 30 Jan 2026 18:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769796014; cv=none; b=EoeB3TH2P0Gmxgfdd1mJp3fHqLiBgHu/FV7avCpJ1GveieIlGzOnjwgaFfrPKB2mrH5A6K9gFMqIsCCyKW/4Yi7UVN/yY5qZ4ceNCBLC5NNnt4KyJq56vm6usuYT0/69Xhyp7sgQvgRIqRTPd0KUr1/UsMhwrGHMqsEwj94sRjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769796014; c=relaxed/simple; bh=AFVyapZz7+rnLVcwl8jFcNdohlBEAdutFNruQ1aqrP4=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=J9F/OC85V5vG3r5bwLLVgiLeBk17/CQqoCU7BAWE2a7SBFu+ypfMHrIeVUQ6ufGSCGkHQxAOfpZGaoylhkwpx3tIUyHe//s70Pj8f/ZdJ1GdgzzElOAqCriLV7F3ZPGJjm8VOIV6+31QjTfcKcCNv2S4HeL97l2WjGL/0rGUgv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=gB6I7Wum; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30691C4CEF7; Fri, 30 Jan 2026 18:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1769796014; bh=AFVyapZz7+rnLVcwl8jFcNdohlBEAdutFNruQ1aqrP4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gB6I7WumOiVus7/WSV+qgJ8RC4GHJIMv0c9/bfPssW0cj2v2O8c2Vr1yOFpxpaIfL 606t/2u3ouWNJ6bwa1u+fRQUs4MTsPyVqGrH/GnFVGUoyC9tpvjpwO2XIha24hfAd9 UozEq6LX5GI/tCl7U2fq5VpTpS4xqDqTcHxIavIk= Date: Fri, 30 Jan 2026 10:00:13 -0800 From: Andrew Morton To: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= Cc: intel-xe@lists.freedesktop.org, Ralph Campbell , Christoph Hellwig , Jason Gunthorpe , Jason Gunthorpe , Leon Romanovsky , Matthew Brost , linux-mm@kvack.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] mm/hmm: Fix a hmm_range_fault() livelock / starvation problem Message-Id: <20260130100013.fb1ce1cd5bd7a440087c7b37@linux-foundation.org> In-Reply-To: <20260130144529.79909-1-thomas.hellstrom@linux.intel.com> References: <20260130144529.79909-1-thomas.hellstrom@linux.intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-DKIM: signer='linux-foundation.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -0.8 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-0.8 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: linux-foundation.org] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [104.64.211.4 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -1.2 NICE_REPLY_A Looks like a legit reply (A) SpamTally: Final spam score: -7 On Fri, 30 Jan 2026 15:45:29 +0100 Thomas Hellstr=F6m wrote: > If hmm_range_fault() fails a folio_trylock() in do_swap_page, > trying to acquire the lock of a device-private folio for migration, > to ram, the function will spin until it succeeds grabbing the lock. >=20 > However, if the process holding the lock is depending on a work > item to be completed, which is scheduled on the same CPU as the > spinning hmm_range_fault(), that work item might be starved and > we end up in a livelock / starvation situation which is never > resolved. >=20 > This can happen, for example if the process holding the > device-private folio lock is stuck in > migrate_device_unmap()->lru_add_drain_all() > The lru_add_drain_all() function requires a short work-item > to be run on all online cpus to complete. This is pretty bad behavior from lru_add_drain_all(). > A prerequisite for this to happen is: > a) Both zone device and system memory folios are considered in > migrate_device_unmap(), so that there is a reason to call > lru_add_drain_all() for a system memory folio while a > folio lock is held on a zone device folio. > b) The zone device folio has an initial mapcount > 1 which causes > at least one migration PTE entry insertion to be deferred to > try_to_migrate(), which can happen after the call to > lru_add_drain_all(). > c) No or voluntary only preemption. >=20 > This all seems pretty unlikely to happen, but indeed is hit by > the "xe_exec_system_allocator" igt test. >=20 > Resolve this using a cond_resched() after each iteration in > hmm_range_fault(). Future code improvements might consider moving > the lru_add_drain_all() call in migrate_device_unmap() out of the > folio locked region. >=20 > Also, hmm_range_fault() can be a very long-running function > so a cond_resched() at the end of each iteration can be > motivated even in the absence of an -EBUSY. >=20 > Fixes: d28c2c9a4877 ("mm/hmm: make full use of walk_page_range()") Six years ago. > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -674,6 +674,13 @@ int hmm_range_fault(struct hmm_range *range) > return -EBUSY; > ret =3D walk_page_range(mm, hmm_vma_walk.last, range->end, > &hmm_walk_ops, &hmm_vma_walk); > + /* > + * Conditionally reschedule to let other work items get > + * a chance to unlock device-private pages whose locks > + * we're spinning on. > + */ > + cond_resched(); > + > /* > * When -EBUSY is returned the loop restarts with > * hmm_vma_walk.last set to an address that has not been stored If the process which is running hmm_range_fault() has SCHED_FIFO/SHCED_RR then cond_resched() doesn't work. An explicit msleep() would be better? From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id uIcxJZb1fGl+dwUAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:16:54 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:16:54 +0000 Received: from sto.lore.kernel.org ([172.232.135.74]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlt38-000000020qL-1AWo for hi@josie.lol; Fri, 30 Jan 2026 18:16:54 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id AC7D43008D5A for ; Fri, 30 Jan 2026 18:16:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BA25D37D130; Fri, 30 Jan 2026 18:16:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h/B+PItv" X-Original-To: stable@vger.kernel.org Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4244433FE12 for ; Fri, 30 Jan 2026 18:16:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797005; cv=none; b=uqkU3NMfv2XVAGLE/ayW6w20cudLFCIZz1ttW07ewhJYF5s+kgcXLnYa5fTFmX2aIs/0vIfyFsk/8im9I0Bq9hMD8/OP+SxUeUgSNAkISmanVSDDS0101rJkrs3/6SnAKxo+42tXhIqfp8CMfBnY1RUXR1D7fD24qOJRNFu4uXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797005; c=relaxed/simple; bh=54jF80axLN2UJAh0SY0zu8J2BqHK+0mKcS7a+qODr54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JWgSXwYYButSy1zAbA+wmCyt74CfNnRdpnpfV01HMx6BUiUVCV0vJX/QZTXfc0EZGp1k9ypjK+4SvhVUplqVi6gvS4FQ5IVAO7Kr89UjsjX4MYRKhWi3c8rMcoTUSWkBIOLpvQeuJta+nJvz2OpI8kBcvKC/Ggv5y6m996YqS6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h/B+PItv; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-480142406b3so18454275e9.1 for ; Fri, 30 Jan 2026 10:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769797003; x=1770401803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=h/B+PItvtCLrF0JiS1yXe9+U3x5Rio87GZyET+2RaQ83/LGjt6/RoEsU3jFV3LWK2I /RZ68vT8OulcHOrpx3qeYEBdvwUx2XzMSmnFFxXLrngFKsPBdswyuNSsVIAktkTINXPV ha6+sqzr2TAtHh3Bamk9VcMUVqZJBM+l/3Od3HFyIBhqsOHdySwFVVA+XPS+Btr5PUPr Ghz2Ix2vnnX2yLd7q06b0v9ajr2fBnaDU2n79qs+09EjMQH9uco8euOGksMVy83ptabI Zu+nH9dfb34g82c1Iq9Lrx2U5R6IDZrD8OsXMN67/KuKe/8PWp2n0wGpuY8lFk+tjPFZ DXgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797003; x=1770401803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=wJEJNE5fdX+2rwXXfTQGaix5ff9ZrGmxnLxRUw5eBiKg3pcA228RWrrksNhJMAFT8c d8RdnUp79P/E2Pi/MTKxpmn+NFXoIiXDWtejw8PB+2o6uO/ySWCvgumXB6TXA3fY4eHg sFXifEWnrrrvl3g9imnLvdhXNvFMgoHmhYnDqnwecMp3m1WgtFa5U/9Ff3c5w1XFhlS1 fpFREu8Hk3jxwyFwCQxlIVv3JZh7a9mYWduqggfUl/UtRYE9q1gwJtGrbxgYJEJHFY+L T3FzPVrfs8F1fe1glG3qUlmuHy9xmZGY6/17pM4KFS7/absqHg7cNu6BwjnbiRnfMhmE guHQ== X-Forwarded-Encrypted: i=1; AJvYcCU2UW8klJz9caK7ADtoipuOog1JI5132I5M05WvC30J7UillcNtHscTQmftvf3BduNaU4dADm8=@vger.kernel.org X-Gm-Message-State: AOJu0YxatqNb7cpWvD8MjPD6CAs74D+s2K/Drywd6HqHvKIrZYMQD1tT YuR1CtlwkG+wz9BnfYtoVF1Ug7gzkVjFvyVJvPmN/BahHofkwbfSmgc= X-Gm-Gg: AZuq6aIi4bjjaTIwhNmjA57yTuqonMrdB4PjIJdyCgB8rQ0vX0moqLMju2WFXqdaqbK bnhdveGkQqSyGhva49EVuSYZyqPlM54QmGGgYC6Ut4YYSyeF7yTpE9BHvZrmbchrH7lSy+If4L/ XSpvLSsdrQEx+lMyMKvD/LBCJPBDma5a6MtKF1TAfgheQFL3T8kvffh/a6/FBQmYIIDf3cDFhRw 8Wbth1aMgrpi1P2D43pO1yhwcCgvnl9193OZt1lDlIlq9Em3BcEL90sT/W1HVtcooekZ7Jj8CmC x6os3tlfgLVE9UeOQmAIauuWOiD3anXxcp+OwbnYZ5Mn7KyJptSQOlgj1yQzUoWj1fs3JHpkNDu nPBA5HM9WjWS5Gy24jtAAqTFienTjROhFAhr76StquaF1dTtA0RZaHew9sYPyyhxDpK3GjCGKtV pDRkyI7WxC3OzK+mgTudFPK+A6o5E0Edj046pO1YbOm6JpLbLII1gin/brIDVBqk4mQiRKDaT+ X-Received: by 2002:a05:600c:3e1b:b0:477:7af8:c88b with SMTP id 5b1f17b1804b1-482db45129bmr44705235e9.11.1769797002303; Fri, 30 Jan 2026 10:16:42 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c40e04sm280571025e9.13.2026.01.30.10.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:16:41 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak , stable@vger.kernel.org Subject: [PATCH v5 1/5] staging: rtl8723bs: fix potential out-of-bounds Date: Fri, 30 Jan 2026 19:16:16 +0100 Message-ID: <20260130181620.199152-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130181620.199152-1-lukagejak5@gmail.com> References: <20260130181620.199152-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lukagejak5[at]gmail.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.232.135.74 listed in list.dnswl.org] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength = initial_out_len; - if (in_ie[i] == 0xDD && in_ie[i+2] == 0x00 && in_ie[i+3] == 0x50 && in_ie[i+4] == 0xF2 && in_ie[i+5] == 0x02 && i+5 < in_len) { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] == 0xDD && in_ie[i + 2] == 0x00 && + in_ie[i + 3] == 0x50 && in_ie[i + 4] == 0xF2 && + in_ie[i + 5] == 0x02) { for (j = i; j < i + 9; j++) { out_ie[ielength] = in_ie[j]; ielength++; -- 2.52.0 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id mE0XDbH8fGkmOggAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:47:13 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:47:13 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vltWS-00000002xqc-46nY for hi@josie.lol; Fri, 30 Jan 2026 18:47:13 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id E712D30241B9 for ; Fri, 30 Jan 2026 18:47:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 91BC4385EC8; Fri, 30 Jan 2026 18:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="kEm0xwxI" X-Original-To: io-uring@vger.kernel.org Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC7263859ED; Fri, 30 Jan 2026 18:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769798827; cv=none; b=Rvs+1C2RkpT/K7kcY3C6vOTPTfXjlOm+UkoKDTaQgdn91btnDkXUAXjes7JItchdZ1q8ITrLVkt2zgbl03UqS6091wjb+1ZI6rqlqxGu+zcXlsZF2lCw0SSfuOq9aL20bOcSRq2SGW37XRHFjX9c5yPaj+H+UKSPh2uWTOekohs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769798827; c=relaxed/simple; bh=4FX0o94g4/j+gck6q6lurkfmlT/H4llIwQqP7XZyYbY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nBLOAQA+6hSovvP7k1ripxv6LTu4mrpQF5wCcIN++OqPmCgBio1jqMfqS2eYrFmaAqmEvZ+fyPeRHa1J6xUpS/EXZ9udj3/XRVUDvZjAHOHE+7TYQEn2COcwOcT1JRXd/DgqPDVE/LgxAxT2q+5DcNZaol7bmaRPJVIKSVpKn24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=kEm0xwxI; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=PV5ptLugLWLHVi99ajukEoln9y5Onr2WkbErb2nElJc=; b=kEm0xwxI6ESGiriN/ZWMtK7pyz XH9vvPMZbwHzBqq/vT1jDPyuT//B2PTroKptDCRQKMZ8dITwx7vJE/oJa/7W5/J4BK//mC2f9Y8QQ fgAfmVf1DhuupdZ9KqIBNM+7dtddqssSyzRdsqkCPBCKnJoxElyTwCTbZRz+oH/HUulNxkN4aqY05 XtxIWY23ZaZNiPIwLB4esqcX/3YvmOIfqJkdWi3NuxM+fqN7cHOvTI8RSYCHP4NuX7zuNNROzg5P9 AGWn/cGlbFVYVUFUOeMbCSdZ+zz8LQFgEIbr85Hq3LnwpmHXftasZji7RVyolkKqoyI1d2U56kJfc 9GASVIPA==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vltWA-001urW-Lx; Fri, 30 Jan 2026 18:46:54 +0000 From: Breno Leitao Date: Fri, 30 Jan 2026 10:46:17 -0800 Subject: [PATCH net-next RFC 1/3] net: add getsockopt_iter callback to proto_ops Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260130-getsockopt-v1-1-9154fcff6f95@debian.org> References: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> In-Reply-To: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , metze@samba.org, axboe@kernel.dk, Stanislav Fomichev Cc: io-uring@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, kernel-team@meta.com, Breno Leitao X-Mailer: b4 0.15-dev-f4305 X-Developer-Signature: v=1; a=openpgp-sha256; l=2223; i=leitao@debian.org; h=from:subject:message-id; bh=4FX0o94g4/j+gck6q6lurkfmlT/H4llIwQqP7XZyYbY=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpfPyUdv4Vgd18b7l3fTf3+8F7Fa1Cdsv9kzuQf tRnWpMZHR2JAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaXz8lAAKCRA1o5Of/Hh3 bUFUD/48ErHKQ8V/LgZA0hHtFI7domjnT54z9cWlkZNQBQlByPzh07GgmQ5ZY10s/bMXbNsrjZX OEu/xUjYW/haJN9NTPM8VHmasKoFQv2siHK5RDkULhohsU2+FusrfCig1V2RIcyn4tlgTK4selw FQQVPGNxE6djZtATw3TToDQDGSYsRBrjEDPto78tLy2vlj3v6U8yszHQwmFmjxHIbme7QOJObOd MF5Pv0aHbp+NdYWNKfngl3mAskCgrNtRSSt/M+rOA9J14B+yZd+DXrR0rY0GkJ1CYDZLaLmQMc1 Dp7HBWeYgwd0kwtW2I9HZcU00xstEJRwg5HKPsrXW40ZOu1QBO7g1uGyUZwpHUcp3h97u2keCTk D5W1YE4BhEBUPAvBnLS4+eKLqMuNH00N6pD77r214GBjEbgGPgjS7MPlhPvObLEgORQJIc0P0BS pgU08CQ07E1KsNVB5Zp69ZeZNO376Oed9bnsU/J0++L2OgyLLjCbclvnKROdvsXQ0cdBK6LJNfV U0Cko0hn6a5Y2FBwsIQGBr2fQlOEXkMYZMaE+C70gTktaD9OGAIR1SE1P7V/y2t44NpOjvx8uNh +BC7vcGXqBnFcALhzMGBZ/BOcvrxB/+MyWcLqgb1U8KS0v3hIp712eccioh4hYy20uBT0jXWt8x UtVWquNDFcFBVHw== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao X-DKIM: signer='debian.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 Add a new getsockopt_iter callback to struct proto_ops that uses sockopt_t, a type-safe wrapper around iov_iter. This provides a clean interface for socket option operations that works with both user and kernel buffers. The sockopt_t type encapsulates an iov_iter and an optlen field. The optlen field, although not suggested by Linus, serves as both input (buffer size) and output (returned data size), allowing callbacks to return a random values independent of the bytes written via copy_to_iter(), so, keep it separated from iov_iter.count. This is preparatory work for removing the SOL_SOCKET level restriction from io_uring getsockopt operations. Suggested-by: Linus Torvalds Signed-off-by: Breno Leitao --- include/linux/net.h | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/include/linux/net.h b/include/linux/net.h index f58b38ab37f8a..94f6c86769afc 100644 --- a/include/linux/net.h +++ b/include/linux/net.h @@ -23,9 +23,26 @@ #include #include #include +#include #include +/** + * struct sockopt - socket option value container + * @iter: iov_iter for reading/writing option data + * @optlen: set by callback to indicate returned data size + * + * Type-safe wrapper for socket option data that works with both + * user and kernel buffers. + * + * The optlen field allows callbacks to return a specific length value + * independent of the bytes written via copy_to_iter(). + */ +typedef struct sockopt { + struct iov_iter iter; + int optlen; +} sockopt_t; + struct poll_table_struct; struct pipe_inode_info; struct inode; @@ -192,6 +209,8 @@ struct proto_ops { unsigned int optlen); int (*getsockopt)(struct socket *sock, int level, int optname, char __user *optval, int __user *optlen); + int (*getsockopt_iter)(struct socket *sock, int level, + int optname, sockopt_t *opt); void (*show_fdinfo)(struct seq_file *m, struct socket *sock); int (*sendmsg) (struct socket *sock, struct msghdr *m, size_t total_len); -- 2.47.3 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id OIEDObr8fGk9XAoAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:47:22 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:47:23 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vltWc-00000002y8n-2uNG for hi@josie.lol; Fri, 30 Jan 2026 18:47:22 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 79711303AF16 for ; Fri, 30 Jan 2026 18:47:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC343385EFA; Fri, 30 Jan 2026 18:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="BRE37BbK" X-Original-To: io-uring@vger.kernel.org Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5302A2D2390; Fri, 30 Jan 2026 18:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769798827; cv=none; b=EWBVa1P8o51IPCTEChbdvOE7Xeg+UaaFzxKJ9Ub98/VHWMAg9GG3sewaNdNYvByvm8iQiua3imYV8bp2vbAGVMXq2jcqcEUKLn1ab//D9BsVazGxzr/LkH5q5OIBoZi1JKvCvWx6YGyaMCaoy0pGQ6xuANYD60ooPEQVt/I9XJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769798827; c=relaxed/simple; bh=BsSJNvEtopeDtqJBgSI/2Gkhl3hlLNA7p2sp0lETHP0=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=EhWNtTWJ9eLracIFPKA+Tq16Rv46A9FWQmV9jSS391wz4U5bXaL2EzKVSl4Te5XMlTysDw/6JqTxRQUekC7Sdogxg8C7Ii0UfZa9VvzM3QDdC6j37aTaePV9wyQvd8LeDfnSSzoNNHwvWNUQBk0AU6m3iu3jQlv4mE43Gx+OC8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=BRE37BbK; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:From:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=u+FPaYMRBpURyEluw/yBM5AMD+gZ+OchcgAsZYWmfxQ=; b=BRE37BbKjyy6Jjmg/EurSEMkii RTo38av7dzeGatWW0eWXmdICH1mDOAOLRtrOayjTy2rq15CzRQwImBO2yTgvIN3J1XUc0GiIMLQVi KT3OpK91ivvhwr3wa8EJAExMkWc47JHoQ01HinbnxX7FB+eoRfIDXmp5M377WoQMMGmlH6E1i7f5Z 0QPM1Odce5w+xuab8o1yuPdy6YLinHm84jKbcKF5XUqEf3uV0iZMRe+174Pe7gbJZVb1Dw7BLu6+r rFZ6mYIhoJU0cua04c026xlpH3u9oVMs+dJ4NoMgm63Fzu6DY5PA4AMonkXbEhkJT/Pksyp5MOXic SNlCGm8g==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vltW5-001upj-Km; Fri, 30 Jan 2026 18:46:50 +0000 From: Breno Leitao Subject: [PATCH net-next RFC 0/3] net: move .getsockopt away from __user buffers Date: Fri, 30 Jan 2026 10:46:16 -0800 Message-Id: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAHn8fGkC/yXMQQrCMBQFwKt83rqBNMWA2QoewG1xYdPXGoWkJ FEKpXcXdT0wGwpzYIGTDZnvUEKKcNI2An+/xZkqjHACo43VbafVzFqSf6alquPUWWsO5OgHNII lcwrrL+sRWVXkWuVyPuH61/IaHvT1+2HfPx3gKg58AAAA X-Change-ID: 20260130-getsockopt-9f36625eedcb To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , metze@samba.org, axboe@kernel.dk, Stanislav Fomichev Cc: io-uring@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, kernel-team@meta.com, Breno Leitao X-Mailer: b4 0.15-dev-f4305 X-Developer-Signature: v=1; a=openpgp-sha256; l=2888; i=leitao@debian.org; h=from:subject:message-id; bh=BsSJNvEtopeDtqJBgSI/2Gkhl3hlLNA7p2sp0lETHP0=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpfPyUfLJa7kYCbO9DaPKX8IKB5y49gG2tFLqTH L/wt/Qt4O+JAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaXz8lAAKCRA1o5Of/Hh3 bYwkD/4xEVmxAXrxOB25//mNLPLzteB+X6gKqaL7XJQLuHAZ5l3mF9n8j1Pupovi8IlxeiQ5F4p wb7bUSTFoAVgDXEY7hwg/mM4h06GdaeW/995ft1S+5iOQlMK4RxJBY6pT7YLM3d9TOgqVTtB/2d Ky4mA7IRNTqn5Xf/Cjf/iTcQzQ2LUBIGR1qaqbfxu/k4YH+x6RKviYE73ghHMM6fIbQYQ3ABmzp r35WTtMZRPsDpgMb8WyRY9OT4yph5G1/5caOOU4tgxSkUn+6mBwgjEg8G0GtG1pWUTmicDlRvIA urmCQzAnD8TesVnEiD8zOvshq9hlJO87wJ1blFiHItDmdaYKxlCp2WRDx5ErMXYhzI45hv/VQQf 4FEx44fzLx0YD0bmks8QsWK2azaJ32D3eAwC8mFC+J62+qWHCw2XQha2pXHDwL7axCJFH5QXmNC Yi1912czfP6qtwUM6LENE84BWR8Kxm1uH3ucxi8/SnD9CVZl6BtJYx1IasTiDEshQqEQdEiA5uO v2ufBY83VKdndujzznknSdGl8xFZsSTzlBfUb692Gr3A9wyztKp9Ouod9b14w/q+IsMWaTmz4Ig nxdw9hFVRR8FI+BigvbjHm7xD+B8OzHwEksodPalsbGzi2hA16qPWiFuRE9j2RHEeIEqYbTv6iv P2QEaFph0JnsOBg== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao X-DKIM: signer='debian.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 Currently, .getsockopt callback cannot be called with kernel buffers because it requires userspace addresses: int (*getsockopt)(struct socket *sock, int level, int optname, char __user *optval, int __user *optlen); This prevents kernel callers (io_uring, BPF, etc) from using getsockopt on levels other than SOL_SOCKET, since they pass kernel pointers rather than __user pointers. Following Linus' suggestion [0], this series introduces a wrapper around iov_iter (sockopt_t) and a temporary getsockopt_iter callback: typedef struct sockopt { struct iov_iter iter; int optlen; } sockopt_t; Note: optlen was not suggested by Linus' but I believe it is needed, given random values could be passed by protocols back to userspace. And the callback becomes: int (*getsockopt_iter)(struct socket *sock, int level, int optname, sockopt_t *opt); The sockopt_t structure encapsulates: - An iov_iter for reading/writing option data (works with both user and kernel buffers) - An optlen field for buffer size (input) and returned data size (output) The plan is to enable getsockopt to leverage kernel buffers initially, but then move .setsockopt from sockptr_t into this as well. This series: 1. Adds the sockopt_t type and getsockopt_iter callback to proto_ops 2. Adds do_sock_getsockopt_iter() helper that prefers getsockopt_iter 3. Converts one protocol (netlink) to use getsockopt_iter as a proof of concept This is what I have in mind for this work stream, to make it more digestible: * Keep the temporary getsockopt_iter callback allows protocols to migrate gradually. * Once all protocols have been converted, getsockopt can be removed and getsockopt_iter renamed back to getsockopt with the new API. * Once the protocols are converted, the SOL_SOCKET limitation in io_uring_cmd_getsockopt() will be removed. * Covert setsockopt() to also use a similar strategy, moving it away from sockptr_t. * Remove sockptr_t in the front end (do_sock_getsockopt(), io_uring_cmd_getsockopt()) and start with sockopt_t (instead of sockptr_t) in __sys_getsockopt() and io_uring_cmd_getsockopt() Link: https://lore.kernel.org/all/CAHk-=whmzrO-BMU=uSVXbuoLi-3tJsO=0kHj1BCPBE3F2kVhTA@mail.gmail.com/ [0] --- Breno Leitao (3): net: add getsockopt_iter callback to proto_ops net: prefer getsockopt_iter in do_sock_getsockopt netlink: convert to getsockopt_iter include/linux/net.h | 19 +++++++++++++++++++ net/netlink/af_netlink.c | 22 ++++++++++++---------- net/socket.c | 42 +++++++++++++++++++++++++++++++++++++++--- 3 files changed, 70 insertions(+), 13 deletions(-) --- base-commit: 4d310797262f0ddf129e76c2aad2b950adaf1fda change-id: 20260130-getsockopt-9f36625eedcb Best regards, -- Breno Leitao From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id IEYdLMv8fGnNrwQAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:47:39 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:47:39 +0000 Received: from sto.lore.kernel.org ([172.232.135.74]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vltWt-00000002yeN-1Kfg for hi@josie.lol; Fri, 30 Jan 2026 18:47:39 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id A11F7300B5A2 for ; Fri, 30 Jan 2026 18:47:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6AC4138757A; Fri, 30 Jan 2026 18:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="aRHmPsMW" X-Original-To: io-uring@vger.kernel.org Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4CCB387378; Fri, 30 Jan 2026 18:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769798830; cv=none; b=FQliOOZo1GmR5g0zPYCpgLGl7G5GYOVf+snCCiVPPtmQB8NOTq8QVCwsJSuP1B+Lvja6tyrL8f5hD056Xuv/n4Y6xLnErlG372fucQobpOQkv6naNoCpSvwOLct1dXwZNX3379xZ/VNgWzEaE3ZzBGzgxmIJrq32AsSLVZpPAcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769798830; c=relaxed/simple; bh=IVnLhnrcy/3xPEQctLWhlsnsImXX6rsH2GP1mnkmDNQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ninl4gqEi+mhuXkI2SVPYjQm8YdlvBaPxO6fTdO2uCl59RQcc5oI8X0S6jLwwtFuYeJNSPC0lPtPsag3YeAH9MudQZQrZuwZH4LkKvlNQR8oqeOoNqkkCdL19pbQxiEmIhH566jsoUh8ktkqtv5yKb8zW7Zb4XrHcWfgb0owjUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=aRHmPsMW; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=gW70Iuxcr93CtMyUc93o0K6n2EmDcL/0tFhB6bt/uXk=; b=aRHmPsMWedGIXc2X0YSNAMvFAT gpBxbCe23doJ2GkVOjXk5qAtYdxfG7QHsv/GZFeGglF5MVb8oi8ie8ecBvqK6OwwGvp3Mrufj4R9f gwTIgyr9An7iroBpuFdP4pCvSv54rbsHMadaNcOX2Oks/h19TTOICxX6Iv3LinlyE9QvOv+tbGx/L wTcT5umDxfJ4bBZWN9TxcctGh0UQpm3mRZ4XmF3h5po3lGR7yRCUFQw2uBAZRzDswWic5we1XzcwF /SAvFr1DLgt6bXlrFp4P21KqJpRkog5J4b+9kw2+DpFOJNuHjlhk466pmK9RtnC8VpIwnGyBr2P/L ry9AY69w==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vltWK-001urn-5X; Fri, 30 Jan 2026 18:47:04 +0000 From: Breno Leitao Date: Fri, 30 Jan 2026 10:46:19 -0800 Subject: [PATCH net-next RFC 3/3] netlink: convert to getsockopt_iter Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260130-getsockopt-v1-3-9154fcff6f95@debian.org> References: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> In-Reply-To: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , metze@samba.org, axboe@kernel.dk, Stanislav Fomichev Cc: io-uring@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, kernel-team@meta.com, Breno Leitao X-Mailer: b4 0.15-dev-f4305 X-Developer-Signature: v=1; a=openpgp-sha256; l=3397; i=leitao@debian.org; h=from:subject:message-id; bh=IVnLhnrcy/3xPEQctLWhlsnsImXX6rsH2GP1mnkmDNQ=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpfPyU2OZHI4M0lCr3semqght57TV1hos0Fo3WE c1nHQfKtcOJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaXz8lAAKCRA1o5Of/Hh3 bQ4lEACRll/JUEMJtdVPtrX+RF5bS7TQWHv7YtDd+8lAJdwtts5jliTofGG4ukbpoQbE4pRKcmL N/9T9SNairfNx6pRssn8tdoyNfc2TICWLatqB057ecdFQqlbWWefHLy4Jycya/yZUIQap+S3roY vR0L2UggKugpnVKUZ9+dAA4uYhYkCfVlS/SY4VU4Bk2NHNDCJvllMiGXsi71Bv2Pq7MirYfw/uv xiblpCNa5UEKDsIbIKV/sobPtejFcU50xdAtoxDBv2shqH6xsO0i3NxzhNBDxuJ6+ufHizF0M1Q zrbl+57gijjx5LAREzuKi2WQAPF7uDsNb2Tvsalu+PAD8JRZ7YznHF1L1PzPbqnoWs3OPIcjGt+ xNcJyKiVgsbt5Pv6S1jqDc6xAL5LWxhgAhzAvPTX/SELvDNREw+K+cpSI+z9fSWKPCXonVFoFTJ jGCQ6XOInJel7qW1TpyKx5prRb9mVwyWxC/RV4pjjA2qR4jWSGQ8BdRysIMGBBc1ag7w0abTwFD K7scjnQ7i3JMdCkzk4VNJROLa+khmlxqU6rF+iJEVB+Qe7gGJWU52UiApPVoc9+pHLnOLR/ZPYF Tpx8H3BUSXqEYGONXfRZKraJkRpzAK9GIMCiXVrgUzXLcH4KihTVihsECbhYcLvmEH0sGkpQknh pios0YQFtQXxG+Q== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao X-DKIM: signer='debian.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.232.135.74 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 Convert netlink's getsockopt implementation to use the new getsockopt_iter callback with sockopt_t. Key changes: - Replace (char __user *optval, int __user *optlen) with sockopt_t *opt - Use opt->optlen for buffer length (input) and returned size (output) - Use copy_to_iter() instead of put_user()/copy_to_user() The optlen field allows callbacks to return a specific length value independent of the bytes written via copy_to_iter(). This enables io_uring to call netlink's getsockopt with kernel buffers. Signed-off-by: Breno Leitao --- net/netlink/af_netlink.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 8e5151f0c6e46..8a195eb1ef761 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include #include @@ -1716,7 +1717,7 @@ static int netlink_setsockopt(struct socket *sock, int level, int optname, } static int netlink_getsockopt(struct socket *sock, int level, int optname, - char __user *optval, int __user *optlen) + sockopt_t *opt) { struct sock *sk = sock->sk; struct netlink_sock *nlk = nlk_sk(sk); @@ -1726,8 +1727,7 @@ static int netlink_getsockopt(struct socket *sock, int level, int optname, if (level != SOL_NETLINK) return -ENOPROTOOPT; - if (get_user(len, optlen)) - return -EFAULT; + len = opt->optlen; if (len < 0) return -EINVAL; @@ -1743,6 +1743,8 @@ static int netlink_getsockopt(struct socket *sock, int level, int optname, break; case NETLINK_LIST_MEMBERSHIPS: { int pos, idx, shift, err = 0; + u32 group_val; + size_t size; netlink_lock_table(); for (pos = 0; pos * 8 < nlk->ngroups; pos += sizeof(u32)) { @@ -1751,14 +1753,14 @@ static int netlink_getsockopt(struct socket *sock, int level, int optname, idx = pos / sizeof(unsigned long); shift = (pos % sizeof(unsigned long)) * 8; - if (put_user((u32)(nlk->groups[idx] >> shift), - (u32 __user *)(optval + pos))) { + group_val = (u32)(nlk->groups[idx] >> shift); + size = copy_to_iter(&group_val, sizeof(group_val), &opt->iter); + if (size != sizeof(group_val)) { err = -EFAULT; break; } } - if (put_user(ALIGN(BITS_TO_BYTES(nlk->ngroups), sizeof(u32)), optlen)) - err = -EFAULT; + opt->optlen = ALIGN(BITS_TO_BYTES(nlk->ngroups), sizeof(u32)); netlink_unlock_table(); return err; } @@ -1784,10 +1786,10 @@ static int netlink_getsockopt(struct socket *sock, int level, int optname, len = sizeof(int); val = test_bit(flag, &nlk->flags); - if (put_user(len, optlen) || - copy_to_user(optval, &val, len)) + if (copy_to_iter(&val, len, &opt->iter) != len) return -EFAULT; + opt->optlen = sizeof(int); return 0; } @@ -2813,7 +2815,7 @@ static const struct proto_ops netlink_ops = { .listen = sock_no_listen, .shutdown = sock_no_shutdown, .setsockopt = netlink_setsockopt, - .getsockopt = netlink_getsockopt, + .getsockopt_iter = netlink_getsockopt, .sendmsg = netlink_sendmsg, .recvmsg = netlink_recvmsg, .mmap = sock_no_mmap, -- 2.47.3 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id SGTgHSL9fGlRzwoAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:49:06 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:49:06 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vltYI-000000031QW-1Crz for hi@josie.lol; Fri, 30 Jan 2026 18:49:06 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 518F53050439 for ; Fri, 30 Jan 2026 18:47:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F0AF33876DC; Fri, 30 Jan 2026 18:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="dFgkOSl4" X-Original-To: io-uring@vger.kernel.org Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 621B4387580; Fri, 30 Jan 2026 18:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769798830; cv=none; b=E7oAFPqMyEoougY1QgveAnh5H7V+FNkH+USjgYr5+3gg41PYKy8LAzE024WMmUfVAsE+BjNR99bUyLLij5TuqCVYKxWyadQs2+KmWcajc4jnMXPg2OzuBeiaE/8kLOChTlUpWwk2RK5qqAVVlqsenxS16AKy8HjXDEa0z/okIp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769798830; c=relaxed/simple; bh=VoX4apeR1/fBQJ1bijPUH/ri8Yl1RQPOugsV/RS525k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aKsF5bB5CNA7S6UhurpYgl5TzPQc1bmnAmN63hmYZN1T/PJlMOdk2jbzXijb7bUMwxwFr3BPvtZ3qdEC4Nr8U+1vKKnzlN2msrNRUZpUlIbecq2rwVF7/MVymLEEZk02+VMwHqqYm6hAGr/h+CcMMBxBaYS6f+BterZWbMSgtCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=dFgkOSl4; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=usq+Fh3qedDoR7rCGaWM06IbYW1Zl0rkP+xHJTmMv28=; b=dFgkOSl4Qbfsl2E9XM2D1lnR63 kxyMynPGNO05wAVCfygTskPk8fJ6FpUmWasx86xOsfsBddCOVScweeuwQIJpTwYiNv4A93msblr73 UN0jCC9eno5x0M5sgiairOipvwHSUVw//SV8sQ3xBMSAb1K9P+0EmHJ/m+oJfGXatutGiY/3DllIR 1OwCegUB5yULdeMME3V/HiXpFN/30i6b5FDLMnT0jP+n+aUFcUkTS8MCHmB4tA3RyUPVjf818ddEU M1G4f/wHdMppGeyLXD/qCFsTQfOGsdhekqTw8mIZKmQP5liGtE2UU0o2k2qJP5bXTEiXmy9sK3INy ZwH+WjCw==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vltWF-001urd-Ct; Fri, 30 Jan 2026 18:46:59 +0000 From: Breno Leitao Date: Fri, 30 Jan 2026 10:46:18 -0800 Subject: [PATCH net-next RFC 2/3] net: prefer getsockopt_iter in do_sock_getsockopt Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260130-getsockopt-v1-2-9154fcff6f95@debian.org> References: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> In-Reply-To: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , metze@samba.org, axboe@kernel.dk, Stanislav Fomichev Cc: io-uring@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, kernel-team@meta.com, Breno Leitao X-Mailer: b4 0.15-dev-f4305 X-Developer-Signature: v=1; a=openpgp-sha256; l=2836; i=leitao@debian.org; h=from:subject:message-id; bh=VoX4apeR1/fBQJ1bijPUH/ri8Yl1RQPOugsV/RS525k=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpfPyUWb2C31GfLNnJFiMkIKi+ss+7naggtKlpw 937uzCL7wyJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaXz8lAAKCRA1o5Of/Hh3 bfK/D/9nRWHA4mKgr+GxKyziMLTfw1bkKVxBk8n58v9M4DS9704rAebJJHOetoYEpxhVYuxijj3 f/2yOSk3xNSP/707kGrhNQfK8vxXIIgTXPA3Sh8WlBiUtC9xrqN0MxnLCxxEXgRUAJ/B+IIgaNk WPd+qoiYW9cdz2GJMOW5icyQwiLwgCjNEhZKr1I0yprdQmnX635doU51jmh0Yv1A6tDlrZWX74A D4WstkhTqPRjSptr+TGQCI5HsjKgXwAz+MfNOttb1lsliUhykTodRTXWfvm+IOQIhwwOd2nwUPr zIltosNZ2CCE+gjqZ9KJngBdF1N2chVCwPo5qYfq09HH0frfqHd/iPFUw48w7DnXqXsnVrDEpvn Iy4pTk9vc2+QcYIgje4Adpg0D1uZX70HgnQruCVQDjFxdKzhmuPdANmZNT/QNp8T6Uu7NFlgL03 R0WFmz6IqgAh0v8crUyLvx+EMf+pQob/jJ6WUrjSPJDPqgYIUv5qoEU61F2/axkRG2hUmP8LWHM Hp6iNFgIysXNPbaS9lue25L/XqhYCL86zBKJhnIkApBHWFeRG4BszTG35gha7u5R0+6J6pMlVx3 2sJZH4pGR94Kixy5g+Ndu/3juVFbKUCbG/JX4XFofYe1Fp7Amikj7N/Gr3QT24O3hTRxMlf1mUZ XCnMI9jZTyAaLeQ== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao X-DKIM: signer='debian.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 Update do_sock_getsockopt() to use the new getsockopt_iter callback when available. Add do_sock_getsockopt_iter() helper that: 1. Reads optlen from user/kernel space 2. Initializes a sockopt_t with the appropriate iov_iter (kvec for kernel, ubuf for user buffers) and sets opt.optlen 3. Calls the protocol's getsockopt_iter callback 4. Writes opt.optlen back to user/kernel space The callback is responsible for setting opt.optlen to indicate the returned data size. Signed-off-by: Breno Leitao --- net/socket.c | 42 +++++++++++++++++++++++++++++++++++++++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/net/socket.c b/net/socket.c index 136b98c54fb37..2d830262b1be5 100644 --- a/net/socket.c +++ b/net/socket.c @@ -77,6 +77,7 @@ #include #include #include +#include #include #include #include @@ -2356,6 +2357,38 @@ SYSCALL_DEFINE5(setsockopt, int, fd, int, level, int, optname, INDIRECT_CALLABLE_DECLARE(bool tcp_bpf_bypass_getsockopt(int level, int optname)); +static int do_sock_getsockopt_iter(struct socket *sock, + const struct proto_ops *ops, int level, + int optname, sockptr_t optval, + sockptr_t optlen) +{ + struct kvec kvec; + sockopt_t opt; + int koptlen; + int err; + + if (copy_from_sockptr(&koptlen, optlen, sizeof(int))) + return -EFAULT; + + if (optval.is_kernel) { + kvec.iov_base = optval.kernel; + kvec.iov_len = koptlen; + iov_iter_kvec(&opt.iter, ITER_DEST, &kvec, 1, koptlen); + } else { + iov_iter_ubuf(&opt.iter, ITER_DEST, optval.user, koptlen); + } + opt.optlen = koptlen; + + err = ops->getsockopt_iter(sock, level, optname, &opt); + if (err) + return err; + + if (copy_to_sockptr(optlen, &opt.optlen, sizeof(int))) + return -EFAULT; + + return 0; +} + int do_sock_getsockopt(struct socket *sock, bool compat, int level, int optname, sockptr_t optval, sockptr_t optlen) { @@ -2373,15 +2406,18 @@ int do_sock_getsockopt(struct socket *sock, bool compat, int level, ops = READ_ONCE(sock->ops); if (level == SOL_SOCKET) { err = sk_getsockopt(sock->sk, level, optname, optval, optlen); - } else if (unlikely(!ops->getsockopt)) { - err = -EOPNOTSUPP; - } else { + } else if (ops->getsockopt_iter) { + err = do_sock_getsockopt_iter(sock, ops, level, optname, + optval, optlen); + } else if (ops->getsockopt) { if (WARN_ONCE(optval.is_kernel || optlen.is_kernel, "Invalid argument type")) return -EOPNOTSUPP; err = ops->getsockopt(sock, level, optname, optval.user, optlen.user); + } else { + err = -EOPNOTSUPP; } if (!compat) -- 2.47.3 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id sE8VIrz9fGne9wUAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:51:40 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:51:40 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vltam-000000036cM-1gCJ for hi@josie.lol; Fri, 30 Jan 2026 18:51:40 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 1C043301A149 for ; Fri, 30 Jan 2026 18:51:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BF763353EEE; Fri, 30 Jan 2026 18:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nFBHV9bk" X-Original-To: stable@vger.kernel.org Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31DBE3859CB for ; Fri, 30 Jan 2026 18:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799088; cv=none; b=hqDgA+sWu2+nrJeJgB+eoATDh7nCh3GSWXnhSK3EevBm9RNBLhpf1lbH/NO+G28ZyoN85PonqKqOclMZsZy4dJBTpOG8yd8C78INj8o1ZxVf17EbSqX3AJuquuamLNJNAWDGrUR0xgtoXC7+iq8o0aphkIcO5AOUcb3t1WVtkLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799088; c=relaxed/simple; bh=54jF80axLN2UJAh0SY0zu8J2BqHK+0mKcS7a+qODr54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ob6e2H26iYG04b640lhGd46J48PKTABtExstYYeSHA2wzhk3CHsHmNkhnppyBlglOae2DeDSxEFPlhi8RUyD65KJtnECGecuEMYyLPEH/XLOGrrUMSAqKyRnW6PTZUttcBkYSC6IdENQ7SZnju7TFZATDQ9b7iWRBSLH7aGSvHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nFBHV9bk; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-432d2c7a8b9so2247899f8f.2 for ; Fri, 30 Jan 2026 10:51:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799084; x=1770403884; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=nFBHV9bk+fopyRoopFFl+iDJ7uSgzNBLTgkLskNfpfdDZ2WyizsgH21v0hmzvHFgJG gffv1gobqkFzko1RpsC6z+L01q8DXVvq5mUuwL01tUNKO03SSE4FzQbW6oBwaz9Iof2u GA6JptJdkmbisKXPznDH2wA2y79WEiK7OzUAFzTC/EbgjOItHv5cZX1m/zDBLVvdYCan 6z+vWhF7cUxBUGOP+ujLZc/m4QYtNuAPiBca40bGMSxWbOcR4vLLP5ov3BZdp76F72mc fNDAWdTuOCgcPcnfI1a6MWKVMKfCvmKX/pkKqOCxfah4hs+F0/CZrXZPj2+Pb2guijgm d5YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799084; x=1770403884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=qvSKr39/LrZu2pk6d5gHG8wdFvMrp+hTjDtGyTMCqywwL9v9rQk1C7uFVGRpMaWllZ HKcW5dKHgD0/SED/ojToqdp/Onq3lSMdBTL0lBrkLRHxuq4du69I/58HNn5kE7G/oqOU xPU7fcSv4Ja3+biMyWItSvHV9nAUQQxhlFIgOY7ztuMUp65lzWh2pBPu2vMTS3UA7qYH cc8UYHdDI5sPyfkb9pP2XFAXtrVQYI32d15TuGSHWkIiYsZvFMrNYsHaJriUqwlkI3U6 fZWdhdwPW2h+lnlyUMrQcGsoFIcDJajbLgdhyNu0DNGC2JvgRBWOVBtSagAkjvKdDysE qDrQ== X-Gm-Message-State: AOJu0YzF8NQqvQsGoHIwfmC3z/wFR9lxsN8hHDBaAw1dx+LXcZR/6Y3S dc+JmZTzCcuEJCBtAlbui3N/mI+Jyb6aPR7o6fcQHFG6iYC9Znzu6xM= X-Gm-Gg: AZuq6aKejf0xX/U6DhldmPfMQBXBMgi05O+O8q2uUnGidhoiCspwkvWcLU/KllgPI0d VjRUhGtnFq8G5mDVvMGz2rjOGxveTIUnVv2aTKn48loe5UJbSLWW+yAtqsDHlQRuAUJuSQVc/A6 Cg1oWLKdm7OQxjTtqsMqhqPV6vm/QhXEiEV834vsQ8uzw1O7DKbZsROagQcvFQmWhz0T1SkCnRS YyDXl/dpzwczgo8+Z9qZ24iyAbRRJMi1KQlO/S662/+C865K6U0gZ7MDngbyCJdHhJUhI3WpRGn 3WiK8E7zh+lfm1E9eRXC4H4ftazwHQlPRP9IbNX0lXPmszClUJoqUUbJ5/eI7yZAQQB+ZQjegTb 3bPL98CFkgKVsVRQYHhmckMdQfSPlmIFeVZ+JAIfPG1iTW1vxNgwBiiUi5nQlWFTjhGfjvlXSdz jgcu/KkeCMu+rjDC3b/qKp1EjjA9ncuIX/2qwTqcSPAnbBAzgKSlnNiohRxL7YSw== X-Received: by 2002:a05:6000:2002:b0:430:f494:6a9c with SMTP id ffacd0b85a97d-435f3a7b463mr6232012f8f.17.1769799084101; Fri, 30 Jan 2026 10:51:24 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10e46cesm24007200f8f.7.2026.01.30.10.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:51:23 -0800 (PST) From: Luka Gejak To: lukagejak5@gmail.com Cc: stable@vger.kernel.org Subject: [PATCH v6 1/5] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie Date: Fri, 30 Jan 2026 19:50:56 +0100 Message-ID: <20260130185100.206381-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185100.206381-1-lukagejak5@gmail.com> References: <20260130185100.206381-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lukagejak5[at]gmail.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength = initial_out_len; - if (in_ie[i] == 0xDD && in_ie[i+2] == 0x00 && in_ie[i+3] == 0x50 && in_ie[i+4] == 0xF2 && in_ie[i+5] == 0x02 && i+5 < in_len) { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] == 0xDD && in_ie[i + 2] == 0x00 && + in_ie[i + 3] == 0x50 && in_ie[i + 4] == 0xF2 && + in_ie[i + 5] == 0x02) { for (j = i; j < i + 9; j++) { out_ie[ielength] = in_ie[j]; ielength++; -- 2.52.0 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 8MvGNhX+fGk9XAoAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:53:09 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:53:10 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vltcD-000000039Z1-2X99 for hi@josie.lol; Fri, 30 Jan 2026 18:53:09 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id C4A9C3008A7C for ; Fri, 30 Jan 2026 18:52:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DF59F36A030; Fri, 30 Jan 2026 18:52:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HOyjmmfg" X-Original-To: stable@vger.kernel.org Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5887D369975 for ; Fri, 30 Jan 2026 18:52:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799165; cv=none; b=rfvXCcgKQOGuRQZbvNoZtaceiDXi75RQfCsUl0YLLQbWPQ1Xz4CN2tiRxmbDfzTeWDMGr21f1/glU8f/Os4kOxt02tabFBiEyMO+xt9e5XVntnbUsXKWbXI25u4LFzIzND0ZwrDD+ODYQEdhXfyz5vkSO+xtByZhKPKZn1rRKws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799165; c=relaxed/simple; bh=54jF80axLN2UJAh0SY0zu8J2BqHK+0mKcS7a+qODr54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rKQ0m68oAJ0rVZCZdzY3ulA7thnCUBHJBgb2YdVkhZUkI5HHZHc1uoCHQe/d3aJD//M9tG5h9EHNQir1R3vPh44bvMF4fnfg+sxpXCDw6mYG0htMr/URUdj2NJjqCbWseo/tnv+/jlNPHfVVqnboqn+67fQ8IK1NDAzs5Noce0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HOyjmmfg; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-432d256c2e6so2173754f8f.3 for ; Fri, 30 Jan 2026 10:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799163; x=1770403963; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=HOyjmmfg+DJiPpdEh0t8+vbE8F5m+ZqpMtEq14wmveZi/HskYNSMYExHVvrcKulBBY zh8tGeAJLwxgS4Cs9SkOtRUSk6aysOWGDUGLE7XvZrHNK48TZlyEuvE5AC2S8Oq3kTDp fdP4XjPzJ/4RlF94kEpF6I7mj4ZRVgLpV8SLZGNI+kxijmftoxw/jpuEkBoSTcAVwRGx OkrB0L2iRpLygJvDFxOVZxuxpYEm+6bPHf1ZRLa6Q4P5PJ9HIAHiOgGM264DeT+R+knV KwNzYDMBRBVQefE0Tjom0hw7zLmgEFBQOC6OSnuDztIIK6ggGsGFPisns5INJvewQTQG hldw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799163; x=1770403963; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=Lza5YOSJaxdJOqzeYFTEgvviUNYP9Km+GQ/MfH8WERkf9/i2d7c/pThXMbaYh2vAxs 4o9C0mknuQFwBjjxdtDBY8RzsfOUwWO7J9BE+QyrVXZtpBui6n9cf3lJBIkYb+JdyTsn eLf55PTYikuctqbnrXd9hwDZIdxdDVRedDJgyMclOGZ+qKGiCxkl+adX7yk6SPestB2t 0b7D/Wmo7AJRz+6w3redpk6QWeiKqV0G7foQJs4dZJ7//fB2WkdopHQ2QXhXyJi5mQKW HxzEMHdBXWGgQQBQdVsgW5lYjxZk+UNwwlDm/RteA3YIwvw0kfoW7gvs47pTCsfevfvs gGkw== X-Gm-Message-State: AOJu0YzCJTYUNmpWxaV4jsSN8LcSjTbCm9qWFcA8dAxPAyeitwugWIQy d3gLm8+D3zDTtGVRuhjfWcRe8hymA1KDKlqKdlMeyISGDgoUZaTbCD0= X-Gm-Gg: AZuq6aLET/iDWIQOG+tNFIWBiWYjvgMh2HNbSxGgcd/GC6XbVJYQVDLszbCBmPgreCF 1HkJkQehhYfVuCfSN6ZXVDLom8BOGsEkCFC1LrMkk7XMjr/axORUr3eUY5z+ODlAjyUBbgWuLEw osMMvXX6sGuSuYfN1zfr+YyoHzUsXxB6DjGt5d5K5yOV3qfn0iWi31EEMzLYG6Y0mCO9x0dr813 /ZlQhGZSqwAtPxn6ibA5i3HgTF3323fs/UpB+bGkGO4hokUyMsAW44nAFs0lxLahRgYGe1V7H0t zuTf2QsuTRtEFSSo4RaZbFqSo+rf8p0ovD686gmkqgWKzZrhHYSvBHMQ8KlSJjmwTTSnf9HEaXj FEq4h6PsrR187gUiClgMhU2XoMYdAQ8fS3j1PUMNqdynMgj4SOGstkRbzKaCgijEF4EAjbhqxPW z2in4FTJ7LiNx3Y7mnjl7JJtsXWDk6KI1GEBYihsBAH2TUAoImGaPFuGMqCGLG9w== X-Received: by 2002:a05:6000:401e:b0:430:feb3:f5ae with SMTP id ffacd0b85a97d-435f3ad7646mr5304918f8f.55.1769799162415; Fri, 30 Jan 2026 10:52:42 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e131cf4asm25026202f8f.28.2026.01.30.10.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:52:41 -0800 (PST) From: Luka Gejak To: lukagejak5@gmail.com Cc: stable@vger.kernel.org Subject: [PATCH v6 1/5] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie Date: Fri, 30 Jan 2026 19:52:15 +0100 Message-ID: <20260130185219.206910-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185219.206910-1-lukagejak5@gmail.com> References: <20260130185219.206910-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lukagejak5[at]gmail.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength = initial_out_len; - if (in_ie[i] == 0xDD && in_ie[i+2] == 0x00 && in_ie[i+3] == 0x50 && in_ie[i+4] == 0xF2 && in_ie[i+5] == 0x02 && i+5 < in_len) { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] == 0xDD && in_ie[i + 2] == 0x00 && + in_ie[i + 3] == 0x50 && in_ie[i + 4] == 0xF2 && + in_ie[i + 5] == 0x02) { for (j = i; j < i + 9; j++) { out_ie[ielength] = in_ie[j]; ielength++; -- 2.52.0 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id KKYWESX+fGlRQAQAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:53:25 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:53:25 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vltcS-00000003A4Y-3JNy for hi@josie.lol; Fri, 30 Jan 2026 18:53:25 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 2175F3007E1F for ; Fri, 30 Jan 2026 18:53:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 97B9836A030; Fri, 30 Jan 2026 18:53:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R5jD6lun" X-Original-To: stable@vger.kernel.org Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2325D369975 for ; Fri, 30 Jan 2026 18:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799203; cv=none; b=jBDy6RjXnsjhhGDFrgI5fEiCM3RMUl/VZZzChHBLUaqYIrGXJyg/KoTWskxWsJKrZ9qPAx2yxupb3oejZFUzGUVtxsI2Vytu0f5bhX86ceM9yJg+pLE96Y4lyxaIWku5E0Rxlh7RRIA1zfWTDjJ7maG4uuOkUWPwB9cjGsh4qAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799203; c=relaxed/simple; bh=54jF80axLN2UJAh0SY0zu8J2BqHK+0mKcS7a+qODr54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TUY8sCjY5CCI/rMFtnsnXrM1Xyb5vkbQvm/2K8a7gUEf/R+UOETVs79/DyObT8B4EPwzAcnQad8zvUQj47HQk5oP9zfUsVJW0/qn+enfmn+/1l4q4l+mfINp0LvE0CDxQNH9Zu7vkLxJw/v8sRvOLjUqY1fz2UKUSH7iLjNhGtA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R5jD6lun; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-432d2670932so2323926f8f.2 for ; Fri, 30 Jan 2026 10:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799200; x=1770404000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=R5jD6lunnQyUEOnslIKzYTP98T6ee9FQW9WuiqZbCBOPrJ674fcC4yVGsdL8v9ho9M 4dEGXZ3r+ZPu5L1kOFmZgx13ftBQQYyh9OPcTD/hjQjARSNaXdDSQRgd4Iilo6Hrvc+e FL2NYPfXcomWhuBz2YqmNlIoTausmMpqIQ8EwvTXGGN0Bw2PBA00fVcgdMCpJp8uh3yk l/T9QeaBS+dM0GjEJD6yu3PTynhLIbtV4xfEA+QRw56/Dh44ZUpFMbtxq/DkBXQNXGn6 L2fMQZlQOyD7/O/3BqYlDYwWN0iiUBgExlVjLhzDJcD4z+tSojmyLmgs6vagYxICT+Rc U/nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799200; x=1770404000; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=rWOFV1eH1zo96Z+eTmXtA13M1LFw13sHbTzuKBWpGpf07e8mOJwfeCBNPr5ev859D6 plZYRZcfiNuJ8PO+Hra6FsUeFm0tdJMEFf1uA4RS1G14Cn3fU9WDDnzS/Q+THKfWdkHA 3tIRRzCB3AA4Qiasf6v/dQSbmNOiLn7jAtkZq09ZgKVFeusbzdjMtcceo02TtKEfJ5si LbmDvJM46qOaLeDIN3XWBBRoiYlJNBgNyJdKWUaxUQXtCzajJzvvxoLCvG2ab567LJ1u FhoNRN1SAesa9IDQ3Ab4khNrqn+ljVpH5tSIHnxiMMa5GapEl+AMMa7vg38E7y4wXo4i pZ+Q== X-Gm-Message-State: AOJu0YyDeozVsoJDrBB9UB0mdJHrdDJVPEr3igtNtxYS3MiDzgZyJBA7 QXk+E98VQu0Q0zP4WzGz9m3/souwyD087xlxpfM5EI5z+gE7S9VnSDPxWGdPhoQ= X-Gm-Gg: AZuq6aIN5Kjtr0wyxpv1K8bqnbmaqWEBMziAoxk0uy7tHJSIIQjgJ8WcZQay/IB+Dis /4ZxOWFsFwviul8T/Uzu2h8M/A4dHlGxYzbyvcKvtFJJ184jmCOj+Vu1PudPCRvc1jO/if5mxEI 5aeNz68AipVJ9BeL+oJ/0k4hY5mnaanCwvYv2FwqhuFTJ/HF5rDN82bwsR1FLRwDNRuKEftpGdk m8aM07NIqMgy6ebJb88P/OWPL46M14XWdMISPaT314PQwe+0ZrPh0Xhcu6e5H6p4O6SmkxcKZC/ ZUaT3zMxk1zEk8oP+mYfVH2W1Rsoi0ifvKD5cdICuiTDq3QH8DnJX/Ly0dTRL7DBRrCbaaIQtOj ymKFV5QjU6ZyvdCxB7mV8Ggl3K0KeMpCtPHB7ZPiFiz2d2egV9tRKtClHtulIRfNzBRvTGbUYZV p6swa3I4x7qmhSGluTSr+ONRV7FvT/gJVOsCADp8tjnGpjV3Qrac/XZgFwJvWR1w== X-Received: by 2002:a5d:64c9:0:b0:435:a0ff:a732 with SMTP id ffacd0b85a97d-435f3aaf7e4mr5866774f8f.50.1769799200199; Fri, 30 Jan 2026 10:53:20 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edf62sm26448652f8f.13.2026.01.30.10.53.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:53:19 -0800 (PST) From: Luka Gejak To: lukagejak5@gmail.com Cc: stable@vger.kernel.org Subject: [PATCH v6 1/5] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie Date: Fri, 30 Jan 2026 19:52:46 +0100 Message-ID: <20260130185250.207064-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185250.207064-1-lukagejak5@gmail.com> References: <20260130185250.207064-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 3.4 (+++) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (3.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lukagejak5[at]gmail.com] 3.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 34 The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength = initial_out_len; - if (in_ie[i] == 0xDD && in_ie[i+2] == 0x00 && in_ie[i+3] == 0x50 && in_ie[i+4] == 0xF2 && in_ie[i+5] == 0x02 && i+5 < in_len) { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] == 0xDD && in_ie[i + 2] == 0x00 && + in_ie[i + 3] == 0x50 && in_ie[i + 4] == 0xF2 && + in_ie[i + 5] == 0x02) { for (j = i; j < i + 9; j++) { out_ie[ielength] = in_ie[j]; ielength++; -- 2.52.0 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id uGvGBjL/fGmGhQsAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 18:57:54 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 18:57:54 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vltgn-00000003ISJ-3XCa for hi@josie.lol; Fri, 30 Jan 2026 18:57:54 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 9D8073013A56 for ; Fri, 30 Jan 2026 18:57:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0FC9237E300; Fri, 30 Jan 2026 18:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EGg129+g" X-Original-To: stable@vger.kernel.org Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69CE234B19A for ; Fri, 30 Jan 2026 18:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799456; cv=none; b=khse1Q+Nunnw6svewHQx5/9cZf8ODrZUyQwgmvmuyMaMjT7OTIaUoAL6MSXAV4eEjhwRN7BgqhM3O6LKQymwrF8nG6K7PSc06c+ulFdXzxwQHbaW6MEduWorxJkJiuahtVkxTPqySDAEElts6OS7NAqdb4Ctp3D6Ksu03HZTL6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769799456; c=relaxed/simple; bh=54jF80axLN2UJAh0SY0zu8J2BqHK+0mKcS7a+qODr54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tkp3NgcloW8Bbt19dwBdRzC7GYX9CGZx6pQBjA02/xYj6GS3bIj/IvbL7MopKIFgvJmDg22+ivIlfbKzYMoN/Az1aYBQ7HLwXrCWb9nX9aFh6CcRk8Xhl25Lt8Qgd22ckqOO2xviAN1T+pbP2yv8l+RdYAvTQ1ebAUCpxjvZ8GU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EGg129+g; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-432755545fcso1657109f8f.1 for ; Fri, 30 Jan 2026 10:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769799453; x=1770404253; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=EGg129+gaCIw5YZ2hFewK7PC5nvYslLDZjLVDYQfJJpfSjne+MATYsP6l4twJZA7xx W54CTZumHyp/dgu9PdJ6x4P5GwbJpAivcFv2/ajfuM3Ogf4AKulu9i9IC4CnPz0tP7ar ZRseyYd6t4kALb/7fJBULtXLxVexpHtWZJ+dX9jwe0ki4/9XdHTD1pn7V0mLB9o1wXyv 0L7H/0sIi2uXNcDIQBqx+SUSp8hnlDfCmBKNzoha5gSgEh68SU+oTTKMl2pzBMO8du/4 n0kxX+kO1AQldTVpRQem551wanPac+ao4EdjlEUWLKh78C9VJwHKr6luYsi7IFZjB7W5 +lHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769799453; x=1770404253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=r675n2qb2biVxGDZmz9LSBKzxleJ7rz9yuYXdSe+ZK9T3ichO4v0ufKkL2asFbPehc 9xAdsY0u8uQSIggn53Hm1H5Y2p33MJul5n0wpG2WbObaGRpYoiPEx1jj0uUehywweSeM gbc5v6IVbRMDTnez132urOw4PJLuLMLAfR5NnPgzp//tZAM+y2egMJuoPTufoW88EETE dQh/GqFXBMtBYTt3N4M8FBsHTVRcwtcnDdcll9NLYBWAbVbsSo2zaJlxpLsw3kNq6lON b8BXGC2pG6gvuKY0GAGEIf1t2VezO77OpWVTQmKjjREWBoi5PVJOf4Ctz5RAVee/pO1a gsCg== X-Forwarded-Encrypted: i=1; AJvYcCVzZD8Wu38mZfHh8KfbbQaEQ+GZyTdK+tMn+UD/x/rsUez4B+zDFSEdKXVqdvWYaJuyPG3vnVM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1BIUBNDCQDWEH0nVX9iBL8hNtp5HEpayVX8xxSl718AMepXPj ugTpNc646Ws7kSNMn3iUXX7jAs6/koTp80rFVpTvklMh6vC6xO1XrPk= X-Gm-Gg: AZuq6aKyLsPTvWFdLRbp0xUQLCy6S4vk3j1uv6umgOuUFjFE90VW+PyjKAvedjotESo em5bHHXjvr1vokIOcY9TnTTYh8i3ZW0j0xtu902T20odqwmu0HqlQwcc0yWTP2ec3nno5vK+F7i O+eyCAEaZ3w841+TALBoyq0M5TgcKpVbNDNOeWuRQ0iqXg2KrKOrY7b3dMM5BqsAqETJJhzCmZX VxgsaTX7MegpNhd+42ghymlDtLvl+qBZGaaCA+19Bj5RL1h7WHKVv/gXk6DdL9dVx1qUPSTXAel F8VRa4YKzjadzjEa/XhWSmkdVXVGDEPR77bJK6iYeELmqIOHRm6WbdM9W3DOb2xFaXmTDAaKgiE UP434k7oPGxIye0aZC7Z/aBqWwBEhnWmcsvj1lv3+Ykb39/fygsjBzuBNyIs/z2wQD4YHN6R/D7 wefM7E+GZVlJ6nSwfBh/aGzcXhWQV5msIAXCut+veLnr+TpYVcCtX6kZjCSgpqdw== X-Received: by 2002:a05:6000:420d:b0:435:960c:5286 with SMTP id ffacd0b85a97d-435f3aba816mr6032365f8f.58.1769799452718; Fri, 30 Jan 2026 10:57:32 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edf62sm26474164f8f.13.2026.01.30.10.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:57:32 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak , stable@vger.kernel.org Subject: [PATCH v6 1/5] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie Date: Fri, 30 Jan 2026 19:56:54 +0100 Message-ID: <20260130185658.207785-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130185658.207785-1-lukagejak5@gmail.com> References: <20260130185658.207785-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lukagejak5[at]gmail.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength = initial_out_len; - if (in_ie[i] == 0xDD && in_ie[i+2] == 0x00 && in_ie[i+3] == 0x50 && in_ie[i+4] == 0xF2 && in_ie[i+5] == 0x02 && i+5 < in_len) { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] == 0xDD && in_ie[i + 2] == 0x00 && + in_ie[i + 3] == 0x50 && in_ie[i + 4] == 0xF2 && + in_ie[i + 5] == 0x02) { for (j = i; j < i + 9; j++) { out_ie[ielength] = in_ie[j]; ielength++; -- 2.52.0 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 8PMPB4sGfWlRzwoAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 19:29:15 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 19:29:15 +0000 Received: from sto.lore.kernel.org ([172.232.135.74]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vluB8-00000004GiS-2AJt for hi@josie.lol; Fri, 30 Jan 2026 19:29:15 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id EC3D030054DC for ; Fri, 30 Jan 2026 19:29:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9BD8D38885F; Fri, 30 Jan 2026 19:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DKIOiVmF" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36D22388847 for ; Fri, 30 Jan 2026 19:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769801351; cv=none; b=FINMjbzlwzpd9MiQ/eofT3ep8GXUuGJIVi6Uuq5U0pp/hJLpoF9Jz+UTsb55br6lz3usYOGqpK1LaIoUdq2oKOWX5XsMwitzZNYNkHfcBPHUK4w6CveR3Y1JG0SlmRfd4IxfZGwiERmktnEZZZ3xPHgZzKkqYpNo4qLFU/SWxrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769801351; c=relaxed/simple; bh=WzeItp1DRTUqKp/9e7w6c4g+FgDenYMP0iSbO1++jDM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=PRBqmQEb/uDPXNQFOAdaaEYjzQUoRfoZolggG6iTnAFfaaeL1J16byAXf/A1ImS9oP8CwMYS/J4v49p7kj9Mbl27sh86tOjQzwLvVygxzmBu1kMCrfbWcisGypmZpoWUd3v1tn0fndMuK7nWKO3ym8MoDljlL6oEQATWXaL9eIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DKIOiVmF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC9C3C4CEF7 for ; Fri, 30 Jan 2026 19:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769801350; bh=WzeItp1DRTUqKp/9e7w6c4g+FgDenYMP0iSbO1++jDM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DKIOiVmF1iy5DeHhlh3x6VxORiXn/ikYNS5cUAhTgThS/PxBeaTdSdmskvpoMag1M BzclYUsHaccqu3dWKquhe78+xt4cAcCQHk4Yx7DigdJMH+KrfDLBfCqQHa8rQSuuZs 4OJizIfUAqcAOiFnqk6EZolDbUu95fE8IJ5BpJNsaGeQta9cCRygtUTm9eV/Xfn+N/ j5ql8AKdf8BNo1sr277PYAcVBPBNn4NFy7RGISnxAsGkS1rlDtfJR/N6CsuJS6QVQf pa1q8cPSpljPFaiG3G+d2sZAb3jufMP9NqmDgNa9pesCQF0Fn5dnt6JdZLE4cSl2OH H0Xcw4hpLv0hA== Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-6610b05b37dso1953353eaf.2 for ; Fri, 30 Jan 2026 11:29:10 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV6kNXqbF9XZcbDhWp3IQbjzalZxWJZDACC8ujsocRFAYprH9VvcnR3thuWjKoHtgTHLqY0iME=@vger.kernel.org X-Gm-Message-State: AOJu0YymjEckOvLQzvzp15CglyH3uWn3ng3e17wcPNDFxtNtmRjnJJip GDNVx+KuVgZlSS/CiDOkjAs0613bOdxTBrERiWMkDxdBuqgWQiuadUjC3Cg+5hIEOGQMSQDcpMT 1+nadtHKUKhemfjNsE49cj61ONhfEWjE= X-Received: by 2002:a05:6820:1f05:b0:663:23a:caf4 with SMTP id 006d021491bc7-6630f0317cfmr1690473eaf.2.1769801349722; Fri, 30 Jan 2026 11:29:09 -0800 (PST) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <39c7d882-6711-4178-bce6-c1e4fc909b84@arm.com> <005401dc64a4$75f1d770$61d58650$@telus.net> <6347bf83-545b-4e85-a5af-1d0c7ea24844@arm.com> <849ee0ff-e15b-4b69-84de-6503e3b3168d@oracle.com> <003e01dc9013$e3bc5060$ab34f120$@telus.net> <004e01dc90b1$4b28f9e0$e17aeda0$@telus.net> <002601dc916e$6acbe650$4063b2f0$@telus.net> In-Reply-To: <002601dc916e$6acbe650$4063b2f0$@telus.net> From: "Rafael J. Wysocki" Date: Fri, 30 Jan 2026 20:28:57 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_Qi4PUwPqvSQzVb5jeIQp7G5TA3-oxr-HbTXhdXTmf3v7XpGoaPT3LFf4ZQ Message-ID: Subject: Re: Performance regressions introduced via Revert "cpuidle: menu: Avoid discarding useful information" on 5.15 LTS To: Doug Smythies , Christian Loehle Cc: Harshvardhan Jha , Sasha Levin , Greg Kroah-Hartman , linux-pm@vger.kernel.org, stable@vger.kernel.org, "Rafael J. Wysocki" , Daniel Lezcano Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: urldefense.com] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.232.135.74 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 On Thu, Jan 29, 2026 at 11:27=E2=80=AFPM Doug Smythies wrote: > > On 2026.01.28 15:53 Doug Smythies wrote: > > On 2026.01.27 21:07 Doug Smythies wrote: > >> On 2026.01.27 07:45 Harshvardhan Jha wrote: > >>> On 08/12/25 6:17 PM, Christian Loehle wrote: > >>>> On 12/8/25 11:33, Harshvardhan Jha wrote: > >>>>> On 04/12/25 4:00 AM, Doug Smythies wrote: > >>>>>> On 2025.12.03 08:45 Christian Loehle wrote: > >>>>>>> On 12/3/25 16:18, Harshvardhan Jha wrote: > > ... snip ... > > > >>>> It would be nice to get the idle states here, ideally how the states= ' usage changed > >>>> from base to revert. > >>>> The mentioned thread did this and should show how it can be done, bu= t a dump of > >>>> cat /sys/devices/system/cpu/cpu*/cpuidle/state*/* > >>>> before and after the workload is usually fine to work with: > >>>> https://urldefense.com/v3/__https://lore.kernel.org/linux-pm/8da4238= 6-282e-4f97-af93-4715ae206361@arm.com/__;!!ACWV5N9M2RV99hQ!PEhkFcO7emFLMaNx= WEoE2Gtnw3zSkpghP17iuEvZM3W6KUpmkbgKw_tr91FwGfpzm4oA5f7c5sz8PkYvKiEVwI_iLIP= pMt53$ > > > >>> Apologies for the late reply, I'm attaching a tar ball which has the = cpu > >>> states for the test suites before and after tests. The folders with t= he > >>> name of the test contain two folders good-kernel and bad-kernel > >>> containing two files having the before and after states. Please note > >>> that different machines were used for different test suites due to > >>> compatibility reasons. The jbb test was run using containers. > > > > Please provide the results of the test runs that were done for > > the supplied before and after idle data. > > In particular, what is the "fio" test and it results. Its idle data is = not very revealing. > > Is it a test I can run on my test computer? > > I see that I have fio installed on my test computer. > > >> It is a considerable amount of work to manually extract and summarize = the data. > >> I have only done it for the phoronix-sqlite data. > > > > I have done the rest now, see below. > > I have also attached the results, in case the formatting gets screwed u= p. > > > >> There seems to be 40 CPUs, 5 idle states, with idle state 3 defaulting= to disabled. > >> I remember seeing a Linux-pm email about why but couldn't find it just= now. > >> Summary (also attached as a PNG file, in case the formatting gets mess= ed up): > >> The total idle entries (usage) and time seem low to me, which is why = the ???. > >> > >> phoronix-sqlite > >> Good Kernel: Time between samples 4 seconds (estimated and ???) > >> Usage Above Below Above Below > >> state 0 220 0 218 0.00% 99.09% > >> state 1 70212 5213 34602 7.42% 49.28% > >> state 2 30273 5237 1806 17.30% 5.97% > >> state 3 0 0 0 0.00% 0.00% > >> state 4 11824 2120 0 17.93% 0.00% > >> > >> total 112529 12570 36626 43.72% <<< Misses % > >> > >> Bad Kernel: Time between samples 3.8 seconds (estimated and ???) > >> Usage Above Below Above Below > >> state 0 262 0 260 0.00% 99.24% > >> state 1 62751 3985 35588 6.35% 56.71% > >> state 2 24941 7896 1433 31.66% 5.75% > >> state 3 0 0 0 0.00% 0.00% > >> state 4 24489 11543 0 47.14% 0.00% > >> > >> total 112443 23424 37281 53.99% <<< Misses % > >> > >> Observe 2X use of idle state 4 for the "Bad Kernel" > >> > >> I have a template now, and can summarize the other 40 CPU data > >> faster, but I would have to rework the template for the 56 CPU data, > >> and is it a 64 CPU data set at 4 idle states per CPU? > > > > jbb: 40 CPU's; 5 idle states, with idle state 3 defaulting to disabled. > > POLL, C1, C1E, C3 (disabled), C6 > > > > Good Kernel: Time between samples > 2 hours (estimated) > > Usage Above Below Above Below > > state 0 297550 0 296084 0.00% 9= 9.51% > > state 1 8062854 341043 4962635 4.23% 61.55% > > state 2 56708358 12688379 6252051 22.37% 11.02% > > state 3 0 0 0 0.00% 0= .00% > > state 4 54624476 15868752 0 29.05% 0= .00% > > > > total 119693238 28898174 11510770 33.76% <<< Misse= s > > > > Bad Kernel: Time between samples > 2 hours (estimated) > > Usage Above Below Above Below > > state 0 90715 0 75134 0.00% 8= 2.82% > > state 1 8878738 312970 6082180 3.52% 68.50% > > state 2 12048728 2576251 603316 21.38% 5.01% > > state 3 0 0 0 0.00% 0= .00% > > state 4 85999424 44723273 0 52.00% 0= .00% > > > > total 107017605 47612494 6760630 50.81% <<< Misses > > > > As with the previous test, observe 1.6X use of idle state 4 for the "Ba= d Kernel" > > > > fio: 64 CPUs; 4 idle states; POLL, C1, C1E, C6. > > > > fio > > Good Kernel: Time between samples ~ 1 minute (estimated) > > Usage Above Below Above Below > > state 0 3822 0 3818 0.00% 99.90% > > state 1 148640 4406 68956 2.96% 46.39% > > state 2 593455 45344 105675 7.64% 17.81% > > state 3 3209648 807014 0 25.14% 0.00% > > > > total 3955565 856764 178449 26.17% <<< Misses > > > > Bad Kernel: Time between samples ~ 1 minute (estimated) > > Usage Above Below Above Below > > state 0 916 0 756 0.00% 82.53% > > state 1 80230 2028 42791 2.53% 53.34% > > state 2 59231 6888 6791 11.63% 11.47% > > state 3 2455784 564797 0 23.00% 0.00% > > > > total 2596161 573713 50338 24.04% <<< Misses > > > > It is not clear why the number of idle entries differs so much > > between the tests, but there is a bit of a different distribution > > of the workload among the CPUs. > > > > rds-stress: 56 CPUs; 5 idle states, with idle state 3 defaulting to dis= abled. > > POLL, C1, C1E, C3 (disabled), C6 > > > > rds-stress-test > > Good Kernel: Time between samples ~70 Seconds (estimated) > > Usage Above Below Above Below > > state 0 1561 0 1435 0.00% 91.93% > > state 1 13855 899 2410 6.49% 17.39% > > state 2 467998 139254 23679 29.76% 5.06% > > state 3 0 0 0 0.00% 0.00% > > state 4 213132 107417 0 50.40% 0.00% > > > > total 696546 247570 27524 39.49% <<< Misses > > > > Bad Kernel: Time between samples ~ 70 Seconds (estimated) > > Usage Above Below Above Below > > state 0 231 0 231 0.00% 100.00% > > state 1 5413 266 1186 4.91% 21.91% > > state 2 54365 719 3789 1.32% 6.97% > > state 3 0 0 0 0.00% 0.00% > > state 4 267055 148327 0 55.54% 0.00% > > > > total 327064 149312 5206 47.24% <<< Misses > > > > Again, differing numbers of idle entries between tests. > > This time the load distribution between CPUs is more > > obvious. In the "Bad" case most work is done on 2 or 3 CPU's. > > In the "Good" case the work is distributed over more CPUs. > > I assume without proof, that the scheduler is deciding not to migrate > > the next bit of work to another CPU in the one case verses the other. > > The above is incorrect. The CPUs involved between the "Good" > and "Bad" tests are very similar, mainly 2 CPUs with a little of > a 3rd and 4th. See the attached graph for more detail / clarity. > > All of the tests show higher usage of shallower idle states with > the "Good" verses the "Bad", which was the expectation of the > original patch, as has been mentioned a few times in the emails. > > My input is to revert the reversion. OK, noted, thanks! Christian, what do you think? From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id uJVSLfoMfWkPaRIAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 19:56:42 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 19:56:42 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlubh-00000005669-3mEY for hi@josie.lol; Fri, 30 Jan 2026 19:56:42 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 8FE883017793 for ; Fri, 30 Jan 2026 19:56:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E42682E0400; Fri, 30 Jan 2026 19:56:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eEFvxzVP" X-Original-To: stable@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC79E224AE0 for ; Fri, 30 Jan 2026 19:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769802998; cv=none; b=LyieNgCjE7VrtK53Odv4mWJxgvIg3wvZFfnWpM/fD1nVvPGUR7Vp2yVPPQCLRrQuH2CTNrYujILkXQfAu6gOABLRA9QCl5BOva3xZvkL6ZP8hmRbBcR204B5NkbcHdiu3qRFOampxp8hl2Nx0mZY/MaTEJfI88n3Z++z9+5gaYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769802998; c=relaxed/simple; bh=worejeHHsq1ziRWfoviB7RGwOnlqO7vcDzzLdGwlVXo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=gyW88S37FqHG9V0wn35Zg+HaBuP8REYhvP1HETpJGHnWsDv3KSKqsfZL3u5RYRnp2QpnfEAwMKsn+hin7GpKZEgIGhW3ElN6vEH+NrqWKVlV/DVjpzj7kZMm4K9nRPK+Tkm18an2v8p7asN2qND7va/mgif9o653tSW2h9V04MA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eEFvxzVP; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769802997; x=1801338997; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=worejeHHsq1ziRWfoviB7RGwOnlqO7vcDzzLdGwlVXo=; b=eEFvxzVP5oCUpmlFwep7mf7IGCEVFJkTSXZ0kqJ592SDNnbVBc9wX+cF MXOzibCPs0PXMlMxE1D24JfsUwZRBNaeAn2E58QPtrOdgTgjp7g2UyBtk kHRopSJn+o4eG5vXUbJb1Iacvabc661vrtDu2RyWahI2luiBBNWFerqov ErOKvtnv08WAO7Cp54/Er4YQh1kzA4jaFwTqazWY1CUHm58sxg+btHOR/ OtwgQeE0TdCyISOn8S2pkEk1JbRuxGF8BP/FBwCfCD4YxGIZHoEHhSP8o Sgte8FauKoEKhCjKz83l8safgBufZU0aQyfs5WS2G8nBJug+HBsuugDVi Q==; X-CSE-ConnectionGUID: vl+H0ifMTqqJ+6CfS6g32g== X-CSE-MsgGUID: iSLuD9KIQ3ewaPZtmFeRSg== X-IronPort-AV: E=McAfee;i="6800,10657,11687"; a="70776042" X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="70776042" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 11:56:37 -0800 X-CSE-ConnectionGUID: nM5QeG7ATpaADUZTOayMgQ== X-CSE-MsgGUID: 9tIorAgaQku43phLFmJqtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="208735691" Received: from rvuia-mobl.ger.corp.intel.com (HELO [10.245.244.13]) ([10.245.244.13]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 11:56:33 -0800 Message-ID: Subject: Re: [PATCH] mm/hmm: Fix a hmm_range_fault() livelock / starvation problem From: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= To: Andrew Morton Cc: intel-xe@lists.freedesktop.org, Ralph Campbell , Christoph Hellwig , Jason Gunthorpe , Jason Gunthorpe , Leon Romanovsky , Matthew Brost , linux-mm@kvack.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org Date: Fri, 30 Jan 2026 20:56:31 +0100 In-Reply-To: <20260130100013.fb1ce1cd5bd7a440087c7b37@linux-foundation.org> References: <20260130144529.79909-1-thomas.hellstrom@linux.intel.com> <20260130100013.fb1ce1cd5bd7a440087c7b37@linux-foundation.org> Organization: Intel Sweden AB, Registration Number: 556189-6027 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-DKIM: signer='intel.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-DKIM: signer='@intel.com' status='pass' reason='' X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 5 On Fri, 2026-01-30 at 10:00 -0800, Andrew Morton wrote: > On Fri, 30 Jan 2026 15:45:29 +0100 Thomas Hellstr=C3=B6m > wrote: >=20 > > If hmm_range_fault() fails a folio_trylock() in do_swap_page, > > trying to acquire the lock of a device-private folio for migration, > > to ram, the function will spin until it succeeds grabbing the lock. > >=20 > > However, if the process holding the lock is depending on a work > > item to be completed, which is scheduled on the same CPU as the > > spinning hmm_range_fault(), that work item might be starved and > > we end up in a livelock / starvation situation which is never > > resolved. > >=20 > > This can happen, for example if the process holding the > > device-private folio lock is stuck in > > =C2=A0=C2=A0 migrate_device_unmap()->lru_add_drain_all() > > The lru_add_drain_all() function requires a short work-item > > to be run on all online cpus to complete. >=20 > This is pretty bad behavior from lru_add_drain_all(). >=20 > > A prerequisite for this to happen is: > > a) Both zone device and system memory folios are considered in > > =C2=A0=C2=A0 migrate_device_unmap(), so that there is a reason to call > > =C2=A0=C2=A0 lru_add_drain_all() for a system memory folio while a > > =C2=A0=C2=A0 folio lock is held on a zone device folio. > > b) The zone device folio has an initial mapcount > 1 which causes > > =C2=A0=C2=A0 at least one migration PTE entry insertion to be deferred = to > > =C2=A0=C2=A0 try_to_migrate(), which can happen after the call to > > =C2=A0=C2=A0 lru_add_drain_all(). > > c) No or voluntary only preemption. > >=20 > > This all seems pretty unlikely to happen, but indeed is hit by > > the "xe_exec_system_allocator" igt test. > >=20 > > Resolve this using a cond_resched() after each iteration in > > hmm_range_fault(). Future code improvements might consider moving > > the lru_add_drain_all() call in migrate_device_unmap() out of the > > folio locked region. > >=20 > > Also, hmm_range_fault() can be a very long-running function > > so a cond_resched() at the end of each iteration can be > > motivated even in the absence of an -EBUSY. > >=20 > > Fixes: d28c2c9a4877 ("mm/hmm: make full use of walk_page_range()") >=20 > Six years ago. Yeah, although unlikely to have been hit due to our multi-device migration code might have been the first instance of all those prerequisites to be fulfilled. >=20 > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -674,6 +674,13 @@ int hmm_range_fault(struct hmm_range *range) > > =C2=A0 return -EBUSY; > > =C2=A0 ret =3D walk_page_range(mm, hmm_vma_walk.last, > > range->end, > > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &hmm_walk_ops, > > &hmm_vma_walk); > > + /* > > + * Conditionally reschedule to let other work > > items get > > + * a chance to unlock device-private pages whose > > locks > > + * we're spinning on. > > + */ > > + cond_resched(); > > + > > =C2=A0 /* > > =C2=A0 * When -EBUSY is returned the loop restarts with > > =C2=A0 * hmm_vma_walk.last set to an address that has > > not been stored >=20 > If the process which is running hmm_range_fault() has > SCHED_FIFO/SHCED_RR then cond_resched() doesn't work.=C2=A0 An explicit > msleep() would be better? Unfortunately hmm_range_fault() is typically called from a gpu pagefault handler and it's crucial to get the gpu up and running again as fast as possible. Is there a way we could test for the cases where cond_resched() doesn't work and in that case instead call sched_yield(), at least on -EBUSY errors? Thanks, Thomas From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id OHzSKF4RfWlb5RIAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 20:15:26 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 20:15:26 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlutq-00000005etZ-1vvW for hi@josie.lol; Fri, 30 Jan 2026 20:15:26 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 938483025A4F for ; Fri, 30 Jan 2026 20:15:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B48FE2FC00D; Fri, 30 Jan 2026 20:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QXRR1P1e" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF552F83A1 for ; Fri, 30 Jan 2026 20:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769804124; cv=none; b=Nn2dSfESyCtF7gVpjGbspNbm2MjrraxZuTaxroKkh+5jD32ryPey+JtHWYveshkyL0sr/WF7YtFaleNkhtO7vs484hXH/Y8BZZNM4atRrP2Gva5gPQ1psSPegtwyKYAW1L9s78EZcmJ7dq4Oee3fj6Aqb2Ico19ABi5DB0BzNYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769804124; c=relaxed/simple; bh=rDxpBa2wQbBmAcOx3wZdYI5yW3Gufe5SwgazwffXj5A=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=MQOqIR63F1dd8bYDp+WWtIsHUM90aZDPHEY9EvFdtqpPlYvItJZMyGRaWs90iAIG+3DXZDZuHRpHvz4AbMXLV4EDn1qgX5C2RmeXYsiN5FQrtNmXer5TZfJG7VB9whtwTD/lCbIaUfec5m3AMd2hbwLNEcUQwDFsxNHpea5v19Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QXRR1P1e; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56E9DC2BC86 for ; Fri, 30 Jan 2026 20:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769804124; bh=rDxpBa2wQbBmAcOx3wZdYI5yW3Gufe5SwgazwffXj5A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QXRR1P1elSoPSRoPWCjHLjHHkt3Lgl/1Fr0Ot8ggOenQwvgbMoga9DVY88BTtJZy4 xyqVfIk96W1cuRDtQUbl3QxdNdjm7FwkRXbuIpdTC4JRgcghoYyzKSI02AGdplTFRY Z8LzJ1Ho/e+sJ0dJwEjHrG8M3ZZkF1G/jNF5E9N2oXJpKMMCMwh1SO3Xe7S/8ooLSY DNiJ5bX8XZcTNZfaWHv12IISR5vME3IgcbI8WIQLhBqRrn4N/8afBc8H9B8h77m68m OLgt1Qnxp1gJSlytXrsviS8umSML0FkbfCaXAZLSbSOLYsyE5vD9t65GUaFJk3fupd 0aBa4NkQlD4+Q== Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-385c23b88e8so23756231fa.3 for ; Fri, 30 Jan 2026 12:15:24 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUNA3zd+k9LQorKugX1bQiVtD2d2iPR6z4vkaBvdUF/widGPPk1+UM6nfrnCot6NuElTc2nUM0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7N/NGv3MjdOgf2hTdvZGrNFKlTUZtWZojCcYPxwLPv4yI2gvX ZMy/ZH5JVmOnX+9T6mfQuyN5YPtA1qIxge14rcI+d/dkhN4SYNwPuTl6yGXOkSCzuuLdTPOI5uS YB5LKbPKphsYH8GsrCcv7zpTgk3/1/1s= X-Received: by 2002:a05:651c:a0a:b0:383:5ea:e9c1 with SMTP id 38308e7fff4ca-386464e0997mr14206801fa.2.1769804123007; Fri, 30 Jan 2026 12:15:23 -0800 (PST) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260122-rust-analyzer-scripts-v1-1-ff6ba278170e@kernel.org> In-Reply-To: From: Tamir Duberstein Date: Fri, 30 Jan 2026 15:14:46 -0500 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_QhncK0We1zFUkHB-_4kfr0Qvxn-w4b_0QxwXlk2gLz6yBBl0VkZfg9wrck Message-ID: Subject: Re: [PATCH] scripts: generate_rust_analyzer.py: define scripts To: Miguel Ojeda Cc: Daniel Almeida , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Kees Cook , David Gow , Alex Gaynor , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Fiona Behrens Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 On Tue, Jan 27, 2026 at 12:07=E2=80=AFPM Tamir Duberstein wrote: > > On Tue, Jan 27, 2026 at 10:13=E2=80=AFAM Miguel Ojeda > wrote: > > > > On Tue, Jan 27, 2026 at 2:53=E2=80=AFPM Tamir Duberstein wrote: > > > > > > It depends on your perspective - I framed it as a fix of the commit > > > that added the first script because that script was added without RA > > > support. What do you think? > > > > Yeah, I see. > > > > So, on the implementation side, I don't think we expected scripts to > > work at all, which is why it sounds to me like a feature (neither the > > linked commit nor the one that added rust-analyzer overall support > > mentions it that I can see, though it doesn't say otherwise either). > > > > But perhaps someone out there expected it to actually work and thus > > may think of it as a fix. I don't recall someone asking for it, but I > > haven't checked. Perhaps someone would, when we use more and more Rust > > scripts. > > > > Now, for the backport part, according to the official rules, I think > > it wouldn't fit. But those rules are often relaxed and who knows what > > companies out there doing out-of-tree work on top of LTS kernels > > want... (Commits can be submitted there even if they are not fixes, by > > the way). > > Thanks for the context. In that case I'll keep it as a fix and take it > through rust-analyzer-next with the backport tags since I expect it to > apply cleanly. > > Cheers, > Tamir Applied to rust-analyzer-next. Thanks all! From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id GAFhCD0TfWl6gxQAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 20:23:25 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 20:23:25 +0000 Received: from sin.lore.kernel.org ([104.64.211.4]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlv1Y-00000005tke-2Dmw for hi@josie.lol; Fri, 30 Jan 2026 20:23:25 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sin.lore.kernel.org (Postfix) with ESMTP id C10FA300B8DF for ; Fri, 30 Jan 2026 20:23:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 36078369236; Fri, 30 Jan 2026 20:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SgqTgC83" X-Original-To: stable@vger.kernel.org Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5BC8350A33 for ; Fri, 30 Jan 2026 20:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.82.179 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769804586; cv=pass; b=m4izQ6gEGSVG0SIi2xqoHm+2/+MaFpj8G+8r2M7WtgKeZADxzz59mUDVgbFlDKRdYmlbjGLU5GC3e/WkV5bPYgYv5D5DMgHR848iuw/OOXrKnI2sSn/oi+gZJlqQcZXS1He3A8Fq0XgAX3E+ddyQB9gt9iHOR+PNX4CuKUBDoKE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769804586; c=relaxed/simple; bh=WMF789FgXx2e6Y4/vq27WMByX/ZrrFaKKZtWTYUTPEY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rOGNbSU2pH/eDE80SEB5fg5X5Y1XgVW/x/IX8KDVc/GWLD2NXZ2TZW2jiSMn87AuNQmq/Ux5zRCwLQOD7t4ldr0bPPI3X0rrtqd85yL1G1mlgjRzAO05NoBt00eb5O+bc2W+oD5jSMtmDAhiIA7HE7ie9HMCQ+Kld+VFJWGdVLc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SgqTgC83; arc=pass smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2b700c7d3c2so62284eec.2 for ; Fri, 30 Jan 2026 12:23:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769804584; cv=none; d=google.com; s=arc-20240605; b=i1wXBqzEgp/uzhVDrc7iDHU5JlsFfaCJeSsBJKDjFj1tUnMMHXnOhiiOyOb6k2/RgD qvACQaDOrgdAHlocWxASJqeurCSyIkH82zn8azH3w0LuZ5FZumFtizaXDhA3YH+w7fr3 b+eUU/O3n8yhLKMW6LLjb35J45BLD9GL07ZOADLgsm/QMlshHn+I9WE2tJYx2Vx+KR5b XdNzQn3jK4WynvOY9DWp+yV8s65g07KH4JS1onxT8kGEknNjkee2EG5AYESIP5d+AOd0 NJI8nwUXdXWLnlbI+iCJBb6rvUl0UtaBnmp96vDC0RpVFSdnP8Zy3BGpcL/xIdl2+Fqb Yomg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=WMF789FgXx2e6Y4/vq27WMByX/ZrrFaKKZtWTYUTPEY=; fh=J962H6tGRL3op3aDBzTELGas2o4DIXeslVjQ/3PhnWU=; b=Jc7JNKLFcZNrRwFfGoKuoxvTmV+Lp5xZrs7EdvtThJgu5lu/CORpt0hQj+F8m++l56 PuvZZSC4W2vZFaK9r1Yh0Uw1UxgQfRatSf6BUebmR4NkLLtPT/UknZahU1fOC9G/Nwef sDfIlP78Pxkj937pxd6y7h3ITpo5OHA35/XwmFc0r8PWlvicOZ4t2mpxyMqU4Wd+Eo9K 3xXfcZATvUCOWC878HJM1n+IOftUFmW0MMvGBNCyEGGmvKlaYu6xiWGjHbJqEwlNbQIA Q6BFQKm4xEqjnbh4v1t7Ldns7Pi998eJCLAYGM6ty7T2AwER+MccefIQ+oSq6Wdn84CA t9mw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769804584; x=1770409384; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WMF789FgXx2e6Y4/vq27WMByX/ZrrFaKKZtWTYUTPEY=; b=SgqTgC83O82fSspNQE1x4UziEWomgX33iHYCLE1hpgCaArkJ/phzbYBP3FxaYjwZoY Xw+eCFd55mEDjVISH5JchZo6ZjIEzDtmTYoIZL8dzdwGqyNGo1rTkL9IcZWj9zyrS121 fwovYTikQZEU0JjBTqB6H4qhWu+T9GfYMJwZaYxkkJB1dEqAvHFUQBAWJfUQG6BF+JWZ o8WqFiO0LjT1dUT3lBFvq4vYSOZWNu2rXPIBtr6nRjoWHay+Vp7SSTBw7TlXY9PhsIW2 Vjuj8a1hAUDYP9RB8hgGNhFTSMK3F3lylcjM36m5SfMxlzWDw9UoZNyUrdtHrWUzPFYq 6qrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769804584; x=1770409384; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WMF789FgXx2e6Y4/vq27WMByX/ZrrFaKKZtWTYUTPEY=; b=TkJm1XpsCkkBh8DVWsUK0olxSI1wp8474cABsEXgP6iUNSZvzox50aH7fgf5aaMvpp kcrU+gneVi47367qzKii3R31dbM6kMk77KDnTpEdJmxgYnngPui3/ayuWhgGYOsJyE84 +M4MtPURV93oWIc9M2BLhHiRdDcj8bAkisTu9/hohtI2KshJBdGOzhOUkavvYf59rVyl vNaGoSkbDFuxGaOJrALYD7iBydlnmrgVdToewBIO+VN9P0XnFL/Xx1mwUbbXqnkaNaMj jKD/0E9A51VMJGQTKEWTzocZTTXg23q66/L8vAEpiAO5kodI1Nl4jk3HUJ+RKmEituzK 6Yqg== X-Forwarded-Encrypted: i=1; AJvYcCUX4VgIhOaJYHdP4ZdEgdm7eUoX1K/KsHF9/5CwC7fqSjwhnxNWuxQ0eY3b3GAAJZv0dm7oVH4=@vger.kernel.org X-Gm-Message-State: AOJu0YyZ9Kq8VB8Apku8rH9cbTZac9L05BfmRQNg89iGFTEOfFXN1fvU HEtOCE/g4zAprDpfBAlXN4mWNq4Mq2eQV70USOIelu3E2AoWWkK8ZxN/uxzgxo84O3Hh1lRn8xB 6RtqInMPcyNkqTrVBHSDG9nHrctwclXQ= X-Gm-Gg: AZuq6aKRRmEgwLZt5KdU4lvs44FXtPjXYcxAJe61hshaOXZyshhfVGbqz6bmTeS04JM eAaJtdH2I3nqfhKegWnpqgV4JxZ9M5mnJJhXhj866hi9W/Q2Y2JgRtqszcvSUPw98pHFf5ceY9P GJ5nBo6ZvlufqNwk08AZBePyykpzWdaobWRpi4xP1k8eP9pAFjZtZCLwE6FM3lW/kkLNXUFKS7U XRotiZmRMCdYaCrlhKNOcyZTjLWkWqteFr6VCt95f56f1wZqSTt1ea3zDhR4o/A2r7RJKCXC6UW URhma6DFJHX60EgMxm77FPS4QQpFMDafeqbE+iQXrqgpt1T8MtN+CedCZxP4U17nb2hwzjqJsBu /5ATAWp5xcQCE X-Received: by 2002:a05:7300:6da6:b0:2b7:24fc:f639 with SMTP id 5a478bee46e88-2b7c866cfd2mr1123479eec.3.1769804583886; Fri, 30 Jan 2026 12:23:03 -0800 (PST) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260122-rust-analyzer-scripts-v1-1-ff6ba278170e@kernel.org> In-Reply-To: From: Miguel Ojeda Date: Fri, 30 Jan 2026 21:22:50 +0100 X-Gm-Features: AZwV_QgY2s756W2c2BeIdnOIPOU_dOHgt0R3PEDW_x6O8Bex19ls3-KPywJ22no Message-ID: Subject: Re: [PATCH] scripts: generate_rust_analyzer.py: define scripts To: Tamir Duberstein Cc: Daniel Almeida , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Kees Cook , David Gow , Alex Gaynor , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Fiona Behrens Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [miguel.ojeda.sandonis[at]gmail.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [104.64.211.4 listed in list.dnswl.org] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On Fri, Jan 30, 2026 at 9:15=E2=80=AFPM Tamir Duberstein wrote: > > Applied to rust-analyzer-next. Thanks all! Please see the other thread (and please reset the branch to e.g. v6.19-rc7 for now -- we should avoid giving linux-next unneeded conflicts). Cheers, Miguel From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id SAAVEe0TfWksKxMAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 20:26:21 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 20:26:21 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlv4O-00000005yu2-3kqm for hi@josie.lol; Fri, 30 Jan 2026 20:26:21 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 9156C30071CF for ; Fri, 30 Jan 2026 20:26:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A7DB234FF59; Fri, 30 Jan 2026 20:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TQMk6z1O" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84CBF33AD9F for ; Fri, 30 Jan 2026 20:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769804774; cv=none; b=NC7rauRzu4nBdp3Kn9ZQmwzZ2F/7KFTN1QbORv+/3n7iq+Z3W0PY2lrgU9WR6NwJvTwGEQumjrrwlKbeVzdHYAvuYoFQvdlTHNJdS0QDIVfRMi92XUTuu5R86XUZ0kDztoOr/VV1EHnSR9dT++wIQYm7++n9x1CKsSvzNeRNMCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769804774; c=relaxed/simple; bh=h5ewnyvlu0xsde8dH+kzKb4XaSR0fvFyJX/BP9nEfqA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=MEMkRsBf6O4pztgGMmx5KI61qUbT/fC3pCgJ8FawfHtVvOlUiKoIVwUQCZIhV4ZmMltxcSIs/TG955mtQUV5bMNB7L/Njs736Z2SJ1iIX9QK7vjOp37AUHPYylDKImAGeQ6sW3byke+I4E03S0I47PyTZpbHr4FRZtx/alVV8bI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TQMk6z1O; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46897C4AF11 for ; Fri, 30 Jan 2026 20:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769804774; bh=h5ewnyvlu0xsde8dH+kzKb4XaSR0fvFyJX/BP9nEfqA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TQMk6z1OIwulNZhMPl9bEDldBgeMbhYaWhUQrD6wtJgjyvKbrrY6jFKW0HNq3d0PF iAO6Ngt4LIA/60zH3UZ9UY327PJX0qfGgmdZFc5z/QFVbnEBLg0Ao1LDAkyaA3fsQK Fj5GfGJNE32NRB3mCs1zKwyKajA+ZZoxhlG5AC4GIwd6SoSlfhyJt2FPqcda5oB5qS RAMtJV/ocerj75Nj2Fiui/6u07yjbyP7XghbMvM0hw+uEMt7bb/yY5aQ7epDmvDcde CimZLw5dkF/i2TjxwJ12eC+sEn3QRe2hTw6OAQq9TON5z/QJZVW1QftbScH1U/uq1m 1fq45O9Jxpk4Q== Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-385cfc572f1so26106411fa.3 for ; Fri, 30 Jan 2026 12:26:14 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVpFmxZ+/9ollyZ+ES0jMr+ZFX1IZg4uKdFeHoB/GR7zw4BVC0Gnna3cE5n942rZbxtZKuxfBA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxd+UPBZeJ2UVj/Tle/4MFqAIEXiMkYnKmMBgTxiwZtHGHVL+wG XIMWWNR6J88V/HfPbCFagPSsuLMFd1Tc8Y+7HsdXuDr58pWT93UmJ0TKk+CH1Ya+0emXaM86NfD 9mL+bdCj5mYeWWbjhAcef5hHfPprVd6Q= X-Received: by 2002:a05:651c:547:b0:383:f7:1057 with SMTP id 38308e7fff4ca-386466b3237mr14787081fa.44.1769804772887; Fri, 30 Jan 2026 12:26:12 -0800 (PST) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260122-rust-analyzer-scripts-v1-1-ff6ba278170e@kernel.org> In-Reply-To: From: Tamir Duberstein Date: Fri, 30 Jan 2026 15:25:36 -0500 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_QgBZ2E4czdZQN3pQDd7z8RjIjyj4ntoIpUiDXh9c7ieEVqekmu1Wm53-bg Message-ID: Subject: Re: [PATCH] scripts: generate_rust_analyzer.py: define scripts To: Miguel Ojeda Cc: Daniel Almeida , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Kees Cook , David Gow , Alex Gaynor , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Fiona Behrens Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 On Fri, Jan 30, 2026 at 3:23=E2=80=AFPM Miguel Ojeda wrote: > > On Fri, Jan 30, 2026 at 9:15=E2=80=AFPM Tamir Duberstein wrote: > > > > Applied to rust-analyzer-next. Thanks all! > > Please see the other thread (and please reset the branch to e.g. > v6.19-rc7 for now -- we should avoid giving linux-next unneeded > conflicts). Ack, done. From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id aLqvHoAVfWng9xUAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 20:33:04 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 20:33:04 +0000 Received: from sto.lore.kernel.org ([172.232.135.74]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlvAt-00000006BEL-2Olf for hi@josie.lol; Fri, 30 Jan 2026 20:33:04 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id 570873003D02 for ; Fri, 30 Jan 2026 20:33:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2C16E2E40B; Fri, 30 Jan 2026 20:33:00 +0000 (UTC) X-Original-To: stable@vger.kernel.org Received: from mail.auroraos.dev (unknown [95.181.193.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F150A2BE655 for ; Fri, 30 Jan 2026 20:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.181.193.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769805180; cv=none; b=Pmgx6K4WkIWcC5J0O+af9TXtavs7YcB5Q9SIMj8APu1VBCDJbXs7PihNYBP9n/Sa/GJEe0qPviOhY3xWshq1csGwsylR684kMtYTrK/wI0wDZIwBbF4qdpHEKOyUkUTBDy560ag2+D5PKvZ78u6WIzcP/KxGr6FGgFMo39wj9DI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769805180; c=relaxed/simple; bh=cvld//9d32K9+FdhPwx8FLT+VmMjtqqnDw60al3xPBo=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=W7bzbUBv0iS7zsqQRnlfoPvtoauUo7VPviEWskSyevqLHSgVVT8dnnGSv6dXZUErLRmwkFyetoVT2MSk96kweglVWQh1LY9p4jyHat4PW7z1LlgdDmo0jH898ST1YJ5lBDBxl8I9lvCDe6+23s34nGgvGoEjN97CD+bf8lRq5nA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=auroraos.dev; spf=pass smtp.mailfrom=auroraos.dev; arc=none smtp.client-ip=95.181.193.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=auroraos.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=auroraos.dev Received: from wasted (213.87.133.239) by exch16.corp.auroraos.dev (10.189.209.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Fri, 30 Jan 2026 23:32:46 +0300 From: Sergey Shtylyov To: Sandy Huang , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , , CC: Sergey Shtylyov , , Subject: [PATCH] drm/rockchip: cdn-dp: add missing check in cdn_dp_config_video() Date: Fri, 30 Jan 2026 23:31:46 +0300 Message-ID: <20260130203148.46473-1-s.shtylyov@auroraos.dev> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: exch16.corp.auroraos.dev (10.189.209.38) To exch16.corp.auroraos.dev (10.189.209.38) X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.232.135.74 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 The result of cdn_dp_reg_write() is checked everywhere (with the error being logged by the callers) except one place in cdn_dp_config_video(). Add the missing result check, bailing out early on error... Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Signed-off-by: Sergey Shtylyov Cc: stable@vger.kernel.org --- drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-reg.c b/drivers/gpu/drm/rockchip/cdn-dp-reg.c index 0dc3804051a9..9b82b27770e5 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-reg.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-reg.c @@ -685,6 +685,8 @@ int cdn_dp_config_video(struct cdn_dp_device *dp) val = div_u64(8 * (symbol + 1), bit_per_pix) - val; val += 2; ret = cdn_dp_reg_write(dp, DP_VC_TABLE(15), val); + if (ret) + goto err_config_video; switch (video->color_depth) { case 6: -- 2.52.0 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id aExPOCcWfWl+sw8AYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 20:35:51 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 20:35:52 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlvDb-00000006G2o-2mKA for hi@josie.lol; Fri, 30 Jan 2026 20:35:51 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id BC2D3300CFF0 for ; Fri, 30 Jan 2026 20:35:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 07DBC2FC006; Fri, 30 Jan 2026 20:35:50 +0000 (UTC) X-Original-To: stable@vger.kernel.org Received: from mail.auroraos.dev (unknown [95.181.193.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14D8A2737F2 for ; Fri, 30 Jan 2026 20:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.181.193.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769805349; cv=none; b=IRzAJxIFvPm5gvtURhx1y6GDIiLmk36dm2PXzAffHhkz1i6Ez4HA82AWspDKr2kr/QwxJWcbUapS9Guvy76Wtup3i81u/YCJtE/imVH4XoH95CN4wlCYhlVZN2n4inYM+5axlDEhygIfst5EfrmOii6s9feorgK8pGapzG/4D4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769805349; c=relaxed/simple; bh=5PgR9a7gQshAFgz923VVLXJuy/ZPO5RacgXLjzUn4hg=; h=Message-ID:Date:MIME-Version:From:Subject:To:CC:Content-Type; b=hd1m+/TqiT8HC4sVOsodqbRj2A3KEeO/cFu013SnPJltgyAiFilwkLM6gQkpOQTHkb/ZgFAjC2fXzJq7alntY3cGSgVfOXvlIWabyzyLxtIPUzi9r5ByyTpB5dw2PG4p7x5rte5G9qCA2Z3y6bgThMSXD93a5oqzifNjCUPDuAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=auroraos.dev; spf=pass smtp.mailfrom=auroraos.dev; arc=none smtp.client-ip=95.181.193.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=auroraos.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=auroraos.dev Received: from [192.168.2.104] (213.87.133.239) by exch16.corp.auroraos.dev (10.189.209.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Fri, 30 Jan 2026 23:35:42 +0300 Message-ID: Date: Fri, 30 Jan 2026 23:35:42 +0300 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Sergey Shtylyov Subject: [PATCH RESEND] drm/rockchip: cdn-dp: add missing check in cdn_dp_config_video() To: Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , , CC: Sergey Shtylyov , , Content-Language: en-US Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: exch16.corp.auroraos.dev (10.189.209.38) To exch16.corp.auroraos.dev (10.189.209.38) X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 The result of cdn_dp_reg_write() is checked everywhere (with the error being logged by the callers) except one place in cdn_dp_config_video(). Add the missing result check, bailing out early on error... Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Signed-off-by: Sergey Shtylyov Cc: stable@vger.kernel.org --- Either we need to add the check or drop the assignment to the ret variable as the value gets ignored anyway... The patch is against the drm-misc-fixes branch of the DRM kernel.git repo on gitlab.freedesktop.org. drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-reg.c b/drivers/gpu/drm/rockchip/cdn-dp-reg.c index 0dc3804051a9..9b82b27770e5 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-reg.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-reg.c @@ -685,6 +685,8 @@ int cdn_dp_config_video(struct cdn_dp_device *dp) val = div_u64(8 * (symbol + 1), bit_per_pix) - val; val += 2; ret = cdn_dp_reg_write(dp, DP_VC_TABLE(15), val); + if (ret) + goto err_config_video; switch (video->color_depth) { case 6: -- 2.52.0 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id EDvMFbcWfWlfOhYAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 20:38:15 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 20:38:15 +0000 Received: from sto.lore.kernel.org ([172.232.135.74]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlvFu-00000006KDN-3CUU for hi@josie.lol; Fri, 30 Jan 2026 20:38:15 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id 3919E3004DE4 for ; Fri, 30 Jan 2026 20:38:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F3BA32B99F; Fri, 30 Jan 2026 20:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="pBile50Q" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E8FB329E7F for ; Fri, 30 Jan 2026 20:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769805491; cv=none; b=HIGmKMrt0v77i98Vi290Rf2JrFW8UIj6319BM69KacGuij9SVEVoGqZMg4CHZ360Dpj0AKuxBxwoaWlz6eBy9VTD7ZT8EsdTjr/w5cc1yaJaaBeVa2wCoWh8yHs0eYgAP79y49yyex6yweorEkMrGhLd/MgyWU7zoXWUvAyWdlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769805491; c=relaxed/simple; bh=ZtMtrB2Y+G7ZscbAHQAFYF5f2VD5t3/mtZEyvZca4WU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=T73BRGYOhjfhwf+avfKQhpmJ/DuMdQdQ3Zchcv9N19R2CesNnJPgOZRXJxuYU+1HLPEcS4zFY6kliv3pBPUAn8HINMiKlhGeCKceo01Hp1mIsD8iz+PldQ7b0JC8M4kP1bkgzlfyM0FuT4YXhQHETcUHL8F1iE5WZr3JLHxsT5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=pBile50Q; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9694EC4CEF7; Fri, 30 Jan 2026 20:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1769805491; bh=ZtMtrB2Y+G7ZscbAHQAFYF5f2VD5t3/mtZEyvZca4WU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pBile50QnlGw8x75Ig9U45/zvrTbeGA0ov5UjecXOYj8eYIHEOhIX+dMpbkvVuR0W KaxG0ErlZlPaC9kxvgycPVLALXmhDSQoT1+nQjyuzLDUT5H8vJmsc62X6Y0T9uQaHR 4Qo3+b9PwRuH9v2n3d6JoxuwZYR/0fN/oL8ep4/Q= Date: Fri, 30 Jan 2026 12:38:10 -0800 From: Andrew Morton To: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= Cc: intel-xe@lists.freedesktop.org, Ralph Campbell , Christoph Hellwig , Jason Gunthorpe , Jason Gunthorpe , Leon Romanovsky , Matthew Brost , linux-mm@kvack.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] mm/hmm: Fix a hmm_range_fault() livelock / starvation problem Message-Id: <20260130123810.61dde600422a8fe01cff8296@linux-foundation.org> In-Reply-To: References: <20260130144529.79909-1-thomas.hellstrom@linux.intel.com> <20260130100013.fb1ce1cd5bd7a440087c7b37@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-DKIM: signer='linux-foundation.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -0.8 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-0.8 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: linux-foundation.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -1.2 NICE_REPLY_A Looks like a legit reply (A) SpamTally: Final spam score: -7 On Fri, 30 Jan 2026 20:56:31 +0100 Thomas Hellstr=F6m wrote: > >=20 > > > --- a/mm/hmm.c > > > +++ b/mm/hmm.c > > > @@ -674,6 +674,13 @@ int hmm_range_fault(struct hmm_range *range) > > > =A0 return -EBUSY; > > > =A0 ret =3D walk_page_range(mm, hmm_vma_walk.last, > > > range->end, > > > =A0 =A0=A0=A0=A0=A0 &hmm_walk_ops, > > > &hmm_vma_walk); > > > + /* > > > + * Conditionally reschedule to let other work > > > items get > > > + * a chance to unlock device-private pages whose > > > locks > > > + * we're spinning on. > > > + */ > > > + cond_resched(); > > > + > > > =A0 /* > > > =A0 * When -EBUSY is returned the loop restarts with > > > =A0 * hmm_vma_walk.last set to an address that has > > > not been stored > >=20 > > If the process which is running hmm_range_fault() has > > SCHED_FIFO/SHCED_RR then cond_resched() doesn't work.=A0 An explicit > > msleep() would be better? >=20 > Unfortunately hmm_range_fault() is typically called from a gpu > pagefault handler and it's crucial to get the gpu up and running again > as fast as possible. Would a millisecond matter? Regular old preemption will often cause longer delays. > Is there a way we could test for the cases where cond_resched() doesn't > work and in that case instead call sched_yield(), at least on -EBUSY > errors? kernel-internal sched_yield() was taken away years ago and I don't think there's a replacement, particularly one which will cause a realtime-policy task to yield to a non-rt-policy one. It's common for kernel code to forget that it could have realtime policy - we probably have potential lockups in various places. I suggest you rerun your testcase with this patch using `chrt -r', see if my speculation is correct. From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id WDuOHx8ZfWnsgBYAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 20:48:31 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 20:48:31 +0000 Received: from sto.lore.kernel.org ([172.232.135.74]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlvPr-00000006caT-0aSe for hi@josie.lol; Fri, 30 Jan 2026 20:48:31 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id 1F34C300CA3C for ; Fri, 30 Jan 2026 20:48:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 75958350A0B; Fri, 30 Jan 2026 20:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JxKbmbFb" X-Original-To: linux-s390@vger.kernel.org Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 116C32E6CA0 for ; Fri, 30 Jan 2026 20:48:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806106; cv=none; b=HoFMqEtMbEX4n8C+/wPA43FWcFIqT9JtXVMI6WTjIkTW/kH13oG3jE+X83LrcWSroa3lPV2adgwlDkwPHWILQN24VkhPesYU/dgtnA+s1pCD5bS2Bu6M2ukzHYmgFyjVTo8JRuFODq21ktaAwllZ5oLayxsS13u22HezhfeQku4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806106; c=relaxed/simple; bh=WcTJzlSzYQ3GdQ4ZKrgKXfine1j1UbideT72PsQJz7o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ubAbNIOVCiFIW81EFSB4urW+0np3OqTcxl1pH5Qs3V6wYrMSJxBqZyDcwHKaW2yr/7iplAi3Hkn37Eh4TPJp1N7uHtLnVdIWWfATdRA2kHucLk/Qcj2a377vHvElHUSpzypaEZY7Jbtny+6y5oc9aw6uuAIH0BTP3cm+jVIHl1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JxKbmbFb; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-47ee0291921so23434105e9.3 for ; Fri, 30 Jan 2026 12:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769806103; x=1770410903; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wyJyqKV6sfd+4rm1C0f1aBd4NEfWaqE99sc9YOO/X6o=; b=JxKbmbFbcnEPYltNFT+3kpskrhkR37I42Nem/xhMqrj9fcMPKmjAtUGewtlRd06Ov3 UFRxklA6iVhnHZ3bPmsHs4w+U8Ct1aOXLclZwe/xKk3w64JEcNxi7uHnGihQt802LJAQ 4AAswBSeXVjbQFGbp19pntzR+0oiJ48inkYfWb+qi2eY4G6Fly1mHVloMn5XIbYnbEo7 SEFFLj0b8jgp2tgcj98Gij7vHpQCUPyY4QOFyOkr97p7hFhppxdG4KvhPlcH7nBv4SBG MKqTQ6dDr6wc3AA+J+T6FxGrXzWf8+1+ss65e+9YDb6qAdypHGS4E0mYqKCeoBNwpCyE kVZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769806103; x=1770410903; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wyJyqKV6sfd+4rm1C0f1aBd4NEfWaqE99sc9YOO/X6o=; b=riuKw5q0ra+4OYRDyIL9zB6ygdGQ+L7g1mxJ1n5hXRQeolqHjydUoL/yo8AOeIb2yf 9ygDGYnTccUNCOELMa4+1wWvHj13CO5OstxSGoX7jMw2ERTR4C6MtFG7l5AEpGyyHHJ2 I4Q07lhQiibcOJmTLgmdy62swKSC6qydaLlVCy3aOyB3OBwCKYgx09+DVg9eZcsZXeVB xejK+wivRnf5obX4tAil2KFYRdYaVr3+r9BAZJPOsIp9SpKhUZWer0/JaCIBpRWz4U84 8rDdoDxgTSd+ntEytlK+e3SDig8pBTyptHkS+C/gJQwq6cczNvDk6ZaLs1mHFea7/zRE tESw== X-Gm-Message-State: AOJu0YypBnLhwQA/3nwdMNCLo80N2YMKFhEDo1YmctIAXaFct0aQl9Hr OrzdKfbIw9UkPs0EovYGHD2DezqO7NLA1ob3vAk/vAvtQTCOXYke+hfR X-Gm-Gg: AZuq6aI8RHtObN9ziN0WCTmaegZCpZlTFmeh28yntn+KhMsK8HV4rsN7LB7oEwXzXD/ tlzCtBfYv1DeG8ohcv/AXP76VUdLp3C3gcIA13FmpSG3Cjv5pTzgdcZeABANsQf1FfMTBXyYSIP v5AV7bqtX6P0BBXMFlHawjMjafcoCAdwusoQXLSMoWwrg/YnFqXYSA0apRkCJGOGvXiSOXinc7e 0WrWofOTG2U6pluEBNC6jGThiJOzkStm8IAwAg1PmKJaopRZiASvO+sx1J5G6qvK9rHAcPi5iTj s3dzx7PzqjGChWz1EHmnRx07o42aEt8T9fNckjRp94ZoDe9Qqk7bpIJ8F9JcCLlOZWJ7CAKXX1I ieFGLNzQ9FKqHKRdfvAOL8NfHJNmhcpVPVwMMOBrCHXJ1pTIFAI9J1iXevltMW54W4ph09E/94B I7OQt1pAD2F9C50NNe5Sj8Gq6QZWLaRl1QdfEp X-Received: by 2002:a05:600c:3ba0:b0:47e:e71a:e13a with SMTP id 5b1f17b1804b1-482db4ee2camr47791655e9.32.1769806103186; Fri, 30 Jan 2026 12:48:23 -0800 (PST) Received: from localhost.localdomain ([196.235.250.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cd8fadfsm221557985e9.0.2026.01.30.12.48.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 12:48:22 -0800 (PST) From: Salah Triki To: Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Salah Triki Subject: [PATCH] s390/cio: fix device lifecycle handling in css_alloc_subchannel() Date: Fri, 30 Jan 2026 21:47:59 +0100 Message-ID: <20260130204800.217395-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [salah.triki[at]gmail.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 `css_alloc_subchannel()` calls `device_initialize()` before setting up the DMA masks. If `dma_set_coherent_mask()` or `dma_set_mask()` fails, the error path frees the subchannel structure directly, bypassing the device model reference counting. Once `device_initialize()` has been called, the embedded struct device must be released via `put_device()`, allowing the release callback to free the container structure. Fix the error path by dropping the initial device reference with `put_device()` instead of calling `kfree()` directly. This ensures correct device lifetime handling and avoids potential use-after-free or double-free issues. Fixes: e5dcf0025d7af ("s390/css: move subchannel lock allocation") Signed-off-by: Salah Triki --- drivers/s390/cio/css.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c index 4c85df7a548e..ac24e019020e 100644 --- a/drivers/s390/cio/css.c +++ b/drivers/s390/cio/css.c @@ -235,7 +235,7 @@ struct subchannel *css_alloc_subchannel(struct subchannel_id schid, return sch; err: - kfree(sch); + put_device(&sch->dev); return ERR_PTR(ret); } -- 2.43.0 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id cO3gLykZfWnsgBYAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 20:48:41 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 20:48:41 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlvQ1-00000006cto-19CK for hi@josie.lol; Fri, 30 Jan 2026 20:48:41 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id C74803018BCD for ; Fri, 30 Jan 2026 20:48:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DBA36308F36; Fri, 30 Jan 2026 20:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=1g4.org header.i=@1g4.org header.b="DZYGi1pX" X-Original-To: stable@vger.kernel.org Received: from mail-05.mail-europe.com (mail-05.mail-europe.com [85.9.206.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76B65318ED8; Fri, 30 Jan 2026 20:48:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.9.206.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806091; cv=none; b=Lw13yihvD+Iwi9L1C4uZ0/B1taJtyxSosa4SFtMYTDwm4ZuA4kA2l99MvNzfLiMUCyI/GXWkdhKqDgY2qWNKLvvbe4/6jIArOVbuxOupfrcCU59jeAtybfGrTtTNO5dGGsr4svqYfEpcKiiD1++aAmww6Hf36JujoDefDeX/vpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806091; c=relaxed/simple; bh=NH3nSMZ3689wk1k+Ydtvm9911igQwjgTtxEraXA3qqE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I6ic1KTtbaj+02jglOSZdyk3f7kgd0Di0IGj67vvsiEUwv/8nWGwQ3hqMGSWE+pQcxQ5mFGOD3MC2FCaYT2mF7OLFPl5HgYi9CnP5PjC+9jFja2iY4Rdw7GOsv+4ULIsOinueKXUckMO9X5wZcmSEC4QjKwQdTYfGzc3zvBIGD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1g4.org; spf=pass smtp.mailfrom=1g4.org; dkim=pass (2048-bit key) header.d=1g4.org header.i=@1g4.org header.b=DZYGi1pX; arc=none smtp.client-ip=85.9.206.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1g4.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1g4.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1g4.org; s=protonmail2; t=1769806078; x=1770065278; bh=Ns6aX4kVdG2x2DS59nidc0rJohsMUdrNgcAO4lwVAHY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=DZYGi1pXMmC/ubxw0V9VFT3GCanL1MXxliYflYZFJ0cpNFRDkbhmac4wXsyyWFpyk C0lJwJ34OSynuEP4MSuqk+6JEUe/nInqPxYzOx23wSwJO2NXCurpA3AJnX78idfvKg kQvsTMKmAzSQQA8PPrwMNTYwOWxAC2sWMOYsW1FWx6cFsfoOHD7Rk3OWCFkxcRZoc1 4ONFQ7npa9bZlgP4BTreEjbydmy2mNu0Vs9vBAwPh5PFS6cK+oxwj3umDjPnco3/Fq 2uxHkZ0xEbXDQcotJjGyiFEqS47iQ9zlRa+mehX0+KY6vS1t/U0jCDtfV3SPQNHUUi RpMd6vCpJ7Uaw== Date: Fri, 30 Jan 2026 20:47:52 +0000 To: Jamal Hadi Salim From: Paul Moses Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] net: sched: act_api: size RTM_GETACTION reply by fill size Message-ID: In-Reply-To: References: <20260130134220.305757-1-p@1g4.org> Feedback-ID: 8253658:user:proton X-Pm-Message-ID: f7035d83a69cc823dd322282f4eb5a8914867daf Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-DKIM: signer='1g4.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: 1g4.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 What version of act_gate.c are you currently testing? Did you actually run = the tests? =E2=80=9Clarge dump=E2=80=9D creates ONE action at base_index, w= ith num_entries=3D100, then immediately does GETACTION. So =E2=80=9Ctc acti= ons ls action gate | grep index | wc -l=E2=80=9D won=E2=80=99t exercise thi= s, because it only counts actions. It doesn=E2=80=99t amplify the per actio= n dump size (the entry list does). It uses libmnl (mnl_socket_sendto / mnl_= socket_recvfrom) with MNL_SOCKET_BUFFER_SIZE. There is no custom netlink ha= ndling. The failure is returned by the kernel before userspace parses anyth= ing. The dumps are transactional at the netlink level, but an individual ac= tion dump still has to fit in the skb backing that message.=20 look at af_netlink.c =09/* NLMSG_GOODSIZE is small to avoid high order allocations being =09 * required, but it makes sense to _attempt_ a 32KiB allocation =09 * to reduce number of system calls on dump operations, if user =09 * ever provided a big enough buffer. =09 */ ... =09/* Trim skb to allocated size. User is expected to provide buffer as =09 * large as max(min_dump_alloc, 32KiB (max_recvmsg_len capped at =09 * netlink_recvmsg())). dump will pack as many smaller messages as =09 * could fit within the allocated skb. skb is typically allocated =09 * with larger space than required (could be as much as near 2x the =09 * requested size with align to next power of 2 approach). Allowing =09 * dump to use the excess space makes it difficult for a user to have a =09 * reasonable static buffer based on the expected largest dump of a =09 * single netdev. The outcome is MSG_TRUNC error. =09 */ This is where I am currently but I have seen these bugs appear throughout a= ll my iterations including what's in the tree currently, if you show me bet= ter alternatives that solve my problems, I'll gladly accept.=20 https://github.com/torvalds/linux/compare/master...jopamo:linux:net-stable-= upstream-v4 gatebench --selftest=20 Configuration: Iterations per run: 1000 Warmup iterations: 100 Runs: 5 Gate entries: 10 Gate interval: 1000000 ns Starting index: 1000 CPU pinning: no Netlink timeout: 1000 ms Selftest: yes JSON output: no Sampling: no Clock ID: 11 Base time: 0 ns Cycle time: 0 ns Cycle time ext: 0 ns Environment: Kernel: Linux 6.18.7 x86_64 Current CPU: 7 Clock source: CLOCK_MONOTONIC_RAW Running selftests... Running 20 selftests... create missing parms PASS (got -22) create missing entry list PASS (got -22) create empty entry list PASS (got -22) create zero interval PASS (got -22) create bad clockid PASS (got -22) replace without existing PASS (got 0) duplicate create PASS (got -17) dump correctness PASS (got 0) replace persistence PASS (got 0) clockid variants PASS (got 0) cycle time derivation PASS (got 0) cycle time extension parsing PASS (got 0) replace preserve schedule PASS (got 0) base time update PASS (got 0) multiple entries PASS (got 0) malformed nesting PASS (got -22) bad attribute size PASS (got -22) param validation PASS (got 0) replace invalid PASS (got 0) large dump DEBUG: msg->len =3D 3112 PASS (got 0) Selftests: 20/20 passed Selftests passed Running benchmark... Run 1/5... done (311721.5 ops/sec) Run 2/5... done (321045.7 ops/sec) Run 3/5... done (336402.3 ops/sec) Run 4/5... done (338419.7 ops/sec) Run 5/5... done (316618.9 ops/sec) Benchmark completed successfully From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 6PrBFBwbfWnmqxgAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 20:57:00 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 20:57:00 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlvY4-00000006rvk-00eG for hi@josie.lol; Fri, 30 Jan 2026 20:57:00 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 5A0513009B1E for ; Fri, 30 Jan 2026 20:56:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CA5FB36AB49; Fri, 30 Jan 2026 20:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="O7O/++g5" X-Original-To: stable@vger.kernel.org Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A6A82FFDEA for ; Fri, 30 Jan 2026 20:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.219.48 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806581; cv=pass; b=WGtMh4gdFcss1qU+Hdm3IWxc2kIBsQ/cI36yQ2Ag91w2UTf/d1PuX3pOl2xD/yVXLtQBtG52MaSJTU71pnyth2cNNs2SXngZOsLWWiJC9zCqvDEx9s4CtBp2wjIOwTg+4aPKKavpKRr737K2QqR/rIiuCnp6PyZ6uzBOHc8i640= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806581; c=relaxed/simple; bh=Br6xQKyGbDO6MM0Z3TPAdS5EDwz4uZXbauI4tqlHtZw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Ovst0hdwoMVC/wg2d0SVZYJfSK+sz1ztNTTrwXKl0lQzv+7ku8HQg/z/xRZT5g5FZBB0IvJdmSOAXRnzf1bXX183v5UqC/cJyzly+UrmS6uv+YO7J3NPC3R0HT4w53EhimRAWK892b14/bofA4RR8zyiFOvwBfi9NtgBs8TV4jU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=O7O/++g5; arc=pass smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-894638da330so25733166d6.1 for ; Fri, 30 Jan 2026 12:56:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769806579; cv=none; d=google.com; s=arc-20240605; b=iB0ZJkFP3eb6rpuCoKfnGr7Z+qFyOOhgNYvZMI0DLS34bi0g20vJarILKjQdysrgD5 BdY/nj71Kn2xQ7T36erp6D9QiTuug/7TUqVu3d8vPSDj5RJ/C7QISlcfy0uLrmH/bCd/ UGpIeO2jmSk8ytAvZTx5+kfCGoSjro9VIKOEZQuaNduRnIZrRtXWmVvKWvL7kzwhjVTv 3i0E0cmGn9knwo1hmTX6JH3B4bhZ25YCRGRmrfYvEPBuIkyl9KdfGR9ge47+nVI9Ij1G lxs7yRYVQobr6mfn9r9Kx8941IJojCfomTMTcQJIFwdTQThPSDa/x0gmc2mGI+W7TTQ0 35YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=WSV8/5N/+j/2QxAKyyJXPtuQTRJ1LNLrh8eDzw4eLyA=; fh=YrOaa6v8lcmLsLJLj2w+O6W4OWUygBFmTycQGhk84Wo=; b=TWA/Pk9+mfOYj5pdoeeSCoxG6+nzY6LTvrZTvcqr3z+0SjcTiwYeUyEFQo4E7i2t1l PyqW5DtoD1sLEjNTudGUmnz1HbScWbcGLZLVnypRcXV2PiVnb58qw/KYLymQiZJBKasA yrc2ZG4+kltvgw0YALNvqBNOU/U2rmfuUTD8E2bs2wlFSKkxFzkbZ3pNGjY24V6UvTbz J22qMzOCPG7VAkoWhmdISuO/yux2QGCqtvrodMKHGW7cfnNbVER2pQueMabguAws3lKJ yOReGJjCpXEgVSSz17IZpIqvzxORopW6VXgK1biYFGKnQTQvlUE8CRp/isruqMC/Pc0Z xkaQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769806579; x=1770411379; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WSV8/5N/+j/2QxAKyyJXPtuQTRJ1LNLrh8eDzw4eLyA=; b=O7O/++g5Xvn2LasG5S+ktz4GbT0JzPYjIxNJrEi4yi2DO8x4tiibM4yYziQRniCZ0+ 7qojDiuDtV5PWZf2UCIF72jY9fkQUJsWeejImTE4h6TV8uqyZfXiTyfBGtRWixMBW4db DmBzj1AHewFNcQiRbgCCTT8j7izBG3cDZWf8DR+ytnCTU4VZ+aYTYgllq5pOvd2yDtn0 Bn59+Hke8Bc0RwWg0MTG1SBcbn33XlvRCcaOlMTId4n390KTTd4w53VEyON11br5QU+b dHrDCFTDVpC/ps/tTkIPsBFwPiyFFmb+9HTa1uOgf7CEWMCp7zyzBxh6P0XRPtkyrCYV P6TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769806579; x=1770411379; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WSV8/5N/+j/2QxAKyyJXPtuQTRJ1LNLrh8eDzw4eLyA=; b=emd2brh0CFp1ervKaD3xcWvGR/Atj62/GAF47WBrM4pSo2yz+W3L3Z17zPN6ca+FGp LcuCjN3kOswU5MiD+IX5vopZRJX4GwN7UqXFKXuj1GvjWP/yLsZxMa4X0Sf+/rBgF40m FXvNlihXpOQRpeAlz1pJSrjPM9f+T2FLW26pXl1aahm55/X6l0Ns5mghvFJt2FiZhYzd 5RwD0VMoeFff+nhQo5OlvhHgtPliWmd7saiVtsaIksYIPBCbEZHo1hkhVAwSEEG2xQAi f9JaGGzwE4DVHu0J/7w8GDewF4p/Xp0wD9eeCKfO2HiHWcCl07mHbhMLI/98wWmxQigp ZUHw== X-Forwarded-Encrypted: i=1; AJvYcCUyV9nRkgjmIpIc2owJaiTibcO/dKY0UuPbTGyNmy2bStZEESh8SLE/WXgdc3zpo98J9U6vUG4=@vger.kernel.org X-Gm-Message-State: AOJu0YzC1M7gaHYcamB68J/LR9tEoM3m9AeVDblFpSx3khSUKuG4MlP1 B0o2s90o+TxkZGRdMBt0DjTl9g8Dq8pmmIYB94Bt7MXogxuQRDp482F0e1/yLJLsLdo8EFP/DGt pU0VUEkXUFhMLCkN+YBBdovG0IxBI13oVVxg9P1CU X-Gm-Gg: AZuq6aKCGs2Q1CDZyHg0liDKQ9nUhX0UPGPdX97alDkbyuddEKdUWwv9F8Tio4QXz1f WNoSi9IwOfOk4MqjzocEuwtOiGV9zSnmlOU7SswRVKn1gsfLEKGyP9Ni3BRQ3uZJ8ubL82bpAiV JiHo8B/Add8/WtgCqDpzc7/eFcpNB5PJ+kwlx21NHxq9Q2c3ojtt5983wddsPvfBnkG4oX3B/H0 fThkRHiJQjOrXNDoFIYraaaQ2y//DfxpQNe/mbCGcWvqqwrqOJWGI/35wsqx2gCu3pAdRo= X-Received: by 2002:ad4:5f8d:0:b0:888:7e02:50c4 with SMTP id 6a1803df08f44-894e9fa1e33mr57059526d6.24.1769806578764; Fri, 30 Jan 2026 12:56:18 -0800 (PST) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260105232504.3791806-1-joshwash@google.com> <20260106182244.7188a8f6@kernel.org> In-Reply-To: From: Eric Dumazet Date: Fri, 30 Jan 2026 21:56:07 +0100 X-Gm-Features: AZwV_QiRhQ8aUH7eQGfWhKSFr9vhFJUyAeNYpfqKMwJkIBSms32xB9wnb_LdUwA Message-ID: Subject: Re: [PATCH net 0/2] gve: fix crashes on invalid TX queue indices To: Ankit Garg Cc: Jakub Kicinski , Joshua Washington , netdev@vger.kernel.org, Harshitha Ramamurthy , Andrew Lunn , "David S. Miller" , Paolo Abeni , Willem de Bruijn , Praveen Kaligineedi , Catherine Sullivan , Luigi Rizzo , Jon Olson , Sagi Shahar , Bailey Forrest , linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-DKIM: signer='google.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -7.1 (-------) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-7.1 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -7.5 USER_IN_DEF_DKIM_WL From: address is in the default DKIM welcome-list -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_MED DKIMwl.org - Medium trust sender SpamTally: Final spam score: -70 On Thu, Jan 8, 2026 at 9:53=E2=80=AFPM Ankit Garg wrote= : > > On Thu, Jan 8, 2026 at 8:37=E2=80=AFAM Eric Dumazet = wrote: > > > > On Thu, Jan 8, 2026 at 4:36=E2=80=AFPM Ankit Garg w= rote: > > > > > > On Tue, Jan 6, 2026 at 6:22=E2=80=AFPM Jakub Kicinski wrote: > > > > > > > > On Mon, 5 Jan 2026 15:25:02 -0800 Joshua Washington wrote: > > > > > This series fixes a kernel panic in the GVE driver caused by > > > > > out-of-bounds array access when the network stack provides an inv= alid > > > > > TX queue index. > > > > > > > > Do you know how? I seem to recall we had such issues due to bugs > > > > in the qdisc layer, most of which were fixed. > > > > > > > > Fixing this at the source, if possible, would be far preferable > > > > to sprinkling this condition to all the drivers. > > > That matches our observation=E2=80=94we have encountered this panic o= n older > > > kernels (specifically Rocky Linux 8) but have not been able to > > > reproduce it on recent upstream kernels. > > > > What is the kernel version used in Rocky Linux 8 ? > > > The kernel version where we observed this is 4.18.0 (full version > 4.18.0-553.81.1+2.1.el8_10_ciq) > > > Note that the test against real_num_tx_queues is done before reaching > > the Qdisc layer. > > > > It might help to give a stack trace of a panic. > > > Crash happens in the sch_direct_xmit path per the trace. > > I wonder if sch_direct_xmit is acting as an optimization to bypass the > queueing layer, and if that is somehow bypassing the queue index > checks you mentioned? > > I'll try to dig a bit deeper into that specific flow, but here is the > trace in the meantime: Jakub, the issue is that before 4.20, calling synchronize_rcu() instead of synchronize_rcu_bh() was probably a bug. I suspect we had more issues like that. __dev_queue_xmit takes a rcu_read_lock_bh(), while the code (that you added in 2018 [1]) to update the queue netif_set_real_num_tx_queues does synchronize_net() (aka synchronize_rcu()) and in earlier times, it would mean that this would maybe return too soon (say on preemptible kernels) [1] commit ac5b70198adc25c73fba28de4f78adcee8f6be0b Author: Jakub Kicinski Date: Mon Feb 12 21:35:31 2018 -0800 net: fix race on decreasing number of TX queues netif_set_real_num_tx_queues() can be called when netdev is up. That usually happens when user requests change of number of channels/rings with ethtool -L. The procedure for changing the number of queues involves resetting the qdiscs and setting dev->num_tx_queues to the new value. When the new value is lower than the old one, extra care has to be taken to ensure ordering of accesses to the number of queues vs qdisc reset. Currently the queues are reset before new dev->num_tx_queues is assigned, leaving a window of time where packets can be enqueued onto the queues going down, leading to a likely crash in the drivers, since most drivers don't check if TX skbs are assigned to an active queue. Fixes: e6484930d7c7 ("net: allocate tx queues in register_netdevice") Signed-off-by: Jakub Kicinski Signed-off-by: David S. Miller So perhaps a fix for pre 4.20 kernel would be: (I kept the synchronize_net() to be really cautious and because I really do not want to test) diff --git a/net/core/dev.c b/net/core/dev.c index 93243479085fb1d61031ed2136f5aee22d8f313d..4dd1db70561d35fe2097afc8676= 4dd82bfd0bf27 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2636,6 +2636,7 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq) if (disabling) { synchronize_net(); + synchronize_rcu_bh(); qdisc_reset_all_tx_gt(dev, txq); #ifdef CONFIG_XPS netif_reset_xps_queues_gt(dev, txq); From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 2NOdGgscfWnsgBYAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 21:00:59 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 21:00:59 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlvbu-00000006z6l-22aY for hi@josie.lol; Fri, 30 Jan 2026 21:00:59 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 110DD30465F9 for ; Fri, 30 Jan 2026 20:59:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD1FA37FF41; Fri, 30 Jan 2026 20:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iWZLZ+Rl" X-Original-To: stable@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F1C38170E; Fri, 30 Jan 2026 20:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806777; cv=none; b=gvijehLMTrIJupzdlrFI40kWC1tExJ5jKxF7hMh5OpFdWNh4qSKRbDJViVNdWYNLqGq7BdzDkPjzdqoP6PFftN4DP4ZluW7dhPDUYO1T5Ebti+FQc/GIysluA0FBJbjhGdUyqdwC36sbjRlCGoc3L2hfN2mrG0VByfxmumbYAe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806777; c=relaxed/simple; bh=baKThfj+uFC29r614dW5AycogE14elKtuMG3Rd0W1m4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jkIbjXIwgwzF1GacQhET9LEll0e5iIUYG6zOpxWTjbTk8trdGi5drWR2c7ZT4J000Gz62GeO/KL/jlSvdqoa38ClDYurkQDneop8vjN80i45Re9o17GWMM1znAb0n2fkLAwB6kEG7WHOXUelmvIWO5AVERR+uYqJmWi3UZ/cCOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=iWZLZ+Rl; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769806776; x=1801342776; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=baKThfj+uFC29r614dW5AycogE14elKtuMG3Rd0W1m4=; b=iWZLZ+RlipdUq9IvwVd3rhkrTECBGL9+VG1Du/37aFdXsA+iWVJ5aJ8v Wsw+XGsmhoo9Dy7jO8QmDkDfKR6SAZD1qYuKaL7RdN/5n/omuaf5cgLH/ n+Yd//qsQRg4vMCnlK3zoDF9S8LkZGz3J4KWq/ww6qfFNX5Xsa3rk0who GNTzLmRCuZAEn9j9/tCstJi6eeRDJ+dOIGAGf/pe5bQ5smRVHDoj7+PDT 3yjIV93E6rupjCfM9HowEA49ghixAvWOnK4+tVwml+aSBnLjiV4CmyEA+ 7ZXMiUG1/qXRW7VK/s//Uu/XQ4GUy5e6MSIPkZe0QoCTbl5VoHjLrasni w==; X-CSE-ConnectionGUID: O6T1n+FER8iV9TWhFpu3HA== X-CSE-MsgGUID: sYZmVKxcSHebMTT1ss9R8g== X-IronPort-AV: E=McAfee;i="6800,10657,11687"; a="88636591" X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="88636591" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 12:59:35 -0800 X-CSE-ConnectionGUID: TOvX5lamQxKe+vP8xRY4yQ== X-CSE-MsgGUID: MGpvkZjGTruQ+cPX22T0Aw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="209351537" Received: from lkp-server01.sh.intel.com (HELO 765f4a05e27f) ([10.239.97.150]) by fmviesa009.fm.intel.com with ESMTP; 30 Jan 2026 12:59:30 -0800 Received: from kbuild by 765f4a05e27f with local (Exim 4.98.2) (envelope-from ) id 1vlvaS-00000000dMG-3LNm; Fri, 30 Jan 2026 20:59:28 +0000 Date: Sat, 31 Jan 2026 04:59:09 +0800 From: kernel test robot To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Andy Shevchenko , qianfan Zhao , Adriana Nicolae , Tim Kryger , Matt Porter , Heikki Krogerus , Markus Mayer , Jamie Iles , linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, "Bandal, Shankar" , "Murthy, Shanth" , stable@vger.kernel.org Subject: Re: [PATCH v3 7/7] serial: 8250_dw: Ensure BUSY is deasserted Message-ID: <202601310404.Rdq0kVXE-lkp@intel.com> References: <20260130132857.13124-8-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260130132857.13124-8-ilpo.jarvinen@linux.intel.com> X-DKIM: signer='intel.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-DKIM: signer='@intel.com' status='pass' reason='' X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: 01.org] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 Hi Ilpo, kernel test robot noticed the following build errors: [auto build test ERROR on 8f0b4cce4481fb22653697cced8d0d04027cb1e8] url: https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/serial-8250-Protect-LCR-write-in-shutdown/20260130-213314 base: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 patch link: https://lore.kernel.org/r/20260130132857.13124-8-ilpo.jarvinen%40linux.intel.com patch subject: [PATCH v3 7/7] serial: 8250_dw: Ensure BUSY is deasserted config: parisc-randconfig-001-20260131 (https://download.01.org/0day-ci/archive/20260131/202601310404.Rdq0kVXE-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260131/202601310404.Rdq0kVXE-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202601310404.Rdq0kVXE-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/tty/serial/8250/8250_dw.c: In function 'dw8250_check_lcr': >> drivers/tty/serial/8250/8250_dw.c:267:1: error: label at end of compound statement write_err: ^~~~~~~~~ vim +267 drivers/tty/serial/8250/8250_dw.c 234 235 /* 236 * This function is being called as part of the uart_port::serial_out() 237 * routine. Hence, special care must be taken when serial_port_out() or 238 * serial_out() against the modified registers here, i.e. LCR (d->in_idle is 239 * used to break recursion loop). 240 */ 241 static void dw8250_check_lcr(struct uart_port *p, unsigned int offset, u32 value) 242 { 243 struct dw8250_data *d = to_dw8250_data(p->private_data); 244 u32 lcr; 245 int ret; 246 247 if (offset != UART_LCR || d->uart_16550_compatible) 248 return; 249 250 lcr = serial_port_in(p, UART_LCR); 251 252 /* Make sure LCR write wasn't ignored */ 253 if ((value & ~UART_LCR_SPAR) == (lcr & ~UART_LCR_SPAR)) 254 return; 255 256 if (d->in_idle) 257 goto write_err; 258 259 ret = dw8250_idle_enter(p); 260 if (ret < 0) 261 goto write_err; 262 263 serial_port_out(p, UART_LCR, value); 264 dw8250_idle_exit(p); 265 return; 266 > 267 write_err: 268 /* 269 * FIXME: this deadlocks if port->lock is already held 270 * dev_err(p->dev, "Couldn't set LCR to %d\n", value); 271 */ 272 } 273 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id KHaxN0UefWmoQhcAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 21:10:29 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 21:10:30 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlvl7-00000007JIK-2GtN for hi@josie.lol; Fri, 30 Jan 2026 21:10:29 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id D28AD30AFC02 for ; Fri, 30 Jan 2026 21:02:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1A6938A713; Fri, 30 Jan 2026 21:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JyRXYswG" X-Original-To: stable@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29D48388863 for ; Fri, 30 Jan 2026 21:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806894; cv=fail; b=otCjAClqGotDKqoxKUFDCKA8u6m1eL14L0g8TPGPvxl14wtCjIdQgaAHw+yfFi9iKhZ9cqVgldINXnIgrlBfqOqIVg3W7zwfao02VVGkNMUfM4yyBlr+OE2MrolkVw5ujQbJveQaQJd3U54293rMHrtEvTQXoB2k50McrficU2w= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769806894; c=relaxed/simple; bh=NMc7cvhygMKo/5d5SZgV0E5w8wAPG/Ca3iBPe+kf4+I=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=tovKfAIHkIM6ol9+T4Bkuk5expVF9aCGhq/IN1xdk5YR/pWMl9Tk+MkAfqLJlXLdPQEBPGFIzVe7XCiap7S9dVIR8hhruIeMb810hfXjsgXP0K573QL9n3MziIxL2LYRMIWRQMaW0It/a63LBscuhiqqtLtveW/d5Xnm9j3ADgA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JyRXYswG; arc=fail smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769806892; x=1801342892; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=NMc7cvhygMKo/5d5SZgV0E5w8wAPG/Ca3iBPe+kf4+I=; b=JyRXYswGUTEVEpOKxE7NfK+SkaBOzA4t7cgJ8wVw5HNoXV9dRK7LBENd gi85/QyE5sm3YLfrcKrL+WTgNM01DOk7Iv3h9jJlLsZQk654e+YA2pk7P JR7QJMFHgIpgrJKZTpO5V+HJm8xybIEdG1RK9aFv1GWVKsOI+NYgijQ2b mlooXg7F43q+c0W1odKKKa1WZGv8wf7M8RsW2FQqf6X5c86tBWJeV0xeF j4GjMVoE6P4BtL13BUQoRyllKq3C4TJRB1wBMCMXvETsqJZXieSRvyQQP czDoWUUegLCyhv9Vi7n1nnSwOavm1wWzoBWbBcKaJu+OM82h+gfd7cqXX w==; X-CSE-ConnectionGUID: kbnSvqqwQMCEf1dmOKqHCg== X-CSE-MsgGUID: VeEckxneQpWYsAaBTEodXg== X-IronPort-AV: E=McAfee;i="6800,10657,11687"; a="71041310" X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="71041310" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 13:01:31 -0800 X-CSE-ConnectionGUID: 84RROu+ZSvyLj9quZwhBRw== X-CSE-MsgGUID: 9Pt6fnlBQ3utm+TxLmSA8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="246571331" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 13:01:31 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Fri, 30 Jan 2026 13:01:30 -0800 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35 via Frontend Transport; Fri, 30 Jan 2026 13:01:30 -0800 Received: from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.67) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Fri, 30 Jan 2026 13:01:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mbgyRN764tyx48Mjt6naqqgmm0gKM9LMj84n1x+/vbBEWfo/VB8jverzyeMm3O84DPhadOZWqqveMWSNee4ATYwdMp8xS6U3lhf4WmKNSOJGwcts7VKjVRKzWFxW7DzNfFbzrSwptTj9//sFsgwjMqB79rOl8JthjfutySV4eoEX9XO2763be7MbUnCWrXiLS4vJTJsFo9DHzRWn9o+wW9ewvBFqbQ9S+LNV6RTir4HYF3ksN5+sFr/Zb2Y/ve6Ku7C3CqIUpCDu+EbwXNFUjN6My8R+5Nbb05clZkXyACvXgUcTpWBKMiWX/BSIs1trLD+iI8gPo8JIeYeUrOs1nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nFKIOFixxPGQ18G8ckmMn0msXOFVq6wnRFkXY1iHxJQ=; b=ksOGAKBpiBSGO+e3Fzb6vbTbKPCbQVM+RKD+WAMFcJAj44j3XPohloNEkembPr8ywUs/1JMix8Y4a/7WYySh+km+hSb4TO9cEDuWhmgNLkY2gkSpsREjOJThfco45mmGnMlFan/djj+tN49Fs3Qy4oVzGsVk2thXy3cGxYYqgVWxdFRpAzit2iFQwttYIAZhO81u5zmi15aXuvjHSbMzCPJ2iN+lwUu6IwV+icMUf08bAR0tMJ5g5XgAAPcLwGIBJQOlXRemWCK3M37BlhRUrwVPhOFVBgucOI/7SDyHlcq6M3Ad7Un0lflWh4rlKkDJZrIFxSb5Lv7NnOx6GlXW1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) by SN7PR11MB6948.namprd11.prod.outlook.com (2603:10b6:806:2ab::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.11; Fri, 30 Jan 2026 21:01:27 +0000 Received: from PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::e0c5:6cd8:6e67:dc0c]) by PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::e0c5:6cd8:6e67:dc0c%6]) with mapi id 15.20.9564.008; Fri, 30 Jan 2026 21:01:27 +0000 Date: Fri, 30 Jan 2026 13:01:24 -0800 From: Matthew Brost To: Andrew Morton CC: Thomas =?iso-8859-1?Q?Hellstr=F6m?= , , Ralph Campbell , Christoph Hellwig , Jason Gunthorpe , "Jason Gunthorpe" , Leon Romanovsky , , , Subject: Re: [PATCH] mm/hmm: Fix a hmm_range_fault() livelock / starvation problem Message-ID: References: <20260130144529.79909-1-thomas.hellstrom@linux.intel.com> <20260130100013.fb1ce1cd5bd7a440087c7b37@linux-foundation.org> <20260130123810.61dde600422a8fe01cff8296@linux-foundation.org> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260130123810.61dde600422a8fe01cff8296@linux-foundation.org> X-ClientProxiedBy: MW4PR04CA0058.namprd04.prod.outlook.com (2603:10b6:303:6a::33) To PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6522:EE_|SN7PR11MB6948:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c22c419-4e91-4bde-e286-08de6042bbd1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?sDECCUhuuHUy4K6yWkLoFoTvDJgjIxmlMUGMOey8uqxpspknPSR5r/qzN6?= =?iso-8859-1?Q?hxt1Wl6pjHHUN7QhRTEOeOYbIybJnuK73ME3H0chgk2e8NM8pVF86tziKG?= =?iso-8859-1?Q?D6sBCeANv47BS8A5xpw1XaqmuT7zfC3P6+4o7lHCVvowK2g7Un2/C3bCYi?= =?iso-8859-1?Q?pMfAEhcImq9hQkA5jV7+3Awe7RTVH5SQvdyHRWxWm6UmFyIMG8COv1EG0/?= =?iso-8859-1?Q?dn/DTOOX2kFmqDeqzA+5alVBIBMJ0CjeNMrxmw6Ue5VG+GIaqj6gIJQ6u0?= =?iso-8859-1?Q?5uR1gmIfgILfTRpCIGcG6gcOiiATtS9DUnlnU2G8mZpotwK6/HcyNXKFPb?= =?iso-8859-1?Q?PSrIZBTbXyql30iVHXjeax3wNp8fFTKpzcqUHXX748RU6i8oPMjlZVu6sP?= =?iso-8859-1?Q?nQ+JAhPBZFnClV3F6/uEmi0VJfVdnO6LlZAi8nSnGjAgcxHjYqpGsn9KCC?= =?iso-8859-1?Q?6XsQ4y1tTwZQPTLBZ3YWkyibdo4NqWkeJ4XEd6/pToiCc2+f098UeeQMHw?= =?iso-8859-1?Q?JyxHGdfKHz2dWlIwV6QS6qHtzXp/CEm9cWeG6wpNqzQQxDfXCwRlm3pvnG?= =?iso-8859-1?Q?V1fl+hTj2ykGcmutuTY3g8yjt1QFC3B8XW2c2U/knj3PT+oH5bC3TDwDMH?= =?iso-8859-1?Q?cn14WBY27DcXKALFK+3KWb954H8xdWkcEInmpvK335CBNvGSBSpgryoUvB?= =?iso-8859-1?Q?YK0c7P1PBlhw6rGxdr6VZtpbcyofeNK2OJH9/bKsFvWEsEh7RGrA0oRa36?= =?iso-8859-1?Q?mN3B6EFSjsVQ1wlkRsO3yWBlghh155FFrv3qCvLxxjcw2nFDK0iqwaSbxX?= =?iso-8859-1?Q?XEEyLXeg/RtXLB2OK/IbETt+zbebt6p5jS00Up4o6scEQ+LZig3UpOXAXb?= =?iso-8859-1?Q?oq8me7RvUkUPAzAy1uniYLnmWybIfcDqqcz20pk6a0AXcu0RDhdBD4YsZf?= =?iso-8859-1?Q?czMZxHFH2eJzvZIwymSM6Amc5IVJBRDunt16St0wlHzUOWZ4PPEVAQUWLM?= =?iso-8859-1?Q?41kPzOEVzyJ4OC0vSlFs86iDBMKzgMzI4KZIKIb2gyUA6j83NeCyrt5uvr?= =?iso-8859-1?Q?enwufkPtmqDbwZhbNGpHjhEQ6y3JJhmhpKIm/YNC02dVUK6sQNlNscgS2e?= =?iso-8859-1?Q?IQ/Klc5lv1cjljexyBXFhgLs9cMghnqO1aoP66BeROdhxMPAuJx4yplZAp?= =?iso-8859-1?Q?SRNOCd0yD0OGWrO/F9X/p9s1sLgTwIUCTK0tybfRciPurtLs6PEdKof5mt?= =?iso-8859-1?Q?lMAvtMR+qm06mp2SQWzqNoijIiZr8FCY8Fzixb8cH+cDwEGz3k6tQFDouz?= =?iso-8859-1?Q?FC3l6/JdnEaCGRolNFIFXRxO1xW/tELSCxB32CtHxpBVzJeAmeV9vNUlzB?= =?iso-8859-1?Q?9iRB/Bxy+o29G9gB1j75RFkAI1UVjCcBACvLqVPeGDS73LrqIkU1tUXDxQ?= =?iso-8859-1?Q?UBN/gTglkF0Pn7Px8nkqcBeD81uPyitIcMVMuDGZ1A3uC8RayGQjYhp1yS?= =?iso-8859-1?Q?G5YaQfo2GWAqBeN4h7hrJLggu4ZW6Q695LXrPEAsdWie39Z3S4EG0JoSYj?= =?iso-8859-1?Q?3yCtZteVqmAb5lf/gmalSFdX+r/5DLLBqqZ2+AP9CR1iRLpo9h1XnxrKuz?= =?iso-8859-1?Q?oQcTcltGNafsE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6522.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?WsmkjqV7ALdjIcQyudRGr6SxgDkJt8NeiRwtfP+GbqX69qmM4i6E01oZAP?= =?iso-8859-1?Q?NSdVCkrjYQQWiAtJAWhADBeU5lQNCPsfb6iUQbXORvHMTF4A1HNsSOH2+W?= =?iso-8859-1?Q?M7atWPSeAd1wYGiZqMJBncFCXV9QYP2YusZv+cglTnjvrE9P8QBsgyRhMx?= =?iso-8859-1?Q?F2IgPO1AUPhf0c53ch6iTk8OqCaNukIm5wPIVeAna0nA9uAQ3IkhdW1QGI?= =?iso-8859-1?Q?Bk2SB5RP8Cou1npSA8V1KnIwruZ+cBlqHKdqFff/y1dZklEYJzwEpFo0xU?= =?iso-8859-1?Q?o0dKA0rdN6mzbHniRPDLCZ7ODx2rbMIiNwCcUzaNa1DAS8yDg+mzQtipLN?= =?iso-8859-1?Q?lJbw4Wi5WoWNJBM1v5tL8XH0BnpWAHux4sdnUfCKeVkldBtQ0tbRtRC62w?= =?iso-8859-1?Q?CavMwLeznSVndFeHrcf9roVJ60F0G0FXmhM28Q48r/XpR3okD9Ekb9OOyf?= =?iso-8859-1?Q?XEf5ZZUK7lzXAY3VZVnX4EvPnspEaygyWUUDkqEvLnW2UgdXyAsCm/QMcf?= =?iso-8859-1?Q?nipBbaGjAYAkrmDus54Nj7TZ9hDd103MWWTEfrunvnnYrQj2r1hXXjbOGO?= =?iso-8859-1?Q?fE3432rcC4QI1taYWZBw1DuubY24NS215LFDG0SgqSZYhKDt54euCrCNKG?= =?iso-8859-1?Q?12leNykDP/oQox7Jbx2qL+h10s58satJSntuvYfbE9mdRCRJEEDH1xhmtE?= =?iso-8859-1?Q?15ZLdEOqEGJPp8acbN1SvfjZoTIH+vWOWxSff42HFqnugi+tCBOC29JEyx?= =?iso-8859-1?Q?W3DHClATIpMbsktunymLORMQimcBSbSl4t/s0w5YDSwgcSjxNyNZqHAvNV?= =?iso-8859-1?Q?bma2wLGY3Jl7tv+6YqcsBFAZYffLdczgidI+vBGE2ZVVloBu1WqNb1Nrb9?= =?iso-8859-1?Q?qsMxfOy3R1t4XzKzDO+EEYoDWeydd9sdx5dsWfBiU46I40qw/jLyCIby2a?= =?iso-8859-1?Q?gUxGRlC6QUArO5iFvEjdWS9oVI4XtGv6+AbdrdFWn2LtvwUzSe7fZsOmRS?= =?iso-8859-1?Q?ZbO5+kAqABEbvIReIxH9WJLetlhySE1FIb5ptBg2RolTEgz2da+YjgNLHi?= =?iso-8859-1?Q?PIoC9TdCTdKIBtYLms+yDIFRrraJAssMBdUa4D39MfUmhShiQKv8lmNDVu?= =?iso-8859-1?Q?2J1Vwr0sPt5Ih8r6C3ypVfHd/3PDQ7Z2JfwjG2+IwGYldgMyl4e1alQz33?= =?iso-8859-1?Q?M2a4oZug7HcB7UqgZZ7AHcAI6G0MotlaN+RV3QlJZwfUGteqqOWo5Ubzgp?= =?iso-8859-1?Q?Joajkf08IquikZ6eNKa0yzOAAsnSzZC6CqceXiNTTt489twb/MugfyJ9H9?= =?iso-8859-1?Q?Oa9c4s2YwCE3w7x04/gQ/Sg8ixVS1H0Gl8EWXBFAp439Be6JcfSiVTLrMz?= =?iso-8859-1?Q?fGC9QfsDTDxjvr7k29sWyCGz3hTEEI9e0sR3RQAl0L9t4sYxms3m75BrMN?= =?iso-8859-1?Q?Cwt9vBTNXLbmG2zbBSzVDwekVgmFH10Tt/7HVqDn+OKMNSYqzrzkb5xt9P?= =?iso-8859-1?Q?jG+OeOb24UmXgCyduVqbNvDCtGCL/eQd8OUNfm1fikBFd5X/CeBavXKlSB?= =?iso-8859-1?Q?9ZPuZXjpJ77gyO87oQNUDJG5u7SyIeXVyAIzw6p0CCO3H1ZG/yduvj6wyu?= =?iso-8859-1?Q?xizBYwF+7nIHNE4yzAF4JfLxar7OOsRNkR8RL+ca3ALxi9BDO+U4sl0FMk?= =?iso-8859-1?Q?SMTi/ePBa8HXMZibVIU6OkFDZSUrJ4RlhitqexGgEgwsiwkirLM4Mvy2Ht?= =?iso-8859-1?Q?BQ46nD+Rn44I+WBqj0PSwhkIY0s3wJgDdXshHpXJcqIx9/Ycaa/w6QXkFJ?= =?iso-8859-1?Q?N0z/3fX7Jw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7c22c419-4e91-4bde-e286-08de6042bbd1 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2026 21:01:26.9891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yWNn4ujydTEMKhEArIszIqKfSKjE6Djo6/xf90E9mldoiN2SlAlx0p9o7AdfUeajZJyt7dk+WFKaJMIalh4jzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6948 X-OriginatorOrg: intel.com X-DKIM: signer='intel.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-DKIM: signer='@intel.com' status='pass' reason='' X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: intel.com] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 On Fri, Jan 30, 2026 at 12:38:10PM -0800, Andrew Morton wrote: > On Fri, 30 Jan 2026 20:56:31 +0100 Thomas Hellstrm wrote: > > > > > > > > --- a/mm/hmm.c > > > > +++ b/mm/hmm.c > > > > @@ -674,6 +674,13 @@ int hmm_range_fault(struct hmm_range *range) > > > > return -EBUSY; > > > > ret = walk_page_range(mm, hmm_vma_walk.last, > > > > range->end, > > > > &hmm_walk_ops, > > > > &hmm_vma_walk); > > > > + /* > > > > + * Conditionally reschedule to let other work > > > > items get > > > > + * a chance to unlock device-private pages whose > > > > locks > > > > + * we're spinning on. > > > > + */ > > > > + cond_resched(); > > > > + > > > > /* > > > > * When -EBUSY is returned the loop restarts with > > > > * hmm_vma_walk.last set to an address that has > > > > not been stored > > > > > > If the process which is running hmm_range_fault() has > > > SCHED_FIFO/SHCED_RR then cond_resched() doesn't work. An explicit > > > msleep() would be better? > > > > Unfortunately hmm_range_fault() is typically called from a gpu > > pagefault handler and it's crucial to get the gpu up and running again > > as fast as possible. > > Would a millisecond matter? Regular old preemption will often cause > longer delays. > I think millisecond is too high. We are aiming to GPU page faults serviced in 10-15us of CPU time (GPU copy time varies based on size of fault / copy bus speed but still at most 200us). Matt > > Is there a way we could test for the cases where cond_resched() doesn't > > work and in that case instead call sched_yield(), at least on -EBUSY > > errors? > > kernel-internal sched_yield() was taken away years ago and I don't > think there's a replacement, particularly one which will cause a > realtime-policy task to yield to a non-rt-policy one. > > It's common for kernel code to forget that it could have realtime > policy - we probably have potential lockups in various places. > > I suggest you rerun your testcase with this patch using `chrt -r', see > if my speculation is correct. From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id yNHuCK0efWmoQhcAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 21:12:13 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 21:12:13 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlvmm-00000007NLF-3ZAf for hi@josie.lol; Fri, 30 Jan 2026 21:12:13 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 671803002743 for ; Fri, 30 Jan 2026 21:08:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADB92335579; Fri, 30 Jan 2026 21:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="PxHhylMn" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660F43074AB for ; Fri, 30 Jan 2026 21:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769807316; cv=none; b=u7VILk+WSHjLqIZ6dTLoywAuHOzr2XefSQvR48OsASfJnCQHXObZSbnRHl2RCsswgpdA0uw3t0PFAppoWX9lJAXyqZG5poS4aOnFZwSGW6+iwSR8v3PQCBvPWvdw65PKGlSIqom/n3t+TAT4Ljakqpa57zIDVm3d+K8/5CkjtEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769807316; c=relaxed/simple; bh=NpIWKTcK0nElwmNCWQsMcXiocFq60OtqNvc0TmYMhpw=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=Ghdt7RhdbghkfaJe2V6tf+LPidgspO70I4FiNraiBPu/pL1+Fqim75T4Oa9o4vVZ/DVCmB1CFeQM98gMgZKWKKSWPhOHNRm0Y+5+fBIrutOP21g1+TThrxOM4jxnCfEXDtqnqNi6Ygo7foelvv2xRXLXm5iuuqFtMeKGGoYF3W8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=PxHhylMn; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94782C4CEF7; Fri, 30 Jan 2026 21:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1769807315; bh=NpIWKTcK0nElwmNCWQsMcXiocFq60OtqNvc0TmYMhpw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PxHhylMnpGHxaYWvYQVZLPqe6RRG2x2B+ggYwZIU30b3Ew6cQLMcdWnHk4NxUd35q /DWbjjtUbgZoNxYCAIONothAH76NlkNHxJERU6WcPdb0qnRJIzB3EW/0MwUiv5SpA0 6Sy9LCXY/OF0lVDCO1Q6CM7gE1uBdrVtvcIGVElA= Date: Fri, 30 Jan 2026 13:08:35 -0800 From: Andrew Morton To: Matthew Brost Cc: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= , , Ralph Campbell , Christoph Hellwig , Jason Gunthorpe , "Jason Gunthorpe" , Leon Romanovsky , , , Subject: Re: [PATCH] mm/hmm: Fix a hmm_range_fault() livelock / starvation problem Message-Id: <20260130130835.10d004cd79d67c55b10def74@linux-foundation.org> In-Reply-To: References: <20260130144529.79909-1-thomas.hellstrom@linux.intel.com> <20260130100013.fb1ce1cd5bd7a440087c7b37@linux-foundation.org> <20260130123810.61dde600422a8fe01cff8296@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DKIM: signer='linux-foundation.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -0.8 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-0.8 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: linux-foundation.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -1.2 NICE_REPLY_A Looks like a legit reply (A) SpamTally: Final spam score: -7 On Fri, 30 Jan 2026 13:01:24 -0800 Matthew Brost wrote: > > > Unfortunately hmm_range_fault() is typically called from a gpu > > > pagefault handler and it's crucial to get the gpu up and running again > > > as fast as possible. > > > > Would a millisecond matter? Regular old preemption will often cause > > longer delays. > > > > I think millisecond is too high. We are aiming to GPU page faults > serviced in 10-15us of CPU time (GPU copy time varies based on size of > fault / copy bus speed but still at most 200us). But it's a rare case? Am I incorrect in believing that getting preempted will cause latencies much larger than this? > Matt > > > > Is there a way we could test for the cases where cond_resched() doesn't > > > work and in that case instead call sched_yield(), at least on -EBUSY > > > errors? > > > > kernel-internal sched_yield() was taken away years ago and I don't > > think there's a replacement, particularly one which will cause a > > realtime-policy task to yield to a non-rt-policy one. > > > > It's common for kernel code to forget that it could have realtime > > policy - we probably have potential lockups in various places. > > > > I suggest you rerun your testcase with this patch using `chrt -r', see > > if my speculation is correct. Please? From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id eBhQKb0kfWmfKRoAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 21:38:05 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 21:38:05 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlwBp-000000088NG-1EoB for hi@josie.lol; Fri, 30 Jan 2026 21:38:05 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 03E13301544E for ; Fri, 30 Jan 2026 21:38:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20B5F34FF54; Fri, 30 Jan 2026 21:38:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WsjlDWcu" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E88CA346FB7; Fri, 30 Jan 2026 21:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769809083; cv=none; b=tdqtOhonO3OFFW2qohfDZN2IOaI6EwLbAa2zhbS4llSja+OnFIiIyd7NLjSibFPEjgS3kq+/yfxTPuMVnt6NhspIpAZ3Ul3PPcBe+lbBZ+W1gSWvUfZwPYqIWd1bmx2SmnkdjQLbTPZu8FTWn56B8/HrG5Rd5ihFZU4BMYwLQjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769809083; c=relaxed/simple; bh=hG/FMFjw+Bsjjqf6+oGgdTmtU6Rj6R39FcIG0oxjB4g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=S7A8kagxYchLSMT+yxQGfSk+pkt0HIEkwOO2wP8zxH/C2HUJX5laoNZxThE0/8IPSR5W9eEkH4juX08FaCsg1kDe3E05zIFkjTf6XdDgTPcTHrK9jSBJnCBcd6G9x7nrw4+8sfGGw5N97kk+hBSE4noL6cYetNoRN7mOMd8R2a0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WsjlDWcu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC43AC4CEF7; Fri, 30 Jan 2026 21:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769809082; bh=hG/FMFjw+Bsjjqf6+oGgdTmtU6Rj6R39FcIG0oxjB4g=; h=From:Date:Subject:To:Cc:From; b=WsjlDWcuspRPbESmBhstfkK56VpUEZUT92aisw++uiwRD4OKUnC2X8DKECtzIiUP2 2tqIyEXoCUlglp1bnkKp9uAyMt0TJJ9MX1XKZK3F65QJyn7Y+lR5Lk2Kl8xg+h5Sb8 aZrKCBq+PZbswnML9coHYmWvjHmP6wOwpvGF1s1Kpy76dl6r56jnfrpcpAMpNJZTKA NMxbjf2zXMXI/NM/zMDXS8E3iW/V4Rns4kurM00r9Te84Qfirk9IYxT0DPPEJEmpHf tzKqUuoCRxGpAy3NBvUnu/lUYHy+Q8V3d5A4g30YVwfx61wYqt5HifZ48C7+2ccE9X ugSdkZ5dlNQ5Q== From: Nathan Chancellor Date: Fri, 30 Jan 2026 14:37:47 -0700 Subject: [PATCH] kbuild: Do not run kernel-doc when building external modules Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260130-kbuild-skip-kernel-doc-extmod-v1-1-58443d60131a@kernel.org> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMQQ6CMBAF0KuQWTtJqQjGqxgWtv3qWGxJC4SEc HerLt/mbZSRBJku1UYJi2SJoaA+VGSft/AAiysmrXSr6qNib2YZHGcvI3ukgIFdtIx1ekfHumt P5wad0UZROcaEu6y//9r/nWfzgp2+Ke37By0QqAGBAAAA X-Change-ID: 20260130-kbuild-skip-kernel-doc-extmod-276584e7b2b0 To: Nathan Chancellor , Nicolas Schier , Jonathan Corbet Cc: linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Rong Zhang , Mauro Carvalho Chehab X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=3283; i=nathan@kernel.org; h=from:subject:message-id; bh=hG/FMFjw+Bsjjqf6+oGgdTmtU6Rj6R39FcIG0oxjB4g=; b=owGbwMvMwCUmm602sfCA1DTG02pJDJm1KjvqVhdnRG95sMfWl01Q86Jq6XKWE2Vu3LqZr2oPT fiqXu3YUcrCIMbFICumyFL9WPW4oeGcs4w3Tk2CmcPKBDKEgYtTACbSls3wh7d8m2vrhFfH6ybw WH9bukDgxqkF5y7wz5Zgtazweekue5yRob2lT54n5/QSWb4n/OEnGCyPPU7NL7EJvtQvLcjm/ng CHwA= X-Developer-Key: i=nathan@kernel.org; a=openpgp; fpr=2437CB76E544CB6AB3D9DFD399739260CB6CB716 X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: kernel-doc.py] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 After commit 778b8ebe5192 ("docs: Move the python libraries to tools/lib/python"), building an external module with any value of W= against the output of install-extmod-build fails with: $ make -C /usr/lib/modules/6.19.0-rc7-00108-g4d310797262f/build M=$PWD W=1 make: Entering directory '/usr/lib/modules/6.19.0-rc7-00108-g4d310797262f/build' make[1]: Entering directory '...' CC [M] ... Traceback (most recent call last): File "/usr/lib/modules/6.19.0-rc7-00108-g4d310797262f/build/scripts/kernel-doc.py", line 339, in main() ~~~~^^ File "/usr/lib/modules/6.19.0-rc7-00108-g4d310797262f/build/scripts/kernel-doc.py", line 295, in main from kdoc.kdoc_files import KernelFiles # pylint: disable=C0415 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ModuleNotFoundError: No module named 'kdoc' scripts/lib was included in the build directory from find_in_scripts but after the move to tools/lib/python, it is no longer included, breaking kernel-doc.py. Commit eba6ffd126cd ("docs: kdoc: move kernel-doc to tools/docs") breaks this even further by moving kernel-doc outside of scripts as well, so it cannot be found when called by cmd_checkdoc. $ make -C /usr/lib/modules/6.19.0-rc7-next-20260130/build M=$PWD W=1 make: Entering directory '/usr/lib/modules/6.19.0-rc7-next-20260130/build' make[1]: Entering directory '...' CC [M] ... python3: can't open file '/usr/lib/modules/6.19.0-rc7-next-20260130/build/tools/docs/kernel-doc': [Errno 2] No such file or directory While kernel-doc could be useful for external modules, it is more useful for in-tree documentation that will be build and included in htmldocs. Rather than including it in install-extmod-build, just skip running kernel-doc for the external module build. Cc: stable@vger.kernel.org Fixes: 778b8ebe5192 ("docs: Move the python libraries to tools/lib/python") Reported-by: Rong Zhang Closes: https://lore.kernel.org/20260129175321.415295-1-i@rong.moe/ Reviewed-by: Mauro Carvalho Chehab Signed-off-by: Nathan Chancellor --- This is an alternative to Rong's proposed fix for the first error: https://lore.kernel.org/20260129175321.415295-1-i@rong.moe/ I noticed the second one by inspection of -next and further testing. --- scripts/Makefile.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 5037f4715d74..f01d7957edf7 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -166,11 +166,13 @@ else ifeq ($(KBUILD_CHECKSRC),2) cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< endif +ifeq ($(KBUILD_EXTMOD),) ifneq ($(KBUILD_EXTRA_WARN),) cmd_checkdoc = PYTHONDONTWRITEBYTECODE=1 $(PYTHON3) $(KERNELDOC) -none $(KDOCFLAGS) \ $(if $(findstring 2, $(KBUILD_EXTRA_WARN)), -Wall) \ $< endif +endif # Compile C sources (.c) # --------------------------------------------------------------------------- --- base-commit: 63804fed149a6750ffd28610c5c1c98cce6bd377 change-id: 20260130-kbuild-skip-kernel-doc-extmod-276584e7b2b0 Best regards, -- Nathan Chancellor From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id YCjAFsUrfWkjaiAAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 22:08:05 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 22:08:05 +0000 Received: from sto.lore.kernel.org ([172.232.135.74]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlweq-00000008zwC-2rrO for hi@josie.lol; Fri, 30 Jan 2026 22:08:05 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id DBC953006145 for ; Fri, 30 Jan 2026 22:08:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9F3ED302742; Fri, 30 Jan 2026 22:08:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fuFO6BzM" X-Original-To: stable@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 429FE2D23B6 for ; Fri, 30 Jan 2026 22:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769810881; cv=none; b=tyZB6CzjredteGVJTde09u1pKzt4JTivl70Ea894x1Z2OspOys8F8aL/LZZvXme2tyS2DETMqZKjzNhgiRQmYIEqdf3vbIUAhwUJ+VzrO7pqjZUF3tU1tst0BxBSbecLQ3ksZnRlRoknwng8aX8XRIMxkwqpMKEcvOpA1vyMEqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769810881; c=relaxed/simple; bh=Dg+h7Tev3AkPmB+X8QR61HHPpOAMika6IoT9ZBEYiNI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hdSAwPkR9lKDJvmp1J+JwHQwPquQo6b7dKm+RQfmvl2rWuMiUTz15iUc666G2NqTghQjtrQ/6Rdt8Mlv7ywAH7xpBMOxuTeWd/CutJDS/Jvfb246AVG66PXwmj/McabPTmPxB57FppnJGyDcIFGpd4S0jpuEUE5DREmEGVYOrs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fuFO6BzM; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769810880; x=1801346880; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Dg+h7Tev3AkPmB+X8QR61HHPpOAMika6IoT9ZBEYiNI=; b=fuFO6BzMsrTwqeJIejHk/SvGbTCn3xkmUNCm7uB6uZ52QiZBJwyAbUKV OVLlV4uz0OML62jdWCMOv01pid/R1kvd0EjmM4QxmNJRoZ4TXWcOkboVU 3xZ8tfjJbHXwqhZ8BIYqKpP/XS7RPOOyeW9W29lmM1KiJhsr+V5ZE7lmK NTYukm98sbfL4c+qrMXakAhOvBbNBPei6rgTi7cUcwZ/kSvXM2v6hntSQ 9kSJ7aXvAAPx4lNc+tLonBTVbVbL4G+vobhIm+WnNa8MKifLk8HUKSKT+ 4kvjX7EwaNZWeedIW9iCFj6OcWTMSvGo5KLS93/v155ClrW08xwdPFeQr w==; X-CSE-ConnectionGUID: 7czJqK+ATd+FatyPsfiI4Q== X-CSE-MsgGUID: 4JgZ45zDQyWnjZjWIUjCDQ== X-IronPort-AV: E=McAfee;i="6800,10657,11687"; a="81800203" X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="81800203" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 14:08:00 -0800 X-CSE-ConnectionGUID: DionjiCNSe2Jtsk607jDBw== X-CSE-MsgGUID: OBuSjlPCRnGavi+Z2H5EJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="213459060" Received: from dut6094bmgfrd.fm.intel.com ([10.80.55.45]) by fmviesa005.fm.intel.com with ESMTP; 30 Jan 2026 14:07:59 -0800 From: Jia Yao To: intel-xe@lists.freedesktop.org Cc: Jia Yao , stable@vger.kernel.org, Mathew Alwin , Michal Mrozek , Matthew Brost , Matthew Auld Subject: [PATCH v3] drm/xe/uapi: Reject coh_none PAT index for CPU cached memory in madvise Date: Fri, 30 Jan 2026 22:07:49 +0000 Message-ID: <20260130220750.573838-1-jia.yao@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260129000147.339361-1-jia.yao@intel.com> References: <20260129000147.339361-1-jia.yao@intel.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='intel.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-DKIM: signer='@intel.com' status='pass' reason='' X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: intel.com] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.232.135.74 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 Add validation in xe_vm_madvise_ioctl() to reject PAT indices with XE_COH_NONE coherency mode when applied to CPU cached memory. Using coh_none with CPU cached buffers is a security issue. When the kernel clears pages before reallocation, the clear operation stays in CPU cache (dirty). GPU with coh_none can bypass CPU caches and read stale sensitive data directly from DRAM, potentially leaking data from previously freed pages of other processes. This aligns with the existing validation in vm_bind path (xe_vm_bind_ioctl_validate_bo). v2(Matthew brost) - Add fixes - Move one debug print to better place v3(Matthew Auld) - Should be drm/xe/uapi - More Cc Fixes: ada7486c5668 ("drm/xe: Implement madvise ioctl for xe") Cc: stable@vger.kernel.org # v6.18 Cc: Mathew Alwin Cc: Michal Mrozek Cc: Matthew Brost Cc: Matthew Auld Signed-off-by: Jia Yao --- drivers/gpu/drm/xe/xe_vm_madvise.c | 47 ++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_vm_madvise.c b/drivers/gpu/drm/xe/xe_vm_madvise.c index add9a6ca2390..50b82e821da7 100644 --- a/drivers/gpu/drm/xe/xe_vm_madvise.c +++ b/drivers/gpu/drm/xe/xe_vm_madvise.c @@ -352,6 +352,44 @@ static void xe_madvise_details_fini(struct xe_madvise_details *details) drm_pagemap_put(details->dpagemap); } +static bool check_pat_args_are_sane(struct xe_device *xe, + struct xe_vmas_in_madvise_range *madvise_range, + u16 pat_index) +{ + u16 coh_mode = xe_pat_index_get_coh_mode(xe, pat_index); + int i; + + /* + * Using coh_none with CPU cached buffers is not allowed. + * Otherwise CPU page clearing can be bypassed, which is a + * security issue. GPU can directly access system memory and + * bypass CPU caches, potentially reading stale sensitive data + * from previously freed pages. + */ + if (coh_mode != XE_COH_NONE) + return true; + + for (i = 0; i < madvise_range->num_vmas; i++) { + struct xe_vma *vma = madvise_range->vmas[i]; + struct xe_bo *bo = xe_vma_bo(vma); + + if (bo) { + /* BO with WB caching + COH_NONE is not allowed */ + if (XE_IOCTL_DBG(xe, bo->cpu_caching == DRM_XE_GEM_CPU_CACHING_WB)) + return false; + /* Imported dma-buf without caching info, assume cached */ + if (XE_IOCTL_DBG(xe, !bo->cpu_caching)) + return false; + } else if (XE_IOCTL_DBG(xe, xe_vma_is_cpu_addr_mirror(vma)) || + xe_vma_is_userptr(vma)) { + /* System memory (userptr/SVM) is always CPU cached */ + return false; + } + } + + return true; +} + static bool check_bo_args_are_sane(struct xe_vm *vm, struct xe_vma **vmas, int num_vmas, u32 atomic_val) { @@ -442,6 +480,14 @@ int xe_vm_madvise_ioctl(struct drm_device *dev, void *data, struct drm_file *fil if (err || !madvise_range.num_vmas) goto madv_fini; + if (args->type == DRM_XE_MEM_RANGE_ATTR_PAT) { + if (!check_pat_args_are_sane(xe, &madvise_range, + args->pat_index.val)) { + err = -EINVAL; + goto free_vmas; + } + } + if (madvise_range.has_bo_vmas) { if (args->type == DRM_XE_MEM_RANGE_ATTR_ATOMIC) { if (!check_bo_args_are_sane(vm, madvise_range.vmas, @@ -485,6 +531,7 @@ int xe_vm_madvise_ioctl(struct drm_device *dev, void *data, struct drm_file *fil err_fini: if (madvise_range.has_bo_vmas) drm_exec_fini(&exec); +free_vmas: kfree(madvise_range.vmas); madvise_range.vmas = NULL; madv_fini: -- 2.43.0 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 0CWUJbIsfWmt+SAAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 22:12:02 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 22:12:02 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlwig-000000096fR-0srO for hi@josie.lol; Fri, 30 Jan 2026 22:12:02 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id D5AA2300D46C for ; Fri, 30 Jan 2026 22:12:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C15237E30D; Fri, 30 Jan 2026 22:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="2lLwCJuD"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="7O9jDY4s" X-Original-To: stable@vger.kernel.org Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D22155757; Fri, 30 Jan 2026 22:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769811119; cv=none; b=NCPp5YLdfY8OGPiHXiYxFoDBFXKE4MC1N+Of2OwK62GZ+icd/iZpaazdedELADPf1lx4saG/yQfen+5lLAJudTk/+NLpMtuDaYcV4PCOPmKAN8NWWqZntUdOvXqpPrhoR/TBV3scS2gTEUhbne5z9MB7b6JWsAnTqpOIH5TNTt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769811119; c=relaxed/simple; bh=331GDWlK9opFl6puEIjQ1O+p808+RqqqgANR0ooSlgo=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=hkXDh3NZAKbzEmI0O5xoVZM4ogfBZrEEwbw2rsKzGtAhxQinmCI56/Ha4IHPmZOxHLFOk9+azYvPj13tVrEjAPpeR1Cl2xswf4uAXktgRrYAWWUhUVWMeHoYgDBjDzdEbBOHSurdrz4r9CWp1w+0c60Dy04ilatprnOFUkJyo14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=2lLwCJuD; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=7O9jDY4s; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Fri, 30 Jan 2026 22:11:55 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1769811116; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YEjHSkuExPun8eMncOcQnDc/DmWjBdF0RVlL6mI6Y2E=; b=2lLwCJuD15Om1AsP4acm4XhmXGPfUzBavegXC97tABVedi/oEEti7A483zhsESvqnXCvij ZKCJDExR9YBjw55NclRYBOr1XIgfwFfFjEoFQ0GCKgXRKSNOg+wYvCfZq3gN5x5bpKvDcf y3RJruRb5ON3In1oQsldKRwx8CA88aZQtVPzEF0J+I6SuxRPEOCnbLHpGNJJORZGQS5xIg YVGZ+kSPTgJC84ZKKy6O7KdCZofBRLu099UZncWlSwW8SaaXBDNdJ1hvdO4iFDYBBt3r7O Tu0mxI2lY7P2Ew/9IMCc7cvINyeNsg8BQWzvWBWcavjPA/1U0xDPKLU+EPgqBA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1769811116; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YEjHSkuExPun8eMncOcQnDc/DmWjBdF0RVlL6mI6Y2E=; b=7O9jDY4s5k9lbVr2SwT3XHOkcTdEHLZET6IQjeBryenXX5DS+dTkOijXYqdvKRNzcCiKn8 imSFn/b0nTW0giCg== From: "tip-bot2 for Steven Rostedt" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: perf/urgent] perf: sched: Fix perf crash with new is_user_task() helper Cc: Guenter Roeck , "Steven Rostedt (Google)" , "Peter Zijlstra (Intel)" , stable@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260129102821.46484722@gandalf.local.home> References: <20260129102821.46484722@gandalf.local.home> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <176981111509.2495410.12577775645614090252.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-DKIM: signer='linutronix.de' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: linutronix.de] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 76ed27608f7dd235b727ebbb12163438c2fbb617 Gitweb: https://git.kernel.org/tip/76ed27608f7dd235b727ebbb12163438c2f= bb617 Author: Steven Rostedt AuthorDate: Thu, 29 Jan 2026 10:28:21 -05:00 Committer: Peter Zijlstra CommitterDate: Fri, 30 Jan 2026 23:06:07 +01:00 perf: sched: Fix perf crash with new is_user_task() helper In order to do a user space stacktrace the current task needs to be a user task that has executed in user space. It use to be possible to test if a task is a user task or not by simply checking the task_struct mm field. If it was non NULL, it was a user task and if not it was a kernel task. But things have changed over time, and some kernel tasks now have their own mm field. An idea was made to instead test PF_KTHREAD and two functions were used to wrap this check in case it became more complex to test if a task was a user task or not[1]. But this was rejected and the C code simply checked the PF_KTHREAD directly. It was later found that not all kernel threads set PF_KTHREAD. The io-uring helpers instead set PF_USER_WORKER and this needed to be added as well. But checking the flags is still not enough. There's a very small window when a task exits that it frees its mm field and it is set back to NULL. If perf were to trigger at this moment, the flags test would say its a user space task but when perf would read the mm field it would crash with at NULL pointer dereference. Now there are flags that can be used to test if a task is exiting, but they are set in areas that perf may still want to profile the user space task (to see where it exited). The only real test is to check both the flags and the mm field. Instead of making this modification in every location, create a new is_user_task() helper function that does all the tests needed to know if it is safe to read the user space memory or not. [1] https://lore.kernel.org/all/20250425204120.639530125@goodmis.org/ Fixes: 90942f9fac05 ("perf: Use current->flags & PF_KTHREAD|PF_USER_WORKER in= stead of current->mm =3D=3D NULL") Closes: https://lore.kernel.org/all/0d877e6f-41a7-4724-875d-0b0a27b8a545@roec= k-us.net/ Reported-by: Guenter Roeck Signed-off-by: Steven Rostedt (Google) Signed-off-by: Peter Zijlstra (Intel) Tested-by: Guenter Roeck Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260129102821.46484722@gandalf.local.home --- include/linux/sched.h | 5 +++++ kernel/events/callchain.c | 2 +- kernel/events/core.c | 6 +++--- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index da01335..5f00b5e 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1776,6 +1776,11 @@ static __always_inline bool is_percpu_thread(void) (current->nr_cpus_allowed =3D=3D 1); } =20 +static __always_inline bool is_user_task(struct task_struct *task) +{ + return task->mm && !(task->flags & (PF_KTHREAD | PF_USER_WORKER)); +} + /* Per-process atomic flags. */ #define PFA_NO_NEW_PRIVS 0 /* May not gain new privileges. */ #define PFA_SPREAD_PAGE 1 /* Spread page cache over cpuset */ diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c index 1f65895..9d24b6e 100644 --- a/kernel/events/callchain.c +++ b/kernel/events/callchain.c @@ -246,7 +246,7 @@ get_perf_callchain(struct pt_regs *regs, bool kernel, boo= l user, =20 if (user && !crosstask) { if (!user_mode(regs)) { - if (current->flags & (PF_KTHREAD | PF_USER_WORKER)) + if (!is_user_task(current)) goto exit_put; regs =3D task_pt_regs(current); } diff --git a/kernel/events/core.c b/kernel/events/core.c index a0fa488..8cca800 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -7460,7 +7460,7 @@ static void perf_sample_regs_user(struct perf_regs *reg= s_user, if (user_mode(regs)) { regs_user->abi =3D perf_reg_abi(current); regs_user->regs =3D regs; - } else if (!(current->flags & (PF_KTHREAD | PF_USER_WORKER))) { + } else if (is_user_task(current)) { perf_get_regs_user(regs_user, regs); } else { regs_user->abi =3D PERF_SAMPLE_REGS_ABI_NONE; @@ -8100,7 +8100,7 @@ static u64 perf_virt_to_phys(u64 virt) * Try IRQ-safe get_user_page_fast_only first. * If failed, leave phys_addr as 0. */ - if (!(current->flags & (PF_KTHREAD | PF_USER_WORKER))) { + if (is_user_task(current)) { struct page *p; =20 pagefault_disable(); @@ -8215,7 +8215,7 @@ perf_callchain(struct perf_event *event, struct pt_regs= *regs) { bool kernel =3D !event->attr.exclude_callchain_kernel; bool user =3D !event->attr.exclude_callchain_user && - !(current->flags & (PF_KTHREAD | PF_USER_WORKER)); + is_user_task(current); /* Disallow cross-task user callchains. */ bool crosstask =3D event->ctx->task && event->ctx->task !=3D current; bool defer_user =3D IS_ENABLED(CONFIG_UNWIND_USER) && user && From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id KDvSBqwvfWmqCyIAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 22:24:44 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 22:24:44 +0000 Received: from sin.lore.kernel.org ([104.64.211.4]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlwux-00000009SoE-2cLq for hi@josie.lol; Fri, 30 Jan 2026 22:24:44 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sin.lore.kernel.org (Postfix) with ESMTP id C32E43009F37 for ; Fri, 30 Jan 2026 22:24:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7E40838885F; Fri, 30 Jan 2026 22:24:32 +0000 (UTC) X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56FD53859C0; Fri, 30 Jan 2026 22:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769811872; cv=none; b=MaWiV50djhaxxfToi8nMe4hurdEeBLzAqmZ1DUfdlq7ERo2Del0QH88TPkl4dZzFbFAsjJ/ouOo3MfNbvFK/5vTAXwIQ7vEp07V03eQGltTWgtO0BnYC3CZTPV6hivoAOlMsoMpuyQ55rBtR66vV9KWVmQ3K1usQV31y8SJCgZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769811872; c=relaxed/simple; bh=sGECo6MXaIdtjWqh9SaFDp75VmBvPj+LEJ+7DWp6AZ4=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=F3FPUQtK17oRDhXDAIc8M0rltZzIQxj0T4eO6jOAwEov+RyRrZvm2/uREQGxU3C6K0iyMQXRI1jccMIRApbMNxgXjQKKf2fqOKUcbwt5KLGVf1uaJCDmgwlc/8sOnm4j9vxsX5jxESmHS6AgLk+t3ICyZ6HrUcjO+ZhGMSLuCEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7915C4AF09; Fri, 30 Jan 2026 22:24:31 +0000 (UTC) Received: by venus (Postfix, from userid 1000) id B57D7180523; Fri, 30 Jan 2026 23:24:27 +0100 (CET) From: Sebastian Reichel To: Francesco Dolcini , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emanuele Ghidoli Cc: Emanuele Ghidoli , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <20260130071208.1184239-1-ghidoliemanuele@gmail.com> References: <20260130071208.1184239-1-ghidoliemanuele@gmail.com> Subject: Re: [PATCH v1] power: reset: tdx-ec-poweroff: fix restart Message-Id: <176981186772.331784.8124433525678638333.b4-ty@collabora.com> Date: Fri, 30 Jan 2026 23:24:27 +0100 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [104.64.211.4 listed in list.dnswl.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 On Fri, 30 Jan 2026 08:11:35 +0100, Emanuele Ghidoli wrote: > During testing, restart occasionally failed on Toradex modules. > > The issue was traced to an interaction between the EC-based reset/poweroff > handler and the PSCI restart handler. While the embedded controller is > resetting or powering off the module, the PSCI code may still be invoked, > triggering an I2C transaction to the PMIC. This can leave the PMIC I2C > in a frozen state. > > [...] Applied, thanks! [1/1] power: reset: tdx-ec-poweroff: fix restart commit: 562357a6310f79e45844c3e980d410a1e8e02ce6 Best regards, -- Sebastian Reichel From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id MDV5OhI2fWkdhSIAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 22:52:02 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 22:52:03 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlxLO-0000000ADg1-2q92 for hi@josie.lol; Fri, 30 Jan 2026 22:52:02 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 00895300AC33 for ; Fri, 30 Jan 2026 22:52:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33B6A359FA4; Fri, 30 Jan 2026 22:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UBuum1Km" X-Original-To: io-uring@vger.kernel.org Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5213358D38 for ; Fri, 30 Jan 2026 22:51:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769813521; cv=none; b=pFrRQC33rNQ4A5LWdD6ReVvDO1Oummo4eb/cHgVNOtkzdDN3UDV6zJ1cyTInF/v95CKVHLNiRbaNfcbNsAmRyxDE0f3bqD5zRzN8O+4gS/wsslOAQ3G/fFFy37C12rP9zhbn8eGDN6DOTvoM2TfY+g8X9K3haxnyjUrnvEBWhEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769813521; c=relaxed/simple; bh=KcUQ1q2ALIp6GQbsuyiFX7GWULQTAiWrMXNKUDp6gDA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kkdMtmPgyuYBqKgKUSBNlgUun/vtTqps+eCZk3fh6xY2/aYXLnqiNKZrgl5OzjnxP3ajXUd4TZX7T+20+ToYofK2Gk3P9HsihwvvwEiBK+V9lIjhNlHwR4/PFVQIODCoB2j7M8AFFzCGa6bbz4WnZjY2vw0ez1PEB77fMRDjPF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UBuum1Km; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-385c6c727fcso25116241fa.3 for ; Fri, 30 Jan 2026 14:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769813518; x=1770418318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZkVCe2Fm0X1zwm2m79SvkIhPjHfte2ufPAVZoEONEas=; b=UBuum1KmS9tiL6vqWLWPTjVlobULd3p9mqcch58HHMBuzMbU7j52fZ/IErxZl/oZmv O86P8LYvk8F6s9MHUO9h3UyaYe7orrxMTvNopn4CqxS/Ox3faV0AIGYPhKdrHRmL5jse YStpseRYpnGx4sSPVfU/n24mXW/tz/g737go6xx9KSGMGgS8jBCWwui222CfbaMz/5Ch h1HrrFwR7m4p+mltEeUOAml+z1khtZlGArtyI4hzH5ZZYws4qIXnbfMTC5086bWsGdvF nbl83qdcdO1Q60QRY42xerVxVhGMx6pDTKwlEiG3kThxYMZNr2P9yr+EyZKKfDjucZd9 ts2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769813518; x=1770418318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZkVCe2Fm0X1zwm2m79SvkIhPjHfte2ufPAVZoEONEas=; b=PKQZ527i6O5ZykfUU5b4DsVwDnUa1CHVMo1+2+CIf/04NNexT7wBQS4SZJXG6MBHXO YqfUk8yqszofEJTUnrvl+BamOPRGYZOgJSqMS7R8JWwFD5MFxkgGSTwG+WCmyjV+c8dc gxzey17oc9G/D7dQwXxYgV/uftqMbr0gJsa9m9itc8eqKm6GOc1joamkoH7OfD5stgIG PebBByFJFzRvcBY+JHgYm5No7+Da5cMqrc/b/dx6+/lxKBUSQkVw/86zmeWiKtDuuJKr yciGmHqcMrtFvWl+qzJxIf7KoFb0+d2sXK0YHvbu9WtfMynWxyyHt9V3EP9Ki4QbPIP4 bJ7A== X-Forwarded-Encrypted: i=1; AJvYcCVnfAa0uxr1kMKa3Tz7iU+6conomE3nPztmBh9o/c5D1Y2HWjtJGxzhFb/BDAo0wdS2WHktoLTBcw==@vger.kernel.org X-Gm-Message-State: AOJu0YzbVldd/4UF5iTSMApRuLtDdiq8pmeyop3K0B9GF4gZNqBlWEz5 2yt+IOr96/qEv7Clhy6vFfW+d2s4MCQpNgL8rUfH+RXazt2DcgMgOZu1n35+HQ== X-Gm-Gg: AZuq6aK/Sg+Zg3GPmbrL8h4Lqb0z+rD+OLaixM7Z7VAPDhVMbI0neAifUNEXjWDReUG FmzVDG0ph28If0rUG7+xBGaC7hk7WcfGikTdB4JPiCyGCQhCTIz6xlY7FTZ1c9UcurbTUwNr+67 zaQoU7yLOu7v08h97wxWYQuK9//iEv5I7/+r+9hqwYiY56k7WxpHGYzEpXIwLoj9lF1ATYR5w2E A9lKR40Ui8o6NKFVGZJUof0mmo89qBIXgOEUVhr3hcpt5Zxx1g0bqApXuLKbg7XOgLzx+f1yrRg MiPdCViPM1V8ydLHfrb7jEA9lcGt6ZqCRpTO5gWF1H/zwR4SgCct+s0UCbTopdPpmiKFKRGoo+A z9KVd3wGL0Owv7r2WDnwtV9diIAC5pTTI6EnFFNREvzmn21WEcTf6UmKvDSyk4jA2ne015fv944 KnwX4xjQgAq5RxkjjGaAjkvebYCtEqDUkUAjyjV1+jyJj7dQfZ3BXe X-Received: by 2002:a05:6000:2004:b0:42f:b690:6788 with SMTP id ffacd0b85a97d-435f3a6baa6mr6239935f8f.10.1769806350269; Fri, 30 Jan 2026 12:52:30 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e267aad1sm21831845e9.15.2026.01.30.12.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 12:52:29 -0800 (PST) Date: Fri, 30 Jan 2026 20:52:27 +0000 From: David Laight To: Breno Leitao Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , metze@samba.org, axboe@kernel.dk, Stanislav Fomichev , io-uring@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH net-next RFC 0/3] net: move .getsockopt away from __user buffers Message-ID: <20260130205227.6fb1d9ad@pumpkin> In-Reply-To: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> References: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [david.laight.linux[at]gmail.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On Fri, 30 Jan 2026 10:46:16 -0800 Breno Leitao wrote: > Currently, .getsockopt callback cannot be called with kernel buffers > because it requires userspace addresses: > > int (*getsockopt)(struct socket *sock, int level, > int optname, char __user *optval, int __user *optlen); > > This prevents kernel callers (io_uring, BPF, etc) from using getsockopt > on levels other than SOL_SOCKET, since they pass kernel pointers rather > than __user pointers. I had thoughts about this as well. I think using iov_iter is over the top and may have measurable performance impact for some paths. I think the first thing to do is sort out 'optlen'. There is absolutely no reason for the user pointer being passed into all the per-protocol functions. (and the code that changes that use sockptr_t are just stupid...) The system call wrapper can do the user copies, it can also suppress the write if the value is unchanged (which matters with clac/slac). The obvious change would be to pass the length itself and make the return value -ERRNO or the size. The annoyance is the few places that want to return an error and change optlen. That might be best addresses by something like: #define GETSOCKOPT_RVAL(errval, size) (1 << 31 | (errval) << 20 | (size)) which would get picked in the rval < 0 path. It would also let 'return 0' mean 'don't change the size' requiring a special return for the one (or two?) places that want to set the size to zero and return success. The length passed should also be 'unsigned int' - with a check for negative values in the system call wrapper. (There are many broken drivers that treat negative lengths as 4.) There is not much point making the 'optval' parameter more than a structure of a user and kernel address - one of which will be NULL. (This is safer than sockptr_t's discriminant union.) You can't police the length because it is sometimes only the length of a header (and in some recent code as well). I have looked at some of this change - it is enormous. David > > Following Linus' suggestion [0], this series introduces a wrapper > around iov_iter (sockopt_t) and a temporary getsockopt_iter callback: > > typedef struct sockopt { > struct iov_iter iter; > int optlen; > } sockopt_t; > > Note: optlen was not suggested by Linus' but I believe it is needed, given > random values could be passed by protocols back to userspace. > > And the callback becomes: > > int (*getsockopt_iter)(struct socket *sock, int level, > int optname, sockopt_t *opt); > > The sockopt_t structure encapsulates: > - An iov_iter for reading/writing option data (works with both user > and kernel buffers) > - An optlen field for buffer size (input) and returned data size > (output) > > The plan is to enable getsockopt to leverage kernel buffers initially, > but then move .setsockopt from sockptr_t into this as well. > > This series: > > 1. Adds the sockopt_t type and getsockopt_iter callback to proto_ops > 2. Adds do_sock_getsockopt_iter() helper that prefers getsockopt_iter > 3. Converts one protocol (netlink) to use getsockopt_iter as a proof of > concept > > This is what I have in mind for this work stream, to make it more > digestible: > > * Keep the temporary getsockopt_iter callback allows protocols to > migrate gradually. > * Once all protocols have been converted, getsockopt can be removed and > getsockopt_iter renamed back to getsockopt with the new API. > * Once the protocols are converted, the SOL_SOCKET limitation in > io_uring_cmd_getsockopt() will be removed. > * Covert setsockopt() to also use a similar strategy, moving it away > from sockptr_t. > * Remove sockptr_t in the front end (do_sock_getsockopt(), > io_uring_cmd_getsockopt()) and start with sockopt_t (instead of > sockptr_t) in __sys_getsockopt() and io_uring_cmd_getsockopt() > > Link: https://lore.kernel.org/all/CAHk-=whmzrO-BMU=uSVXbuoLi-3tJsO=0kHj1BCPBE3F2kVhTA@mail.gmail.com/ [0] > --- > Breno Leitao (3): > net: add getsockopt_iter callback to proto_ops > net: prefer getsockopt_iter in do_sock_getsockopt > netlink: convert to getsockopt_iter > > include/linux/net.h | 19 +++++++++++++++++++ > net/netlink/af_netlink.c | 22 ++++++++++++---------- > net/socket.c | 42 +++++++++++++++++++++++++++++++++++++++--- > 3 files changed, 70 insertions(+), 13 deletions(-) > --- > base-commit: 4d310797262f0ddf129e76c2aad2b950adaf1fda > change-id: 20260130-getsockopt-9f36625eedcb > > Best regards, > -- > Breno Leitao > > From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id aEZGEMg3fWm4wiUAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 22:59:20 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 22:59:20 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlxSR-0000000APwb-3vxx for hi@josie.lol; Fri, 30 Jan 2026 22:59:20 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 8C8083013A56 for ; Fri, 30 Jan 2026 22:59:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC5B135B63C; Fri, 30 Jan 2026 22:59:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="QTk5ow9G" X-Original-To: stable@vger.kernel.org Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79C7135A95A; Fri, 30 Jan 2026 22:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769813951; cv=none; b=nTNj6OMllJZ6bE/hD8Oc2Df3UFd1ylH1u4jcVctTkg6HWwxQtuPfHYPQUSiEJHGqsZcoG5/oH4rDK1oc0IhKQS3ohUWUzUqjaYT1Y/FXZd7QIfvQHZPzLEik32xNPzX9cOhtSZ04Vrc1RF9Bgkq8RYQJ5zxHNfLiz/REdg1Kn/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769813951; c=relaxed/simple; bh=pGZCdfTqJZsczKLbgP8aETuCtwVHrNt9P39BRiViQ1g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qjQqLoRr6g4fvpxcq0r0MheajFzPM2dsaDwuhZYKoizfzs9lWi3NDGDWkjEoVgQmQtLfi38s7ZoEXDKvAiVxUaXeJGAfb/E0E+mQit4iH5DGSBuxXfO09Zt8YqDi3Di4vM4nJzwv+5MeT77GfcK19EzQgmmMHPZ4dy8GY5mvIzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=QTk5ow9G; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4f2rzX4wHrzm4ql0; Fri, 30 Jan 2026 22:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1769813942; x=1772405943; bh=pGZCdfTqJZsczKLbgP8aETuC twVHrNt9P39BRiViQ1g=; b=QTk5ow9G2TWbxVMxrX4lXhMSMGVYdJCx5sgAI6g+ DvXEr0Dfl4mFpCNDj+rePLRl1xHfv3kOiZC78rLfcWYDE7t36Mu8sm5BNallsfrD q8dJMWUicsgcJ15Xpi1aW11ZTMcCLVTQH5I1eKTsjyroBiJZNyKFzQ4g2o7fprqA hBlgr/38v4a9BKiDtHo3KmvUZda3Icp2uFiuJtEJPPPTpK6puBucqhTZF4kcSPfu LAUYiqX3HT+b9+x1FoQvkzQgi1DGfFk7Y+UynoRvp0fWAd2Wjcz5gLHUrJqm9k2I 6pI4tdBb+dNAd5qdVg7C2tgNuapW7ok6gVjRa9YQMxjYSw== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id YmmZJXQ3CZ6w; Fri, 30 Jan 2026 22:59:02 +0000 (UTC) Received: from [100.119.48.131] (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4f2rzR6Blvzm4qkw; Fri, 30 Jan 2026 22:58:59 +0000 (UTC) Message-ID: Date: Fri, 30 Jan 2026 14:58:59 -0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] scsi: ufs: core: Flush exception handling work when RPM level is zero To: Thomas Yen Cc: Stable Tree , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Peter Wang , Bean Huo , Adrian Hunter , "Bao D. Nguyen" , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER" , open list References: <20260129070657.678532-1-thomasyen@google.com> <491d53b9-a110-431b-9a5e-3b46d833fdbb@acm.org> <076fe171-6fd3-4dbc-9876-242905379594@acm.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DKIM: signer='acm.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: acm.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On 1/29/26 9:39 AM, Thomas Yen wrote: > My apologies. I missed that Peter had already replied with his > Reviewed-by tag on this v3 thread before I sent v4. In the future, please leave more time between posting different versions of a patch. Posting four versions of the same patch in five days is too frequent because it doesn't give reviewers enough time to react. Thanks, Bart. From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id +AJOAjY4fWkqQyEAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 23:01:10 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 23:01:10 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlxUD-0000000AThV-3W80 for hi@josie.lol; Fri, 30 Jan 2026 23:01:10 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 12B453009F35 for ; Fri, 30 Jan 2026 23:01:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 34BD92D191C; Fri, 30 Jan 2026 23:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R74TAEZm" X-Original-To: stable@vger.kernel.org Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94F0435B654 for ; Fri, 30 Jan 2026 23:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769814067; cv=none; b=it4qcWhXKh+OhvVL8HceurdplK0QkMzn79Htsuj7iCJUZvGLQK1P2hDg4J34wsoT1moYTltqwZnFpnHxs9j6m3njGO6+lJLUGRQZc9FgapWo1gO/WORjTpS7s8J5EMsEsNLtIatuvBtjFPYzObQsv26VXsdP3y04Ph7Cazxz6a4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769814067; c=relaxed/simple; bh=YcpEfZQTsm6x4i7YQGBxoxQHFpqNqiq87Wo3LOjlTvg=; h=From:To:Cc:Subject:Date:Message-Id; b=f27F4Pxaze7CcMcaL0qWTSxAC18xVKtp19U7L0EwSNjIOI79+o8geYtyeYwU62kZfh1tfz5AcWZ6lHixFnj55et+MV2HXhcOwIRHLOcjcDkAPT/l0Bwz5FeY6h56RhOeBVDyefUjAo3bamc2nRGeD6n+htUK3IoI2zjLquRA1X4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R74TAEZm; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b8838339fc6so490340166b.0 for ; Fri, 30 Jan 2026 15:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769814063; x=1770418863; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XpzJMKrnIvJPiY74TgzeTlKt0Hvq5aWJIdiYlnsoQHE=; b=R74TAEZmkgJ1rKpOVAEjLFVYCN23nTlfoMmnRSerH7dbBxhE1evlOo4YBkD7/aBGKB QsGOPIeAWI2pgi8bg5DvObR0RBEn92hnkqLkwWERim/3HlRvNToIhqGI3h5vWISJDEbu YIq8BrKsP2ZHiVFY/FKBpoBxh4OJl104Dj3oUb7OrUqlomWTIUsbZSPvFnsJJjC+jcr0 uYDRIP9jDjkIuMgfCzDTfKblDDVbvRWIZZ6EPDCCXdPFGynNTLzTLBxqjtngc7kKZdid QuugyDY6DPrsEu+aUYJdeOYGCIxLwJQsJpPUHy5UUMGbrlJ0/GZrKGDvWByuzEIj1kTP gEEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769814063; x=1770418863; h=message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XpzJMKrnIvJPiY74TgzeTlKt0Hvq5aWJIdiYlnsoQHE=; b=uvOQ2Hb29EU+qphH2k4SEabFUk8HTC4Cv0Mn5W4l8GbekIGg+QTKaPd3ijG47bWIOV ulrDxfJAvQfNro+RLmQtjS1o/lp5iDyPBYWPJFUff2PqoI1e2aJmP/yIxvoqCJalzdGa RWS9tNW7w9E4qE9pcfQ7sGeRVWQU1DVO/YhJHmEyQXBANM8XxWJOvtR0TGmetMsUe6CD FPq/RZvpMJpwBfGV3WmBD9iHFyiPJj68w7W48jIs/2o0UP8hSKKF37wfIbxpmsQDa9jJ lhBeQzGv0JgbxRmwL+cJXnewe+lthNgwXFqF510s8T9ll+R4eqBreMlHIi5xsc5BJraK xQTg== X-Forwarded-Encrypted: i=1; AJvYcCWXckywtPZdaRYTwT8oIX2sSsZtbURKjRWjhifik8Xz2BbL5tX5hbx1ols86PXd8c1N8R+6WII=@vger.kernel.org X-Gm-Message-State: AOJu0YxN6zRsA9qmh2LIqI+kTEen9Gxk2ceEb+ARIyP+jKxUfL36KVlo G8Y/hg+KFEhotYXpa03KPjRRb2TBdnKxa6DN/fsPyzfLIGoIXzINlmBo X-Gm-Gg: AZuq6aKu5lM7QTXoFtuUJI5WgLpVvRavUakduypKF/RsrnZDS0sRpIiUHtLSWGDKYs1 0+HaZevRHu5gu3SbG/X4AuiewVdDbJybf3hqVmIEioE2wTr11BuaSOiswamxH+30t55VplcQ2Aq IU/aGErbubN3MSbDdt8OXWCL6jQ4GNUp0sIW17iKRlVz8KaIovU4HF2dKExGaq5FO7G30mg2y6D ZhgWdxv9uVaksOlPMD4OWe65iCohaEhpg4WsXZ1icDj/q+OvbGqLzOMKGTYpHcR2glsM7MgI2pi FjjR8zwD6stVdwWjuV8x5CuEoTgaI2Ztr1eKoi2VF0wAFuIDUNB4LPZcCujqFi633ZKEDBOIFrd NLl9PpAclIEhtQyeEjVO10vKrdrqu2+7QfbD3lQQd3qMIuawHTQMbts0RFaS7MIBvmjw/lIshtB j+Ak16fiRdEA== X-Received: by 2002:a17:907:2d0e:b0:b88:1e2:ed49 with SMTP id a640c23a62f3a-b8dff22f549mr298811466b.8.1769814062665; Fri, 30 Jan 2026 15:01:02 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e0a5a3b1asm152556866b.57.2026.01.30.15.01.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Jan 2026 15:01:01 -0800 (PST) From: Wei Yang To: akpm@linux-foundation.org, david@kernel.org, lorenzo.stoakes@oracle.com, riel@surriel.com, Liam.Howlett@oracle.com, vbabka@suse.cz, harry.yoo@oracle.com, jannh@google.com, gavinguo@igalia.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com Cc: linux-mm@kvack.org, Wei Yang , stable@vger.kernel.org Subject: [PATCH] mm/huge_memory: fix early failure try_to_migrate() when split huge pmd for shared thp Date: Fri, 30 Jan 2026 23:00:58 +0000 Message-Id: <20260130230058.11471-1-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [richard.weiyang[at]gmail.com] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 Commit 60fbb14396d5 ("mm/huge_memory: adjust try_to_migrate_one() and split_huge_pmd_locked()") return false unconditionally after split_huge_pmd_locked() which may fail early during try_to_migrate() for shared thp. This will lead to unexpected folio split failure. One way to reproduce: Create an anonymous thp range and fork 512 children, so we have a thp shared mapped in 513 processes. Then trigger folio split with /sys/kernel/debug/split_huge_pages debugfs to split the thp folio to order 0. Without the above commit, we can successfully split to order 0. With the above commit, the folio is still a large folio. The reason is the above commit return false after split pmd unconditionally in the first process and break try_to_migrate(). The tricky thing in above reproduce method is current debugfs interface leverage function split_huge_pages_pid(), which will iterate the whole pmd range and do folio split on each base page address. This means it will try 512 times, and each time split one pmd from pmd mapped to pte mapped thp. If there are less than 512 shared mapped process, the folio is still split successfully at last. But in real world, we usually try it for once. This patch fixes this by removing the unconditional false return after split_huge_pmd_locked(). Later, we may introduce a true fail early if split_huge_pmd_locked() does fail. Signed-off-by: Wei Yang Fixes: 60fbb14396d5 ("mm/huge_memory: adjust try_to_migrate_one() and split_huge_pmd_locked()") Cc: Gavin Guo Cc: "David Hildenbrand (Red Hat)" Cc: Zi Yan Cc: Baolin Wang Cc: --- mm/rmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/rmap.c b/mm/rmap.c index 618df3385c8b..eed971568d65 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -2448,7 +2448,6 @@ static bool try_to_migrate_one(struct folio *folio, struct vm_area_struct *vma, if (flags & TTU_SPLIT_HUGE_PMD) { split_huge_pmd_locked(vma, pvmw.address, pvmw.pmd, true); - ret = false; page_vma_mapped_walk_done(&pvmw); break; } -- 2.34.1 From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 0KF/LIo4fWkniSUAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 23:02:34 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 23:02:34 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlxVa-0000000AW7G-1wr4 for hi@josie.lol; Fri, 30 Jan 2026 23:02:34 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id EAFE2305617C for ; Fri, 30 Jan 2026 23:00:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 22BFD350A0E; Fri, 30 Jan 2026 23:00:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="NnqdysyG" X-Original-To: stable@vger.kernel.org Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3AEC364EA6; Fri, 30 Jan 2026 23:00:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769814037; cv=none; b=SdJIVLOoez9cNjEGnk9VGLEYuHnNTOQXh8uLlOszQ/HqVkNsgrTRcgidASDG/bHdQAY6B8eey5bAFC60lt5hYLU+1CaOF98GRzScLuBvg5oohQAAaSj/ODk0iGXLi2ubt4DviNCRtt8d6Kt7ymFBpbVRoWb1IP2fGjSwrcitzHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769814037; c=relaxed/simple; bh=7amOVhwEswMxix3YRsOAK+uY3G4S7SOWKYxYoumlp/k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ORrJjeGl8Dvc2j3OXlw9QyLX6eN8XMm65Hk8r9bKEgjiCCC08r1FKicIVMYgRdYPz/paP+YQUdfymMR5vJs/obUt6N2x2rhic3WJtbrLvmRqtxdSNhIKT6C65Oq2aJYNFOT0vBITbJ8kXI0fATgMwePyPkSQ69h/+k5fDB8lMTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=NnqdysyG; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4f2s1H3bkRzm4ql0; Fri, 30 Jan 2026 23:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1769814032; x=1772406033; bh=O2JkvURvRK4OyrBNFDyITmb/ tZoBffSL7tR9HU4jlo0=; b=NnqdysyGOkN01H/kjZfcR86vLUifb8N7ZADSN4Aq jau0LlqJ1WJsinwJAYO+6bKs3SGON3WSG9j7ReleIhgiJbDSO60AAsyikJ4ogrhU cpAcbwvovwFJAybgAV0whUsmYV9ly8fOwbhIvbixd4bBpdh4Z5572iSUi8JGcQ7t FDO2g2gUB+a3JWwK9UVWN2uctDjT9T6cpw5YgeaiMdtKqwyYPdoL9UBxsVhWhydU fNJQ2qgNc11QGJafLWOeDnEx9oGxEJnXsKZs6SP0GdKnqYFKC3FKhvN3tKi1oRtu WGPNtGbG8TTDhrzgR/pXKEs15i6zOqII6Z6KNu3EBDxZqQ== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id z-rf8S79pmle; Fri, 30 Jan 2026 23:00:32 +0000 (UTC) Received: from [100.119.48.131] (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4f2s162KxzzlgyGd; Fri, 30 Jan 2026 23:00:25 +0000 (UTC) Message-ID: <91ce1532-0af7-46ca-8d3e-fa2cf063b18c@acm.org> Date: Fri, 30 Jan 2026 15:00:25 -0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/1] scsi: ufs: core: Flush exception handling work when RPM level is zero To: Thomas Yen , martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com Cc: Stable Tree , Alim Akhtar , Avri Altman , Peter Wang , Bean Huo , Adrian Hunter , "Bao D. Nguyen" , Subhash Jadavani , Dolev Raviv , Sujit Reddy Thumma , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER" , open list References: <20260129165156.956601-1-thomasyen@google.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20260129165156.956601-1-thomasyen@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DKIM: signer='acm.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: acm.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On 1/29/26 8:51 AM, Thomas Yen wrote: > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index 0369043ca010..8c88dd5c2cca 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -9997,6 +9997,8 @@ static int __ufshcd_wl_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op) > > if (req_dev_pwr_mode == UFS_ACTIVE_PWR_MODE && > req_link_state == UIC_LINK_ACTIVE_STATE) { > + ufshcd_disable_auto_bkops(hba); > + flush_work(&hba->eeh_work); > goto vops_suspend; > } Reviewed-by: Bart Van Assche From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id KDlPDk08fWlB+SUAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 23:18:37 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 23:18:37 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlxl5-0000000Ax2S-3PHy for hi@josie.lol; Fri, 30 Jan 2026 23:18:37 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id DB17F3036635 for ; Fri, 30 Jan 2026 23:18:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A005F36826D; Fri, 30 Jan 2026 23:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="h2oOv/wf" X-Original-To: stable@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E780A1EB5F8; Fri, 30 Jan 2026 23:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769815110; cv=none; b=qnXfodr2QxrAwOgqJuoTUvHThDzrTWuY+wfMDWUpHr1/BVHzAEgXlJuYK43VVdY4eIz2Qnz1BVolYcYHulKOgmaTIKLqnMQsO//TEE0QaHBcz1gai+BtnOJlf7exbweqbQL4Tv9yRg4ECGcFmyJo6pVBxHSiG4qQzmcYP+EiZb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769815110; c=relaxed/simple; bh=t6+FD63TBEjAF4loU6XF4HOpBwGsFUNv91UC8x59JYY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fu6RWOQT/UBsFk9sblbb9zf4CtSz5jwqaCk1Si2axSLjhLFnrt6XslBK2x/uSO5LDBGf77pF6CoajC0N72/F74AjQXHaCA130zmLlP4W9UwhnbKgi7OaklrRe7Z0EdBVrgEvUvquKx6PXfWL/pc9xdzNq9GBJg3dZt0v3qNgSzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=h2oOv/wf; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=6O1mYVG2C4caxIEKCFEl8cUKL+tPPC5+mqnQqr+mWek=; b=h2oOv/wf+Gc10WkF1rp6lpKhkx REDyin4qfKyGMKAcdYmyjQRWX+VrSfwR4eXd8S2FNWlADZqsKpnxN7EvCdHc8CCZMwbNlODRRUqBj V5U+9vU+B7KisVoQ7uYed0oa+vWVk0Kq636TjCG7kO6S1Pchuxw0YZNWtk50oIw/VEjd5R/oHVwg4 V4/CUHugHHoryEUoLPQSjfboedENzshD0dfK61pSZkzolTxa9WB2kLMBpjHNW2jd0R8aDCgwqzRHD 4Uw/6WH8KgIZ5wEXi17F41tNvBNsKBlrj08GiHFqQXWU1oOPozjg3NZmHoQIHPRKbXbZRPwDonUCe 2Uz7VkBw==; Received: from [50.53.43.113] (helo=[192.168.254.34]) by bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vlxku-000000025sf-22tZ; Fri, 30 Jan 2026 23:18:24 +0000 Message-ID: <70955fc0-84c0-440f-85ba-2d97418ca827@infradead.org> Date: Fri, 30 Jan 2026 15:18:22 -0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kbuild: Do not run kernel-doc when building external modules To: Nathan Chancellor , Nicolas Schier , Jonathan Corbet Cc: linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Rong Zhang , Mauro Carvalho Chehab References: <20260130-kbuild-skip-kernel-doc-extmod-v1-1-58443d60131a@kernel.org> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20260130-kbuild-skip-kernel-doc-extmod-v1-1-58443d60131a@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-DKIM: signer='infradead.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: makefile.build] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On 1/30/26 1:37 PM, Nathan Chancellor wrote: > After commit 778b8ebe5192 ("docs: Move the python libraries to > tools/lib/python"), building an external module with any value of W= > against the output of install-extmod-build fails with: > > $ make -C /usr/lib/modules/6.19.0-rc7-00108-g4d310797262f/build M=$PWD W=1 > make: Entering directory '/usr/lib/modules/6.19.0-rc7-00108-g4d310797262f/build' > make[1]: Entering directory '...' > CC [M] ... > Traceback (most recent call last): > File "/usr/lib/modules/6.19.0-rc7-00108-g4d310797262f/build/scripts/kernel-doc.py", line 339, in > main() > ~~~~^^ > File "/usr/lib/modules/6.19.0-rc7-00108-g4d310797262f/build/scripts/kernel-doc.py", line 295, in main > from kdoc.kdoc_files import KernelFiles # pylint: disable=C0415 > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > ModuleNotFoundError: No module named 'kdoc' > > scripts/lib was included in the build directory from find_in_scripts but > after the move to tools/lib/python, it is no longer included, breaking > kernel-doc.py. > > Commit eba6ffd126cd ("docs: kdoc: move kernel-doc to tools/docs") breaks > this even further by moving kernel-doc outside of scripts as well, so it > cannot be found when called by cmd_checkdoc. > > $ make -C /usr/lib/modules/6.19.0-rc7-next-20260130/build M=$PWD W=1 > make: Entering directory '/usr/lib/modules/6.19.0-rc7-next-20260130/build' > make[1]: Entering directory '...' > CC [M] ... > python3: can't open file '/usr/lib/modules/6.19.0-rc7-next-20260130/build/tools/docs/kernel-doc': [Errno 2] No such file or directory > > While kernel-doc could be useful for external modules, it is more useful > for in-tree documentation that will be build and included in htmldocs. > Rather than including it in install-extmod-build, just skip running > kernel-doc for the external module build. > > Cc: stable@vger.kernel.org > Fixes: 778b8ebe5192 ("docs: Move the python libraries to tools/lib/python") > Reported-by: Rong Zhang > Closes: https://lore.kernel.org/20260129175321.415295-1-i@rong.moe/ > Reviewed-by: Mauro Carvalho Chehab > Signed-off-by: Nathan Chancellor LGTM. Reviewed-by: Randy Dunlap Thanks. > --- > This is an alternative to Rong's proposed fix for the first error: > > https://lore.kernel.org/20260129175321.415295-1-i@rong.moe/ > > I noticed the second one by inspection of -next and further testing. > --- > scripts/Makefile.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 5037f4715d74..f01d7957edf7 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -166,11 +166,13 @@ else ifeq ($(KBUILD_CHECKSRC),2) > cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< > endif > > +ifeq ($(KBUILD_EXTMOD),) > ifneq ($(KBUILD_EXTRA_WARN),) > cmd_checkdoc = PYTHONDONTWRITEBYTECODE=1 $(PYTHON3) $(KERNELDOC) -none $(KDOCFLAGS) \ > $(if $(findstring 2, $(KBUILD_EXTRA_WARN)), -Wall) \ > $< > endif > +endif > > # Compile C sources (.c) > # --------------------------------------------------------------------------- > > --- > base-commit: 63804fed149a6750ffd28610c5c1c98cce6bd377 > change-id: 20260130-kbuild-skip-kernel-doc-extmod-276584e7b2b0 > > Best regards, > -- > Nathan Chancellor > > -- ~Randy From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id aPARIktCfWkW6igAYBR5ng (envelope-from ) for ; Fri, 30 Jan 2026 23:44:11 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 30 Jan 2026 23:44:11 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vly9r-0000000BeIA-0uox for hi@josie.lol; Fri, 30 Jan 2026 23:44:11 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 30495300F151 for ; Fri, 30 Jan 2026 23:44:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C68D938B7BE; Fri, 30 Jan 2026 23:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z+OHOeuH" X-Original-To: stable@vger.kernel.org Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 219CA2D8370 for ; Fri, 30 Jan 2026 23:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769816647; cv=none; b=DIl6XJAmlV58UPdsjoOtwnmitGF6UQx5SEuBZ7fE6+SCeNcCQA4bQeUj1J1zAqrjuBlOjPGye1aanWN3FmsfGYpk0wMYG3G/QvBB2iieoIlWLUmYsn6AlSkCWUslF4QOo+Xa+QLhyGvJ4pWYisWj/jsfSDbl0DkBk1Ds7twlgoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769816647; c=relaxed/simple; bh=dR0F3EMGWh5ahhwUJyWJNhY/BpTFkjYYDkVdU3wHi/M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Erd1mLDP2yODuILch8Th0g/YUU0Tztn1WPOZFWHvjiRyLvUltNrgFc1igE2/YVmxtjlRs58oIBSjw8X/3EFOqcIgo6mjthuOEc+7fpnQdTM+OyHCRBY7aSXaz3krimekoB9yXahwWVnBswwfzIOERabz2E8gkz6xOIaV6j/k/iU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z+OHOeuH; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4806f9e61f9so13618395e9.1 for ; Fri, 30 Jan 2026 15:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769816644; x=1770421444; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dR0F3EMGWh5ahhwUJyWJNhY/BpTFkjYYDkVdU3wHi/M=; b=Z+OHOeuHKTpZNJFvosort1CYjKRI6QKfId7jFJP9ypDY4qqalrTG2hu/Oo1LG7POKm pRbrChMuJkCljmiJTM9hJPVTq7sMMcncMmhN4gFpVeq0Q+IWhlQDqa8hiW0kLaLEWfyr vBLlqCHe/UBjfn/UWfTBkT0mRXRShTUKSNwo/emJJb3rqHnk5auXbw7Za6tnhEudNG7+ npH893C2iDqX+2V0Sy+rmAWcTQZiF1zPSBfbrZ6RzUTfy/fyqekD141DMKJVA3K6xvHd PQ1RmQN2TaM2PUnEp5y6Gow/hHTR9cf0KtqAOalZHAdP406YXZrheS9eiFvGPHBPYsxs SNig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769816644; x=1770421444; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dR0F3EMGWh5ahhwUJyWJNhY/BpTFkjYYDkVdU3wHi/M=; b=HhiKfg1DMXEGXsckiUjd/TYT4utkLRp2qhY++JaAarY3b9/WfEsb7Z/HPUpHz4O2Fv MTD2gf9h9eB6YD7lXc48DgDG+pyX67nRUO10IeXtaMYr04c2q0ZsjO1vNayGubmm2Yoq UPPaiOLdwnyUdgzBCc28FMrqDvSvOJz21qaeJ7lyp/1q8W9KFvQyiruNDYupilVGvpqS VP6Mvr1cRGbqRYRvmDf3YMor4iAgCEYbqIQlXwWNAlRMv5ZSHw2nQ7F2Q4yu2CUCHC46 o8RnJB1Hs+ekfUq7CIfylWkV3cFwxzja1lHTJYO1ziVTQzbGbef34XcDZ0Hegmun3A2d vDRw== X-Forwarded-Encrypted: i=1; AJvYcCVLliaRagky4VIOOtW7ORGP9vTEH+inPkJPyKsHdX0MQ9wxpUA3V6zVgy1+Songr4WT/C5mutc=@vger.kernel.org X-Gm-Message-State: AOJu0YwReM2T//jyVEFlUtMomUbYlY04S57D4Hz8Qm5Tc21A01ITypdh O6SUKioMi7cLbV7pYudEXM5l56Cfm2/RxPKN+zNiAvT1lgOTqRscKz2iDUJAZncQUHI= X-Gm-Gg: AZuq6aJ9txmDNHmhDfSF/wRrSrJ8X148a2Cz/LrfhFig14OyJfJqeZEoIMwLMGWPruq 3ctLX0XMgRn86rhiNxJFPStlqqWHdmM7PnpDRkPkLe32pO+E0aj8O7P7zvaJVaf+rWtvT+HsQ10 8jzuOucf4nblLOky59NQSeL+HI37WkGGAgUSDoAhVtZgyHc28mS1hs6nePFdEWQUQVbeXjnlbok YjYNIhzpnj+QX/U/wLSRRmyMm7HrIlBUC6iemb9J3znMKY0QOqPw8oKXNTd7A3bzy9M4RG8E1bb rigKShK3KIMopztuny6lzNA+bxpV+58dENkrm2rj/ZxU2SGCZ2FNcS3cBdFxb7qyuv2qU02zROv /LEWsZeFMyRaszCpd07Yyv0d6KF9BcYXgKRQQ4NZD3qtvFamVG7mhfGz3DvVPyQbmUlSCxsx51q AFMVdorwbTcxm6ZjWUqe63UuI= X-Received: by 2002:a05:600c:8b65:b0:47e:e61d:b8d2 with SMTP id 5b1f17b1804b1-482db486ee9mr55984625e9.27.1769816644353; Fri, 30 Jan 2026 15:44:04 -0800 (PST) Received: from debian.local ([2a0a:ef40:e94:5d01:a218:5589:9f9c:4f52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cdd77b8sm229200855e9.3.2026.01.30.15.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 15:44:03 -0800 (PST) Date: Fri, 30 Jan 2026 23:44:01 +0000 From: Chris Bainbridge To: "Korenblit, Miriam Rachel" Cc: "kvalo@kernel.org" , "Berg, Johannes" , "benjamin@sipsolutions.net" , "gustavoars@kernel.org" , "linux-intel-wifi@intel.com" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH] Revert "wifi: iwlwifi: trans: remove STATUS_SUSPENDED" Message-ID: References: <20260125233335.6875-1-chris.bainbridge@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chris.bainbridge[at]gmail.com] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 Hi, I've been running a kernel with both of the suspend fixes (pause TCM on fast resume, cleanup IWL_MVM_STATUS_IN_HW_RESTART in resume) here for the last few days. I just experienced this fault - not from suspend/resume this time though, the laptop wasn't doing anything particular at the time, so no idea how to reproduce it. Maybe it's related though (?) as it has the same "Error sending SYSTEM_STATISTICS_CMD: time out after 2000ms." It recovered ok, wifi was functional afterwards. [37410.975565] iwlwifi 0000:01:00.0: Error sending SYSTEM_STATISTICS_CMD: time out after 2000ms. [37410.975741] iwlwifi 0000:01:00.0: Current CMD queue read_ptr 39088 write_ptr 39089 [37410.977474] iwlwifi 0000:01:00.0: Start IWL Error Log Dump: [37410.977480] iwlwifi 0000:01:00.0: Transport status: 0x0000004A, valid: 6 [37410.977486] iwlwifi 0000:01:00.0: Loaded firmware version: 89.7f71c7f4.0 ty-a0-gf-a0-89.ucode [37410.977491] iwlwifi 0000:01:00.0: 0x00000084 | NMI_INTERRUPT_UNKNOWN [37410.977497] iwlwifi 0000:01:00.0: 0x00008210 | trm_hw_status0 [37410.977502] iwlwifi 0000:01:00.0: 0x00000000 | trm_hw_status1 [37410.977506] iwlwifi 0000:01:00.0: 0x004DAD04 | branchlink2 [37410.977511] iwlwifi 0000:01:00.0: 0x004D092A | interruptlink1 [37410.977515] iwlwifi 0000:01:00.0: 0x004D092A | interruptlink2 [37410.977520] iwlwifi 0000:01:00.0: 0x00016AD2 | data1 [37410.977524] iwlwifi 0000:01:00.0: 0x01000000 | data2 [37410.977529] iwlwifi 0000:01:00.0: 0x00000000 | data3 [37410.977533] iwlwifi 0000:01:00.0: 0x70C01827 | beacon time [37410.977538] iwlwifi 0000:01:00.0: 0xAD47B7F5 | tsf low [37410.977542] iwlwifi 0000:01:00.0: 0x0000066B | tsf hi [37410.977547] iwlwifi 0000:01:00.0: 0x00000000 | time gp1 [37410.977551] iwlwifi 0000:01:00.0: 0xB3FD3A22 | time gp2 [37410.977555] iwlwifi 0000:01:00.0: 0x00000001 | uCode revision type [37410.977560] iwlwifi 0000:01:00.0: 0x00000059 | uCode version major [37410.977565] iwlwifi 0000:01:00.0: 0x7F71C7F4 | uCode version minor [37410.977569] iwlwifi 0000:01:00.0: 0x00000420 | hw version [37410.977574] iwlwifi 0000:01:00.0: 0x00C80002 | board version [37410.977578] iwlwifi 0000:01:00.0: 0x80F3FD26 | hcmd [37410.977583] iwlwifi 0000:01:00.0: 0x24020000 | isr0 [37410.977587] iwlwifi 0000:01:00.0: 0x00000000 | isr1 [37410.977591] iwlwifi 0000:01:00.0: 0x40F84002 | isr2 [37410.977596] iwlwifi 0000:01:00.0: 0x04C3081C | isr3 [37410.977600] iwlwifi 0000:01:00.0: 0x00000000 | isr4 [37410.977604] iwlwifi 0000:01:00.0: 0x0326001C | last cmd Id [37410.977609] iwlwifi 0000:01:00.0: 0x00016AD2 | wait_event [37410.977613] iwlwifi 0000:01:00.0: 0x00000080 | l2p_control [37410.977618] iwlwifi 0000:01:00.0: 0x00010014 | l2p_duration [37410.977622] iwlwifi 0000:01:00.0: 0x0000003F | l2p_mhvalid [37410.977627] iwlwifi 0000:01:00.0: 0x00001800 | l2p_addr_match [37410.977631] iwlwifi 0000:01:00.0: 0x00000008 | lmpm_pmg_sel [37410.977635] iwlwifi 0000:01:00.0: 0x00000000 | timestamp [37410.977640] iwlwifi 0000:01:00.0: 0x06647878 | flow_handler [37410.977678] iwlwifi 0000:01:00.0: Start IWL Error Log Dump: [37410.977682] iwlwifi 0000:01:00.0: Transport status: 0x0000004A, valid: 7 [37410.977687] iwlwifi 0000:01:00.0: 0x20000066 | NMI_INTERRUPT_HOST [37410.977692] iwlwifi 0000:01:00.0: 0x00000000 | umac branchlink1 [37410.977697] iwlwifi 0000:01:00.0: 0x804838BE | umac branchlink2 [37410.977701] iwlwifi 0000:01:00.0: 0x804A5D36 | umac interruptlink1 [37410.977706] iwlwifi 0000:01:00.0: 0x804A5D36 | umac interruptlink2 [37410.977710] iwlwifi 0000:01:00.0: 0x01000000 | umac data1 [37410.977715] iwlwifi 0000:01:00.0: 0x804A5D36 | umac data2 [37410.977719] iwlwifi 0000:01:00.0: 0x00000000 | umac data3 [37410.977723] iwlwifi 0000:01:00.0: 0x00000059 | umac major [37410.977728] iwlwifi 0000:01:00.0: 0x7F71C7F4 | umac minor [37410.977732] iwlwifi 0000:01:00.0: 0xB3FD3A20 | frame pointer [37410.977736] iwlwifi 0000:01:00.0: 0xC0886258 | stack pointer [37410.977741] iwlwifi 0000:01:00.0: 0x00B0020F | last host cmd [37410.977745] iwlwifi 0000:01:00.0: 0x00000400 | isr status reg [37410.977759] iwlwifi 0000:01:00.0: IML/ROM dump: [37410.977764] iwlwifi 0000:01:00.0: 0x00000B03 | IML/ROM error/state [37410.977778] iwlwifi 0000:01:00.0: 0x00008EBB | IML/ROM data1 [37410.977792] iwlwifi 0000:01:00.0: 0x00000090 | IML/ROM WFPM_AUTH_KEY_0 [37410.977802] iwlwifi 0000:01:00.0: Fseq Registers: [37410.977868] iwlwifi 0000:01:00.0: 0x60000000 | FSEQ_ERROR_CODE [37410.977875] iwlwifi 0000:01:00.0: 0x80440007 | FSEQ_TOP_INIT_VERSION [37410.977882] iwlwifi 0000:01:00.0: 0x00080009 | FSEQ_CNVIO_INIT_VERSION [37410.977889] iwlwifi 0000:01:00.0: 0x0000A652 | FSEQ_OTP_VERSION [37410.977896] iwlwifi 0000:01:00.0: 0x00000002 | FSEQ_TOP_CONTENT_VERSION [37410.977902] iwlwifi 0000:01:00.0: 0x4552414E | FSEQ_ALIVE_TOKEN [37410.977909] iwlwifi 0000:01:00.0: 0x00400410 | FSEQ_CNVI_ID [37410.977915] iwlwifi 0000:01:00.0: 0x00400410 | FSEQ_CNVR_ID [37410.977922] iwlwifi 0000:01:00.0: 0x00400410 | CNVI_AUX_MISC_CHIP [37410.977930] iwlwifi 0000:01:00.0: 0x00400410 | CNVR_AUX_MISC_CHIP [37410.977939] iwlwifi 0000:01:00.0: 0x00009061 | CNVR_SCU_SD_REGS_SD_REG_DIG_DCDC_VTRIM [37410.977948] iwlwifi 0000:01:00.0: 0x00000061 | CNVR_SCU_SD_REGS_SD_REG_ACTIVE_VDIG_MIRROR [37410.977954] iwlwifi 0000:01:00.0: 0x00080009 | FSEQ_PREV_CNVIO_INIT_VERSION [37410.977961] iwlwifi 0000:01:00.0: 0x00440007 | FSEQ_WIFI_FSEQ_VERSION [37410.977968] iwlwifi 0000:01:00.0: 0x00440007 | FSEQ_BT_FSEQ_VERSION [37410.977974] iwlwifi 0000:01:00.0: 0x000000E6 | FSEQ_CLASS_TP_VERSION [37410.977988] iwlwifi 0000:01:00.0: UMAC CURRENT PC: 0x804a57fc [37410.977995] iwlwifi 0000:01:00.0: LMAC1 CURRENT PC: 0xd0 [37410.978994] iwlwifi 0000:01:00.0: WRT: Collecting data: ini trigger 4 fired (delay=0ms). [37411.452630] iwlwifi 0000:01:00.0: Device error - SW reset [37411.452783] ieee80211 phy0: Hardware restart was requested [37411.699230] iwlwifi 0000:01:00.0: WFPM_UMAC_PD_NOTIFICATION: 0x20 [37411.699393] iwlwifi 0000:01:00.0: WFPM_LMAC2_PD_NOTIFICATION: 0x1f [37411.699479] iwlwifi 0000:01:00.0: WFPM_AUTH_KEY_0: 0x90 [37411.699553] iwlwifi 0000:01:00.0: CNVI_SCU_SEQ_DATA_DW9: 0x0 [37411.837813] iwlwifi 0000:01:00.0: restart completed From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id wKeyAwhPfWmkQS4AYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 00:38:32 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 00:38:34 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlz0R-0000000D9n7-3A0N for hi@josie.lol; Sat, 31 Jan 2026 00:38:32 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 28AE3300F9CA for ; Sat, 31 Jan 2026 00:38:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8473E2F693B; Sat, 31 Jan 2026 00:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bYnxHnU/" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F9A519A288; Sat, 31 Jan 2026 00:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769819907; cv=none; b=Fajw2WdPJsywEDFrC9rzpRAiRqkOVLA9borf1F49saAzT+aJ6JumOaT6mgc0Dfgqt/Rac5yQhyYBF4zdR1d25UbNY02FbVQApN8HnjyjL8qzR7fJRb0CrHbWfuBxqpjyI+aa1xs8ouLP90I1poYRR27fgnr9bMPa2AzFyI0HISg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769819907; c=relaxed/simple; bh=Jdd3buLMaqZBkACwxbSaZ9XyMhBAqA5jAjxcO9QTh9M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E+ALXqIiwOIVfSJUqiWPTxf6oQQPe9GO1o8sFxPw4ajfkF36wzypX+d1VtGNuBMBg7AdNz6Ru39tYa5ncx+aeD5CSO9U8SJm4U2Z8WB7Pt+ee2T7Wc4MFrg6J7dymHRYfdgKF5tN60aeS8cGfnHEQOAC5UqzBBNBE40KHBxizpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bYnxHnU/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49F75C4CEF7; Sat, 31 Jan 2026 00:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769819907; bh=Jdd3buLMaqZBkACwxbSaZ9XyMhBAqA5jAjxcO9QTh9M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bYnxHnU/XJ9Lk3D3akKRWErAxebiOZiN+kzUeQWoviWRVSAWgyfw3bHNYtPh1qdXA hGEpFGoyweQuOeWSBNm7f2vRN6k3b2i3q0kheVi6pnSmB3WWevIouZYMhOx1krHN1N yAjWxNv05ePs/d12c96gt4DeQboX9AN6QyO/9cqNUP9AyPSP8pHlN5ubIaly2KxW/P qiNQyFR64beaeD+/ja7YCcglAU63W+qnscbckUh9A0+TeYf2ZL/g5Zzwvmymk8dG7q OVeRmngY8jPaXfQ1cj5PQLWceUHwSE+Kay6q3yCiuCGm05ceeVDSvJrDMSsCj34STd w+yl4p/EOAeyg== Date: Fri, 30 Jan 2026 16:38:25 -0800 From: Jakub Kicinski To: Eric Dumazet , Ankit Garg Cc: Joshua Washington , netdev@vger.kernel.org, Harshitha Ramamurthy , Andrew Lunn , "David S. Miller" , Paolo Abeni , Willem de Bruijn , Praveen Kaligineedi , Catherine Sullivan , Luigi Rizzo , Jon Olson , Sagi Shahar , Bailey Forrest , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net 0/2] gve: fix crashes on invalid TX queue indices Message-ID: <20260130163825.3b63222a@kernel.org> In-Reply-To: References: <20260105232504.3791806-1-joshwash@google.com> <20260106182244.7188a8f6@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 On Fri, 30 Jan 2026 21:56:07 +0100 Eric Dumazet wrote: > Jakub, the issue is that before 4.20, calling synchronize_rcu() > instead of synchronize_rcu_bh() > was probably a bug. I suspect we had more issues like that. > > __dev_queue_xmit takes a rcu_read_lock_bh(), while the code (that you > added in 2018 [1]) > to update the queue netif_set_real_num_tx_queues does synchronize_net() > (aka synchronize_rcu()) and in earlier times, it would mean that this > would maybe return too soon (say on preemptible kernels) > > [...] > > So perhaps a fix for pre 4.20 kernel would be: (I kept the > synchronize_net() to be really cautious and because I really do not > want to test) Sounds entirely plausible, FWIW. Ankit, this would mean that you have to convince RHEL / Rocky to take Eric's patch. Oldest kernel we can patch upstream is 5.10, AFAIK. From - Sat Jan 31 08:51:02 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 0AUABydVfWnp2i8AYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 01:04:39 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 01:04:39 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlzPi-0000000Dr7c-39QP for hi@josie.lol; Sat, 31 Jan 2026 01:04:39 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 33568307DFCE for ; Sat, 31 Jan 2026 01:00:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 01CE731AA8D; Sat, 31 Jan 2026 00:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DM4nUhW1" X-Original-To: stable@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A26A831A7F2 for ; Sat, 31 Jan 2026 00:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769821168; cv=fail; b=pmzrvpbBj00rzHdhMaCLx8rGya9Hioe7IYP3mJoxVtmQyYapG72PDzcM4h1VPzue9gJ6Ucsv14M4BeMoWv90JNSLSOxw226HAtKEYme/7G4+E6k++/odgG2Hl029xILTUyfpFShbt4fnPlaU8hTW7JtoG6ZOR8NanzRC7/+ys/E= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769821168; c=relaxed/simple; bh=Xk02qnUdSquwQF1iLqj0MUaRejQr66WAmHiqfE4KGY0=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=T9xJBTRVXzoC0D/heJdT/xt4TKDQMdOEan7fYf6clnKS4+ezz2IAPCarIcJ9U0j2ykFH6yt0IffCIBuPbI2MYwNMRdo8zb9IU0dfkrHF783Y+fH+4XWcFubWEkWOsVIkrVXIF41kAfJxBdstQWHd3eE7LIPOvR9Tk7Hn0bfCqvc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DM4nUhW1; arc=fail smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769821167; x=1801357167; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Xk02qnUdSquwQF1iLqj0MUaRejQr66WAmHiqfE4KGY0=; b=DM4nUhW1IKcndBXpwAS/efE1fQIoAtMBDCp15Ri+qdS8YTm5K4GJldNr eNRNNkikuL/OcKD+AC60OeXveP4qrU3KLD2HOr6sWPCXHIPf6Up/ZdYTC 3fEaL7YAqli0r6aSaQAqvkens4jdzS6DApRbner9b7h3taYX1QMLn/t/C K6XRihSYD54rY7LjcxHINbsbHAC/S9THIx7PgqftZ3bFDZW3ewsHGJrV4 uohNoMCMKCF11mB0tND3Sva01Fi7kzDuXYm4wXt4O0THN+iYlLnV6/fX9 9xf3jpuMM0OrNOtIhFOfy8s2Vq70/BnDr2J4l4GUgjJrr3J7TwJhNroby w==; X-CSE-ConnectionGUID: kYjsDEG1SyCcvqs/wtjgMA== X-CSE-MsgGUID: YxzBlHkYSKqY/6M0LjJVmw== X-IronPort-AV: E=McAfee;i="6800,10657,11687"; a="82444290" X-IronPort-AV: E=Sophos;i="6.21,264,1763452800"; d="scan'208";a="82444290" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 16:59:26 -0800 X-CSE-ConnectionGUID: ejeRSLg0TSCJqYZCsG5Bsw== X-CSE-MsgGUID: DDNFUxCTQdmsAa+dgb1TqQ== X-ExtLoop1: 1 Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 16:59:26 -0800 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Fri, 30 Jan 2026 16:59:25 -0800 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35 via Frontend Transport; Fri, 30 Jan 2026 16:59:25 -0800 Received: from DM1PR04CU001.outbound.protection.outlook.com (52.101.61.23) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Fri, 30 Jan 2026 16:59:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tMm7VsmNOHgoBvv/O7RNG0IiW1x1YHIeL7pmrqXnE6EsqN6Vs+QXOxfSJuPWF/g6tFq4utrMEXO9cyLx+HH47KWLjpXzoIluLnww5VfVgLRo8VHKIvZCs0uh19zMGOoZP6hXGlxADSAzaMqbo0ZeF9iALU5WX31VtyEer9zTOZ2I7VqXUQUFWSIihWEX7eHM2piHHtjejfv2ooyat6DfzzjpomcV2V+jWpaU1WWQTH0tZdr191OHAYhtn7dCkYzwxqzeOzLBKtHq6UwQeQ3ArQ72cK++QoRE/PKKAj7v/dG/kgiw8Nb89FxXyr5mek8dN5kWvqa2YaMACwuEEUePGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kqrotd9NxyWDElo9lfsmgz+3xduAgsFAtt7wbu5irbw=; b=u9xc3NwU4PtuTRp/ZAdp/GJCCbn8uCUFRkE1qHh8Xz7WdF+HRyQ/nzt/fRNdMKY2wZG/7xSoU5Yex8Eu6y/mlaQDNZfIexb575d8+peW6i/dq7YlrQPfHB0phac92TPVCnfBP+x4GQd1TWG0XWspidJF2ZJnmYoKBG/fRck99s04Gx6dTSdsKFOQkmmxAzpCHrXf/RcecxXYtGitrSljnxYfps2zpvcj3EufDXCaijxZff22m+6wxwEEnvJkyROlA+Ga1GCKbW3o2j/mNxTvZfE899IoTvHAw8Uz5IQNcNmWk1mc05LhVT0URXJTLLhlshacX2h0IBIdH8vwDVQDUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) by IA1PR11MB7920.namprd11.prod.outlook.com (2603:10b6:208:3fc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.7; Sat, 31 Jan 2026 00:59:23 +0000 Received: from PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::e0c5:6cd8:6e67:dc0c]) by PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::e0c5:6cd8:6e67:dc0c%6]) with mapi id 15.20.9564.008; Sat, 31 Jan 2026 00:59:23 +0000 Date: Fri, 30 Jan 2026 16:59:20 -0800 From: Matthew Brost To: Andrew Morton CC: Thomas =?iso-8859-1?Q?Hellstr=F6m?= , , Ralph Campbell , Christoph Hellwig , Jason Gunthorpe , "Jason Gunthorpe" , Leon Romanovsky , , , Subject: Re: [PATCH] mm/hmm: Fix a hmm_range_fault() livelock / starvation problem Message-ID: References: <20260130144529.79909-1-thomas.hellstrom@linux.intel.com> <20260130100013.fb1ce1cd5bd7a440087c7b37@linux-foundation.org> <20260130123810.61dde600422a8fe01cff8296@linux-foundation.org> <20260130130835.10d004cd79d67c55b10def74@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260130130835.10d004cd79d67c55b10def74@linux-foundation.org> X-ClientProxiedBy: MW4P223CA0011.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::16) To PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6522:EE_|IA1PR11MB7920:EE_ X-MS-Office365-Filtering-Correlation-Id: dfaf8258-ff11-4d44-2808-08de6063f916 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RzJjZzZrakZpTktCQjBMUEZLTDRacDRpWGExMFJqY2lUTlZNd3VnaEorYlFU?= =?utf-8?B?ZEkyUUo3QlFZZzVFT0hSQ0JCWlhnYldIbjE3R3pzelE4T1FpRzk4eHZEU240?= =?utf-8?B?eDNVaFRENUY3eC9FSlZwaER5TDRTcmZYblF1d2prdS9DT2FGNFZXeEY0NjN3?= =?utf-8?B?MjFYbVd0YzY1OFFLeWVWUFNNSVJSaFFmd0RpV0JETGd2Q3dlN3hQVVd4a3lq?= =?utf-8?B?QXkxVWk2UDZ0ZlcybllJQTRydkMwQm5PZFBsd21wYjU2ZkM1YUVCYmlNZHYv?= =?utf-8?B?MXNNdEZCQngzVVdIVWZEN1BqUURmVUlvMzBlQXR6RmI5dVZmZHE5VmNMVUNs?= =?utf-8?B?YVF2YmVzZUlzMGUyeEZzM2tCd0pNaXAxMkNUNFcvWFdBVHF5MDVMMUROLzFH?= =?utf-8?B?ZWtXRFJoN3lEZmtCRHhJZXdXWXNOSHQvMGNHOXpvRnRSYnAreUU0ZW16aDBO?= =?utf-8?B?VFZaYzIrZXRiWEg4T2F3a1Bsc29xVDlhclMzYzNPbFJ2cFVERWNjOGhBby9Y?= =?utf-8?B?bWQ2MkVmVnJxWnMwaDRpNEJHVjY0MWNYbHJza3p1dFBUbU5mazRrNFBYQzRM?= =?utf-8?B?TlN1eGtsOVJZUGRtbkFpWGt5d0FLcm5VaFFpYVNzUVFBZ1pnYnkvdDhlTys2?= =?utf-8?B?dzFnY0F3djJRSzlDby9hb0xwQU8yeFQyYkZJeEdveitxV3l0bFM3bmNiQndr?= =?utf-8?B?TFcxUE1pb1I0OFdjMG9XQkxGRGkyQmZyeFZyekxzMUYwR294M0JnL2cwdmM0?= =?utf-8?B?VFJGWjUrTmxEVDQ4OGxQdDVZNHExQkI5MnV2SjU5VFEwMDN2UnBoQ2IxUFNn?= =?utf-8?B?R0NiL3ZzOEQvVnU0VFlhdTlvRW5TRE1HS3RGSUJJOXIxdExEZmZybjVsVUhr?= =?utf-8?B?OUZvY25HeEgrNENzWWNRcmljL0dxSHdaWEQ1YUZiM0xUeEJ0aW1nM0h0YWtV?= =?utf-8?B?dVZ3bmdTZVBYeS9uZmVsWU5Sc3ArT1J6OU5mdjVvaEFUTGNPalliSDVsRTVt?= =?utf-8?B?WWE5MFFlZ1lNT2tZVmd2QXIvTXdZR2xKbVhxV3pLWWlCbFJzaUdHWmtKVUhM?= =?utf-8?B?RGpFMStSMXdVWWdSL0lkOTlVQXUvMWt0ZXhFTThGL3NkSXNvOHkzQmYvdklk?= =?utf-8?B?WEZlOGxvRkxvVTFXcmFMREsyRGMwZnZ0UUVtc21xcmIwdEhIaGpNREl0QnF6?= =?utf-8?B?L3JjMFhxbGpqcXg4cTZ4T05iN0xOVmxIemtpSUdxM1A3NnFBUFc2bmo0ODNQ?= =?utf-8?B?cm5admhSL2dCUURkU3RLRFdueWlYQktRMkZXSFM0d3RQUndNOEd5V2JsWW1s?= =?utf-8?B?cVF0VjJzVVc2amZsaGlDYm1INDROc1lIZ3hNc21Vc1BpQnAxTWpoMEk2aGNI?= =?utf-8?B?dmlkNzY2QXppV2wrYVhKOGR4alRaVTZ1OGwyR2ZUbk43WHpGeW9mUzk1VEhV?= =?utf-8?B?cENRM09Mb3lyaE5rSEhRVGt6b2p4Y0NPL1hqUmhPenNXdkFkaHAyRlkxa2RO?= =?utf-8?B?dUs1MmRuMFNOWHlNcWNpRXpOV1dXNlpWSWx3RjJDejNReTRGKzBSY1V6aTFh?= =?utf-8?B?cUgxTGVXRTJvL0FvdHZUcFlTNWdlZitsM3ovNUkwRmg4T2ZLSnYwZzM1UTVP?= =?utf-8?B?cUkvdzN6MEJZc29tTUxlcVhPeS9EdlMwNUZXWUdkSGFzYjJIWFYyU2x1b1Ux?= =?utf-8?B?L1oyRm4vQzhwK3JiQjE0M0pKaGM5a3VDNjE0aW9rQ0Zvek4wNEptRm1yMDdQ?= =?utf-8?B?ai80c3NqNFJWVlhXN3J0Q2ZLUGdZTzBsMUJzU1JidklmMVBhaWJGQ243bmh6?= =?utf-8?B?Mm9KNEJBU2Q3dmlCZVlXQnFGRVFSUEhnQk4wRkszQkpkcGRqNjh5K0ZyQzAx?= =?utf-8?B?a0hUdWxMTzBBU2VOclBSVXdwcnM3K2ZHOUtkUHU0QktFVHJxd3B2Y2hGMGVz?= =?utf-8?B?MFZ1bUltM3Rxd002SGRKS1RYR3VCWEJLdTI2eHFudVF1VmtsdlVFdGFyOUJ3?= =?utf-8?B?aDhRVDJFRk1wSWtUQ29pZTRteksxWFYyZFJUalArMEt6UTdSSGwvWVZFelQw?= =?utf-8?B?TDhaU085cGVDZVlQays5SVR5WjRjeDZQb1VxTHdKZEhyUUdBN2x6YTkzdzFt?= =?utf-8?Q?KNdo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6522.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0N5RU9VcDZPOWZIM004cndDVzZXMU02elUvNHVxVTRtK2hhTzVhaDJaQlV3?= =?utf-8?B?clY2MDdYK2FLUEU1NHVFRGh2Y2h0YmRaS0dhNy8zR0pyb1lESVJrSC9zQXV2?= =?utf-8?B?Q2duTkJISjV2NGo3a2V5aUJiaGFWZ0lwLzJ1aE12UllYNytwaFZscEJLcC82?= =?utf-8?B?cDQ2cUdFZXlrdFpnTi83cjFKcXZSZnRCV2dYMEVZOTlwSjNkM2VPUXVjMmZK?= =?utf-8?B?ODV5YlNyUW1OUUduZlhxSnRvQW40dWJMU3pTSXR5U3JEMlJPSHB4dlQzMjRI?= =?utf-8?B?U0FzUmxGTGo3KzZrLzBZWHFMN2x6a2ZtUHRicG9sU0lFa1ZBTHVGNG9wZEgy?= =?utf-8?B?QzFucGFvWWlwUkZSYjQ3MGFtQnFUeU5QVkxWQlFCbUhJZUVNOU9LMktzK2c1?= =?utf-8?B?QkZ2WjFjSmFCVEN4dEFhdzRxaXVkci9HWGllWmMzV04zUEhJK0k3SkdSd3R6?= =?utf-8?B?cmxOV0RJWGcxWEE2L1VmN3ZnTEtBSUx0cW85RnhXd1pGWkdvV24va0hIRVZN?= =?utf-8?B?VmFDMHpHbHgwNTBNS0ZnRG1lK3ZiTmx1TFVvdDYvL2laNU5LV3I1Vm5UMmYv?= =?utf-8?B?OWVIVng0d1E0b1ZSYXVrSmNFMEUzYWt6U3VObTRyOUdFdElrWEhacFl3SS9X?= =?utf-8?B?SWxTVWUwLzFRb2lLZ3krVlBaeE9YamdDb3pGTFpUQTlXdk14TDlWU2VkQi9N?= =?utf-8?B?Z3pzc0pVR3J6MHgyMDZ4QzBEeHErNThtdzZtb3BBeVA1d2M0QXRnWFNYMUE2?= =?utf-8?B?VjBuZGcwUnBvYTJMcDZWbWErTWpjMFRGVGZzZVpWNjRRTk84K2w4b3ROMk5i?= =?utf-8?B?Q1AxalI2WWNaV0ZXdEdJNWVEWTNRQjQ5SmJ5NjBCNVlQSDQ1d0JNWFVMRUVB?= =?utf-8?B?NnFDTXR2TGZWNzRZQThQc2tmODJNUmsyL2hZSi9YbG43ZzJOeUY4TG5vRHhN?= =?utf-8?B?KzZuKzc3dEJUMFNXWjdyRGlCMFlHTlZreFMvN3c3WFNYK1RZd0pXRnFQWEt6?= =?utf-8?B?aXNkOWkya28vc0djZGRqZzhIM09BVzR6Zk11elI3czZkTUQyYm5iSXBxTUxt?= =?utf-8?B?Z01EK1c1LytjNG1BK09XTzdqNTcyc3UyN0hqZmxmR0RJMkZRVklnZzBFN2Ry?= =?utf-8?B?SHI4ck15ZE1TbUlxZTlLbXM4eUNlZElaZ05YKzZvNldybEpxWHJIWG1wamZO?= =?utf-8?B?Z0UwdFpUZGJSWFc5SnRTb3FOYVFwbUxHc2lmaC9ENXByZVBGMVpYMHhuYU40?= =?utf-8?B?YXpFN3pwb09OUkovK0s5a25DRG56K2c5cE4vb3orSnJ6b3dzLzhQWEJ3RnJy?= =?utf-8?B?OGxHY1YwbkU5T2w4KyttamE5MmNRYkkzMGVMb2I0WHpVUlh0QjNwclFLSlpu?= =?utf-8?B?NE5jNTV5WFRBemx0SGNOR0pwQzRaUTBVbWlPTGdBLzZKOThsNDJjOHFBanFW?= =?utf-8?B?NDNBRGVEcTNoeWcvYjZMb0h3RWVXNklmckdwcGEwYk1RZnMxUmpjbW5DZkpB?= =?utf-8?B?aGh3T1dWLzZPM0NpM2VnL2RMVmlaVU00WWc5dHZYMWJ6c08wcENuMXhRNHh1?= =?utf-8?B?R1dNbFBncVBESE10RytuU0podEJXN2RIclNIQUVEcGFGZkUwQkE5M25tcnlN?= =?utf-8?B?RU1rbFJNZjA4WUNyOXBLUWZ1QWU5azZEc3ptL1lsVmd4OWJ3SjBET1RUMmZ1?= =?utf-8?B?UDd2K0hSeVZpQURpcjc0UmEvd1ZTVXFGZDJ5WGtxbUxxa2FDaW9LL255TFNN?= =?utf-8?B?VFBQaXEvNHRid3gyRUVXT2FmMWJXTmtNRmlGdU5SVC9Sa2ZDaFdDWEhNSjhQ?= =?utf-8?B?TFg3LzJXS2U2RGZvbkJHV3R0aXZzelg3NWVaaGZmVmpENHVneFZSTmF5VGtK?= =?utf-8?B?Q2llZ3ZxVzdURUdVTU8wRHNqaC9BQWV2dktKOUkrQm41SnVsN3Iva0QxY0U1?= =?utf-8?B?MC9zREdvMVFCcmFDYnF5aERtSDZpMzl6c05lN2hteFJQdUMzMUx3NENJSGJm?= =?utf-8?B?MmtsSkhKYjE5amRiTmtLYzR0RFNhdi9vYlIzdlJKQlkzems0YlJTeUZPOS82?= =?utf-8?B?TU1KTkZrdWN0L1d3WUlsbFNiSllNZk1XY3RyaXRYQjRJVUtQUkc4UUFNU0FU?= =?utf-8?B?RVMraXNFMDJIU1Jia0xZKzFpZXNYQVFrUFgzamt1ODh4MVRQWnd0dzZ1eVBD?= =?utf-8?B?Q25xOHhzTHJMaDVhcjN5elRSbXZOaWNheUh6ZEkxYW9MUU56MGZKVGRnVUZU?= =?utf-8?B?MkMxZUtrOW9iSU5JbVhVdDJzK0pqRnNjMkV6SjU3NitBdGd4S2FjVGVUemQ5?= =?utf-8?B?bmhROVpsbXd1bGhtTlQ1QVJQcmthWkVLMUVrMk1rd3lSMExKcmNNQT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: dfaf8258-ff11-4d44-2808-08de6063f916 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2026 00:59:23.2124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5YVuwy7ooaPQDiFQK2cjOJn+jep2rAHoD7Qi6w5/5FLs5eSRV+pZYVeoSCesnU4oDL8U3nhMdvjT9SaAlPDeCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7920 X-OriginatorOrg: intel.com X-DKIM: signer='intel.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-DKIM: signer='@intel.com' status='pass' reason='' X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 On Fri, Jan 30, 2026 at 01:08:35PM -0800, Andrew Morton wrote: > On Fri, 30 Jan 2026 13:01:24 -0800 Matthew Brost wrote: > > > > > Unfortunately hmm_range_fault() is typically called from a gpu > > > > pagefault handler and it's crucial to get the gpu up and running again > > > > as fast as possible. > > > > > > Would a millisecond matter? Regular old preemption will often cause > > > longer delays. > > > > > > > I think millisecond is too high. We are aiming to GPU page faults > > serviced in 10-15us of CPU time (GPU copy time varies based on size of > > fault / copy bus speed but still at most 200us). > > But it's a rare case? > Not that rare. I believe this code path — where hmm_range_fault returns -EBUSY — can be triggered any time HMM_PFN_REQ_FAULT is set and a page needs to be faulted in. We don't set HMM_PFN_REQ_FAULT in our GPU fault handler unless migrations are racing, which should indeed be rare with well behaved user space. But there are other cases, such as userptr binds, that do set HMM_PFN_REQ_FAULT, where it's somewhat expected to fault in a bunch of CPU pages. Doing an msleep probably isn’t a great idea in core code that a bunch of drivers call, unless this is truly the last resort. > Am I incorrect in believing that getting preempted will cause latencies > much larger than this? > I'm not really sure — I'm not a scheduling expert — but from my research I think preemption is still less than 1ms, and in cases where you don't preempt, cond_resched() is basically free. > > Matt > > > > > > Is there a way we could test for the cases where cond_resched() doesn't > > > > work and in that case instead call sched_yield(), at least on -EBUSY > > > > errors? > > > > > > kernel-internal sched_yield() was taken away years ago and I don't > > > think there's a replacement, particularly one which will cause a > > > realtime-policy task to yield to a non-rt-policy one. > > > > > > It's common for kernel code to forget that it could have realtime > > > policy - we probably have potential lockups in various places. > > > > > > I suggest you rerun your testcase with this patch using `chrt -r', see > > > if my speculation is correct. > > Please? Thomas is in Europe, so he’s already done for the day. But I tested this fix and verified that it resolves the hang we were seeing. I also did at least 10 runs with chrt -r 1, chrt -r 50, and chrt -r 99. I couldn’t get it to hang — previously I could reproduce the hang in at most 2 runs. In this test case all threads are on work queues, which I believe can bypass real-time scheduling policies, so that likely explains the chrt result. I think we’d have to craft a test case that triggers an hmm_range_fault from a user space call (userptr binds would do this) and race it with a migration to catch any RT bugs. Matt From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id WH03AuFYfWl6mjMAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 01:20:33 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 01:20:33 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vlzf6-0000000EHER-2j1y for hi@josie.lol; Sat, 31 Jan 2026 01:20:32 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 602B3302B3A2 for ; Sat, 31 Jan 2026 01:20:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4A4143254B4; Sat, 31 Jan 2026 01:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="C3XaXnr/" X-Original-To: io-uring@vger.kernel.org Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5BAF2F616E for ; Sat, 31 Jan 2026 01:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769822416; cv=none; b=Qi5Sg+2Y/hnoJw2pIpjLFfTHXgK+MVDreSWsts20bQdg5dVC+wFcafkiMX+hlv4VSM1boBtLg7oe93gfdn3YJpDKc6xJCYX8zPA0p/8p/8XKuA0JbmYC2oJGtEA4TKjr3qI55XrsNVppz1JDPX7g+pfivvEXZfUNlUq+u6lWbc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769822416; c=relaxed/simple; bh=LqjG26iPcgUJUjdKHHQUCfcuvzKdnJ4bXKdhZ7B7/mk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qqSJXfBEHmWRI+5t9Czg8WsBMGxJzHYQOdOtb7UMHtxKykeBFvqJxGLfR6uXEqdY26CVCsCPFYvsnioB0mdYh2n5k/qmxp+tXzG5lKxCZ85thg4vS4l2n1y7If6IRh1CCytt23ayPTxk0q4t0ffaPs0yLNmDA1tdo7bTUkcZFL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=C3XaXnr/; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b8863db032dso444219366b.0 for ; Fri, 30 Jan 2026 17:20:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1769822413; x=1770427213; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=X+Zsir5E/r34txHH39Th9Cb+s5GtaeVJrYm06jsRDB0=; b=C3XaXnr/FF6cIAzaxerJOqcXEXJ/Fa6W2MhMyzCzozQs3rRMXUq5fYZqLTp4bPNcmK We9PIwTdP8jJcxo6tdZH0nrPfK8Lyw4qDIhiJUSzb2Dhd+X1DfddffqbeH3kHrnGMurw Di5zx1SXZpi8IKYMnH1jXy7Asc/GxFcQBgMBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769822413; x=1770427213; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X+Zsir5E/r34txHH39Th9Cb+s5GtaeVJrYm06jsRDB0=; b=LqXDExCebqrQBWTmYNDCWSPY5KpmsgarqDhLe7L76EKL6iYAXZS+3AtiikxtkT1yHt Ezmk+SUdI5aaZF6YjkY+24zOAfHTxl9q7STKVhmNu/kU9AsBVSmz0cttIbcR/BMc5fJ5 CO2X84dLzRpRHCqCQ2NCz5V6igFjAWPss42Ys0QRDBFUxUJM/lG3etgBA9FI2ykSsL71 ++YP5QFTmgNnyillPIi2hMel+vUmNMTMzK2IxI+LUtmfic3peV3U/HLYuy3rmhDnulrr h0es45rednCh5uYl18/NAwD9lJHGUqOUklvpvrVVRosu7H30r9uM6ACwsFRG3nxKP2nf aFUw== X-Forwarded-Encrypted: i=1; AJvYcCUt+hdQ4TiKI1pvgjF/F1M2PJHAmyACowB81KpN0zynvUNEtATbudYuh7JMvSKFG4bap21EYG1cHw==@vger.kernel.org X-Gm-Message-State: AOJu0YwqTMS+C3JxzY+MV/F5XpHiTSKXPq+Bft0n+7KbvgwNQR5+ZUIZ SYZ3ntdLTc1StmXWiLvAHo+dEk2UeUnD1LrXj+9Gux0q+hED2vs5rO2mk6hjLzddfmLfmtDjt42 w2dhAhr1PaA== X-Gm-Gg: AZuq6aIqYkNuIa+6gEZ/jcHacyDzoIO/BUm/+XsvkcxdyZbAmcrOLLyU66Mf/FcPgLD 6AJAulyjrSIefHJyISTRhWLtfiVi/o1Ye7mKS+3YsZORja/IH+xaxhBj62FjnXKzt+YXgFbDBPW CMmQbaoOgsO7PFgH8SWKf+56q7//mxMSV0Ec9ad7ewuHJ+abGig+ItXgsRdAfYJEk8vTpaj2g3o 3UVB63x+MlnYlL42rmsBuiEJnpeV3FV9sd7eeMizfzlcBMqRGWM2GQv1aLPPkkoNyKlYbm+R1f8 OBgdUoFexbKwW4TOZk7rm7yBLhbAYQbXwwzouscJQGT+01ZCWajwA09ilfr4TDAVBmeZpUI6Ua5 LtU5vTfoOAX3ur5s6ZoyT5IAAvfV1fKSa6Za0816HvhFiH7KDQGUhWrEZQX7PfmWmjj+6fbV3G3 nL1U/+8eFbdK5fminRvdNJi8aMXTDK3M9FemPAAfls3CdtPOO71SgSAhC8+sMa X-Received: by 2002:a17:907:9608:b0:b8d:f6f1:e27a with SMTP id a640c23a62f3a-b8dff882467mr246378666b.65.1769822412898; Fri, 30 Jan 2026 17:20:12 -0800 (PST) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1c0213sm506198266b.48.2026.01.30.17.20.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 17:20:12 -0800 (PST) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b8871718b00so470215766b.3 for ; Fri, 30 Jan 2026 17:20:11 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXJnrxb14pasrqq5y/M8MwpnyWnr8kmDmRp/K0FyCvf80xpwnfEBUWJJ29ny/xjnOT3MRM+MxwoCg==@vger.kernel.org X-Received: by 2002:a17:906:6a1f:b0:b87:701d:341a with SMTP id a640c23a62f3a-b8dff607a33mr279550266b.25.1769822411525; Fri, 30 Jan 2026 17:20:11 -0800 (PST) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260130-getsockopt-v1-0-9154fcff6f95@debian.org> <20260130205227.6fb1d9ad@pumpkin> In-Reply-To: <20260130205227.6fb1d9ad@pumpkin> From: Linus Torvalds Date: Fri, 30 Jan 2026 17:19:55 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_QicYb2Y4IsMdcHkp6aaLn_xxvWlOuA7e1nJwap4TdBtycKshhvQFgQOM3M Message-ID: Subject: Re: [PATCH net-next RFC 0/3] net: move .getsockopt away from __user buffers To: David Laight Cc: Breno Leitao , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , metze@samba.org, axboe@kernel.dk, Stanislav Fomichev , io-uring@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" X-DKIM: signer='linux-foundation.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: linux-foundation.org] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On Fri, 30 Jan 2026 at 14:40, David Laight wrote: > > There is not much point making the 'optval' parameter more than > a structure of a user and kernel address - one of which will be NULL. That's exactly what we do *NOT* want. Because people will get it wrong, and then we're back to the bad old days where trivial bugs result in security issues. Can you point to an actual case where setsockopt / getsockopt would be performance-critical? Typically you do it once or twice. Linus From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id QGA/DDFpfWkf4zkAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 02:30:09 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 02:30:09 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm0kS-0000000GBPc-3ead for hi@josie.lol; Sat, 31 Jan 2026 02:30:09 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 7CA9F300C913 for ; Sat, 31 Jan 2026 02:30:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BE4C30DEA7; Sat, 31 Jan 2026 02:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernelci-org.20230601.gappssmtp.com header.i=@kernelci-org.20230601.gappssmtp.com header.b="SWfpZEbt" X-Original-To: stable@vger.kernel.org Received: from mail-dl1-f66.google.com (mail-dl1-f66.google.com [74.125.82.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC31C30F808 for ; Sat, 31 Jan 2026 02:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769826606; cv=none; b=nwIIhjr1plBeYJAYDIGzAA4K9uKMxzPT4cfwUh6BIdfkXDzwkLzyGBMHjolVZHqcGjGgRIa1uvJaKeIWUtso1RhE8nwdQsMw1/XphNzqX6tjY5k9pYCtMrV6tSr65SlPPwDxGulTWishaFtr28AXanBafCiHBkF4j0jIu7N1nTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769826606; c=relaxed/simple; bh=aawpH01g3NlljyX4vMWX6V5ZcLZAMf3+k7RK0tyEr1I=; h=Content-Type:MIME-Version:Subject:From:To:Cc:Date:Message-ID; b=XLxihbhpd+U/8k6cxgQKdNtjJA2YGQ66Kh6Rbinf/vdAAZWIF2ydU0UfMoseeGF73QPE16AIohXRqnuxSOHEKRy6y5hY9pn82Ak2X/jgSTcij/1IpUZxDobAGYQ+NDouHCqPqVIL2dY+rsGHavN/hLkl2kXbaOmpSfzBllbvi9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernelci.org; spf=none smtp.mailfrom=kernelci.org; dkim=pass (2048-bit key) header.d=kernelci-org.20230601.gappssmtp.com header.i=@kernelci-org.20230601.gappssmtp.com header.b=SWfpZEbt; arc=none smtp.client-ip=74.125.82.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernelci.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=kernelci.org Received: by mail-dl1-f66.google.com with SMTP id a92af1059eb24-1248d27f2b9so3919110c88.0 for ; Fri, 30 Jan 2026 18:30:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20230601.gappssmtp.com; s=20230601; t=1769826604; x=1770431404; darn=vger.kernel.org; h=message-id:date:reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=63ki0YpAxle07rAQjlDknWShS7mPY1SLG3TD9Ihu/4M=; b=SWfpZEbtnyLod1diEwqVeqnqY3pG3YdsqcLi/sGXTn4mtdotMqRsxyjxr8z5PpP/RM sflBefKSQ+BzO57jiFN3JdGHqJefhFRu2GuOw+ahe8uwI2QTLAIjxQvTMzKIgXuaCJx3 awm5r47dR+hM2nrouWZOJ9gQfW3F81gHjfjXZm/wBn3HtVOYHHih9Hl+coEP8Syv4cmE Dp0K9FTwKAB2eB5qhe9s24UIAn5rh8Xek5MrYbFQgUs3dE1gSGgle+MpuYmQoBYCx0DZ skjH0azaC545umUX48Kqi2tYqo3BkeRbo+ajlsIbmBNaA3KSy5qZrDRtzCP2Ye39r9Xa FQNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769826604; x=1770431404; h=message-id:date:reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=63ki0YpAxle07rAQjlDknWShS7mPY1SLG3TD9Ihu/4M=; b=gY9hF5Oc0ktjtT8/ozMvwFfW9eObH/gCTjvuCSG3DhwytDJSnKA/mUQExeekVOozON JGWsWwX+/kKjHKReP3dpbEDvnuvVrmausYusCk8NbYPKMd7JUIfAtFueB1BYd7QA2DZV 3h98ujiBidJyT7CG3NFOmfmxsl+S18ez0otkUDz3B5NAw1UHMlQID4i/dklYedhmnlfy hdnnvlSpotblygIpMXYd5Sb3tNv/py/A5KT+1m7bAQfjkLmYQf7xIXvoFCGKMEO/KVJw iFoTLtaA56ZEsl8W1XxLF0VE2OpltrYlxnx6VlopLEFArkG7lyJOndULG3Yvzu7GYiZx d7yw== X-Gm-Message-State: AOJu0YwX6JXew9C8lvQTRau4B3UO2RwtxIi2l8vV+l57XHQm/+UHmILB IrmsYAlfHnWuCJWXvZGoAaT25QWVQcKKWGG9S5EZq07Lvl0mnvY7uD/WIrSzZAyIz05fHQmsziv koGn983E= X-Gm-Gg: AZuq6aKX1mZLkjNzARo/0guHw+Jq4Hu59ts4NK/lDfM7SBu5OrScaVjRitdfmZOwFhj vxGIVP7uGtr+FYnMMR1wvoj2UoQuFzS3eXpgyyQmvU6/D5tpxXkkHVvbNL4l15QGz2Ku4LpQVAs KDOKAQd39jgOcz92IFW+b+Soaacpki+w/rJWYollMtdQJoFwXtfLsoY15Fwzrts802LydDe5oR8 6QPrmUab0L7mjeQA0Bl7Pfi3luSvIy9hD5cJp64kRsUQYJiPRLNVNhgYU8EzrF9KATGfxV/4DHl /Pocpgnf3BAEEY+1zRTlL7rNgV8XpD6hW4mYL+3CU2EDqZAixIZrM6cq7uPXJ7rfAGNEuKZvgDT Ewoe/paz7HI6maEx9QEmY9Ipw1kpswLY5z2Ox/8Z8aBADOGEox/qUXW/q14tAA/7Z8/WxHtNKXB nxmlNt X-Received: by 2002:a05:7022:78a:b0:124:9acd:3bd0 with SMTP id a92af1059eb24-125c0f9a94bmr2636358c88.5.1769826603832; Fri, 30 Jan 2026 18:30:03 -0800 (PST) Received: from 22d5995788c3 ([20.38.40.137]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9efd3b8sm12242958c88.17.2026.01.30.18.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 18:30:03 -0800 (PST) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [STATUS] stable/linux-6.6.y - 2cf6f68313dcc3c404f49fdee41bbf3c694ad75d From: KernelCI bot To: kernelci-results@groups.io Cc: stable@vger.kernel.org Reply-To: kernelci@lists.linux.dev Date: Sat, 31 Jan 2026 02:30:02 -0000 Message-ID: <176982660229.4838.1045825830629279728@22d5995788c3> X-DKIM: signer='kernelci-org.20230601.gappssmtp.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: kernelci.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FUZZY_CPILL BODY: Attempt to obfuscate words in spam -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 Hello, Status summary for stable/linux-6.6.y Dashboard: https://d.kernelci.org/c/stable/linux-6.6.y/2cf6f68313dcc3c404f49fdee41bbf3c694ad75d/ giturl: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git branch: linux-6.6.y commit hash: 2cf6f68313dcc3c404f49fdee41bbf3c694ad75d origin: maestro test start time: 2026-01-30 09:35:43.026000+00:00 Builds: 40 ✅ 0 ❌ 0 ⚠️ Boots: 48 ✅ 0 ❌ 0 ⚠️ Tests: 1481 ✅ 211 ❌ 554 ⚠️ ### POSSIBLE REGRESSIONS No possible regressions observed. ### FIXED REGRESSIONS Hardware: beaglebone-black > Config: multi_v7_defconfig - Architecture/compiler: arm/gcc-14 - ltp last run: https://d.kernelci.org/test/maestro:697c8256a1ae387ffbb6856e history: > ❌ > ❌ > ❌ > ✅ > ✅ ### UNSTABLE TESTS No unstable tests observed. Sent every day if there were changes in the past 24 hours. Legend: ✅ PASS ❌ FAIL ⚠️ INCONCLUSIVE -- This is an experimental report format. Please send feedback in! Talk to us at kernelci@lists.linux.dev Made with love by the KernelCI team - https://kernelci.org From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id sFGxAYVsfWm+aDsAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 02:44:21 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 02:44:21 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm0yC-0000000GYVV-3Cqw for hi@josie.lol; Sat, 31 Jan 2026 02:44:20 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 0751D3017532 for ; Sat, 31 Jan 2026 02:44:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 359CB30F943; Sat, 31 Jan 2026 02:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="hO9cHJa9" X-Original-To: stable@vger.kernel.org Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012015.outbound.protection.outlook.com [40.93.195.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 707211624D5 for ; Sat, 31 Jan 2026 02:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769827458; cv=fail; b=sHkU68kCin/h2SB2xC/XFt5w9JRARycmwzm3+EOWhcpXCOvOchJtqy8wCdh0R74e2DBS1pJwgckfkWrv2EbzUi0A8iGJTYIRcJMULDEneGHSrobDSiZKaTkzugaiU2hcCb+L0pKHZaklfr6OUbsVghMOACu4dP4Rq7E82HQgh7s= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769827458; c=relaxed/simple; bh=o5wBj30Yv22kfAXPSllFlE2m4MtMzS2nDHTD8+vBdhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=R6KQFVZtgh/6ToBxGRkMS25nDCoiisQgB4eIBStS+wbxSvI0MqnZkxd8EcFpOfeA+mha43hpcRElxbsDNapY1JvswqhJReIsifOS9Qsp6VfEqaCUUOUn/j4Zjrdj11XsvpQPlAnD12bMR13raY26PCsAT/eqUYzmJGZ4fRxPRR0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=hO9cHJa9; arc=fail smtp.client-ip=40.93.195.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JM/WvrQ5deU09h/tIA8nd+zBj+TNMDMFXJVXfHUMg7JeqCCNQkA1fWIzlYPmx6/gStHcS1OaR+Ei4l49wii9fo+Thsy0EwFO7loFm2+Z5pcd2FlgVaL8WKtskmIJOuw0BDwpd7Ee5kX/Chd/2IvCBkGlDGSS2xCC8NTmEiUdobDOXU3UJwZTkWtyZhXxeQJwI29X25T1e3HwZAjrQBwQtFGDukPN7evMGx4chdKIkL1sEogqJWL5+zwzgAIgFa6pi69HVJEUQfgkxfeVpbaQVr6hMx5KbyBpISF1oEstESyAzZ3yKTKD/Ih2kbsAFO7CP9ShvS0zipQEEUqIlQcRww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D/B/sX93QcqXgtlSsA08JkRxXjLNVt0vkhM9/8eoyEg=; b=sCRlAOdjmeQ8U8dclatF8SyLZ58k5xJP1E02AEFLcFSAX5emUMV3PilY8ZJ4M0Mh5MUhH/DpqQwMvE3BFWxHGsFxrWX3NHA+BKOvXGFrGqblE+3EjjASLyiPzLBDkjN6K3s9bKpg+iG2Vhqmu5gOHcXew0hK2oEwiVuflTHTi7O9iguAQLYPWDsMU8n/zxuhQq75EsN58PGCqGF8eRyLdRwar+Q8+5hTuc1MD5GhMLdTdU0YDg7wgZi7BOjCHwMlSAx63jXPXO5HY4+dEvvxxfM4ks48yZsqPgtlh/eTHB71ofFnmny2n5gGEYhSDOh20dXiziASronOHIl5hZXUEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D/B/sX93QcqXgtlSsA08JkRxXjLNVt0vkhM9/8eoyEg=; b=hO9cHJa9KHcXm3PLcceiI+c9zEW73Moiq4AtuILYGkN4ZlCkBAqOBnh7/PuWY0A7hH4nahOszv//siT0nT1sTlzRmMrySXe4fvZPg0dzsU4cbiqBFcxTt6wJDLAnk/VZRQ74o+5NxPCCe+EXqOiPMdN131H1AJOzXEwY4dl9c/ifK6Ll6Ptwh3TSk/8q9SojPmF/MY4YXaVk5gepvW+YgRaxIVom17Yu9QAmmkplK/bfUDIQZkGkAn32gqBqGznrAeEiSoaadyAvUVLO8jKnqyXRlq9QnkEO+IXwnzAa9KU1T12tB/5Z6IKGn7oOknlcpTWTjymR+AocGeOoGomr6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by BY5PR12MB4132.namprd12.prod.outlook.com (2603:10b6:a03:209::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.13; Sat, 31 Jan 2026 02:44:12 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9564.010; Sat, 31 Jan 2026 02:44:12 +0000 From: Zi Yan To: Wei Yang Cc: akpm@linux-foundation.org, david@kernel.org, lorenzo.stoakes@oracle.com, riel@surriel.com, Liam.Howlett@oracle.com, vbabka@suse.cz, harry.yoo@oracle.com, jannh@google.com, gavinguo@igalia.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/huge_memory: fix early failure try_to_migrate() when split huge pmd for shared thp Date: Fri, 30 Jan 2026 21:44:10 -0500 X-Mailer: MailMate (2.0r6290) Message-ID: <178ADAB8-50AB-452F-B25F-6E145DEAA44C@nvidia.com> In-Reply-To: <20260130230058.11471-1-richard.weiyang@gmail.com> References: <20260130230058.11471-1-richard.weiyang@gmail.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR08CA0001.namprd08.prod.outlook.com (2603:10b6:208:239::6) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|BY5PR12MB4132:EE_ X-MS-Office365-Filtering-Correlation-Id: 242c6065-33dd-4b9d-ec8b-08de60729dbf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?d8x7qVDju8IXkoouSHdLbQdBd+jLnX8iSOKtxdI+twlNrhWvemRlZzEp5f0j?= =?us-ascii?Q?0iwU9RkLQLf0ylJKb3Gc9LmusIYjNSTseZSwe9wGQLCgn+58IW1FtanDtF48?= =?us-ascii?Q?pOdT0X3JYZP7JSjtU8CxlgmMtnQGZSwfkAT0LOeqIt/vpHFYX2rlKOg2Ws9O?= =?us-ascii?Q?tHJLrEz7PV42tvGYwSGM2W723D/GdB0XiNqNR5fpqca/jbTpGKlVSmUXMO+3?= =?us-ascii?Q?oQz3zwbunX2A1qqNYb+nly96slRw4Byk4Re94JDxqj3ifyz1nzLqc5FSTeP+?= =?us-ascii?Q?dLKwbUcSD0zAhbMQIC5wo9fIekyyFnsDGRmfvrlkQP5DWWQDGCerfkdQ75b+?= =?us-ascii?Q?Ogu80+PMewkv0a6fyLAXCaosMBOowPtlbgS1jROMlvJl9ZfN8Gk0oYAI7K+8?= =?us-ascii?Q?fEYoKPlrWHez4Xj2SMalEQ23Q0XWvtwlJ7ky+6fXmcSbn+uTUWTQjL2HPgor?= =?us-ascii?Q?LjscGpwmLZIprPSmlMyjpfKHDqaBayuK25ERIzWq4T74/gqYmXjI7p1FpCfd?= =?us-ascii?Q?L4xCaV7eUZuFro4CvH97WUEMGd3AusJqRKWvVjVtPMB8NAZrIv1niuILBpt2?= =?us-ascii?Q?Lr+VKaf5EN5zZjOTiWneKxYI9/s34uIEnXFpjEpiISF0wk47umhyLTSDDQsT?= =?us-ascii?Q?e8L+WWvw2HIagpvfrcCSw2c2JhO9+sHgdnSYj2rWeyjDsRLCvoZlCohrceMZ?= =?us-ascii?Q?CHp6Jui63JtAB/5iDwlB4xRV36wTUflZ334kaqUoePXVjbsJ9GwJVFobETIu?= =?us-ascii?Q?hsTpz86zOg0MsRol1T6UQoYFlL825glg0snKnXincKne+NODDDI4iSY70MKY?= =?us-ascii?Q?UpzEpI62LKgsMrU6VEdOjQ8CXHRHK0/ED1VCOZuPpAUdYK6Q64HZ6F2bV83Y?= =?us-ascii?Q?3KWVOmThOMJeqpOq+V0dgpATAOM2xC3ayD25FkCd48r19dXjkE/LfYhJ7NL3?= =?us-ascii?Q?cfR+Y0la2C1iTdci8eh2BFF8iQciWK1FMHEMFF2QB1+w/uyNDPea7vv1Dee9?= =?us-ascii?Q?4ICozdmgFuBFziaTsofvhaBr8ujwcC6e+knDiCwQRkOcbAdZb17f0If/kiaX?= =?us-ascii?Q?2P1MAcnQXxXorxpNaK77QLq91bD/GfhnDFrVeVFVcNbbwCI+xdbLMlgBCKUA?= =?us-ascii?Q?wANq2KCe9zmbfRfHYKOeLA2q2fZFwOdiqUDbbWkrKZGEDAw+Bckwx3/KVaGc?= =?us-ascii?Q?b0rf8gVa1i0OFWoQn/zgAH1ZmZdC4ROl3M2Apq8WZtUIamGmObKCoIaO8QEH?= =?us-ascii?Q?vHbijlhbPTsaew3ysm3eeqOW5BLvHwzwLSuHczfSAwMfn+vql3URjT4a3ZQD?= =?us-ascii?Q?C58M8x5kKCw5MewgCGQYPENwA62F3RCBZ+NhkDELH9ojqpmslkH/WTq7R+2K?= =?us-ascii?Q?YJhU51+WATVIBTFWJTDyxgUIGngSjljQgJMWD7VunwrHNWmml+0E1NBirJME?= =?us-ascii?Q?BAXZT4H2A3UTwS3Vx7Vfmo8JfiUjbqdyZUR5Fs6iYLnrbuYXBC+Xy3YV6g+p?= =?us-ascii?Q?KUrIsVEOd7NJ7UleOQnOIoB7eBTQFFNIYxO+gI1cIAZqSunNMI4mPlLSH0Je?= =?us-ascii?Q?VvSDWrvonKAWNikY/IE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5US2+g9EbPNmm6p5gNBtX4aPo1kZ54ezKkScOt9O4IHUqGVeBg4G0K2vp1vb?= =?us-ascii?Q?s8KaXuAD7VHslqwkIvs7CSAdGM/BoQlIjJjBDGApFvl7xqEfs98YDsEQLHo7?= =?us-ascii?Q?N9UziGaBCEA9HTQjRudJQcqS0hcx57fVQTxYHHUUxmV4DklQPeq21RJpf9jt?= =?us-ascii?Q?+qjh9nD39KPWDGROTCU2/oAsj3x3ZqoNXQxK2nzJrNtKkhEsp50G4Qj+z3kT?= =?us-ascii?Q?VG19U4cCwazpAK2pbHtSudv9bnviVjE35oUTy/Phyv6CyvCf4GT8ByT0JlWC?= =?us-ascii?Q?uZYncDdAvxSl0MFaEUuobRxJGbN+vH49VEDrHzYUy6YcClbAvdxHw21Tz39r?= =?us-ascii?Q?BJWp5y3NrPtEBFPkhJu2sx2c4WWg9Woe0h58gGbgsB0wsx6isZL6q2pQE2vR?= =?us-ascii?Q?FXSq9a6rjtTCEUKyYomgRih3yERG9X5uHmagB/C2epw5v7eerEBQ4N4HZCbl?= =?us-ascii?Q?Sh1xzDb6xRNEmeOSHJ93rs0deEJJQej/VzOTuNRi32/E3iFv2HApN7kLjOhT?= =?us-ascii?Q?CSrPqTwOhzZV/Xc6HlaVhei0IX12B0RWMN12AGYpjt4++LerUCNpSZ5fKBCP?= =?us-ascii?Q?iXC2YnTqRv5q8Irs4Pc5EnY6nvb+tUICvX6yK+v3MNzyAYy746XvjRCf5mpL?= =?us-ascii?Q?ngfC2UiaAZBKRGNmN/BFtAQJieIRk0o/GVvZ+hKpKcmhzoM/HOQ0k4q+UHPg?= =?us-ascii?Q?LZ0FBZFN37KP3ITJN5Phtyo7zXDVkdfOabhwohvF5u4m5sdqpOvJ0xBXLb7F?= =?us-ascii?Q?35DCfpmTOt7LSl6XFthvZ0RLiKQCuTLqFIPa87tz5Eb0IDCY+FxPFwtuZ5ms?= =?us-ascii?Q?79jF6psIsBtlvRKM9QEdLe+Efdaz8WYmYRVuyvR6nF/7bC/H86Bz8WK3U0jV?= =?us-ascii?Q?Uc8iIFMY54ll7MElZggfzYQTDehvD2e99PptysJb32x4OmQSo35vzS5D/KGX?= =?us-ascii?Q?zg3j0UMkI6YBB/Q4DAgasghRUtph16hUsB1pzVwMgvLwqCa3NIEkxSV3O86y?= =?us-ascii?Q?HFElIH31k5flie1kl2mOs+Xc+cZowk0WuqcneXIP4HPgoWsS30YQ0DwKbq8H?= =?us-ascii?Q?48OPyXbIKXuXWn/Tls9d5XbOj0K1Jb+M727kwZu3LTORAWXEnKAcXvfvHTgR?= =?us-ascii?Q?4+1+NjL/ii8OiNLSea4//2mPKXB0M88Ig0zgcZfVdn14zewWvsy+4BKrBE68?= =?us-ascii?Q?Cai/SFo+G8R58k55+rw0A6g30e2ugbR13qZe7M0yxzzHb4AFR/sSV2RZEs76?= =?us-ascii?Q?7CWUs+cCxzGu3wxyQuO4e48NfPVITc0DWBSt0g2bCx8RNyRV2K+Bz7CIpTgr?= =?us-ascii?Q?g1eMMk7e4AdElltukOp6PfjP8gGUj4a0jgPbkZWXfKAyrt2natkRyLNxGQkP?= =?us-ascii?Q?+yW+oQOyzsohJTlfrw3RPhpUTWQ1y6eyM8xWz3L2DfB8sNaD6kBExOMabF3I?= =?us-ascii?Q?9Hw9y90Jdzzo4zFASeVS+8v6u2YtVTo/qIK7n5P4CiBalUCkyO8FADd1sPq1?= =?us-ascii?Q?j6x3+vKXcc4oWJrr4yOSVvJMwvbppa6GjDi/d50f+OsHsp7XebTiMXwG/wgP?= =?us-ascii?Q?57FoeYPbPMG0IeCa4NC/Xk/OiSol1OCFDDclkciAti1ZJF2P0AmOxlsOZGAX?= =?us-ascii?Q?/S6bR82QM6+mImp4gQwfH9a0CTok5LCYCJ4bsZT3XV51DGlL7e3x6SWNbDkK?= =?us-ascii?Q?dyEN0q29N2F7IWeKBfTq0i/PD+EsXdIhCc37VuOMHxVCfD2Z?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 242c6065-33dd-4b9d-ec8b-08de60729dbf X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2026 02:44:12.4884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AbQqaoibRmz2AxwPbPB6E0dlngTNyc0urPvIGGIgmloShfBSUpjsa12GbdpzGv/4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4132 X-DKIM: signer='Nvidia.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 On 30 Jan 2026, at 18:00, Wei Yang wrote: > Commit 60fbb14396d5 ("mm/huge_memory: adjust try_to_migrate_one() and > split_huge_pmd_locked()") return false unconditionally after > split_huge_pmd_locked() which may fail early during try_to_migrate() fo= r > shared thp. This will lead to unexpected folio split failure. > > One way to reproduce: > > Create an anonymous thp range and fork 512 children, so we have a > thp shared mapped in 513 processes. Then trigger folio split with > /sys/kernel/debug/split_huge_pages debugfs to split the thp folio t= o > order 0. > > Without the above commit, we can successfully split to order 0. > With the above commit, the folio is still a large folio. > > The reason is the above commit return false after split pmd > unconditionally in the first process and break try_to_migrate(). The reasoning looks good to me. > > The tricky thing in above reproduce method is current debugfs interface= > leverage function split_huge_pages_pid(), which will iterate the whole > pmd range and do folio split on each base page address. This means it > will try 512 times, and each time split one pmd from pmd mapped to pte > mapped thp. If there are less than 512 shared mapped process, > the folio is still split successfully at last. But in real world, we > usually try it for once. > > This patch fixes this by removing the unconditional false return after > split_huge_pmd_locked(). Later, we may introduce a true fail early if > split_huge_pmd_locked() does fail. > > Signed-off-by: Wei Yang > Fixes: 60fbb14396d5 ("mm/huge_memory: adjust try_to_migrate_one() and s= plit_huge_pmd_locked()") > Cc: Gavin Guo > Cc: "David Hildenbrand (Red Hat)" > Cc: Zi Yan > Cc: Baolin Wang > Cc: > --- > mm/rmap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 618df3385c8b..eed971568d65 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -2448,7 +2448,6 @@ static bool try_to_migrate_one(struct folio *foli= o, struct vm_area_struct *vma, > if (flags & TTU_SPLIT_HUGE_PMD) { > split_huge_pmd_locked(vma, pvmw.address, > pvmw.pmd, true); > - ret =3D false; > page_vma_mapped_walk_done(&pvmw); > break; > } How about the patch below? It matches the pattern of set_pmd_migration_en= try() below. Basically, continue if the operation is successful, break otherwise. diff --git a/mm/rmap.c b/mm/rmap.c index 618df3385c8b..83cc9d98533e 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -2448,9 +2448,7 @@ static bool try_to_migrate_one(struct folio *folio,= struct vm_area_struct *vma, if (flags & TTU_SPLIT_HUGE_PMD) { split_huge_pmd_locked(vma, pvmw.address, pvmw.pmd, true); - ret =3D false; - page_vma_mapped_walk_done(&pvmw); - break; + continue; } #ifdef CONFIG_ARCH_ENABLE_THP_MIGRATION pmdval =3D pmdp_get(pvmw.pmd); -- Best Regards, Yan, Zi From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id yIYVDyFxfWkhRD0AYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 03:04:01 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 03:04:01 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm1HE-0000000H49E-3pJa for hi@josie.lol; Sat, 31 Jan 2026 03:04:01 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id B405E304A643 for ; Sat, 31 Jan 2026 03:01:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 45A9330C63A; Sat, 31 Jan 2026 03:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="rAcNXItA" X-Original-To: stable@vger.kernel.org Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010029.outbound.protection.outlook.com [52.101.85.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C15B3254BD for ; Sat, 31 Jan 2026 03:01:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.29 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769828493; cv=fail; b=ApHk/6axAN4fUVa1je7O5oQa6tp/4kwUCSVruVJEOIUa0DlaA+PStbvSAvoTsvk4LLbu06BVDPF8/YdYDNhdeFgXyF0nx3k4S56eMtpyNuV2lUqpm0OCmft3zc+JCcjlOJBv8+IKYbOLh2lyvzXRYsuJhQG32y/apvXc4KboQRw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769828493; c=relaxed/simple; bh=nT3QnnGWOL29RVobm4dpUDH17mQkxJguM27xyEC/q9E=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=kjXVxeEkTSqXueZxzIrli3GzGqHc0+7e3FeIliB/IQvf5806r5++oh6YOUsxlD1GFL0s1R59+q8JQtM++iJwqBJTqADP5szcahuYnM5G96T8QPCjlpv17e9IJGUA+HybWTvg5BeTmxWmzjEHWki5kKdfpgl2petPbbv4VonTHj0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=rAcNXItA; arc=fail smtp.client-ip=52.101.85.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gtH3ShsN4Su7O6K5cWBsLCxC2d9KwrVqB+joarlzIcVGajZxv3dGuScnGtKC915Jn9Xke5wSfmESReCLgXSXXU/eSXsPeK7EYfywVgIwtY/Lo57Fq2xO24Vyb7rSZQc9VRLwQpg9wJ0JsvWeXfsKCMQ19ttR0HhOYIajkpE7I6EdOP1QIE7C6JITEwZOHqHr6feKeJWiQj6Fc/T9VSE7WchrZRO2LGEJ6B6eS4ifA/G7HIiOwgQRGhlKCR4IheXuOIyNLVD+6BTWq6kbTrTU00xjbQOlW/N8MjZ6XPgrHUhkDqA/ceHRZVYxEXW166IXpJ0tdHb8Fe8aFFP8jPxplg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VXXgolPotg+N0ILa+3OBCMeuxPWl3FAeZcugG6mexnw=; b=Hkm0Frsh+sTLkDWVDq5H6MvC6P/Z18eCYul9BH6Q/OaMJIMoY2Lqo5jLmYV6lhRm1ek/6kkd/q3vqTU7Fb82RuFDTfKJ4Ac6IYJAQmPBa3wMyVsy9Vvup9kF1ceUMM2iT+bfKoOh8zIa3pCeQJuJ7T1xcqSuhR6n3k942PFx+f4RWnkA6Q4DT3bX/rwxR4CMX+mSnA1hKLXxsGoPq85QJQnblkU8jMWxu69742NL900MS1l106x/RBmwKCyVRg9ujCRfUiAFlU77fbV3e/FHzFU8CZSwWcnLRulUGiIH/7rJpY1AowT3cx8NoQPWiiDibimIiDJhHksLuFOxov6F2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VXXgolPotg+N0ILa+3OBCMeuxPWl3FAeZcugG6mexnw=; b=rAcNXItAZScbEKf+r2cCYcXnxh30vpaLOExxZeL/2jrz7iYX+0ILjOixw3W/nS76aJxBaVyHh9Xdx7I0uZjSKSrOUhes6ABEI4vosf7eFMklmuVegoVH7ZI0FPz1vwCk5dnTSKjfQdixqA3go5H5V30Xsxpw4xb9XLQp3KwnXLQqODz7S/TssRMsnOLa9p3sOdq7qwmelg+rHNrS7qcCWAmiDzOQOUkhQ9MMzCFf0uXQVltaWS/Y7IZvDHw3ZaXmULeb00shGOnSec6IVuukudDFoHhsVXFxBxvxp2loxoIRioBiNevtHvz755BpU1j8cYXGvOwdkWTmi7jslNOWuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by LV2PR12MB5989.namprd12.prod.outlook.com (2603:10b6:408:171::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.11; Sat, 31 Jan 2026 03:01:25 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8%7]) with mapi id 15.20.9564.013; Sat, 31 Jan 2026 03:01:24 +0000 Message-ID: <57fd7f99-fa21-41eb-b484-56778ded457a@nvidia.com> Date: Fri, 30 Jan 2026 19:01:00 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hmm: Fix a hmm_range_fault() livelock / starvation problem To: Andrew Morton , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= Cc: intel-xe@lists.freedesktop.org, Ralph Campbell , Christoph Hellwig , Jason Gunthorpe , Jason Gunthorpe , Leon Romanovsky , Matthew Brost , linux-mm@kvack.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20260130144529.79909-1-thomas.hellstrom@linux.intel.com> <20260130100013.fb1ce1cd5bd7a440087c7b37@linux-foundation.org> Content-Language: en-US From: John Hubbard In-Reply-To: <20260130100013.fb1ce1cd5bd7a440087c7b37@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR05CA0196.namprd05.prod.outlook.com (2603:10b6:a03:330::21) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|LV2PR12MB5989:EE_ X-MS-Office365-Filtering-Correlation-Id: e3d1b117-4f0d-4041-fdf5-08de60750504 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bnZpVG1veXlHUTVSM0RKNWlSSWEzTkZCOGlEZDVTb0c2aFFMWHQxWGxMckJv?= =?utf-8?B?TmU2eUJkM2FOUTh6bjZyNzhUdHAzK1gyNVJ4UFZsem45dG9FTmovcWRrdDE3?= =?utf-8?B?TC9BbVN1bkUxWkVMSUx0eWJmZUdnNGc3T0dBa2R4SWxEYWJNZzRvdjRvMnNl?= =?utf-8?B?U2tzZ1RtK1RiaW1JSFQ1U0Z4SlJGSFR0alRrRnJXSEpMYWt5bXp0SHZJaHgz?= =?utf-8?B?Wmp3MEZlZWMyZThDek1UVGFQQzh2d2VpT2RvZFJ1eWtPMUFGdWp2YlR5UVdy?= =?utf-8?B?Mjh6RWJuMWR4dW5LZGZ3VHVTZDVnZ0RQMzcrV1Q3eUZrV3Y4ZlhLbyswdmZG?= =?utf-8?B?VG9ZSllGRDZGSVp3OTM4UG9ZYnNHQnJsMUM2dHRBWUZVNzR4dDIrK0xBMld0?= =?utf-8?B?TFREcjN0cXZuMGU1OVRxS2QvT29lVVBqTXVUTTYxZlVqc1V5UUNob1FzeWts?= =?utf-8?B?cHNVbEwrOUJjZmdWVzdrWWFSV2w5dGRGSnhrR2tFYjFucEVZK2Y3STV5dFEy?= =?utf-8?B?d0l6eU9YemNjVlFuV0tKOVE1Y29LWVdBZXpUcm9Ca2MvY3pJNXlDOU9qNE9D?= =?utf-8?B?elRlNEJaR1RWSHByM0lvbzlsM0xhd0JqR04yMzNaVkZYcEwyZXNLaWxjcUJG?= =?utf-8?B?VHVjLzUzNUxlaXBZYWZVZEdYSU5WUXNKVlVNK21YRGI2TFJRd1JQbzdyQjlq?= =?utf-8?B?eHVKd2V0Yk9jMnFLS3dzT1REVFBDaTFFM0ZhZEtxS3J0ckJ6Vi9zcHFvWE41?= =?utf-8?B?UU0wL3dFbmJ6T1hhc3dRTHNsRXYvc0NLRWloeFhRbG1YNVlZNzRzaGpTeEQ1?= =?utf-8?B?Y2xHamxmdSt6akRmTzhOcElnV0JPZWN2WXBSQXpWc1NLdU5sZ29FUUNVLzdR?= =?utf-8?B?ZW0wclBpcFdLc2tLeWsreWc2YThVZG1aTmdiMStsakZuOG4zaCs0SjVqRmJ3?= =?utf-8?B?TU1BMDc0WXpUVnlTZUI4TVZWRzV4ZVpQRzUwLzVBRFlUYU02akdVN2lVUENj?= =?utf-8?B?dlZMK1B4SjFYU3JDd0lCZjIvYjJadkxvSFBqRzNKZnlqdlFrTytjY2xaUTU1?= =?utf-8?B?SkVXcUQzZVNRcUQ4THk4allzWGtJNDhHSmZvTzFKdmU1VWNXWHpxR21tZUQ4?= =?utf-8?B?MDhLUDJmMEQ4RW1pUEU5dU9Md0E2WFgwTzdIdXBWQ3RrYmVEY21lblBTbWlO?= =?utf-8?B?Q3MvOE1YWFpiZEtLUDdNWnBSV1NPN3hrY091TEhUUkdvWW5kVFd5Y0JDdDhk?= =?utf-8?B?bFFFSmhmS1VhZVhQaFhiMU5JTmNYV2s2YUtiSUQvSjNoSWlUZE04aDVUZXJU?= =?utf-8?B?VEE3djJqaWF6QisyMHV2V3hUTUZHbytlMGFaY1BPUisrclFQOExuWk9VY1Fk?= =?utf-8?B?T2thV3pxZU1oSTM4UW5DTHZzNHBLZFJqV05kUFhVSWNId1lXRWxuZWZWUmVQ?= =?utf-8?B?c085U0E3MGI5RE1tWjNQS3N1V0lHQ2tjQW1XbmloN1lnYlVwYmRPVHhYRGx2?= =?utf-8?B?ckU2bUxrNkoweW54ZjZCOWJWTzdKOVBvc0tBSkRuYWdhU09zSU5NdjZQbW9Z?= =?utf-8?B?ODFneWxQSlBNYVY4TUxkT1NUYXlwYnZ3czFFN0szMDJXVjVjQW9lN0wxY0F6?= =?utf-8?B?cFJFRzl2UE01K3JBWDZlZW1TQzZTcmRQZ2hBNW5aMnEyd1Jkc3E1QUI3V3RF?= =?utf-8?B?ajhnQWpITDRwQjE5RForQWZIUm9OSmxKWnBlWXpIU3pNRWY1L0ZaOHBsVnF2?= =?utf-8?B?dUpRNG1IaVpzcUxWNDJwOXVrcklUSW13ZzFpZzQ5ekR5Y2h6WHh3ZmRpdkd5?= =?utf-8?B?eGRTZ0dOUG5XdlRPandWS0xnM2x3QXlsckc5TXZQVmRQTFpQS0xlSDV2Nk5R?= =?utf-8?B?NmF4dC96M2RpWUw0elVmM3BZOXRvc1QvSXVzbTE5R0ZUNHltQi90bWx0WTht?= =?utf-8?B?QlFqVnBYc2FPQXVmeEVZNVpWM05yUVR0djE2WXlCbktxckxoVFc4S0U2KzdQ?= =?utf-8?B?SFVZR1VlMXcvRUZBOU95L3RWc3hUTXdSSGRLb1M3VnlDZ0dDUjBqMjROSlpM?= =?utf-8?B?d0VORERJeTZhQUZQb21oTnQrc29Gb1I3Z0h0RGQwZWVOYnJJbFdiQjdSNWxi?= =?utf-8?Q?RxpU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXJiRzRGUlhXajJRS2JJZ3BJeVFSMTNsSTh0dGs0dDRncENBOS9BM1NvNWVM?= =?utf-8?B?VTlFdVNteXZTZlUwaXJmZ2xpK1hBU0J5UlB5VlIyRjZCM3J3ejdSMGF6UEI4?= =?utf-8?B?STBMTFpPc2tnZmtVdzMxUHBvKzBqZytIc2VvMGRtdGEzNWpUa3lRejRzd2sz?= =?utf-8?B?aWNUZURoc1NVTUZRV2Vkbm9JVVJHK05uU3c5RWFxbjh2WE90bFRMV2JUNmZ0?= =?utf-8?B?YVU1eGFGTkFXbEpvTWxiYmR2VkxDYmJLcUtDbWVxZ1dYVXk4dHhxR0dZekNY?= =?utf-8?B?ZXdGOXR3YllUdlIvcVBFeFZsLzlXaG5QK1RTSk1zOXkxUk44cTEwWmlnWisx?= =?utf-8?B?NGpFSnFyb3Y1ZkJqdldWY1YxMndJa2J1Z0s0Q082T1pMRTNCVXFkZk9QMXIr?= =?utf-8?B?RDgwUm0vaGhNYy84OEFLOTJZekNBTEZGbm1Cdlg5VHprY1BSVFZnNGJZT1VZ?= =?utf-8?B?VjczTyt1NkRRMEJhTDM2Yk1RYk5kRlJlZDFMUFhmRUYzMDZldVc1TnJqVXdo?= =?utf-8?B?OG5oaGRUTjkyeEhkNGh3U3ZsT1ZWTXNhOEE2SytiWjI3Z1U0Vkh5VmY0ZDFv?= =?utf-8?B?aHRtUlM5bnRTcE5kSTlnZDRQa3hQdG10dlBMNlFGR2J3WVlkWm1ueUV5S1Qz?= =?utf-8?B?clgzSHZUVDduKzZLTjFYTjh3MkgwNTJ2RnVEV1VGcWhLckVZT1c0a3V0UUo5?= =?utf-8?B?NW5hLzljSDdhbnNOU2x4WXJ5TDdLWHorMURtbnBZOHBwL1AvQ21zYmlsNnZa?= =?utf-8?B?a3RwbHdYMm9HNE5pbW03ZmlDQ3lZQjJvRHorUU5WaFQxU3J1TDlEWmg4VWRS?= =?utf-8?B?RjR6cWJqandOdjU1eU5uNFpkVXlUUnZLZGp1enBCbzdIeWliRTBpQ0JhR3B4?= =?utf-8?B?cEVRQXhTMk96T2t2b2I5SSt1MVQzWHBuWU5hYTdHcUc5cEVSa3BkUU5ZSklp?= =?utf-8?B?anh4WGNNVm42SzZ6ME53NTdrZk9HOGtNNnhBZDZUQlpoK3NkREtnRmMweDBC?= =?utf-8?B?YzlQRk5PS0RLZE5vdjN4djdCVmZhZEFLTzVJQ00vcXdoZHRvT3BxYXdaSkRh?= =?utf-8?B?RmswUjdwVy8xTWZIL3B3d0JlV04yMW0waFJ5WlBjY3VNOS9xa0dycTJiSnJR?= =?utf-8?B?YXIvWWJMeUNaNDIrMzVjb3dUUnZNMEhjWGlxMi83SkhrVmZIUjV2aDk3OHkr?= =?utf-8?B?UUtsVHRGR3BzNHpiOHQ4M0NnWDlJNUtxNTNQbktNQkpxOGFTS01SdVNQMURU?= =?utf-8?B?SzdGMlBGRTNDd3RJYVVTNG5ZSXVkV3dNZWFsMExUTitya0IrWGQ4R0JwUjY4?= =?utf-8?B?YXpwZzE5ZGZKREhPcUQzY3FGM3ZZeW1Nb1dHTVdDbmhTZGJIRTFtcHdzcmt5?= =?utf-8?B?Uy8zTFZsUUpINEx5YldoYVhLemFtbVVVaHNMamlUT0I4bitESW1Cb2owWXYy?= =?utf-8?B?OE5xelFyWFBTOVc5UkRqY2pUMEVPckF0VDFrdHJiOXQ3U3BXM0NEdktUZnhr?= =?utf-8?B?Ty9pZWliMGdiN1JFd0MwYjlScmdrSXUxZzMzK05sVk1keHFBRGFYWDRibThI?= =?utf-8?B?V1NHZGxUMzkweEM0SzJkdHFHK2cvZnI4cjhhOTVjQ2xRVEJpajh0L1pvV2VM?= =?utf-8?B?Y2hQQ3JDdXd1M0FKa2NkbU03aHl5OUpxdHQzdytYNUVibFRwLzM5V25rekl1?= =?utf-8?B?V2F6SlZlT1hGSWllMEd1bVo1NUd0RFB4T3JSSjRKZlhtZEsxWEp0TldvUkR4?= =?utf-8?B?cnNHR2NqZEFVVThnOGUxRWc5ZVpyQVRGQ0JiaStxVXZmNzQ0dGhhbUIrUmdr?= =?utf-8?B?Mm9rdjZSWEp5ZEdkWWU1SDNsSVBxVzV3UHlQaEd1VzdUT2o0Y3dKSm51V1pU?= =?utf-8?B?aTNRQm1ZR3pxMmVRVGx4NTRRakJDeWMzME9VM1ovcUNoWFJxQjloVGNzcTEv?= =?utf-8?B?MHBLcHpLdUdFVHRadXJnbkJjVkV3ZE5Nc3Jad0UzUGc4dEdXNGpJTFc2b0Vp?= =?utf-8?B?Y2xiUCtqbjRmL0pDL1d1MzBranc5WGVYd2Nxa2ZqeWJjbCt6NjNOTkcxd1dQ?= =?utf-8?B?cXRhVUlIY2RlTXJnaHFERm41OG94THY0YmJrd0lxbE9WajM1TlJxQlZnRjJo?= =?utf-8?B?dGNWQ2djYm5xeXNrTkcvT1hmbHRkV2k0TTQwZDVDMWJ1ZjAvVERMcUhrRS9T?= =?utf-8?B?U3hMYUJQZU5Xa0VMTEI5c1FpWjZBaWZhZDE4MUgzeTBPWkZXUlBpV0pvZDZL?= =?utf-8?B?aXFKZkc1V0x0dUlmc29Va2prbXRkYVhjbHZpeVZsMktmTFJ5S1lvbFdSanRC?= =?utf-8?B?dHVNODBQVFhsYUtyeld6Wk9kSUVOZjhhOGUvdnhXVktSb1JuVWhEUT09?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3d1b117-4f0d-4041-fdf5-08de60750504 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2026 03:01:24.6303 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SdQVve67o7fuuFzUe7S7XKTJ8gM2DMFx58AxYj2CFElF2ADXLin1cazAfusUSOUCMxC6M+Ez3nvWEr0EO29rMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5989 X-DKIM: signer='Nvidia.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: nvidia.com] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: 4 On 1/30/26 10:00 AM, Andrew Morton wrote: > On Fri, 30 Jan 2026 15:45:29 +0100 Thomas Hellström wrote: ... >> This can happen, for example if the process holding the >> device-private folio lock is stuck in >> migrate_device_unmap()->lru_add_drain_all() >> The lru_add_drain_all() function requires a short work-item >> to be run on all online cpus to complete. > > This is pretty bad behavior from lru_add_drain_all(). Yes. And also, by code inspection, it seems like other folio_batch items (I was going to say pagevecs, heh) can leak in after calling lru_add_drain_all(), making things even worse. Maybe we really should be calling lru_cache_disable/enable() pairs for migration, even though it looks heavier weight. This diff would address both points, and maybe fix Matthew's issue, although I haven't done much real testing on it other than a quick run of run_vmtests.sh: diff --git a/mm/migrate_device.c b/mm/migrate_device.c index 23379663b1e1..3c55a766dd33 100644 --- a/mm/migrate_device.c +++ b/mm/migrate_device.c @@ -570,7 +570,6 @@ static unsigned long migrate_device_unmap(unsigned long *src_pfns, struct folio *fault_folio = fault_page ? page_folio(fault_page) : NULL; unsigned long i, restore = 0; - bool allow_drain = true; unsigned long unmapped = 0; lru_add_drain(); @@ -595,12 +594,6 @@ static unsigned long migrate_device_unmap(unsigned long *src_pfns, /* ZONE_DEVICE folios are not on LRU */ if (!folio_is_zone_device(folio)) { - if (!folio_test_lru(folio) && allow_drain) { - /* Drain CPU's lru cache */ - lru_add_drain_all(); - allow_drain = false; - } - if (!folio_isolate_lru(folio)) { src_pfns[i] &= ~MIGRATE_PFN_MIGRATE; restore++; @@ -759,11 +752,15 @@ int migrate_vma_setup(struct migrate_vma *args) args->cpages = 0; args->npages = 0; + lru_cache_disable(); + migrate_vma_collect(args); if (args->cpages) migrate_vma_unmap(args); + lru_cache_enable(); + /* * At this point pages are locked and unmapped, and thus they have * stable content and can safely be copied to destination memory that @@ -1395,6 +1392,8 @@ int migrate_device_range(unsigned long *src_pfns, unsigned long start, { unsigned long i, j, pfn; + lru_cache_disable(); + for (pfn = start, i = 0; i < npages; pfn++, i++) { struct page *page = pfn_to_page(pfn); struct folio *folio = page_folio(page); @@ -1413,6 +1412,8 @@ int migrate_device_range(unsigned long *src_pfns, unsigned long start, migrate_device_unmap(src_pfns, npages, NULL); + lru_cache_enable(); + return 0; } EXPORT_SYMBOL(migrate_device_range); @@ -1429,6 +1430,8 @@ int migrate_device_pfns(unsigned long *src_pfns, unsigned long npages) { unsigned long i, j; + lru_cache_disable(); + for (i = 0; i < npages; i++) { struct page *page = pfn_to_page(src_pfns[i]); struct folio *folio = page_folio(page); @@ -1446,6 +1449,8 @@ int migrate_device_pfns(unsigned long *src_pfns, unsigned long npages) migrate_device_unmap(src_pfns, npages, NULL); + lru_cache_enable(); + return 0; } EXPORT_SYMBOL(migrate_device_pfns); thanks, -- John Hubbard From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id IMgNMqF5fWnJ+T4AYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 03:40:17 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 03:40:18 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm1qL-00000000Pex-2Box for hi@josie.lol; Sat, 31 Jan 2026 03:40:17 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 4B694300E70C for ; Sat, 31 Jan 2026 03:40:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53A3134E74E; Sat, 31 Jan 2026 03:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hl3Q32je" X-Original-To: linux-s390@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C9D78C1F; Sat, 31 Jan 2026 03:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769830813; cv=none; b=fFmuHX/gUZwTDPvhtGpB5XJ4HoCm6ZF3WKGBfcwUnH/R+2Mc6ZthuYVfL8Ki18VWqDO6hHzKHHOKMFp1+gvJj+T6XVfQEM+YCCGOVVFcfb3qTy4lIB8djA9oIxWimGRn4Is5+VzLqcsKVsah5ToiSvnXU05H73IrD+ArkO4Sfmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769830813; c=relaxed/simple; bh=SPa2ky00MTlgAVW6CPBZYtqiEy57G6865mcHfn5Fva4=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=GHjTfJDCWI3dADeupbBZaDztd8osojiHOtoCSgU8S2Pp6vAoakKgDHYf9RRTVCcIB9NGGZfz4aXPR25FQneWUvJH8+BLTuoOXmICiMGV2GkCGI1HQwKK8r3aWcPYHrot3HkEnDZqVz/lCu1gw0pk0/D/IFMLXvqL2p/FKiC7vpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hl3Q32je; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8D19C4CEF1; Sat, 31 Jan 2026 03:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769830812; bh=SPa2ky00MTlgAVW6CPBZYtqiEy57G6865mcHfn5Fva4=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=hl3Q32jesSmbR2hXuuoqdTRzotmtlIy8xD0XeqEbyuc9r4NTXzG/9oaF/N5Kwu5fv MUoKS06t3AlPtYepLp0PSJunGKx888rIwCL+4lV7WSO4YOJDSOf71G9CtDHgtBx+D9 cKkDpPzvSdZdB/f3JUfhfmv/vJeHPwGI3KVZGEa9SsnjNbI9lHWJJuv431vHpNyCW3 RzujlV7YGmCYVQxuTg2KY7b/QkinWmBPtCIGwT9dr5y7+3dcEMNPg5K9yP5/7abpAS wW3Er7XEk4OslLCDAE50UnOx+b0wfPh9yLjn4gJBhaYxFp7our83XPoZjkZrF2+z/D 5idM+zmOLWGMw== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id 11B0B380CFFF; Sat, 31 Jan 2026 03:40:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] Revert "net/smc: Introduce TCP ULP support" From: patchwork-bot+netdevbpf@kernel.org Message-Id: <176983080486.3985311.3826362708256060586.git-patchwork-notify@kernel.org> Date: Sat, 31 Jan 2026 03:40:04 +0000 References: <20260128055452.98251-1-alibuda@linux.alibaba.com> In-Reply-To: <20260128055452.98251-1-alibuda@linux.alibaba.com> To: D. Wythe Cc: davem@davemloft.net, dust.li@linux.alibaba.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, sidraya@linux.ibm.com, wenjia@linux.ibm.com, mjambigi@linux.ibm.com, horms@kernel.org, tonylu@linux.alibaba.com, guwen@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, oliver.yang@linux.alibaba.com, viro@zeniv.linux.org.uk X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 28 Jan 2026 13:54:52 +0800 you wrote: > This reverts commit d7cd421da9da2cc7b4d25b8537f66db5c8331c40. > > As reported by Al Viro, the TCP ULP support for SMC is fundamentally > broken. The implementation attempts to convert an active TCP socket > into an SMC socket by modifying the underlying `struct file`, dentry, > and inode in-place, which violates core VFS invariants that assume > these structures are immutable for an open file, creating a risk of > use after free errors and general system instability. > > [...] Here is the summary with links: - [net] Revert "net/smc: Introduce TCP ULP support" https://git.kernel.org/netdev/net-next/c/df31a6b0a305 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id oK1tIbiYfWkRhQsAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 05:52:56 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 05:52:56 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm3uh-00000003lUu-3k4u for hi@josie.lol; Sat, 31 Jan 2026 05:52:56 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id F2A0E3010B8C for ; Sat, 31 Jan 2026 05:52:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DDECF2C21FE; Sat, 31 Jan 2026 05:52:53 +0000 (UTC) X-Original-To: stable@vger.kernel.org Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 505E6221F20; Sat, 31 Jan 2026 05:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769838773; cv=none; b=kqCpQteBc+zI/CDxQZIz+YVoXQYlcHo4Krtt8DExjPHwFIzpBrI2OjmhSQOVh4BLcJs1Fai9TETPsAt7kd6/nwshD1riZ4JhwQ+O0oGIuqrqnyYAZu92oAnnA4oX8OByfBJGAqn38t3jCGsFx50hiA6qFUlegjvoG0MDUY9TOC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769838773; c=relaxed/simple; bh=PmbAJYJkov8V5YggkGt6mnyWmVPIBHeFOH5at+c+duk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BrXbp0GX1mZNMXyd9Sg7PSC8fJBMRD9M7oWPVRB248VNbsvqJLmFr5BIt4XZ2b1lvBVhLiEHEU3kghRiHXjtbl1XTkAWYlgajb4deJA/wAk/GxcRKSkyeqhzYi9eT30N8D0M16Fj4EiYisZr3W3ak+aPAdsxAsE5fPn4exGetR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.223]) by APP-05 (Coremail) with SMTP id zQCowAAXpgmSmH1pKjcfBw--.29939S2; Sat, 31 Jan 2026 13:52:19 +0800 (CST) From: Haoxiang Li To: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, daniel@iogearbox.net, magnus.karlsson@intel.com, bjorn@kernel.org Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Haoxiang Li , stable@vger.kernel.org Subject: [PATCH v2] i40e: add an error handling path in i40e_xsk_pool_enable() Date: Sat, 31 Jan 2026 13:52:17 +0800 Message-Id: <20260131055217.729048-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:zQCowAAXpgmSmH1pKjcfBw--.29939S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KF4xJF4DJF43uF13Aw1UZFb_yoW8Gw17pr 4j9a95Cr1rXFW5Wa9rJF4j9an8Ja1ftry0gF4fGanY9r15ta17JF1xtFWFgFy8ZrW8Janx KF1DArs8CFn8J3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9014x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4j6r 4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x kEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCw CI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1x MIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIda VFxhVjvjDU0xZFpf9x0JUd-B_UUUUU= X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiCRAEE2l9cjNJQwAAsR X-Spam-Score: 0.5 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.5 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 In i40e_xsk_pool_enable(), add an error handling path to prevent potential memory leaks. Fixes: 1742b3d52869 ("xsk: i40e: ice: ixgbe: mlx5: Pass buffer pool to driver instead of umem") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li --- Changes in v2: - Add a Fixes tag. Thanks, Paul! - Replace unmap with i40e_xsk_pool_disable() to prevent a limbo state of queues. Thanks, Maciej! --- drivers/net/ethernet/intel/i40e/i40e_xsk.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c index 9f47388eaba5..a72a309540c3 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c @@ -108,23 +108,26 @@ static int i40e_xsk_pool_enable(struct i40e_vsi *vsi, if (if_running) { err = i40e_queue_pair_disable(vsi, qid); if (err) - return err; + goto err_out; err = i40e_realloc_rx_xdp_bi(vsi->rx_rings[qid], true); if (err) - return err; + goto err_out; err = i40e_queue_pair_enable(vsi, qid); if (err) - return err; + goto err_out; /* Kick start the NAPI context so that receiving will start */ err = i40e_xsk_wakeup(vsi->netdev, qid, XDP_WAKEUP_RX); if (err) - return err; + goto err_out; } return 0; + +err_out: + i40e_xsk_pool_disable(vsi, qid); } /** -- 2.25.1 From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 6JVkDoKdfWkApwYAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 06:13:22 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 06:13:22 +0000 Received: from sin.lore.kernel.org ([104.64.211.4]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm4ET-00000004MAg-2XFX for hi@josie.lol; Sat, 31 Jan 2026 06:13:22 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sin.lore.kernel.org (Postfix) with ESMTP id 2E8323002D15 for ; Sat, 31 Jan 2026 06:13:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1E63630F546; Sat, 31 Jan 2026 06:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=enjuk.jp header.i=@enjuk.jp header.b="XBgenLn4" X-Original-To: stable@vger.kernel.org Received: from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CCA731BCA9 for ; Sat, 31 Jan 2026 06:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.212.198.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769839997; cv=none; b=HWgAPZGiXcq4SMktIH39ruLyleRulM+4/TX8HPlyU9hXu8ijmQ50xTXq1hxe6FstWZtYQ+c75KP+IKWGHEHCctre/xP8+mlXfIpx/N4S5UaxEp3AYo5cwm+8bXvkIyT5gMzNhuad2ayYMuZLWbrXKywLY1icxVufhZ9J3GA456o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769839997; c=relaxed/simple; bh=S5QS4QrBbXd53iVDxcnbSBS2H6BGQcxYOTrLN2xJWdY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kpe9h0IaQ1IAR9qcavX+VluzZyJs6dJe2isPaGBbLezUBvm8LzjmqDWa9YzMTPjfAurntsLmQ0v72TrzIx/RpMGAfwriIBxbpGeSFtsftJYPf+PeRe+0v/HlSaQWulcc9Vvz1942j5KwiKVAYrGk6BgAyFOZ+VC+UtAFlZOl8Fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enjuk.jp; spf=pass smtp.mailfrom=enjuk.jp; dkim=pass (2048-bit key) header.d=enjuk.jp header.i=@enjuk.jp header.b=XBgenLn4; arc=none smtp.client-ip=49.212.198.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enjuk.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enjuk.jp Received: from ms-a2 (248.212.13.160.dy.iij4u.or.jp [160.13.212.248]) (authenticated bits=0) by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 60V6D4tN072210 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 31 Jan 2026 15:13:05 +0900 (JST) (envelope-from kohei@enjuk.jp) DKIM-Signature: a=rsa-sha256; bh=vpaHteD97DiVFaAs0Ate1NmbUcN7m/ErCU3DJJSYNzQ=; c=relaxed/relaxed; d=enjuk.jp; h=From:To:Subject:Date:Message-ID; s=rs20251215; t=1769839987; v=1; b=XBgenLn4wgnJ1zMAW/kbmMJyhALGrl1AWnKI5gzGzCR0l8i9KZbBLIDcu0tePkHc rOGF0PSUBXIVaYHmG/9n4d3faCODXk0AA2ogUrazk3Gzn+9EN0tWrhG+eOUTzLlK wpuUpzN6Xn3XtwUW29KXyLQ5JX0nTvYOAzgXSLHlEZ7Pw9vceAjcbwZyIX5/dLag 95lbE4NuAlvETCjmWsU+yPEYbKa2gv5EwzWwbzu1LLdw/yxbCYuOo3yP/QmpnYi8 H+tr4Wwf4t+WC0tytEuU9K04OYW/0QntG0I9yG3Lu1xE64Q6hieIvZjI4d+1FbQ9 BKYHYasNAQrt8K6nJmEzRw== From: Kohei Enju To: lihaoxiang@isrc.iscas.ac.cn Cc: andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com, bjorn@kernel.org, daniel@iogearbox.net, davem@davemloft.net, edumazet@google.com, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, linux-kernel@vger.kernel.org, magnus.karlsson@intel.com, netdev@vger.kernel.org, pabeni@redhat.com, przemyslaw.kitszel@intel.com, stable@vger.kernel.org Subject: Re: [Intel-wired-lan] [PATCH v2] i40e: add an error handling path in Date: Sat, 31 Jan 2026 06:12:12 +0000 Message-ID: <20260131061304.27368-1-kohei@enjuk.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260131055217.729048-1-lihaoxiang@isrc.iscas.ac.cn> References: <20260131055217.729048-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='enjuk.jp' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: enjuk.jp] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On Sat, 31 Jan 2026 13:52:17 +0800, Haoxiang Li wrote: > In i40e_xsk_pool_enable(), add an error handling path to > prevent potential memory leaks. > > Fixes: 1742b3d52869 ("xsk: i40e: ice: ixgbe: mlx5: Pass buffer pool to driver instead of umem") > Cc: stable@vger.kernel.org > Signed-off-by: Haoxiang Li > --- > Changes in v2: > - Add a Fixes tag. Thanks, Paul! > - Replace unmap with i40e_xsk_pool_disable() to prevent > a limbo state of queues. Thanks, Maciej! > --- > drivers/net/ethernet/intel/i40e/i40e_xsk.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c > index 9f47388eaba5..a72a309540c3 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c > @@ -108,23 +108,26 @@ static int i40e_xsk_pool_enable(struct i40e_vsi *vsi, > if (if_running) { > err = i40e_queue_pair_disable(vsi, qid); > if (err) > - return err; > + goto err_out; > > err = i40e_realloc_rx_xdp_bi(vsi->rx_rings[qid], true); > if (err) > - return err; > + goto err_out; > > err = i40e_queue_pair_enable(vsi, qid); > if (err) > - return err; > + goto err_out; > > /* Kick start the NAPI context so that receiving will start */ > err = i40e_xsk_wakeup(vsi->netdev, qid, XDP_WAKEUP_RX); > if (err) > - return err; > + goto err_out; > } > > return 0; > + > +err_out: > + i40e_xsk_pool_disable(vsi, qid); I think return err; is missing... Also, since i40e_xsk_pool_disable is not declared before this line, compilation fails due to a 'Call to undeclared function i40e_xsk_pool_disable' error. Adding declaration or moving i40e_xsk_pool_enable() after i40e_xsk_pool_disable() is needed. > } > > /** > -- > 2.25.1 From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id 4DDaKICnfWmEchAAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 06:56:00 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 06:56:00 +0000 Received: from sto.lore.kernel.org ([172.232.135.74]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm4tk-00000005Rf0-1AZE for hi@josie.lol; Sat, 31 Jan 2026 06:56:00 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id 783543003609 for ; Sat, 31 Jan 2026 06:55:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A009B78C9C; Sat, 31 Jan 2026 06:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QLHnadnT" X-Original-To: stable@vger.kernel.org Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C75EC313E15 for ; Sat, 31 Jan 2026 06:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769842553; cv=none; b=LBuRqi1t0S1Pb0JDubetWFxMzL3ag5UcyMIP4jkH7iLAFlJP73PPr96C54AVPK2kF4Fg75GdikCnF0uduxZAJzd62QG3ncpj7g/Ps6Lv/Fr9NKMLHgX6GEg7H1Dsn40yJ5taaiugmklgeGDfE0cXtEmyXieHvz3aqw3j05WEDEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769842553; c=relaxed/simple; bh=5BmH12YbHKMwJRnWZOYAXW3Pk9yR76BehzdsGZW/grE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=SththUWMpvPK7+n5A14pQ7gXwgogFZujPqsA7iM9V+ITMA04AOAh3ydfcu6ij1BuNwZUprEMsRjjE2F332SUJbUtv2eKQ8T8W43qM520ktXgAAhDauP1eE7SqA1/2peMnXu21XONWDABAtuWJB5GBVjaFuGxwf1tJ+wY9QVFqNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QLHnadnT; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so27988055ad.2 for ; Fri, 30 Jan 2026 22:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769842550; x=1770447350; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KDLJXl3kO9WYLHYaAYOE8EZpw5zllMbrwjKTsjUtSuU=; b=QLHnadnTnLxIX7gRLWW4pI+261VDu9j+czXO4MmuQiXFnXFLuLlZBqnzgkOy2TNJRJ jr+nSXC5oWd00y5jCdabX9RF/4bQXpoSe40wf1FcIUEQ8GvP/wVvMklJVpGRKlfAPPzM IN39zS1vSeUqTc1O2vJmYrM8bhpPZnNWZfIKxZLsmrMtvYL93kJEt41Xh7dHTNJbmU7S MGCeSk19nKkEatiIibmBQhiZHDoG3DAw6tN2DY1FCtnLMOWbxYxoUAW8Gaf4sTU0nZOe tkYN0Ca+jVLHQ5QbvHVxROAz+HbTEn0NHAJ6JM4cKf6QdiwaClJ2PiUaXiT751c8JI1W 9Hhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769842550; x=1770447350; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KDLJXl3kO9WYLHYaAYOE8EZpw5zllMbrwjKTsjUtSuU=; b=LgbzvyWPhIxWcsAhpSJbRE0QX9r/PgOGNOJF94OzytNV3Iv3lni3x4S62s/mL3fPbP INYjn4gvU0mxIe6qUUHPex/T3qNc6kEYKvzTQA1pox/CifNjhgHQxQhTq5UzNE4zwtrP Yjg/ZQ9/c+7VDRT9XkzwuXIaSwjp3igpA4NAj/ChOlJZusO911jfdUzPOUHx4kcv8ejD TVnWn9gbo41UM+AgeLZMvFqdIe2NwxD/qSBYbcPDHi8EtfQ90rhL/ZuI8Zs3HXYHfE/q pGVU9OZV9tRGYEXuTtfuDflHVIYPM5MTN+qjVq9FZAinmenW5Rf3dvOQ6h0tTYdR2hHT umSg== X-Forwarded-Encrypted: i=1; AJvYcCW65DM4mYrRyasrH3u6f1LUXi4h83IEIS9fSQBJMwxhCkmzeaTuOQhLPTT2JAowhvReHK+pWb4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf+RIyLNd6TL/nLjJswRwrqo6aMLHZIjIi+UMb9Sef8gMxeZ30 X6mgJR3OaLCNTi4sDxYbipnhnmKjvxoj2Y76o8yPw6PZG9BwV5UFHeqq X-Gm-Gg: AZuq6aLjGBBHs6ISeLks6Qi+ePJxM1m6Kj4awrOFAlaaNsDg17lvu7s+DYfQQq+gZpL C7VvJSO35uv3rOb/GEFYtVxihm97mAzQTQeN/T2lWVgR+tqkUEknqs+glCK7dHQKBu2KIYJY/v7 5VULWUY2pEhwGGzj7OLay+onrbbGXypEWLNSeBQj16lVnnpujj+1mWdm2YU51cKPRDxbOX7EM6C k86j0ZAs76KRsiNgbpsholdJSXRK1izneN7IeqjYOSm7Z9t7y/irnoEoAnESF4LfBeRxDRFwBsv BGvqGji++LQs0w/Nkv8cnOonwcvSh2wDAseTurrumJYF+30PvTIop5V+U8a2LbXhKdP90Xfcbw3 adJdFNnh4KmqoaJGhwUrG95SuWX/dkGcuk1vDqUQY7mIlwbrUeoe3Opsc6JNuJP38L98YYLGg8P 0eZL/aB5xwj+00vmcOwxvJPaOFWZJkUpfFeA== X-Received: by 2002:a17:902:ea11:b0:2a8:3707:d79f with SMTP id d9443c01a7336-2a8d96e3bfamr54830685ad.26.1769842550031; Fri, 30 Jan 2026 22:55:50 -0800 (PST) Received: from localhost.localdomain ([111.202.170.108]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b5d9a7bsm92571725ad.79.2026.01.30.22.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 22:55:49 -0800 (PST) From: Xingjing Deng X-Google-Original-From: Xingjing Deng To: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, gregkh@linuxfoundation.org Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Xingjing Deng , stable@vger.kernel.org Subject: [PATCH v8] misc: fastrpc: check qcom_scm_assign_mem() return in rpmsg_probe Date: Sat, 31 Jan 2026 14:55:39 +0800 Message-Id: <20260131065539.2124047-1-xjdeng@buaa.edu.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.232.135.74 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [micro6947[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 In the SDSP probe path, qcom_scm_assign_mem() is used to assign the reserved memory to the configured VMIDs, but its return value was not checked. Fail the probe if the SCM call fails to avoid continuing with an unexpected/incorrect memory permission configuration. This issue was found by an in-house analysis workflow that extracts AST-based information and runs static checks, with LLM assistance for triage, and was confirmed by manual code review. No hardware testing was performed. Fixes: c3c0363bc72d4 ("misc: fastrpc: support complete DMA pool access to the DSP") Cc: stable@vger.kernel.org # 6.11-rc1 Signed-off-by: Xingjing Deng --- v8: - Remove the redundant brace. - Link to v7: https://lore.kernel.org/linux-arm-msm/20260129233703.407404-1-xjdeng@buaa.edu.cn/ v7: - Add the detail description of how the tool detect. - Link to v6: https://lore.kernel.org/linux-arm-msm/20260128033454.2614886-1-xjdeng@buaa.edu.cn/ v6: - Add description of the detection tool. - Link to v5: https://lore.kernel.org/linux-arm-msm/20260117140351.875511-1-xjdeng@buaa.edu.cn/T/#u v5: - Squash the functional change and indentation fix into a single patch. - Link to v4: https://lore.kernel.org/linux-arm-msm/2026011637-statute-showy-2c3f@gregkh/T/#t v4: - Format the indentation - Link to v3: https://lore.kernel.org/linux-arm-msm/20260113084352.72itrloj5w7qb5o3@hu-mojha-hyd.qualcomm.com/T/#t v3: - Add missing linux-kernel@vger.kernel.org to cc list. - Standarlize changelog placement/format. - Link to v2: https://lore.kernel.org/linux-arm-msm/20260113063618.e2ke47gy3hnfi67e@hu-mojha-hyd.qualcomm.com/T/#t v2: - Add Fixes: and Cc: stable tags. - Link to v1: https://lore.kernel.org/linux-arm-msm/20260113022550.4029635-1-xjdeng@buaa.edu.cn/T/#u --- drivers/misc/fastrpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index ee652ef01534..a669e4b2bb35 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -2337,8 +2337,10 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) if (!err) { src_perms = BIT(QCOM_SCM_VMID_HLOS); - qcom_scm_assign_mem(res.start, resource_size(&res), &src_perms, + err = qcom_scm_assign_mem(res.start, resource_size(&res), &src_perms, data->vmperms, data->vmcount); + if (err) + goto err_free_data; } } -- 2.25.1 From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id +A2OOU6pfWlEVBMAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 07:03:42 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 07:03:43 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm51C-00000005e5E-2fDK for hi@josie.lol; Sat, 31 Jan 2026 07:03:42 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 4D898300C923 for ; Sat, 31 Jan 2026 07:03:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C14C51E98EF; Sat, 31 Jan 2026 07:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=enjuk.jp header.i=@enjuk.jp header.b="DFLkZzag" X-Original-To: stable@vger.kernel.org Received: from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C3335D8F0 for ; Sat, 31 Jan 2026 07:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.212.198.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769843020; cv=none; b=iWI6qTMT1b1DcibuhwBHTXpgA7bVHrTtDuK5GURXbwsCCZHUMySDfv1hC9TynWaPB4nTM7J5uR+S3aDCKN9BGggZi1HpqKxE3+xcIenR6n0l187mVM1cO5HbPCPX7WtlnxnXLNPRRMpJOyAb4LDsHXTgSIwmrgY5uhfRpna5aY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769843020; c=relaxed/simple; bh=6EWdvGFMeGOZ3ybmMF54CEgrpRbcZjIC0e7KxtUYD1g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MZrEd1s942qt37h5z9me01LFDAkgK4g6j2T0KEBOu1jbmWKYKWy4L6GuaGneKSS4Ly1dJ3XfCh2axrpJ8XWgaOCEjbpMJO6tT3UESFR09orL3BknAip4iqVkA811gx3XGHNzpwGrClYYp7TQ8D/X6aGXVAJ59tDwY87mlB8kvNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enjuk.jp; spf=pass smtp.mailfrom=enjuk.jp; dkim=pass (2048-bit key) header.d=enjuk.jp header.i=@enjuk.jp header.b=DFLkZzag; arc=none smtp.client-ip=49.212.198.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enjuk.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enjuk.jp Received: from ms-a2 (248.212.13.160.dy.iij4u.or.jp [160.13.212.248]) (authenticated bits=0) by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 60V73ZSS013433 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 31 Jan 2026 16:03:36 +0900 (JST) (envelope-from kohei@enjuk.jp) DKIM-Signature: a=rsa-sha256; bh=9+22T3qAILLWnarXKk2rk2jH9okIYXXwV2PNBFUkk50=; c=relaxed/relaxed; d=enjuk.jp; h=From:To:Subject:Date:Message-ID; s=rs20251215; t=1769843017; v=1; b=DFLkZzagAsrFRi53NMETPhbWhcFfg4o9hcQnuMUXLA+1j4H5WwvOjBmv9eykxz5T jW4UkQWDIv0yMUtX7cCJmimqaWrj4WIBnkAI92WdByrBv4TyXcH8m9t10KgRqlPZ gehnhZxXZZGTayYdVsFSyM1NRhDOFiHR4/lSqYNWNjwhiytG9SSnXes38QxL7qDS obF5Rs+DGcWrwMzi+cR8+pBgExZOKFVCiSP2D/2wELUankdMn2dKpSDiLbQQEFls 1dQlmUkmdZG0t+sMc+C3AqruS/u9w9a7hT4mBomgbSaG7+5EheuasQ4ZAW//4dQU ofR8nH7F98rogpqaFEHOLg== From: Kohei Enju To: kohei@enjuk.jp Cc: andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com, bjorn@kernel.org, daniel@iogearbox.net, davem@davemloft.net, edumazet@google.com, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, lihaoxiang@isrc.iscas.ac.cn, linux-kernel@vger.kernel.org, magnus.karlsson@intel.com, netdev@vger.kernel.org, pabeni@redhat.com, przemyslaw.kitszel@intel.com, stable@vger.kernel.org Subject: Re: [Intel-wired-lan] [PATCH v2] i40e: add an error handling path in Date: Sat, 31 Jan 2026 07:02:38 +0000 Message-ID: <20260131070335.38303-1-kohei@enjuk.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260131061304.27368-1-kohei@enjuk.jp> References: <20260131061304.27368-1-kohei@enjuk.jp> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='enjuk.jp' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On Sat, 31 Jan 2026 06:12:12 +0000, Kohei Enju wrote: > On Sat, 31 Jan 2026 13:52:17 +0800, Haoxiang Li wrote: > > > In i40e_xsk_pool_enable(), add an error handling path to > > prevent potential memory leaks. > > > > Fixes: 1742b3d52869 ("xsk: i40e: ice: ixgbe: mlx5: Pass buffer pool to driver instead of umem") > > Cc: stable@vger.kernel.org > > Signed-off-by: Haoxiang Li > > --- > > Changes in v2: > > - Add a Fixes tag. Thanks, Paul! > > - Replace unmap with i40e_xsk_pool_disable() to prevent > > a limbo state of queues. Thanks, Maciej! > > --- > > drivers/net/ethernet/intel/i40e/i40e_xsk.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c > > index 9f47388eaba5..a72a309540c3 100644 > > --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c > > +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c > > @@ -108,23 +108,26 @@ static int i40e_xsk_pool_enable(struct i40e_vsi *vsi, > > if (if_running) { > > err = i40e_queue_pair_disable(vsi, qid); > > if (err) > > - return err; > > + goto err_out; > > > > err = i40e_realloc_rx_xdp_bi(vsi->rx_rings[qid], true); > > if (err) > > - return err; > > + goto err_out; > > > > err = i40e_queue_pair_enable(vsi, qid); > > if (err) > > - return err; > > + goto err_out; > > > > /* Kick start the NAPI context so that receiving will start */ > > err = i40e_xsk_wakeup(vsi->netdev, qid, XDP_WAKEUP_RX); > > if (err) > > - return err; > > + goto err_out; > > } > > > > return 0; > > + > > +err_out: > > + i40e_xsk_pool_disable(vsi, qid); > > I think return err; is missing... > > Also, since i40e_xsk_pool_disable is not declared before this line, > compilation fails due to a 'Call to undeclared function > i40e_xsk_pool_disable' error. Adding declaration or moving > i40e_xsk_pool_enable() after i40e_xsk_pool_disable() is needed. After skimming the code, I think i40e_xsk_pool_disable() can fail in this error path, right? Let's assume a scenario that i40e_queue_pair_disable() succeeds but i40e_realloc_rx_xdp_bi() fails in i40e_xsk_pool_enable(). At this point, i40e_enter_busy_conf() called by i40e_queue_pair_disable() has set __I40E_CONFIG_BUSY state. Then the err_out: path is executed and i40e_xsk_pool_disable() tries to call i40e_queue_pair_disable() when if_running. In this case, i40e_enter_busy_conf() fails because __I40E_CONFIG_BUSY is set, and finally xsk_pool_dma_unmap() isn't called. Do you have any thoughts on how to handle this case? Thanks. > > > } > > > > /** > > -- > > 2.25.1 From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id mP3gM9qwfWkhKBQAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 07:35:54 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 07:35:55 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm5WM-00000006Sq4-1yM7 for hi@josie.lol; Sat, 31 Jan 2026 07:35:54 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 58D2D300F9F8 for ; Sat, 31 Jan 2026 07:35:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 644A8329E4F; Sat, 31 Jan 2026 07:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gZOY13HI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iEsvYsz8" X-Original-To: stable@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14682307AD5 for ; Sat, 31 Jan 2026 07:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769844946; cv=none; b=hUqqcf5HMtMz0sVYfgJI0Joyd07pUCKYMZcHwU+w3X0W9grWj07fOo71IidIBT4GBxsB6rRc8psT2Fl45XknCdZvdJCfOQc9Bf3yY6d0Ko50awY1Bg+4+7dwtyInUgBGBtzC7h6RY6zdcl4QpLTYo3Rszr1mOVaMGJJhprR3kf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769844946; c=relaxed/simple; bh=hvVnxPOrZIbUtHJz7oves9pDbzDR3Que2PqHawVoVZo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KGStRnvBWq6OT/YvD/dJSal9YqhZidd7SlPo9GHgWGRELl3JxS9X7ffbXZOBxSn8tQtgxUkuwvwUEav3cqFmQ1penVml88g0IYncjU8OKwkTbGDcgoge8eds+6Dng3flnCagAwmCOHv1dX2qgXqwkidhP4kmXLbSfPj0KgmwA34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gZOY13HI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iEsvYsz8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60V4SiG31510045 for ; Sat, 31 Jan 2026 07:35:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=SUqzqLvgto+ebNJM8P3jaMfV gKVElHQyD3m2HQJHmkE=; b=gZOY13HIhKlknlRFc9Py5Rje7e39U5LQJNlrToYk CXPQ7X6R3U7Fz4kGIZA2tOuFK22bmJXk7ebGs7beGLx/iieBEP6KNBYU2SaJiPB8 OL9peJSU09SDGH52fQf8OVJxjVyk9G6QXKo5GLWyYNqE5iz5kUlmkT/3hUF372u1 4Cj3/cA2EUUaMJO74sCgRbj+bHXBtlD34i3kurF22P/e1Z11wKV/Arjo3a+FdVkJ qmPflA7Vvjx7wR7lBxd1HbOX86tIgNDi22ja+7+7aqvjnD+bok6tpFeevwhy6y4+ O+oUg+H48hfnfuWv9t9AH2vbE7CbR83HxnH8ylowRpa+9A== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1ard0d37-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 31 Jan 2026 07:35:44 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-5f58f90f83aso8092848137.0 for ; Fri, 30 Jan 2026 23:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769844943; x=1770449743; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SUqzqLvgto+ebNJM8P3jaMfVgKVElHQyD3m2HQJHmkE=; b=iEsvYsz80K+q5GtHtWHWmFCCekriSgW1/ff0sIjMmbM+G2pYdkVrwHTic4LuIg1JGC zP3sLSkHVtextlPsex5+vAAITO657+Eho22Kir0D303gRIx/Gv1SVJeYn2ARgi6+Kn+4 Ri6pXKePT33wnXIxKY3uFoeH7ua8i/X23F71eSUOAVm1LFJ++8jtWl0zmtpAUa4/IS4y HMc6wHY5JME5wJWGJOhukTIhkz4s/QGHsOyFM9hSAq/yOR5kx7KNqN5OyLPVIupA92fn YEhgIxhjQNp/3iQclts0jxiQvza0dQRyUa1vjN5Eg8i+kj/qTOOF53CPnANNhXOY9qg3 H+wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769844943; x=1770449743; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SUqzqLvgto+ebNJM8P3jaMfVgKVElHQyD3m2HQJHmkE=; b=RBiedoDq/mjxBY1+jTr5XuVwtetWNZsFZQ04Vjh1Q2dBjklvbILlW0o63auNHp8aIX 0xAgEv0biJ3Wpp9QYquY4O3K547/bts++0FxxFP6ftz6z2Bx56JxsD5JT9Svt7F42iMY NJn6P98IYayNWmNsQ893f8AQrPBa8L7lygDS6EIsT73q3uBXSNiDPfQZSBxryr/SaT0x cCOt797uAvZAnoBXZ9S8LlgQLVHYSwOne6FyhxYu+YllOxGkKN2DjWv3jwixcTBD+7IB /vP2LCPu9klx60JW5Cio+n/8ToPyQohkFloKSK39tlYL5Z9F32lZnX81XdJH2Dt+RoQ/ jZ+w== X-Forwarded-Encrypted: i=1; AJvYcCWrO7cIA/TDloTpGTp6WRaTwIBxJd8UzqFajm5T5qTgc5+cHNAWW90qigR+4ooPK9n5uJf3jNM=@vger.kernel.org X-Gm-Message-State: AOJu0YxVOtLCNP630xLGwngpZtuMXFX2QGvbKrUPAyruindoanByCqCK wPDLrsgM6G0McMzYtwTQkal+TNmMVgwzamAXYR+nX+BGySto0uIuVt/eTq1YGTxJBNU48kr6gez pISYeV1oTJ2LXF/LhYUGEVQfZQRchmhh3Qc/P2Dyy25YjXYIHobua5rSsg0hCQ5kG6I0= X-Gm-Gg: AZuq6aLyExNOWI2QAwfEL0c146iovEWSgRWxQxo3CPLcPPICmC75U3+Geijye1c2Pg9 pwmYEZhZZgpnNmXTbG0tz7fsZM9u9nd9aP0RQ+kbFUZI5W61SrgQt3XXCpPK6A9vcHTK+gNxu2v aSasWydrvBHvXNLkqWT6SOCP8MzaZW3WjZyI6o38nsX3mAFdrZnT3nt8BHT2F6biDv8vLU98jdS G7H1HTLTMr89Td9i5gpFq/lBnPQDysusFbDzfAyCwbxDUIBCWfXTr9wkICJazPD8EVeECabgr1t ePCBlpGVIkTuSUFSwa6o0EvVyZPcwHZtKyLK/HPfMrDEmkwXWYxBEo3w5Ml5EKdmYvPxZiowi/D RerURlRzUA1gxZ/UjGUbD4u3ZsThW3fj8toWvBvYRtquSjns7HwlQpjPdniQXTnH9ifo3nkPWAK sEgxB9JnYYP1HcRNWvpcJMDJ4= X-Received: by 2002:a05:6102:d87:b0:5f5:3c96:983f with SMTP id ada2fe7eead31-5f8e236d78emr1957067137.1.1769844942942; Fri, 30 Jan 2026 23:35:42 -0800 (PST) X-Received: by 2002:a05:6102:d87:b0:5f5:3c96:983f with SMTP id ada2fe7eead31-5f8e236d78emr1957059137.1.1769844942560; Fri, 30 Jan 2026 23:35:42 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e074beadcsm2216555e87.95.2026.01.30.23.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 23:35:40 -0800 (PST) Date: Sat, 31 Jan 2026 09:35:38 +0200 From: Dmitry Baryshkov To: Xingjing Deng Cc: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Xingjing Deng , stable@vger.kernel.org Subject: Re: [PATCH v8] misc: fastrpc: check qcom_scm_assign_mem() return in rpmsg_probe Message-ID: References: <20260131065539.2124047-1-xjdeng@buaa.edu.cn> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260131065539.2124047-1-xjdeng@buaa.edu.cn> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMxMDA2MSBTYWx0ZWRfX/wnvD8YXYMex x613nRrJdmgdbmODlg7OPMn0K7hzM9I2ED0aLx6qJIbKs4yXvHCOPC8CyhWFV7wUCR9nbKLhor+ 5GRMxgNiGSx6TDhqeIgiEnJMBuBrSYR/trlFptw5L3fBG1oG74JsEbkD4KROH5SloMi4NKhlXZ9 znqnghDwFRPm6CnkKUAnquaGrNmYxsziTmJ1lyyYH0H0mbEi9E11FZ+vE7Fy/vk4494iUGdEKYb fh6bNVmWsi607jkw6COOd2XXsjMCl27kDqux04ltESNFWTbgdL+yzgtbXrOckHWpszmRnfZ/hRX z5GuY74jt3+v/aCl2faR8rfavL1beF02bwezvzEUHse5My7BOtkN6VUsqz/f2G11KicOrM02zyb uS3TMgjn03sJ/5iorFO7oWMqNMS/RogbrDGu7hiFL4FD7rLBRZ+rPTmSvBh7bON+vVJsdiPch8c PrkWGqn6vWdOfX3ClFw== X-Authority-Analysis: v=2.4 cv=J6anLQnS c=1 sm=1 tr=0 ts=697db0d0 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=gt7TBnWFjOhXHAj3EKgA:9 a=CjuIK1q_8ugA:10 a=zZCYzV9kfG8A:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-ORIG-GUID: KZTwFxD5DI4P2gFfF0RNTLMBafw1C_Y8 X-Proofpoint-GUID: KZTwFxD5DI4P2gFfF0RNTLMBafw1C_Y8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_04,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1015 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601310061 X-DKIM: signer='qualcomm.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-DKIM: signer='oss.qualcomm.com' status='pass' reason='' X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: qualcomm.com] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On Sat, Jan 31, 2026 at 02:55:39PM +0800, Xingjing Deng wrote: > In the SDSP probe path, qcom_scm_assign_mem() is used to assign the > reserved memory to the configured VMIDs, but its return value was not checked. > > Fail the probe if the SCM call fails to avoid continuing with an > unexpected/incorrect memory permission configuration. > > This issue was found by an in-house analysis workflow that extracts AST-based > information and runs static checks, with LLM assistance for triage, and was > confirmed by manual code review. > No hardware testing was performed. > > Fixes: c3c0363bc72d4 ("misc: fastrpc: support complete DMA pool access to the DSP") > Cc: stable@vger.kernel.org # 6.11-rc1 > Signed-off-by: Xingjing Deng > --- > v8: > - Remove the redundant brace. > - Link to v7: https://lore.kernel.org/linux-arm-msm/20260129233703.407404-1-xjdeng@buaa.edu.cn/ > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry From - Sat Jan 31 08:51:03 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id MGp6Jzu3fWkxlxkAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 08:03:07 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 08:03:07 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vm5wh-00000007ACY-1Ig3 for hi@josie.lol; Sat, 31 Jan 2026 08:03:07 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 752AA300C921 for ; Sat, 31 Jan 2026 08:03:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2EFA01E4AF; Sat, 31 Jan 2026 08:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VMe8LG9p" X-Original-To: stable@vger.kernel.org Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBB2C2BDC27 for ; Sat, 31 Jan 2026 08:03:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769846585; cv=none; b=ggaRX5KoYe4C79fJkO4m/WqLsO/GM/aBIuHcyiWrFHMeDBRX0LzD9hK1oNfSmnIwtDGuPew86oCOUxGA8GHd5i2+GdDo4YbUalDgnkdMSCYhcmUdLWFHrPMc1jCSY3uOB/HvKIXnzKHr7PEOLATjjc6B1kSnNkfJfbsdGg9uKMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769846585; c=relaxed/simple; bh=dBbkA3s8ZDlYOu+fYRUqtVqIzyY2MkklyEgHq02a5fs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JrNZ+5I342QaUtsqTAlD/WPUGjWlYfaRax6p24KDhEKyzvPM3IGbZWOkGoj5gzr3R7kB6CZbt2RbxTQv1PpuhZVH6aq0+wlo7/bxtPq0w5WIhC8+PpbP/cCt9pFU4h1qNHXdBez01O5ZVzS0X1XguK8TDof9BQ/sAItFEphiFws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VMe8LG9p; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c075ec1a58aso1169644a12.0 for ; Sat, 31 Jan 2026 00:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769846583; x=1770451383; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2XcWW/vYfFgkZEN1KNi9wjY+Xh26NCKHQFJADTAEK40=; b=VMe8LG9p9LvaiT2CX/lJZ7XcM0lCSdiOcrsZZ8H+1r8VoeDcTVON+rAcA57oZaDid+ xh2wxKeZ0F8tkKjtbJga4vPNo9c4xJssQZpwKZjGMtmFOIMRN6flPYSdVMUS7OdEfVLD Atx3Qh2tKFYXzteIRklvb7ZmkujzqcQsmXT14PP4E+36lDHeuCJatNZSb6aMSJQF4w3C mcknrpxThbRxHzIUH7sD3zmVxCaTjdsV7NWWE8gkW+2xRJZJinpN2u6nUp/y/y0141nE 3K9u3MgVVTOLEl+3T9algye9YB1gWeV+sOwPtzzatkxUuF8SaL/PycHy9OpBeX2aTna0 gGIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769846583; x=1770451383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2XcWW/vYfFgkZEN1KNi9wjY+Xh26NCKHQFJADTAEK40=; b=E+zxtrbmLOqdtg3jcZyH3YVYHtTTTnGKUXjJiZMmkIuogAPUknsBhSM4OTJdeKdZ9u EBg65PdJgGoMBPv1q2jfBe6Kt0a4TdA1PTgoiAHA84vTb2U5QSwxwCF6/XjlQ9ko4E+u WR0f4EbMPseAzC8vjrFldXnhXJABg34lmMF35YzDmM845rzPS7IGeYGEYg0hRDT5xyay fTq3mfx05g20aS0TteM7XIQVw0D/8w5teKXgldcQEQnwXKSR7n9MKxa+RazRA5iGD+pP Gb80LM/DKEpAJWBbB9wRRSjRwEbfpt0MP/clUnN0QJFFEFmEjV0qbfSQWYOl61YymFH6 rsJA== X-Forwarded-Encrypted: i=1; AJvYcCX8Rj3Wi5cy9f4OKdiR4s7wsR5masujvNLB62qDaZT3cfbj4RQPo1c5S8VSbGSUAp9vjY89HBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyGtmpvfClRaRn5EFmmIo1jv6z+eLyR0NtDc2lidM9Agjg11vHK 4wwB2gd+MGxIdvePBjsEM6RVN4VCCncZjE33sVLoutYjsoy3FQXHRL6a X-Gm-Gg: AZuq6aIc6WRKDjhM2i13rQlFSTeJf07iFacXJxeZA1uvqg/Ql3ijRNnpH5n7yRxkIUH SCfZsczgoFnose05txkmGDSg/EtZ29Ix3/4Ks/SroL9rKGnXK/suMDwJDe07tgJ7p/m9JcbSU9D J/4K31TrC2PyxBnnDeE2qDkslsGeN60QaPnTqFtBgZECIjfAH07tMyWSGXCf+z5ie3orP+rLQcq eNB24Nb6QgnE8sPwVwcw46gX8CTBKlwsUocKFoTcwMtCQPy/VRb7kPupGyDyaX6ARSgrNmyhOVx F51jA1bJLkRsvVyne4A4NnWG9TYOvb22L3eG1wuBj/Jm8TkhVNH3oVA9E+BiO2jV+CmjqXqQkI6 qHuRfOjKk3RMoTYOgiL7FtXgfZ5b9Ojh5J689qoNDQAHWwq1wUcayoK6yUpk9FihU7htkfNf5Um KSmKcGATOWfx7LfRGphUwZ+EKPur2lGnqGrzMOEmHG X-Received: by 2002:a17:902:e88a:b0:2a0:c1ed:c8c2 with SMTP id d9443c01a7336-2a8d99458d9mr49139415ad.55.1769846582973; Sat, 31 Jan 2026 00:03:02 -0800 (PST) Received: from sprasad-dev1.corp.microsoft.com ([167.220.110.216]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b7f6c7csm98853045ad.98.2026.01.31.00.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 00:03:02 -0800 (PST) From: nspmangalore@gmail.com X-Google-Original-From: sprasad@microsoft.com To: linux-cifs@vger.kernel.org, smfrench@gmail.com, pc@manguebit.org, bharathsm@microsoft.com Cc: Shyam Prasad N , stable@vger.kernel.org Subject: [PATCH 2/2] cifs: Fix locking usage for tcon fields Date: Sat, 31 Jan 2026 13:32:16 +0530 Message-ID: <20260131080239.943483-2-sprasad@microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260131080239.943483-1-sprasad@microsoft.com> References: <20260131080239.943483-1-sprasad@microsoft.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DKIM: signer='gmail.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [nspmangalore[at]gmail.com] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.234.253.10 listed in list.dnswl.org] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 From: Shyam Prasad N We used to use the cifs_tcp_ses_lock to protect a lot of objects that are not just the server, ses or tcon lists. We later introduced srv_lock, ses_lock and tc_lock to protect fields within the corresponding structs. This was done to provide a more granular protection and avoid unnecessary serialization. There were still a couple of uses of cifs_tcp_ses_lock to provide tcon fields. In this patch, I've replaced them with tc_lock. Cc: stable@vger.kernel.org Signed-off-by: Shyam Prasad N --- fs/smb/client/cached_dir.c | 4 ++-- fs/smb/client/smb2misc.c | 6 +++--- fs/smb/client/smb2ops.c | 8 +++----- fs/smb/client/smb2pdu.c | 2 ++ 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fs/smb/client/cached_dir.c b/fs/smb/client/cached_dir.c index 1db7ab6c2529c..84c3aea18a1a7 100644 --- a/fs/smb/client/cached_dir.c +++ b/fs/smb/client/cached_dir.c @@ -788,11 +788,11 @@ static void cfids_laundromat_worker(struct work_struct *work) cfid->dentry = NULL; if (cfid->is_open) { - spin_lock(&cifs_tcp_ses_lock); + spin_lock(&tcon->tc_lock); ++cfid->tcon->tc_count; trace_smb3_tcon_ref(cfid->tcon->debug_id, cfid->tcon->tc_count, netfs_trace_tcon_ref_get_cached_laundromat); - spin_unlock(&cifs_tcp_ses_lock); + spin_unlock(&tcon->tc_lock); queue_work(serverclose_wq, &cfid->close_work); } else /* diff --git a/fs/smb/client/smb2misc.c b/fs/smb/client/smb2misc.c index f3cb62d914502..0871b9f1f86a6 100644 --- a/fs/smb/client/smb2misc.c +++ b/fs/smb/client/smb2misc.c @@ -820,14 +820,14 @@ smb2_handle_cancelled_close(struct cifs_tcon *tcon, __u64 persistent_fid, int rc; cifs_dbg(FYI, "%s: tc_count=%d\n", __func__, tcon->tc_count); - spin_lock(&cifs_tcp_ses_lock); + spin_lock(&tcon->tc_lock); if (tcon->tc_count <= 0) { struct TCP_Server_Info *server = NULL; trace_smb3_tcon_ref(tcon->debug_id, tcon->tc_count, netfs_trace_tcon_ref_see_cancelled_close); WARN_ONCE(tcon->tc_count < 0, "tcon refcount is negative"); - spin_unlock(&cifs_tcp_ses_lock); + spin_unlock(&tcon->tc_lock); if (tcon->ses) { server = tcon->ses->server; @@ -841,7 +841,7 @@ smb2_handle_cancelled_close(struct cifs_tcon *tcon, __u64 persistent_fid, tcon->tc_count++; trace_smb3_tcon_ref(tcon->debug_id, tcon->tc_count, netfs_trace_tcon_ref_get_cancelled_close); - spin_unlock(&cifs_tcp_ses_lock); + spin_unlock(&tcon->tc_lock); rc = __smb2_handle_cancelled_cmd(tcon, SMB2_CLOSE_HE, 0, persistent_fid, volatile_fid); diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c index c1aaf77e187b6..6f930d6c78adb 100644 --- a/fs/smb/client/smb2ops.c +++ b/fs/smb/client/smb2ops.c @@ -3091,7 +3091,9 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses, struct cifs_tcon, tcon_list); if (tcon) { + spin_lock(&tcon->tc_lock); tcon->tc_count++; + spin_unlock(&tcon->tc_lock); trace_smb3_tcon_ref(tcon->debug_id, tcon->tc_count, netfs_trace_tcon_ref_get_dfs_refer); } @@ -3160,13 +3162,9 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses, out: if (tcon && !tcon->ipc) { /* ipc tcons are not refcounted */ - spin_lock(&cifs_tcp_ses_lock); - tcon->tc_count--; + cifs_put_tcon(tcon); trace_smb3_tcon_ref(tcon->debug_id, tcon->tc_count, netfs_trace_tcon_ref_dec_dfs_refer); - /* tc_count can never go negative */ - WARN_ON(tcon->tc_count < 0); - spin_unlock(&cifs_tcp_ses_lock); } kfree(utf16_path); kfree(dfs_req); diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c index 5d57c895ca37a..c7e086dfb1765 100644 --- a/fs/smb/client/smb2pdu.c +++ b/fs/smb/client/smb2pdu.c @@ -4239,7 +4239,9 @@ void smb2_reconnect_server(struct work_struct *work) list_for_each_entry(tcon, &ses->tcon_list, tcon_list) { if (tcon->need_reconnect || tcon->need_reopen_files) { + spin_lock(&tcon->tc_lock); tcon->tc_count++; + spin_unlock(&tcon->tc_lock); trace_smb3_tcon_ref(tcon->debug_id, tcon->tc_count, netfs_trace_tcon_ref_get_reconnect_server); list_add_tail(&tcon->rlist, &tmp_list); -- 2.43.0 From - Sat Jan 31 09:25:20 2026 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id EELqNgjFfWmswRgAYBR5ng (envelope-from ) for ; Sat, 31 Jan 2026 09:02:00 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Sat, 31 Jan 2026 09:02:01 +0000 Received: from sea.lore.kernel.org ([172.234.253.10]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from