g X-Gm-Message-State: AOJu0YxGnrd7/jbOKw1HIoUVkdhGsG/ALvWAPO/UQGwGBhRZ0Sa3Pn5H SgBDqFTPfL4RcGE2SoD+N6EexD0YQWEdeoPclXItT66LEUQIbtd2ma/RolMoy7K5NIMMJP9KLTh aHvjmaQ== X-Google-Smtp-Source: AGHT+IFwzWgtPptIOyQJLby5S982+3QC2rN4V2KVy1J/lj/jLP6cxRNrCIT8QnhPtZST1lAtZV6zpA10OhY= X-Received: from pfbfb38.prod.google.com ([2002:a05:6a00:2da6:b0:76b:f0d4:ac71]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:140e:b0:7ff:885f:9c2a with SMTP id d2e1a72fcca58-7ff885fa2d7mr3264079b3a.12.1766165910740; Fri, 19 Dec 2025 09:38:30 -0800 (PST) Date: Fri, 19 Dec 2025 09:38:29 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251219010131.12659-1-ariadne@ariadne.space> Message-ID: Subject: Re: [PATCH] x86/CPU/AMD: avoid printing reset reasons on Xen domU From: Sean Christopherson To: Teddy Astie Cc: Ariadne Conill , linux-kernel@vger.kernel.org, mario.limonciello@amd.com, darwi@linutronix.de, sandipan.das@amd.com, kai.huang@intel.com, me@mixaill.net, yazen.ghannam@amd.com, riel@surriel.com, peterz@infradead.org, hpa@zytor.com, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, xen-devel@lists.xenproject.org, stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-DKIM: signer='google.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -7.1 (-------) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-7.1 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [172.105.105.114 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -7.5 USER_IN_DEF_DKIM_WL From: address is in the default DKIM welcome-list -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_MED DKIMwl.org - Medium trust sender SpamTally: Final spam score: -70 On Fri, Dec 19, 2025, Teddy Astie wrote: > Le 19/12/2025 =C3=A0 02:04, Ariadne Conill a =C3=A9crit=C2=A0: > > Xen domU cannot access the given MMIO address for security reasons, > > resulting in a failed hypercall in ioremap() due to permissions. > > > > Fixes: ab8131028710 ("x86/CPU/AMD: Print the reason for the last reset"= ) > > Signed-off-by: Ariadne Conill > > Cc: xen-devel@lists.xenproject.org > > Cc: stable@vger.kernel.org > > --- > > arch/x86/kernel/cpu/amd.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > > index a6f88ca1a6b4..99308fba4d7d 100644 > > --- a/arch/x86/kernel/cpu/amd.c > > +++ b/arch/x86/kernel/cpu/amd.c > > @@ -29,6 +29,8 @@ > > # include > > #endif > > > > +#include > > + > > #include "cpu.h" > > > > u16 invlpgb_count_max __ro_after_init =3D 1; > > @@ -1333,6 +1335,10 @@ static __init int print_s5_reset_status_mmio(voi= d) > > if (!cpu_feature_enabled(X86_FEATURE_ZEN)) > > return 0; > > > > + /* Xen PV domU cannot access hardware directly, so bail for domU case= */ > > + if (cpu_feature_enabled(X86_FEATURE_XENPV) && !xen_initial_domain()) > > + return 0; > > + > > addr =3D ioremap(FCH_PM_BASE + FCH_PM_S5_RESET_STATUS, sizeof(value)= ); > > if (!addr) > > return 0; >=20 > Such MMIO only has a meaning in a physical machine, but the feature > check is bogus as being on Zen arch is not enough for ensuring this. >=20 > I think this also translates in most hypervisors with odd reset codes > being reported; without being specific to Xen PV (Zen CPU is > unfortunately not enough to ensuring such MMIO exists). >=20 > Aside that, attempting unexpected MMIO in a SEV-ES/SNP guest can cause > weird problems since they may not handled MMIO-NAE and could lead the > hypervisor to crash the guest instead (unexpected NPF). IMO, terminating an SEV-ES+ guest because it accesses an unknown MMIO range= is unequivocally a hypervisor bug. The right behavior there is to configure a reserved NPT entry to reflect the access into the guest as a #VC. From - Fri Dec 19 17:41:32 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id eGftHkiORWkhPwMAYBR5ng (envelope-from ) for ; Fri, 19 Dec 2025 17:41:28 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Fri, 19 Dec 2025 17:41:28 +0000 Received: from tor.lore.kernel.org ([172.105.105.114]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vWeTn-00000001ZOz-3zXK for hi@josie.lol; Fri, 19 Dec 2025 17:41:28 +0000 Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id BBC34303EA26 for ; Fri, 19 Dec 2025 17:41:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E23DF32B992; Fri, 19 Dec 2025 17:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AdZW13Mm" X-Original-To: stable@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C74482F7AB0; Fri, 19 Dec 2025 17:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766166065; cv=none; b=XI0i5OAn/U6YPXaRrA/cwZuLW3SDoo7yNVf3wKiDYCp8ejNrDUtgeSC8l3b6/TKmAuikzLm0cmM/kvWZXDsN3IwT9/HU5XWvtSO2kuJ26cybk6QptJo2MRtMqOcZQ80OZHLNh032QBEpH58QUjIAI1WdJFBgQ7Uo11U/TgDfSRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766166065; c=relaxed/simple; bh=iDk5PDFyCbkxThYZSXCCggnIbQTec9fz3huwZNw1Nfg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=HiZxAw0DAT9SmadAZMhrh9ZxFMI8i7p5kBrO71xrheba+U08tzYyK+aFCoxSgDr6mKX6tExrpMVvHwkhD1j9TcyXN5ORuO8wY9+XlDB7nrW76FyJhKci7ttC5IOJZf5m0gm61G2vY/IFdSM459pPGP5GYgq3mJZBuTFQLBKjxfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spfole":"user","content":[{"type":"tool_result","content":"The user doesn't want to proceed with this tool use. The tool use was rejected (eg. if it was a file edit, the new_string was NOT written to the file). STOP what you are doing and wait for the user to tell you how to proceed.","is_error":true,"tool_use_id":"toolu_01WcasFto7hpULSVHdoLKCcS"}]},"uuid":"4f673ab6-f20c-4125-87e7-47843e19e432","timestamp":"2026-03-03T16:58:17.004Z","toolUseResult":"User rejected tool use","sourceToolAssistantUUID":"e3725c5a-081b-4c7e-812d-e73fd9419807"}