http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [213.196.21.55 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 5 From: Owen Gu When a UAS device is unplugged during data transfer, there is a probability of a system panic occurring. The root cause is an access to an invalid memory address during URB callback handling. Specifically, this happens when the dma_direct_unmap_sg() function is called within the usb_hcd_unmap_urb_for_dma() interface, but the sg->dma_address field is 0 and the sg data structure has already been freed. The SCSI driver sends transfer commands by invoking uas_queuecommand_lck() in uas.c, using the uas_submit_urbs() function to submit requests to USB. Within the uas_submit_urbs() implementation, three URBs (sense_urb, data_urb, and cmd_urb) are sequentially submitted. Device removal may occur at any point during uas_submit_urbs execution, which may result in URB submission failure. However, some URBs might have been successfully submitted before the failure, and uas_submit_urbs will return the -ENODEV error code in this case. The current error handling directly calls scsi_done(). In the SCSI driver, this eventually triggers scsi_complete() to invoke scsi_end_request() for releasing the sgtable. The successfully submitted URBs, when being unlinked to giveback, call usb_hcd_unmap_urb_for_dma() in hcd.c, leading to exceptions during sg unmapping operations since the sg data structure has already been freed. This patch modifies the error condition check in the uas_submit_urbs() function. When a UAS device is removed but one or more URBs have already been successfully submitted to USB, it avoids immediately invoking scsi_done() and save the cmnd to devinfo->cmnd array. If the successfully submitted URBs is completed before devinfo->resetting being set, then the scsi_done() function will be called within uas_try_complete() after all pending URB operations are finalized. Otherwise, the scsi_done() function will be called within uas_zap_pending(), which is executed after usb_kill_anchored_urbs(). The error handling only takes effect when uas_queuecommand_lck() calls uas_submit_urbs() and returns the error value -ENODEV . In this case, the device is disconnected, and the flow proceeds to uas_disconnect(), where uas_zap_pending() is invoked to call uas_try_complete(). Fixes: eb2a86ae8c54 ("USB: UAS: fix disconnect by unplugging a hub") Cc: stable@vger.kernel.org Signed-off-by: Yu Chen Signed-off-by: Owen Gu Acked-by: Oliver Neukum --- v4: Add the fix tag, cc stable and acked-by tag v3: Add some commit message. v2: Upon uas_submit_urbs() returning -ENODEV despite successful URB submission, the cmnd is added to the devinfo->cmnd array before exiting uas_queuecommand_lck(). https://lore.kernel.org/linux-usb/20251015153157.11870-1-guhuinan@xiaomi.com/ v1: https://lore.kernel.org/linux-usb/20250930045309.21588-1-guhuinan@xiaomi.com/ --- --- drivers/usb/storage/uas.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 03043d567fa1..02fe411567fa 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -698,6 +698,10 @@ static int uas_queuecommand_lck(struct scsi_cmnd *cmnd) * of queueing, no matter how fatal the error */ if (err == -ENODEV) { + if (cmdinfo->state & (COMMAND_INFLIGHT | DATA_IN_URB_INFLIGHT | + DATA_OUT_URB_INFLIGHT)) + goto out; + set_host_byte(cmnd, DID_NO_CONNECT); scsi_done(cmnd); goto zombie; @@ -711,6 +715,7 @@ static int uas_queuecommand_lck(struct scsi_cmnd *cmnd) uas_add_work(cmnd); } +out: devinfo->cmnd[idx] = cmnd; zombie: spin_unlock_irqrestore(&devinfo->lock, flags); -- 2.43.0 From - Thu Nov 20 13:43:41 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id WKhiC8INH2kFJAYAYBR5ng (envelope-from ) for ; Thu, 20 Nov 2025 12:46:58 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Thu, 20 Nov 2025 12:46:58 +0000 Received: from dfw.mirrors.kernel.org ([142.0.200.124]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vM43t-00000002LAO-3ucj for hi@josie.lol; Thu, 20 Nov 2025 12:46:58 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.mirrors.kernel.org (Postfix) with ESMTPS id 9ADB64E6169 for ; Thu, 20 Nov 2025 12:46:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A18971E885A; Thu, 20 Nov 2025 12:46:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o5kQVw/x" X-Original-To: stable@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2C21E766E; Thu, 20 Nov 2025 12:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763642761; cv=none; b=CMrhDkQUlkC5Ch9xkoin2E+4mw49K0YrESSYPRYdV0SF+Z3sr9yuqh5UIgzD55qgqMCHi/1pIZpvvgzxKx3GqCGJJiEum+H6qbWu/gwhh7IKgyJq5lUtF6LB3r64W25nwZ/PlyXAJQC+Rg+ly6gLVqEQUDenuVvqWKBG5NItggM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763642761; c=relaxed/simple; bh=rGS/XJMdl+I5LSrsc7S5CQODSW6RGFPxQQoPc1ctHlE=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=I+ql8hOuedJyCCJXmzLDGDO2jXDHFAIUUUM8ipGstHsHVXg8kF/a/OHFVjh1t3p2Hs2QNFrnAcATfZZhkYxCczG/Zu+STOH7hSTOuULg7y0vV424/tRKobNRYCLTBmN8zxmBpAxGdiKN/qrOUESe4uqr8A9HPsd3DUtLMpVyyXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o5kQVw/x; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EF95C116B1; Thu, 20 Nov 2025 12:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763642759; bh=rGS/XJMdl+I5LSrsc7S5CQODSW6RGFPxQQoPc1ctHlE=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=o5kQVw/x6HRnWVDE3ImzTQDDLZYVSexS/zgNAHYIagSUevhRsKUVjAFYCcVIQz/Qa xYDQMYYLdZxQvN6aylfPdzS0RmisybqoGdKlnMQT01vieRzi41Lb7mX1ELJ2ioSrQ+ 1z7yKmlejAu+AdIXR8jlapPGbvABow/DiCHhWDh9ySVFSA4Jixl4UMlNQ6u2Z85dZr qkezXe6lsxfop3KnDyklxGLZTJ0HLdy+/NjjczjelXxtHOGzSAr+EBtfuAuhuT8/Go lSLButun+87wtBF6mMCuHbxQt6aGV+2sKcVrwRuyHcOtNVsEFUE8Ch4YSMIdycYaOg Lg7yiB+4XGivQ== From: Niklas Cassel To: Hannes Reinecke , "Martin K. Petersen" , Damien Le Moal , Niklas Cassel Cc: Ilia Baryshnikov , stable@vger.kernel.org, linux-ide@vger.kernel.org In-Reply-To: <20251119141313.2220084-3-cassel@kernel.org> References: <20251119141313.2220084-3-cassel@kernel.org> Subject: Re: [PATCH 1/2] ata: