Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gPP1v5GndP5FXb13HOdbN1a5CDv2g0Eh88b9fz/P8N4=;
 b=kGzqPqL+tzAEfKa/8j4HFnz0jMZpvN2HalDqI4Sl2rPAnqqRxV6K869W3ho7iHEvyznzSi6rV7cvFKmEA729KgjEa0WpXPxxwyuBPJUall3FcZVsc+ma8nFaDZL8QICEEEYhD6JW+nPE/S6mRPIyn0LGV5NZcnVcrpXmMhijplA=
Date: Mon, 20 Oct 2025 12:32:24 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: Hugh Dickins <hughd@google.com>, akpm@linux-foundation.org,
        minchan@kernel.org, david@redhat.com, Liam.Howlett@oracle.com,
        rppt@kernel.org, pfalcato@suse.de, kernel-team@android.com,
        android-mm@google.com, stable@vger.kernel.org,
        SeongJae Park <sj@kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
        Kees Cook <kees@kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
        Suren Baghdasaryan <surenb@google.com>, Michal Hocko <mhocko@suse.com>,
        Jann Horn <jannh@google.com>, Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Valentin Schneider <vschneid@redhat.com>,
        Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v3 1/5] mm: fix off-by-one error in VMA count limit checks
Message-ID: <e4af1a65-5ad0-45d4-a888-8a78090bc5db@lucifer.local>
References: <20251013235259.589015-1-kaleshsingh@google.com>
 <20251013235259.589015-2-kaleshsingh@google.com>
 <144f3ee6-1a5f-57fc-d5f8-5ce54a3ac139@google.com>
 <098b030b-9d5a-4b1c-ab44-55bad474e70f@lucifer.local>
 <CAC_TJvct_KXyUuiO328MgrHnVPwvx995mEucvRPvNBa9zCekqw@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAC_TJvct_KXyUuiO328MgrHnVPwvx995mEucvRPvNBa9zCekqw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?rbtXr7w6JJkr+NG/uH6PaRup+JijAX8TTLF4SiEMlQZNdf5+f/xMQb83umbZ?=
 =?us-ascii?Q?JDnJNDHwIpCDWmxWRC2aZwB0sNU1XKt9qAGMtNBzxFb9bY7Vg90iUBoJfwd9?=
 =?us-ascii?Q?OeemhedaL0JoQUK2Q6OEazJeyUprPOsdHM4uqNWLGDHoP5w1Nu+gloMCnknR?=
 =?us-ascii?Q?3w+IGpNdiac2vRMcU0vbL+xsk9kY/P+y/EGnyQSJzVWSyhxgXW7N7goqawTI?=
 =?us-ascii?Q?EEZxchiKKTlq1vx7hnibDTbyJF1W0HkJNm0G+5ggA5tDI1Wu8W/spgs/IQyM?=
 =?us-ascii?Q?5ciQAZ9nEUE3bsoWV3FWVDMdyozh1r2eFN52O3S4T0g+9qAxbEueg6KXXmx7?=
 =?us-ascii?Q?iskOiou/tWF/bKjJwMc2n6RjJivqvIYxsUiGCqSpRyhVRGzqnhxnGxNv8An4?=
 =?us-ascii?Q?54PWnJYlj8B9UmDqCqUFseii6GiWzrMisd4wJZRHuYFjjk/mNpmY1p2NQGjl?=
 =?us-ascii?Q?qp3pzX7QOaBxWNjIThqJdlbbtAY3JbAC9nVa/5cpvO4X8548zOnp9N14JceI?=
 =?us-ascii?Q?eMjZqWs7hwhlMFAP+lqtwYESXg7hYmJh+V8QKko9k4PDJmBvzuoDF+yOax5w?=
 =?us-ascii?Q?o6OpiGK7Bx+vcUefnL7f2Q880ogTHVRBsnrEwzZF8Wka87ekpmbJnL4cugkA?=
 =?us-ascii?Q?xImuFQZopB8sYZqN1r32KP8wm9zOxPhfB0tVwE+vx1k943qxKtduXiRHB9Od?=
 =?us-ascii?Q?zzHzMwgvp+Ejz+thqoI5U5+2far1UW/siPIksb5YGSwXAlqlsla2Ox8518WE?=
 =?us-ascii?Q?6cFDh/BpdAS3+g4OtxPwht102rOnOYK0Ml1w+ZLWTRWhiupKwcwsehZawwMf?=
 =?us-ascii?Q?Ov8GytQovSlfEwZ9dH3e+m8HlVmIj990nlKPuwEse8aGwC+248aaFocDfzut?=
 =?us-ascii?Q?PQ7VYL7D+IyOlO4qn2Llv3fxAQuwS63+Bao2jYGjDMojtJco2Hx2+Ch38Y/H?=
 =?us-ascii?Q?ct3EeBqhVhC4wfUuAxHIRj3KSOK/wz6RDOmqgoATrw3uP0o76FB2I2PhcN93?=
 =?us-ascii?Q?nJ+YSvLNdrXV2x89Jk7UeAe36iAGEDHNCe9VPK6GRoCHoogFhBG6fryIdzaB?=
 =?us-ascii?Q?rVElpWdPl5/PAAix3f9uw4jfGkEVRW/0KYgRXkexa6F6dLcIIXOQTwC0wLZU?=
 =?us-ascii?Q?snkjifmzsU5057YJ/oYsegrzf7gZu5y/99X0Rw51riiv1rM8N0F5//GRtAaA?=
 =?us-ascii?Q?mGSGq4ly3Fi31HuLct7V7PhwLH40YhsjB63CZdrLZFSaBeBOxH3cS1YyKpV4?=
 =?us-ascii?Q?n06TB1VhSI9BBpaUgDNEQQZfA0dIk8ifHvciFG60DpaBlousLrvdF/ZHG8J2?=
 =?us-ascii?Q?TF+DkfaAdg6Olxz/Zpp/3m+0mNwmmkATGokrLLSnVBWNU76Ox9HVfl6yspVD?=
 =?us-ascii?Q?q7P62mOSiKH0QQ83r2ubfYg+p489oEHgYoUz1kH1KuCIeJWIQY8ge0N5bGiw?=
 =?us-ascii?Q?ltBgcWN+Nfu/e45tdgHJOiC6Ia9uNT5kGfsYD5aUuAHhQqUiFrZvmoUel78X?=
 =?us-ascii?Q?uXC/c3V6NaxSpsZ5VP5AHu0bDFnMkypLiH2Qw8QQw3GUAVNSlCiCqCxHW7P1?=
 =?us-ascii?Q?msyRfx9WIADXga2JXWPAj4+s5vnAhzvyotoWsjPNWWSs44KwX60j+aFL/MtM?=
 =?us-ascii?Q?iQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	F+ny+3PLlGJIIVsp9G9Peuk6oE2zrnqgcssNY800hAV2PiQNuJIXjslKJ3Fjj35/gB6Jph5/hW5S+C5FlZNa6UDi3b1AkJvJA7MDATI8216HjB+BtWkgN5XsreXvo3K9c/w7XB2a0Ed4B5FGGZimU66YO9H/wdq+kkYq5d5eAGGlZqM504bb6G5LzxFdCYSuPqQWVSWOJ73UQ11vMMHUPKf+8QY5zGLvGlEKc/K3tD3pQUV9kPZW7kNAQHD1oPS069e1Lc9Ahb7jwXDasMkd/sm9NSJhTK9WjNx6zL9Tn1KONLdo5Gou/+nsjDcA+V7K1jkPrP3x0DHqJsflRF3h1mdUog4JbTBLPZtJEiPvW9MT6yZPY7Eda/fTBsFiBrhyfnjvLycQEXAFKbGbUiBActnmNW0xxy7iiT+gasT811zgsxT+rAMdyQL09S6xMoBCFYmG/OfSlk0sX+ta+tWODtQfp6SWfqxyr595DOml1qVuXoF0cwz3TmZ1B46PY5Hm8ROypzYrZFgC+aon66mUzRwDzPoADXSrmsXqh9lAnW93yFB8fhwTn4MjCUSHJLdih5Uv2uUkNgyQa1fgYHE9M2epaeP3QU5zwMvKfghSVuQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 333c2dc0-0eb0-4ddc-c25b-08de0fcc595b
X-MS-Exchange-CrossTenant-AuthSource: BL4PR10MB8229.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2025 11:32:28.5547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KHXTkn0ozv1AkLQQDzkUSzuqXjtZk5tc7oyx05Ee2ZH806TrFEQGO5et8reG0kvMipQglpXirW62byL0h94vaDWs9beWbHngShHy1oK0q/U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6089
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40
 definitions=2025-10-20_02,2025-10-13_01,2025-03-28_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 mlxlogscore=994 bulkscore=0 malwarescore=0 mlxscore=0 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2510020000 definitions=main-2510200093
X-Proofpoint-GUID: do0ObVzZmvnyey1Z5fRPSkWg_MGuPuHO
X-Proofpoint-ORIG-GUID: do0ObVzZmvnyey1Z5fRPSkWg_MGuPuHO
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMyBTYWx0ZWRfX3TvQZ5Wc6p6L
 4FGzFZprvjTDMxal0nRxoN/yPNT00LN89n/XkSFgYw/4IdfrHfkXG0H9PWjr6rrSJNirFrni/RZ
 Bvhz1EwOrHdT2zSytMT7NCdXxTuMiPTN8ecOx3IT4Nmj9/xEFrXDcyNnnp4Lazped8dLf9LPPqx
 areZs0DXji5dPSsLmjDUFNCWM/Moe0DzIxw6Y2jegrDX2v4hd9cT+jdbicoRXiHqi7UO/9xwMEh
 nfJXd3dqgHQBpc6B5qW1pW5z3n69NwnpfmP4jpAi4GKnMFV4KQYfw2uOF03cX3w+qXziF5WNSfd
 jkByxDNYxGUixQZ/g5e9OpTED72I/y5MULPiaGnoqvCqPGeAtEm3zAcRKsqeAqfs1W8MOsxA4Ez
 Gxe0s9JcxJXOBc1olIY4fSKtkZP/kBt4BOGZN/CP9IT7iKVD4Js=
X-Authority-Analysis: v=2.4 cv=Nu7cssdJ c=1 sm=1 tr=0 ts=68f61dd1 b=1 cx=c_pps
 a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17
 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19
 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10
 a=x6icFKpwvdMA:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22
 a=TZoiOLDRoPF9d9RrMksA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:12092
X-DKIM: signer='oracle.com' status='pass' reason=''
DKIMCheck: Server passes DKIM test, 0 Spam score
X-DKIM: signer='oracle.onmicrosoft.com' status='pass' reason=''
X-Spam-Score: 0.4 (/)
X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has
 performed the tests listed below against this email.
 Information: https://mxroutedocs.com/directadmin/spamfilters/
 ---
 Content analysis details:   (0.4 points)
 ---
  pts rule name              description
 ---- ---------------------- -----------------------------------------
  1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
                             mail domains are different
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
                             valid
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
                             author's domain
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
SpamTally: Final spam score: 4

On Fri, Oct 17, 2025 at 02:41:00PM -0700, Kalesh Singh wrote:
>
> Hi all,
>
> Thanks, Lorenzo, for the feedback and support.
>
> The consensus from the discussion appears to be:
>
> - Drop this patch keeping the existing check lenient, but make it more
> obvious and clear that this is the intended behavior.
> - Keep the vma_count_remaining() or another helper and abstracts away
> the direct use of the global sysctl_max_map_count.
> - Keep the rename of map_count to vma_count
> - Keep the selftest and tracepoint patches, which are important for
> documenting the behavior and providing observability.
>
> If there are no objections, I'll plan to send out a new version of the series.
>
> Thanks,
> Kalesh
>

Ack, sounds good!


From - Mon Oct 20 11:35:08 2025
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <stable+bounces-188040-hi=josie.lol@vger.kernel.org>
Delivered-To: hi@josie.lol
Received: from witcher.mxrouting.net
	by witcher.mxrouting.net with LMTP
	id cFmCJ2ge9mg1iSMAYBR5ng
	(envelope-from <stable+bounces-188040-hi=josie.lol@vger.kernel.org>)
	for <hi@josie.lol>; Mon, 20 Oct 2025 11:35:04 +0000
Return-path: <stable+bounces-188040-hi=josie.lol@vger.kernel.org>
Envelope-to: hi@josie.lol
Delivery-date: Mon, 20 Oct 2025 11:35:04 +0000
Received: from dfw.mirrors.kernel.org ([142.0.200.124])
	by witcher.mxrouting.net with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.98)
	(envelope-from <stable+bounces-188040-hi=josie.lol@vger.kernel.org>)
	id 1vAoAK-0000000A4oZ-0EwH
	for hi@josie.lol;
	Mon, 20 Oct 2025 11:35:04 +0000
Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.mirrors.kernel.org (Postfix) with ESMTPS id 1380E4E5C9D
	for <hi@josie.lol>; Mon, 20 Oct 2025 11:35:03 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 9293F257431;
	Mon, 20 Oct 2025 11:35:02 +0000 (UTC)
X-Original-To: stable@vger.kernel.org
Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86F6523D7D2
	for <stable@vger.kernel.org>; Mon, 20 Oct 2025 11:35:00 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1760960102; cv=none; b=AGCQygyOLvHJhWJ821x4YGHfM7akOc/LKvKlzuDPPuih5xmjujbBWZ0CV2uXlD6f86h6pxT92b2ZnoSZULPVNF7w0MjyUtzT/eI7eEhf0gyWEVTuBkdLK1GQ3jOdrCT+cIb6U/ZRWgKeL5geY2qQLQP7KewjcncpXzh4iCWCCcI=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1760960102; c=relaxed/simple;
	bh=kDNU1VZRvLNKxiiKzrPuVBiAaDGRSLGk5fWfXxh6JGc=;
	h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=I/e9rshe6jV0A3CsXZQPL8Un9tr8dffTwe25706kkj2MynyBLhmUteDqt6Uiev4evYO/+asppl/8O8XPkwq1wBJ7qB/S9OCSMQFJWGvi/EOYH3SjrgaEtOxcB/brzvfxiqpJZIxgPMAzn6P/YS69clRLaA0V8SIL0FmVHzY9Goc=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
	by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <mkl@pengutronix.de>)
	id 1vAoA7-0002j5-Cu; Mon, 20 Oct 2025 13:34:51 +0200
Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org)
	by drehscheibe.grey.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <mkl@pengutronix.de>)
	id 1vAoA7-004XYw-01;
	Mon, 20 Oct 2025 13:34:51 +0200
Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.