nt=1 engine=8.22.0-2510240001 definitions=main-2511100118 X-DKIM: signer='qualcomm.com' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-DKIM: signer='oss.qualcomm.com' status='pass' reason='' X-Spam-Score: 0.4 (/) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (0.4 points) --- pts rule name description ---- ---------------------- ----------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: qualcomm.com] 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [139.178.88.99 listed in list.dnswl.org] 1.5 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager SpamTally: Final spam score: 4 On Wed, Nov 05, 2025 at 11:17:37AM +0530, Dikshita Agarwal wrote: > Improve the condition used to determine when input internal buffers need > to be reconfigured during streamon on the capture port. Previously, the > check relied on the INPUT_PAUSE sub-state, which was also being set > during seek operations. This led to input buffers being queued multiple > times to the firmware, causing session errors due to duplicate buffer > submissions. > > This change introduces a more accurate check using the FIRST_IPSC and > DRC sub-states to ensure that input buffer reconfiguration is triggered > only during resolution change scenarios, such as streamoff/on on the > capture port. This avoids duplicate buffer queuing during seek > operations. > > Fixes: c1f8b2cc72ec ("media: iris: handle streamoff/on from client in dynamic resolution change") > Cc: stable@vger.kernel.org > Reported-by: Val Packett > Closes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4700 > Signed-off-by: Dikshita Agarwal > --- > Changes in v3: > - Fixed the compilation issue > - Added stable@vger.kernel.org in Cc > - Link to v2: https://lore.kernel.org/r/20251104-iris-seek-fix-v2-1-c9dace39b43d@oss.qualcomm.com > > Changes in v2: > - Removed spurious space and addressed other comments (Nicolas) > - Remove the unnecessary initializations (Self) > - Link to v1: https://lore.kernel.org/r/20251103-iris-seek-fix-v1-1-6db5f5e17722@oss.qualcomm.com > --- > drivers/media/platform/qcom/iris/iris_common.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_common.c b/drivers/media/platform/qcom/iris/iris_common.c > index 9fc663bdaf3fc989fe1273b4d4280a87f68de85d..7f1c7fe144f707accc2e3da65ce37cd6d9dfeaff 100644 > --- a/drivers/media/platform/qcom/iris/iris_common.c > +++ b/drivers/media/platform/qcom/iris/iris_common.c > @@ -91,12 +91,14 @@ int iris_process_streamon_input(struct iris_inst *inst) > int iris_process_streamon_output(struct iris_inst *inst) > { > const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops; > - bool drain_active = false, drc_active = false; > enum iris_inst_sub_state clear_sub_state = 0; > + bool drain_active, drc_active, first_ipsc; > int ret = 0; > > iris_scale_power(inst); > > + first_ipsc = inst->sub_state & IRIS_INST_SUB_FIRST_IPSC; > + > drain_active = inst->sub_state & IRIS_INST_SUB_DRAIN && > inst->sub_state & IRIS_INST_SUB_DRAIN_LAST; > > @@ -108,7 +110,8 @@ int iris_process_streamon_output(struct iris_inst *inst) > else if (drain_active) > clear_sub_state = IRIS_INST_SUB_DRAIN | IRIS_INST_SUB_DRAIN_LAST; > > - if (inst->domain == DECODER && inst->sub_state & IRIS_INST_SUB_INPUT_PAUSE) { > + /* Input internal buffer reconfiguration required in case of resolution change */ > + if (first_ipsc || drc_active) { Another question: can this now result in PIPE being sent for the ENCODER instance? > ret = iris_alloc_and_queue_input_int_bufs(inst); > if (ret) > return ret; > > --- > base-commit: 163917839c0eea3bdfe3620f27f617a55fd76302 > change-id: 20251103-iris-seek-fix-7a25af22fa52 > > Best regards, > -- > Dikshita Agarwal > -- With best wishes Dmitry From - Mon Nov 10 13:45:19 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id mGfXD2vsEWkBdhQAYBR5ng (envelope-from ) for ; Mon, 10 Nov 2025 13:45:15 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Mon, 10 Nov 2025 13:45:15 +0000 Received: from am.mirrors.kernel.org ([147.75.80.249]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vISCo-00000005nCc-3LB7 for hi@josie.lol; Mon, 10 Nov 2025 13:45:15 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 791FE1882D4C for ; Mon, 10 Nov 2025 13:45:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 41CC93115B5; Mon, 10 Nov 2025 13:45:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nJRJnoHT" X-Original-To: linux-s390@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06E1A30E0C5; Mon, 10 Nov 2025 13:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762782309; cv=none; b=J+Ym0LAA5oRBo4e+cJkXLI3xrjF6kX1MGWi53H1IGQkZAFdOkVaEtmJuMjRQb6aiDePif7GN0cwIbqHlMockZo2PEc7vkU+XoJCclTGdF78EZc63zTUmLUHq3jvXKbmJBfDW/IxSAzIqscs/GPVZvWrqrgN2uT5G1DKYj7miw5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762782309; c=relaxed/simple; bh=K1xogRmcdnJHCvjWGY+Er/5mR9phjWmkoC/mTpkqq+Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XBOnXyO6mpRXeUuvr70iBH2Yyaeuumh3auWYopNX0jxvbcstdPSvCQNpr0nct2QYRfkjfO9x29x6Pc6c5a6sZ9ryy4oEzv7bF8mzRP8BSmyDsLaEiGltX16IbYcSLAzhFZm66rJZskquyRz7qWcLa/ODVI/GdPmDHO1xFcOLVuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nJRJnoHT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA5E7C4C