DHEEzqFAseqx1VMPiiixeu0GzDT0ztuC0E6K6 HXvc9etRm9K+Kfme2p3YPXOtamnzXnO4UPe6QEBpFfj8VWRJKgnghUfq5SggvC4x8N UTymRzOeKwUyxxevZvjYO7LiX8WJmZNVZt5P5JSgVASRoHPv0HTEenu69ELlPyOm12 vlQCDNJbwPIrLOT/+RHu8TXrz08NGiS8IkJIEr5syqFEhFOQ0l82dAjXgzd8iviUcH LNGhdI42I421yxYIGngpyRj1RYM6a7lQUTpBLKMQAEqU5eavAC+9XPnA7HmaCJlB91 NbeXBTprGPMBw== Date: Mon, 10 Nov 2025 16:02:11 +0200 From: Leon Romanovsky To: Gerd Bayer Cc: Bjorn Helgaas , Jay Cornwall , Felix Kuehling , Niklas Schnelle , Alexander Schmidt , linux-s390@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] PCI: AtomicOps: Define valid root port capabilities Message-ID: <20251110140211.GK15456@unreal> References: <20251110-fix_pciatops-v1-0-edc58a57b62e@linux.ibm.com> <20251110-fix_pciatops-v1-1-edc58a57b62e@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251110-fix_pciatops-v1-1-edc58a57b62e@linux.ibm.com> X-DKIM: signer='kernel.org' status='pass' reason='' DKIMCheck: Server passes DKIM test, 0 Spam score X-Spam-Score: -1.2 (-) X-Spam-Report: Spam detection software, running on the system "witcher.mxrouting.net", has performed the tests listed below against this email. Information: https://mxroutedocs.com/directadmin/spamfilters/ --- Content analysis details: (-1.2 points) --- pts rule name description ---- ---------------------- ----------------------------------------- -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [142.0.200.124 listed in list.dnswl.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender SpamTally: Final spam score: -11 On Mon, Nov 10, 2025 at 02:25:05PM +0100, Gerd Bayer wrote: > Provide the two combinations of Atomic Op Completion size attributes > that a root port may support per PCIe Spec 7.0 section 6.15.3.1. - > besides the trivial "No support" - as two new defines. > > Change documentation of pci_enable_atomic_ops_to_root() that these are > the only ones that should be used. Also, spell out that all requested > capabilities need to be supported at the root port for enable to > succeed. Also emphasize that on success, this sets AtomicOpsCtl:ReqEn to > 1, and leaves it untouched in case of failure. > > Suggested-by: Leon Romanovsky > Signed-off-by: Gerd Bayer > --- > drivers/pci/pci.c | 13 +++++++------ > include/uapi/linux/pci_regs.h | 8 ++++++++ > 2 files changed, 15 insertions(+), 6 deletions(-) <...> > +/* PCIe spec 7.0 6.15.3.1: Root ports may support one of 2 sets of Atomic Ops */ > +#define PCI_EXP_ROOT_PORT_ATOMIC_BASE \ > + (PCI_EXP_DEVCAP2_ATOMIC_COMP32 | \ > + PCI_EXP_DEVCAP2_ATOMIC_COMP64) > +#define PCI_EXP_ROOT_PORT_ATOMIC_FULL \ > + (PCI_EXP_DEVCAP2_ATOMIC_COMP32 | \ > + PCI_EXP_DEVCAP2_ATOMIC_COMP64 | \ > + PCI_EXP_DEVCAP2_ATOMIC_COMP128) Thanks for doing this. From - Mon Nov 10 14:07:48 2025 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: hi@josie.lol Received: from witcher.mxrouting.net by witcher.mxrouting.net with LMTP id sKAuJrDxEWmXohYAYBR5ng (envelope-from ) for ; Mon, 10 Nov 2025 14:07:44 +0000 Return-path: Envelope-to: hi@josie.lol Delivery-date: Mon, 10 Nov 2025 14:07:44 +0000 Received: from ams.mirrors.kernel.org ([213.196.21.55]) by witcher.mxrouting.net with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1vISYa-00000006XmC-0JPL for hi@josie.lol; Mon, 10 Nov 2025 14:07:44 +0000 Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.mirrors.kernel.org (Postfix) with ESMTPS id B4B7F343E12 for ; Mon, 10 Nov 2025 14:07:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F150530C376; Mon, 10 Nov 2025 14:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="wdHhURlI" X-Original-To: stable@vger.kernel.org Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010060.outbound.protection.outlook.com [52.101.193.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09FD622256B; Mon, 10 Nov 2025 14:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.60 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762783658; cv=fail; b=CZa14R0hj8f+HSmh/gxCFLpzm9vgNqT02N8JZKMOZa1Y5VmciBIRuRTjUxITFHVP8VmtvMMoUjFhsBQm9WluMQeya9WasFIl85kVbIrMwPWvs6FYtsi5cFQe0niF6Zhp243/ZLKkpP1wAaK5K7OL0upOcjQPI5cECOuysr+ZoU0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762783658; c=relaxed/simple; bh=HHKkh+gRVCLahjDLjtOjnxBqVMRfD/HVnfkZlEIT6WI=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=NcCg/2cXXDIZlV9X6EEauHUpGEuA/7WM2lvL9m7SzIDFp6GpNQx/dz3mVxE8g0OQw+VOWjTE7/y5peXPK8NKWTXYcY6yxrwiw0hDdwUVoH7/plMzy6fdyCUV8Q5c7u8zS6rtv42cFjS3EpHMVYS5N97UzwvQU914soSTCfAsep4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=wdHhURlI; arc=fail smtp.client-ip=52.101.193.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H8TYX4H9NZDsTb/ZY/pMZNnE1RGS6yNe9w5fUiN9gid05Ftkmw5JsPh3fQk5ucUiRDEdVZAP9e6bmBZcMl8fObMqr+oGuT3LLVAiQrRIwwc34477H14UDWGjdpv4hVVvf+Hk64VlOoB2hfb4dB0rGmjaJOvMlABg7v4iU1oeKFyS6SrrpciLZT2wnh06F2bzOUz24nex1ir7qjMs0tcHcYONEEYXOiMbLUsgQb+M4GD88Wa7c3SdQSdTBxREG6SpyY8bKqR44MejOMRRcRb658a5tgvu8M7Tx6K7IXVQMZmYjHli8tIr+epvfDynCei1pwM3mP6nFffNVOec6aPEgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ba9mIJEbdNiJ7qNuUI4ONcvd5pqBELygQtSH7COPXY=; b=ebzo7AtNamth5wimwl1pq7ZChFl2maR5I/Hxhheukqv+9KK5gSoR2T0krnTUaWKzTdAo+poKDgCWZeMHpGGlhy6cFfvPPK0KM7pn2OBLzzEy